Skip to content

Commit 8d1e52f

Browse files
Merge pull request #5215 from microsoft/track2/asc/2-deployment
migrate to track2 based azure-toolkit-springcloud-lib for deployment
2 parents 226840b + b97637b commit 8d1e52f

File tree

4 files changed

+19
-256
lines changed

4 files changed

+19
-256
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/SpringCloudUtils.java

Lines changed: 0 additions & 152 deletions
This file was deleted.

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/deplolyment/SpringCloudDeploymentConfigurationPanel.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import com.intellij.openapi.project.Project;
1212
import com.intellij.uiDesigner.core.GridConstraints;
1313
import com.intellij.uiDesigner.core.GridLayoutManager;
14-
import com.microsoft.azure.management.appplatform.v2020_07_01.RuntimeVersion;
1514
import com.microsoft.azure.management.resources.Subscription;
1615
import com.microsoft.azure.toolkit.intellij.appservice.subscription.SubscriptionComboBox;
1716
import com.microsoft.azure.toolkit.intellij.common.AzureArtifact;
@@ -22,12 +21,12 @@
2221
import com.microsoft.azure.toolkit.intellij.common.EnvironmentVariableTable;
2322
import com.microsoft.azure.toolkit.intellij.springcloud.component.SpringCloudAppComboBox;
2423
import com.microsoft.azure.toolkit.intellij.springcloud.component.SpringCloudClusterComboBox;
25-
import com.microsoft.azure.toolkit.lib.appservice.Platform;
2624
import com.microsoft.azure.toolkit.lib.common.form.AzureFormInput;
2725
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudApp;
2826
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudCluster;
2927
import com.microsoft.azure.toolkit.lib.springcloud.config.SpringCloudAppConfig;
3028
import com.microsoft.azure.toolkit.lib.springcloud.config.SpringCloudDeploymentConfig;
29+
import com.microsoft.azure.toolkit.lib.springcloud.model.SpringCloudJavaVersion;
3130
import com.microsoft.azuretools.azurecommons.helpers.Nullable;
3231
import com.microsoft.intellij.util.BeforeRunTaskUtils;
3332
import lombok.Getter;
@@ -136,7 +135,7 @@ public void setData(SpringCloudAppConfig appConfig) {
136135
.ifPresent((id -> this.selectorCluster.setValue(new ItemReference<>(id, SpringCloudCluster::name))));
137136
Optional.ofNullable(appConfig.getAppName())
138137
.ifPresent((id -> this.selectorApp.setValue(new ItemReference<>(id, SpringCloudApp::name))));
139-
final boolean useJava11 = StringUtils.equalsIgnoreCase(appConfig.getRuntimeVersion(), RuntimeVersion.JAVA_11.toString());
138+
final boolean useJava11 = StringUtils.equalsIgnoreCase(appConfig.getRuntimeVersion(), SpringCloudJavaVersion.JAVA_11);
140139
this.useJava11.setSelected(useJava11);
141140
this.useJava8.setSelected(!useJava11);
142141
final boolean enableStorage = deploymentConfig.isEnablePersistentStorage();
@@ -162,12 +161,12 @@ public SpringCloudAppConfig getData() {
162161

163162
public SpringCloudAppConfig getData(SpringCloudAppConfig appConfig) {
164163
final SpringCloudDeploymentConfig deploymentConfig = appConfig.getDeployment();
165-
final RuntimeVersion javaVersion = this.useJava11.isSelected() ? RuntimeVersion.JAVA_11 : RuntimeVersion.JAVA_8;
164+
final String javaVersion = this.useJava11.isSelected() ? SpringCloudJavaVersion.JAVA_11 : SpringCloudJavaVersion.JAVA_8;
166165
appConfig.setSubscriptionId(this.selectorSubscription.getValue().subscriptionId());
167166
appConfig.setClusterName(this.selectorCluster.getValue().name());
168167
appConfig.setAppName(this.selectorApp.getValue().name());
169168
appConfig.setIsPublic(enablePublic.isSelected());
170-
appConfig.setRuntimeVersion(javaVersion.toString());
169+
appConfig.setRuntimeVersion(javaVersion);
171170
deploymentConfig.setCpu(Optional.ofNullable(this.cbCPU.getSelectedItem()).map(o -> Integer.parseInt((String) o)).orElse(1));
172171
deploymentConfig.setMemoryInGB(Optional.ofNullable(this.cbMemory.getSelectedItem()).map(o -> Integer.parseInt((String) o)).orElse(1));
173172
deploymentConfig.setInstanceCount(Optional.ofNullable(this.cbInstanceCount.getSelectedItem()).map(o -> Integer.parseInt((String) o)).orElse(1));

0 commit comments

Comments
 (0)