Skip to content

Commit 992b471

Browse files
Merge pull request #9534 from microsoft/hanli/fixes-202410
Resolve issues in end game bits
2 parents 25057ce + 8e3aafe commit 992b471

File tree

3 files changed

+20
-14
lines changed
  • PluginsAndFeatures/azure-toolkit-for-intellij
    • azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/appservice/task
    • azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/action
    • azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/fileexplorer

3 files changed

+20
-14
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/appservice/task/CreateWebAppTask.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ public void execute() throws Exception {
5252
webAppConfig.subscriptionId(subscription.getId());
5353
webAppConfig.runtime(RuntimeConfig.fromRuntime(WebAppRuntime.getDefaultJavaseRuntime()));
5454

55-
final String rgName = Utils.generateRandomResourceName(String.format("rg-%s", name), 90);
56-
webAppConfig.resourceGroup(rgName);
5755
final WebAppBase<?, ?, ?> webApp = WebAppService.getInstance().createWebApp(webAppConfig);
5856
context.applyResult(WEBAPP_ID, webApp.getId());
5957
context.applyResult(RESOURCE_GROUP, webApp.getResourceGroupName());

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/action/SSHIntoWebAppAction.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class SSHIntoWebAppAction {
4747
private static final String WEB_APP_DOCKER_PREFIX = "DOCKER|";
4848
private static final String CMD_SSH_TO_LOCAL_PROXY =
4949
"ssh -o StrictHostKeyChecking=no -o \"UserKnownHostsFile /dev/null\" -o \"LogLevel ERROR\" %[email protected] -p %d";
50-
50+
private static final Integer TERMINAL_MAX_SIZE = 1024 * 8;
5151
private static final String WEBAPP_TERMINAL_TABLE_NAME = "SSH - %s";
5252
private static final String RESOURCE_GROUP_PATH_PREFIX = "resourceGroups/";
5353
private static final String RESOURCE_ELEMENT_PATTERN = "[^/]+";
@@ -131,12 +131,14 @@ private static boolean waitForInputPassword(TtyConnector connector) throws Illeg
131131
final int interval = 500;
132132
final int times = 30000 / interval;
133133
while (count++ < times) {
134-
final AbstractList<Byte> outputCache = (AbstractList<Byte>) FieldUtils.readField(connector, "outputCache", true);
135-
Byte[] bytes = new Byte[outputCache.size()];
136-
bytes = outputCache.toArray(bytes);
137-
final byte[] myBuf = ArrayUtils.toPrimitive(bytes);
138-
if (myBuf != null && new String(myBuf, StandardCharsets.UTF_8).contains("password:")) {
139-
return true;
134+
try {
135+
final char[] result = new char[TERMINAL_MAX_SIZE];
136+
connector.read(result, 0, TERMINAL_MAX_SIZE -1 );
137+
if (new String(result).contains("password:")) {
138+
return true;
139+
}
140+
} catch (final IOException ignore) {
141+
continue;
140142
}
141143
Thread.sleep(interval);
142144
}

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/fileexplorer/VirtualFileActions.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ public void beforeFileClosed(FileEditorManager source, VirtualFile file) {
131131

132132
public static VirtualFile getVirtualFile(String fileId, FileEditorManager manager) {
133133
return Arrays.stream(manager.getOpenFiles())
134-
.filter(f -> StringUtils.equals(f.getUserData(FILE_ID), fileId))
135-
.findAny().orElse(null);
134+
.filter(f -> StringUtils.equals(f.getUserData(FILE_ID), fileId))
135+
.findAny().orElse(null);
136136
}
137137

138138
public static VirtualFile createVirtualFile(String fileId, String fileName, File file, FileEditorManager manager) {
139139
return Arrays.stream(manager.getOpenFiles())
140-
.filter(f -> StringUtils.equals(f.getUserData(FILE_ID), fileId))
141-
.findAny().orElse(createTempVirtualFile(fileId, fileName, file, manager));
140+
.filter(f -> StringUtils.equals(f.getUserData(FILE_ID), fileId))
141+
.findAny().orElse(createTempVirtualFile(fileId, fileName, file, manager));
142142
}
143143

144144
@SneakyThrows
@@ -147,7 +147,13 @@ private static VirtualFile createTempVirtualFile(final String fileId, final Stri
147147
final VirtualFile virtualFile = new RemoteVirtualFile(origin, fileName);
148148
virtualFile.setCharset(StandardCharsets.UTF_8);
149149
virtualFile.putUserData(FILE_ID, fileId);
150-
virtualFile.setWritable(true);
150+
AzureTaskManager.getInstance().runLater(() -> {
151+
try {
152+
WriteAction.run(() -> virtualFile.setWritable(true));
153+
} catch (IOException e) {
154+
throw new RuntimeException(e);
155+
}
156+
});
151157
return virtualFile;
152158
}
153159

0 commit comments

Comments
 (0)