Merge pull request #5250 from microsoft/eventbus/springcloud

use AzureEventBus to sync status among different views(azure explorer, properties view, run configuration...)

Author: wangmingliang-ms

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/properties/AzureSlider.form

@@ -13,15 +13,15 @@
           <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
         </constraints>
         <properties>
-          <majorTickSpacing value="50"/>
-          <maximum value="500"/>
+          <majorTickSpacing value="5"/>
+          <maximum value="25"/>
           <minimum value="0"/>
-          <minorTickSpacing value="10"/>
+          <minorTickSpacing value="1"/>
           <paintLabels value="true"/>
           <paintTicks value="true"/>
           <paintTrack value="true"/>
           <snapToTicks value="false"/>
-          <value value="50"/>
+          <value value="1"/>
           <valueIsAdjusting value="true"/>
         </properties>
       </component>

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/properties/AzureSlider.java

@@ -62,6 +62,10 @@ public int getValue() {
         return (int) this.numValue.getValue();
     }
 
+    public void prepare() {
+        this.numSlider.setLabelTable(null);
+    }
+
     private void createUIComponents() {
         this.numValue = new JBIntSpinner(1, 0, 10);
     }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/properties/SpringCloudAppPanel.java

@@ -182,6 +182,7 @@ private void updateForm() {
         numCpuModel.addAll(IntStream.range(1, 1 + (basic ? 1 : 4)).boxed().collect(Collectors.toList()));
         numMemoryModel.removeAllElements();
         numMemoryModel.addAll(IntStream.range(1, 1 + (basic ? 2 : 8)).boxed().collect(Collectors.toList()));
+        this.numInstance.prepare();
         this.numInstance.setMaximum(basic ? 25 : 500);
         this.numInstance.setMajorTickSpacing(basic ? 5 : 50);
         this.numInstance.setMinorTickSpacing(basic ? 1 : 10);

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/properties/SpringCloudAppPropertiesEditor.java

@@ -8,6 +8,7 @@
 import com.intellij.openapi.project.Project;
 import com.intellij.ui.components.ActionLink;
 import com.microsoft.azure.toolkit.intellij.common.BaseEditor;
+import com.microsoft.azure.toolkit.lib.common.event.AzureEventBus;
 import com.microsoft.azure.toolkit.lib.common.messager.AzureMessager;
 import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
 import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudApp;
@@ -112,15 +113,24 @@ private void initListeners() {
             new DeploySpringCloudAppTask(this.appPanel.getData()).execute();
             this.refresh();
         }));
-        // TODO: add listener: update view on app updated and close editor on app deleted.
+        AzureEventBus.after("springcloud|app.remove", (SpringCloudApp app) -> {
+            if (this.app.name().equals(app.name())) {
+                this.closeEditor();
+            }
+        });
+        AzureEventBus.after("springcloud|app.update", (SpringCloudApp app) -> {
+            if (this.app.name().equals(app.name())) {
+                this.refresh();
+            }
+        });
     }
 
     private void refresh() {
         this.reset.setVisible(false);
         this.saveButton.setEnabled(false);
         AzureTaskManager.getInstance().runLater(() -> {
             final String refreshTitle = String.format("Refreshing app(%s)...", Objects.requireNonNull(this.app).name());
-            AzureTaskManager.getInstance().runInModal(refreshTitle, () -> {
+            AzureTaskManager.getInstance().runInBackground(refreshTitle, () -> {
                 this.appPanel.refresh();
                 this.resetToolbar();
             });

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/intellij/util/ValidationUtils.java

@@ -17,6 +17,7 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -137,10 +138,8 @@ public static void validateSpringCloudAppName(final String name, final SpringClo
             throw new IllegalArgumentException(message("springCloud.app.name.validate.empty"));
         } else if (!name.matches(SPRING_CLOUD_APP_NAME_PATTERN)) {
             throw new IllegalArgumentException(message("springCloud.app.name.validate.invalid"));
-        } else {
-            if (cluster.app(name).exists()) {
-                throw new IllegalArgumentException(message("springCloud.app.name.validate.exist", name));
-            }
+        } else if (Objects.nonNull(cluster) && cluster.app(name).exists()) {
+            throw new IllegalArgumentException(message("springCloud.app.name.validate.exist", name));
         }
     }
 

Utils/azure-explorer-common/src/com/microsoft/tooling/msservices/serviceexplorer/azure/springcloud/SpringCloudAppNode.java

@@ -6,6 +6,7 @@
 package com.microsoft.tooling.msservices.serviceexplorer.azure.springcloud;
 
 import com.microsoft.azure.management.appplatform.v2020_07_01.DeploymentResourceStatus;
+import com.microsoft.azure.toolkit.lib.common.event.AzureEventBus;
 import com.microsoft.azure.toolkit.lib.common.operation.AzureOperation;
 import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudApp;
 import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudDeployment;
@@ -62,6 +63,16 @@ public SpringCloudAppNode(SpringCloudApp app, SpringCloudNode parent) {
                 fillData(event.getApp(), event.getDeployment());
             }
         }, this.app.entity().getId());
+        AzureEventBus.after("springcloud|app.start", this::onAppStatusChanged);
+        AzureEventBus.after("springcloud|app.stop", this::onAppStatusChanged);
+        AzureEventBus.after("springcloud|app.restart", this::onAppStatusChanged);
+    }
+
+    public void onAppStatusChanged(SpringCloudApp app) {
+        if (this.app.name().equals(app.name())) {
+            this.app.refresh();
+            this.fillData(this.app, this.app.activeDeployment());
+        }
     }
 
     @Override

Utils/azure-explorer-common/src/com/microsoft/tooling/msservices/serviceexplorer/azure/springcloud/SpringCloudNode.java

@@ -6,6 +6,7 @@
 package com.microsoft.tooling.msservices.serviceexplorer.azure.springcloud;
 
 import com.microsoft.azure.toolkit.lib.Azure;
+import com.microsoft.azure.toolkit.lib.common.event.AzureEventBus;
 import com.microsoft.azure.toolkit.lib.springcloud.AzureSpringCloud;
 import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudApp;
 import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudCluster;
@@ -35,6 +36,14 @@ public SpringCloudNode(AzureRefreshableNode parent, SpringCloudCluster cluster)
         super(cluster.id(), cluster.name(), parent, null, true);
         this.cluster = cluster;
         loadActions();
+        AzureEventBus.after("springcloud|app.create", this::onAppCreatedOrRemoved);
+        AzureEventBus.after("springcloud|app.remove", this::onAppCreatedOrRemoved);
+    }
+
+    public void onAppCreatedOrRemoved(SpringCloudApp app) {
+        if (this.cluster.name().equals(app.getCluster().name())) {
+            refreshItems();
+        }
     }
 
     @Override