Improve the validation implemetation (#2939)

Author: zmssp

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.webapp/src/com/microsoft/azuretools/webapp/ui/AppServiceCreateDialog.java

@@ -1093,13 +1093,13 @@ protected void okPressed() {
         properties.put("runtime",
             model.getOS() == OperatingSystem.LINUX ? "Linux-" + model.getLinuxRuntime().toString()
                 : "windows-" + model.getWebContainer());
+        if (!validated()) {
+            return;
+        }
         try {
             ProgressDialog.get(this.getShell(), CREATE_APP_SERVICE_PROGRESS_TITLE).run(true, true,
                 (monitor) -> {
                     monitor.beginTask(VALIDATING_FORM_FIELDS, IProgressMonitor.UNKNOWN);
-                    if (!validated()) {
-                        return;
-                    }
                     monitor.setTaskName(CREATING_APP_SERVICE);
                     if (monitor.isCanceled()) {
                         AzureModel.getInstance().setResourceGroupToWebAppMap(null);
@@ -1171,18 +1171,12 @@ protected boolean validated() {
                     return false;
                 }
                 // App service plan name must be unique in each subscription
-                List<ResourceGroup> rgl = AzureMvpModel.getInstance()
-                    .getResourceGroupsBySubscriptionId(model.getSubscriptionId());
-                for (ResourceGroup rg : rgl) {
-                    List<AppServicePlan> aspl = AzureWebAppMvpModel.getInstance()
-                        .listAppServicePlanBySubscriptionIdAndResourceGroupName(model.getSubscriptionId(),
-                            rg.name());
-                    for (AppServicePlan asp : aspl) {
-                        if (asp != null
-                            && asp.name().toLowerCase().equals(model.getAppServicePlanName().toLowerCase())) {
-                            setError(dec_textAppSevicePlanName, APP_SERVICE_PLAN_NAME_MUST_UNUQUE);
-                            return false;
-                        }
+                List<AppServicePlan> appServicePlans = getAppservicePlanBySID(model.getSubscriptionId());
+                for (AppServicePlan asp : appServicePlans) {
+                    if (asp != null
+                        && asp.name().toLowerCase().equals(model.getAppServicePlanName().toLowerCase())) {
+                        setError(dec_textAppSevicePlanName, APP_SERVICE_PLAN_NAME_MUST_UNUQUE);
+                        return false;
                     }
                 }
             }

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.webapp/src/com/microsoft/azuretools/webapp/ui/WebAppDeployDialog.java

@@ -1047,7 +1047,7 @@ private WebAppBase getRealWebApp(WebAppDetails webAppDetails, Object parent, IPr
         String deploymentName) {
         if (isDeployToSlot) {
             if (isCreateNewSlot) {
-                String message = "Create Deployment Slot...";
+                String message = "Creating Deployment Slot...";
                 monitor.setTaskName(message);
                 AzureDeploymentProgressNotification.notifyProgress(parent, deploymentName, "", 30, message);
                 return createDeploymentSlot(webAppDetails);