use cache to simplify implementation.

Author: wangmingliang-ms

PluginsAndFeatures/azure-toolkit-for-intellij/azure-sdk-reference-book/build.gradle

@@ -1,6 +1,7 @@
 plugins {
     id 'java'
     id "org.jetbrains.intellij"
+    id "io.freefair.aspectj.post-compile-weaving"
 }
 
 group 'com.microsoft.azuretools'
@@ -26,6 +27,8 @@ dependencies {
         exclude group: "com.fasterxml.jackson", module: "jackson-bom"
     }
 
-    implementation project(':azure-intellij-plugin-lib')
-    implementation "com.microsoft.azure:azure-toolkit-common-lib:0.5.0-SNAPSHOT"
+    compile project(':azure-intellij-plugin-lib')
+    compile "com.microsoft.azure:azure-toolkit-common-lib:0.5.0-SNAPSHOT"
+
+    aspect "com.microsoft.azure:azure-toolkit-common-lib:0.5.0-SNAPSHOT"
 }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-sdk-reference-book/src/main/java/com/microsoft/azure/toolkit/intellij/azuresdk/dependencesurvey/activity/AzurePreloadingActivity.java

@@ -37,6 +37,7 @@
 import org.apache.commons.lang3.StringUtils;
 import org.jetbrains.annotations.NotNull;
 
+import javax.annotation.Nonnull;
 import javax.swing.*;
 import javax.swing.tree.DefaultMutableTreeNode;
 import javax.swing.tree.DefaultTreeModel;
@@ -95,11 +96,9 @@ private void filter(final String text) {
         this.loadData(this.services, filters);
     }
 
-    public void refresh() {
-        final AzureSdkLibraryService service = AzureSdkLibraryService.getInstance();
+    public void refresh(Boolean... force) {
         try {
-            service.reloadAzureSDKArtifacts();
-            this.services = service.getServices();
+            this.services = AzureSdkLibraryService.loadAzureSdkServices(force);
             this.filter.debounce();
             Optional.ofNullable(this.lastNodePath).ifPresent(p -> TreeUtil.selectPath(this.tree, p));
         } catch (final IOException e) {
@@ -176,7 +175,7 @@ public final void actionPerformed(@NotNull final AnActionEvent e) {
             this.loading = true;
             ActivityTracker.getInstance().inc();
             AzureTaskManager.getInstance().runLater(() -> {
-                AzureSdkTreePanel.this.refresh();
+                AzureSdkTreePanel.this.reload();
                 this.loading = false;
             });
         }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-sdk-reference-book/src/main/java/com/microsoft/azure/toolkit/intellij/azuresdk/referencebook/AzureSdkTreePanel.java

@@ -11,36 +11,21 @@
 import com.fasterxml.jackson.databind.ObjectReader;
 import com.fasterxml.jackson.dataformat.yaml.YAMLMapper;
 import com.microsoft.azure.toolkit.intellij.azuresdk.model.AzureSdkServiceEntity;
+import com.microsoft.azure.toolkit.lib.common.cache.Cacheable;
 
 import java.io.IOException;
 import java.net.URL;
-import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 
 public class AzureSdkLibraryService {
     private static final ObjectMapper mapper = new YAMLMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
     private static final String SDK_METADATA_URL = "https://raw.githubusercontent.com/Azure/azure-sdk-for-java/master/sdk/spring/spring-reference.yml";
-    private List<AzureSdkServiceEntity> services = new ArrayList<>();
 
-    public static AzureSdkLibraryService getInstance() {
-        return Holder.instance;
-    }
-
-    public List<AzureSdkServiceEntity> getServices() {
-        return Collections.unmodifiableList(services);
-    }
-
-    public void reloadAzureSDKArtifacts() throws IOException {
+    @Cacheable(value = "sdk-services", condition = "!(force&&force[0])")
+    public static List<AzureSdkServiceEntity> loadAzureSdkServices(boolean... force) throws IOException {
         final URL destination = new URL(SDK_METADATA_URL);
         final ObjectReader reader = mapper.readerFor(AzureSdkServiceEntity.class);
         final MappingIterator<AzureSdkServiceEntity> data = reader.readValues(destination);
-        synchronized (this) {
-            this.services = data.readAll();
-        }
-    }
-
-    private static class Holder {
-        private static final AzureSdkLibraryService instance = new AzureSdkLibraryService();
+        return data.readAll();
     }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-sdk-reference-book/src/main/java/com/microsoft/azure/toolkit/intellij/azuresdk/service/AzureSdkLibraryService.java

@@ -1,9 +1,6 @@
 <idea-plugin>
     <extensionPoints>
     </extensionPoints>
-    <extensions defaultExtensionNs="com.intellij">
-        <preloadingActivity implementation="com.microsoft.azure.toolkit.intellij.azuresdk.dependencesurvey.activity.AzurePreloadingActivity"/>
-    </extensions>
     <actions>
         <action id="AzureToolkit.OpenSdkReferenceBook"
                 class="com.microsoft.azure.toolkit.intellij.azuresdk.referencebook.OpenReferenceBookAction"

PluginsAndFeatures/azure-toolkit-for-intellij/azure-sdk-reference-book/src/main/resources/META-INF/azure-sdk-reference-book.xml

@@ -98,8 +98,8 @@ configurations {
 apply plugin: 'java'
 
 dependencies {
-    implementation project(':azure-intellij-plugin-lib')
-    implementation project(':azure-sdk-reference-book')
+    compile project(':azure-intellij-plugin-lib')
+    compile project(':azure-sdk-reference-book')
     compile 'com.microsoft.sqlserver:mssql-jdbc:6.4.0.jre8'
     compile 'commons-io:commons-io:2.7'
     compile group: 'org.apache.commons', name: 'commons-text', version: '1.8'