Show password dialog only for access denied exception, for other exceptions, show warn notification instead.

Author: Flanker32

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/link/mysql/MySQLConnectionUtils.java

@@ -33,6 +33,7 @@ public static boolean connect(String url, String username, String password) {
     }
 
     public static ConnectResult connectWithPing(String url, String username, String password) {
+        int errorCode = 0;
         boolean connected = false;
         String errorMessage = null;
         Long pingCost = null;
@@ -51,17 +52,20 @@ public static ConnectResult connectWithPing(String url, String username, String
             }
             pingCost = System.currentTimeMillis() - start;
             serverVersion = ((ConnectionImpl) connection).getServerVersion().toString();
-        } catch (ClassNotFoundException | SQLException exception) {
+        } catch (ClassNotFoundException exception) {
+            errorMessage = exception.getMessage();
+        } catch (SQLException exception) {
+            errorCode = exception.getErrorCode();
             errorMessage = isConnectionIssue(exception) ? String.format(CONNECTION_ISSUE_MESSAGE, exception.getMessage()) : exception.getMessage();
         }
         EventUtil.logEvent(EventType.info, ActionConstants.parse(ActionConstants.MySQL.TEST_CONNECTION).getServiceName(),
                            ActionConstants.parse(ActionConstants.MySQL.TEST_CONNECTION).getOperationName(),
                            Collections.singletonMap("result", String.valueOf(connected)));
-        return new ConnectResult(connected, errorMessage, pingCost, serverVersion);
+        return new ConnectResult(connected, errorMessage, pingCost, serverVersion, errorCode);
     }
 
-    private static boolean isConnectionIssue(final Exception exception){
-        return exception instanceof SQLException && ((SQLException) exception).getErrorCode() == CONNECTION_ERROR_CODE;
+    private static boolean isConnectionIssue(final SQLException exception){
+        return exception.getErrorCode() == CONNECTION_ERROR_CODE;
     }
 
     @Getter
@@ -71,5 +75,6 @@ public static class ConnectResult {
         private String message;
         private Long pingCost;
         private String serverVersion;
+        private int errorCode;
     }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/lib/link/AzureLinkService.java

@@ -21,6 +21,7 @@
 import com.microsoft.azuretools.telemetrywrapper.EventUtil;
 import com.microsoft.intellij.AzureLinkStorage;
 import com.microsoft.intellij.AzureMySQLStorage;
+import com.microsoft.intellij.util.PluginUtil;
 import org.apache.commons.codec.digest.DigestUtils;
 import org.apache.commons.collections4.CollectionUtils;
 import org.apache.commons.lang3.ArrayUtils;
@@ -32,6 +33,7 @@
 
 public class AzureLinkService {
     private static final AzureLinkService instance = new AzureLinkService();
+    private static final int ACCESS_DENIED_ERROR_CODE = 1045;
 
     public static AzureLinkService getInstance() {
         return instance;
@@ -109,10 +111,15 @@ public Map<String, String> retrieveLinkEnvsByModuleName(Project project, String
     }
 
     private String readPasswordCredentials(Project project, MySQLResourcePO service) {
-        String storagedPassword = AzureMySQLStorage.getStorage().loadPassword(service, service.getPasswordSave(), service.getUsername());
-        if (StringUtils.isNotBlank(storagedPassword)) {
-            if (MySQLConnectionUtils.connect(service.getUrl(), service.getUsername(), storagedPassword)) {
-                return storagedPassword;
+        final String storedPassword = AzureMySQLStorage.getStorage().loadPassword(service, service.getPasswordSave(), service.getUsername());
+        if (StringUtils.isNotEmpty(storedPassword)) {
+            final MySQLConnectionUtils.ConnectResult result = MySQLConnectionUtils.connectWithPing(service.getUrl(), service.getUsername(), storedPassword);
+            if (result.isConnected()) {
+                return storedPassword;
+            }
+            if (result.getErrorCode() != ACCESS_DENIED_ERROR_CODE) {
+                PluginUtil.showWarnNotification("Failed to connect MySQL", result.getMessage());
+                return StringUtils.EMPTY;
             }
         }
         // re-input password