Using AzureMessager in function creation/deploy action

Author: Flanker32

PluginsAndFeatures/azure-toolkit-for-intellij/resources/com/microsoft/intellij/ui/messages/messages.properties

@@ -1390,7 +1390,7 @@ function.create.hint.created=Function app ({0}) created.
 function.create.hint.startCreateFunction=The specified function app does not exist. Creating a new function app...
 function.create.hint.functionCreated=Successfully created function app ({0})
 function.create.error.targetExists=Failed to create function app ({0}), target function app already exists.
-function.create.error.createApplicationInsightsFailed=Failed to create application insights for function app ({0})
+function.create.error.createApplicationInsightsFailed=Skip binding application insights as failed to create insights instance for function app ({0})
 function.create.error.dockerNotSupport=The 'docker' runtime is not supported in current version.
 function.create.error.invalidRuntime=Unsupported runtime {0}
 function.create.dialog.title=Create Function

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/function/action/CreateFunctionAppAction.java

@@ -5,27 +5,27 @@
 
 package com.microsoft.azure.toolkit.intellij.function.action;
 
-import com.intellij.notification.Notification;
-import com.intellij.notification.NotificationType;
-import com.intellij.notification.Notifications;
 import com.intellij.openapi.progress.ProgressIndicator;
 import com.intellij.openapi.progress.ProgressManager;
 import com.intellij.openapi.project.Project;
 import com.microsoft.azure.management.appservice.FunctionApp;
+import com.microsoft.azure.toolkit.intellij.common.messager.IntellijAzureMessager;
 import com.microsoft.azure.toolkit.intellij.function.FunctionAppCreationDialog;
 import com.microsoft.azure.toolkit.lib.common.exception.AzureExceptionHandler;
 import com.microsoft.azure.toolkit.lib.common.exception.AzureExceptionHandler.AzureExceptionAction;
+import com.microsoft.azure.toolkit.lib.common.messager.AzureMessager;
 import com.microsoft.azure.toolkit.lib.common.operation.AzureOperation;
 import com.microsoft.azure.toolkit.lib.common.operation.IAzureOperationTitle;
 import com.microsoft.azure.toolkit.lib.common.task.AzureTask;
 import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
 import com.microsoft.azure.toolkit.lib.function.FunctionAppConfig;
 import com.microsoft.azure.toolkit.lib.function.FunctionAppService;
 import com.microsoft.azuretools.authmanage.AuthMethodManager;
+import com.microsoft.azuretools.azurecommons.helpers.NotNull;
 import com.microsoft.azuretools.azurecommons.helpers.Nullable;
-import com.microsoft.intellij.actions.AzureSignInAction;
 import com.microsoft.azuretools.utils.AzureUIRefreshCore;
 import com.microsoft.azuretools.utils.AzureUIRefreshEvent;
+import com.microsoft.intellij.actions.AzureSignInAction;
 import com.microsoft.intellij.util.AzureLoginHelper;
 import com.microsoft.tooling.msservices.helpers.Name;
 import com.microsoft.tooling.msservices.serviceexplorer.AzureActionEnum;
@@ -92,13 +92,20 @@ private void openDialog(final Project project, @Nullable final FunctionAppConfig
     @AzureOperation(name = "function.create_detail", params = {"config.getName()"}, type = AzureOperation.Type.ACTION)
     private Single<FunctionApp> createFunctionApp(final FunctionAppConfig config) {
         final IAzureOperationTitle title = title("function.create_detail", config.getName());
+        final IntellijAzureMessager actionMessenger = new IntellijAzureMessager() {
+            @Override
+            public void info(@NotNull String message, String title) {
+                // swallow info notification for action
+            }
+        };
         final AzureTask<FunctionApp> task = new AzureTask<>(null, title, false, () -> {
+            AzureMessager.getContext().setMessager(actionMessenger);
             final ProgressIndicator indicator = ProgressManager.getInstance().getProgressIndicator();
             indicator.setIndeterminate(true);
             return functionAppService.createFunctionApp(config);
         });
         return AzureTaskManager.getInstance().runInModalAsObservable(task).toSingle().doOnSuccess(app -> {
-            this.notifyCreationSuccess(app);
+            AzureMessager.getMessager().success(message("function.create.success.title"), message("function.create.success.message", app.name()));
             this.refreshAzureExplorer(app);
         });
     }
@@ -111,11 +118,4 @@ private void refreshAzureExplorer(FunctionApp app) {
             }
         });
     }
-
-    private void notifyCreationSuccess(final FunctionApp app) {
-        final String title = message("function.create.success.title");
-        final String message = message("function.create.success.message", app.name());
-        final Notification notification = new Notification(NOTIFICATION_GROUP_ID, title, message, NotificationType.INFORMATION);
-        Notifications.Bus.notify(notification);
-    }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/function/runner/deploy/FunctionDeploymentState.java

@@ -5,8 +5,11 @@
 
 package com.microsoft.azure.toolkit.intellij.function.runner.deploy;
 
+import com.intellij.execution.process.ProcessOutputTypes;
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiMethod;
+import com.microsoft.azure.toolkit.intellij.common.messager.IntellijAzureMessager;
+import com.microsoft.azure.toolkit.lib.common.messager.AzureMessager;
 import com.microsoft.azure.toolkit.lib.legacy.function.configurations.FunctionConfiguration;
 import com.microsoft.azure.management.appservice.AppServicePlan;
 import com.microsoft.azure.management.appservice.FunctionApp;
@@ -27,10 +30,12 @@
 import com.microsoft.azuretools.utils.AzureUIRefreshCore;
 import com.microsoft.azuretools.utils.AzureUIRefreshEvent;
 import com.microsoft.intellij.RunProcessHandler;
+import lombok.RequiredArgsConstructor;
 import org.apache.commons.lang.StringUtils;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
+import javax.annotation.Nonnull;
 import java.io.File;
 import java.io.IOException;
 import java.nio.file.Path;
@@ -57,6 +62,8 @@ public FunctionDeploymentState(Project project, FunctionDeployConfiguration func
     @Override
     @AzureOperation(name = "function.deploy.state", type = AzureOperation.Type.ACTION)
     public WebAppBase executeSteps(@NotNull RunProcessHandler processHandler, @NotNull Operation operation) throws Exception {
+        final FunctionDeploymentMessenger messenger = new FunctionDeploymentMessenger(processHandler);
+        AzureMessager.getContext().setMessager(messenger);
         // Update run time information by function app
         final FunctionApp functionApp;
         if (deployModel.isNewResource()) {
@@ -73,11 +80,7 @@ public WebAppBase executeSteps(@NotNull RunProcessHandler processHandler, @NotNu
         stagingFolder = FunctionUtils.getTempStagingFolder();
         deployModel.setDeploymentStagingDirectoryPath(stagingFolder.getPath());
         prepareStagingFolder(stagingFolder, processHandler, operation);
-        final DeployFunctionHandler deployFunctionHandler = new DeployFunctionHandler(deployModel, message -> {
-            if (processHandler.isProcessRunning()) {
-                processHandler.setText(message);
-            }
-        }, operation);
+        final DeployFunctionHandler deployFunctionHandler = new DeployFunctionHandler(deployModel, operation);
         return deployFunctionHandler.execute();
     }
 
@@ -151,4 +154,32 @@ protected void onFail(@NotNull Throwable error, @NotNull RunProcessHandler proce
     protected Map<String, String> getTelemetryMap() {
         return functionDeployConfiguration.getModel().getTelemetryProperties();
     }
+
+    // todo: create shared run state messenger for all run states
+    @RequiredArgsConstructor
+    private static class FunctionDeploymentMessenger extends IntellijAzureMessager {
+        private final RunProcessHandler processHandler;
+
+        @Override
+        public void info(@Nonnull String message, String title) {
+            processHandler.setText(message);
+        }
+
+        @Override
+        public void success(@Nonnull String message, String title) {
+            processHandler.println(message, ProcessOutputTypes.SYSTEM);
+            super.success(message, title);
+        }
+
+        @Override
+        public void error(@Nonnull String message, String title) {
+            processHandler.println(message, ProcessOutputTypes.STDERR);
+            super.error(message, title);
+        }
+
+        @Override
+        public void warning(@Nonnull String message, String title) {
+            processHandler.setText(message);
+        }
+    }
 }