Merge remote-tracking branch 'origin/endgame-202401' into develop

Author: wangmingliang-ms

.azure-pipelines/sign-for-dev-release.yml

@@ -104,7 +104,7 @@ extends:
                 inputs:
                   targetType: inline
                   script: |
-                    (cd PluginsAndFeatures/azure-toolkit-for-intellij && ./gradlew clean buildPlugin -s -Papplicationinsights.key=$(INTELLIJ_KEY)  -PneedPatchVersion=$(IS_FOR_DEV_RELEASE) -Psources=false -Porg.gradle.configureondemand=false -Porg.gradle.daemon=false -Porg.gradle.unsafe.configuration-cache=false -Porg.gradle.caching=false)
+                    (cd PluginsAndFeatures/azure-toolkit-for-intellij && ./gradlew clean buildPlugin -s -Papplicationinsights.key=$(INTELLIJ_KEY)  -PneedPatchVersion=true -Psources=false -Porg.gradle.configureondemand=false -Porg.gradle.daemon=false -Porg.gradle.unsafe.configuration-cache=false -Porg.gradle.caching=false)
 
                     mkdir -p ./artifacts/intellij/
                     cp ./PluginsAndFeatures/azure-toolkit-for-intellij/build/distributions/*.zip ./artifacts/intellij/azure-toolkit-for-intellij.zip

CHANGELOG.md

@@ -3,6 +3,7 @@
 All notable changes to "Azure Toolkit for IntelliJ IDEA" will be documented in this file.
 
 - [Change Log](#change-log)
+  - [3.85.0](#3850)
   - [3.84.0](#3840)
   - [3.83.0](#3830)
   - [3.82.0](#3820)
@@ -106,6 +107,24 @@ All notable changes to "Azure Toolkit for IntelliJ IDEA" will be documented in t
   - [3.0.7](#307)
   - [3.0.6](#306)
 
+## 3.85.0
+### Added
+- Support for containerized FunctionApps (based on Azure Container Apps) 
+- Support for creating docker WebApp/FunctionApp
+- Support for Managing Azure Container Registries (ACR) with bundled Docker plugin (2023.3) in integrated `Services` view.     
+- Warn user when creating/deploying WebApps/FunctionApps of (to-be-) deprected runtime.
+
+### Updated
+- Update icon of WebApp/FunctionApp to indicate its runtime.
+
+### Fixed
+- [#8118](https://github.com/microsoft/azure-tools-for-java/issues/8118): NPE at EnvVarLineMarkerProvider.
+- [#8113](https://github.com/microsoft/azure-tools-for-java/issues/8113): java.nio.file.NoSuchFileException at AzureModule.getDefaultProfileName.
+- [#8109](https://github.com/microsoft/azure-tools-for-java/issues/8109): java.lang.ClassCastException at StoragePathPrefixCompletionProvider.addCompletions.
+- [#8093](https://github.com/microsoft/azure-tools-for-java/issues/8093): Speed Search not working correctly.
+- [#8081](https://github.com/microsoft/azure-tools-for-java/issues/8081): java.lang.AssertionError at AzureCognitiveServices.accounts.
+- [#8063](https://github.com/microsoft/azure-tools-for-java/issues/8063): java.lang.ArrayIndexOutOfBoundsException at TreeUtils.selectResourceNode.
+
 ## 3.84.0
 ### Added
 - Browse Azure sample projects and create new project from them.     

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/AppServiceInfoAdvancedPanel.java

@@ -52,7 +52,7 @@
 @Getter
 public class AppServiceInfoAdvancedPanel<T extends AppServiceConfig> extends JPanel implements AzureFormPanel<T> {
     public static final ContainerAppDraft.ImageConfig QUICK_START_IMAGE =
-            new ContainerAppDraft.ImageConfig("mcr.microsoft.com/azuredocs/containerapps-helloworld:latest");
+            new ContainerAppDraft.ImageConfig("mcr.microsoft.com/appsvc/staticsite:latest");
     private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("yyMMddHHmmss");
     private static final String NOT_APPLICABLE = "N/A";
     private final Project project;

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/AppServiceInfoBasicPanel.java

@@ -15,18 +15,20 @@
 import com.microsoft.azure.toolkit.lib.appservice.config.AppServiceConfig;
 import com.microsoft.azure.toolkit.lib.appservice.config.FunctionAppConfig;
 import com.microsoft.azure.toolkit.lib.appservice.config.RuntimeConfig;
+import com.microsoft.azure.toolkit.lib.appservice.model.OperatingSystem;
 import com.microsoft.azure.toolkit.lib.appservice.model.Runtime;
 import com.microsoft.azure.toolkit.lib.auth.Account;
 import com.microsoft.azure.toolkit.lib.auth.AzureAccount;
 import com.microsoft.azure.toolkit.lib.common.form.AzureFormInput;
 import com.microsoft.azure.toolkit.lib.common.model.Subscription;
+import lombok.Getter;
+import lombok.Setter;
 import lombok.SneakyThrows;
 import org.apache.commons.compress.utils.FileNameUtils;
 import org.apache.commons.lang3.ObjectUtils;
 import org.apache.commons.lang3.StringUtils;
 
 import javax.swing.*;
-import java.text.SimpleDateFormat;
 import java.util.*;
 import java.util.function.Supplier;
 
@@ -45,6 +47,9 @@ public class AppServiceInfoBasicPanel<T extends AppServiceConfig> extends JPanel
     private JLabel lblArtifact;
     private JLabel lblName;
     private JLabel lblPlatform;
+    @Setter
+    @Getter
+    private String defaultImage;
 
     public AppServiceInfoBasicPanel(final Project project, final Supplier<? extends T> defaultConfigSupplier) {
         super();
@@ -82,16 +87,16 @@ public T getValue() {
                                                   .orElseGet(() -> account.getSelectedSubscriptions().stream().findFirst().orElse(null));
         final T result = this.config == null ? supplier.get() : this.config;
         result.appName(name);
-        Optional.ofNullable(platform).map(RuntimeConfig::fromRuntime).ifPresent(result::runtime);
         Optional.ofNullable(subscription).map(Subscription::getId).ifPresent(result::subscriptionId);
-        // todo: web app creation dialog should use run/deploy configuration, which should be parent of info panel
-//        if (Objects.nonNull(artifact)) {
-//            final AzureArtifactManager manager = AzureArtifactManager.getInstance(this.project);
-//            final String path = this.selectorApplication.getValue().getFileForDeployment();
-//            result.setApplication(Paths.get(path));
-//        }
+        Optional.ofNullable(platform).filter(r -> !r.isDocker()).map(RuntimeConfig::fromRuntime).ifPresent(result::runtime);
+        if (Objects.nonNull(platform) && platform.isDocker()) {
+            final RuntimeConfig runtime = Optional.ofNullable(result.runtime()).orElseGet(RuntimeConfig::new);
+            runtime.os(OperatingSystem.DOCKER);
+            runtime.image(StringUtils.firstNonBlank(runtime.image(), defaultImage));
+            result.runtime(runtime);
+        }
+        result.appSettings(ObjectUtils.firstNonNull(this.config.appSettings(), new HashMap<>()));
         this.config = result;
-        this.config.appSettings(ObjectUtils.firstNonNull(this.config.appSettings(), new HashMap<>()));
         return config;
     }
 

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/function/FunctionAppCreationDialog.java

@@ -10,8 +10,14 @@
 import com.microsoft.azure.toolkit.intellij.common.AzureFormPanel;
 import com.microsoft.azure.toolkit.intellij.common.ConfigDialog;
 import com.microsoft.azure.toolkit.intellij.legacy.appservice.AppServiceInfoBasicPanel;
+import com.microsoft.azure.toolkit.lib.appservice.config.AppServiceConfig;
+import com.microsoft.azure.toolkit.lib.appservice.config.AppServicePlanConfig;
 import com.microsoft.azure.toolkit.lib.appservice.config.FunctionAppConfig;
+import com.microsoft.azure.toolkit.lib.appservice.config.RuntimeConfig;
 import com.microsoft.azure.toolkit.lib.appservice.model.FunctionAppRuntime;
+import com.microsoft.azure.toolkit.lib.appservice.model.OperatingSystem;
+import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
+import com.microsoft.azure.toolkit.lib.appservice.plan.AppServicePlan;
 import com.microsoft.azure.toolkit.lib.auth.AzureAccount;
 import com.microsoft.azure.toolkit.lib.auth.IAccountActions;
 import com.microsoft.azure.toolkit.lib.common.exception.AzureToolkitRuntimeException;
@@ -25,6 +31,7 @@
 import java.util.Optional;
 
 import static com.microsoft.azure.toolkit.intellij.common.AzureBundle.message;
+import static com.microsoft.azure.toolkit.intellij.legacy.function.FunctionAppInfoPanel.QUICK_START_IMAGE;
 import static com.microsoft.azure.toolkit.lib.Azure.az;
 
 public class FunctionAppCreationDialog extends ConfigDialog<FunctionAppConfig> {
@@ -78,10 +85,27 @@ public FunctionAppConfig getValue() {
                         insightConfig.setName(config.appName());
                     }
                 });
+
+                final OperatingSystem os = Optional.ofNullable(config)
+                        .map(FunctionAppConfig::runtime).map(RuntimeConfig::os).orElse(null);
+                final PricingTier pricingTier = Optional.ofNullable(config)
+                        .map(FunctionAppConfig::getPricingTier).orElse(null);
+                final Boolean isConsumption = Optional.ofNullable(pricingTier)
+                        .map(tier -> tier.isConsumption() || tier.isFlexConsumption()).orElse(false);
+                // set draft plan pricing tier to premium if runtime is docker
+                if (os == OperatingSystem.DOCKER && isConsumption) {
+                    Optional.of(config)
+                            .map(AppServiceConfig::getServicePlanConfig)
+                            .map(AppServicePlanConfig::getAppServicePlan)
+                            .filter(AppServicePlan::isDraftForCreating).ifPresent(ignore -> {
+                                config.pricingTier(PricingTier.PREMIUM_P1V2);
+                            });
+                }
                 return config;
             }
         };
         basicPanel.getSelectorRuntime().setPlatformList(FunctionAppRuntime.getMajorRuntimes());
+        basicPanel.setDefaultImage(QUICK_START_IMAGE.getFullImageName());
         advancePanel = new FunctionAppAdvancedConfigPanel(project);
     }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/function/FunctionAppInfoPanel.java

@@ -115,12 +115,6 @@ public FunctionAppConfig getValue() {
         if (isDocker) {
             final ContainerAppDraft.ImageConfig image = chkUseQuickStart.isSelected() ? QUICK_START_IMAGE : pnlContainer.getValue();
             Optional.ofNullable(image).map(DockerUtils::convertImageConfigToRuntimeConfig).ifPresent(config::runtime);
-            // workaround to fix worker runtime issue of default image, as it was a dot net one
-            if (chkUseQuickStart.isSelected()) {
-                final Map<String, String> appSettings = new HashMap<>(config.appSettings());
-                appSettings.put("FUNCTIONS_WORKER_RUNTIME", "dotnet-isolated");
-                config.appSettings(appSettings);
-            }
         }
         return this.config;
     }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/function/runner/deploy/FunctionDeploymentState.java

@@ -62,7 +62,6 @@ public class FunctionDeploymentState extends AzureRunProfileState<FunctionAppBas
     private static final String NO_TRIGGERS_FOUNDED = "No triggers found in deployed function app";
 
     private final FunctionDeployConfiguration functionDeployConfiguration;
-    private final FunctionDeployModel deployModel;
     private File stagingFolder;
 
     /**
@@ -71,7 +70,6 @@ public class FunctionDeploymentState extends AzureRunProfileState<FunctionAppBas
     public FunctionDeploymentState(Project project, FunctionDeployConfiguration functionDeployConfiguration) {
         super(project);
         this.functionDeployConfiguration = functionDeployConfiguration;
-        this.deployModel = functionDeployConfiguration.getModel();
     }
 
     @Nullable
@@ -177,6 +175,6 @@ protected void onFail(@NotNull Throwable error, @NotNull RunProcessHandler proce
 
     @Override
     protected Map<String, String> getTelemetryMap() {
-        return deployModel.getTelemetryProperties();
+        return OperationContext.action().getTelemetryProperties();
     }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/webapp/WebAppCreationDialog.java

@@ -9,6 +9,7 @@
 import com.microsoft.azure.toolkit.intellij.appservice.AppServiceIntelliJActionsContributor;
 import com.microsoft.azure.toolkit.intellij.common.AzureFormPanel;
 import com.microsoft.azure.toolkit.intellij.common.ConfigDialog;
+import com.microsoft.azure.toolkit.intellij.legacy.appservice.AppServiceInfoAdvancedPanel;
 import com.microsoft.azure.toolkit.intellij.legacy.appservice.AppServiceInfoBasicPanel;
 import com.microsoft.azure.toolkit.lib.appservice.config.AppServiceConfig;
 import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
@@ -74,5 +75,6 @@ private void createUIComponents() {
         }
         basicForm = new AppServiceInfoBasicPanel<>(project, () -> AppServiceIntelliJActionsContributor.getDefaultWebAppConfig(null));
         basicForm.setDeploymentVisible(false);
+        basicForm.setDefaultImage(AppServiceInfoAdvancedPanel.QUICK_START_IMAGE.getFullImageName());
     }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice-java/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/webapp/runner/webappconfig/WebAppRunState.java

@@ -174,9 +174,8 @@ protected void onSuccess(WebAppBase<?, ?, ?> result, @NotNull RunProcessHandler
 
     @Override
     protected Map<String, String> getTelemetryMap() {
-        final Map<String, String> properties = new HashMap<>();
+        final Map<String, String> properties = new HashMap<>(OperationContext.action().getTelemetryProperties());
         properties.put("artifactType", webAppConfiguration.getAzureArtifactType() == null ? null : webAppConfiguration.getAzureArtifactType().name());
-        properties.putAll(webAppSettingModel.getTelemetryProperties(Collections.EMPTY_MAP));
         return properties;
     }
 

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib-java/src/main/resources/whatsnew.md

@@ -1,5 +1,22 @@
 <!-- Version: 3.83.0 -->
 # What's new in Azure Toolkit for IntelliJ
+## 3.85.0
+### Added
+- Support for containerized FunctionApps (based on Azure Container Apps) 
+- Support for creating docker WebApp/FunctionApp
+- Support for Managing Azure Container Registries (ACR) with bundled Docker plugin (2023.3) in integrated `Services` view.     
+- Warn user when creating/deploying WebApps/FunctionApps of (to-be-) deprected runtime.
+
+### Updated
+- Update icon of WebApp/FunctionApp to indicate its runtime.
+
+### Fixed
+- [#8118](https://github.com/microsoft/azure-tools-for-java/issues/8118): NPE at EnvVarLineMarkerProvider.
+- [#8113](https://github.com/microsoft/azure-tools-for-java/issues/8113): java.nio.file.NoSuchFileException at AzureModule.getDefaultProfileName.
+- [#8109](https://github.com/microsoft/azure-tools-for-java/issues/8109): java.lang.ClassCastException at StoragePathPrefixCompletionProvider.addCompletions.
+- [#8093](https://github.com/microsoft/azure-tools-for-java/issues/8093): Speed Search not working correctly.
+- [#8081](https://github.com/microsoft/azure-tools-for-java/issues/8081): java.lang.AssertionError at AzureCognitiveServices.accounts.
+- [#8063](https://github.com/microsoft/azure-tools-for-java/issues/8063): java.lang.ArrayIndexOutOfBoundsException at TreeUtils.selectResourceNode.
 
 ## 3.84.0
 ### Added