Skip to content

Commit de67602

Browse files
Merge pull request #9765 from srnagar/expand-groupid
Include spring and management group ids in Maven Report
2 parents 8528e5e + 01ef69c commit de67602

File tree

1 file changed

+9
-4
lines changed
  • PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-java-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/java/sdk

1 file changed

+9
-4
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-java-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/java/sdk/MavenProjectReportGenerator.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,17 @@ private void analyzePom(MavenProjectsManager mavenProjectsManager, MavenProject
166166
final Optional<DeprecatedDependency> deprecatedDependency = DeprecatedDependencyUtil.lookupReplacement(groupId, artifactId);
167167
deprecatedDependency.ifPresent(deprecatedDependencies::add);
168168

169-
if (AZURE_GROUP_ID.equals(groupId)) {
169+
final boolean isAzureGroupId = isAzureGroupId(groupId);
170+
if (isAzureGroupId) {
170171
azureDependencies.add(dependency.getMavenId().getDisplayString());
171172
}
172173

173-
if (report.getBomVersion() == null && AZURE_GROUP_ID.equals(groupId) && versionId != null && !versionId.contains("beta")) {
174+
if (report.getBomVersion() == null && isAzureGroupId && versionId != null && !versionId.contains("beta")) {
174175
report.addError(new Error("Azure SDK BOM not used",
175176
ErrorCode.BOM_NOT_USED, ErrorLevel.WARNING, List.of(dependency.getMavenId().getDisplayString())));
176177
}
177178

178-
if (AZURE_GROUP_ID.equals(groupId) && versionId != null && versionId.contains("beta")) {
179+
if (isAzureGroupId && versionId != null && versionId.contains("beta")) {
179180
report.addError(new Error("Beta version of the library used",
180181
ErrorCode.BETA_DEPENDENCY_USED, ErrorLevel.WARNING, List.of(dependency.getMavenId().getDisplayString())));
181182
}
@@ -184,6 +185,10 @@ private void analyzePom(MavenProjectsManager mavenProjectsManager, MavenProject
184185
report.addAllDeprecatedDependencies(deprecatedDependencies);
185186
}
186187

188+
private static boolean isAzureGroupId(String groupId) {
189+
return groupId != null && groupId.startsWith(AZURE_GROUP_ID);
190+
}
191+
187192
private void analyzeCode(MavenProjectsManager mavenProjectsManager, MavenProject mavenProject, MavenProjectReport report) {
188193
final Map<String, Integer> methodCallFrequency = new HashMap<>();
189194
final Map<String, Integer> betaMethodCallFrequency = new HashMap<>();
@@ -284,7 +289,7 @@ private void checkDependencyManagement(MavenProjectsManager mavenProjectsManager
284289
final String artifactId = getTextValue(dependencyTag, "artifactId");
285290
final String versionId = getTextValue(dependencyTag, "version");
286291

287-
if (AZURE_GROUP_ID.equals(groupId) && AZURE_SDK_BOM.equals(artifactId)) {
292+
if (isAzureGroupId(groupId) && AZURE_SDK_BOM.equals(artifactId)) {
288293
final String latestArtifactVersion = MavenUtils.getLatestArtifactVersion(groupId, artifactId);
289294
if (versionId != null && !versionId.equals(latestArtifactVersion)) {
290295
report.setBomVersion(versionId);

0 commit comments

Comments
 (0)