Skip to content

Commit de96cc8

Browse files
Merge pull request #6886 from microsoft/resolve-conflicts
develop -> develop.next
2 parents 6ea4951 + 6cec90d commit de96cc8

File tree

197 files changed

+2583
-911
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

197 files changed

+2583
-911
lines changed

PluginsAndFeatures/AddLibrary/AzureLibraries/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<parent>
2828
<groupId>com.microsoft.azuretools</groupId>
2929
<artifactId>utils</artifactId>
30-
<version>3.68.0-SNAPSHOT</version>
30+
<version>3.68.0</version>
3131
</parent>
3232
<groupId>com.microsoft.azuretools</groupId>
3333
<artifactId>com.microsoft.azuretools.sdk.lib</artifactId>
@@ -39,9 +39,9 @@
3939
</organization>
4040

4141
<properties>
42-
<azuretool.version>3.68.0-SNAPSHOT</azuretool.version>
42+
<azuretool.version>3.68.0</azuretool.version>
4343
<azuretool.sdk.version>3.32.0.qualifier</azuretool.sdk.version>
44-
<azure.toolkit-lib.version>0.24.0-SNAPSHOT</azure.toolkit-lib.version>
44+
<azure.toolkit-lib.version>0.24.0</azure.toolkit-lib.version>
4545
</properties>
4646
<dependencyManagement>
4747
<dependencies>

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.appservice/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ Export-Package: com.microsoft.azuretools.appservice,
4343
com.microsoft.azuretools.appservice.handlers,
4444
com.microsoft.azuretools.appservice.ui
4545
Bundle-ClassPath: .,
46-
target/lib/azure-toolkit-ide-appservice-lib-0.24.0-SNAPSHOT.jar
46+
target/lib/azure-toolkit-ide-appservice-lib-0.24.0.jar

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.appservice/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<dependency>
1414
<groupId>com.microsoft.azure</groupId>
1515
<artifactId>azure-toolkit-ide-appservice-lib</artifactId>
16-
<version>0.24.0-SNAPSHOT</version>
16+
<version>0.24.0</version>
1717
</dependency>
1818
</dependencies>
1919
<repositories>

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.springcloud/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Require-Bundle: org.eclipse.ui,
2323
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
2424
Bundle-ActivationPolicy: lazy
2525
Bundle-ClassPath: .,
26-
target/lib/azure-toolkit-ide-springcloud-lib-0.24.0-SNAPSHOT.jar
26+
target/lib/azure-toolkit-ide-springcloud-lib-0.24.0.jar
2727
Import-Package: com.microsoft.azuretools.core.actions,
2828
org.eclipse.core.expressions,
2929
org.eclipse.jface.text.hyperlink,

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.springcloud/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<dependency>
1414
<groupId>com.microsoft.azure</groupId>
1515
<artifactId>azure-toolkit-ide-springcloud-lib</artifactId>
16-
<version>0.24.0-SNAPSHOT</version>
16+
<version>0.24.0</version>
1717
</dependency>
1818
</dependencies>
1919
<build>

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-applicationinsights/src/main/java/com/microsoft/azure/toolkit/intellij/applicationinsights/IntelliJApplicationInsightsActionsContributor.java

Lines changed: 26 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package com.microsoft.azure.toolkit.intellij.applicationinsights;
77

8-
import com.azure.resourcemanager.applicationinsights.models.ApplicationInsightsComponent;
8+
import com.google.common.base.Preconditions;
99
import com.intellij.openapi.actionSystem.AnActionEvent;
1010
import com.microsoft.azure.toolkit.ide.applicationinsights.ApplicationInsightsActionsContributor;
1111
import com.microsoft.azure.toolkit.ide.common.IActionsContributor;
@@ -20,18 +20,20 @@
2020
import com.microsoft.azure.toolkit.lib.applicationinsights.AzureApplicationInsights;
2121
import com.microsoft.azure.toolkit.lib.auth.AzureAccount;
2222
import com.microsoft.azure.toolkit.lib.common.action.AzureActionManager;
23+
import com.microsoft.azure.toolkit.lib.common.cache.CacheManager;
24+
import com.microsoft.azure.toolkit.lib.common.model.AbstractAzResource;
2325
import com.microsoft.azure.toolkit.lib.common.model.AzResource;
2426
import com.microsoft.azure.toolkit.lib.common.model.Region;
2527
import com.microsoft.azure.toolkit.lib.common.model.Subscription;
2628
import com.microsoft.azure.toolkit.lib.common.operation.OperationBundle;
2729
import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
2830
import com.microsoft.azure.toolkit.lib.common.utils.Utils;
29-
import com.microsoft.azure.toolkit.lib.resource.AzureResources;
3031
import com.microsoft.azure.toolkit.lib.resource.ResourceGroup;
31-
import com.microsoft.azure.toolkit.lib.resource.ResourceGroupDraft;
32+
import org.apache.commons.collections4.CollectionUtils;
3233

3334
import javax.annotation.Nullable;
3435
import java.util.List;
36+
import java.util.Objects;
3537
import java.util.Optional;
3638
import java.util.function.BiConsumer;
3739
import java.util.function.BiPredicate;
@@ -59,16 +61,29 @@ public void registerHandlers(AzureActionManager am) {
5961
}
6062

6163
private static ApplicationInsightDraft getDraftApplicationInsight(@Nullable final ResourceGroup resourceGroup) {
62-
final List<Subscription> selectedSubscriptions = Azure.az(AzureAccount.class).account().getSelectedSubscriptions();
63-
if (selectedSubscriptions.size() == 0) {
64-
return null;
65-
}
64+
final List<Subscription> subs = Azure.az(AzureAccount.class).account().getSelectedSubscriptions();
65+
Preconditions.checkArgument(CollectionUtils.isNotEmpty(subs), "There are no subscriptions in your account.");
66+
67+
final Subscription historySub = CacheManager.getUsageHistory(Subscription.class).peek(subs::contains);
68+
final ResourceGroup historyRg = CacheManager.getUsageHistory(ResourceGroup.class)
69+
.peek(r -> Objects.isNull(historySub) || r.getSubscriptionId().equals(historySub.getId()));
70+
final Region historyRegion = CacheManager.getUsageHistory(Region.class).peek();
71+
6672
final String timestamp = Utils.getTimestamp();
67-
final Subscription subscription = selectedSubscriptions.get(0);
68-
final Region region = Optional.ofNullable(resourceGroup).map(ResourceGroup::getRegion).orElse(null);
69-
final String resourceGroupName = resourceGroup == null ? String.format("rg-%s", timestamp) : resourceGroup.getResourceGroupName();
73+
final ResourceGroup rg = Optional.ofNullable(resourceGroup)
74+
.or(() -> Optional.ofNullable(historyRg))
75+
.orElse(null);
76+
final Subscription subscription = Optional.ofNullable(rg).map(AzResource::getSubscription)
77+
.or(() -> Optional.ofNullable(historySub).filter(subs::contains))
78+
.orElse(subs.get(0));
79+
final Region region = Optional.ofNullable(rg).map(ResourceGroup::getRegion)
80+
.or(() -> Optional.ofNullable(historyRegion))
81+
.orElse(null);
82+
final String resourceGroupName = Optional.ofNullable(rg)
83+
.map(AbstractAzResource::getResourceGroupName)
84+
.orElse(String.format("rg-%s", timestamp));
7085
final ApplicationInsightDraft applicationInsightDraft = Azure.az(AzureApplicationInsights.class).applicationInsights(subscription.getId())
71-
.create(String.format("ai-%s", timestamp), resourceGroupName);
86+
.create(String.format("ai-%s", timestamp), resourceGroupName);
7287
applicationInsightDraft.setRegion(region);
7388
return applicationInsightDraft;
7489
}

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-applicationinsights/src/main/java/com/microsoft/azure/toolkit/intellij/applicationinsights/connection/ApplicationInsightsResourcePanel.java

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.microsoft.azure.toolkit.lib.Azure;
1313
import com.microsoft.azure.toolkit.lib.applicationinsights.ApplicationInsight;
1414
import com.microsoft.azure.toolkit.lib.applicationinsights.AzureApplicationInsights;
15+
import com.microsoft.azure.toolkit.lib.common.cache.CacheManager;
1516
import com.microsoft.azure.toolkit.lib.common.form.AzureFormInput;
1617
import com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo;
1718
import com.microsoft.azure.toolkit.lib.common.model.Subscription;
@@ -23,6 +24,7 @@
2324
import java.util.Arrays;
2425
import java.util.Collections;
2526
import java.util.List;
27+
import java.util.Objects;
2628
import java.util.Optional;
2729
import java.util.function.Supplier;
2830
import java.util.stream.Collectors;
@@ -71,25 +73,32 @@ public Resource<ApplicationInsight> getValue() {
7173
@Override
7274
public List<AzureFormInput<?>> getInputs() {
7375
return Arrays.asList(
74-
this.insightComboBox,
75-
this.subscriptionComboBox
76+
this.insightComboBox,
77+
this.subscriptionComboBox
7678
);
7779
}
7880

7981
protected void createUIComponents() {
8082
final Supplier<List<? extends ApplicationInsight>> loader = () -> Optional
81-
.ofNullable(this.subscriptionComboBox)
82-
.map(AzureComboBox::getValue)
83-
.map(Subscription::getId)
84-
.map(id -> Azure.az(AzureApplicationInsights.class).applicationInsights(id).list()
85-
.stream().sorted((first, second) -> StringUtils.compare(first.getName(), second.getName())).collect(Collectors.toList()))
86-
.orElse(Collections.emptyList());
83+
.ofNullable(this.subscriptionComboBox)
84+
.map(AzureComboBox::getValue)
85+
.map(Subscription::getId)
86+
.map(id -> Azure.az(AzureApplicationInsights.class).applicationInsights(id).list()
87+
.stream().sorted((first, second) -> StringUtils.compare(first.getName(), second.getName())).collect(Collectors.toList()))
88+
.orElse(Collections.emptyList());
8789
this.insightComboBox = new AzureComboBox<>(loader) {
8890
@Override
8991
protected String getItemText(Object item) {
9092
return Optional.ofNullable(item).map(i -> ((ApplicationInsight) i).getName()).orElse(StringUtils.EMPTY);
9193
}
9294

95+
@Nullable
96+
@Override
97+
protected ApplicationInsight doGetDefaultValue() {
98+
return CacheManager.getUsageHistory(ApplicationInsight.class)
99+
.peek(v -> Objects.isNull(subscriptionComboBox) || Objects.equals(subscriptionComboBox.getValue(), v.getSubscription()));
100+
}
101+
93102
@Override
94103
protected void refreshItems() {
95104
Optional.ofNullable(ApplicationInsightsResourcePanel.this.subscriptionComboBox)

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-applicationinsights/src/main/java/com/microsoft/azure/toolkit/intellij/applicationinsights/creation/CreateApplicationInsightsAction.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import com.microsoft.azure.toolkit.lib.applicationinsights.ApplicationInsightDraft;
1212
import com.microsoft.azure.toolkit.lib.auth.AzureAccount;
1313
import com.microsoft.azure.toolkit.lib.common.bundle.AzureString;
14+
import com.microsoft.azure.toolkit.lib.common.cache.CacheManager;
1415
import com.microsoft.azure.toolkit.lib.common.operation.AzureOperation;
1516
import com.microsoft.azure.toolkit.lib.common.operation.OperationBundle;
1617
import com.microsoft.azure.toolkit.lib.common.operation.OperationContext;
@@ -51,6 +52,8 @@ public static ApplicationInsight createApplicationInsights(ApplicationInsightDra
5152
final ResourceGroup newResourceGroup = Azure.az(AzureResources.class)
5253
.groups(subscriptionId).createResourceGroupIfNotExist(draft.getResourceGroupName(), draft.getRegion());
5354
}
54-
return draft.commit();
55+
final ApplicationInsight resource = draft.commit();
56+
CacheManager.getUsageHistory(ApplicationInsight.class).push(draft);
57+
return resource;
5558
}
5659
}

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/AppServiceComboBox.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ protected T convertAppServiceToConfig(final Supplier<T> supplier, AppServiceAppB
7171
config.setRuntime(appService.getRuntime());
7272
config.setRegion(appService.getRegion());
7373
config.setServicePlan(AppServicePlanConfig.fromResource(appService.getAppServicePlan()));
74+
config.setAppSettings(appService.getAppSettings());
7475
})).subscribe();
7576
return config;
7677
}

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/AppServiceStreamingLogConsoleView.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,16 @@ public class AppServiceStreamingLogConsoleView extends ConsoleViewImpl {
2727
public AppServiceStreamingLogConsoleView(@NotNull Project project, String resourceId) {
2828
super(project, true);
2929
this.isDisposed = false;
30+
this.setUpdateFoldingsEnabled(false);
3031
this.resourceId = resourceId;
3132
}
3233

3334
public void startStreamingLog(Flux<String> logStreaming) {
3435
if (!isActive()) {
3536
printlnToConsole(message("appService.logStreaming.hint.connect"), SYSTEM_OUTPUT);
3637
subscription = logStreaming.subscribeOn(Schedulers.boundedElastic())
37-
.doAfterTerminate(() -> printlnToConsole(message("appService.logStreaming.hint.disconnected"), SYSTEM_OUTPUT))
38-
.subscribe((log) -> printlnToConsole(log, NORMAL_OUTPUT));
38+
.doAfterTerminate(() -> printlnToConsole(message("appService.logStreaming.hint.disconnected"), SYSTEM_OUTPUT))
39+
.subscribe((log) -> printlnToConsole(log, NORMAL_OUTPUT));
3940
}
4041
}
4142

0 commit comments

Comments
 (0)