Skip to content

Commit e2825bc

Browse files
committed
Fix missing message bundle for eclipse function log streaming, AB#1952208
1 parent 78dfdca commit e2825bc

File tree

2 files changed

+6
-5
lines changed
  • PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.appservice/src/com/microsoft/azure/toolkit/eclipse/functionapp/logstreaming
  • Utils/azure-toolkit-ide-libs/azure-toolkit-ide-common-lib/src/main/resources/bundles/com/microsoft/azure/toolkit

2 files changed

+6
-5
lines changed

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.appservice/src/com/microsoft/azure/toolkit/eclipse/functionapp/logstreaming/FunctionAppLogStreamingHandler.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ public static void stopLogStreaming(final FunctionAppBase<?, ?, ?> functionApp)
4646

4747
public static void startLogStreaming(final FunctionAppBase<?, ?, ?> functionApp) {
4848
if (!isLogStreamingEnabled(functionApp)) {
49-
final boolean enableLogging = AzureTaskManager.getInstance()
50-
.runAndWaitAsObservable(new AzureTask<>(() -> AzureMessager.getMessager()
51-
.confirm(AzureString.format(ENABLE_FILE_LOGGING, functionApp.name()), ENABLE_LOGGING)))
52-
.toBlocking().single();
49+
final boolean enableLogging = AzureMessager.getMessager()
50+
.confirm(AzureString.format(ENABLE_FILE_LOGGING, functionApp.getName()), ENABLE_LOGGING);
5351
if (enableLogging) {
5452
enableLogStreaming(functionApp);
5553
} else {

Utils/azure-toolkit-ide-libs/azure-toolkit-ide-common-lib/src/main/resources/bundles/com/microsoft/azure/toolkit/message.properties

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,7 @@ springcloud.deploy_app.no_artifact=nothing to deploy
3535
springcloud.deploy_app.no_artifact.tips=You can add a BeforeRunTask to build the artifact automatically or build it manually by yourself beforehand
3636

3737
vm.publicIpAddress.create.title=Create new public ip
38-
vm.publicIpAddress.description=Use a public IP address if you want to communicate with the virtual machine from outside the virtual network.
38+
vm.publicIpAddress.description=Use a public IP address if you want to communicate with the virtual machine from outside the virtual network.
39+
40+
appService.logStreaming.error.noApplicationInsights=You must configure Application Insights to enable streaming logs on Linux Function Apps.
41+
appService.logStreaming.error.aiNotFound=Application Insights instance defined in app settings cannot be found in current subscription {0}

0 commit comments

Comments
 (0)