Skip to content

Commit e422b49

Browse files
migrate to track2 based azure-toolkit-springcloud-lib for logstreaming
1 parent b97637b commit e422b49

File tree

2 files changed

+19
-22
lines changed

2 files changed

+19
-22
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/streaminglog/SpringCloudStreamingLogAction.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
package com.microsoft.azure.toolkit.intellij.springcloud.streaminglog;
77

88
import com.intellij.openapi.project.Project;
9-
import com.microsoft.azure.management.appplatform.v2020_07_01.DeploymentInstance;
10-
import com.microsoft.azure.management.appplatform.v2020_07_01.implementation.AppPlatformManager;
119
import com.microsoft.azure.management.resources.fluentcore.arm.ResourceId;
1210
import com.microsoft.azure.management.resources.fluentcore.arm.ResourceUtils;
1311
import com.microsoft.azure.toolkit.lib.Azure;
@@ -17,8 +15,9 @@
1715
import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
1816
import com.microsoft.azure.toolkit.lib.springcloud.AzureSpringCloud;
1917
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudApp;
18+
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudCluster;
2019
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudDeployment;
21-
import com.microsoft.azuretools.authmanage.AuthMethodManager;
20+
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudDeploymentInstanceEntity;
2221
import com.microsoft.azuretools.azurecommons.helpers.AzureCmdException;
2322
import com.microsoft.azuretools.telemetrywrapper.EventUtil;
2423
import com.microsoft.intellij.util.PluginUtil;
@@ -32,6 +31,7 @@
3231
import org.apache.commons.lang.StringUtils;
3332

3433
import java.util.List;
34+
import java.util.Objects;
3535
import java.util.Optional;
3636

3737
import static com.microsoft.azuretools.telemetry.TelemetryConstants.SPRING_CLOUD;
@@ -58,7 +58,8 @@ public SpringCloudStreamingLogAction(SpringCloudAppNode springCloudAppNode) {
5858
final ResourceId appId = ResourceId.fromString(this.appId);
5959
final String subscriptionId = appId.subscriptionId();
6060
final String clusterName = appId.parent().name();
61-
this.app = Azure.az(AzureSpringCloud.class).subscription(subscriptionId).cluster(clusterName).app(appId.name());
61+
final SpringCloudCluster cluster = Azure.az(AzureSpringCloud.class).subscription(subscriptionId).cluster(clusterName);
62+
this.app = Objects.requireNonNull(cluster, String.format("cluster(%s) not exist", clusterName)).app(appId.name());
6263
}
6364

6465
@Override
@@ -74,7 +75,7 @@ protected void actionPerformed(NodeActionEvent nodeActionEvent) throws AzureCmdE
7475
PluginUtil.displayWarningDialog(FAILED_TO_START_LOG_STREAMING, NO_ACTIVE_DEPLOYMENT));
7576
return;
7677
}
77-
final List<DeploymentInstance> instances = deployment.entity().getInstances();
78+
final List<SpringCloudDeploymentInstanceEntity> instances = deployment.entity().getInstances();
7879
if (CollectionUtils.isEmpty(instances)) {
7980
DefaultLoader.getIdeHelper().invokeLater(() ->
8081
PluginUtil.displayWarningDialog(FAILED_TO_START_LOG_STREAMING, NO_AVAILABLE_INSTANCES));
@@ -90,12 +91,12 @@ protected void actionPerformed(NodeActionEvent nodeActionEvent) throws AzureCmdE
9091
});
9192
}
9293

93-
private void showLogStreamingDialog(List<DeploymentInstance> instances) {
94+
private void showLogStreamingDialog(List<? extends SpringCloudDeploymentInstanceEntity> instances) {
9495
DefaultLoader.getIdeHelper().invokeLater(() -> {
9596
final SpringCloudStreamingLogDialog dialog = new SpringCloudStreamingLogDialog(project, instances);
9697
if (dialog.showAndGet()) {
97-
final DeploymentInstance target = dialog.getInstance();
98-
SpringCloudStreamingLogManager.getInstance().showStreamingLog(project, appId, target.name());
98+
final SpringCloudDeploymentInstanceEntity target = dialog.getInstance();
99+
SpringCloudStreamingLogManager.getInstance().showStreamingLog(project, appId, target.getName());
99100
}
100101
});
101102
}
@@ -114,8 +115,4 @@ protected String getOperationName(final NodeActionEvent event) {
114115
public int getGroup() {
115116
return Groupable.DIAGNOSTIC_GROUP;
116117
}
117-
118-
private static AppPlatformManager getSpringManager(String sid) {
119-
return AuthMethodManager.getInstance().getAzureSpringCloudClient(sid);
120-
}
121118
}

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/streaminglog/SpringCloudStreamingLogDialog.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import com.intellij.openapi.project.Project;
99
import com.intellij.ui.ListCellRendererWithRightAlignedComponent;
10-
import com.microsoft.azure.management.appplatform.v2020_07_01.DeploymentInstance;
10+
import com.microsoft.azure.toolkit.lib.springcloud.SpringCloudDeploymentInstanceEntity;
1111
import com.microsoft.intellij.ui.components.AzureDialogWrapper;
1212
import org.jetbrains.annotations.Nullable;
1313

@@ -17,31 +17,31 @@
1717
public class SpringCloudStreamingLogDialog extends AzureDialogWrapper {
1818

1919
private JPanel pnlRoot;
20-
private JComboBox<DeploymentInstance> cbInstances;
20+
private JComboBox<SpringCloudDeploymentInstanceEntity> cbInstances;
2121

22-
private DeploymentInstance instance;
22+
private SpringCloudDeploymentInstanceEntity instance;
2323

24-
public SpringCloudStreamingLogDialog(@Nullable final Project project, List<DeploymentInstance> instances) {
24+
public SpringCloudStreamingLogDialog(@Nullable final Project project, List<? extends SpringCloudDeploymentInstanceEntity> instances) {
2525
super(project, false);
26-
setTitle("Select instance");
26+
setTitle("Select Instance");
2727
instances.forEach(instance -> cbInstances.addItem(instance));
28-
cbInstances.setRenderer(new ListCellRendererWithRightAlignedComponent<DeploymentInstance>() {
28+
cbInstances.setRenderer(new ListCellRendererWithRightAlignedComponent<>() {
2929
@Override
30-
protected void customize(final DeploymentInstance deploymentInstance) {
31-
setLeftText(deploymentInstance.name());
30+
protected void customize(final SpringCloudDeploymentInstanceEntity deploymentInstance) {
31+
setLeftText(deploymentInstance.getName());
3232
}
3333
});
3434

3535
init();
3636
}
3737

38-
public DeploymentInstance getInstance() {
38+
public SpringCloudDeploymentInstanceEntity getInstance() {
3939
return instance;
4040
}
4141

4242
@Override
4343
protected void doOKAction() {
44-
instance = (DeploymentInstance) cbInstances.getSelectedItem();
44+
instance = (SpringCloudDeploymentInstanceEntity) cbInstances.getSelectedItem();
4545
super.doOKAction();
4646
}
4747

0 commit comments

Comments
 (0)