Skip to content

Commit ea35e83

Browse files
dispose browser when disposing editor
1 parent 63da75d commit ea35e83

File tree

1 file changed

+6
-3
lines changed
  • PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/feedback

1 file changed

+6
-3
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/feedback/ProvideFeedbackEditor.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@
3030

3131
public class ProvideFeedbackEditor extends BaseEditor implements DumbAware {
3232
private final JBCefJSQuery myJSQueryOpenInBrowser;
33+
private final JBCefBrowser jbCefBrowser;
3334
private JPanel pnlRoot;
3435

3536
public ProvideFeedbackEditor(final Project project, VirtualFile virtualFile) {
3637
super(virtualFile);
37-
final JBCefBrowser jbCefBrowser = new JBCefBrowser("https://www.surveymonkey.com/r/PNB5NBL?mode=simple");
38+
this.jbCefBrowser = new JBCefBrowser("https://www.surveymonkey.com/r/PNB5NBL?mode=simple");
3839
final CefBrowser browser = jbCefBrowser.getCefBrowser();
3940
final JBCefClient client = jbCefBrowser.getJBCefClient();
4041
pnlRoot.add(jbCefBrowser.getComponent(), new GridConstraints(0, 0, 1, 1, 0, GridConstraints.FILL_BOTH, 3, 3, null, null, null, 0));
@@ -98,13 +99,15 @@ public JComponent getComponent() {
9899
}
99100

100101
@Override
101-
public @Nls(capitalization = Nls.Capitalization.Title)
102-
@Nonnull String getName() {
102+
@Nonnull
103+
@Nls(capitalization = Nls.Capitalization.Title)
104+
public String getName() {
103105
return "Provide Feedback";
104106
}
105107

106108
@Override
107109
public void dispose() {
108110
Disposer.dispose(myJSQueryOpenInBrowser);
111+
Disposer.dispose(jbCefBrowser);
109112
}
110113
}

0 commit comments

Comments
 (0)