Skip to content

Commit f236a58

Browse files
authored
Merge pull request #5418 from microsoft/qianjin-endgame-june-fix
set SDK "Others" Category as the last item and tidy messages/properties of SQL server.
2 parents 37a9a5c + c6ea5e1 commit f236a58

File tree

6 files changed

+14
-16
lines changed

6 files changed

+14
-16
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/azure-sdk-reference-book/src/main/java/com/microsoft/azure/toolkit/intellij/azuresdk/referencebook/AzureSdkTreePanel.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@ private void loadData(final Map<String, List<AzureSdkCategoryEntity>> categoryTo
131131
final DefaultMutableTreeNode root = (DefaultMutableTreeNode) this.model.getRoot();
132132
root.removeAllChildren();
133133
final Map<String, AzureSdkServiceEntity> serviceMap = services.stream().collect(Collectors.toMap(e -> getServiceKeyByName(e.getName()), e -> e));
134-
final List<String> categories = categoryToServiceMap.keySet().stream().sorted().collect(Collectors.toList());
134+
final List<String> categories = categoryToServiceMap.keySet().stream().filter(StringUtils::isNotBlank).sorted(
135+
(s1, s2) -> StringUtils.contains(s1, "Others") ? 1 : StringUtils.contains(s2, "Others") ? -1 : s1.compareTo(s2)).collect(Collectors.toList());
135136
for (final String category : categories) {
136137
// no feature found for current category
137138
if (CollectionUtils.isEmpty(categoryToServiceMap.get(category)) ||
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
sqlserver.create=create Azure Database for SQL Server({0}) in subscription({1})
2-
sqlserver|database.list.server|subscription=list all Azure SQL Server database schemas in server({0}) of subscription({1})
3-
sqlserver|region.list.supported=list Azure SQL Server-supported regions
4-
sqlserver|version.list.supported=list Azure SQL Server-supported versions
5-
sqlserver.update_password=update password of SQL Server instance
6-
sqlserver.connect_server=connect to Azure SQL Server({0})
7-
sqlserver.delete=delete SQL Server({0})
8-
sqlserver.open_portal=open configuration page of SQL Server({0}) in portal
9-
sqlserver.show_properties=show properties of SQL Server({0})
1+
sqlserver|server.create=create SQL Server({0}) in subscription({1})
2+
sqlserver|server.delete=delete SQL Server({0})
3+
sqlserver|server.open_portal=open configuration page of SQL Server({0}) in portal
4+
sqlserver|server.show_properties=show properties of SQL Server({0})
5+
sqlserver|server.open_by_database_tools=open SQL Server({0}) by Database Tools plugin.
6+
sqlserver|server.database_load|subscription=list all SQL Server databases in server({0}) of subscription({1})

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/sqlserver/OpenSqlServerByToolsAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ protected String getOperationName(NodeActionEvent event) {
6060
return ActionConstants.parse(ActionConstants.SqlServer.CONNECT_TO_SERVER).getOperationName();
6161
}
6262

63-
@AzureOperation(name = "sqlserver.connect_server", params = {"this.node.getServer().entity().getName()"}, type = AzureOperation.Type.ACTION)
63+
@AzureOperation(name = "sqlserver|server.open_by_database_tools", params = {"this.node.getServer().entity().getName()"}, type = AzureOperation.Type.ACTION)
6464
private void doActionPerformed(boolean isLoggedIn, Project project) {
6565
try {
6666
if (!isLoggedIn ||

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/sqlserver/common/SqlServerDatabaseComboBox.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ protected String getItemText(Object item) {
4444

4545
@Override
4646
@AzureOperation(
47-
name = "sqlserver|database.list.server|subscription",
47+
name = "sqlserver|server.database_load|subscription",
4848
params = {"this.server.name()", "this.subscription.subscriptionId()"},
4949
type = AzureOperation.Type.SERVICE
5050
)

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/sqlserver/task/CreateSqlServerTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public CreateSqlServerTask(SqlServerConfig config) {
3434
}
3535

3636
@AzureOperation(
37-
name = "sqlserver.create",
37+
name = "sqlserver|server.create",
3838
params = {
3939
"config.getServerName()",
4040
"config.getSubscription().displayName()"

Utils/azure-explorer-common/src/com/microsoft/tooling/msservices/serviceexplorer/azure/sqlserver/SqlServerNode.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,18 @@ public List<NodeAction> getNodeActions() {
6666
return super.getNodeActions();
6767
}
6868

69-
@AzureOperation(name = "sqlserver.delete", params = {"this.server.entity().getName()"}, type = AzureOperation.Type.ACTION)
69+
@AzureOperation(name = "sqlserver|server.delete", params = {"this.server.entity().getName()"}, type = AzureOperation.Type.ACTION)
7070
private void delete() {
7171
this.serverState = SERVER_UPDATING;
7272
this.getParent().removeNode(this.subscriptionId, this.getId(), SqlServerNode.this);
7373
}
7474

75-
@AzureOperation(name = "sqlserver.open_portal", params = {"this.server.entity().getName()"}, type = AzureOperation.Type.ACTION)
75+
@AzureOperation(name = "sqlserver|server.open_portal", params = {"this.server.entity().getName()"}, type = AzureOperation.Type.ACTION)
7676
private void openInPortal() {
7777
this.openResourcesInPortal(this.subscriptionId, this.server.entity().getId());
7878
}
7979

80-
@AzureOperation(name = "sqlserver.show_properties", params = {"this.server.entity().getName()"}, type = AzureOperation.Type.ACTION)
80+
@AzureOperation(name = "sqlserver|server.show_properties", params = {"this.server.entity().getName()"}, type = AzureOperation.Type.ACTION)
8181
private void showProperties() {
8282
DefaultLoader.getUIHelper().openSqlServerPropertyView(SqlServerNode.this);
8383
}

0 commit comments

Comments
 (0)