Skip to content

Commit f9db2df

Browse files
authored
Merge pull request #5273 from microsoft/feature-track2-common-resource-2
Feature track2 common resource 2
2 parents a9a9c32 + ff0fac0 commit f9db2df

File tree

21 files changed

+80
-38
lines changed

21 files changed

+80
-38
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/appservice/AppServiceInfoAdvancedPanel.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import com.intellij.ui.TitledSeparator;
1010
import com.microsoft.azure.management.appservice.AppServicePlan;
1111
import com.microsoft.azure.management.appservice.OperatingSystem;
12-
import com.microsoft.azure.management.appservice.PricingTier;
12+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1313
import com.microsoft.azure.toolkit.intellij.appservice.platform.PlatformComboBox;
1414
import com.microsoft.azure.toolkit.intellij.appservice.region.RegionComboBox;
1515
import com.microsoft.azure.toolkit.intellij.appservice.resourcegroup.ResourceGroupComboBox;
@@ -198,7 +198,10 @@ private void onSubscriptionChanged(final ItemEvent e) {
198198
private void onServicePlanChanged(final ItemEvent e) {
199199
if (e.getStateChange() == ItemEvent.SELECTED) {
200200
final AppServicePlan plan = (AppServicePlan) e.getItem();
201-
final String pricing = plan.pricingTier() == AzureFunctionMvpModel.CONSUMPTION_PRICING_TIER ?
201+
if (plan.pricingTier() == null) {
202+
return;
203+
}
204+
final String pricing = StringUtils.equals(plan.pricingTier().toSkuDescription().tier(), AzureFunctionMvpModel.CONSUMPTION_PRICING_TIER.getTier()) ?
202205
"Consumption" : plan.pricingTier().toString();
203206
this.textSku.setText(pricing);
204207
} else if (e.getStateChange() == ItemEvent.DESELECTED) {

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/appservice/region/RegionComboBox.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package com.microsoft.azure.toolkit.intellij.appservice.region;
77

8-
import com.microsoft.azure.management.appservice.PricingTier;
8+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
99
import com.microsoft.azure.toolkit.intellij.common.AzureComboBox;
1010
import com.microsoft.azure.toolkit.lib.auth.AzureAccount;
1111
import com.microsoft.azure.toolkit.lib.common.model.Region;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/appservice/serviceplan/PricingTierComboBox.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@
55

66
package com.microsoft.azure.toolkit.intellij.appservice.serviceplan;
77

8-
import com.microsoft.azure.management.appservice.PricingTier;
8+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
99
import com.microsoft.azure.toolkit.intellij.common.AzureComboBox;
1010
import com.microsoft.azuretools.azurecommons.helpers.NotNull;
1111
import com.microsoft.azuretools.core.mvp.model.function.AzureFunctionMvpModel;
1212

1313
import java.util.Collections;
1414
import java.util.List;
15+
import java.util.Objects;
1516

1617
import static com.microsoft.intellij.ui.messages.AzureBundle.message;
1718

@@ -33,7 +34,12 @@ public void setPricingTierList(final List<PricingTier> pricingTierList) {
3334

3435
@Override
3536
protected String getItemText(final Object item) {
36-
return item == AzureFunctionMvpModel.CONSUMPTION_PRICING_TIER ? message("appService.pricingTier.consumption") : super.getItemText(item);
37+
if (Objects.isNull(item)) {
38+
return EMPTY_ITEM;
39+
}
40+
PricingTier pricingTier = (PricingTier) item;
41+
return pricingTier == AzureFunctionMvpModel.CONSUMPTION_PRICING_TIER ? message("appService.pricingTier.consumption") :
42+
pricingTier.getTier() + "_" + pricingTier.getSize();
3743
}
3844

3945
@NotNull

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/appservice/serviceplan/ServicePlanComboBox.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import com.intellij.ui.components.fields.ExtendableTextComponent;
1010
import com.microsoft.azure.management.appservice.AppServicePlan;
1111
import com.microsoft.azure.management.appservice.OperatingSystem;
12-
import com.microsoft.azure.management.appservice.PricingTier;
12+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1313
import com.microsoft.azure.toolkit.intellij.common.AzureComboBox;
1414
import com.microsoft.azure.toolkit.intellij.common.Draft;
1515
import com.microsoft.azure.toolkit.lib.appservice.DraftServicePlan;
@@ -38,7 +38,7 @@ public class ServicePlanComboBox extends AzureComboBox<AppServicePlan> {
3838
private OperatingSystem os;
3939
private Region region;
4040

41-
private List<PricingTier> pricingTierList = new ArrayList<>(PricingTier.getAll());
41+
private List<PricingTier> pricingTierList = new ArrayList<>(PricingTier.WEB_APP_PRICING);
4242
private PricingTier defaultPricingTier = PricingTier.BASIC_B2;
4343

4444
private Predicate<AppServicePlan> servicePlanFilter;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/appservice/serviceplan/ServicePlanCreationDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import com.intellij.ui.components.JBLabel;
99
import com.microsoft.azure.management.appservice.OperatingSystem;
10-
import com.microsoft.azure.management.appservice.PricingTier;
10+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1111
import com.microsoft.azure.toolkit.intellij.common.AzureDialog;
1212
import com.microsoft.azure.toolkit.intellij.common.SwingUtils;
1313
import com.microsoft.azure.toolkit.intellij.common.ValidationDebouncedTextInput;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/function/FunctionAppConfigFormPanelAdvance.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import com.intellij.openapi.project.Project;
99
import com.intellij.ui.DocumentAdapter;
1010
import com.microsoft.azure.management.appservice.OperatingSystem;
11-
import com.microsoft.azure.management.appservice.PricingTier;
11+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1212
import com.microsoft.azure.toolkit.intellij.appservice.AppServiceInfoAdvancedPanel;
1313
import com.microsoft.azure.toolkit.intellij.appservice.AppServiceMonitorPanel;
1414
import com.microsoft.azure.toolkit.intellij.appservice.insights.ApplicationInsightsComboBox;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/function/runner/component/AppServicePlanPanel.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import com.intellij.ui.SimpleListCellRenderer;
1010
import com.microsoft.azure.management.appservice.AppServicePlan;
1111
import com.microsoft.azure.management.appservice.OperatingSystem;
12-
import com.microsoft.azure.management.appservice.PricingTier;
12+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1313
import com.microsoft.azure.toolkit.lib.common.model.Region;
1414
import com.microsoft.azure.toolkit.lib.common.operation.AzureOperation;
1515
import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
@@ -92,7 +92,7 @@ public String getAppServicePlanRegion() {
9292
}
9393

9494
public String getAppServicePlanPricingTier() {
95-
return selectedAppServicePlan == null ? null : selectedAppServicePlan.getPricingTier().toSkuDescription().size();
95+
return selectedAppServicePlan == null ? null : selectedAppServicePlan.getPricingTier().getSize();
9696
}
9797

9898
public String getAppServicePlanResourceGroup() {
@@ -217,7 +217,7 @@ public AppServicePlanWrapper(AppServicePlan appServicePlan) {
217217
this.isNewCreate = false;
218218
this.name = appServicePlan.name();
219219
this.region = Region.fromName(appServicePlan.region().name());
220-
this.pricingTier = appServicePlan.pricingTier();
220+
this.pricingTier = fromPricingTier(appServicePlan.pricingTier());
221221
this.operatingSystem = appServicePlan.operatingSystem();
222222
this.resourceGroup = appServicePlan.resourceGroupName();
223223
}
@@ -258,4 +258,11 @@ public String toString() {
258258
return isNewCreate ? String.format(NEW_CREATED_RESOURCE, name) : String.format("%s (Resource Group: %s)", name, resourceGroup);
259259
}
260260
}
261+
262+
static PricingTier fromPricingTier(com.microsoft.azure.management.appservice.PricingTier pricingTier) {
263+
return PricingTier.values().stream()
264+
.filter(value -> StringUtils.equals(value.getSize(), pricingTier.toSkuDescription().size()) &&
265+
StringUtils.equals(value.getTier(), pricingTier.toSkuDescription().tier()))
266+
.findFirst().orElse(null);
267+
}
261268
}

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/function/runner/component/NewAppServicePlanDialog.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import com.intellij.openapi.ui.ValidationInfo;
99
import com.intellij.ui.ListCellRendererWrapper;
10-
import com.microsoft.azure.management.appservice.PricingTier;
10+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1111
import com.microsoft.azure.management.appservice.SkuName;
1212
import com.microsoft.azure.toolkit.lib.common.model.Region;
1313
import com.microsoft.azuretools.core.mvp.model.function.AzureFunctionMvpModel;
@@ -157,7 +157,7 @@ private void onLoadPricingTier() {
157157

158158
// We will mark function only pricing tier as recommend
159159
private static boolean isRecommendPricingTier(PricingTier pricingTier) {
160-
final String tier = pricingTier.toSkuDescription().tier();
160+
final String tier = pricingTier.getTier();
161161
return pricingTier == CONSUMPTION_PRICING_TIER || StringUtils.equals(SkuName.ELASTIC_PREMIUM.toString(), tier);
162162
}
163163
}

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/webapp/WebAppConfigFormPanelAdvance.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import com.intellij.openapi.project.Project;
99
import com.microsoft.azure.management.appservice.OperatingSystem;
10-
import com.microsoft.azure.management.appservice.PricingTier;
10+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1111
import com.microsoft.azure.toolkit.intellij.appservice.AppServiceInfoAdvancedPanel;
1212
import com.microsoft.azure.toolkit.intellij.appservice.AppServiceMonitorPanel;
1313
import com.microsoft.azure.toolkit.intellij.common.AzureFormPanel;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/webapp/WebAppCreationDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
package com.microsoft.azure.toolkit.intellij.webapp;
77

88
import com.intellij.openapi.project.Project;
9-
import com.microsoft.azure.management.appservice.PricingTier;
9+
import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
1010
import com.microsoft.azure.toolkit.intellij.appservice.AppConfigDialog;
1111
import com.microsoft.azure.toolkit.intellij.appservice.AppServiceInfoBasicPanel;
1212
import com.microsoft.azure.toolkit.intellij.common.AzureFormPanel;

0 commit comments

Comments
 (0)