Skip to content

Commit fdb7a4e

Browse files
#1951398: [Test]Failed to create App Service plan
1 parent d9fd50c commit fdb7a4e

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.appservice/src/com/microsoft/azure/toolkit/eclipse/appservice/AppServiceCreationComposite.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import java.util.stream.Collectors;
1313
import java.util.stream.Stream;
1414

15+
import org.apache.commons.lang3.ObjectUtils;
1516
import org.apache.commons.lang3.StringUtils;
1617
import org.eclipse.swt.SWT;
1718
import org.eclipse.swt.layout.FillLayout;
@@ -107,10 +108,14 @@ public T getValue() {
107108
result.setName(instanceDetailPanel.getAppName());
108109
result.setRegion(instanceDetailPanel.getResourceRegion());
109110
result.setRuntime(Runtime.getRuntime(runtime.os(), runtime.webContainer(), runtime.javaVersion()));
110-
result.setServicePlan(AppServicePlanConfig.fromResource(appServicePlanPanel.getServicePlan()));
111111
result.setPricingTier(Optional.ofNullable(appServicePlanPanel.getServicePlan())
112112
.map(AppServicePlan::getPricingTier).orElse(null));
113113
result.setAppSettings(new HashMap<>());
114+
final AppServicePlanConfig planConfig = AppServicePlanConfig.fromResource(appServicePlanPanel.getServicePlan());
115+
planConfig.setResourceGroupName(
116+
StringUtils.firstNonBlank(planConfig.getResourceGroupName(), result.getResourceGroupName()));
117+
planConfig.setRegion(ObjectUtils.firstNonNull(planConfig.getRegion(), result.getRegion()));
118+
result.setServicePlan(planConfig);
114119
return result;
115120
}
116121

PluginsAndFeatures/azure-toolkit-for-eclipse/com.microsoft.azuretools.appservice/src/com/microsoft/azure/toolkit/eclipse/appservice/serviceplan/ServicePlanCreationDialog.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ protected Control createDialogArea(Composite parent) {
7979
lblPricingTier.setText("Pricing tier:");
8080

8181
pricingTierCombobox = new PricingTierCombobox(container, this.pricingTiers);
82+
pricingTierCombobox.setValue(PricingTier.BASIC_B1);
8283
pricingTierCombobox.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, false, false, 1, 1));
8384
pricingTierCombobox.setLabeledBy(lblPricingTier);
8485

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/appservice/AppServiceInfoAdvancedPanel.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import com.microsoft.azure.toolkit.lib.resource.ResourceGroupConfig;
3131
import com.microsoft.azuretools.utils.WebAppUtils;
3232
import org.apache.commons.compress.utils.FileNameUtils;
33+
import org.apache.commons.lang3.ObjectUtils;
3334
import org.apache.commons.lang3.StringUtils;
3435

3536
import javax.swing.*;
@@ -95,7 +96,10 @@ public T getValue() {
9596
config.setName(name);
9697
config.setRuntime(runtime);
9798
config.setRegion(region);
98-
config.setServicePlan(AppServicePlanConfig.fromResource(servicePlan));
99+
final AppServicePlanConfig planConfig = AppServicePlanConfig.fromResource(servicePlan);
100+
planConfig.setResourceGroupName(StringUtils.firstNonBlank(planConfig.getResourceGroupName(), config.getResourceGroupName()));
101+
planConfig.setRegion(ObjectUtils.firstNonNull(planConfig.getRegion(), config.getRegion()));
102+
config.setServicePlan(planConfig);
99103
if (Objects.nonNull(artifact)) {
100104
final AzureArtifactManager manager = AzureArtifactManager.getInstance(this.project);
101105
final String path = manager.getFileForDeployment(this.selectorApplication.getValue());

0 commit comments

Comments
 (0)