From 20738258c79f36a4d1faf97a4b53f8d0d99bef7b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <t-njmwenjwa@microsoft.com>
Date: Thu, 6 Jun 2024 15:33:03 -0700
Subject: [PATCH 001/144] hello world rule

---
 .../.idea/gradle.xml                          |  3 ++
 .../azure/sdk/buildtool/HelloWorld.java       | 50 +++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       | 11 ++++
 3 files changed, 64 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
index 0e2731864ba..1b74c3eb9f7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
@@ -14,6 +14,7 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-arm" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-azure-sdk" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-bicep" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-cognitiveservices" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-containerapps" />
@@ -28,11 +29,13 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-base" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-lib" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-integration-services" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-keyvault" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-monitor" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-redis" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-samples" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-service-explorer" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-servicebus" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-sparkoncosmos" />
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java
new file mode 100644
index 00000000000..a184327ded4
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java
@@ -0,0 +1,50 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+// make a class similar to MavenProjectInspection to trigger a hello world statement
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.lang.StdLanguages;
+import com.intellij.psi.FileViewProvider;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiFile;
+import com.intellij.psi.xml.XmlFile;
+import com.intellij.psi.xml.XmlTag;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.NotNull;
+
+public class HelloWorld extends LocalInspectionTool{
+
+    @Nls
+    @NotNull
+    @Override
+    public String getDisplayName() {
+        return "Hello World!!";
+    }
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new PsiElementVisitor() {
+
+            @Override
+            public void visitFile(@NotNull PsiFile file) {
+                if (file.getName().equals("pom.xml")) {
+                    System.out.println("Hello World!!");
+                    holder.registerProblem(file, "Hello World!!");
+
+
+                    FileViewProvider viewProvider = file.getViewProvider();
+                    XmlFile xmlFile = (XmlFile) viewProvider.getPsi(StdLanguages.XML);
+
+                    XmlTag rootTag = xmlFile.getRootTag();
+                    showError(rootTag, holder);
+                }
+            }
+        };
+    }
+
+    private static void showError (XmlTag rootTag, @NotNull ProblemsHolder holder) {
+        holder.registerProblem(rootTag, "Hello World!!");
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..f1126fae8ce 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,16 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+            language="XML"
+            shortName="HelloWorld"
+            displayName="Hello World"
+            groupName="Azure SDK Rules"
+            enabledByDefault="true"
+            level="WARNING"
+            implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HelloWorld">
+            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HelloWorld</class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From 881f7bab895b044314215c3b88e5a11a37390888 Mon Sep 17 00:00:00 2001
From: Njeriiii <joymwenjwa@gmail.com>
Date: Mon, 10 Jun 2024 16:27:52 -0700
Subject: [PATCH 002/144] UseStorageAPIsWithLengthParameter rule

---
 .../UseStorageAPIsWithLengthParameter.java    | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java
new file mode 100644
index 00000000000..e726fe6270e
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java
@@ -0,0 +1,44 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.*;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.Arrays;
+import java.util.List;
+
+
+public class UseStorageAPIsWithLengthParameter extends LocalInspectionTool {
+    @Nls
+    @NotNull
+    @Override
+    public String getDisplayName() {
+        return "Use Storage APIs With Length Parameter";
+    }
+
+    private static final List<String> METHODS_TO_CHECK = Arrays.asList("uploadFromFile", "upload", "uploadWithResponse");
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new JavaRecursiveElementWalkingVisitor() {
+            @Override
+            public void visitMethodCallExpression(PsiMethodCallExpression expression) {
+                super.visitMethodCallExpression(expression);
+                String methodName = expression.getMethodExpression().getReferenceName();
+                if (METHODS_TO_CHECK.contains(methodName)) {
+                    PsiExpression[] arguments = expression.getArgumentList().getExpressions();
+                    boolean hasInputStreamArg = Arrays.stream(arguments)
+                            .anyMatch(arg -> arg.getType().equalsToText("java.io.InputStream"));
+                    if (!hasInputStreamArg) {
+                        holder.registerProblem(expression, "Use Storage APIs With Length Parameter");
+                    }
+                }
+            }
+
+            ;
+        };
+    }
+}

From f9be8804b6038534a8548a633b7b2511581ebac0 Mon Sep 17 00:00:00 2001
From: Njeriiii <joymwenjwa@gmail.com>
Date: Mon, 10 Jun 2024 16:29:43 -0700
Subject: [PATCH 003/144] UseStorageAPIsWithLengthParameter rule

---
 .../azure-toolkit-for-intellij/.gitignore              |  3 +++
 .../META-INF/azure-intellij-plugin-azure-sdk.xml       | 10 +++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 6691dbbf974..6df47059e18 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -44,3 +44,6 @@ gen-external-apklibs/
 
 # Jar dependencies generated in build
 **/resources/spark/spark-tools-*.jar
+
+# IntelliJ
+.idea/
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index f1126fae8ce..b92b1c1fc1e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -25,14 +25,14 @@
         </localInspection>
 
         <localInspection
-            language="XML"
-            shortName="HelloWorld"
-            displayName="Hello World"
+            language="JAVA"
+            shortName="UseStorageAPIsWithLengthParameter"
+            displayName="Use Storage APIs with Length Parameter"
             groupName="Azure SDK Rules"
             enabledByDefault="true"
             level="WARNING"
-            implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HelloWorld">
-            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HelloWorld</class>
+            implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseStorageAPIsWithLengthParameter">
+            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseStorageAPIsWithLengthParameter</class>
         </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From 7dd8cd143e561e68d0d1e20a51e13571bf83f7e9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 12 Jun 2024 23:49:15 -0700
Subject: [PATCH 004/144] fully address 8/9 PR comments

---
 .../azure-toolkit-for-intellij/.gitignore     |  2 +-
 .../build.gradle                              |  2 +-
 .../azure-intellij-plugin-azure-sdk/readme.md | 25 +++++++
 .../azure/sdk/buildtool/HelloWorld.java       | 50 --------------
 .../StorageUploadWithoutLengthCheck.java      | 69 +++++++++++++++++++
 .../UseStorageAPIsWithLengthParameter.java    | 44 ------------
 .../azure/sdk/buildtool/ruleConfigs.json      |  5 ++
 .../azure-intellij-plugin-azure-sdk.xml       | 13 ++--
 8 files changed, 109 insertions(+), 101 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 6df47059e18..8f090d60b2f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -46,4 +46,4 @@ gen-external-apklibs/
 **/resources/spark/spark-tools-*.jar
 
 # IntelliJ
-.idea/
\ No newline at end of file
+.idea/
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..7849525a297 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,5 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
-
+    implementation group: 'org.json', name: 'json', version: '20240303'
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
new file mode 100644
index 00000000000..f349282973d
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -0,0 +1,25 @@
+# Project: Java Code Quality Analyzer
+
+## Project Description
+The Java Code Quality Analyzer, is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
+
+## Key Features
+
+- **Rule Set Integration**: This feature enables users to import and customize rule sets, tailoring the plugin to their specific needs.
+- **Telemetry Integration**: This feature connects the plugin to the backend with Application Insights, allowing for efficient data transmission.
+- **Azure Toolkit Integration**: This feature allows the plugin to integrate with the IntelliJ Azure toolkit, providing extended functionality.
+- **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
+- **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
+
+## User Interface
+
+- **Analysis Button**: Users can initiate code analysis which provides immediate feedback and sends telemetry information.
+- **Results Display**: This is a central area where users can view detailed violations and outcomes of the analysis.
+- **Rule Configuration Panel** : This space allows users to toggle rules for customization and disable telemetry if desired.
+- **Refresh/Clear Functionality**: Users can clear previous results and re-run the analysis at any time.
+
+## Rules
+1. #### Storage Upload without Length Check
+   Using Azure Storage upload APIs that don’t take a length parameter. This approach can lead to OutOfMemoryErrors, especially when dealing with large files or high-volume uploads
+    ##### Severity: INFO. 
+    #### Solution: Use APIs that take a length parameter.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java
deleted file mode 100644
index a184327ded4..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HelloWorld.java
+++ /dev/null
@@ -1,50 +0,0 @@
-package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
-
-// make a class similar to MavenProjectInspection to trigger a hello world statement
-
-import com.intellij.codeInspection.LocalInspectionTool;
-import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.lang.StdLanguages;
-import com.intellij.psi.FileViewProvider;
-import com.intellij.psi.PsiElementVisitor;
-import com.intellij.psi.PsiFile;
-import com.intellij.psi.xml.XmlFile;
-import com.intellij.psi.xml.XmlTag;
-import org.jetbrains.annotations.Nls;
-import org.jetbrains.annotations.NotNull;
-
-public class HelloWorld extends LocalInspectionTool{
-
-    @Nls
-    @NotNull
-    @Override
-    public String getDisplayName() {
-        return "Hello World!!";
-    }
-
-    @NotNull
-    @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new PsiElementVisitor() {
-
-            @Override
-            public void visitFile(@NotNull PsiFile file) {
-                if (file.getName().equals("pom.xml")) {
-                    System.out.println("Hello World!!");
-                    holder.registerProblem(file, "Hello World!!");
-
-
-                    FileViewProvider viewProvider = file.getViewProvider();
-                    XmlFile xmlFile = (XmlFile) viewProvider.getPsi(StdLanguages.XML);
-
-                    XmlTag rootTag = xmlFile.getRootTag();
-                    showError(rootTag, holder);
-                }
-            }
-        };
-    }
-
-    private static void showError (XmlTag rootTag, @NotNull ProblemsHolder holder) {
-        holder.registerProblem(rootTag, "Hello World!!");
-    }
-}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
new file mode 100644
index 00000000000..d743f31b4f3
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -0,0 +1,69 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.*;
+import org.json.*;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.NotNull;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+
+
+/**
+ * This class extends the LocalInspectionTool and is used to inspect the usage of Azure Storage upload APIs in the code.
+ * It checks if the upload methods are being called without a 'length' parameter of type 'long'.
+ * The methods to check are defined in a JSON configuration file.
+ * If such a method call is detected, a problem is registered with the ProblemsHolder.
+ */
+
+public class StorageUploadWithoutLengthCheck extends LocalInspectionTool {
+    @Nls
+    @NotNull
+    @Override
+    public String getDisplayName() {
+        return "Use Storage APIs With Length Parameter";
+    }
+
+    private static final List<String> METHODS_TO_CHECK = getMethodsToCheck();
+
+    private static List<String> getMethodsToCheck() {
+        try {
+            JSONObject jsonObject = new JSONObject(new String(Files.readAllBytes(Paths.get("C:/Users/t-njmwenjwa/Documents/azure-tools-for-java/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json"))));
+            JSONArray methods = jsonObject.getJSONObject("StorageUploadWithoutLengthCheck").getJSONArray("methodsToCheck");
+            return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
+        } catch (Exception e) {
+            e.printStackTrace();
+            return Collections.emptyList();
+        }
+    }
+
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new JavaRecursiveElementWalkingVisitor() {
+            @Override
+            public void visitMethodCallExpression(PsiMethodCallExpression expression) {
+                super.visitMethodCallExpression(expression);
+                String methodName = expression.getMethodExpression().getReferenceName();
+
+                if (METHODS_TO_CHECK.contains(methodName)) {
+                    PsiExpression[] arguments = expression.getArgumentList().getExpressions();
+
+                    // TODO: check if a parameter object instantiated from a class with a length parameter field will NOT be detected.
+                    // eg line 150 stream parameter in sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/LargeBlobTests.java
+                    boolean hasLengthArg = Arrays.stream(arguments)
+                            .anyMatch(arg -> arg.getType().equalsToText("long"));
+                    if (!hasLengthArg) {
+                        holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
+                    }
+                }
+            };
+        };
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java
deleted file mode 100644
index e726fe6270e..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseStorageAPIsWithLengthParameter.java
+++ /dev/null
@@ -1,44 +0,0 @@
-package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
-
-import com.intellij.codeInspection.LocalInspectionTool;
-import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.psi.*;
-import org.jetbrains.annotations.Nls;
-import org.jetbrains.annotations.NotNull;
-
-import java.util.Arrays;
-import java.util.List;
-
-
-public class UseStorageAPIsWithLengthParameter extends LocalInspectionTool {
-    @Nls
-    @NotNull
-    @Override
-    public String getDisplayName() {
-        return "Use Storage APIs With Length Parameter";
-    }
-
-    private static final List<String> METHODS_TO_CHECK = Arrays.asList("uploadFromFile", "upload", "uploadWithResponse");
-
-    @NotNull
-    @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new JavaRecursiveElementWalkingVisitor() {
-            @Override
-            public void visitMethodCallExpression(PsiMethodCallExpression expression) {
-                super.visitMethodCallExpression(expression);
-                String methodName = expression.getMethodExpression().getReferenceName();
-                if (METHODS_TO_CHECK.contains(methodName)) {
-                    PsiExpression[] arguments = expression.getArgumentList().getExpressions();
-                    boolean hasInputStreamArg = Arrays.stream(arguments)
-                            .anyMatch(arg -> arg.getType().equalsToText("java.io.InputStream"));
-                    if (!hasInputStreamArg) {
-                        holder.registerProblem(expression, "Use Storage APIs With Length Parameter");
-                    }
-                }
-            }
-
-            ;
-        };
-    }
-}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json
new file mode 100644
index 00000000000..c0dff0bfe81
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json
@@ -0,0 +1,5 @@
+{
+  "StorageUploadWithoutLengthCheck": {
+    "methodsToCheck": ["uploadFromFile", "upload", "uploadWithResponse"]
+  }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index b92b1c1fc1e..744262b38bd 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -26,13 +26,16 @@
 
         <localInspection
             language="JAVA"
-            shortName="UseStorageAPIsWithLengthParameter"
-            displayName="Use Storage APIs with Length Parameter"
+            shortName="StorageUploadWithoutLengthCheck"
+            displayName="Storage Upload Without LengthCheck"
             groupName="Azure SDK Rules"
             enabledByDefault="true"
-            level="WARNING"
-            implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseStorageAPIsWithLengthParameter">
-            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseStorageAPIsWithLengthParameter</class>
+            level="INFO"
+
+            implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.StorageUploadWithoutLengthCheck">
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseStorageAPIsWithLengthParameter
+            </class>
         </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From d07d3ce8ba1e7ac4162188ad4fa80096eab8bc8b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 14 Jun 2024 10:18:24 -0700
Subject: [PATCH 005/144] use of ServiceBusReceiverAsyncClient rule

---
 .../.idea/gradle.xml                          |  3 ++
 .../ServiceBusReceiverAsyncClientCheck.java   | 34 +++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       | 14 ++++++++
 3 files changed, 51 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
index 0e2731864ba..1b74c3eb9f7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
@@ -14,6 +14,7 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-arm" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-azure-sdk" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-bicep" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-cognitiveservices" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-containerapps" />
@@ -28,11 +29,13 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-base" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-lib" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-integration-services" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-keyvault" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-monitor" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-redis" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-samples" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-service-explorer" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-servicebus" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-sparkoncosmos" />
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
new file mode 100644
index 00000000000..5e776e8a932
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -0,0 +1,34 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.*;
+import com.intellij.psi.*;
+import org.jetbrains.annotations.NotNull;
+
+
+/**
+ * This class extends the LocalInspectionTool to check for the use of ServiceBusReceiverAsyncClient
+ * in the code and suggests using ServiceBusProcessorClient instead.
+ */
+public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
+
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+
+        return new JavaElementVisitor() {
+
+            @Override
+            public void visitLocalVariable(PsiLocalVariable variable) {
+                super.visitLocalVariable(variable);
+
+                final PsiType type = variable.getType();
+                final String qualifiedName = type.getCanonicalText();
+
+                if (qualifiedName.equals("com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient")) {
+                    holder.registerProblem(variable, "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead.");
+                }
+            }
+        };
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..020d89832bc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,19 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="ServiceBusReceiverAsyncClientCheck"
+                displayName="ServiceBusReceiverAsyncClient Check"
+                groupName="Azure SDK"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From f54c668d3cb6e7c87defecb6a6bb10b063951f61 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 13 Jun 2024 15:31:21 -0700
Subject: [PATCH 006/144] connection string rule

---
 .../.idea/gradle.xml                          |  3 ++
 .../sdk/buildtool/ConnectionStringCheck.java  | 29 +++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       | 14 +++++++++
 3 files changed, 46 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
index 0e2731864ba..1b74c3eb9f7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
@@ -14,6 +14,7 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-arm" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-azure-sdk" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-bicep" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-cognitiveservices" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-containerapps" />
@@ -28,11 +29,13 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-base" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-lib" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-integration-services" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-keyvault" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-monitor" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-redis" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-samples" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-service-explorer" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-servicebus" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-sparkoncosmos" />
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
new file mode 100644
index 00000000000..2a01b7e472e
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -0,0 +1,29 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.*;
+import com.intellij.psi.*;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * This class extends the LocalInspectionTool and checks for the usage of connection strings in the code.
+ * Connection strings that start with "DefaultEndpointsProtocol=http;AccountName=" are flagged as problems.
+ * This is because the use of such connection strings is not recommended.
+ */
+public class ConnectionStringCheck extends LocalInspectionTool {
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new JavaElementVisitor() {
+            @Override
+            public void visitLiteralExpression(PsiLiteralExpression expression) {
+                super.visitLiteralExpression(expression);
+
+                String value = expression.getValue() instanceof String ? (String) expression.getValue() : null;
+
+                if (value != null && value.startsWith("DefaultEndpointsProtocol=http;AccountName=")) {
+                    holder.registerProblem(expression, "Use of connection strings is not recommended");
+                }
+            }
+        };
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..413eb6afcef 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,19 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="ConnectionStringCheck"
+                displayName="Connection String Check"
+                groupName="Maven"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ClosingCloseableClientsCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From b0795897ed1278c9ad8297016555182fcfe85e04 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 17 Jun 2024 20:35:39 -0700
Subject: [PATCH 007/144] extend to include method call chain parameters

---
 .../azure-intellij-plugin-azure-sdk/readme.md |  4 --
 .../StorageUploadWithoutLengthCheck.java      | 65 +++++++++++++++----
 .../azure/sdk/buildtool/ruleConfigs.json      |  5 --
 .../main/resources/META-INF/ruleConfigs.json  |  8 +++
 4 files changed, 60 insertions(+), 22 deletions(-)
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index f349282973d..83f5cb5c885 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -12,11 +12,7 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 
 ## User Interface
-
-- **Analysis Button**: Users can initiate code analysis which provides immediate feedback and sends telemetry information.
-- **Results Display**: This is a central area where users can view detailed violations and outcomes of the analysis.
 - **Rule Configuration Panel** : This space allows users to toggle rules for customization and disable telemetry if desired.
-- **Refresh/Clear Functionality**: Users can clear previous results and re-run the analysis at any time.
 
 ## Rules
 1. #### Storage Upload without Length Check
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index d743f31b4f3..82d7359e69d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -6,9 +6,11 @@
 import org.json.*;
 import org.jetbrains.annotations.Nls;
 import org.jetbrains.annotations.NotNull;
-import java.nio.file.Files;
-import java.nio.file.Paths;
-import java.util.Arrays;
+
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
 import java.util.Collections;
 import java.util.List;
 import java.util.stream.Collectors;
@@ -33,9 +35,14 @@ public String getDisplayName() {
 
     private static List<String> getMethodsToCheck() {
         try {
-            JSONObject jsonObject = new JSONObject(new String(Files.readAllBytes(Paths.get("C:/Users/t-njmwenjwa/Documents/azure-tools-for-java/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json"))));
+            InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream("META-INF/ruleConfigs.json");
+            if (inputStream == null) {
+                throw new FileNotFoundException();
+            }
+            JSONObject jsonObject = new JSONObject(new BufferedReader(new InputStreamReader(inputStream)).lines().collect(Collectors.joining()));
             JSONArray methods = jsonObject.getJSONObject("StorageUploadWithoutLengthCheck").getJSONArray("methodsToCheck");
             return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
+
         } catch (Exception e) {
             e.printStackTrace();
             return Collections.emptyList();
@@ -47,23 +54,55 @@ private static List<String> getMethodsToCheck() {
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         return new JavaRecursiveElementWalkingVisitor() {
+
             @Override
             public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                 super.visitMethodCallExpression(expression);
                 String methodName = expression.getMethodExpression().getReferenceName();
 
                 if (METHODS_TO_CHECK.contains(methodName)) {
-                    PsiExpression[] arguments = expression.getArgumentList().getExpressions();
+                    boolean hasLengthArg = false;
+
+                    PsiExpressionList argumentList = expression.getArgumentList();
+                    PsiExpression[] arguments = argumentList.getExpressions();
+
+                    for (PsiExpression arg : arguments) {
+                        if (arg.getType().toString().equals("PsiType:long")) {
+                            hasLengthArg = true;
+                            break;
+                        }
+
+                        if (arg instanceof PsiMethodCallExpression) {
+                            PsiMethodCallExpression argMethodCall = (PsiMethodCallExpression) arg;
+                            PsiExpression qualifier = argMethodCall.getMethodExpression().getQualifierExpression();
 
-                    // TODO: check if a parameter object instantiated from a class with a length parameter field will NOT be detected.
-                    // eg line 150 stream parameter in sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/LargeBlobTests.java
-                    boolean hasLengthArg = Arrays.stream(arguments)
-                            .anyMatch(arg -> arg.getType().equalsToText("long"));
+                            while (qualifier instanceof PsiMethodCallExpression) {
+                                PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifier;
+                                PsiExpressionList qualifierArgumentList = qualifierMethodCall.getArgumentList();
+                                PsiExpression[] qualifierArguments = qualifierArgumentList.getExpressions();
+
+                                qualifier = qualifierMethodCall.getMethodExpression().getQualifierExpression();
+
+                                if (qualifier instanceof PsiNewExpression) {
+                                    PsiNewExpression newExpression = (PsiNewExpression) qualifier;
+                                    PsiExpressionList newExpressionArgumentList = newExpression.getArgumentList();
+                                    PsiExpression[] newExpressionArguments = newExpressionArgumentList.getExpressions();
+
+                                    for (PsiExpression newExpressionArgument : newExpressionArguments) {
+                                        if (newExpressionArgument.getType().toString().equals("PsiType:long")) {
+                                            hasLengthArg = true;
+                                            break;
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
                     if (!hasLengthArg) {
-                        holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
+                     holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
                     }
                 }
-            };
+            }
         };
-    }
-}
+    };
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json
deleted file mode 100644
index c0dff0bfe81..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ruleConfigs.json
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-  "StorageUploadWithoutLengthCheck": {
-    "methodsToCheck": ["uploadFromFile", "upload", "uploadWithResponse"]
-  }
-}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
new file mode 100644
index 00000000000..944d7f5a467
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -0,0 +1,8 @@
+{
+  "StorageUploadWithoutLengthCheck": {
+    "methodsToCheck": [
+      "upload",
+      "uploadWithResponse"
+    ]
+  }
+}
\ No newline at end of file

From 9433eb0a1582d3eafb87be99d8ea4d13f1e30d5d Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 15 Jun 2024 20:37:20 -0700
Subject: [PATCH 008/144] add telemetry with Az App Insights

---
 .../azure-toolkit-for-intellij/.gitignore     |  3 +
 .../CONTRIBUTING.MD                           | 15 ++++
 .../build.gradle                              |  6 +-
 .../buildtool/TelemetryClientProvider.java    | 72 +++++++++++++++++++
 4 files changed, 94 insertions(+), 2 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 6691dbbf974..9b67b0ab515 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -44,3 +44,6 @@ gen-external-apklibs/
 
 # Jar dependencies generated in build
 **/resources/spark/spark-tools-*.jar
+
+# InstrumentationKey
+PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationinsights.json
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
new file mode 100644
index 00000000000..957875451ac
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
@@ -0,0 +1,15 @@
+### Configuring MS Application Insights
+- An Azure account with an active subscription.
+
+#### 1. Generate the Instrumentation Key
+
+#### 2. Add the Instrumentation Key to the Application
+
+Add it to the `applicationinsights.json` file located in the `resources/META-INF` directory of the `azure-intellij-plugin-azure-sdk` project.
+```json
+{
+  "instrumentationKey": "your-instrumentation-key-goes-here"
+}
+```
+
+#### 3. Add `applicationinsights.json` to `.gitignore`
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..d6bc240c0fd 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,7 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
-
-}
+    implementation group: 'org.json', name: 'json', version: '20240303'
+    implementation 'com.microsoft.azure:applicationinsights-core:2.6.2'
+    implementation 'com.microsoft.azure:applicationinsights-web:2.6.2'
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
new file mode 100644
index 00000000000..4fe42f67ca2
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -0,0 +1,72 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+
+import com.microsoft.applicationinsights.TelemetryClient;
+import java.io.FileNotFoundException;
+
+import java.util.Timer;
+import org.json.JSONObject;
+import java.io.InputStream;
+import java.io.BufferedReader;
+import java.io.InputStreamReader;
+import java.util.TimerTask;
+import java.util.stream.Collectors;
+
+/**
+ * This class reads the instrumentation key from the applicationinsights.json file
+ * and returns a TelemetryClient object with the instrumentation key set.
+ * This object is used to send telemetry data to Application Insights.
+ * The trackMemoryUsage method is used to track the memory usage of the application.
+ * The start method is used to start a timer that runs the trackMemoryUsage method every 10 seconds.
+ */
+public class TelemetryClientProvider {
+
+    public static TelemetryClient getTelemetryClient() {
+
+        TelemetryClient telemetry;
+        telemetry = new TelemetryClient();
+
+        String instrumentationKey = null;
+
+        try {
+            InputStream inputStream = ConnectionStringCheck.class.getClassLoader().getResourceAsStream("META-INF/applicationinsights.json");
+            if (inputStream == null) {
+                throw new FileNotFoundException("File not found on classpath");
+            }
+
+            BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
+            String json = reader.lines().collect(Collectors.joining("\n"));
+            reader.close();
+
+            JSONObject jsonObject = new JSONObject(json);
+            instrumentationKey = jsonObject.getString("instrumentationKey");
+
+        } catch (Exception e) {
+            throw new RuntimeException("Could not read the instrumentation key from the applicationinsights.json file.");
+        }
+        telemetry.getContext().setInstrumentationKey(instrumentationKey);
+        return telemetry;
+    }
+
+    public static void trackMemoryUsage(TelemetryClient telemetry) {
+
+        Runtime runtime = Runtime.getRuntime();
+        long usedMemory = runtime.totalMemory() - runtime.freeMemory();
+
+        telemetry.trackMetric("UsedMemory", usedMemory);
+        telemetry.flush();
+    }
+
+    public static void start() {
+        Timer timer = new Timer();
+        timer.schedule(new TelemetryTask(), 0, 60000);
+    }
+
+    private static class TelemetryTask extends TimerTask {
+        @Override
+        public void run() {
+            TelemetryClient telemetry = TelemetryClientProvider.getTelemetryClient();
+            TelemetryClientProvider.trackMemoryUsage(telemetry);
+        }
+    }
+}

From 613b225dc85a6b7246cf75cd308e7a7648a56356 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 19 Jun 2024 11:07:50 -0700
Subject: [PATCH 009/144] extend telemetry to integrate background service

---
 .../buildtool/TelemetryClientProvider.java    | 106 +++++++++++++-----
 .../azure-intellij-plugin-azure-sdk.xml       |  10 ++
 2 files changed, 87 insertions(+), 29 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 4fe42f67ca2..2c6bbbd3e4b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -1,25 +1,93 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
-
+import com.intellij.codeInspection.*;
+import com.intellij.openapi.project.Project;
+import com.intellij.psi.*;
 import com.microsoft.applicationinsights.TelemetryClient;
 import java.io.FileNotFoundException;
 
-import java.util.Timer;
+import java.util.*;
+
+import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
 import java.io.InputStream;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
-import java.util.TimerTask;
+import java.util.concurrent.*;
 import java.util.stream.Collectors;
 
+
 /**
  * This class reads the instrumentation key from the applicationinsights.json file
  * and returns a TelemetryClient object with the instrumentation key set.
  * This object is used to send telemetry data to Application Insights.
- * The trackMemoryUsage method is used to track the memory usage of the application.
- * The start method is used to start a timer that runs the trackMemoryUsage method every 10 seconds.
  */
-public class TelemetryClientProvider {
+public class TelemetryClientProvider extends LocalInspectionTool {
+
+    private static final TelemetryClient telemetryClient = getTelemetryClient();
+    private static final ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
+    private static Project project;
+
+    private static final Map<String, Integer> methodCounts = new HashMap<>();
+
+    public static void setProject(Project project) {
+        System.out.println("Setting project.");
+        TelemetryClientProvider.project = project;
+        startTelemetryService();
+    }
+
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        Project project = holder.getProject();
+        TelemetryClientProvider.setProject(project);
+
+        return new JavaElementVisitor() {
+
+            //  will only track the methods that are being called in the code
+            @Override
+            public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+                super.visitMethodCallExpression(expression);
+
+                PsiReferenceExpression methodExpression = expression.getMethodExpression();
+                String methodName = methodExpression.getReferenceName();
+                System.out.println("Method tracked.");
+
+                synchronized (methodCounts) {
+                    // Increment the count of the method call
+                    methodCounts.put(methodName, methodCounts.getOrDefault(methodName, 0) + 1);
+                }
+                System.out.println(methodCounts.toString() + " method counts.");
+            }
+        };
+    }
+
+
+    private static void sendTelemetryData() {
+        System.out.println("Sending telemetry data sent at." + new Date().toString());
+
+        // print the time of the last event (using this to verify that the telemetry is being sent)
+        telemetryClient.trackEvent("Telemetry data sent at " + new Date().toString());
+
+        System.out.println(methodCounts.toString() + " sendTelemetryData method counts.");
+
+        for (Map.Entry<String, Integer> entry : methodCounts.entrySet()) {
+            String methodName = entry.getKey();
+            int count = entry.getValue();
+
+            telemetryClient.trackMetric("Method in use " + methodName, count);
+            telemetryClient.trackEvent("Method in use " + methodName);
+        }
+
+        // Clear the methodCounts map for the next interval
+        methodCounts.clear();
+        telemetryClient.flush();
+    }
+
+    private static void startTelemetryService() {
+        executorService.scheduleAtFixedRate(() ->
+            TelemetryClientProvider.sendTelemetryData(), 2, 3, TimeUnit.MINUTES);
+    }
+
 
     public static TelemetryClient getTelemetryClient() {
 
@@ -29,7 +97,7 @@ public static TelemetryClient getTelemetryClient() {
         String instrumentationKey = null;
 
         try {
-            InputStream inputStream = ConnectionStringCheck.class.getClassLoader().getResourceAsStream("META-INF/applicationinsights.json");
+            InputStream inputStream = TelemetryClient.class.getClassLoader().getResourceAsStream("META-INF/applicationinsights.json");
             if (inputStream == null) {
                 throw new FileNotFoundException("File not found on classpath");
             }
@@ -41,32 +109,12 @@ public static TelemetryClient getTelemetryClient() {
             JSONObject jsonObject = new JSONObject(json);
             instrumentationKey = jsonObject.getString("instrumentationKey");
 
+            System.out.println(instrumentationKey);
+
         } catch (Exception e) {
             throw new RuntimeException("Could not read the instrumentation key from the applicationinsights.json file.");
         }
         telemetry.getContext().setInstrumentationKey(instrumentationKey);
         return telemetry;
     }
-
-    public static void trackMemoryUsage(TelemetryClient telemetry) {
-
-        Runtime runtime = Runtime.getRuntime();
-        long usedMemory = runtime.totalMemory() - runtime.freeMemory();
-
-        telemetry.trackMetric("UsedMemory", usedMemory);
-        telemetry.flush();
-    }
-
-    public static void start() {
-        Timer timer = new Timer();
-        timer.schedule(new TelemetryTask(), 0, 60000);
-    }
-
-    private static class TelemetryTask extends TimerTask {
-        @Override
-        public void run() {
-            TelemetryClient telemetry = TelemetryClientProvider.getTelemetryClient();
-            TelemetryClientProvider.trackMemoryUsage(telemetry);
-        }
-    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..7709ebe3221 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,15 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="ReportTelemetry"
+                displayName="Report Telemetry"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryClientProvider">
+            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From 2fd394e2dcba7e8e71b0c1ade5303c2bfba59029 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 19 Jun 2024 12:24:54 -0700
Subject: [PATCH 010/144] addressing PR comments

---
 .../azure-intellij-plugin-azure-sdk/readme.md |  7 +-
 .../StorageUploadWithoutLengthCheck.java      | 79 +++++++++++--------
 .../azure-intellij-plugin-azure-sdk.xml       |  4 +-
 3 files changed, 54 insertions(+), 36 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index 83f5cb5c885..25e7c8d5885 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -16,6 +16,7 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 ## Rules
 1. #### Storage Upload without Length Check
-   Using Azure Storage upload APIs that don’t take a length parameter. This approach can lead to OutOfMemoryErrors, especially when dealing with large files or high-volume uploads
-    ##### Severity: INFO. 
-    #### Solution: Use APIs that take a length parameter.
\ No newline at end of file
+    Anti-Pattern: Using Azure Storage upload APIs that don’t take a length parameter. As a result, the entire data payload is buffered into memory before uploading.
+    Issue: This approach can lead to OutOfMemoryErrors, especially when dealing with large files or high-volume uploads
+       ##### Severity: INFO. 
+       #### Solution: Use APIs that take a length parameter. [Click here for more details](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java)
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 82d7359e69d..0cc96f3d36e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -2,8 +2,14 @@
 
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.psi.*;
-import org.json.*;
+import com.intellij.psi.JavaRecursiveElementWalkingVisitor;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiNewExpression;
+import org.json.JSONArray;
+import org.json.JSONObject;
 import org.jetbrains.annotations.Nls;
 import org.jetbrains.annotations.NotNull;
 
@@ -28,28 +34,29 @@ public class StorageUploadWithoutLengthCheck extends LocalInspectionTool {
     @NotNull
     @Override
     public String getDisplayName() {
-        return "Use Storage APIs With Length Parameter";
+        return "Ensure Storage APIs use Length Parameter";
     }
 
     private static final List<String> METHODS_TO_CHECK = getMethodsToCheck();
 
     private static List<String> getMethodsToCheck() {
         try {
-            InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream("META-INF/ruleConfigs.json");
+            String configFileName = "META-INF/ruleConfigs.json";
+            InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(configFileName);
             if (inputStream == null) {
-                throw new FileNotFoundException();
+                throw new FileNotFoundException("Configuration file not found");
+            }
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                JSONArray methods = jsonObject.getJSONObject("StorageUploadWithoutLengthCheck").getJSONArray("methodsToCheck");
+                return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
             }
-            JSONObject jsonObject = new JSONObject(new BufferedReader(new InputStreamReader(inputStream)).lines().collect(Collectors.joining()));
-            JSONArray methods = jsonObject.getJSONObject("StorageUploadWithoutLengthCheck").getJSONArray("methodsToCheck");
-            return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
-
         } catch (Exception e) {
             e.printStackTrace();
             return Collections.emptyList();
         }
     }
 
-
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -67,35 +74,17 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                     PsiExpression[] arguments = argumentList.getExpressions();
 
                     for (PsiExpression arg : arguments) {
+                        // Check if the argument is of type 'long'
                         if (arg.getType().toString().equals("PsiType:long")) {
                             hasLengthArg = true;
                             break;
                         }
-
                         if (arg instanceof PsiMethodCallExpression) {
                             PsiMethodCallExpression argMethodCall = (PsiMethodCallExpression) arg;
                             PsiExpression qualifier = argMethodCall.getMethodExpression().getQualifierExpression();
 
-                            while (qualifier instanceof PsiMethodCallExpression) {
-                                PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifier;
-                                PsiExpressionList qualifierArgumentList = qualifierMethodCall.getArgumentList();
-                                PsiExpression[] qualifierArguments = qualifierArgumentList.getExpressions();
-
-                                qualifier = qualifierMethodCall.getMethodExpression().getQualifierExpression();
-
-                                if (qualifier instanceof PsiNewExpression) {
-                                    PsiNewExpression newExpression = (PsiNewExpression) qualifier;
-                                    PsiExpressionList newExpressionArgumentList = newExpression.getArgumentList();
-                                    PsiExpression[] newExpressionArguments = newExpressionArgumentList.getExpressions();
-
-                                    for (PsiExpression newExpressionArgument : newExpressionArguments) {
-                                        if (newExpressionArgument.getType().toString().equals("PsiType:long")) {
-                                            hasLengthArg = true;
-                                            break;
-                                        }
-                                    }
-                                }
-                            }
+                            // Analysing arguments that are chained method calls
+                            hasLengthArg = checkMethodCallChain(argMethodCall);
                         }
                     }
                     if (!hasLengthArg) {
@@ -105,4 +94,32 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
             }
         };
     };
+
+    // Analysing arguments that are chained method calls
+    private boolean checkMethodCallChain (PsiMethodCallExpression expression) {
+
+        // Iterating up the chain of method calls
+        PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
+        while (qualifier instanceof PsiMethodCallExpression) {
+            PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifier;
+            PsiExpressionList qualifierArgumentList = qualifierMethodCall.getArgumentList();
+            PsiExpression[] qualifierArguments = qualifierArgumentList.getExpressions();
+
+            qualifier = qualifierMethodCall.getMethodExpression().getQualifierExpression();
+
+            // Checking for constructor with 'long' type arguments
+            if (qualifier instanceof PsiNewExpression) {
+                PsiNewExpression newExpression = (PsiNewExpression) qualifier;
+                PsiExpressionList newExpressionArgumentList = newExpression.getArgumentList();
+                PsiExpression[] newExpressionArguments = newExpressionArgumentList.getExpressions();
+
+                for (PsiExpression newExpressionArgument : newExpressionArguments) {
+                    if (newExpressionArgument.getType().toString().equals("PsiType:long")) {
+                        return true;
+                    }
+                }
+            }
+        }
+        return false;
+    }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 744262b38bd..ae5f87207d8 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -27,14 +27,14 @@
         <localInspection
             language="JAVA"
             shortName="StorageUploadWithoutLengthCheck"
-            displayName="Storage Upload Without LengthCheck"
+            displayName="Storage Upload Without Length Check"
             groupName="Azure SDK Rules"
             enabledByDefault="true"
             level="INFO"
 
             implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.StorageUploadWithoutLengthCheck">
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseStorageAPIsWithLengthParameter
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.StorageUploadWithoutLengthCheck
             </class>
         </localInspection>
     </extensions>

From 5f39981546df79a5d6bc8b9ea3c65712fa03efd2 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 19 Jun 2024 14:33:31 -0700
Subject: [PATCH 011/144] removing idea files

---
 .../azure-toolkit-for-intellij/.gitignore       | Bin 534 -> 597 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 8f090d60b2fcf9af90525de4559a7267e099280a..d09ecb50620244f4c28a0de250cd3fe118974183 100644
GIT binary patch
literal 597
zcmYjO+iK)649#;O|KMfb0!hB1(6Y2pSeOqeimhfe<FSpbbY}a|Z(k|d+l!CxI!8Vn
z+>?(~Dt7HyQH0V`C$(dSP(V&<UQr-`K-U(|%L*K{plkc_f<LQd*4BQ^Op9U68_2bo
zH^aqB4+r;<0%r>DC~Kf>IVhSlcryriH}DZ^HG^(D6jtxcBK4*tWA+e7<x!A@P;2rk
zN@rdv8ZFI))eGgcan!}%8A3F5%Vz9hw_rjB!QkF0+L*qd{>+%knzce-0bbA+s5{_Y
zkQ2l~sYjaaPO8nlg4gkn$G78t42%6>{J<pc`SIz&y>q_0ddfFFt_uWuqv~>UO7@Ii
zoQg?Z`)#CvFn#zs-mmemztjF5g3pz4pd=V0ore<Fh0<^elqxMJ8D^+BG1k1Y$2#@>
z&hQ1;1=KA8lh>>LC!dnrbZ-~<*I5hjW!m0Ba*lQA$1~_(n7HSC|BI^LC@VJ9ga#XE
Ix~6S@0WC(e%m4rY

literal 534
zcmYjN(P|?x41D)jxa4hN?QbZwlokqwd_d9K>PCrU8%f)w_i*2S+Rc^rWn{^WG&8%M
ze@unCpbLVkRA-4Ulm@wj9$Yx1LIwrbxy=i3j?N9?gkPeK(VmTIwo=-PdhUi3oSfV3
z{C&;bDEqxGnVNk-KW+GKnDJ_u3W!*x%Z8oZ@Yh<obXQt}66|b8Rzh)Y(dedyifOQM
zUXoI)rpHb_G2~(%=B=(XKVwA(#q2+*7=0MxfAU1evhU~=ct+c5&4^b;u24o(S!l8t
zY{@Gm7asQS`^~Kl-WWfzs(*fXy!Rj6&R!1fVzK#5U?GTa)tkB_CiN!0y1PIbA$}$a
z*K_%9Z$fVq__HvMR2561<JikGQymYPs?dDUaRR}}C~e_{5{F?`_5$oP+JTHUSv<e|
iQuUkD)$$KbI`AoOIBIJ}#vvSm*Im!I(=YBO)%^pdsjqhc


From cac41263ef370ea24422e87d5f67a6d850816b9f Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 19 Jun 2024 14:37:36 -0700
Subject: [PATCH 012/144] remove idea files

---
 .../.idea/codeStyles/Project.xml              |   51 -
 .../.idea/codeStyles/codeStyleConfig.xml      |    5 -
 .../.idea/copyright/Microsoft.xml             |    6 -
 .../.idea/findbugs-idea.xml                   |   16 -
 .../.idea/gradle.xml                          |   56 -
 .../inspectionProfiles/Project_Default.xml    | 2835 -----------------
 .../azure-toolkit-for-intellij/.idea/misc.xml |   61 -
 .../azure-toolkit-for-intellij/.idea/vcs.xml  |    6 -
 8 files changed, 3036 deletions(-)
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/Project.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/codeStyleConfig.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/copyright/Microsoft.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/findbugs-idea.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/inspectionProfiles/Project_Default.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/.idea/vcs.xml

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/Project.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/Project.xml
deleted file mode 100644
index 6735a734ceb..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/Project.xml
+++ /dev/null
@@ -1,51 +0,0 @@
-<component name="ProjectCodeStyleConfiguration">
-  <code_scheme name="Project" version="173">
-    <option name="LINE_SEPARATOR" value="&#10;" />
-    <option name="RIGHT_MARGIN" value="160" />
-    <option name="WRAP_WHEN_TYPING_REACHES_RIGHT_MARGIN" value="true" />
-    <JavaCodeStyleSettings>
-      <option name="GENERATE_FINAL_LOCALS" value="true" />
-      <option name="GENERATE_FINAL_PARAMETERS" value="true" />
-      <option name="ANNOTATION_PARAMETER_WRAP" value="5" />
-      <option name="ALIGN_MULTILINE_ANNOTATION_PARAMETERS" value="true" />
-    </JavaCodeStyleSettings>
-    <codeStyleSettings language="JAVA">
-      <option name="ALIGN_MULTILINE_CHAINED_METHODS" value="true" />
-      <option name="ALIGN_MULTILINE_PARAMETERS_IN_CALLS" value="true" />
-      <option name="ALIGN_MULTILINE_TERNARY_OPERATION" value="true" />
-      <option name="ALIGN_MULTILINE_THROWS_LIST" value="true" />
-      <option name="ALIGN_MULTILINE_EXTENDS_LIST" value="true" />
-      <option name="ALIGN_MULTILINE_METHOD_BRACKETS" value="true" />
-      <option name="ALIGN_MULTILINE_ARRAY_INITIALIZER_EXPRESSION" value="true" />
-      <option name="CALL_PARAMETERS_WRAP" value="5" />
-      <option name="PREFER_PARAMETERS_WRAP" value="true" />
-      <option name="METHOD_PARAMETERS_WRAP" value="5" />
-      <option name="RESOURCE_LIST_WRAP" value="1" />
-      <option name="EXTENDS_LIST_WRAP" value="1" />
-      <option name="THROWS_LIST_WRAP" value="1" />
-      <option name="EXTENDS_KEYWORD_WRAP" value="1" />
-      <option name="THROWS_KEYWORD_WRAP" value="1" />
-      <option name="METHOD_CALL_CHAIN_WRAP" value="5" />
-      <option name="BINARY_OPERATION_WRAP" value="1" />
-      <option name="BINARY_OPERATION_SIGN_ON_NEXT_LINE" value="true" />
-      <option name="TERNARY_OPERATION_WRAP" value="5" />
-      <option name="TERNARY_OPERATION_SIGNS_ON_NEXT_LINE" value="true" />
-      <option name="ARRAY_INITIALIZER_WRAP" value="5" />
-      <option name="ARRAY_INITIALIZER_LBRACE_ON_NEXT_LINE" value="true" />
-      <option name="ARRAY_INITIALIZER_RBRACE_ON_NEXT_LINE" value="true" />
-      <option name="ASSIGNMENT_WRAP" value="1" />
-      <option name="ASSERT_STATEMENT_WRAP" value="1" />
-      <option name="ASSERT_STATEMENT_COLON_ON_NEXT_LINE" value="true" />
-      <option name="IF_BRACE_FORCE" value="3" />
-      <option name="DOWHILE_BRACE_FORCE" value="3" />
-      <option name="WHILE_BRACE_FORCE" value="3" />
-      <option name="FOR_BRACE_FORCE" value="3" />
-      <option name="PARAMETER_ANNOTATION_WRAP" value="5" />
-      <option name="VARIABLE_ANNOTATION_WRAP" value="5" />
-      <option name="ENUM_CONSTANTS_WRAP" value="5" />
-      <indentOptions>
-        <option name="CONTINUATION_INDENT_SIZE" value="4" />
-      </indentOptions>
-    </codeStyleSettings>
-  </code_scheme>
-</component>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/codeStyleConfig.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/codeStyleConfig.xml
deleted file mode 100644
index 39dce05fd51..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/codeStyleConfig.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<component name="ProjectCodeStyleConfiguration">
-  <state>
-    <option name="PREFERRED_PROJECT_CODE_STYLE" value="Azure" />
-  </state>
-</component>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/copyright/Microsoft.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/copyright/Microsoft.xml
deleted file mode 100644
index 09b5df2c7a7..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/copyright/Microsoft.xml
+++ /dev/null
@@ -1,6 +0,0 @@
-<component name="CopyrightManager">
-  <copyright>
-    <option name="notice" value="Copyright (c) Microsoft Corporation&#10;&#10;All rights reserved.&#10;&#10;MIT License&#10;&#10;Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated&#10;documentation files (the &quot;Software&quot;), to deal in the Software without restriction, including without limitation&#10;the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and&#10;to permit persons to whom the Software is furnished to do so, subject to the following conditions:&#10;&#10;The above copyright notice and this permission notice shall be included in all copies or substantial portions of&#10;the Software.&#10;&#10;THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO&#10;THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE&#10;AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,&#10;TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE&#10;SOFTWARE." />
-    <option name="myName" value="Microsoft" />
-  </copyright>
-</component>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/findbugs-idea.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/findbugs-idea.xml
deleted file mode 100644
index 68840ef99a7..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/findbugs-idea.xml
+++ /dev/null
@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="FindBugs-IDEA">
-    <analysisEffort>max</analysisEffort>
-    <minPriority>High</minPriority>
-    <plugins>
-      <plugin id="com.h3xstream.findsecbugs" enabled="true" bundled="true" />
-    </plugins>
-    <includeFilterFiles>
-      <filter file="$PROJECT_DIR$/../../tools/spotbugs-security-include.xml" enabled="true" />
-    </includeFilterFiles>
-    <excludeFilterFiles>
-      <filter file="$PROJECT_DIR$/../../tools/spotbugs-security-exclude.xml" enabled="true" />
-    </excludeFilterFiles>
-  </component>
-</project>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
deleted file mode 100644
index 1b74c3eb9f7..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ /dev/null
@@ -1,56 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="GradleMigrationSettings" migrationVersion="1" />
-  <component name="GradleSettings">
-    <option name="linkedExternalProjectsSettings">
-      <GradleProjectSettings>
-        <option name="distributionType" value="WRAPPED" />
-        <option name="externalProjectPath" value="$PROJECT_DIR$" />
-        <option name="gradleHome" value="$USER_HOME$/Tools/gradle-7.1.1-all/gradle-7.1.1" />
-        <option name="modules">
-          <set>
-            <option value="$PROJECT_DIR$" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-applicationinsights" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice-java" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-arm" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-azure-sdk" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-bicep" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-cognitiveservices" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-containerapps" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-containerregistry" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-containerservice" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-cosmos" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-database" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-database-java" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-eventhubs" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-guidance" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-guidance-java" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-base" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-lib" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-integration-services" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-keyvault" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-lib" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-lib-java" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-monitor" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-redis" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-samples" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-service-explorer" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-servicebus" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-sparkoncosmos" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-springcloud" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-sqlserverbigdata" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-storage" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-synapse" />
-            <option value="$PROJECT_DIR$/azure-intellij-plugin-vm" />
-            <option value="$PROJECT_DIR$/azure-intellij-resource-connector-aad" />
-            <option value="$PROJECT_DIR$/azure-intellij-resource-connector-lib" />
-            <option value="$PROJECT_DIR$/azure-intellij-resource-connector-lib-java" />
-            <option value="$PROJECT_DIR$/azure-sdk-reference-book" />
-          </set>
-        </option>
-      </GradleProjectSettings>
-    </option>
-  </component>
-</project>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/inspectionProfiles/Project_Default.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/inspectionProfiles/Project_Default.xml
deleted file mode 100644
index 422c782e967..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/inspectionProfiles/Project_Default.xml
+++ /dev/null
@@ -1,2835 +0,0 @@
-<component name="InspectionProjectProfileManager">
-  <profile version="1.0" is_locked="true">
-    <option name="myName" value="Project Default" />
-    <inspection_tool class="AbsoluteAlignmentInUserInterface" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractBeanReferencesInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="AbstractClassExtendsConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractClassNeverImplemented" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractClassWithOnlyOneDirectInheritor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractClassWithoutAbstractMethods" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractMethodCallInConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractMethodOverridesAbstractMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractMethodOverridesConcreteMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractMethodWithMissingImplementations" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AbstractValueInTrait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AccessStaticViaInstance" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AccessToNonThreadSafeStaticFieldFromInstance" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="nonThreadSafeClasses">
-        <value />
-      </option>
-      <option name="nonThreadSafeTypes" value="" />
-    </inspection_tool>
-    <inspection_tool class="AccessToStaticFieldLockedOnInstance" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AccessorLikeMethodIsEmptyParen" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AccessorLikeMethodIsUnit" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AddOperatorModifier" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="AddVarianceModifier" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="AlphaUnsortedPropertiesFile" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="AmbiguousFieldAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AmbiguousMethodCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AmmoniteUnresolvedLibrary" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Annotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AnnotationClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Annotator" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="Anonymous2MethodRef" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AnonymousClassComplexity" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="AnonymousClassMethodCount" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="1" />
-    </inspection_tool>
-    <inspection_tool class="AnonymousClassVariableHidesContainingMethodVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AnonymousFunctionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AnonymousHasLambdaAlternative" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AnonymousInnerClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AnonymousInnerClassMayBeStatic" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AntDuplicateTargetsInspection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="AntMissingPropertiesFileInspection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="AntResolveInspection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ApiName" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ApiNamespace" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ApiParameter" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ApparentResultTypeRefinement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AppliedTypeLambdaCanBeSimplified" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ArgNamesErrorsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ArgNamesWarningsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AroundAdviceStyleInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ArrayCanBeReplacedWithEnumValues" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ArrayCreationWithoutNewKeyword" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ArrayEquality" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ArrayEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ArrayHashCode" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ArrayInDataClass" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ArrayLengthInLoopCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ArrayObjectsEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ArraysAsListWithZeroOrOneArgument" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AssertAsName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertBetweenInconvertibleTypes" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertEqualsBetweenInconvertibleTypes" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AssertEqualsBetweenInconvertibleTypesTestNG" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AssertEqualsCalledOnArray" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertEqualsMayBeAssertSame" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertMessageNotString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AssertStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertWithSideEffects" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AssertWithoutMessage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertionCanBeIf" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="AssertsWithoutMessages" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssertsWithoutMessagesTestNG" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentOrReturnOfFieldWithMutableType" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentResultUsedJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToCatchBlockParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToForLoopParameter" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_checkForeachParameters" value="true" />
-    </inspection_tool>
-    <inspection_tool class="AssignmentToForLoopParameterJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToFunctionParameterJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToLambdaParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToMethodParameter" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreTransformationOfOriginalParameter" value="false" />
-    </inspection_tool>
-    <inspection_tool class="AssignmentToNull" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToStaticFieldFromInstanceMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentToSuperclassField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AssignmentUsedAsCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AsyncMethodInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AtomicFieldUpdaterIssues" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AtomicFieldUpdaterNotStaticFinal" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="AutoBoxing" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreAddedToCollection" value="false" />
-    </inspection_tool>
-    <inspection_tool class="AutoCloseableResource" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AutoTupling" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AutoUnboxing" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AwaitNotInLoop" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="AwaitWithoutCorrespondingSignal" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BadExceptionCaught" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="exceptionsString" value="" />
-      <option name="exceptions">
-        <value />
-      </option>
-    </inspection_tool>
-    <inspection_tool class="BadExceptionDeclared" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="exceptionsString" value="" />
-      <option name="exceptions">
-        <value />
-      </option>
-      <option name="ignoreTestCases" value="false" />
-      <option name="ignoreLibraryOverrides" value="false" />
-    </inspection_tool>
-    <inspection_tool class="BadExceptionThrown" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="exceptionsString" value="" />
-      <option name="exceptions">
-        <value />
-      </option>
-    </inspection_tool>
-    <inspection_tool class="BadExpressionStatementJS" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="BadOddness" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BatchJobDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="BatchXmlDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="BeforeClassOrAfterClassIsPublicStaticVoidNoArg" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BeforeOrAfterIsPublicVoidNoArg" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BigDecimalEquals" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BigDecimalLegacyMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BigDecimalMethodWithoutRoundingCalled" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BintrayPublishingPlugin" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BlockMarkerComments" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BlockStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BlockingMethodInNonBlockingContext" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BooleanConstructor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BooleanExpressionMayBeConditional" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BooleanLiteralArgument" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="BooleanMethodIsAlwaysInverted" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BooleanMethodNameMustStartWithQuestion" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreBooleanMethods" value="false" />
-      <option name="ignoreInAnnotationInterface" value="true" />
-      <option name="onlyWarnOnBaseMethods" value="true" />
-      <option name="questionString" value="add,are,can,check,contains,could,endsWith,equals,has,is,matches,must,put,remove,shall,should,startsWith,was,were,will,would" />
-    </inspection_tool>
-    <inspection_tool class="BooleanParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BooleanVariableAlwaysNegated" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BoundFieldAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BoundedWildcard" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="BoxingBoxedValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="BreakStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BreakStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BreakStatementWithLabel" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BreakStatementWithLabelJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BusyWait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="BvConfigDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="BvConstraintMappingsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CStyleArrayDeclaration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CachedNumberConstructorCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CallToNativeMethodWhileLocked" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CallToSimpleGetterInClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreGetterCallsOnOtherObjects" value="false" />
-      <option name="onlyReportPrivateGetter" value="false" />
-    </inspection_tool>
-    <inspection_tool class="CallToSimpleSetterInClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreSetterCallsOnOtherObjects" value="false" />
-      <option name="onlyReportPrivateSetter" value="false" />
-    </inspection_tool>
-    <inspection_tool class="CallToStringConcatCanBeReplacedByOperator" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CallToSuspiciousStringMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CallerJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CallingSubscribeInNonBlockingScope" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CanBeFinal" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="REPORT_CLASSES" value="false" />
-      <option name="REPORT_METHODS" value="false" />
-      <option name="REPORT_FIELDS" value="true" />
-    </inspection_tool>
-    <inspection_tool class="CanBeParameter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CanBePrimaryConstructorProperty" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CanBeVal" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CanSealedSubClassBeObject" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="CapturingCleaner" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CascadeIf" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="CaseClassParam" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CastCanBeRemovedNarrowingVariableType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CastConflictsWithInstanceof" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CastThatLosesPrecision" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreIntegerCharCasts" value="false" />
-      <option name="ignoreOverflowingByteCasts" value="false" />
-    </inspection_tool>
-    <inspection_tool class="CastToConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CastToIncompatibleInterface" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CatchMayIgnoreException" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CaughtExceptionImmediatelyRethrown" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CdiAlternativeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiDecoratorInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiDisposerMethodInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiDomBeans" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CdiInjectInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiInjectionPointsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CdiInterceptorInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiManagedBeanInconsistencyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiNormalScopeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CdiObservesInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiScopeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CdiSpecializesInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiStereotypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiStereotypeRestrictionsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiTypedAnnotationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CdiUnknownProducersForDisposerMethodInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CdiUnproxyableBeanTypesInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ChainedEquality" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ChainedEqualityJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ChainedFunctionCallJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ChainedMethodCall" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreFieldInitializations" value="true" />
-      <option name="m_ignoreThisSuperCalls" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ChainedPackage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ChangeToMethod" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ChangeToOperator" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ChannelResource" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="insideTryAllowed" value="false" />
-    </inspection_tool>
-    <inspection_tool class="CharUsedInArithmeticContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CharacterComparison" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CharsetObjectCanBeUsed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CheckDtdRefs" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="CheckEmptyScriptTag" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CheckForOutOfMemoryOnLargeArrayAllocation" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="64" />
-    </inspection_tool>
-    <inspection_tool class="CheckImageSize" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CheckNodeTest" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CheckStyle" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CheckTagEmptyBody" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CheckValidXmlInScriptTagBody" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="CheckXmlFileWithXercesValidator" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="CheckedExceptionClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClashingGetters" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClashingTraitMethods" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ClassCanBeRecord" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassComplexity" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="80" />
-    </inspection_tool>
-    <inspection_tool class="ClassCoupling" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_includeJavaClasses" value="false" />
-      <option name="m_includeLibraryClasses" value="false" />
-      <option name="m_limit" value="15" />
-    </inspection_tool>
-    <inspection_tool class="ClassEscapesItsScope" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ClassGetClass" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ClassHasNoToStringMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="excludeClassNames" value="" />
-      <option name="excludeException" value="true" />
-      <option name="excludeDeprecated" value="true" />
-      <option name="excludeEnum" value="false" />
-      <option name="excludeAbstract" value="false" />
-      <option name="excludeTestCode" value="false" />
-      <option name="excludeInnerClasses" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ClassIndependentOfModule" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassInheritanceDepth" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="2" />
-    </inspection_tool>
-    <inspection_tool class="ClassInitializer" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassInitializerMayBeStatic" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ClassLoaderInstantiation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassMayBeInterface" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ClassName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ClassNameDiffersFromFileName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassNamePrefixedWithPackageName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassNameSameAsAncestorName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassNestingDepth" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="1" />
-    </inspection_tool>
-    <inspection_tool class="ClassNewInstance" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassOnlyUsedInOneModule" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassOnlyUsedInOnePackage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassReferencesSubclass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassUnconnectedToPackage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassWithMultipleLoggers" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="loggerNamesString" value="java.util.logging.Logger,org.slf4j.Logger,org.apache.commons.logging.Log,org.apache.log4j.Logger,org.apache.logging.log4j.Logger" />
-    </inspection_tool>
-    <inspection_tool class="ClassWithOnlyPrivateConstructors" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassWithTooManyDependencies" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="ClassWithTooManyDependents" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="ClassWithTooManyTransitiveDependencies" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="35" />
-    </inspection_tool>
-    <inspection_tool class="ClassWithTooManyTransitiveDependents" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="35" />
-    </inspection_tool>
-    <inspection_tool class="ClassWithoutConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ClassWithoutLogger" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="loggerNamesString" value="java.util.logging.Logger,org.slf4j.Logger,org.apache.commons.logging.Log,org.apache.log4j.Logger,org.apache.logging.log4j.Logger" />
-      <option name="ignoreSuperLoggers" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ClassWithoutNoArgConstructor" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreClassesWithNoConstructors" value="true" />
-    </inspection_tool>
-    <inspection_tool class="CloneCallsConstructors" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CloneDeclaresCloneNotSupported" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CloneInNonCloneableClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CloneReturnsClassType" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CloneableClassInSecureContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CloneableImplementsClone" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreCloneableDueToInheritance" value="false" />
-    </inspection_tool>
-    <inspection_tool class="CodeBlock2Expr" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CollectHeadOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CollectionAddAllCanBeReplacedWithConstructor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CollectionAddedToSelf" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CollectionContainsUrl" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CollectionsFieldAccessReplaceableByMethodCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CollectionsMustHaveInitialCapacity" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CommaExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CommentedOutCode" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ComparableImplementedButEqualsNotOverridden" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ComparatorCombinators" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ComparatorMethodParameterNotUsed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ComparatorNotSerializable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ComparatorResultComparison" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CompareToUsesNonFinalVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ComparingDiffCollectionKinds" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ComparingLength" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ComparingUnrelatedTypes" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ComparisonOfShortAndChar" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ComparisonToNaN" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ComplexRedundantLet" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ComponentNotRegistered" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="CHECK_ACTIONS" value="true" />
-      <option name="IGNORE_NON_PUBLIC" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ComponentRegistrationProblems" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ComposeMissingKeys" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ComposeUnknownKeys" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ComposeUnknownValues" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ComposeUnquotedPorts" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConcealedApplyCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConditionCoveredByFurtherCondition" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConditionSignal" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConditionalBreakInInfiniteLoop" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConditionalCanBeOptional" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConditionalCanBePushedInsideExpression" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConditionalExpression" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConditionalExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConditionalExpressionWithIdenticalBranches" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConditionalExpressionWithIdenticalBranchesJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConfigurationProperties" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ConflictingExtensionProperty" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConfusingElse" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="reportWhenNoStatementFollow" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ConfusingFloatingPointLiteral" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConfusingFloatingPointLiteralJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConfusingMainMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConfusingOctalEscape" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConfusingPlusesOrMinusesJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConnectionResource" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstPropertyName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConstantAssertArgument" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantAssertCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantConditionIf" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConstantConditionalExpression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConstantConditionalExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantConditions" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="SUGGEST_NULLABLE_ANNOTATIONS" value="false" />
-      <option name="DONT_REPORT_TRUE_ASSERT_STATEMENTS" value="false" />
-      <option name="REPORT_NULLABLE_METHODS_RETURNING_NOT_NULL" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ConstantDeclaredInAbstractClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantDeclaredInInterface" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantExpression" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConstantJUnitAssertArgument" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantMathCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantOnLHSOfComparisonJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantOnRHSOfComparisonJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantOnWrongSideOfComparison" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantTestNGAssertArgument" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConstantValueVariableUse" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Constructor" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ConstructorCount" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreDeprecatedConstructors" value="false" />
-      <option name="m_limit" value="5" />
-    </inspection_tool>
-    <inspection_tool class="ContextComponentScanInconsistencyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ContextJavaBeanUnresolvedMethodsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ContinueOrBreakFromFinallyBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ContinueOrBreakFromFinallyBlockJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ContinueStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ContinueStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ContinueStatementWithLabel" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ContinueStatementWithLabelJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Contract" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ControlFlowStatementWithoutBraces" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ControlFlowWithEmptyBody" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Convert2Diamond" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Convert2Lambda" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Convert2MethodRef" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Convert2streamapi" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConvertCallChainIntoSequence" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ConvertExpressionToSAM" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConvertJavadoc" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConvertLambdaToReference" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConvertNaNEquality" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConvertNullInitializerToUnderscore" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConvertOldAnnotations" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ConvertPairConstructorToToFunction" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConvertReferenceToLambda" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ConvertSecondaryConstructorToPrimary" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConvertToBasicLatin" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ConvertToStringTemplate" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ConvertTryFinallyToUseCall" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ConvertTwoComparisonsToRangeCheck" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ConvertibleToMethodValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CopyConstructorMissesField" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CopyWithoutNamedArguments" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="CorrespondsUnsorted" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CovariantEquals" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CriteriaApiResolveInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssBrowserCompatibilityForProperties" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssConvertColorToHexInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssConvertColorToRgbInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidAtRule" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidCharsetRule" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidFunction" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidHtmlTagReference" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidMediaFeature" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidPropertyValue" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssInvalidPseudoSelector" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssMissingComma" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssMissingSemicolon" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssNegativeValue" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssNoGenericFontName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssNonIntegerLengthInPixels" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssOverwrittenProperties" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssRedundantUnit" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssReplaceWithShorthandSafely" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssReplaceWithShorthandUnsafely" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="CssShorthandPropertyUsage" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssUnknownProperty" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CssUnknownTarget" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssUnresolvedClassInComposesRule" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssUnresolvedCustomProperty" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="CssUnusedSymbol" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CucumberExamplesColon" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="CucumberJavaStepDefClassInDefaultPackage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CucumberJavaStepDefClassIsPublic" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CucumberMissedExamples" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="CucumberTableInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CucumberUndefinedStep" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="CustomClassloader" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CustomSecurityManager" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CyclicClassDependency" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CyclicPackageDependency" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="CyclomaticComplexity" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="CyclomaticComplexityJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DangerousCatchAll" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DanglingJavadoc" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DataClassPrivateConstructor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DataProviderReturnType" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="DateToString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DebuggerStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DeclareCollectionAsInterface" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreLocalVariables" value="false" />
-      <option name="ignorePrivateMethodsAndFields" value="false" />
-    </inspection_tool>
-    <inspection_tool class="DeclareParentsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="DefaultAnnotationParam" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DefaultFileTemplate" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="CHECK_FILE_HEADER" value="true" />
-      <option name="CHECK_TRY_CATCH_SECTION" value="true" />
-      <option name="CHECK_METHOD_BODY" value="true" />
-    </inspection_tool>
-    <inspection_tool class="DefaultNotLastCaseInSwitch" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DefaultNotLastCaseInSwitchJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DeferredIsResult" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="DeferredResultUnused" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DelegatesTo" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DelegationToVarProperty" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Dependency" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="DependencyVersionWithBom" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DependencyWithNoBom" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DeprecatedAppEngineJavaRuntime" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="DeprecatedCallableAddReplaceWith" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="DeprecatedClassUsageInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DeprecatedGradleDependency" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DeprecatedIsStillUsed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DeprecatedKindProjectorSyntax" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DeprecatedLombok" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DeprecatedMavenDependency" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DeprecatedViewBound" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Deprecation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DesignForExtension" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Destructure" enabled="false" level="INFO" enabled_by_default="false" />
-    <inspection_tool class="DestructuringWrongName" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DialogTitleCapitalization" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DiamondCanBeReplacedWithExplicitTypeArguments" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="DifferentKotlinGradleVersion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DifferentKotlinMavenVersion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DifferentMavenStdlibVersion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DifferentStdlibGradleVersion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DirectUseOfResultType" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="DisjointPackage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DivideByZero" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DivideByZeroJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DockerFileAddOrCopySemantic" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DockerFileArgumentCount" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="DockerFileAssignments" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="DocumentWriteJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DollarSignInName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DontUsePairConstructor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DoubleBraceInitialization" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="DoubleCheckedLocking" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreOnVolatileVariables" value="false" />
-    </inspection_tool>
-    <inspection_tool class="DoubleLiteralMayBeFloatLiteral" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DoubleNegation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DoubleNegationScala" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DriverManagerGetConnection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DropTakeToSlice" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DuplicateBooleanBranch" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DuplicateBranchesInSwitch" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="DuplicateCondition" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="ignoreSideEffectConditions" value="true" />
-    </inspection_tool>
-    <inspection_tool class="DuplicateConditionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DuplicateExpressions" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="DuplicateMnemonic" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DuplicatePropertyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DuplicateStringLiteralInspection" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="MIN_STRING_LENGTH" value="5" />
-      <option name="IGNORE_PROPERTY_KEYS" value="false" />
-    </inspection_tool>
-    <inspection_tool class="DuplicateThrows" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="DuplicatedBeanNamesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DuplicatedCode" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="DuplicatedDataProviderNames" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="DynamicRegexReplaceableByCompiledPattern" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="DynamicallyGeneratedCodeJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ELDeferredExpressionsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ELMethodSignatureInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ELSpecValidationInJSP" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ELValidationInJSP" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6BindWithArrowFunction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6CheckImport" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6ClassMemberInitializationOrder" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6ConvertIndexedForToForOf" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ES6ConvertLetToConst" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ES6ConvertModuleExportToExport" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ES6ConvertRequireIntoImport" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ES6ConvertToForOf" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ES6ConvertVarToLetConst" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6DestructuringVariablesMerge" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6MissingAwait" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6PossiblyAsyncFunction" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6PreferShortImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6RedundantAwait" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6RedundantNestingInTemplateLiteral" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ES6ShorthandObjectProperty" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="ES6TopLevelAwaitExpression" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ES6UnusedImports" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EditorConfigCharClassLetterRedundancy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigCharClassRedundancy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigDeprecatedDescriptor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigEmptyHeader" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigEmptySection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigHeaderUniqueness" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigKeyCorrectness" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigListAcceptability" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigMissingRequiredDeclaration" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigNoMatchingFiles" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigNumerousWildcards" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigOptionRedundancy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigPairAcceptability" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigPartialOverride" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigPatternEnumerationRedundancy" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigPatternRedundancy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigReferenceCorrectness" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigRootDeclarationCorrectness" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigRootDeclarationUniqueness" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigShadowedOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigShadowingOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigSpaceInHeader" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigUnexpectedComma" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigUnusedDeclaration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigValueCorrectness" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigValueUniqueness" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EditorConfigWildcardRedundancy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyCatchBlockJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptyCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignorableAnnotations">
-        <value />
-      </option>
-      <option name="ignoreClassWithParameterization" value="false" />
-      <option name="ignoreThrowables" value="true" />
-      <option name="commentsAreContent" value="true" />
-    </inspection_tool>
-    <inspection_tool class="EmptyDirectory" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptyFinallyBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyFinallyBlockJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptyInitializer" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptyMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyParenMethodAccessedAsParameterless" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyParenMethodOverriddenAsParameterless" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyRange" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyStatementBody" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_reportEmptyBlocks" value="true" />
-    </inspection_tool>
-    <inspection_tool class="EmptyStatementBodyJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptySynchronizedStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptyTryBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EmptyTryBlockJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EmptyWebServiceClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EndlessStream" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EnhancedSwitchBackwardMigration" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="EnhancedSwitchMigration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EnumAsName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EnumClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EnumEntryName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="EnumSwitchStatementWhichMissesCases" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="ignoreSwitchStatementsWithDefault" value="true" />
-    </inspection_tool>
-    <inspection_tool class="EnumerationCanBeIteration" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EqualityToSameElements" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EqualsAndHashcode" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EqualsBetweenInconvertibleTypes" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EqualsCalledOnEnumConstant" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="EqualsHashCodeCalledOnUrl" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EqualsOnSuspiciousObject" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EqualsOrHashCode" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EqualsReplaceableByObjectsCall" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="EqualsUsesNonFinalVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="EqualsWhichDoesntCheckParameterClass" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="EqualsWithItself" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ErrorRethrown" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Eslint" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExceptionCaughtLocallyJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExceptionFromCatchWhichDoesntWrap" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreGetMessage" value="false" />
-      <option name="ignoreCantWrap" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ExceptionNameDoesntEndWithException" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExceptionPackage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExcessiveLambdaUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExcessiveRangeCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExistsEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExistsForallReplace" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExpectedExceptionNeverThrown" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExpectedExceptionNeverThrownTestNG" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExplicitArgumentCanBeLambda" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ExplicitArrayFilling" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExplicitThis" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ExtendsAnnotation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExtendsConcreteCollection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExtendsObject" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ExtendsThread" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExtendsThrowable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExtendsUtilityClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExternalizableWithSerializationMethods" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ExternalizableWithoutPublicNoArgConstructor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FacesModelInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="FakeJvmFieldConstant" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FallThroughInSwitchStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FallthruInSwitchStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FeatureEnvy" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreTestCases" value="false" />
-    </inspection_tool>
-    <inspection_tool class="FieldAccessNotGuarded" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FieldAccessedSynchronizedAndUnsynchronized" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="countGettersAndSetters" value="false" />
-    </inspection_tool>
-    <inspection_tool class="FieldCanBeLocal" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FieldCount" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_countConstantFields" value="false" />
-      <option name="m_considerStaticFinalFieldsConstant" value="false" />
-      <option name="myCountEnumConstants" value="false" />
-      <option name="m_limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="FieldFromDelayedInit" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FieldHasSetterButNoGetter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FieldHidesSuperclassField" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreInvisibleFields" value="true" />
-    </inspection_tool>
-    <inspection_tool class="FieldMayBeFinal" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FieldMayBeStatic" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FieldNamingConvention" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FieldNotUsedInToString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FileEqualsUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FillPermitsList" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="FilterEmptyCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FilterHeadOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FilterOtherContains" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FilterSetContains" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FilterSize" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FinalClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FinalMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FinalMethodInFinalClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FinalPrivateMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FinalStaticMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Finalize" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreTrivialFinalizers" value="true" />
-    </inspection_tool>
-    <inspection_tool class="FinalizeNotProtected" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FinallyBlockCannotCompleteNormally" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FindAndMapToApply" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FindEmptyCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FloatLiteralEndingWithDecimalPoint" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FloatingPointEquality" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FlowJSConfig" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FlowJSCoverage" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="FlowJSError" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="FlowJSFlagCommentPlacement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FoldExpressionIntoStream" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="FoldInitializerAndIfToElvis" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="FoldTrueAnd" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ForCanBeForeach" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="REPORT_INDEXED_LOOP" value="true" />
-      <option name="ignoreUntypedCollections" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ForEachParameterNotUsed" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ForLoopReplaceableByWhile" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="m_ignoreLoopsWithoutConditions" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ForLoopReplaceableByWhileJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ForLoopThatDoesntUseLoopVariableJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ForLoopWithMissingComponent" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreCollectionLoops" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ForeachStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FormSpellChecking" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ForwardCompatibility" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ForwardReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FrequentlyUsedInheritorInspection" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="FromClosedRangeMigration" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="FullJavaName" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="FullMethodName" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="FunctionName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="FunctionNamingConventionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FunctionTupleSyntacticSugar" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FunctionWithInconsistentReturnsJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FunctionWithLambdaExpressionBody" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="FunctionWithMultipleLoopsJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FunctionWithMultipleReturnPointsJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="FunctionalExpressionCanBeFolded" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="FuseStreamOperations" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GetGetOrElse" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GetOrElseNull" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GherkinBrokenTableInspection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="GherkinMisplacedBackground" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="GherkinScenarioToScenarioOutline" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="GrAnnotationReferencingUnknownIdentifiers" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GrDeprecatedAPIUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrEqualsBetweenInconvertibleTypes" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrFinalVariableAccess" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrMethodMayBeStatic" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrNamedVariantLabels" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GrPackage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrReassignedInClosureLocalVar" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrStringStyleViolation" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="GrUnnecessaryAlias" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrUnnecessaryDefModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrUnnecessaryPublicModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrUnnecessarySemicolon" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GrUnresolvedAccess" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="GradleKotlinxCoroutinesDeprecation" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="GradlePackageUpdate" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GrazieInspection" enabled="false" level="TYPO" enabled_by_default="false" />
-    <inspection_tool class="GroovyAccessToStaticFieldLockedOnInstance" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyAccessibility" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyAssignabilityCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyAssignmentCanBeOperatorAssignment" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreLazyOperators" value="true" />
-      <option name="ignoreObscureOperators" value="false" />
-    </inspection_tool>
-    <inspection_tool class="GroovyAssignmentToForLoopParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyAssignmentToMethodParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyBreak" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyBusyWait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyConditional" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyConditionalCanBeConditionalCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyConditionalCanBeElvis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyConditionalWithIdenticalBranches" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyConstantConditional" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyConstantIfStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyConstantNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[A-Z\d]*" />
-      <option name="m_minLength" value="4" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovyConstructorNamedArguments" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyContinue" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyContinueOrBreakFromFinallyBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyDivideByZero" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyDocCheck" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="GroovyDoubleCheckedLocking" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreOnVolatileVariables" value="false" />
-    </inspection_tool>
-    <inspection_tool class="GroovyDoubleNegation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyDuplicateSwitchBranch" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyEmptyCatchBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyEmptyFinallyBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyEmptyStatementBody" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyEmptySyncBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyEmptyTryBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyFallthrough" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyGStringKey" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyIfStatementWithIdenticalBranches" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyIfStatementWithTooManyBranches" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="GroovyImplicitNullArgumentCall" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyInArgumentCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyInfiniteLoopStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyInfiniteRecursion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyInstanceMethodNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="4" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovyInstanceVariableNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="m_[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="1" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovyLabeledStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyListGetCanBeKeyedAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyListSetCanBeKeyedAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyLocalVariableNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="4" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovyLoopStatementThatDoesntLoop" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyMapGetCanBeKeyedAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyMapPutCanBeKeyedAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyMethodParameterCount" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="5" />
-    </inspection_tool>
-    <inspection_tool class="GroovyMethodWithMoreThanThreeNegations" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyMissingReturnStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyMultipleReturnPointsPerMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="1" />
-    </inspection_tool>
-    <inspection_tool class="GroovyNegatedConditional" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNegatedIf" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNestedAssignment" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNestedConditional" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNestedSwitch" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNestedSynchronizedStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNonShortCircuitBoolean" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyNotifyWhileNotSynchronized" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyOctalInteger" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyOverlyComplexArithmeticExpression" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="GroovyOverlyComplexBooleanExpression" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="GroovyOverlyComplexMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="GroovyOverlyLongMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="30" />
-    </inspection_tool>
-    <inspection_tool class="GroovyOverlyNestedMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="5" />
-    </inspection_tool>
-    <inspection_tool class="GroovyParameterNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="4" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovyPointlessArithmetic" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyPointlessBoolean" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyPublicFieldAccessedInSynchronizedContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyRangeTypeCheck" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyResultOfAssignmentUsed" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyResultOfIncrementOrDecrementUsed" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyResultOfObjectAllocationIgnored" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyReturnFromClosureCanBeImplicit" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyReturnFromFinallyBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovySillyAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyStaticMethodNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="4" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovyStaticVariableNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="s_[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="4" />
-      <option name="m_maxLength" value="32" />
-    </inspection_tool>
-    <inspection_tool class="GroovySwitchStatementWithNoDefault" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovySynchronizationOnNonFinalField" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovySynchronizationOnThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovySynchronizationOnVariableInitializedWithLiteral" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovySynchronizedMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovySystemRunFinalizersOnExit" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyThreadStopSuspendResume" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyThrowFromFinallyBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyTrivialConditional" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyTrivialIf" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUncheckedAssignmentOfMemberOfRawType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnconditionalWait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyUnnecessaryContinue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnnecessaryReturn" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnreachableStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnsynchronizedMethodOverridesSynchronizedMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUntypedAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyUnusedAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnusedCatchParameter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnusedDeclaration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyUnusedIncOrDec" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyVariableCanBeFinal" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyVariableNotAssigned" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="GroovyWaitCallNotInLoop" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyWaitWhileNotSynchronized" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="GroovyWhileLoopSpinsOnField" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreNonEmtpyLoops" value="false" />
-    </inspection_tool>
-    <inspection_tool class="Guava" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HardCodedStringLiteral" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreForAssertStatements" value="true" />
-      <option name="ignoreForExceptionConstructors" value="true" />
-      <option name="ignoreForSpecifiedExceptionConstructors" value="" />
-      <option name="ignoreForJUnitAsserts" value="true" />
-      <option name="ignoreForClassReferences" value="true" />
-      <option name="ignoreForPropertyKeyReferences" value="true" />
-      <option name="ignoreForNonAlpha" value="true" />
-      <option name="ignoreAssignedToConstants" value="false" />
-      <option name="ignoreToString" value="false" />
-      <option name="nonNlsCommentPattern" value="NON-NLS" />
-    </inspection_tool>
-    <inspection_tool class="HardcodedFileSeparators" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_recognizeExampleMediaType" value="false" />
-    </inspection_tool>
-    <inspection_tool class="HardcodedLineSeparators" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HardwiredNamespacePrefix" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HasPlatformType" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="HashCodeUsesNonFinalVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HashCodeUsesVar" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="HeadOrLastOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HibernateConfigDomFacetInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HibernateConfigDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="HibernateMappingDatasourceDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="HibernateMappingDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="HibernateResource" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="insideTryAllowed" value="false" />
-    </inspection_tool>
-    <inspection_tool class="HtmlDeprecatedAttribute" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlDeprecatedTag" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlExtraClosingTag" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HtmlFormInputWithoutLabel" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlMissingClosingTag" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="HtmlNonExistentInternetResource" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlPresentationalElement" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="HtmlRequiredAltAttribute" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlRequiredLangAttribute" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlRequiredSummaryAttribute" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="HtmlRequiredTitleAttribute" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="HtmlRequiredTitleElement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlTagCanBeJavadocTag" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HtmlUnknownAnchorTarget" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HtmlUnknownAttribute" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="myValues">
-        <value>
-          <list size="0" />
-        </value>
-      </option>
-      <option name="myCustomValuesEnabled" value="true" />
-    </inspection_tool>
-    <inspection_tool class="HtmlUnknownBooleanAttribute" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HtmlUnknownTag" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="myValues">
-        <value>
-          <list size="6">
-            <item index="0" class="java.lang.String" itemvalue="nobr" />
-            <item index="1" class="java.lang.String" itemvalue="noembed" />
-            <item index="2" class="java.lang.String" itemvalue="comment" />
-            <item index="3" class="java.lang.String" itemvalue="noscript" />
-            <item index="4" class="java.lang.String" itemvalue="embed" />
-            <item index="5" class="java.lang.String" itemvalue="script" />
-          </list>
-        </value>
-      </option>
-      <option name="myCustomValuesEnabled" value="true" />
-    </inspection_tool>
-    <inspection_tool class="HtmlUnknownTarget" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="HttpRequestContentLengthIsIgnored" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HttpRequestPlaceholder" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="HttpUrlsUsage" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="I18nForm" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IOResource" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoredTypesString" value="java.io.ByteArrayOutputStream,java.io.ByteArrayInputStream,java.io.StringBufferInputStream,java.io.CharArrayWriter,java.io.CharArrayReader,java.io.StringWriter,java.io.StringReader" />
-      <option name="insideTryAllowed" value="false" />
-    </inspection_tool>
-    <inspection_tool class="IdempotentLoopBody" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IfCanBeAssertion" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="IfCanBeSwitch" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="minimumBranches" value="3" />
-      <option name="suggestIntSwitches" value="false" />
-      <option name="suggestEnumSwitches" value="false" />
-    </inspection_tool>
-    <inspection_tool class="IfElseToFilterdOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IfElseToOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IfMayBeConditional" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IfStatementMissingBreakInLoop" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IfStatementWithIdenticalBranches" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="IfStatementWithIdenticalBranchesJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IfStatementWithTooManyBranches" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="IfStatementWithTooManyBranchesJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IfThenToElvis" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="IfThenToSafeAccess" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="IgnoreFileDuplicateEntry" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IgnoreResultOfCall" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_reportAllNonLibraryCalls" value="false" />
-      <option name="callCheckString" value="java.io.File,.*,java.io.InputStream,read|skip|available|markSupported,java.io.Reader,read|skip|ready|markSupported,java.lang.Boolean,.*,java.lang.Byte,.*,java.lang.Character,.*,java.lang.Double,.*,java.lang.Float,.*,java.lang.Integer,.*,java.lang.Long,.*,java.lang.Math,.*,java.lang.Object,equals|hashCode|toString,java.lang.Short,.*,java.lang.StrictMath,.*,java.lang.String,.*,java.lang.Thread,interrupted,java.math.BigInteger,.*,java.math.BigDecimal,.*,java.net.InetAddress,.*,java.net.URI,.*,java.util.Arrays,.*,java.util.List,of,java.util.Set,of,java.util.Map,of|ofEntries|entry,java.util.Collections,(?!addAll).*,java.util.UUID,.*,java.util.regex.Matcher,pattern|toMatchResult|start|end|group|groupCount|matches|find|lookingAt|quoteReplacement|replaceAll|replaceFirst|regionStart|regionEnd|hasTransparentBounds|hasAnchoringBounds|hitEnd|requireEnd,java.util.regex.Pattern,.*,java.util.stream.BaseStream,.*" />
-    </inspection_tool>
-    <inspection_tool class="IgnoredJUnitTest" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IllegalIdentifier" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ImplicitArrayToString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ImplicitCallToSuper" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_ignoreForObjectSubclasses" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ImplicitDefaultCharsetUsage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ImplicitNullableNothingType" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ImplicitNumericConversion" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreWideningConversions" value="false" />
-      <option name="ignoreCharConversions" value="false" />
-      <option name="ignoreConstantConversions" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ImplicitSubclassInspection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ImplicitThis" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ImplicitTypeConversion" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="BITS" value="1720" />
-      <option name="FLAG_EXPLICIT_CONVERSION" value="true" />
-      <option name="IGNORE_NODESET_TO_BOOLEAN_VIA_STRING" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ImplicitlyExposedWebServiceMethods" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="IncompatibleAPI" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="IncompatibleMask" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IncompatibleMaskJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IncompleteDestructuring" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IncompleteProperty" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="InconsistentLanguageLevel" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InconsistentLineSeparators" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InconsistentResourceBundle" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="InconsistentTextBlockIndent" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IncorrectHttpHeaderInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IncorrectOnMessageMethodsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="IncorrectScope" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="IncrementDecrementResultUsedJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IncrementDecrementUsedAsExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IndexBoundsCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IndexOfReplaceableByContains" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IndexZeroUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InfiniteLoopJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InfiniteLoopStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InfiniteRecursion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InfiniteRecursionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InjectedReferences" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="InjectionNotApplicable" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="InjectionValueTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="InnerClassMayBeStatic" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InnerClassOnInterface" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreInnerInterfaces" value="false" />
-    </inspection_tool>
-    <inspection_tool class="InnerClassReferencedViaSubclass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InnerClassVariableHidesOuterClassVariable" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreInvisibleFields" value="true" />
-    </inspection_tool>
-    <inspection_tool class="InnerHTMLJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InsertLiteralUnderscores" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="InspectionDescriptionNotFoundInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InspectionMappingConsistency" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InspectionUniqueToolbarId" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InspectionUsingGrayColors" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InstanceGuardedByStatic" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InstanceVariableInitialization" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignorePrimitives" value="false" />
-    </inspection_tool>
-    <inspection_tool class="InstanceVariableOfConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InstanceVariableUninitializedUse" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignorePrimitives" value="false" />
-      <option name="annotationNamesString" value="" />
-    </inspection_tool>
-    <inspection_tool class="InstanceofCatchParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InstanceofChain" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreInstanceofOnLibraryClasses" value="false" />
-    </inspection_tool>
-    <inspection_tool class="InstanceofIncompatibleInterface" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InstanceofInterfaces" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InstanceofThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InstantiatingObjectToGetClassObject" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InstantiationOfUtilityClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IntLiteralMayBeLongLiteral" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IntegerDivisionInFloatingPointContext" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IntegerMultiplicationImplicitCastToLong" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreNonOverflowingCompileTimeConstants" value="true" />
-    </inspection_tool>
-    <inspection_tool class="IntentionDescriptionNotFoundInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InterfaceMayBeAnnotatedFunctional" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="InterfaceMethodClashesWithObject" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InterfaceNeverImplemented" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreInterfacesThatOnlyDeclareConstants" value="false" />
-    </inspection_tool>
-    <inspection_tool class="InterfaceWithOnlyOneDirectInheritor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IntroduceWhenSubject" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="InvalidComparatorMethodReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="InvalidParameterAnnotations" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="InvalidPropertyKeyForm" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IterableUsedAsVararg" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="IteratorHasNextCallsIteratorNext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="IteratorNextDoesNotThrowNoSuchElementException" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JCenterRepository" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JDBCExecuteWithNonConstantString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JDBCPrepareStatementWithNonConstantString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JDBCResource" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="insideTryAllowed" value="false" />
-    </inspection_tool>
-    <inspection_tool class="JNDIResource" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="insideTryAllowed" value="false" />
-    </inspection_tool>
-    <inspection_tool class="JSAccessibilityCheck" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSAnnotator" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JSArrowFunctionBracesCanBeRemoved" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSAssignmentUsedAsCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSBitwiseOperatorUsage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSCheckFunctionSignatures" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSClassNamingConvention" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSClosureCompilerSyntax" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSCommentMatchesSignature" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSComparisonWithNaN" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSConsecutiveCommasInArrayLiteral" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSConstantReassignment" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JSConstructorReturnsPrimitive" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSDeclarationsAtScopeStart" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSDeprecatedSymbols" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSDuplicateCaseLabel" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSDuplicatedDeclaration" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSEqualityComparisonWithCoercion" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSEqualityComparisonWithCoercion.TS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSFileReferences" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSFunctionExpressionToArrowFunction" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSHint" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JSIgnoredPromiseFromCall" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSIncompatibleTypesComparison" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSJQueryEfficiency" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSJoinVariableDeclarationAndAssignment" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSLastCommaInArrayLiteral" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSLastCommaInObjectLiteral" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSMethodCanBeStatic" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSMismatchedCollectionQueryUpdate" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSMissingSwitchBranches" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSMissingSwitchDefault" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSNonASCIINames" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSNonStrictModeUsed" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSObjectNullOrUndefined" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSObsoletePrivateAccessSyntax" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JSOctalInteger" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JSPotentiallyInvalidConstructorUsage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSPotentiallyInvalidTargetOfIndexedPropertyAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSPotentiallyInvalidUsageOfClassThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSPotentiallyInvalidUsageOfThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSPrimitiveTypeWrapperUsage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSRedundantSwitchStatement" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSReferencingMutableVariableFromClosure" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSRemoveUnnecessaryParentheses" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSStringConcatenationToES6Template" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="JSSuspiciousEqPlus" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSSuspiciousNameCombination" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSSwitchVariableDeclarationIssue" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSTestFailedLine" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSTypeOfValues" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUndeclaredVariable" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUndefinedPropertyAssignment" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnfilteredForInLoop" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnnecessarySemicolon" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnreachableSwitchBranches" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnresolvedExtXType" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnresolvedFunction" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnresolvedLibraryURL" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnresolvedReactComponent" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnresolvedVariable" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnusedAssignment" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnusedGlobalSymbols" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSUnusedLocalSymbols" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSValidateJSDoc" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSValidateTypes" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSVoidFunctionReturnValueUsed" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSXNamespaceValidation" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="JSXSyntaxUsed" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JUnit3StyleTestMethodInJUnit4Class" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JUnit4AnnotatedMethodInJUnit3TestCase" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JUnit5AssertionsConverter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JUnit5Converter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JUnit5MalformedNestedClass" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JUnit5MalformedParameterized" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JUnit5MalformedRepeated" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JUnit5Platform" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JUnitDatapoint" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JUnitRule" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JUnitTestNG" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Java8CollectionRemoveIf" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java8ListSort" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java8MapApi" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java8MapForEach" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java9CollectionFactory" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java9ModuleExportsPackageToItself" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java9RedundantRequiresStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java9ReflectionClassVisibility" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Java9UndeclaredServiceUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaAccessorEmptyParenCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaAccessorMethodOverriddenAsEmptyParen" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaCollectionsStaticMethod" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaCollectionsStaticMethodOnImmutableList" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaDoc" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="TOP_LEVEL_CLASS_OPTIONS">
-        <value>
-          <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="none" />
-          <option name="REQUIRED_TAGS" value="" />
-        </value>
-      </option>
-      <option name="INNER_CLASS_OPTIONS">
-        <value>
-          <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="none" />
-          <option name="REQUIRED_TAGS" value="" />
-        </value>
-      </option>
-      <option name="METHOD_OPTIONS">
-        <value>
-          <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="none" />
-          <option name="REQUIRED_TAGS" value="@return@param@throws or @exception" />
-        </value>
-      </option>
-      <option name="FIELD_OPTIONS">
-        <value>
-          <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="none" />
-          <option name="REQUIRED_TAGS" value="" />
-        </value>
-      </option>
-      <option name="IGNORE_DEPRECATED" value="false" />
-      <option name="IGNORE_JAVADOC_PERIOD" value="true" />
-      <option name="IGNORE_DUPLICATED_THROWS" value="false" />
-      <option name="IGNORE_POINT_TO_ITSELF" value="false" />
-      <option name="myAdditionalJavadocTags" value="" />
-    </inspection_tool>
-    <inspection_tool class="JavaFxColorRgb" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaFxDefaultTag" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaFxEventHandler" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaFxRedundantPropertyValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaFxResourcePropertyValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaFxUnresolvedFxIdReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaFxUnusedImports" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaLangImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JavaLangInvokeHandleSignature" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaMapForEach" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaModuleNaming" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaMutatorMethodAccessedAsParameterless" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaMutatorMethodOverriddenAsParameterless" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaReflectionInvocation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaReflectionMemberAccess" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaRequiresAutoModule" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavaStylePropertiesInvocation" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="JavacQuirks" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JavadocHtmlLint" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JavadocReference" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="JavaeeApplicationDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JdkProxiedBeanTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JoinDeclarationAndAssignment" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="JoinDeclarationAndAssignmentJava" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="JpaAttributeMemberSignatureInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaAttributeTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaConfigDomFacetInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JpaDataSourceORMDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaDataSourceORMInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaEntityGraphsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaEntityListenerInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaEntityListenerWarningsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JpaMissingIdInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaModelReferenceInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaORMDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaObjectClassSignatureInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaQlInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JpaQueryApiInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JsfJamExtendsClassInconsistencyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JsfManagedBeansInconsistencyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="Json5StandardCompliance" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="JsonDuplicatePropertyKeys" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JsonPathEvaluateUnknownKey" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JsonPathUnknownFunction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JsonPathUnknownOperator" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JsonSchemaCompliance" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JsonSchemaDeprecation" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="JsonSchemaRefReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="JsonStandardCompliance" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="JspAbsolutePathInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JspDirectiveInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JspPropertiesInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="JspTagBodyContent" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="JspUnescapedEl" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Junit4Converter" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="Junit5MalformedParameterized" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="KDocMissingDocumentation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="KDocUnresolvedReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KeySetIterationMayUseEntrySet" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="KindProjectorSimplifyTypeProjection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KindProjectorUseCorrectLambdaKeyword" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinConstantConditions" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="KotlinCovariantEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinDeprecation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinDoubleNegation" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinEqualsBetweenInconvertibleTypes" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinInternalInJava" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="KotlinInvalidBundleOrProperty" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="KotlinLoggerInitializedWithForeignClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="KotlinMavenPluginPhase" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinRedundantOverride" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinSealedInheritorsInJava" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="KotlinTestJUnit" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinThrowableNotThrown" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="KotlinUnusedImport" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LabeledStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LabeledStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LambdaBodyCanBeCodeBlock" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="LambdaCanBeMethodCall" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="LambdaCanBeReplacedWithAnonymous" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="LambdaParameterHidingMemberVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LambdaParameterNamingConvention" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LambdaParameterTypeCanBeSpecified" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="LambdaUnfriendlyMethodOverload" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LanguageDetectionInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LanguageFeature" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LanguageMismatch" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="CHECK_NON_ANNOTATED_REFERENCES" value="true" />
-    </inspection_tool>
-    <inspection_tool class="LastIndexToLast" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LateinitVarOverridesLateinitVar" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LawOfDemeter" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreLibraryCalls" value="true" />
-    </inspection_tool>
-    <inspection_tool class="LeakingThis" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LegacyStringFormatting" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LengthOneStringInIndexOf" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LengthOneStringsInConcatenation" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="LessResolvedByNameOnly" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="LessUnresolvedMixin" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LessUnresolvedVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LiftReturnOrAssignment" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="LimitedScopeInnerClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ListIndexOfReplaceableByContains" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ListRemoveInLoop" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ListenerMayUseAdapter" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="checkForEmptyMethods" value="true" />
-    </inspection_tool>
-    <inspection_tool class="LiteralAsArgToStringEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LoadLibraryWithNonConstantString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LocalCanBeFinal" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="REPORT_VARIABLES" value="true" />
-      <option name="REPORT_PARAMETERS" value="false" />
-    </inspection_tool>
-    <inspection_tool class="LocalVariableHidingMemberVariable" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreInvisibleFields" value="true" />
-      <option name="m_ignoreStaticMethods" value="true" />
-    </inspection_tool>
-    <inspection_tool class="LocalVariableName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="LocalVariableNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreForLoopParameters" value="false" />
-      <option name="m_ignoreCatchParameters" value="false" />
-      <option name="m_regex" value="[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="1" />
-      <option name="m_maxLength" value="20" />
-    </inspection_tool>
-    <inspection_tool class="LocalVariableNamingConventionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LocalVariableOfConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LogStatementGuardedByLogCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LoggerInitializedWithForeignClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="loggerFactoryMethodName" value="getLogger,getLogger,getLog,getLogger" />
-    </inspection_tool>
-    <inspection_tool class="LoggingConditionDisagreesWithLogStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="Lombok" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LongLine" enabled="true" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LongLiteralsEndingWithLowercaseL" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LoopConditionNotUpdatedInsideLoop" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="ignoreIterators" value="false" />
-    </inspection_tool>
-    <inspection_tool class="LoopStatementThatDoesntLoopJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LoopStatementsThatDontLoop" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LoopToCallChain" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="LoopVariableNotUpdated" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="LoopWithImplicitTerminationCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="LossyEncoding" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MVCPathVariableInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MagicCharacter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MagicConstant" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MagicNumber" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MagicNumberJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MainFunctionReturnUnit" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MalformedDataProvider" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MalformedFormatString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MalformedRegex" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MalformedSetUpTearDown" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MalformedXPath" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ManualArrayCopy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ManualArrayToCollectionCopy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ManualMinMaxCalculation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapFlatten" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapGetGet" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapGetOrElse" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MapGetOrElseBoolean" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapGetWithNotNullAssertionOperator" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="MapKeys" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapLift" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapReplaceableByEnumMap" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MapToBooleanContains" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MapValues" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MarkdownUnresolvedFileReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MarkedForRemoval" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MarkerInterface" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MaskedAssertion" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MatchToPartialFunction" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MathRandomCastToInt" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MavenCoroutinesDeprecation" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MavenDuplicateDependenciesInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MavenDuplicatePluginInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MavenModelInspection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MavenPackageUpdate" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MavenParentMissedVersionInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MavenPropertyInParent" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MavenRedundantGroupId" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MayBeConstant" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="MeaninglessRecordAnnotationInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MemberVisibilityCanBePrivate" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="MetaAnnotationWithoutRuntimeRetention" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MethodCallInLoopCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodCanBeVariableArityMethod" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="MethodCount" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="20" />
-      <option name="ignoreGettersAndSetters" value="false" />
-      <option name="ignoreOverridingMethods" value="false" />
-    </inspection_tool>
-    <inspection_tool class="MethodCoupling" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_includeJavaClasses" value="false" />
-      <option name="m_includeLibraryClasses" value="false" />
-      <option name="m_limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="MethodMayBeStatic" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_onlyPrivateOrFinal" value="false" />
-      <option name="m_ignoreEmptyMethods" value="true" />
-    </inspection_tool>
-    <inspection_tool class="MethodMayBeSynchronized" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodName" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MethodNameSameAsClassName" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MethodNameSameAsParentName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodOnlyUsedFromInnerClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreMethodsAccessedFromAnonymousClass" value="false" />
-      <option name="ignoreStaticMethodsFromNonStaticInnerClass" value="false" />
-      <option name="onlyReportStaticMethods" value="false" />
-    </inspection_tool>
-    <inspection_tool class="MethodOverloadsParentMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodOverridesInaccessibleMethodOfSuper" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodOverridesStaticMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodParameterType" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MethodRefCanBeReplacedWithLambda" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="MethodReturnAlwaysConstant" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodReturnOfConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MethodReturnType" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MethodWithMultipleLoops" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MigrateAssertToMatcherAssert" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MigrateDiagnosticSuppression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MimeType" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MinMaxValuesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MismatchedArrayReadWrite" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MismatchedCollectionQueryUpdate" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="queryNames">
-        <value />
-      </option>
-      <option name="updateNames">
-        <value />
-      </option>
-      <option name="ignoredClasses">
-        <value />
-      </option>
-    </inspection_tool>
-    <inspection_tool class="MismatchedStringBuilderQueryUpdate" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MismatchedStringCase" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MisorderedAssertEqualsArguments" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MisorderedAssertEqualsArgumentsTestNG" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MisorderedAssertEqualsParameters" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MissingAspectjAutoproxyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MissingDeprecatedAnnotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MissingDeprecatedAnnotationOnScheduledForRemovalApi" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MissingFinalNewline" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MissingMnemonic" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MissingOverrideAnnotation" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="ignoreObjectMethods" value="true" />
-      <option name="ignoreAnonymousClassMethods" value="false" />
-    </inspection_tool>
-    <inspection_tool class="MissingPackageInfo" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MissingRecentApi" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MissingSerialAnnotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MissortedModifiers" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_requireAnnotationsFirst" value="true" />
-    </inspection_tool>
-    <inspection_tool class="MisspelledEquals" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MisspelledHeader" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="MisspelledMethodName" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ModuleWithTooFewClasses" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="ModuleWithTooManyClasses" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="100" />
-    </inspection_tool>
-    <inspection_tool class="MongoJSDeprecationInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MongoJSExtDeprecationInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MongoJSExtResolveInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MongoJSExtSideEffectsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MongoJSResolveInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MongoJSSideEffectsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MoveFieldAssignmentToInitializer" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="MoveLambdaOutsideParentheses" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="MoveSuspiciousCallableReferenceIntoParentheses" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="MoveVariableDeclarationIntoWhen" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="MsBuiltinInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MsOrderByInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MultiCatchCanBeSplit" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="MultipleArgListsInAnnotation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MultipleExceptionsDeclaredOnTestMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MultipleMethodDesignatorsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="MultipleRepositoryUrls" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MultipleReturnPointsPerMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreGuardClauses" value="false" />
-      <option name="ignoreEqualsMethod" value="false" />
-      <option name="m_limit" value="1" />
-    </inspection_tool>
-    <inspection_tool class="MultipleTopLevelClassesInFile" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MultipleVariablesInDeclaration" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="MultiplyOrDivideByPowerOfTwo" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="checkDivision" value="false" />
-    </inspection_tool>
-    <inspection_tool class="MustAlreadyBeRemovedApi" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="MutatorLikeMethodIsParameterless" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="MysqlLoadDataPathInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="MysqlParsingInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NakedNotify" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NameBooleanParameters" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NamedResource" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="NativeMethods" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NegatedConditional" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreNegatedNullComparison" value="true" />
-    </inspection_tool>
-    <inspection_tool class="NegatedConditionalExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NegatedConditionalExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NegatedEqualityExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NegatedIfElse" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreNegatedNullComparison" value="true" />
-      <option name="m_ignoreNegatedZeroComparison" value="false" />
-    </inspection_tool>
-    <inspection_tool class="NegatedIfStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NegativelyNamedBooleanVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedAssignment" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedAssignmentJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedConditionalExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedConditionalExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedFunctionCallJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedFunctionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedLambdaShadowedImplicitParameter" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="NestedMethodCall" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreFieldInitializations" value="true" />
-    </inspection_tool>
-    <inspection_tool class="NestedStatefulMonads" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedSwitchStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedSwitchStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedSynchronizedStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestedTryStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NestingDepth" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="5" />
-    </inspection_tool>
-    <inspection_tool class="NestingDepthJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NewClassNamingConvention" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NewExceptionWithoutArguments" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NewGroovyClassNamingConvention" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NewInstanceOfSingleton" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NewMethodNamingConvention" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NewObjectEquality" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NewStringBufferWithCharArgument" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NoButtonGroup" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NoExplicitFinalizeCalls" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NoLabelFor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NoScrollPane" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NoTailRecursionAnnotation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NodeCoreCodingAssistance" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonAsciiCharacters" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NonAtomicOperationOnVolatileField" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NonBlockStatementBodyJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonBooleanMethodNameMayNotStartWithQuestion" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="questionString" value="add,are,can,check,contains,could,endsWith,equals,has,is,matches,must,put,remove,shall,should,startsWith,was,were,will,would" />
-      <option name="ignoreBooleanMethods" value="false" />
-      <option name="onlyWarnOnBaseMethods" value="true" />
-    </inspection_tool>
-    <inspection_tool class="NonCommentSourceStatements" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="30" />
-    </inspection_tool>
-    <inspection_tool class="NonDefaultConstructor" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="NonExceptionNameEndsWithException" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonExtendableApiUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NonFinalClone" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonFinalFieldInEnum" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonFinalFieldInImmutable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonFinalFieldOfException" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonFinalGuard" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonFinalStaticVariableUsedInClassInitialization" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonFinalUtilityClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonJaxWsWebServices" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonProtectedConstructorInAbstractClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreNonPublicClasses" value="false" />
-    </inspection_tool>
-    <inspection_tool class="NonPublicClone" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonReproducibleMathCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonSerializableFieldInSerializableClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignorableAnnotations">
-        <value />
-      </option>
-      <option name="ignoreAnonymousInnerClasses" value="false" />
-      <option name="superClassString" value="java.awt.Component" />
-    </inspection_tool>
-    <inspection_tool class="NonSerializableObjectBoundToHttpSession" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonSerializableObjectPassedToObjectStream" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonSerializableWithSerialVersionUIDField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonSerializableWithSerializationMethods" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonShortCircuitBoolean" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonStaticFinalLogger" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="loggerClassName" value="java.util.logging.Logger,org.slf4j.Logger,org.apache.commons.logging.Log,org.apache.log4j.Logger,org.apache.logging.log4j.Logger" />
-    </inspection_tool>
-    <inspection_tool class="NonStaticInnerClassInSecureContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonSynchronizedMethodOverridesSynchronizedMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NonThreadSafeLazyInitialization" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NoopMethodInAbstractClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NotImplementedCode" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NotNullFieldNotInitialized" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NotifyCalledOnCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NotifyWithoutCorrespondingWait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NpmUsedModulesInstalled" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="NullArgumentToVariableArgMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NullChecksToSafeCall" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="NullThrown" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="NullableBooleanElvis" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="NullableProblems" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="REPORT_NULLABLE_METHOD_OVERRIDES_NOTNULL" value="true" />
-      <option name="REPORT_NOT_ANNOTATED_METHOD_OVERRIDES_NOTNULL" value="false" />
-      <option name="REPORT_NOTNULL_PARAMETER_OVERRIDES_NULLABLE" value="true" />
-      <option name="REPORT_NOT_ANNOTATED_PARAMETER_OVERRIDES_NOTNULL" value="true" />
-      <option name="REPORT_NOT_ANNOTATED_GETTER" value="true" />
-      <option name="REPORT_NOT_ANNOTATED_SETTER_PARAMETER" value="true" />
-      <option name="REPORT_ANNOTATION_NOT_PROPAGATED_TO_OVERRIDERS" value="false" />
-      <option name="REPORT_NULLS_PASSED_TO_NON_ANNOTATED_METHOD" value="true" />
-    </inspection_tool>
-    <inspection_tool class="NumberEquality" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NumericOverflow" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="NumericToString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ObjectAllocationIgnoredJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ObjectAllocationInLoop" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ObjectEquality" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="m_ignoreEnums" value="true" />
-      <option name="m_ignoreClassObjects" value="true" />
-      <option name="m_ignorePrivateConstructors" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ObjectEqualsCanBeEquality" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ObjectInstantiationInEqualsHashCode" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ObjectLiteralToLambda" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ObjectNotify" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ObjectPropertyName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ObjectToString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ObjectsEqualsCanBeSimplified" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ObsoleteCollection" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreRequiredObsoleteCollectionTypes" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ObsoleteExperimentalCoroutines" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ObsoleteKotlinJsPackages" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ObviousNullCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OctalAndDecimalIntegersMixed" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OctalLiteral" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OnDemandImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OneButtonGroup" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OneWayWebMethod" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="OptionEqualsSome" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OptionalAssignedToNull" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="OptionalContainsCollection" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="OptionalExpectation" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="OptionalGetWithoutIsPresent" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OptionalIsPresent" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OptionalToIf" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="OptionalUsedAsFieldOrParameterType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OraMissingBodyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OraOverloadInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OraUnmatchedForwardDeclarationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="OverflowingLoopIndex" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OverloadedMethodsWithSameNumberOfParameters" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreInconvertibleTypes" value="true" />
-    </inspection_tool>
-    <inspection_tool class="OverloadedVarargsMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OverlyComplexArithmeticExpression" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="6" />
-    </inspection_tool>
-    <inspection_tool class="OverlyComplexArithmeticExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OverlyComplexBooleanExpression" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-      <option name="m_ignorePureConjunctionsDisjunctions" value="true" />
-    </inspection_tool>
-    <inspection_tool class="OverlyComplexBooleanExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OverlyLargePrimitiveArrayInitializer" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="64" />
-    </inspection_tool>
-    <inspection_tool class="OverlyLongLambda" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OverlyStrongTypeCast" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreInMatchingInstanceof" value="false" />
-    </inspection_tool>
-    <inspection_tool class="OverridableMethodCallDuringObjectConstruction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OverriddenMethodCallDuringObjectConstruction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="OverrideAbstractMember" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="OverrideOnly" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OverridingDeprecatedMember" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="OverwrittenKey" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PackageDirectoryMismatch" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="PackageDotHtmlMayBePackageInfo" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PackageInMultipleModules" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PackageInfoWithoutPackage" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PackageJsonMismatchedDependency" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PackageName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="PackageNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[a-z]*" />
-      <option name="m_minLength" value="3" />
-      <option name="m_maxLength" value="16" />
-    </inspection_tool>
-    <inspection_tool class="PackageVisibleField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PackageVisibleInnerClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreEnums" value="false" />
-      <option name="ignoreInterfaces" value="false" />
-    </inspection_tool>
-    <inspection_tool class="PackageWithTooFewClasses" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="PackageWithTooManyClasses" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="ParameterCanBeLocal" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ParameterHidingMemberVariable" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreInvisibleFields" value="true" />
-      <option name="m_ignoreStaticMethodParametersHidingInstanceFields" value="true" />
-      <option name="m_ignoreForConstructors" value="false" />
-      <option name="m_ignoreForPropertySetters" value="false" />
-      <option name="m_ignoreForAbstractMethods" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ParameterNameDiffersFromOverriddenParameter" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreSingleCharacterNames" value="false" />
-      <option name="m_ignoreOverridesOfLibraryMethods" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ParameterNamingConvention" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_regex" value="[a-z][A-Za-z\d]*" />
-      <option name="m_minLength" value="1" />
-      <option name="m_maxLength" value="20" />
-    </inspection_tool>
-    <inspection_tool class="ParameterNamingConventionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ParameterOfConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ParameterTypePreventsOverriding" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ParameterizedParametersStaticCollection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ParameterlessMemberOverriddenAsEmptyParen" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ParametersPerConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ParametersPerFunctionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ParametersPerMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="5" />
-    </inspection_tool>
-    <inspection_tool class="PathAnnotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PatternNotApplicable" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="PatternOverriddenByNonAnnotatedMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PatternValidation" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="CHECK_NON_CONSTANT_VALUES" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PatternVariableCanBeUsed" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PermissionUsageInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PgSelectFromProcedureInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PlaceholderCountMatchesArgumentCount" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PlatformDetectionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PlatformExtensionReceiverOfInline" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PluginXmlCapitalization" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PluginXmlValidity" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="PointcutMethodStyleInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PointlessArithmeticExpression" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_ignoreExpressionsContainingConstants" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PointlessArithmeticExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PointlessBitwiseExpression" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_ignoreExpressionsContainingConstants" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PointlessBitwiseExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PointlessBooleanExpression" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_ignoreExpressionsContainingConstants" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PointlessBooleanExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PointlessIndexOfComparison" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PointlessNullCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PostfixMethodCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PostfixTemplateDescriptionNotFound" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PresentationAnnotation" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="PreviewFeature" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PrimitiveArrayArgumentToVariableArgMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PrivatePropertyName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ProblematicVarargsMethodOverride" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ProblematicWhitespace" enabled="true" level="WARNING" enabled_by_default="true">
-      <scope name="All Changed Files" level="INFORMATION" enabled="true" />
-    </inspection_tool>
-    <inspection_tool class="ProcedureDeclaration" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ProcedureDefinition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ProhibitJvmOverloadsOnConstructorsOfAnnotationClassesMigration" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ProhibitRepeatedUseSiteTargetAnnotationsMigration" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ProhibitTypeParametersForLocalVariablesMigration" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ProhibitUseSiteTargetAnnotationsOnSuperTypesMigration" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ProjectFingerprint" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PropertyName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="PropertyValueSetToItself" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ProtectedField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ProtectedInFinal" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ProtectedInnerClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreEnums" value="false" />
-      <option name="ignoreInterfaces" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ProtectedMemberInFinalClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PsiElementConcatenation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="PublicApiImplicitType" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="PublicConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PublicConstructorInNonPublicClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PublicField" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="ignoreEnums" value="false" />
-      <option name="ignorableAnnotations">
-        <value />
-      </option>
-    </inspection_tool>
-    <inspection_tool class="PublicFieldAccessedInSynchronizedContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PublicInnerClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreEnums" value="false" />
-      <option name="ignoreInterfaces" value="false" />
-    </inspection_tool>
-    <inspection_tool class="PublicMethodNotExposedInInterface" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignorableAnnotations">
-        <value />
-      </option>
-      <option name="onlyWarnIfContainingClassImplementsAnInterface" value="false" />
-    </inspection_tool>
-    <inspection_tool class="PublicMethodWithoutLogging" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="loggerClassName" value="java.util.logging.Logger,org.slf4j.Logger,org.apache.commons.logging.Log,org.apache.log4j.Logger,org.apache.logging.log4j.Logger" />
-    </inspection_tool>
-    <inspection_tool class="PublicStaticArrayField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="PublicStaticCollectionField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="QuestionableName" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="nameString" value="aa,abc,bad,bar,bar2,baz,baz1,baz2,baz3,bb,blah,bogus,bool,cc,dd,defau1t,dummy,dummy2,ee,fa1se,ff,foo,foo1,foo2,foo3,foobar,four,fred,fred1,fred2,gg,hh,hello,hello1,hello2,hello3,ii,nu11,one,silly,silly2,string,two,that,then,three,whi1e,var" />
-    </inspection_tool>
-    <inspection_tool class="QuickFixGetFamilyNameViolation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RandomDoubleForRandomInteger" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RangeToIndices" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RawTypeCanBeGeneric" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RawUseOfParameterizedType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReactiveStreamsNullableInLambdaInTransform" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReactiveStreamsPublisherImplementation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReactiveStreamsSubscriberImplementation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReactiveStreamsThrowInOperator" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReactiveStreamsTooLongSameOperatorsChain" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReactiveStreamsUnusedPublisher" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReactorAutomaticDebugger" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReadObjectAndWriteObjectPrivate" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReadObjectInitialization" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReadResolveAndWriteReplaceProtected" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReadWriteStringCanBeUsed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RecordCanBeClass" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="RecordStoreResource" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RecursiveEqualsCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RecursivePropertyAccessor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantArrayCreation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantAsSequence" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantAsync" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantCast" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantClassCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantCollectionConversion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantCollectionOperation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantCompanionReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantComparatorComparing" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantCompareCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantDefaultArgument" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantElseInIf" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RedundantElvisReturnNull" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantEmptyInitializerBlock" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="RedundantEnumConstructorInvocation" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantExplicitClose" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantExplicitType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantExplicitVariableType" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RedundantFieldInitialization" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantFileCreation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantGetter" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantHeadOrLastOption" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantIf" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantImplements" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreSerializable" value="false" />
-      <option name="ignoreCloneable" value="false" />
-    </inspection_tool>
-    <inspection_tool class="RedundantInnerClassModifier" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantLabelMigration" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantLabeledSwitchRuleCodeBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantLambdaArrow" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantLambdaOrAnonymousFunction" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantLambdaParameterType" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RedundantMethodOverride" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantModalityModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantModifiersUtilityClassLombok" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantModifiersValLombok" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantModifiersValueLombok" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantNewCaseClass" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantNotNullExtensionReceiverOfInline" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="RedundantNullableReturnType" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantObjectTypeCheck" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RedundantOperationOnEmptyContainer" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantRecordConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantRequireNotNullCall" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantReturnLabel" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantRunCatching" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantSamConstructor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantSemicolon" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantSetter" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantSlf4jDefinition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantStreamOptionalCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantStringFormatCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantSuppression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantSuspendModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantThrows" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantTypeArguments" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantTypeConversion" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="CHECK_ANY" value="false" />
-    </inspection_tool>
-    <inspection_tool class="RedundantUnitExpression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantUnitReturnType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantUnmodifiable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RedundantVisibilityModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RedundantWith" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReferenceMustBePrefixed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReferencesToClassesFromDefaultPackagesInJSPFile" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ReflectionForUnavailableAnnotation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Reformat" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="RefusedBequest" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="ignoreEmptySuperMethods" value="false" />
-      <option name="onlyReportWhenAnnotated" value="true" />
-    </inspection_tool>
-    <inspection_tool class="RegExpAnonymousGroup" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RegExpDuplicateAlternationBranch" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RegExpDuplicateCharacterInClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RegExpEmptyAlternationBranch" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RegExpEscapedMetaCharacter" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RegExpOctalEscape" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="RegExpRedundantEscape" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RegExpRedundantNestedCharacterClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RegExpRepeatedSpace" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RegExpSingleCharAlternation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RegExpUnexpectedAnchor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RegExpUnnecessaryNonCapturingGroup" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RelativeImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RemoveCurlyBracesFromTemplate" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveEmptyClassBody" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="RemoveEmptyParenthesesFromAnnotationEntry" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveEmptyParenthesesFromLambdaCall" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="RemoveEmptyPrimaryConstructor" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveEmptySecondaryConstructorBody" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveExplicitSuperQualifier" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveExplicitTypeArguments" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveForLoopIndices" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveLiteralUnderscores" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="RemoveRedundantBackticks" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveRedundantCallsOfConversionMethods" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveRedundantQualifierName" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveRedundantReturn" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveRedundantSpreadOperator" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveSetterParameterType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveSingleExpressionStringTemplate" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RemoveToStringInStringTemplate" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceAllDot" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceArrayEqualityOpWithArraysEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceArrayOfWithLiteral" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceAssertBooleanWithAssertEquality" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceAssignmentWithOperatorAssignment" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreLazyOperators" value="true" />
-      <option name="ignoreObscureOperators" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ReplaceAssignmentWithOperatorAssignmentJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReplaceAssociateFunction" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceCallWithBinaryOperator" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceCollectionCountWithSize" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReplaceGetOrSet" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ReplaceGuardClauseWithFunctionCall" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceInefficientStreamCount" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceIsEmptyWithIfEmpty" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReplaceJavaStaticMethodWithKotlinAnalog" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceManualRangeWithIndicesCalls" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="ReplaceNegatedIsEmptyWithIsNotEmpty" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceNotNullAssertionWithElvisReturn" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReplaceNullCheck" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplacePutWithAssignment" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceRangeStartEndInclusiveWithFirstLast" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceRangeToWithUntil" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSizeCheckWithIsNotEmpty" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSizeZeroCheckWithIsEmpty" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceStringFormatWithLiteral" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSubstringWithDropLast" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSubstringWithIndexingOperation" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSubstringWithSubstringAfter" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSubstringWithSubstringBefore" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceSubstringWithTake" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceToStringWithStringTemplate" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReplaceToWithInfixForm" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceToWithUntil" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceWithEnumMap" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceWithFlatten" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReplaceWithIgnoreCaseEquals" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReplaceWithOperatorAssignment" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="RequiredArtifactTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="RequiredAttributes" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="myAdditionalRequiredHtmlAttributes" value="" />
-    </inspection_tool>
-    <inspection_tool class="RequiredBeanTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ReservedWordUsedAsNameJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ResourceParameter" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="RestParamTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="RestResourceMethodInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="RestSignature" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="RestWrongDefaultValueInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="RestrictReturnStatementTargetMigration" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ResultOfObjectAllocationIgnored" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ResultSetIndexZero" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReturnFromFinallyBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReturnFromFinallyBlockJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReturnNull" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_reportObjectMethods" value="true" />
-      <option name="m_reportArrayMethods" value="true" />
-      <option name="m_reportCollectionMethods" value="true" />
-      <option name="m_ignorePrivateMethods" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ReturnOfInnerClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReturnSeparatedFromComputation" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="ReturnThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReuseOfLocalVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReuseOfLocalVariableJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ReverseIterator" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReverseMap" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ReverseTakeReverse" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="RuntimeExec" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="RuntimeExecWithNonConstantString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SSBasedInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SafeCastWithReturn" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SafeLock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SafeVarargsDetector" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SameElementsToEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SamePackageImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SameParameterValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SameReturnValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SassScssResolvedByNameOnly" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="SassScssUnresolvedMixin" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SassScssUnresolvedPlaceholderSelector" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SassScssUnresolvedVariable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SbtReplaceProjectWithProjectIn" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaBundledInsRunner" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ScalaDefaultFileTemplateUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDeprecatedIdentifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDeprecation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocInlinedTag" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocMissingParameterDescription" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocParserErrorInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocUnbalancedHeader" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocUnclosedTagWithoutParser" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocUnknownParameter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaDocUnknownTag" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaFileName" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaMalformedFormatString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaPackageName" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaRedundantCast" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaRedundantConversion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaStyle" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaUnnecessaryParentheses" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaUnnecessarySemicolon" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaUnreachableCode" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaUnresolvedPropertyKey" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ScalaUnusedExpression" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaUnusedSymbol" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="ScalaXmlUnmatchedTag" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ScheduledMethodInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ScheduledThreadPoolExecutorWithZeroCoreThreads" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ScopeFunctionConversion" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="SecondUnsafeCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SecurityRoles" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SelfAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SelfIncludingJspFiles" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SelfReferenceConstructorParameter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SerialAnnotationUsedOnWrongMember" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SerialPersistentFieldsWithWrongSignature" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SerialVersionUIDNotStaticFinal" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SerializableDeserializableClassInSecureContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SerializableHasSerialVersionUIDField" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreAnonymousInnerClasses" value="false" />
-      <option name="superClassString" value="java.awt.Component" />
-    </inspection_tool>
-    <inspection_tool class="SerializableHasSerializationMethods" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreAnonymousInnerClasses" value="false" />
-      <option name="superClassString" value="java.awt.Component" />
-    </inspection_tool>
-    <inspection_tool class="SerializableInnerClassHasSerialVersionUIDField" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreAnonymousInnerClasses" value="false" />
-      <option name="superClassString" value="java.awt.Component" />
-    </inspection_tool>
-    <inspection_tool class="SerializableInnerClassWithNonSerializableOuterClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreAnonymousInnerClasses" value="false" />
-      <option name="superClassString" value="java.awt.Component" />
-    </inspection_tool>
-    <inspection_tool class="SerializableRecordContainsIgnoredMembers" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SerializableStoresNonSerializable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SerializableWithUnconstructableAncestor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ServerEndpointInconsistencyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="ServletWithoutMappingInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SetReplaceableByEnumSet" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SetterBackingFieldAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SharedThreadLocalRandom" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ShellCheck" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="ShiftOutOfRange" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ShiftOutOfRangeJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SideEffectsInMonadicTransformation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SignalWithoutCorrespondingAwait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SillyAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SillyAssignmentJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SimpleDateFormatWithoutLocale" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SimpleRedundantLet" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableAnnotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SimplifiableAssertion" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SimplifiableBooleanExpression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableCall" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableCallChain" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableConditionalExpression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableEqualsExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SimplifiableFoldOrReduce" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableIfStatement" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="SimplifiableJUnitAssertion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifiedTestNGAssertion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyAssertNotNull" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="SimplifyBoolean" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyBooleanMatch" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyBooleanWithConstants" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyCollector" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyForEach" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="SimplifyNegatedBinaryExpression" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyNestedEachInScopeFunction" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="SimplifyOptionalCallChains" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyStreamApiCallChains" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SimplifyWhenWithBooleanConstantCondition" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="Since15" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="SingleCharacterStartsWith" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SingleClassImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SingleElementAnnotation" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="SingleImport" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SingleStatementInBlock" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="Singleton" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SingletonConstructor" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="SizeReplaceableByIsEmpty" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SizeToLength" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SkaffoldSchemaUpgradeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SleepWhileHoldingLock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SlowAbstractSetRemoveAll" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SocketResource" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="insideTryAllowed" value="false" />
-    </inspection_tool>
-    <inspection_tool class="SomeToOption" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SortFilter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SortModifiers" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SortedCollectionWithNonComparableKeys" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SortedHeadLast" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SourceNotClosed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="Specs2Matchers" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SpellCheckingInspection" enabled="true" level="TYPO" enabled_by_default="true">
-      <option name="processCode" value="true" />
-      <option name="processLiterals" value="true" />
-      <option name="processComments" value="true" />
-    </inspection_tool>
-    <inspection_tool class="SpringAopErrorsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringAopPointcutExpressionInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringAopWarningsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringBatchModel" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringBeanAttributesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringBeanConstructorArgInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringBeanInstantiationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringBeanLookupMethodInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringBeanNameConventionInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringBootAdditionalConfig" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringBootApplicationProperties" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringBootApplicationSetup" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringBootApplicationYaml" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringBootBootstrapConfigurationInspection" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringBootReactorHooksOnDebug" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringCacheAnnotationsOnInterfaceInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringCacheNamesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringCacheableAndCachePutInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringCacheableComponentsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringCloudStreamInconsistencyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringCloudStreamMessageChannelInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringComponentScan" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringConfigurationProxyMethods" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringContextConfigurationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringDataMethodInconsistencyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringDataRepositoryMethodParametersInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringDataRepositoryMethodReturnTypeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringElInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringElStaticFieldInjectionInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringEventListenerInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringFacetCodeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringFacetInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringFacetProgrammaticInspection" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringFactoryMethodInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringHandlersSchemasHighlighting" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringImportResource" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringInactiveProfileHighlightingInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringIncorrectResourceTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringInjectionValueConsistencyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringInjectionValueStyleInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringIntegrationDeprecations21" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringIntegrationMethodEndpointInconsistency" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringIntegrationModel" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringJavaAutowiredFieldsWarningInspection" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringJavaAutowiredMembersInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringJavaConstructorAutowiringInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringJavaInjectionPointsAutowiringInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringJavaStaticMembersAutowiringInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringLookupInjectionInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringMVCInitBinder" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringMVCViewInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringMessageDispatcherWebXmlInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringPlaceholdersInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringProfileExpression" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringPropertySource" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringPublicFactoryMethodInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringQualifierCopyableLombok" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringRequiredAnnotationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringRequiredPropertyInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringScopesInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringSecurityAnnotationBeanPointersResolveInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringSecurityDebugActivatedInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringSecurityModelInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringTestingDirtiesContextInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringTestingSqlInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringTestingTransactionalInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringTransactionalComponentInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringWebServiceAnnotationsInconsistencyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringWebServicesConfigurationsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringWebSocketConfigurationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringXmlAutowireExplicitlyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SpringXmlAutowiringInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SpringXmlModelInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SqlAddNotNullColumnInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlAggregatesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlAmbiguousColumnInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlAutoIncrementDuplicateInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlCallNotationInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SqlCaseVsCoalesceInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlCaseVsIfInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlCheckUsingColumnsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlConstantConditionInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlCurrentSchemaInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlDeprecateTypeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlDerivedTableAliasInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlDialectInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlDropIndexedColumnInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlDtInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlDuplicateColumnInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlErrorHandlingInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SqlGotoInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlIdentifierInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlIdentifierLengthInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SqlIllegalCursorStateInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlInsertIntoGeneratedColumnInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlInsertNullIntoNotNullInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlInsertValuesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlJoinWithoutOnInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlMisleadingReferenceInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlMissingColumnAliasesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlMissingReturnInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SqlMultipleLimitClausesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlNamedArgumentsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlNoDataSourceInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlNullComparisonInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlRedundantAliasInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlRedundantCodeInCoalesceInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlRedundantElseNullInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlRedundantLimitInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlRedundantOrderingDirectionInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlResolveInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SqlShadowingAliasInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlShouldBeInGroupByInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlSideEffectsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlSignatureInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlStorageInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlStringLengthExceededInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlTransactionStatementInTriggerInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlTriggerTransitionInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlTypeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlUnicodeStringLiteralInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlUnreachableCodeInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlUnusedCteInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlUnusedSubqueryItemInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlUnusedVariableInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SqlWithoutWhereInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StandardJS" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="StandardVariableNames" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StatefulEp" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StatementsPerFunctionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticCallOnSubclass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticCollection" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreWeakCollections" value="false" />
-    </inspection_tool>
-    <inspection_tool class="StaticFieldReferenceOnSubclass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticGuardedByInstance" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticImport" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticInheritance" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticInitializerReferencesSubClass" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StaticMethodOnlyUsedInOneClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticNonFinalField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticPseudoFunctionalStyleMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StaticSuite" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StaticVariableInitialization" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignorePrimitives" value="false" />
-    </inspection_tool>
-    <inspection_tool class="StaticVariableOfConcreteClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StaticVariableUninitializedUse" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignorePrimitives" value="false" />
-    </inspection_tool>
-    <inspection_tool class="StreamToLoop" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="StringBufferField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringBufferMustHaveInitialCapacity" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringBufferReplaceableByString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringBufferReplaceableByStringBuilder" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringBufferToStringInConcatenation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringConcatenation" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreAsserts" value="false" />
-      <option name="ignoreSystemOuts" value="false" />
-      <option name="ignoreSystemErrs" value="false" />
-      <option name="ignoreThrowableArguments" value="false" />
-      <option name="ignoreConstantInitializers" value="false" />
-      <option name="ignoreInTestCode" value="false" />
-      <option name="ignoreInToString" value="false" />
-    </inspection_tool>
-    <inspection_tool class="StringConcatenationArgumentToLogCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringConcatenationInFormatCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringConcatenationInLoops" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringConcatenationInMessageFormatCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringConcatenationInsideStringBufferAppend" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringConcatenationMissingWhitespace" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringEquality" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringEqualsCharSequence" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringEqualsEmptyString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringLiteralBreaksHTMLJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringOperationCanBeSimplified" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringRepeatCanBeUsed" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StringReplaceableByStringBuffer" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="onlyWarnOnLoop" value="true" />
-    </inspection_tool>
-    <inspection_tool class="StringToUpperWithoutLocale" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringTokenizer" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="StringTokenizerDelimiter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="StudyItemNotFound" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="Stylelint" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="SubtractionInCompareTo" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuperTearDownInFinally" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuppressionAnnotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspendFunctionOnCoroutineScope" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousArrayCast" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousArrayMethodCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousAsDynamic" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousCallableReferenceInLambda" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousCollectionReassignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousDateFormat" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousEqualsCombination" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousGetterSetter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousIndentAfterControlStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousIntegerDivAssignment" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousInvocationHandlerImplementation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousListRemoveInLoop" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousLiteralUnderscore" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousLocalesLanguages" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousMethodCalls" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="REPORT_CONVERTIBLE_METHOD_CALLS" value="true" />
-    </inspection_tool>
-    <inspection_tool class="SuspiciousNameCombination" enabled="true" level="WARNING" enabled_by_default="true">
-      <group names="x,width,left,right" />
-      <group names="y,height,top,bottom" />
-      <ignored>
-        <option name="METHOD_MATCHER_CONFIG" value="java.io.PrintStream,println,java.io.PrintWriter,println,java.lang.System,identityHashCode,java.sql.PreparedStatement,set.*,java.sql.ResultSet,update.*,java.sql.SQLOutput,write.*,java.lang.Integer,compare.*,java.lang.Long,compare.*,java.lang.Short,compare,java.lang.Byte,compare,java.lang.Character,compare,java.lang.Boolean,compare,java.lang.Math,.*,java.lang.StrictMath,.*" />
-      </ignored>
-    </inspection_tool>
-    <inspection_tool class="SuspiciousPackagePrivateAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousSystemArraycopy" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousTernaryOperatorInVarargsCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousToArrayCall" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SuspiciousTypeOfGuard" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SuspiciousVarProperty" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SwitchLabeledRuleCanBeCodeBlock" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="SwitchStatement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SwitchStatementDensity" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="20" />
-    </inspection_tool>
-    <inspection_tool class="SwitchStatementWithConfusingDeclaration" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SwitchStatementWithTooFewBranches" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_limit" value="2" />
-    </inspection_tool>
-    <inspection_tool class="SwitchStatementWithTooManyBranches" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="10" />
-    </inspection_tool>
-    <inspection_tool class="SwitchStatementsWithoutDefault" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="m_ignoreFullyCoveredEnums" value="true" />
-    </inspection_tool>
-    <inspection_tool class="SynchronizationOnGetClass" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SynchronizationOnLocalVariableOrMethodParameter" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="reportLocalVariables" value="true" />
-      <option name="reportMethodParameters" value="true" />
-    </inspection_tool>
-    <inspection_tool class="SynchronizationOnStaticField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SynchronizeOnLock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SynchronizeOnNonFinalField" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="SynchronizeOnThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SynchronizeOnValueBasedClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SynchronizedMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_includeNativeMethods" value="true" />
-      <option name="ignoreSynchronizedSuperMethods" value="true" />
-    </inspection_tool>
-    <inspection_tool class="SynchronizedOnLiteralObject" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SyntaxError" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="SystemExit" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SystemGC" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SystemGetenv" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SystemOutErr" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SystemProperties" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SystemRunFinalizersOnExit" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="SystemSetSecurityManager" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TaglibDomModelInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="TailRecursion" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="TailRecursionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TaskFileNotFound" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="TestCaseInProductCode" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TestCaseWithConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TestCaseWithNoTestMethods" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreSupers" value="true" />
-    </inspection_tool>
-    <inspection_tool class="TestFailedLine" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TestFunctionName" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="TestMethodInProductCode" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TestMethodIsPublicVoidNoArg" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TestMethodWithoutAssertion" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TestNGDataProvider" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TestOnlyProblems" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TextBlockBackwardMigration" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="TextBlockMigration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TextLabelInSwitchStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TextLabelInSwitchStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThisEscapedInConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThisExpressionReferencesGlobalObjectJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadDeathRethrown" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadDumpStack" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadLocalNotStaticFinal" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadPriority" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadRun" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ThreadStartInConstruction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadStopSuspendResume" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadWithDefaultRunMethod" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreadYield" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreeNegationsPerFunctionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThreeNegationsPerMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreInEquals" value="true" />
-      <option name="ignoreInAssert" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ThrowCaughtLocally" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreRethrownExceptions" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ThrowFromFinallyBlock" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ThrowFromFinallyBlockJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThrowableNotThrown" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ThrowablePrintStackTrace" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ThrowablePrintedToSystemOut" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ThrownExceptionsPerMethod" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_limit" value="3" />
-    </inspection_tool>
-    <inspection_tool class="ThrowsRuntimeException" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TimeToString" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ToArrayCallWithZeroLengthArrayArgument" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ToSetAndBack" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TodoComment" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TooBroadCatch" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TooBroadScope" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="m_allowConstructorAsInitializer" value="false" />
-      <option name="m_onlyLookAtBlocks" value="false" />
-    </inspection_tool>
-    <inspection_tool class="TooBroadThrows" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TrailingComma" enabled="false" level="INFO" enabled_by_default="false" />
-    <inspection_tool class="TrailingSpacesInProperty" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TrailingWhitespacesInTextBlock" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TransientFieldInNonSerializableClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TransientFieldNotInitialized" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TrivialConditionalJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TrivialFunctionalExpressionUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TrivialIf" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TrivialIfJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TrivialStringConcatenation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TryFinallyCanBeTryWithResources" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TryStatementWithMultipleResources" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="TryWithIdenticalCatches" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TsLint" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeAnnotation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TypeCheckCanBeMatch" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TypeCustomizer" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TypeMayBeWeakened" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="useRighthandTypeAsWeakestTypeInAssignments" value="true" />
-      <option name="useParameterizedTypeForCollectionMethods" value="true" />
-      <option name="doNotWeakenToJavaLangObject" value="true" />
-      <option name="onlyWeakentoInterface" value="true" />
-    </inspection_tool>
-    <inspection_tool class="TypeParameterExtendsFinalClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeParameterExtendsObject" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TypeParameterFindViewById" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeParameterHidesVisibleType" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TypeParameterShadow" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="TypeScriptAbstractClassConstructorCanBeMadeProtected" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptCheckImport" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptConfig" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptDuplicateUnionOrIntersectionType" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptExplicitMemberType" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptFieldCanBeMadeReadonly" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptLibrary" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptMissingAugmentationImport" enabled="false" level="INFORMATION" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptMissingConfigOption" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptRedundantGenericType" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptSmartCast" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptSuspiciousConstructorParameterAssignment" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptUMDGlobal" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptUnresolvedFunction" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptUnresolvedReactComponent" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptUnresolvedVariable" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptValidateGenericTypes" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptValidateJSTypes" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="TypeScriptValidateTypes" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="UElementAsPsi" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UNCHECKED_WARNING" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UNUSED_IMPORT" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UastIncorrectHttpHeaderInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UastIncorrectMimeTypeInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="UnaryPlus" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UncheckedExceptionClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnclearBinaryExpression" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="UnclearPrecedenceOfBinaryExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnconditionalWait" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnconstructableTestCase" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UndeclaredTests" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UndesirableClassUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnfinishedStepVerifier" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnhandledExceptionInJSP" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnitInMap" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnitMethodDeclaredWithTypeAnnotation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnitMethodDefinedLikeFunction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnitMethodDefinedWithEqualsSign" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnitMethodIsParameterless" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnknownGuard" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnknownLanguage" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="UnlabeledReturnInsideLambda" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="UnnecessarilyQualifiedInnerClassAccess" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="ignoreReferencesNeedingImport" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessarilyQualifiedStaticUsage" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreStaticFieldAccesses" value="false" />
-      <option name="m_ignoreStaticMethodCalls" value="false" />
-      <option name="m_ignoreStaticAccessFromStaticContext" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessarilyQualifiedStaticallyImportedElement" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryBlockStatement" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="ignoreSwitchBranches" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessaryBoxing" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryBreak" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryCallToStringValueOf" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryConditionalExpression" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryConstantArrayCreationExpression" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryContinue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryContinueJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryDefault" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryEmptyArrayUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryEnumModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryExplicitNumericCast" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryFinalOnLocalVariableOrParameter" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryFullyQualifiedName" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="m_ignoreJavadoc" value="false" />
-      <option name="ignoreInModuleStatements" value="true" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessaryInheritDoc" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryInitCause" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryInterfaceModifier" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryJavaDocLink" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreInlineLinkToSuper" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessaryLabelJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryLabelOnBreakStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryLabelOnBreakStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryLabelOnContinueStatement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryLabelOnContinueStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryLocalVariable" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="m_ignoreImmediatelyReturnedVariables" value="false" />
-      <option name="m_ignoreAnnotatedVariables" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessaryLocalVariableJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryModuleDependencyInspection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryParentheses" enabled="true" level="INFORMATION" enabled_by_default="true">
-      <option name="ignoreClarifyingParentheses" value="false" />
-      <option name="ignoreParenthesesOnConditionals" value="false" />
-      <option name="ignoreParenthesesOnLambdaParameter" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnnecessaryPartialFunction" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryQualifiedReference" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryQualifierForThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryReturn" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryReturnJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessarySemicolon" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryStringEscape" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessarySuperConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessarySuperQualifier" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryTemporaryOnConversionFromString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryTemporaryOnConversionToString" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryThis" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryToStringCall" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryUnaryMinus" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryUnboxing" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnnecessaryUnicodeEscape" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnnecessaryVariable" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnparsedCustomBeanInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnpredictableBigDecimalConstructorCall" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="ignoreReferences" value="true" />
-      <option name="ignoreComplexLiterals" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnqualifiedFieldAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnqualifiedInnerClassAccess" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreReferencesToLocalInnerClasses" value="true" />
-    </inspection_tool>
-    <inspection_tool class="UnqualifiedMethodAccess" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnqualifiedStaticUsage" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="m_ignoreStaticFieldAccesses" value="false" />
-      <option name="m_ignoreStaticMethodCalls" value="false" />
-      <option name="m_ignoreStaticAccessFromStaticContext" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UnreachableCodeJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnresolvedMessageChannel" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnresolvedPropertyKey" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="UnresolvedReference" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="UnresolvedRestParam" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="UnsafeCastFromDynamic" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="UnsafeReturnStatementVisitor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnsafeVfsRecursion" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnsatisfiedRange" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnsecureRandomNumberGeneration" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnstableApiUsage" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnstableTypeUsedInSignature" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnterminatedStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnusedAssignment" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="REPORT_PREFIX_EXPRESSIONS" value="false" />
-      <option name="REPORT_POSTFIX_EXPRESSIONS" value="true" />
-      <option name="REPORT_REDUNDANT_INITIALIZER" value="true" />
-    </inspection_tool>
-    <inspection_tool class="UnusedCatchParameterJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnusedDataClassCopyResult" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnusedDefine" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnusedEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedLabel" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedLambdaExpressionBody" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedLibrary" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnusedMainParameter" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedMessageFormatParameter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedProperty" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedReceiverParameter" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedReturnValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedSymbol" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UnusedUnaryOperator" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UnzipSingleElement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UpperCaseFieldNameNotConstant" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseBulkOperation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseCompareMethod" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseCouple" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseDPIAwareBorders" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseDPIAwareInsets" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseEllipsisInPropertyInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseExpressionBody" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="UseJBColor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseOfAWTPeerClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfAnotherObjectsPrivateField" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignoreSameClass" value="false" />
-      <option name="ignoreEquals" value="false" />
-    </inspection_tool>
-    <inspection_tool class="UseOfClone" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfJDBCDriverClass" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfObsoleteAssert" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfObsoleteDateTimeApi" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfProcessBuilder" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfPropertiesAsHashtable" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UseOfSunClasses" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UsePrimitiveTypes" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UsePropertyAccessSyntax" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseVirtualFileEquals" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UseWithIndex" enabled="true" level="INFO" enabled_by_default="true" />
-    <inspection_tool class="UselessCallOnCollection" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UselessCallOnNotNull" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="UtilSchemaInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="UtilityClass" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignorableAnnotations">
-        <value />
-      </option>
-    </inspection_tool>
-    <inspection_tool class="UtilityClassCanBeEnum" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UtilityClassWithPublicConstructor" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="UtilityClassWithoutPrivateConstructor" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="ignorableAnnotations">
-        <value />
-      </option>
-      <option name="ignoreClassesWithOnlyMain" value="false" />
-    </inspection_tool>
-    <inspection_tool class="ValidExternallyBoundObject" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="VarCouldBeVal" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="VarargParameter" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="VariableNotUsedInsideIf" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VariablePatternShadow" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VariableTypeCanBeExplicit" enabled="true" level="INFORMATION" enabled_by_default="true" />
-    <inspection_tool class="VoidExpressionJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VoidMethodAnnotatedWithGET" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VolatileArrayField" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VtlDirectiveArgsInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VtlFileReferencesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VtlInterpolationsInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="VtlReferencesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VtlTypesInspection" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VueDataFunction" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="VueDuplicateTag" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="W3CssValidation" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WSReferenceInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="WadlDomInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="WaitCalledOnCondition" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WaitNotInLoop" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WaitNotifyNotInSynchronizedContext" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WaitOrAwaitWithoutTimeout" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WaitWhileHoldingTwoLocks" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WaitWithoutCorrespondingNotify" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WarningOnMainUnusedParameterMigration" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="WeakerAccess" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="SUGGEST_PACKAGE_LOCAL_FOR_MEMBERS" value="true" />
-      <option name="SUGGEST_PACKAGE_LOCAL_FOR_TOP_CLASSES" value="true" />
-      <option name="SUGGEST_PRIVATE_FOR_INNERS" value="false" />
-    </inspection_tool>
-    <inspection_tool class="WebProperties" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="WebWarnings" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WebpackConfigHighlighting" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WhenWithOnlyElse" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
-    <inspection_tool class="WhileCanBeForeach" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="WhileLoopSpinsOnField" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="ignoreNonEmtpyLoops" value="true" />
-    </inspection_tool>
-    <inspection_tool class="WithStatementJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WorksheetPackageDeclaration" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="WrapUnaryOperator" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="WrapperTypeMayBePrimitive" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="WriteOnlyObject" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="WrongPackageStatement" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="WrongPropertyKeyValueDelimiter" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="WsdlHighlightingInspection" enabled="false" level="ERROR" enabled_by_default="false" />
-    <inspection_tool class="XHTMLIncompatabilitiesJS" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="XmlDefaultAttributeValue" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="XmlDeprecatedElement" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="XmlDuplicatedId" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XmlHighlighting" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XmlInvalidId" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XmlPathReference" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XmlUnboundNsPrefix" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="XmlUnusedNamespaceDeclaration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="XmlWrongFileType" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="XmlWrongRootElement" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XsltDeclarations" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XsltTemplateInvocation" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="XsltUnusedDeclaration" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="XsltVariableShadowing" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="YAMLDuplicatedKeys" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="YAMLRecursiveAlias" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="YAMLSchemaDeprecation" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="YAMLSchemaValidation" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="YAMLUnresolvedAlias" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="YAMLUnusedAnchor" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ZeroIndexToHead" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ZeroLengthArrayInitialization" enabled="false" level="WARNING" enabled_by_default="false" />
-    <inspection_tool class="ZipWithIndex" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="dependsOnMethodTestNG" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="groupsTestNG" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="groups">
-        <value>
-          <list size="0" />
-        </value>
-      </option>
-    </inspection_tool>
-    <inspection_tool class="unused" enabled="false" level="WARNING" enabled_by_default="false">
-      <option name="LOCAL_VARIABLE" value="true" />
-      <option name="FIELD" value="true" />
-      <option name="METHOD" value="true" />
-      <option name="CLASS" value="true" />
-      <option name="PARAMETER" value="true" />
-      <option name="REPORT_PARAMETER_FOR_PUBLIC_METHODS" value="true" />
-      <option name="ADD_MAINS_TO_ENTRIES" value="true" />
-      <option name="ADD_APPLET_TO_ENTRIES" value="true" />
-      <option name="ADD_SERVLET_TO_ENTRIES" value="true" />
-      <option name="ADD_NONJAVA_TO_ENTRIES" value="true" />
-    </inspection_tool>
-  </profile>
-</component>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
deleted file mode 100644
index 57337953a0f..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
+++ /dev/null
@@ -1,61 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="ExternalStorageConfigurationManager" enabled="true" />
-  <component name="FrameworkDetectionExcludesConfiguration">
-    <file type="web" url="file://$PROJECT_DIR$" />
-  </component>
-  <component name="MavenProjectsManager">
-    <option name="originalFiles">
-      <list>
-        <option value="$PROJECT_DIR$/../../Utils/pom.xml" />
-      </list>
-    </option>
-  </component>
-  <component name="NullableNotNullManager">
-    <option name="myDefaultNullable" value="javax.annotation.Nullable" />
-    <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
-    <option name="myNullables">
-      <value>
-        <list size="15">
-          <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
-          <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
-          <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
-          <item index="3" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.Nullable" />
-          <item index="4" class="java.lang.String" itemvalue="android.support.annotation.Nullable" />
-          <item index="5" class="java.lang.String" itemvalue="androidx.annotation.Nullable" />
-          <item index="6" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNullable" />
-          <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.Nullable" />
-          <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableDecl" />
-          <item index="9" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableType" />
-          <item index="10" class="java.lang.String" itemvalue="com.android.annotations.Nullable" />
-          <item index="11" class="java.lang.String" itemvalue="com.microsoft.azuretools.azurecommons.helpers.Nullable" />
-          <item index="12" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.Nullable" />
-          <item index="13" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.Nullable" />
-          <item index="14" class="java.lang.String" itemvalue="io.reactivex.annotations.Nullable" />
-        </list>
-      </value>
-    </option>
-    <option name="myNotNulls">
-      <value>
-        <list size="15">
-          <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
-          <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
-          <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
-          <item index="3" class="java.lang.String" itemvalue="android.support.annotation.NonNull" />
-          <item index="4" class="java.lang.String" itemvalue="androidx.annotation.NonNull" />
-          <item index="5" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNonNull" />
-          <item index="6" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.NonNull" />
-          <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullDecl" />
-          <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullType" />
-          <item index="9" class="java.lang.String" itemvalue="com.android.annotations.NonNull" />
-          <item index="10" class="java.lang.String" itemvalue="com.microsoft.azuretools.azurecommons.helpers.NotNull" />
-          <item index="11" class="java.lang.String" itemvalue="io.reactivex.annotations.NonNull" />
-          <item index="12" class="java.lang.String" itemvalue="lombok.NonNull" />
-          <item index="13" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.NonNull" />
-          <item index="14" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.NonNull" />
-        </list>
-      </value>
-    </option>
-  </component>
-  <component name="ProjectRootManager" version="2" languageLevel="JDK_17" default="true" project-jdk-name="17" project-jdk-type="JavaSDK" />
-</project>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/vcs.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/vcs.xml
deleted file mode 100644
index b2bdec2d71b..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/vcs.xml
+++ /dev/null
@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="VcsDirectoryMappings">
-    <mapping directory="$PROJECT_DIR$/../.." vcs="Git" />
-  </component>
-</project>
\ No newline at end of file

From 71902b59685a3e670d8ed7ac09c76a9191cf2c2f Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 19 Jun 2024 21:07:01 -0700
Subject: [PATCH 013/144] create readme

---
 .../azure-intellij-plugin-azure-sdk/README.md     | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
new file mode 100644
index 00000000000..95243fda7f4
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -0,0 +1,15 @@
+# Project: Java Code Quality Analyzer
+
+## Project Description
+The Java Code Quality Analyzer, is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
+
+## Key Features
+
+- **Rule Set Integration**: This feature enables users to import and customize rule sets, tailoring the plugin to their specific needs.
+- **Telemetry Integration**: This feature connects the plugin to the backend with Application Insights, allowing for efficient data transmission.
+- **Azure Toolkit Integration**: This feature allows the plugin to integrate with the IntelliJ Azure toolkit, providing extended functionality.
+- **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
+- **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
+
+## User Interface
+- **Rule Configuration Panel** : This space allows users to enable or disable telemetry if desired.
\ No newline at end of file

From ba056ca151b93d935f6664e916b8c136543f029a Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 19 Jun 2024 21:10:49 -0700
Subject: [PATCH 014/144] Update README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md                   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 95243fda7f4..3cd55989065 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -12,4 +12,4 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 
 ## User Interface
-- **Rule Configuration Panel** : This space allows users to enable or disable telemetry if desired.
\ No newline at end of file
+- **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.

From ef3eb3f72411a1bfca211224ee310fe37b5870fa Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 20 Jun 2024 21:18:52 -0700
Subject: [PATCH 015/144] address comments, some refactoring, and tests

---
 .../azure-toolkit-for-intellij/.gitignore     |   3 +
 .../.idea/gradle.xml                          |   2 +-
 .../azure-intellij-plugin-azure-sdk/README.md |  13 ++
 .../build.gradle                              |   7 +-
 .../ServiceBusReceiverAsyncClientCheck.java   |  69 ++++++++--
 .../azure-intellij-plugin-azure-sdk.xml       |   4 +-
 .../main/resources/META-INF/ruleConfigs.json  |   6 +
 ...erviceBusReceiverAsyncClientCheckTest.java | 125 ++++++++++++++++++
 8 files changed, 215 insertions(+), 14 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 6691dbbf974..2b332718319 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -44,3 +44,6 @@ gen-external-apklibs/
 
 # Jar dependencies generated in build
 **/resources/spark/spark-tools-*.jar
+
+#.idea
+/azure-intellij-plugin-azure-sdk/.idea/
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
index 1b74c3eb9f7..498939a6530 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
@@ -4,9 +4,9 @@
   <component name="GradleSettings">
     <option name="linkedExternalProjectsSettings">
       <GradleProjectSettings>
+        <option name="testRunner" value="PLATFORM" />
         <option name="distributionType" value="WRAPPED" />
         <option name="externalProjectPath" value="$PROJECT_DIR$" />
-        <option name="gradleHome" value="$USER_HOME$/Tools/gradle-7.1.1-all/gradle-7.1.1" />
         <option name="modules">
           <set>
             <option value="$PROJECT_DIR$" />
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3cd55989065..0a5a5d7c328 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -13,3 +13,16 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 ## User Interface
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
+
+
+## Rules
+1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is discouraged due to its low-level API. 
+This API provides fine-grained control over message handling, making it suitable for scenarios where full control over message processing is required. 
+However, it necessitates a proficiency in Reactive programming and is primarily beneficial when constructing a Reactive library or an end-to-end Reactive application.
+
+As a recommendation, consider using the `ServiceBusProcessorClient` instead of the low-level `ServiceBusReceiverAsyncClient`. 
+The ServiceBusProcessorClient is a higher-level abstraction that simplifies message consumption and is tailored for most common use cases. 
+It should be the primary choice for consuming messages.
+
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..0bee027496f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,8 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
-
-}
+    implementation group: 'org.json', name: 'json', version: '20240303'
+    testImplementation'org.junit.jupiter:junit-jupiter-api:5.8.1'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1'
+    testImplementation group: 'org.mockito', name: 'mockito-core'
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 5e776e8a932..e1dcf9601fe 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -1,8 +1,27 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
-import com.intellij.codeInspection.*;
-import com.intellij.psi.*;
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiJavaCodeReferenceElement;
+import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiMethod;
+import com.intellij.psi.PsiNewExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiTypeElement;
 import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+
 
 
 /**
@@ -11,24 +30,56 @@
  */
 public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
+    public static final String configFileName = "META-INF/ruleConfigs.json";
+
+    public static List<String> getClientToCheck() {
+        try {
+
+            InputStream inputStream = ServiceBusReceiverAsyncClientCheck.class.getClassLoader().getResourceAsStream(configFileName);
+            if (inputStream == null) {
+                throw new FileNotFoundException("Configuration file not found");
+            }
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                String clientName = jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString("clientName");
+                String suggestedClient = jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString("suggestion");
+                return Arrays.asList(clientName, suggestedClient);
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+            return Collections.emptyList();
+        }
+    }
 
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-
         return new JavaElementVisitor() {
 
             @Override
-            public void visitLocalVariable(PsiLocalVariable variable) {
-                super.visitLocalVariable(variable);
+            public void visitTypeElement(PsiTypeElement element) {
+                super.visitTypeElement(element);
+
+                if (element instanceof PsiTypeElement) {
 
-                final PsiType type = variable.getType();
-                final String qualifiedName = type.getCanonicalText();
+                    PsiType type = element.getType();
+                    if (type != null) {
+                        String typeOfElement = type.getPresentableText();
 
-                if (qualifiedName.equals("com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient")) {
-                    holder.registerProblem(variable, "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead.");
+                        List<String> clientData = getClientToCheck();
+                        if (clientData.isEmpty()) {
+                            return;
+                        }
+                        String clientName = clientData.get(0);
+                        String suggestedClient = clientData.get(1);
+
+                        if (element.getType().getPresentableText().equals(clientName)) {
+                            holder.registerProblem(element, "Use of "+clientName+" detected. Use "+suggestedClient+" instead.");
+                        }
+                    }
                 }
             }
+
         };
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 020d89832bc..1aea2376681 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -27,14 +27,14 @@
         <localInspection
                 language="JAVA"
                 shortName="ServiceBusReceiverAsyncClientCheck"
-                displayName="ServiceBusReceiverAsyncClient Check"
+                displayName="Low level ServiceBusReceiverAsyncClient check"
                 groupName="Azure SDK"
                 enabledByDefault="true"
                 level="WARNING"
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
 
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
             </class>
         </localInspection>
     </extensions>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
new file mode 100644
index 00000000000..839476f7eac
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -0,0 +1,6 @@
+{
+  "ServiceBusReceiverAsyncClientCheck": {
+    "clientName": "ServiceBusReceiverAsyncClient",
+    "suggestion": "ServiceBusProcessorClient"
+  }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
new file mode 100644
index 00000000000..7095bab2c0e
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
@@ -0,0 +1,125 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+
+// Import necessary libraries
+import com.intellij.ide.highlighter.JavaFileType;
+import com.intellij.openapi.fileTypes.FileType;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiFile;
+import com.intellij.psi.PsiFileFactory;
+import com.intellij.psi.PsiTypeElement;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiType;
+import com.intellij.openapi.project.Project;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+
+
+public class ServiceBusReceiverAsyncClientCheckTest {
+
+    // Create a mock ProblemsHolder to be used in the test
+    private ProblemsHolder mockHolder;
+
+    // Create a Java code snippet that uses ServiceBusReceiverAsyncClient with situations that should be flagged
+    private String createJavaCode() {
+        StringBuilder javaCode = new StringBuilder();
+
+        javaCode.append("public class TestClass {\n");
+
+        // Define the client as a private final member
+        javaCode.append("\tprivate final ServiceBusReceiverAsyncClient client;\n");
+
+        // Create a constructor for TestClass
+        javaCode.append("\tpublic TestClass() {\n");
+        javaCode.append("\t\tthis.client = new ServiceBusReceiverAsyncClient();\n");
+        javaCode.append("\t}\n");
+
+        // Create a getClient method to access the client
+        javaCode.append("\tpublic ServiceBusReceiverAsyncClient getClient() {\n");
+        javaCode.append("\t\treturn this.client;\n");
+        javaCode.append("\t}\n");
+
+        javaCode.append("}");
+
+        return javaCode.toString();
+    }
+
+
+    @Test
+    public void testBuildVisitor() {
+        // Arrange
+        String javaCode = createJavaCode();
+        PsiElementVisitor visitor = createVisitor();
+
+        // Mock PsiFileFactory
+        PsiFileFactory psiFileFactory = mockPsiFileFactory();
+
+        // Create PsiFile
+        PsiFile psiFile = createPsiFile(javaCode, psiFileFactory);
+
+        // Accept visitor
+        psiFile.accept(visitor);
+
+        // Assert
+        assertVisitor(visitor);
+
+        // Visit Type Element
+        visitTypeElement(visitor);
+    }
+
+    // Create a visitor by calling the buildVisitor method of ServiceBusReceiverAsyncClientCheck
+    private PsiElementVisitor createVisitor() {
+        ServiceBusReceiverAsyncClientCheck check = new ServiceBusReceiverAsyncClientCheck();
+        mockHolder = mock(ProblemsHolder.class);
+        boolean isOnTheFly = true;
+
+        return check.buildVisitor(mockHolder, isOnTheFly);
+    }
+
+    // Mock PsiFileFactory and create a PsiFile to be used in the test
+    private PsiFileFactory mockPsiFileFactory() {
+        Project mockProject = mock(Project.class);
+        PsiFileFactory mockFileFactory = mock(PsiFileFactory.class);
+        when(PsiFileFactory.getInstance(mockProject)).thenReturn(mockFileFactory);
+
+        return PsiFileFactory.getInstance(mockProject);
+    }
+
+    // Create a PsiFile from the Java code to simulate the file to be inspected
+    private PsiFile createPsiFile(String javaCode, PsiFileFactory psiFileFactory) {
+        PsiFile mockFile = mock(PsiFile.class);
+        when(psiFileFactory.createFileFromText(anyString(), any(FileType.class), any())).thenReturn(mockFile);
+
+        return psiFileFactory.createFileFromText(javaCode, JavaFileType.INSTANCE, javaCode);
+    }
+
+
+    // Assert that the visitor is not null and is an instance of JavaElementVisitor
+    private void assertVisitor(PsiElementVisitor visitor) {
+        assertNotNull(visitor);
+        assertTrue(visitor instanceof JavaElementVisitor);
+    }
+
+    // Visit a Type Element and verify that a problem was registered
+    private void visitTypeElement(PsiElementVisitor visitor) {
+        PsiType mockType = mock(PsiType.class);
+        when(mockType.getPresentableText()).thenReturn("ServiceBusReceiverAsyncClient");
+
+        PsiTypeElement mockTypeElement = mock(PsiTypeElement.class);
+        when(mockTypeElement.getType()).thenReturn(mockType);
+
+        ((JavaElementVisitor) visitor).visitTypeElement(mockTypeElement);
+
+        verify(mockHolder, times(1)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains("Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."));
+    }
+}
\ No newline at end of file

From 13ce22b7f218be971d958225baeb0274ed7657a2 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 20 Jun 2024 21:44:53 -0700
Subject: [PATCH 016/144] minor edit, adding comments

---
 .../ServiceBusReceiverAsyncClientCheck.java   | 31 +++++++------------
 1 file changed, 12 insertions(+), 19 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index e1dcf9601fe..5e8d593f059 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -3,11 +3,6 @@
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.PsiElementVisitor;
-import com.intellij.psi.PsiJavaCodeReferenceElement;
-import com.intellij.psi.PsiLocalVariable;
-import com.intellij.psi.PsiMethod;
-import com.intellij.psi.PsiNewExpression;
-import com.intellij.psi.PsiType;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiTypeElement;
 import org.jetbrains.annotations.NotNull;
@@ -32,6 +27,7 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
     public static final String configFileName = "META-INF/ruleConfigs.json";
 
+    // loading the client data from the configuration file
     public static List<String> getClientToCheck() {
         try {
 
@@ -60,23 +56,20 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
             public void visitTypeElement(PsiTypeElement element) {
                 super.visitTypeElement(element);
 
-                if (element instanceof PsiTypeElement) {
+                // Check if the element is an instance of PsiTypeElement and if the type matches the discouraged client
+                if (element instanceof PsiTypeElement && element.getType() != null) {
 
-                    PsiType type = element.getType();
-                    if (type != null) {
-                        String typeOfElement = type.getPresentableText();
-
-                        List<String> clientData = getClientToCheck();
-                        if (clientData.isEmpty()) {
-                            return;
-                        }
-                        String clientName = clientData.get(0);
-                        String suggestedClient = clientData.get(1);
+                    List<String> clientData = getClientToCheck();
+                    if (clientData.isEmpty()) {
+                        return;
+                    }
+                    String clientName = clientData.get(0);
+                    String suggestedClient = clientData.get(1);
 
-                        if (element.getType().getPresentableText().equals(clientName)) {
-                            holder.registerProblem(element, "Use of "+clientName+" detected. Use "+suggestedClient+" instead.");
-                        }
+                    if (element.getType().getPresentableText().equals(clientName)) {
+                        holder.registerProblem(element, "Use of "+clientName+" detected. Use "+suggestedClient+" instead.");
                     }
+
                 }
             }
 

From 180accae84d5775ca13f4e5d938aaf24299d3591 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 23 Jun 2024 13:06:51 -0700
Subject: [PATCH 017/144] implement kql queries with time interval in query
 string rule.

---
 .../build.gradle                              |   9 +
 ...iesWithTimeIntervalInQueryStringCheck.java | 240 ++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  11 +
 .../main/resources/META-INF/ruleConfigs.json  |  13 +
 ...ithTimeIntervalInQueryStringCheckTest.java | 206 +++++++++++++++
 5 files changed, 479 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..55155ca26a6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,14 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
+    implementation group: 'org.json', name: 'json', version: '20240303'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
+    testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
+
+    testImplementation group: 'org.mockito', name: 'mockito-core'
 
 }
+
+tasks.named('test', Test) {
+    useJUnitPlatform()
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
new file mode 100644
index 00000000000..d411b40bb47
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -0,0 +1,240 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.openapi.util.text.StringUtil;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.JavaPsiFacade;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementFactory;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiLiteralExpression;
+import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiPolyadicExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiVariable;
+import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
+/**
+ * This class is an inspection tool that checks for Kusto queries with time intervals in the query string.
+ * Kusto queries should not use time intervals in the query string as it can lead to incorrect results.
+ * This inspection tool checks for the following anti-patterns:
+ * 1. Queries that use the "ago" function with a time interval.
+ * 2. Queries that use the "datetime" function with a specific datetime.
+ * 3. Queries that use the "now" function to get the current timestamp.
+ * 4. Queries that use the "startofday", "startofmonth", or "startofyear" functions.
+ * 5. Queries that use the "between" function with datetime values.
+ */
+public class KustoQueriesWithTimeIntervalInQueryStringCheck extends LocalInspectionTool {
+
+    // This method builds the visitor for the inspection tool
+
+    /**
+     * This method builds the visitor for the inspection tool
+     * @param holder
+     * @param isOnTheFly
+     * @return PsiElementVisitor
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new KustoQueriesVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * This class defines the visitor for the inspection tool
+     * The visitor checks for Kusto queries with time intervals in the query string
+     * and registers a problem if an anti-pattern is detected
+     * To check for the anti-patterns, the visitor uses regex patterns to match the query string
+     * Processing of polyadic expressions is also done to replace the variables with their values in the query string
+     * before checking for the anti-patterns.
+     */
+    public static class KustoQueriesVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+
+
+        // Define constants for string literals
+        private static final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+        private static final String ANTI_PATTERN_KEY = "antipattern_message";
+        private static final String REGEX_PATTERNS_KEY = "regex_patterns";
+        private static final Map<String, List<String>> ruleConfigurations = loadRuleConfigurations();
+
+        private static final String ANTI_PATTERN = ruleConfigurations.get(ANTI_PATTERN_KEY).get(0);
+
+        // Define your patterns
+        Pattern KQL_ANTI_PATTERN_AGO = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(0));
+        Pattern KQL_ANTI_PATTERN_DATETIME = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(1));
+        Pattern KQL_ANTI_PATTERN_NOW = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(2));
+        Pattern KQL_ANTI_PATTERN_START_OF_PERIOD = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(3));
+        Pattern KQL_ANTI_PATTERN_BETWEEN = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(4));
+
+        public KustoQueriesVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
+
+        @Override
+        public void visitElement(@NotNull PsiElement element) {
+            super.visitElement(element);
+
+            if (!(element instanceof PsiPolyadicExpression || element instanceof PsiLocalVariable)) {
+                return;
+            }
+
+            PsiExpression initializer = null;
+            PsiPolyadicExpression originalExpression = null;
+
+            if (!(element instanceof PsiPolyadicExpression)) {
+                PsiLocalVariable variable = (PsiLocalVariable) element;
+                initializer = variable.getInitializer();
+                if (initializer != null && initializer instanceof PsiLiteralExpression) {
+                    String text = initializer.toString();
+                    checkExpression(initializer, element, holder);
+                }
+            }
+
+            // if element is a polyadic expression, extract the value.
+            // PsiPolyadicExpressions are used to represent expressions with multiple operands
+            // eg ("datetime" + startDate), where startDate is a variable
+             else if (element instanceof PsiPolyadicExpression) {
+                // process the polyadic expression to replace the variables with their values
+                PsiElement processedElement = processPsiPolyadicExpressions(element.copy());
+                initializer = processedElement instanceof PsiPolyadicExpression ? (PsiPolyadicExpression) processedElement : null;
+                checkExpression(initializer, element, holder);
+            }
+        }
+
+        /** This method checks the expression for the anti-patterns by matching regex patterns with the expression text
+         * and registers a problem if an anti-pattern is detected
+         * @param expression
+         * @param element
+         * @param holder
+         */
+        void checkExpression(PsiExpression expression, PsiElement element, ProblemsHolder holder) {
+            if (expression == null) {
+                return;
+            }
+            String text = expression.getText();
+            if (
+                    KQL_ANTI_PATTERN_AGO.matcher(text).find() ||
+                    KQL_ANTI_PATTERN_DATETIME.matcher(text).find() ||
+                    KQL_ANTI_PATTERN_NOW.matcher(text).find() ||
+                    KQL_ANTI_PATTERN_START_OF_PERIOD.matcher(text).find() ||
+                    KQL_ANTI_PATTERN_BETWEEN.matcher(text).find()
+            ) {
+                holder.registerProblem(element, ANTI_PATTERN);
+            }
+        }
+
+        /** This method processes the polyadic expressions to replace the variables with their values
+         * @param element
+         * @return PsiElement
+         */
+        public PsiElement processPsiPolyadicExpressions(PsiElement element) {
+
+            // Extract the operands from the polyadic expression
+            PsiPolyadicExpression expression = (PsiPolyadicExpression) element;
+            PsiExpression[] operands = expression.getOperands();
+
+            // Iterate through the operands
+            for (int i = 0; i < operands.length; i++) {
+                PsiExpression operand = operands[i];
+
+                // PsiReferenceExpressions are used to represent references to variables
+                if (!(operand instanceof PsiReferenceExpression)) {
+                    continue;
+                }
+                PsiReferenceExpression reference = (PsiReferenceExpression) operand;
+                PsiElement resolved = reference.resolve();
+                if (!(resolved instanceof PsiVariable)) {
+                    continue;
+                }
+
+                // Extract the value of the variable
+                // Resolve means to find the declaration of the variable
+                // Initializer is the value assigned to the variable
+                PsiVariable variable = (PsiVariable) resolved;
+                PsiExpression initializer = variable.getInitializer();
+                if (initializer == null) {
+                    continue;
+                }
+
+                // Initializer.getText() returns the value of the variable in string format
+                // Create a new expression from the variable value and replace the variable with the value
+                String variableValue = initializer.getText();
+                PsiElementFactory factory = JavaPsiFacade.getInstance(element.getProject()).getElementFactory();
+                PsiExpression newExpression = factory.createExpressionFromText(variableValue, null);
+                if (newExpression != null) {
+                    operands[i] = newExpression;
+                }
+            }
+
+            // Create a new expression from the operands after replacing the variables with their values
+            // Return the new expression if it is not null, else return the original element
+            PsiElementFactory factory = JavaPsiFacade.getInstance(element.getProject()).getElementFactory();
+            String newExpressionText = StringUtil.join(operands, PsiElement::getText, "+");
+            PsiExpression newExpression = factory.createExpressionFromText(newExpressionText, null);
+            return newExpression != null ? newExpression : element;
+        }
+
+
+        /** This method loads the rule configurations from the configuration file
+         * The configuration file contains the regex patterns for the anti-patterns
+         * and the message to display when an anti-pattern is detected
+         * @return Map<String, List<String>>
+         */
+        private static Map<String, List<String>> loadRuleConfigurations() {
+
+            // move magic strings to constants
+            final String KQL_ANTI_PATTERN_AGO = "KQL_ANTI_PATTERN_AGO";
+            final String KQL_ANTI_PATTERN_DATETIME = "KQL_ANTI_PATTERN_DATETIME";
+            final String KQL_ANTI_PATTERN_NOW = "KQL_ANTI_PATTERN_NOW";
+            final String KQL_ANTI_PATTERN_START_OF_PERIOD = "KQL_ANTI_PATTERN_START_OF_PERIOD";
+            final String KQL_ANTI_PATTERN_BETWEEN = "KQL_ANTI_PATTERN_BETWEEN";
+
+            try {
+                InputStream inputStream = KustoQueriesWithTimeIntervalInQueryStringCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
+                if (inputStream == null) {
+                    throw new FileNotFoundException("Configuration file not found");
+                }
+                try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                    JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                    JSONObject kustoCheckObject = jsonObject.getJSONObject("KustoQueriesWithTimeIntervalInQueryStringCheck");
+                    JSONObject regexPatterns = kustoCheckObject.getJSONObject(REGEX_PATTERNS_KEY);
+
+                    Map<String, List<String>> ruleConfigurations = new HashMap<>();
+                    ruleConfigurations.put(REGEX_PATTERNS_KEY, Arrays.asList(
+                            regexPatterns.getString(KQL_ANTI_PATTERN_AGO),
+                            regexPatterns.getString(KQL_ANTI_PATTERN_DATETIME),
+                            regexPatterns.getString(KQL_ANTI_PATTERN_NOW),
+                            regexPatterns.getString(KQL_ANTI_PATTERN_START_OF_PERIOD),
+                            regexPatterns.getString(KQL_ANTI_PATTERN_BETWEEN)
+                    ));
+                    ruleConfigurations.put(ANTI_PATTERN_KEY, Collections.singletonList(jsonObject.getJSONObject("KustoQueriesWithTimeIntervalInQueryStringCheck").getString(ANTI_PATTERN_KEY)));
+                    return ruleConfigurations;
+                }
+            } catch (Exception e) {
+                e.printStackTrace();
+                return Collections.emptyMap();
+            }
+        }
+    };
+
+}
+
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..b305c982b09 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,16 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="KustoQueriesWithTimeIntervalInQueryStringCheck"
+                displayName="Kusto Queries With TIme Interval In Query String Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck">
+            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck</class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
new file mode 100644
index 00000000000..981c521dd07
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -0,0 +1,13 @@
+{
+  "KustoQueriesWithTimeIntervalInQueryStringCheck": {
+    "regex_patterns": {
+      "KQL_ANTI_PATTERN_AGO": "\"?ago\\(\"?\\+?\"?\\d+[smhdw]\"?\\+?\"?\\)?\"?",
+      "KQL_ANTI_PATTERN_DATETIME": ".*datetime\\s*\\(\\s*[\"\\+\\s]*\\d{4}-\\d{2}-\\d{2}(?:T\\d{2}:\\d{2}:\\d{2}Z)?[\"\\+\\s]*\\s*\\)",
+      "KQL_ANTI_PATTERN_NOW": "now\\(\\)",
+      "KQL_ANTI_PATTERN_START_OF_PERIOD": "startofday\\(\\)|startofmonth\\(\\)|startofyear\\(\\)",
+      "KQL_ANTI_PATTERN_BETWEEN": ".*between\\\\(datetime\\\\(\\\\d{4}-\\\\d{2}-\\\\d{2}\\\\), datetime\\\\(\\\\d{4}-\\\\d{2}-\\\\d{2}\\\\)\\\\)\n"
+    },
+    "antipattern_message": "KQL queries with time intervals in the query string detected.",
+    "solution": "Use the QueryTimeInterval parameter in the client method parameters to specify the time interval for the query"
+  }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
new file mode 100644
index 00000000000..c394155355b
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -0,0 +1,206 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor;
+
+// Import necessary libraries
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.JavaPsiFacade;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementFactory;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiPolyadicExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.openapi.project.Project;
+import com.intellij.psi.PsiVariable;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.ArgumentMatchers.isNull;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+/**
+ * This class tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
+ *
+ * These are some example queries that should be flagged:
+ * 1. "String query1 = \"| where timestamp > ago(1d)\";": This query uses the ago function to create a time interval of 1 day. This should be FLAGGED.
+ * 2. "String query2 = \"| where timestamp > datetime(2021-01-01)\";": This query compares the timestamp to a specific datetime. This should be FLAGGED.
+ * 3. "String query3 = \"| where timestamp > now()\";": This query uses the now function to get the current timestamp. This should be FLAGGED.
+ * 4. "String query4 = \"| where timestamp > startofday()\";": This query uses the startofday function to get the start of the current day. This should be FLAGGED.
+ * 5. "String query5 = \"| where timestamp > startofmonth()\";": This query uses the startofmonth function to get the start of the current month. This should be FLAGGED.
+ * 6. "String query11 = \"| where timestamp > ago(\" + days + \")\";": This query uses a variable to define the time interval. This should be FLAGGED.
+ * 7. "String query12 = \"| where timestamp > datetime(\" + date + \")\";": This query uses a variable to define the datetime. This should not be FLAGGED.
+ */
+
+public class KustoQueriesWithTimeIntervalInQueryStringCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+    private PsiElementVisitor mockVisitor;
+    private PsiElement mockElement;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockElement = mock(PsiElement.class);
+    }
+
+    /**
+     * This is the main test method that tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
+     */
+    @Test
+    public void testKustoQueriesWithTimeIntervalInQueryStringCheck() {
+
+        // assert visitor
+        assertVisitor(mockVisitor);
+
+        // Visit PsiPolyadicExpression
+        visitPsiPolyadicExpression(mockVisitor, mockElement);
+
+        // Visit other literals
+        visitOtherLiterals(mockVisitor,mockElement);
+    }
+
+    /**
+     * Create a visitor by calling the buildVisitor method of KustoQueriesWithTimeIntervalInQueryStringCheck
+     * @return PsiElementVisitor
+     */
+    PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        KustoQueriesVisitor visitor = new KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
+
+    /**
+     * Assert that the visitor is not null and is an instance of JavaElementVisitor
+     * @param visitor
+     */
+    void assertVisitor(PsiElementVisitor visitor) {
+        assertNotNull(visitor);
+        assertTrue(visitor instanceof JavaElementVisitor);
+    }
+
+    /**
+     * This method tests the processPsiPolyadicExpressions method
+     * for a PsiPolyadicExpression that should be flagged
+     * @param mockVisitor
+     * @param mockElement
+     */
+    void visitPsiPolyadicExpression(PsiElementVisitor mockVisitor, PsiElement mockElement) {
+
+        // Arrange
+        PsiPolyadicExpression mockExpression = mock(PsiPolyadicExpression.class);
+        PsiExpression mockNewExpression = mock(PsiExpression.class);
+        PsiReferenceExpression mockReference = mock(PsiReferenceExpression.class);
+        PsiVariable mockVariable = mock(PsiVariable.class);
+        PsiExpression mockInitializer = mock(PsiExpression.class);
+        JavaPsiFacade mockJavaPsiFacade = mock(JavaPsiFacade.class);
+        Project mockProject = mock(Project.class);
+        PsiElementFactory mockPsiElementFactory = mock(PsiElementFactory.class);
+
+        when(mockElement.getProject()).thenReturn(mockProject);
+        when(mockExpression.getOperands()).thenReturn(new PsiExpression[]{mockReference});
+        when(mockExpression.getText()).thenReturn("test");
+        when(mockExpression.getProject()).thenReturn(mockProject);
+        when(mockReference.resolve()).thenReturn(mockVariable);
+        when(mockVariable.getInitializer()).thenReturn(mockInitializer);
+        when(mockInitializer.getText()).thenReturn("datetime(2022-01-01)");
+        when(mockNewExpression.getText()).thenReturn("datetime(2022-01-01)");
+
+        when(mockJavaPsiFacade.getInstance(mockProject)).thenReturn(mockJavaPsiFacade);
+        when(mockJavaPsiFacade.getElementFactory()).thenReturn(mockPsiElementFactory);
+        when(mockPsiElementFactory.createExpressionFromText(eq("datetime(2022-01-01)"), isNull())).thenReturn(mockNewExpression);
+
+
+        // Act
+        PsiElement result = ((KustoQueriesVisitor) mockVisitor).processPsiPolyadicExpressions(mockExpression);
+        ((KustoQueriesVisitor) mockVisitor).checkExpression(mockInitializer, mockElement, mockHolder);
+
+        // Assert
+        assertEquals(mockNewExpression, result);
+
+        // Verify registerProblem is called
+        verify(mockHolder, times(1)).registerProblem(Mockito.eq(mockElement), Mockito.contains("KQL queries with time intervals in the query string detected."));
+    }
+
+    /**
+     * This method tests the checkExpression method for other literals that should be flagged
+     * @param mockVisitor
+     * @param mockElement
+     */
+
+    void visitOtherLiterals(PsiElementVisitor mockVisitor, PsiElement mockElement) {
+
+        // Arrange
+        PsiLocalVariable mockVariable = mock(PsiLocalVariable.class);
+        PsiExpression mockInitializer = mock(PsiExpression.class);
+
+        when(mockVariable.getInitializer()).thenReturn(mockInitializer);
+        when(mockInitializer.toString()).thenReturn("datetime(2022-01-01)");
+        when(mockInitializer.getText()).thenReturn("datetime(2022-01-01)");
+
+        // Act
+        ((KustoQueriesVisitor) mockVisitor).checkExpression(mockInitializer, mockVariable, mockHolder);
+
+        // Verify registerProblem is not called
+        verify(mockHolder, times(1)).registerProblem(Mockito.eq(mockElement), Mockito.contains("KQL queries with time intervals in the query string detected."));
+    }
+
+    /**
+     * This test checks the checkExpression method with a null expression as input
+     */
+    @Test
+    public void testCheckExpressionWithNullExpression() {
+        // Arrange
+        PsiExpression nullExpression = null;
+
+        // Act
+        ((KustoQueriesVisitor) mockVisitor).checkExpression(nullExpression, mockElement, mockHolder);
+
+        // Assert
+        // In this case, we expect that no problem will be registered, because the expression is null
+        verify(mockHolder, times(0)).registerProblem(any(), any());
+    }
+
+    /**
+     * This test checks the checkExpression method with no operands,
+     * which may be due to a PolyadicExpressions that was not formed correctly
+     */
+    @Test
+    public void testProcessPsiPolyadicExpressionsWithNoOperands() {
+
+        // Arrange
+        Project mockProject = mock(Project.class);
+        PsiExpression mockNewExpression = mock(PsiExpression.class);
+        PsiPolyadicExpression mockExpression = mock(PsiPolyadicExpression.class);
+        PsiElementFactory mockPsiElementFactory = mock(PsiElementFactory.class);
+        JavaPsiFacade mockJavaPsiFacade = mock(JavaPsiFacade.class);
+
+        when(mockExpression.getOperands()).thenReturn(new PsiExpression[]{});
+        when(mockExpression.getProject()).thenReturn(mockProject);
+        when(mockJavaPsiFacade.getInstance(mockProject)).thenReturn(mockJavaPsiFacade);
+        when(mockJavaPsiFacade.getElementFactory()).thenReturn(mockPsiElementFactory);
+        when(mockPsiElementFactory.createExpressionFromText(eq("datetime(2d)"), isNull())).thenReturn(mockNewExpression);
+
+        // Act
+        PsiElement result = ((KustoQueriesVisitor) mockVisitor).processPsiPolyadicExpressions(mockExpression);
+
+        // Assert
+        // In this case, we expect that the result is the same as the original expression,
+        // because the expression has no operands and therefore nothing was replaced
+        assertEquals(mockExpression, result);
+    }
+}
\ No newline at end of file

From b1791079607fc706beb1089cc1a337477a972776 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 23 Jun 2024 13:37:29 -0700
Subject: [PATCH 018/144] updating README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md | 14 +++++++
 ...iesWithTimeIntervalInQueryStringCheck.java | 39 ++++++++++++-------
 2 files changed, 38 insertions(+), 15 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3cd55989065..041b63d94aa 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -13,3 +13,17 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 ## User Interface
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
+
+
+## Rules
+1. #### Kusto Queries Having a Time Interval in the Query String
+
+Writing KQL queries with hard-coded time intervals directly in the query string is an anti-pattern. 
+Time intervals include using ago(1d) or between(datetime(2023-01-01), datetime(2023-01-02)). 
+This approach makes queries less flexible and harder to troubleshoot.
+
+Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the time interval for the query. 
+By passing the time range as an argument in the method call, you make it easier to troubleshoot and understand the context of an API call. 
+This approach enhances the flexibility and readability of your Kusto queries.
+
+Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index d411b40bb47..bcf8f7d0872 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -31,7 +31,7 @@
 
 /**
  * This class is an inspection tool that checks for Kusto queries with time intervals in the query string.
- * Kusto queries should not use time intervals in the query string as it can lead to incorrect results.
+ * This approach makes queries less flexible and harder to troubleshoot.
  * This inspection tool checks for the following anti-patterns:
  * 1. Queries that use the "ago" function with a time interval.
  * 2. Queries that use the "datetime" function with a specific datetime.
@@ -45,8 +45,8 @@ public class KustoQueriesWithTimeIntervalInQueryStringCheck extends LocalInspect
 
     /**
      * This method builds the visitor for the inspection tool
-     * @param holder
-     * @param isOnTheFly
+     * @param holder ProblemsHolder is used to register problems found in the code
+     * @param isOnTheFly boolean to indicate if the inspection is done on the fly
      * @return PsiElementVisitor
      */
     @NotNull
@@ -84,11 +84,26 @@ public static class KustoQueriesVisitor extends JavaElementVisitor {
         Pattern KQL_ANTI_PATTERN_START_OF_PERIOD = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(3));
         Pattern KQL_ANTI_PATTERN_BETWEEN = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(4));
 
+        /**
+         * Constructor for the KustoQueriesVisitor class
+         * The constructor initializes the ProblemsHolder and isOnTheFly variables
+         * @param holder
+         * @param isOnTheFly
+         */
         public KustoQueriesVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
             this.isOnTheFly = isOnTheFly;
         }
 
+        /**
+         * This method visits the element and checks for the anti-patterns
+         * The method checks if the element is a PsiPolyadicExpression or a PsiLocalVariable
+         * If the element is a PsiLocalVariable, the method checks the initializer of the variable
+         * If the element is a PsiPolyadicExpression, the method processes the expression to replace the variables with their values
+         * The method then checks the expression for the anti-patterns by matching regex patterns with the expression text
+         * and registers a problem if an anti-pattern is detected
+         * @param element
+         */
         @Override
         public void visitElement(@NotNull PsiElement element) {
             super.visitElement(element);
@@ -96,7 +111,6 @@ public void visitElement(@NotNull PsiElement element) {
             if (!(element instanceof PsiPolyadicExpression || element instanceof PsiLocalVariable)) {
                 return;
             }
-
             PsiExpression initializer = null;
             PsiPolyadicExpression originalExpression = null;
 
@@ -108,7 +122,6 @@ public void visitElement(@NotNull PsiElement element) {
                     checkExpression(initializer, element, holder);
                 }
             }
-
             // if element is a polyadic expression, extract the value.
             // PsiPolyadicExpressions are used to represent expressions with multiple operands
             // eg ("datetime" + startDate), where startDate is a variable
@@ -165,7 +178,6 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
                 if (!(resolved instanceof PsiVariable)) {
                     continue;
                 }
-
                 // Extract the value of the variable
                 // Resolve means to find the declaration of the variable
                 // Initializer is the value assigned to the variable
@@ -174,7 +186,6 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
                 if (initializer == null) {
                     continue;
                 }
-
                 // Initializer.getText() returns the value of the variable in string format
                 // Create a new expression from the variable value and replace the variable with the value
                 String variableValue = initializer.getText();
@@ -184,7 +195,6 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
                     operands[i] = newExpression;
                 }
             }
-
             // Create a new expression from the operands after replacing the variables with their values
             // Return the new expression if it is not null, else return the original element
             PsiElementFactory factory = JavaPsiFacade.getInstance(element.getProject()).getElementFactory();
@@ -209,16 +219,16 @@ private static Map<String, List<String>> loadRuleConfigurations() {
             final String KQL_ANTI_PATTERN_BETWEEN = "KQL_ANTI_PATTERN_BETWEEN";
 
             try {
-                InputStream inputStream = KustoQueriesWithTimeIntervalInQueryStringCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
+                final InputStream inputStream = KustoQueriesWithTimeIntervalInQueryStringCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
                 if (inputStream == null) {
                     throw new FileNotFoundException("Configuration file not found");
                 }
                 try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
-                    JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
-                    JSONObject kustoCheckObject = jsonObject.getJSONObject("KustoQueriesWithTimeIntervalInQueryStringCheck");
-                    JSONObject regexPatterns = kustoCheckObject.getJSONObject(REGEX_PATTERNS_KEY);
+                    final JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                    final JSONObject kustoCheckObject = jsonObject.getJSONObject("KustoQueriesWithTimeIntervalInQueryStringCheck");
+                    final JSONObject regexPatterns = kustoCheckObject.getJSONObject(REGEX_PATTERNS_KEY);
 
-                    Map<String, List<String>> ruleConfigurations = new HashMap<>();
+                    final Map<String, List<String>> ruleConfigurations = new HashMap<>();
                     ruleConfigurations.put(REGEX_PATTERNS_KEY, Arrays.asList(
                             regexPatterns.getString(KQL_ANTI_PATTERN_AGO),
                             regexPatterns.getString(KQL_ANTI_PATTERN_DATETIME),
@@ -234,7 +244,6 @@ private static Map<String, List<String>> loadRuleConfigurations() {
                 return Collections.emptyMap();
             }
         }
-    };
-
+    }
 }
 

From 09d122230a86f49854fa31cb8523bc82bdf0deea Mon Sep 17 00:00:00 2001
From: Sameeksha Vaity <savaity@microsoft.com>
Date: Mon, 24 Jun 2024 12:25:49 -0700
Subject: [PATCH 019/144] [unblocks the data clearing issue] Reset the
 methodCounts map for each new visitor

Rather than clearing for every interval
---
 .../azure/sdk/buildtool/TelemetryClientProvider.java         | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 2c6bbbd3e4b..28c6d2b65ba 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -40,7 +40,8 @@ public static void setProject(Project project) {
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         Project project = holder.getProject();
         TelemetryClientProvider.setProject(project);
-
+        // Reset the methodCounts map for each new visitor
+        methodCounts.clear();
         return new JavaElementVisitor() {
 
             //  will only track the methods that are being called in the code
@@ -78,8 +79,6 @@ private static void sendTelemetryData() {
             telemetryClient.trackEvent("Method in use " + methodName);
         }
 
-        // Clear the methodCounts map for the next interval
-        methodCounts.clear();
         telemetryClient.flush();
     }
 

From 3adda32ef1f79640d774cca00a70a9d5d3ff8905 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 24 Jun 2024 16:58:35 -0700
Subject: [PATCH 020/144] address PR comments and add tests

---
 .../build.gradle                              |   7 +
 .../azure-intellij-plugin-azure-sdk/readme.md |   7 +-
 .../StorageUploadWithoutLengthCheck.java      | 113 +++++++++-----
 .../StorageUploadWithoutLengthCheckTest.java  | 139 ++++++++++++++++++
 4 files changed, 224 insertions(+), 42 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 7849525a297..7c07ef4fc6e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -11,4 +11,11 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation group: 'org.json', name: 'json', version: '20240303'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
+    testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
+    testImplementation group: 'org.mockito', name: 'mockito-core'
 }
+
+tasks.named('test', Test) {
+    useJUnitPlatform()
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index 25e7c8d5885..ca395475947 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -11,12 +11,9 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 
-## User Interface
-- **Rule Configuration Panel** : This space allows users to toggle rules for customization and disable telemetry if desired.
-
 ## Rules
 1. #### Storage Upload without Length Check
-    Anti-Pattern: Using Azure Storage upload APIs that don’t take a length parameter. As a result, the entire data payload is buffered into memory before uploading.
-    Issue: This approach can lead to OutOfMemoryErrors, especially when dealing with large files or high-volume uploads
+   Anti-Pattern: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+   Issue: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
        ##### Severity: INFO. 
        #### Solution: Use APIs that take a length parameter. [Click here for more details](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java)
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 0cc96f3d36e..409b43792e0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -38,17 +38,25 @@ public String getDisplayName() {
     }
 
     private static final List<String> METHODS_TO_CHECK = getMethodsToCheck();
+    private static final String LENGTH_TYPE = "PsiType:long";
 
+
+    // Get the list of methods to check from the configuration file
     private static List<String> getMethodsToCheck() {
+
+        final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+        final String RULE_NAME = "StorageUploadWithoutLengthCheck";
+        final String METHODS_TO_CHECK = "methodsToCheck";
+
         try {
-            String configFileName = "META-INF/ruleConfigs.json";
-            InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(configFileName);
+//            String configFileName = "META-INF/ruleConfigs.json";
+            InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
             if (inputStream == null) {
                 throw new FileNotFoundException("Configuration file not found");
             }
             try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
                 JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
-                JSONArray methods = jsonObject.getJSONObject("StorageUploadWithoutLengthCheck").getJSONArray("methodsToCheck");
+                JSONArray methods = jsonObject.getJSONObject(RULE_NAME).getJSONArray(METHODS_TO_CHECK);
                 return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
             }
         } catch (Exception e) {
@@ -57,6 +65,13 @@ private static List<String> getMethodsToCheck() {
         }
     }
 
+    /**
+     * This method is used to build a PsiElementVisitor that will be used to visit the method calls in the code.
+     *
+     * @param holder
+     * @param isOnTheFly
+     * @return
+     */
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -67,57 +82,81 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                 super.visitMethodCallExpression(expression);
                 String methodName = expression.getMethodExpression().getReferenceName();
 
-                if (METHODS_TO_CHECK.contains(methodName)) {
-                    boolean hasLengthArg = false;
-
-                    PsiExpressionList argumentList = expression.getArgumentList();
-                    PsiExpression[] arguments = argumentList.getExpressions();
-
-                    for (PsiExpression arg : arguments) {
-                        // Check if the argument is of type 'long'
-                        if (arg.getType().toString().equals("PsiType:long")) {
-                            hasLengthArg = true;
-                            break;
-                        }
-                        if (arg instanceof PsiMethodCallExpression) {
-                            PsiMethodCallExpression argMethodCall = (PsiMethodCallExpression) arg;
-                            PsiExpression qualifier = argMethodCall.getMethodExpression().getQualifierExpression();
-
-                            // Analysing arguments that are chained method calls
-                            hasLengthArg = checkMethodCallChain(argMethodCall);
-                        }
+                if (!METHODS_TO_CHECK.contains(methodName)) {
+                    return;
+                }
+
+                boolean hasLengthArg = false;
+
+                PsiExpressionList argumentList = expression.getArgumentList();
+                PsiExpression[] arguments = argumentList.getExpressions();
+
+                for (PsiExpression arg : arguments) {
+                    // Check if the argument is of type 'long'
+                    if (arg.getType() != null && arg.getType().toString().equals(LENGTH_TYPE)) {
+                        hasLengthArg = true;
+                        break;
                     }
-                    if (!hasLengthArg) {
-                     holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
+                    // Check if the argument is a method call
+                    if (arg instanceof PsiMethodCallExpression) {
+                        PsiMethodCallExpression argMethodCall = (PsiMethodCallExpression) arg;
+
+                        // Analysing arguments that are method calls to check for 'long' type arguments
+                        hasLengthArg = checkMethodCallChain(argMethodCall);
                     }
                 }
+                if (!hasLengthArg) {
+                    holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
+                }
+
             }
         };
-    };
+    }
 
-    // Analysing arguments that are chained method calls
-    private boolean checkMethodCallChain (PsiMethodCallExpression expression) {
+    /**
+     * Analysing arguments that are chained method calls
+     * This method is used to check if the method call chain has a constructor with 'long' type arguments.
+     * The iteration starts from the end of the chain and goes up the chain.
+     * The qualifier of the method call is checked for a constructor with 'long' type arguments.
+     *
+     * @param expression
+     * @return boolean
+     */
+    public boolean checkMethodCallChain(PsiMethodCallExpression expression) {
 
         // Iterating up the chain of method calls
         PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
+
         while (qualifier instanceof PsiMethodCallExpression) {
             PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifier;
-            PsiExpressionList qualifierArgumentList = qualifierMethodCall.getArgumentList();
-            PsiExpression[] qualifierArguments = qualifierArgumentList.getExpressions();
 
             qualifier = qualifierMethodCall.getMethodExpression().getQualifierExpression();
 
             // Checking for constructor with 'long' type arguments
             if (qualifier instanceof PsiNewExpression) {
-                PsiNewExpression newExpression = (PsiNewExpression) qualifier;
-                PsiExpressionList newExpressionArgumentList = newExpression.getArgumentList();
-                PsiExpression[] newExpressionArguments = newExpressionArgumentList.getExpressions();
+                return isLengthArgumentInCall (qualifier);
+            }
+        }
+        return false;
+    }
 
-                for (PsiExpression newExpressionArgument : newExpressionArguments) {
-                    if (newExpressionArgument.getType().toString().equals("PsiType:long")) {
-                        return true;
-                    }
-                }
+    /**
+     * This method is used to check if the constructor of the new expression has a 'long' type argument.
+     *
+     * @param qualifier - The qualifier of the method call
+     * @return boolean
+     */
+    private boolean isLengthArgumentInCall (PsiExpression qualifier) {
+        PsiNewExpression newExpression = (PsiNewExpression) qualifier;
+
+        // Getting the arguments of the constructor
+        PsiExpressionList newExpressionArgumentList = newExpression.getArgumentList();
+        PsiExpression[] newExpressionArguments = newExpressionArgumentList.getExpressions();
+
+        // Checking if the arguments are of type 'long'
+        for (PsiExpression newExpressionArgument : newExpressionArguments) {
+            if (newExpressionArgument.getType().toString().equals(LENGTH_TYPE)) {
+                return true;
             }
         }
         return false;
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
new file mode 100644
index 00000000000..31273cb2057
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
@@ -0,0 +1,139 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaRecursiveElementWalkingVisitor;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiNewExpression;
+import com.intellij.psi.PsiType;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+import org.mockito.Mock;
+
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+
+/**
+ * This class is used to test the StorageUploadWithoutLengthCheck class.
+ * It tests the visitor method to check if the upload methods are being called without a 'length' parameter of type 'long'.
+ *
+ * These are examples of situations where the visitor method should register a problem:
+ * 1. @ServiceMethod(returns = ReturnType.SINGLE)
+ *     public void upload(InputStream data) {
+ *         uploadWithResponse(new BlobParallelUploadOptions(data), null, null);
+ *     }
+ *
+ * 2. uploadWithResponse(new BlobParallelUploadOptions(data).setRequestConditions(blobRequestConditions), null, Context.NONE);
+ *
+ * 3. upload(data, false);
+ */
+
+public class StorageUploadWithoutLengthCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+    private PsiElementVisitor mockVisitor;
+    private PsiElement mockElement;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockElement = mock(PsiElement.class);
+        mockVisitor = createVisitor();
+    }
+
+    /**
+     * assertVisitor(mockVisitor) asserts that it the visitor not null and is an instance of JavaRecursiveElementWalkingVisitor.
+     * verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS) verifies that the registerProblem method is called
+     * when the visitor visits a method call expression with the method name METHOD_TO_CHECK.
+     */
+    @Test
+    public void testStorageUploadWithoutLengthCheck() {
+        assertVisitor(mockVisitor);
+
+        String METHOD_TO_CHECK = "upload";
+        int NUMBER_OF_INVOCATIONS = 1;  // Number of times registerProblem should be called
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS);
+
+    }
+
+    private PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = false;
+
+        // Create an instance of the class under test
+        StorageUploadWithoutLengthCheck check = new StorageUploadWithoutLengthCheck();
+        return check.buildVisitor(mockHolder, isOnTheFly);
+    }
+
+    void assertVisitor(PsiElementVisitor visitor) {
+        assertNotNull(visitor);
+        assertTrue(visitor instanceof JavaRecursiveElementWalkingVisitor);
+    }
+
+    private void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS) {
+
+        // Arrange
+        PsiMethodCallExpression mockExpression = mock(PsiMethodCallExpression.class);
+        PsiExpressionList mockArgList = mock(PsiExpressionList.class);
+
+        PsiExpression mockArgExpression = mock(PsiExpression.class);
+
+        PsiMethodCallExpression mockArgMethodCall = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression mockMethodExpression = mock(PsiReferenceExpression.class);
+        PsiExpression mockQualifier = mock(PsiExpression.class);
+        PsiNewExpression nextMockQualifier = mock(PsiNewExpression.class);
+        PsiType mockType = mock(PsiType.class);
+        PsiMethodCallExpression mockQualifierMethodCall = mock(PsiMethodCallExpression.class);
+
+
+        // Act
+        when(mockExpression.getMethodExpression()).thenReturn(mockMethodExpression);
+        when(mockMethodExpression.getReferenceName()).thenReturn(METHOD_TO_CHECK);
+
+        when(mockExpression.getArgumentList()).thenReturn(mockArgList);
+        when(mockArgList.getExpressions()).thenReturn(new PsiExpression[0]);
+
+        when(mockArgExpression.getType()).thenReturn(mockType);
+        when(mockType.toString()).thenReturn("long");
+
+        when(mockArgMethodCall.getMethodExpression()).thenReturn(mockMethodExpression);
+        when(mockMethodExpression.getQualifierExpression()).thenReturn(mockQualifier);
+
+        when(mockQualifierMethodCall.getMethodExpression()).thenReturn(mockMethodExpression);
+        when(mockMethodExpression.getQualifierExpression()).thenReturn(nextMockQualifier);
+
+        when(nextMockQualifier.getArgumentList()).thenReturn(mockArgList);
+        when(mockArgList.getExpressions()).thenReturn(new PsiExpression[0]);
+
+        when(nextMockQualifier.getType()).thenReturn(mockType);
+        when(mockType.toString()).thenReturn("long");
+
+        ((JavaRecursiveElementWalkingVisitor) visitor).visitMethodCallExpression(mockExpression);
+
+        // Verify registerProblem is called
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(mockExpression), Mockito.contains("Azure Storage upload API without length parameter detected"));
+    }
+
+    /**
+     * Test the visitor method when the method call expression is not in the list of methods to check.
+     * This should not call registerProblem.
+     */
+    @Test
+    public void testMethodCallNotInList() {
+        String METHOD_TO_CHECK = "notInList";
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS);
+    }
+}
+

From 50b7e6d469fbf7483c5bb02ac165c610a07a9455 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 24 Jun 2024 21:36:42 -0700
Subject: [PATCH 021/144] address PR comments

---
 .../build.gradle                              |   8 +-
 .../ServiceBusReceiverAsyncClientCheck.java   |  72 ++++++----
 .../main/resources/META-INF/ruleConfigs.json  |   2 +-
 ...erviceBusReceiverAsyncClientCheckTest.java | 132 ++++++++----------
 4 files changed, 112 insertions(+), 102 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 0bee027496f..7c07ef4fc6e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -11,7 +11,11 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation group: 'org.json', name: 'json', version: '20240303'
-    testImplementation'org.junit.jupiter:junit-jupiter-api:5.8.1'
-    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
+    testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
     testImplementation group: 'org.mockito', name: 'mockito-core'
+}
+
+tasks.named('test', Test) {
+    useJUnitPlatform()
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 5e8d593f059..f14e9eea72d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -22,31 +22,21 @@
 /**
  * This class extends the LocalInspectionTool to check for the use of ServiceBusReceiverAsyncClient
  * in the code and suggests using ServiceBusProcessorClient instead.
+ * The client data is loaded from the configuration file and the client name is checked against the
+ * discouraged client name. If the client name matches, a problem is registered with the suggestion message.
  */
 public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
-    public static final String configFileName = "META-INF/ruleConfigs.json";
+    static final List<String> CLIENT_DATA = getClientToCheck();
 
-    // loading the client data from the configuration file
-    public static List<String> getClientToCheck() {
-        try {
-
-            InputStream inputStream = ServiceBusReceiverAsyncClientCheck.class.getClassLoader().getResourceAsStream(configFileName);
-            if (inputStream == null) {
-                throw new FileNotFoundException("Configuration file not found");
-            }
-            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
-                JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
-                String clientName = jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString("clientName");
-                String suggestedClient = jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString("suggestion");
-                return Arrays.asList(clientName, suggestedClient);
-            }
-        } catch (Exception e) {
-            e.printStackTrace();
-            return Collections.emptyList();
-        }
-    }
 
+    /**
+     * This method builds a visitor to check for the discouraged client name in the code.
+     * If the client name matches the discouraged client, a problem is registered with the suggestion message.
+     * @param holder
+     * @param isOnTheFly
+     * @return PsiElementVisitor
+     */
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -56,23 +46,51 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
             public void visitTypeElement(PsiTypeElement element) {
                 super.visitTypeElement(element);
 
-                // Check if the element is an instance of PsiTypeElement and if the type matches the discouraged client
+                // Check if the element is an instance of PsiTypeElement
                 if (element instanceof PsiTypeElement && element.getType() != null) {
 
-                    List<String> clientData = getClientToCheck();
-                    if (clientData.isEmpty()) {
+                    if (CLIENT_DATA.isEmpty()) {
                         return;
                     }
-                    String clientName = clientData.get(0);
-                    String suggestedClient = clientData.get(1);
+                    String clientName = CLIENT_DATA.get(0);
+                    String suggestion = CLIENT_DATA.get(1);
 
+                    // Register a problem if the client used matches the discouraged client
                     if (element.getType().getPresentableText().equals(clientName)) {
-                        holder.registerProblem(element, "Use of "+clientName+" detected. Use "+suggestedClient+" instead.");
+                        holder.registerProblem(element, suggestion);
                     }
-
                 }
             }
 
         };
     }
+
+    /**
+     * Loading the client data from the configuration file.
+     *
+     * @return List of client name and suggestion message
+     */
+    static List<String> getClientToCheck() {
+
+        // Define constants for string literals
+        final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+        final String SUGGESTION_KEY = "antipattern_message";
+        final String CLIENT_NAME_KEY = "clientName";
+
+        try {
+            final InputStream inputStream = ServiceBusReceiverAsyncClientCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
+            if (inputStream == null) {
+                throw new FileNotFoundException("Configuration file not found");
+            }
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                final JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                final String clientName = jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString(CLIENT_NAME_KEY);
+                final String suggestion= jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString(SUGGESTION_KEY);
+                return Arrays.asList(clientName, suggestion);
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+            return Collections.emptyList();
+        }
+    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 839476f7eac..83ff0edb68c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -1,6 +1,6 @@
 {
   "ServiceBusReceiverAsyncClientCheck": {
     "clientName": "ServiceBusReceiverAsyncClient",
-    "suggestion": "ServiceBusProcessorClient"
+    "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
   }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
index 7095bab2c0e..a6f0ac84bd6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
@@ -1,18 +1,14 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
-
 // Import necessary libraries
-import com.intellij.ide.highlighter.JavaFileType;
-import com.intellij.openapi.fileTypes.FileType;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiElementVisitor;
-import com.intellij.psi.PsiFile;
-import com.intellij.psi.PsiFileFactory;
 import com.intellij.psi.PsiTypeElement;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.PsiType;
-import com.intellij.openapi.project.Project;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
 import org.mockito.Mockito;
 
 import static org.junit.Assert.assertNotNull;
@@ -21,105 +17,97 @@
 import static org.mockito.Mockito.when;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyString;
 
 
+/**
+ * This class tests the ServiceBusReceiverAsyncClientCheck class by mocking the ProblemsHolder and PsiElementVisitor
+ * and verifying that a problem is registered when the ServiceBusReceiverAsyncClient is used.
+ * The test also verifies that a problem is not registered when the PsiElement is null.
+ *
+ * Here are some examples of test data where registerProblem should be called:
+ * 1. ServiceBusReceiverAsyncClient client = new ServiceBusReceiverAsyncClient();
+ * 2.private ServiceBusReceiverAsyncClient receiver;
+ * 3. final ServiceBusReceiverAsyncClient autoCompleteReceiver =
+ *             toClose(getReceiverBuilder(false, entityType, index, false)
+ *                 .buildAsyncClient());
+ */
+
 public class ServiceBusReceiverAsyncClientCheckTest {
 
     // Create a mock ProblemsHolder to be used in the test
+    @Mock
     private ProblemsHolder mockHolder;
 
-    // Create a Java code snippet that uses ServiceBusReceiverAsyncClient with situations that should be flagged
-    private String createJavaCode() {
-        StringBuilder javaCode = new StringBuilder();
-
-        javaCode.append("public class TestClass {\n");
-
-        // Define the client as a private final member
-        javaCode.append("\tprivate final ServiceBusReceiverAsyncClient client;\n");
+    // Create a mock PsiElementVisitor for visiting the PsiTypeElement
+    @Mock
+    private PsiElementVisitor mockVisitor;
 
-        // Create a constructor for TestClass
-        javaCode.append("\tpublic TestClass() {\n");
-        javaCode.append("\t\tthis.client = new ServiceBusReceiverAsyncClient();\n");
-        javaCode.append("\t}\n");
+    // Create a mock PsiTypeElement.
+    @Mock
+    private PsiTypeElement mockTypeElement;
 
-        // Create a getClient method to access the client
-        javaCode.append("\tpublic ServiceBusReceiverAsyncClient getClient() {\n");
-        javaCode.append("\t\treturn this.client;\n");
-        javaCode.append("\t}\n");
 
-        javaCode.append("}");
-
-        return javaCode.toString();
+    @BeforeEach
+    public void setUp() {
+        // Set up the test
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockTypeElement = mock(PsiTypeElement.class);
     }
 
-
     @Test
-    public void testBuildVisitor() {
-        // Arrange
-        String javaCode = createJavaCode();
-        PsiElementVisitor visitor = createVisitor();
-
-        // Mock PsiFileFactory
-        PsiFileFactory psiFileFactory = mockPsiFileFactory();
-
-        // Create PsiFile
-        PsiFile psiFile = createPsiFile(javaCode, psiFileFactory);
-
-        // Accept visitor
-        psiFile.accept(visitor);
-
+    public void testProblemRegisteredWhenUsingServiceBusReceiverAsyncClient() {
         // Assert
-        assertVisitor(visitor);
+        assertVisitor();
 
         // Visit Type Element
-        visitTypeElement(visitor);
+        int NUMBER_OF_INVOCATIONS = 1;  // Number of times registerProblem should be called
+        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS);
     }
 
     // Create a visitor by calling the buildVisitor method of ServiceBusReceiverAsyncClientCheck
     private PsiElementVisitor createVisitor() {
         ServiceBusReceiverAsyncClientCheck check = new ServiceBusReceiverAsyncClientCheck();
-        mockHolder = mock(ProblemsHolder.class);
         boolean isOnTheFly = true;
-
         return check.buildVisitor(mockHolder, isOnTheFly);
     }
 
-    // Mock PsiFileFactory and create a PsiFile to be used in the test
-    private PsiFileFactory mockPsiFileFactory() {
-        Project mockProject = mock(Project.class);
-        PsiFileFactory mockFileFactory = mock(PsiFileFactory.class);
-        when(PsiFileFactory.getInstance(mockProject)).thenReturn(mockFileFactory);
-
-        return PsiFileFactory.getInstance(mockProject);
+    // Assert that the visitor is not null and is an instance of JavaElementVisitor
+    private void assertVisitor() {
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
     }
 
-    // Create a PsiFile from the Java code to simulate the file to be inspected
-    private PsiFile createPsiFile(String javaCode, PsiFileFactory psiFileFactory) {
-        PsiFile mockFile = mock(PsiFile.class);
-        when(psiFileFactory.createFileFromText(anyString(), any(FileType.class), any())).thenReturn(mockFile);
+    /** Visit a Type Element and verify that a problem was registered
+     * when the ServiceBusReceiverAsyncClient is used.
+     * @param typeElement The PsiTypeElement to visit
+     * @param NUMBER_OF_INVOCATIONS The number of times registerProblem should be called
+     */
+    private void visitTypeElement(PsiTypeElement typeElement, int NUMBER_OF_INVOCATIONS) {
 
-        return psiFileFactory.createFileFromText(javaCode, JavaFileType.INSTANCE, javaCode);
-    }
+        PsiType mockType = mock(PsiType.class);
 
+        when(mockTypeElement.getType()).thenReturn(mockType);
+        when(mockType.getPresentableText()).thenReturn("ServiceBusReceiverAsyncClient");
 
-    // Assert that the visitor is not null and is an instance of JavaElementVisitor
-    private void assertVisitor(PsiElementVisitor visitor) {
-        assertNotNull(visitor);
-        assertTrue(visitor instanceof JavaElementVisitor);
+        ((JavaElementVisitor) mockVisitor).visitTypeElement(mockTypeElement);
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains("Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."));
     }
 
-    // Visit a Type Element and verify that a problem was registered
-    private void visitTypeElement(PsiElementVisitor visitor) {
-        PsiType mockType = mock(PsiType.class);
-        when(mockType.getPresentableText()).thenReturn("ServiceBusReceiverAsyncClient");
-
-        PsiTypeElement mockTypeElement = mock(PsiTypeElement.class);
-        when(mockTypeElement.getType()).thenReturn(mockType);
 
-        ((JavaElementVisitor) visitor).visitTypeElement(mockTypeElement);
+    /**
+     * Test that a problem is not registered when the PsiElement is null.
+     *
+     * This test is important because it verifies that the code does not
+     * throw a NullPointerException when the PsiElement is null.
+     */
+    @Test
+    public void testProblemRegisteredWhenPsiElementIsNull() {
+        // Arrange
+        PsiTypeElement nullElement = null;
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
 
-        verify(mockHolder, times(1)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains("Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."));
+        // Act
+        visitTypeElement(nullElement, NUMBER_OF_INVOCATIONS);
     }
 }
\ No newline at end of file

From 6c7efb75821052d01f7c1b278ee695065984e4d2 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 26 Jun 2024 09:47:39 -0700
Subject: [PATCH 022/144] refactor rule & add tests

---
 .../build.gradle                              |   7 +
 .../sdk/buildtool/ConnectionStringCheck.java  |  79 ++++++++--
 .../azure-intellij-plugin-azure-sdk.xml       |   2 +-
 .../main/resources/META-INF/ruleConfigs.json  |   7 +
 .../buildtool/ConnectionStringCheckTest.java  | 135 ++++++++++++++++++
 5 files changed, 220 insertions(+), 10 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..9c1c931578e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,12 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
+    implementation group: 'org.json', name: 'json', version: '20240303'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
+    testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
+    testImplementation group: 'org.mockito', name: 'mockito-core'
+}
 
+tasks.named('test', Test) {
+    useJUnitPlatform()
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
index 2a01b7e472e..3a80b0a26da 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -3,27 +3,88 @@
 import com.intellij.codeInspection.*;
 import com.intellij.psi.*;
 import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
 
 /**
- * This class extends the LocalInspectionTool and checks for the usage of connection strings in the code.
- * Connection strings that start with "DefaultEndpointsProtocol=http;AccountName=" are flagged as problems.
- * This is because the use of such connection strings is not recommended.
+ * This class extends the LocalInspectionTool and checks for the usage of connection strings API to create clients
+ * in the Azure SDK for Java.
+ * If a connection string is found, a warning is displayed.
  */
 public class ConnectionStringCheck extends LocalInspectionTool {
+
+    private static final List <String> ruleConfigurations = loadRuleConfigurations();
+
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         return new JavaElementVisitor() {
+
             @Override
-            public void visitLiteralExpression(PsiLiteralExpression expression) {
-                super.visitLiteralExpression(expression);
+            public void visitElement(@NotNull PsiElement element) {
+                super.visitElement(element);
+
+                String METHOD_TO_CHECK = ruleConfigurations.get(0);
+                String SUGGESTION = ruleConfigurations.get(1);
+
+                // check if an element is an azure client
+                if (element instanceof PsiMethodCallExpression) {
+
+                    // check if the method is a connectionString call
+                    PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) element;
+                    PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
 
-                String value = expression.getValue() instanceof String ? (String) expression.getValue() : null;
+                    // resolvedMethod is the method that is being called
+                    PsiElement resolvedMethod = methodExpression.resolve();
 
-                if (value != null && value.startsWith("DefaultEndpointsProtocol=http;AccountName=")) {
-                    holder.registerProblem(expression, "Use of connection strings is not recommended");
+                    if (resolvedMethod != null && resolvedMethod instanceof PsiElement && ((PsiMethod) resolvedMethod).getName().equals(METHOD_TO_CHECK)) {
+                        PsiMethod method = (PsiMethod) resolvedMethod;
+
+                        // containingClass is the client class that is being called
+                        PsiClass containingClass = method.getContainingClass();
+
+                        // check if the class is an azure client
+                        if (containingClass != null && containingClass.getQualifiedName() != null && containingClass.getQualifiedName().startsWith("com.azure")) {
+                            holder.registerProblem(element, SUGGESTION);
+                        }
+                    }
                 }
             }
         };
+    };
+
+    // Load the rule configurations from the configuration file
+    private static List<String> loadRuleConfigurations() {
+
+        final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+        final String RULE_NAME = "ConnectionStringCheck";
+        final String METHOD_TO_CHECK_KEY = "method_to_check";
+        final String SUGGESTION_KEY = "antipattern_message";
+
+        try {
+            InputStream inputStream = ConnectionStringCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
+            if (inputStream == null) {
+                throw new FileNotFoundException("Configuration file not found");
+            }
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                final JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                JSONObject ruleConfig = jsonObject.getJSONObject(RULE_NAME);
+                String methodToCheck = ruleConfig.getString(METHOD_TO_CHECK_KEY);
+                String antipatternMessage = ruleConfig.getString(SUGGESTION_KEY);
+                return Arrays.asList(methodToCheck, antipatternMessage);
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+            return Collections.emptyList();
+        }
     }
-}
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 413eb6afcef..9a357371109 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -34,7 +34,7 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck">
 
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ClosingCloseableClientsCheck
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck
             </class>
         </localInspection>
     </extensions>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
new file mode 100644
index 00000000000..87f5056b84e
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -0,0 +1,7 @@
+{
+  "ConnectionStringCheck": {
+    "method_to_check": "connectionString",
+    "antipattern_message" : "Connection String detected. Use DefaultAzureCredential for azure service client authentication instead.",
+    "solution": "Do not construct a service client with a connection string unless such connection string is available within the Azure portal or Azure CLI. Use DefaultAzureCredential or other secure methods for client authentication instead."
+  }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
new file mode 100644
index 00000000000..97908bd9ab5
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
@@ -0,0 +1,135 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+
+import com.intellij.psi.PsiMethod;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+
+/**
+ * This class tests the ConnectionStringCheck class.
+ * It tests the buildVisitor method and the visitElement method.
+ * It tests the check for the usage of connection strings API to create clients in the Azure SDK for Java.
+ *
+ * This
+ */
+public class ConnectionStringCheckTest {
+
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private PsiElement mockElement;
+
+    @Mock
+    private PsiElementVisitor mockVisitor;
+
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockElement = mock(PsiElement.class);
+        mockVisitor = createVisitor();
+    }
+
+    PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        ConnectionStringCheck check = new ConnectionStringCheck();
+        return check.buildVisitor(mockHolder, isOnTheFly);
+    }
+
+    /**
+     * This test checks the buildVisitor method.
+     * It checks if the visitor is created and if it is an instance of JavaElementVisitor.
+     * It also verifies that a warning is raised when a connection string being used to create a client is detected.
+     *
+     * This is an example of a passing test.
+     * 1. ServiceBusSenderClient senderClient2 = new ServiceBusClientBuilder().connectionString(connectionString2).sender().queueName("myQueueName2").buildClient();
+     * 2. BlobServiceClient blobServiceClient2 = new BlobServiceClientBuilder().connectionString(connectionString2).buildClient();
+     */
+    @Test
+    void testConnectionStringCheck() {
+
+        assertVisitor(mockVisitor);
+        String METHOD_TO_CHECK = "connectionString";
+        int NUMBER_OF_INVOCATIONS = 1;
+        String CLASS_NAME = "com.azure";
+
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+    }
+
+
+    // Asserts that the visitor is not null and is an instance of JavaElementVisitor
+    void assertVisitor(PsiElementVisitor visitor) {
+        assertNotNull(visitor);
+        assertTrue(visitor instanceof JavaElementVisitor);
+    }
+
+    // Verifies that a warning is raised when a connection string being used to create a client is detected.
+    void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS, String CLASS_NAME) {
+
+        PsiMethodCallExpression methodCallExpression = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
+        PsiMethod resolvedMethod = mock(PsiMethod.class);
+        PsiMethod method = mock(PsiMethod.class);
+        PsiClass containingClass = mock(PsiClass.class);
+
+        when(methodCallExpression.getMethodExpression()).thenReturn(methodExpression);
+        when(methodExpression.resolve()).thenReturn(resolvedMethod);
+        when(resolvedMethod.getContainingClass()).thenReturn(containingClass);
+        when(resolvedMethod.getName()).thenReturn(METHOD_TO_CHECK);
+        when(containingClass.getQualifiedName()).thenReturn(CLASS_NAME);
+
+        (visitor).visitElement(methodCallExpression);
+
+        // Verify problem is registered
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(methodCallExpression), Mockito.contains("Connection String detected. Use AzureKeyCredentials for azure service client authentication instead."));
+    }
+
+
+    // Problem isn't registered because the method to check is different from the method that should be flagged
+    @Test
+    void differentMethodCheck() {
+        String METHOD_TO_CHECK = "differentMethod";
+        int NUMBER_OF_INVOCATIONS = 0;
+        String CLASS_NAME = "com.azure";
+
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+    }
+
+    // Problem isn't registered because the class name is different from the class that should be flagged
+    @Test
+    void differentClassCheck() {
+        String METHOD_TO_CHECK = "connectionString";
+        int NUMBER_OF_INVOCATIONS = 0;
+        String CLASS_NAME = "com.microsoft.azure";
+
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+    }
+
+    // Problem isn't registered because the class name is null
+    @Test
+    void nullClassCheck() {
+        String METHOD_TO_CHECK = "connectionString";
+        int NUMBER_OF_INVOCATIONS = 0;
+        String CLASS_NAME = null;
+
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+    }
+}

From 445bdc61a325943ef538f44adaf5fa107936e137 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 26 Jun 2024 11:13:02 -0700
Subject: [PATCH 023/144] update to tests and README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md | 11 ++--
 ...erviceBusReceiverAsyncClientCheckTest.java | 53 ++++++++++++-------
 2 files changed, 38 insertions(+), 26 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 0a5a5d7c328..191fd3e94f2 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -17,12 +17,9 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 ## Rules
 1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
-The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is discouraged due to its low-level API. 
-This API provides fine-grained control over message handling, making it suitable for scenarios where full control over message processing is required. 
-However, it necessitates a proficiency in Reactive programming and is primarily beneficial when constructing a Reactive library or an end-to-end Reactive application.
-
-As a recommendation, consider using the `ServiceBusProcessorClient` instead of the low-level `ServiceBusReceiverAsyncClient`. 
-The ServiceBusProcessorClient is a higher-level abstraction that simplifies message consumption and is tailored for most common use cases. 
-It should be the primary choice for consuming messages.
+- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
 
+- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
+- **Severity: INFO**
+- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
 Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
index a6f0ac84bd6..ca765b3b5da 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
@@ -60,9 +60,40 @@ public void testProblemRegisteredWhenUsingServiceBusReceiverAsyncClient() {
         // Assert
         assertVisitor();
 
+        String CLIENT_TO_CHECK = "ServiceBusReceiverAsyncClient";
+
         // Visit Type Element
         int NUMBER_OF_INVOCATIONS = 1;  // Number of times registerProblem should be called
-        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS);
+        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS, CLIENT_TO_CHECK);
+    }
+
+    /**
+     * Test that a problem is not registered when the client name is not ServiceBusReceiverAsyncClient.
+     *
+     * This test is important because it verifies that the code does not
+     * register a problem when the client name is not ServiceBusReceiverAsyncClient.
+     */
+
+    @Test
+    void testProblemNotRegisteredWhenCheckingForDiifferentClient() {
+
+        String CLIENT_TO_CHECK = "ServiceBusProcessorClient";
+
+        // Visit Type Element
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
+        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS, CLIENT_TO_CHECK);
+
+    }
+
+    /**
+     * Test that a problem is not registered when the PsiTypeElement is null and the client name is empty.
+     */
+    @Test
+    void testProblemNotRegisteredWhenClientIsEmpty() {
+        // Visit Type Element
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
+        String CLIENT_TO_CHECK = "";
+        visitTypeElement(null, NUMBER_OF_INVOCATIONS, "");
     }
 
     // Create a visitor by calling the buildVisitor method of ServiceBusReceiverAsyncClientCheck
@@ -83,31 +114,15 @@ private void assertVisitor() {
      * @param typeElement The PsiTypeElement to visit
      * @param NUMBER_OF_INVOCATIONS The number of times registerProblem should be called
      */
-    private void visitTypeElement(PsiTypeElement typeElement, int NUMBER_OF_INVOCATIONS) {
+    private void visitTypeElement(PsiTypeElement typeElement, int NUMBER_OF_INVOCATIONS, String CLIENT_TO_CHECK) {
 
         PsiType mockType = mock(PsiType.class);
 
         when(mockTypeElement.getType()).thenReturn(mockType);
-        when(mockType.getPresentableText()).thenReturn("ServiceBusReceiverAsyncClient");
+        when(mockType.getPresentableText()).thenReturn(CLIENT_TO_CHECK);
 
         ((JavaElementVisitor) mockVisitor).visitTypeElement(mockTypeElement);
         verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains("Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."));
     }
 
-
-    /**
-     * Test that a problem is not registered when the PsiElement is null.
-     *
-     * This test is important because it verifies that the code does not
-     * throw a NullPointerException when the PsiElement is null.
-     */
-    @Test
-    public void testProblemRegisteredWhenPsiElementIsNull() {
-        // Arrange
-        PsiTypeElement nullElement = null;
-        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
-
-        // Act
-        visitTypeElement(nullElement, NUMBER_OF_INVOCATIONS);
-    }
 }
\ No newline at end of file

From 2211856ebadae1d648cf7be73185ae745eaa4e75 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 26 Jun 2024 12:11:38 -0700
Subject: [PATCH 024/144] Update README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md    | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 041b63d94aa..5da91ee1739 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -14,16 +14,10 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 ## User Interface
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
 
-
 ## Rules
 1. #### Kusto Queries Having a Time Interval in the Query String
-
-Writing KQL queries with hard-coded time intervals directly in the query string is an anti-pattern. 
-Time intervals include using ago(1d) or between(datetime(2023-01-01), datetime(2023-01-02)). 
-This approach makes queries less flexible and harder to troubleshoot.
-
-Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the time interval for the query. 
-By passing the time range as an argument in the method call, you make it easier to troubleshoot and understand the context of an API call. 
-This approach enhances the flexibility and readability of your Kusto queries.
-
-Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable) for additional information.
\ No newline at end of file
+- **Anti-pattern**: Writing KQL queries with hard-coded time intervals directly in the query string. Time intervals include using ago(1d) or between(datetime(2023-01-01), datetime(2023-01-02)). This approach makes queries less flexible and harder to troubleshoot.
+-**Issue**: Hard-coding time intervals directly in the query string reduces the flexibility of your queries and makes them harder to troubleshoot. It can be difficult to understand the context of an API call when the time interval is embedded within the query string.
+- **Severity**: WARNING. 
+**Recommendation**: Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the time interval for the query.
+Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable) for additional information.

From dc60186dd4d0927a230ae48b46d54d674d34f400 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 26 Jun 2024 12:24:45 -0700
Subject: [PATCH 025/144] minor edits

---
 .../azure-toolkit-for-intellij/.gitignore       | Bin 597 -> 534 bytes
 .../azure-intellij-plugin-azure-sdk/readme.md   |  11 +++++++----
 .../StorageUploadWithoutLengthCheck.java        |   1 -
 .../StorageUploadWithoutLengthCheckTest.java    |   3 +++
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index d09ecb50620244f4c28a0de250cd3fe118974183..8f090d60b2fcf9af90525de4559a7267e099280a 100644
GIT binary patch
literal 534
zcmYjN(P|?x41D)jxa4hN?QbZwlokqwd_d9K>PCrU8%f)w_i*2S+Rc^rWn{^WG&8%M
ze@unCpbLVkRA-4Ulm@wj9$Yx1LIwrbxy=i3j?N9?gkPeK(VmTIwo=-PdhUi3oSfV3
z{C&;bDEqxGnVNk-KW+GKnDJ_u3W!*x%Z8oZ@Yh<obXQt}66|b8Rzh)Y(dedyifOQM
zUXoI)rpHb_G2~(%=B=(XKVwA(#q2+*7=0MxfAU1evhU~=ct+c5&4^b;u24o(S!l8t
zY{@Gm7asQS`^~Kl-WWfzs(*fXy!Rj6&R!1fVzK#5U?GTa)tkB_CiN!0y1PIbA$}$a
z*K_%9Z$fVq__HvMR2561<JikGQymYPs?dDUaRR}}C~e_{5{F?`_5$oP+JTHUSv<e|
iQuUkD)$$KbI`AoOIBIJ}#vvSm*Im!I(=YBO)%^pdsjqhc

literal 597
zcmYjO+iK)649#;O|KMfb0!hB1(6Y2pSeOqeimhfe<FSpbbY}a|Z(k|d+l!CxI!8Vn
z+>?(~Dt7HyQH0V`C$(dSP(V&<UQr-`K-U(|%L*K{plkc_f<LQd*4BQ^Op9U68_2bo
zH^aqB4+r;<0%r>DC~Kf>IVhSlcryriH}DZ^HG^(D6jtxcBK4*tWA+e7<x!A@P;2rk
zN@rdv8ZFI))eGgcan!}%8A3F5%Vz9hw_rjB!QkF0+L*qd{>+%knzce-0bbA+s5{_Y
zkQ2l~sYjaaPO8nlg4gkn$G78t42%6>{J<pc`SIz&y>q_0ddfFFt_uWuqv~>UO7@Ii
zoQg?Z`)#CvFn#zs-mmemztjF5g3pz4pd=V0ore<Fh0<^elqxMJ8D^+BG1k1Y$2#@>
z&hQ1;1=KA8lh>>LC!dnrbZ-~<*I5hjW!m0Ba*lQA$1~_(n7HSC|BI^LC@VJ9ga#XE
Ix~6S@0WC(e%m4rY

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index ca395475947..4685ec00cd8 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -11,9 +11,12 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 
+## User Interface
+- **Telemetry Configuration Panel**: This space allows users to enable or disable telemetry if desired.
+- 
 ## Rules
 1. #### Storage Upload without Length Check
-   Anti-Pattern: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
-   Issue: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
-       ##### Severity: INFO. 
-       #### Solution: Use APIs that take a length parameter. [Click here for more details](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java)
\ No newline at end of file
+- **Anti-Pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
+- **Severity**: INFO. 
+- **Recommendation**: Use APIs that take a length parameter. [Click here for more details](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java)
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 409b43792e0..a577931ad8a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -49,7 +49,6 @@ private static List<String> getMethodsToCheck() {
         final String METHODS_TO_CHECK = "methodsToCheck";
 
         try {
-//            String configFileName = "META-INF/ruleConfigs.json";
             InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
             if (inputStream == null) {
                 throw new FileNotFoundException("Configuration file not found");
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
index 31273cb2057..9d92008e7b0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
@@ -68,6 +68,7 @@ public void testStorageUploadWithoutLengthCheck() {
 
     }
 
+    // Create a visitor for the class under test
     private PsiElementVisitor createVisitor() {
         boolean isOnTheFly = false;
 
@@ -76,11 +77,13 @@ private PsiElementVisitor createVisitor() {
         return check.buildVisitor(mockHolder, isOnTheFly);
     }
 
+    // Assert that the visitor is not null and is an instance of JavaRecursiveElementWalkingVisitor
     void assertVisitor(PsiElementVisitor visitor) {
         assertNotNull(visitor);
         assertTrue(visitor instanceof JavaRecursiveElementWalkingVisitor);
     }
 
+    // Verify that the registerProblem method is called when the visitor visits a method call expression with the method name METHOD_TO_CHECK.
     private void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS) {
 
         // Arrange

From 2fda813cd9225ebae5343cbf077d758436d9cc78 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 27 Jun 2024 14:12:55 -0700
Subject: [PATCH 026/144] implement HardcodedAPIKeysAndTokensCheck rule

---
 .../build.gradle                              |   9 +-
 .../HardcodedAPIKeysAndTokensCheck.java       | 116 +++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  14 ++
 .../main/resources/META-INF/ruleConfigs.json  |   7 +
 .../HardcodedAPIKeysAndTokensCheckTest.java   | 134 ++++++++++++++++++
 5 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..7c07ef4fc6e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,12 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
-
+    implementation group: 'org.json', name: 'json', version: '20240303'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
+    testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
+    testImplementation group: 'org.mockito', name: 'mockito-core'
 }
+
+tasks.named('test', Test) {
+    useJUnitPlatform()
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
new file mode 100644
index 00000000000..054a1c25d45
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
@@ -0,0 +1,116 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiNewExpression;
+import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+
+/**
+ * This class is a custom inspection tool that checks for hardcoded API keys and tokens in the code.
+ * It extends the LocalInspectionTool class and overrides the buildVisitor method to create a visitor for the inspection.
+ * The visitor checks for the use of specific methods that are known to be used for API keys and tokens.
+ * These are AzureKeyCredential and AccessToken.
+ *
+ * These are some instances that a flag would be raised.
+ * 1. TextAnalyticsClient client = new TextAnalyticsClientBuilder()
+ *         .endpoint(endpoint)
+ *         .credential(new AzureKeyCredential(apiKey))
+ *         .buildClient();
+ *
+ * 2. TokenCredential credential = request -> {
+ *         AccessToken token = new AccessToken("<your-hardcoded-token>", OffsetDateTime.now().plusHours(1));
+ *     }
+ */
+public class HardcodedAPIKeysAndTokensCheck extends LocalInspectionTool {
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new APIKeysAndTokensVisitor(holder, isOnTheFly);
+    }
+
+    // This class is a visitor that checks for the use of specific methods that authenticate API keys and tokens.
+    public static class APIKeysAndTokensVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+
+        // Load rule configurations from a JSON file
+        static Map<String, Object> RULE_CONFIGURATIONS = loadRuleConfigurations();
+        static String ANTI_PATTERN_MESSAGE = (String) RULE_CONFIGURATIONS.get("anti_pattern_message");
+        static List<String> CLIENTS_TO_CHECK = (List<String>) RULE_CONFIGURATIONS.get("clients_to_check");
+
+        // This constructor is used to create a visitor for the inspection
+        public APIKeysAndTokensVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
+
+        @Override
+        public void visitElement(@NotNull PsiElement element) {
+            super.visitElement(element);
+
+            // Check if the element is a new expression -- i.e., a constructor call
+            if (element instanceof PsiNewExpression) {
+
+                // Cast the element to a new expression
+                PsiNewExpression newExpression = (PsiNewExpression) element;
+
+                // Get the class reference name from the new expression
+                String classReference = newExpression.getClassReference().getReferenceName();
+
+                // Check if the class reference is not null, the qualifier name starts with "com.azure" and
+                // the class reference is in the list of clients to check
+                if (newExpression.getClassReference() != null
+                        && newExpression.getClassReference().getQualifiedName().startsWith("com.azure")
+                        && CLIENTS_TO_CHECK.contains(classReference)) {
+                    this.holder.registerProblem(newExpression, ANTI_PATTERN_MESSAGE);
+                }
+            }
+        }
+
+
+        // Helper method to load rule configurations from a JSON file
+        private static Map<String, Object> loadRuleConfigurations() {
+
+            // Define constants for string literals
+            final String RULE_KEY = "HardcodedAPIKeysAndTokensCheck";
+            final String ANTI_PATTERN_MESSAGE_KEY = "anti_pattern_message";
+            final String CLIENTS_TO_CHECK_KEY = "clients_to_check";
+            final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+
+            // Load the rule configurations from the JSON file
+            try {
+                final InputStream inputStream = HardcodedAPIKeysAndTokensCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
+                if (inputStream == null) {
+                    throw new FileNotFoundException("Configuration file not found");
+                }
+                // Read the JSON object from the input stream
+                try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                    final JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                    final JSONObject apiKeysAndTokensObject = jsonObject.getJSONObject(RULE_KEY);
+                    final String antiPatternMessage = apiKeysAndTokensObject.getString(ANTI_PATTERN_MESSAGE_KEY);
+                    final List<String> clientsToCheck = apiKeysAndTokensObject.getJSONArray(CLIENTS_TO_CHECK_KEY).toList().stream().map(Object::toString).collect(Collectors.toList());
+                    return Map.of(ANTI_PATTERN_MESSAGE_KEY, antiPatternMessage, CLIENTS_TO_CHECK_KEY, clientsToCheck);
+                }
+            } catch (Exception e) {
+                e.printStackTrace();
+                return Collections.emptyMap();
+            }
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..d968bc36648 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,19 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="HardcodedAPIKeysAndTokensCheck"
+                displayName="Hardcoded API Keys And Tokens Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
new file mode 100644
index 00000000000..a1476b999ce
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -0,0 +1,7 @@
+{
+  "HardcodedAPIKeysAndTokensCheck": {
+    "clients_to_check": ["AzureKeyCredential", "AccessToken"],
+    "anti_pattern_message": "Use of API keys or tokens in code is not recommended. We recommend Secretless authentication through DefaultAzureCredential.",
+    "solution": "We recommend Secretless authentication through DefaultAzureCredential."
+  }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
new file mode 100644
index 00000000000..5ded4a9981e
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
@@ -0,0 +1,134 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck.APIKeysAndTokensVisitor;
+
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiJavaCodeReferenceElement;
+import com.intellij.psi.PsiNewExpression;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElementVisitor;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test the HardcodedAPIKeysAndTokensCheck class for hardcoded API keys and tokens.
+ * When a client is authenticated with AzurekeyCredentials and AccessToken, a problem is registered.
+ These are some instances that a flag would be raised.
+ * 1. TextAnalyticsClient client = new TextAnalyticsClientBuilder()
+ *         .endpoint(endpoint)
+ *         .credential(new AzureKeyCredential(apiKey))
+ *         .buildClient();
+ *
+ * 2. TokenCredential credential = request -> {
+ *         AccessToken token = new AccessToken("<your-hardcoded-token>", OffsetDateTime.now().plusHours(1));
+ *     }
+ */
+public class HardcodedAPIKeysAndTokensCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private PsiElementVisitor mockVisitor;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+    }
+
+
+    /**
+     * Test the HardcodedAPIKeysAndTokensCheck class for hardcoded API keys and tokens.
+     * When a client is authenticated with AzurekeyCredentials and AccessToken, a problem is registered.
+     */
+    @Test
+    public void testHardcodedAPIKeysAndTokensCheck() {
+
+        // assert visitor
+        assertVisitor(mockVisitor);
+
+        int NUMBER_OF_INVOCATIONS = 1; // number of times registerProblem is called
+
+        String CLIENT_TO_CHECK_ONE = "AccessToken";
+        verifyRegisterProblem(CLIENT_TO_CHECK_ONE, NUMBER_OF_INVOCATIONS);
+
+        String CLIENT_TO_CHECK_TWO = "AzureKeyCredential";
+        verifyRegisterProblem(CLIENT_TO_CHECK_TWO, NUMBER_OF_INVOCATIONS);
+    }
+
+    /**
+     * Test for non-auth client use.
+     * These are other Azure clients that are not AzureKeyCredential or AccessToken.
+     */
+    @Test
+    public void testNonAuthAzureClientUse() {
+
+        // assert visitor
+        assertVisitor(mockVisitor);
+
+        String CLIENT_TO_CHECK = "SomeOtherClient";
+        int NUMBER_OF_INVOCATIONS = 0;
+        verifyRegisterProblem(CLIENT_TO_CHECK, NUMBER_OF_INVOCATIONS);
+    }
+
+    /**
+     * Test for null class reference.
+     */
+    @Test
+    public void testNullClassReference() {
+
+        // assert visitor
+        assertVisitor(mockVisitor);
+
+        String CLIENT_TO_CHECK = ""; // null class reference
+        int NUMBER_OF_INVOCATIONS = 0;
+        verifyRegisterProblem(CLIENT_TO_CHECK, NUMBER_OF_INVOCATIONS);
+    }
+
+
+    // Helper method to create visitor.
+    PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        APIKeysAndTokensVisitor visitor = new HardcodedAPIKeysAndTokensCheck.APIKeysAndTokensVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
+
+
+    // Helper method to assert visitor is not null and is an instance of JavaElementVisitor
+    void assertVisitor(PsiElementVisitor mockVisitor) {
+
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    }
+
+    // Helper method to verify registerProblem is called
+    void verifyRegisterProblem(String CLIENT_TO_CHECK, int NUMBER_OF_INVOCATIONS) {
+
+        PsiNewExpression newExpression = mock(PsiNewExpression.class);
+        PsiJavaCodeReferenceElement javaCodeReferenceElement = mock(PsiJavaCodeReferenceElement.class);
+
+        when(newExpression.getClassReference()).thenReturn(javaCodeReferenceElement);
+        when(javaCodeReferenceElement.getReferenceName()).thenReturn(CLIENT_TO_CHECK);
+
+        when(javaCodeReferenceElement.getQualifiedName()).thenReturn("com.azure");
+
+        mockVisitor.visitElement(newExpression);
+
+        // Verify registerProblem is called
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(eq(newExpression),
+                Mockito.contains("Use of API keys or tokens in code is not recommended. " +
+                        "We recommend Secretless authentication through DefaultAzureCredential"));
+    }
+}

From d6f13cc1cbdeef43a89312b59059e4fc38391dcd Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 30 Jun 2024 12:29:38 -0700
Subject: [PATCH 027/144] integrate central json loader engine

---
 .../sdk/buildtool/LoadJsonConfigFile.java     | 63 +++++++++++++++++++
 .../ServiceBusReceiverAsyncClientCheck.java   | 55 +++++++---------
 .../StorageUploadWithoutLengthCheck.java      | 49 +++++++--------
 .../main/resources/META-INF/ruleConfigs.json  |  3 +-
 4 files changed, 110 insertions(+), 60 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
new file mode 100644
index 00000000000..3f4ca0d3c1b
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -0,0 +1,63 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.stream.Collectors;
+import org.json.JSONObject;
+
+/**
+ * This class is used to load a JSON configuration file and provide access to the loaded JSON object.
+ * The constructor is private, so it can't be called from outside the class.
+ * The getInstance method returns the single instance of the class, creating it if it doesn't exist.
+ * The loadJsonObject method is called in the constructor, so it only runs once when the instance is created.
+ * The getJsonObject method returns the loaded JSON object.
+ * To use this class, you would call LoadJsonConfigFile.getInstance().getJsonObject().
+ * This ensures that the JSON object is only loaded once, no matter how many times or from where getJsonObject is called.
+ * */
+public class LoadJsonConfigFile {
+
+    // The instance variable holds the single instance of the class
+    private static LoadJsonConfigFile instance;
+    private JSONObject jsonObject;
+
+    final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
+
+    // The constructor is private, so it can't be called from outside the class
+    private LoadJsonConfigFile() throws IOException {
+        loadJsonObject();
+    }
+
+    // The getInstance method returns the single instance of the class, creating it if it doesn't exist
+    public static synchronized LoadJsonConfigFile getInstance() throws IOException {
+        if (instance == null) {
+            instance = new LoadJsonConfigFile();
+        }
+        return instance;
+    }
+
+    // Load the JSON object from the configuration file
+    private void loadJsonObject() throws IOException {
+
+        try (InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
+            if (inputStream == null) {
+                throw new FileNotFoundException("Configuration file not found");
+            }
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+            }
+        } catch (Exception e) {
+            // Log the error message
+            System.err.println("Error loading JSON configuration: " + e.getMessage());
+            // Rethrow the exception
+            throw e;
+        }
+    }
+
+    // The getJsonObject method returns the loaded JSON object
+    public JSONObject getJsonObject() {
+        return jsonObject;
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 221d50b14ee..3c03a099917 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -8,16 +8,11 @@
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
 
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.io.BufferedReader;
-import java.io.FileNotFoundException;
+import java.io.IOException;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.List;
-import java.util.stream.Collectors;
-
-
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 /**
  * This class extends the LocalInspectionTool to check for the use of ServiceBusReceiverAsyncClient
@@ -27,7 +22,22 @@
  */
 public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
-    static final List<String> CLIENT_DATA = getClientToCheck();
+    private static List<String> CLIENT_DATA = null;
+
+    // Define constants for string literals
+    private static final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+    private static final String RULE_NAME = "ServiceBusReceiverAsyncClientCheck";
+    private static final String SUGGESTION_KEY = "antipattern_message";
+    private static final String CLIENT_NAME_KEY = "client_name";
+    private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
+
+    static {
+        try {
+            CLIENT_DATA = getClientToCheck();
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "Error loading client data", e);
+        }
+    }
 
 
     /**
@@ -46,8 +56,6 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
             public void visitTypeElement(PsiTypeElement element) {
                 super.visitTypeElement(element);
 
-                System.out.println("CLIENT_DATA: " + CLIENT_DATA);
-
                 // Check if the element is an instance of PsiTypeElement
                 if (element instanceof PsiTypeElement && element.getType() != null) {
 
@@ -72,27 +80,12 @@ public void visitTypeElement(PsiTypeElement element) {
      *
      * @return List of client name and suggestion message
      */
-    static List<String> getClientToCheck() {
+    static List<String> getClientToCheck() throws IOException {
 
-        // Define constants for string literals
-        final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
-        final String SUGGESTION_KEY = "antipattern_message";
-        final String CLIENT_NAME_KEY = "client_name";
+        final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+        final String clientName = jsonObject.getJSONObject(RULE_NAME).getString(CLIENT_NAME_KEY);
+        final String suggestion= jsonObject.getJSONObject(RULE_NAME).getString(SUGGESTION_KEY);
+        return Arrays.asList(clientName, suggestion);
 
-        try {
-            final InputStream inputStream = ServiceBusReceiverAsyncClientCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
-            if (inputStream == null) {
-                throw new FileNotFoundException("Configuration file not found");
-            }
-            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
-                final JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
-                final String clientName = jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString(CLIENT_NAME_KEY);
-                final String suggestion= jsonObject.getJSONObject("ServiceBusReceiverAsyncClientCheck").getString(SUGGESTION_KEY);
-                return Arrays.asList(clientName, suggestion);
-            }
-        } catch (Exception e) {
-            e.printStackTrace();
-            return Collections.emptyList();
-        }
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 8da37838e54..5233ac098cf 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -13,12 +13,10 @@
 import org.jetbrains.annotations.Nls;
 import org.jetbrains.annotations.NotNull;
 
-import java.io.BufferedReader;
-import java.io.FileNotFoundException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.util.Collections;
+import java.io.IOException;
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 import java.util.stream.Collectors;
 
 
@@ -37,35 +35,30 @@ public String getDisplayName() {
         return "Ensure Storage APIs use Length Parameter";
     }
 
-    private static final List<String> METHODS_TO_CHECK = getMethodsToCheck();
-    private static final String LENGTH_TYPE = "PsiType:long";
+    private static List<String> METHODS_TO_CHECK_LIST;
+    private static final String RULE_NAME = "StorageUploadWithoutLengthCheck";
+    private static final String METHODS_TO_CHECK_KEY = "methods_to_check";
+    private static final String LENGTH_TYPE = "long";
+    private static final Logger LOGGER = Logger.getLogger(StorageUploadWithoutLengthCheck.class.getName());
 
 
-    // Get the list of methods to check from the configuration file
-    private static List<String> getMethodsToCheck() {
-
-        System.out.println("METHODS_TO_CHECK: " + METHODS_TO_CHECK);
-
-        final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
-        final String RULE_NAME = "StorageUploadWithoutLengthCheck";
-        final String METHODS_TO_CHECK = "methods_to_check";
 
+    static {
         try {
-            InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
-            if (inputStream == null) {
-                throw new FileNotFoundException("Configuration file not found");
-            }
-            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
-                JSONObject jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
-                JSONArray methods = jsonObject.getJSONObject(RULE_NAME).getJSONArray(METHODS_TO_CHECK);
-                return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
-            }
-        } catch (Exception e) {
-            e.printStackTrace();
-            return Collections.emptyList();
+            METHODS_TO_CHECK_LIST = getMethodsToCheck();
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "Error loading methods to check", e);
         }
     }
 
+    // Get the list of methods to check from the configuration file
+    private static List<String> getMethodsToCheck() throws IOException {
+
+        JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+        JSONArray methods = jsonObject.getJSONObject(RULE_NAME).getJSONArray(METHODS_TO_CHECK_KEY);
+        return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
+    }
+
     /**
      * This method is used to build a PsiElementVisitor that will be used to visit the method calls in the code.
      *
@@ -83,7 +76,7 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                 super.visitMethodCallExpression(expression);
                 String methodName = expression.getMethodExpression().getReferenceName();
 
-                if (!METHODS_TO_CHECK.contains(methodName)) {
+                if (!METHODS_TO_CHECK_LIST.contains(methodName)) {
                     return;
                 }
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 2fe624f1650..d0361d1b107 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -3,7 +3,8 @@
     "methods_to_check": [
       "upload",
       "uploadWithResponse"
-    ]
+    ],
+    "antipattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
   },
 
   "ServiceBusReceiverAsyncClientCheck": {

From ecea9e1549dc0400475e142268f7d680489390a1 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 30 Jun 2024 14:51:23 -0700
Subject: [PATCH 028/144] using block on async clients implementation

---
 .../UseOfBlockOnAsyncClientsCheck.java        | 118 ++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  14 +++
 2 files changed, 132 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
new file mode 100644
index 00000000000..ce47c5ec518
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -0,0 +1,118 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+
+import com.intellij.psi.PsiType;
+import com.intellij.psi.util.PsiTreeUtil;
+import org.jetbrains.annotations.NotNull;
+
+
+/**
+ * Inspection to check for the use of block() method on async clients in Azure SDK.
+ * This inspection will check for the use of block() method on reactive types like Mono, Flux, etc.
+ */
+public class UseOfBlockOnAsyncClientsCheck extends LocalInspectionTool {
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new UseOfBlockOnAsyncClientsVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * Visitor to check for the use of block() method on async clients in Azure SDK.
+     */
+    public static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+
+        public UseOfBlockOnAsyncClientsVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
+
+        /**
+         * Visit method call expressions to check for the use of block() method on async clients.
+         * This method will check if the method call is block() and if it is used in an async context.
+         * @param expression
+         */
+        @Override
+        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+            super.visitMethodCallExpression(expression);
+
+            // Check if the element is a method call expression
+            if (expression instanceof PsiMethodCallExpression) {
+                PsiMethodCallExpression methodCall = expression;
+
+                System.out.println("methodCall.getMethodExpression().getReferenceName()): " + methodCall.getMethodExpression().getReferenceName());
+
+                // Check if the method call is block()
+                if (methodCall.getMethodExpression().getReferenceName().startsWith("block")) {
+                    boolean isAsyncContext = checkIfAsyncContext(methodCall);
+                    if (isAsyncContext && isAzureClient(methodCall)) {
+                        holder.registerProblem(expression, "Using block() method in an async client can lead to performance issues.");
+                    } else {
+                        holder.registerProblem(expression, "Consider using a synchronous client instead of block().");
+                    }
+                }
+            }
+        }
+
+        /**
+         * Helper method to check if the method call is within an async context.
+         * This method will check if the method call is on a reactive type like Mono, Flux, etc.
+         * @param methodCall
+         * @return true if the method call is on a reactive type, false otherwise
+         */
+        private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
+            PsiExpression expression = methodCall.getMethodExpression().getQualifierExpression();
+            System.out.println("Expression: " + expression);
+
+            if (expression != null) {
+                PsiType type = expression.getType();
+                System.out.println("Type: " + type);
+
+                if (type != null) {
+                    String typeName = type.getCanonicalText();
+                    System.out.println("TypeName: " + typeName);
+
+                    // Check for common async/reactive types directly
+                    return typeName.startsWith("reactor.core.publisher.Mono") ||
+                        typeName.startsWith("reactor.core.publisher.Flux") ||
+                        typeName.startsWith("com.azure.core.util.paging.PagedFlux") ||
+                        typeName.startsWith("com.azure.core.util.polling.PollerFlux");
+                }
+            }
+            return false;
+        }
+
+        /**
+         * Helper method to check if the method call is on an Azure SDK client.
+         * This method will check if the method call is on a class that is part of the Azure SDK.
+         * @param methodCall
+         * @return true if the method call is on an Azure SDK client, false otherwise
+         */
+        private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
+            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
+            System.out.println("ContainingClass: " + containingClass);
+
+            if (containingClass != null) {
+                String className = containingClass.getQualifiedName();
+                System.out.println("ClassName: " + className);
+
+                // Check if the class is part of the Azure SDK
+                if (className != null && className.startsWith("com.azure.")) {
+                    return true;
+                }
+            }
+            return false;
+        }
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index fd1f041cf1b..9f2bce28616 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -23,5 +23,19 @@
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection">
             <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="UseOfBlockOnAsyncClientsCheck"
+                displayName="Use Of Block On Async Clients Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseOfBlockOnAsyncClientsCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseOfBlockOnAsyncClientsCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From e1821f3016b4308ba3b72e9c88f8ba3f3c701231 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 30 Jun 2024 17:21:40 -0700
Subject: [PATCH 029/144] using block on async clients rule implementation &
 testing

---
 .../azure-toolkit-for-intellij/.gitignore     |   6 +
 .../.idea/gradle.xml                          |   5 +-
 .../azure-intellij-plugin-azure-sdk/README.md |  10 +
 .../build.gradle                              |   9 +-
 .../sdk/buildtool/LoadJsonConfigFile.java     |  65 +++++++
 .../ServiceBusReceiverAsyncClientCheck.java   |  91 +++++++++
 .../StorageUploadWithoutLengthCheck.java      | 158 ++++++++++++++++
 .../UseOfBlockOnAsyncClientsCheck.java        |  81 ++++++--
 .../main/resources/META-INF/ruleConfigs.json  |  24 +++
 ...erviceBusReceiverAsyncClientCheckTest.java | 128 +++++++++++++
 .../StorageUploadWithoutLengthCheckTest.java  | 142 ++++++++++++++
 .../UseOfBlockOnAsyncClientsCheckTest.java    | 175 ++++++++++++++++++
 12 files changed, 874 insertions(+), 20 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 6691dbbf974..e297894a61e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -44,3 +44,9 @@ gen-external-apklibs/
 
 # Jar dependencies generated in build
 **/resources/spark/spark-tools-*.jar
+
+#.idea
+/azure-intellij-plugin-azure-sdk/.idea/
+
+# IntelliJ
+.idea/
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
index 0e2731864ba..498939a6530 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
@@ -4,9 +4,9 @@
   <component name="GradleSettings">
     <option name="linkedExternalProjectsSettings">
       <GradleProjectSettings>
+        <option name="testRunner" value="PLATFORM" />
         <option name="distributionType" value="WRAPPED" />
         <option name="externalProjectPath" value="$PROJECT_DIR$" />
-        <option name="gradleHome" value="$USER_HOME$/Tools/gradle-7.1.1-all/gradle-7.1.1" />
         <option name="modules">
           <set>
             <option value="$PROJECT_DIR$" />
@@ -14,6 +14,7 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-arm" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-azure-sdk" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-bicep" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-cognitiveservices" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-containerapps" />
@@ -28,11 +29,13 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-base" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-lib" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-integration-services" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-keyvault" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-monitor" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-redis" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-samples" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-service-explorer" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-servicebus" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-sparkoncosmos" />
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3cd55989065..191fd3e94f2 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -13,3 +13,13 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 ## User Interface
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
+
+
+## Rules
+1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
+
+- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
+- **Severity: INFO**
+- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 66d77731651..7c07ef4fc6e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -10,5 +10,12 @@ dependencies {
     implementation 'com.microsoft.azure:azure-toolkit-common-lib'
     implementation 'com.microsoft.azure:azure-toolkit-ide-common-lib'
     aspect 'com.microsoft.azure:azure-toolkit-common-lib'
-
+    implementation group: 'org.json', name: 'json', version: '20240303'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
+    testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
+    testImplementation group: 'org.mockito', name: 'mockito-core'
 }
+
+tasks.named('test', Test) {
+    useJUnitPlatform()
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
new file mode 100644
index 00000000000..cddb05bcf7b
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -0,0 +1,65 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import java.io.BufferedReader;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.stream.Collectors;
+import org.json.JSONObject;
+
+/**
+ * This class is used to load a JSON configuration file and provide access to the loaded JSON object.
+ * The constructor is private, so it can't be called from outside the class.
+ * The getInstance method returns the single instance of the class, creating it if it doesn't exist.
+ * The loadJsonObject method is called in the constructor, so it only runs once when the instance is created.
+ * The getJsonObject method returns the loaded JSON object.
+ * To use this class, you would call LoadJsonConfigFile.getInstance().getJsonObject().
+ * This ensures that the JSON object is only loaded once, no matter how many times or from where getJsonObject is called.
+ * */
+public class LoadJsonConfigFile {
+
+    // The instance variable holds the single instance of the class
+    private static LoadJsonConfigFile instance;
+    private JSONObject jsonObject;
+
+    final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
+
+    // The constructor is private, so it can't be called from outside the class
+    private LoadJsonConfigFile() throws IOException {
+        loadJsonObject();
+    }
+
+    // The getInstance method returns the single instance of the class, creating it if it doesn't exist
+    public static synchronized LoadJsonConfigFile getInstance() throws IOException {
+        if (instance == null) {
+            instance = new LoadJsonConfigFile();
+        }
+        return instance;
+    }
+
+    // Load the JSON object from the configuration file
+    private void loadJsonObject() throws IOException {
+
+        System.out.println("Start loading JSON configuration");
+
+        try (InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
+            if (inputStream == null) {
+                throw new FileNotFoundException("Configuration file not found");
+            }
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
+                jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+            }
+        } catch (Exception e) {
+            // Log the error message
+            System.err.println("Error loading JSON configuration: " + e.getMessage());
+            // Rethrow the exception
+            throw e;
+        }
+    }
+
+    // The getJsonObject method returns the loaded JSON object
+    public JSONObject getJsonObject() {
+        return jsonObject;
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
new file mode 100644
index 00000000000..3c03a099917
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -0,0 +1,91 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiTypeElement;
+import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+/**
+ * This class extends the LocalInspectionTool to check for the use of ServiceBusReceiverAsyncClient
+ * in the code and suggests using ServiceBusProcessorClient instead.
+ * The client data is loaded from the configuration file and the client name is checked against the
+ * discouraged client name. If the client name matches, a problem is registered with the suggestion message.
+ */
+public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
+
+    private static List<String> CLIENT_DATA = null;
+
+    // Define constants for string literals
+    private static final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
+    private static final String RULE_NAME = "ServiceBusReceiverAsyncClientCheck";
+    private static final String SUGGESTION_KEY = "antipattern_message";
+    private static final String CLIENT_NAME_KEY = "client_name";
+    private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
+
+    static {
+        try {
+            CLIENT_DATA = getClientToCheck();
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "Error loading client data", e);
+        }
+    }
+
+
+    /**
+     * This method builds a visitor to check for the discouraged client name in the code.
+     * If the client name matches the discouraged client, a problem is registered with the suggestion message.
+     * @param holder
+     * @param isOnTheFly
+     * @return PsiElementVisitor
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new JavaElementVisitor() {
+
+            @Override
+            public void visitTypeElement(PsiTypeElement element) {
+                super.visitTypeElement(element);
+
+                // Check if the element is an instance of PsiTypeElement
+                if (element instanceof PsiTypeElement && element.getType() != null) {
+
+                    if (CLIENT_DATA.isEmpty()) {
+                        return;
+                    }
+                    String clientName = CLIENT_DATA.get(0);
+                    String suggestion = CLIENT_DATA.get(1);
+
+                    // Register a problem if the client used matches the discouraged client
+                    if (element.getType().getPresentableText().equals(clientName)) {
+                        holder.registerProblem(element, suggestion);
+                    }
+                }
+            }
+
+        };
+    }
+
+    /**
+     * Loading the client data from the configuration file.
+     *
+     * @return List of client name and suggestion message
+     */
+    static List<String> getClientToCheck() throws IOException {
+
+        final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+        final String clientName = jsonObject.getJSONObject(RULE_NAME).getString(CLIENT_NAME_KEY);
+        final String suggestion= jsonObject.getJSONObject(RULE_NAME).getString(SUGGESTION_KEY);
+        return Arrays.asList(clientName, suggestion);
+
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
new file mode 100644
index 00000000000..5233ac098cf
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -0,0 +1,158 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaRecursiveElementWalkingVisitor;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiNewExpression;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.NotNull;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import java.util.stream.Collectors;
+
+
+/**
+ * This class extends the LocalInspectionTool and is used to inspect the usage of Azure Storage upload APIs in the code.
+ * It checks if the upload methods are being called without a 'length' parameter of type 'long'.
+ * The methods to check are defined in a JSON configuration file.
+ * If such a method call is detected, a problem is registered with the ProblemsHolder.
+ */
+
+public class StorageUploadWithoutLengthCheck extends LocalInspectionTool {
+    @Nls
+    @NotNull
+    @Override
+    public String getDisplayName() {
+        return "Ensure Storage APIs use Length Parameter";
+    }
+
+    private static List<String> METHODS_TO_CHECK_LIST;
+    private static final String RULE_NAME = "StorageUploadWithoutLengthCheck";
+    private static final String METHODS_TO_CHECK_KEY = "methods_to_check";
+    private static final String LENGTH_TYPE = "long";
+    private static final Logger LOGGER = Logger.getLogger(StorageUploadWithoutLengthCheck.class.getName());
+
+
+
+    static {
+        try {
+            METHODS_TO_CHECK_LIST = getMethodsToCheck();
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "Error loading methods to check", e);
+        }
+    }
+
+    // Get the list of methods to check from the configuration file
+    private static List<String> getMethodsToCheck() throws IOException {
+
+        JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+        JSONArray methods = jsonObject.getJSONObject(RULE_NAME).getJSONArray(METHODS_TO_CHECK_KEY);
+        return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
+    }
+
+    /**
+     * This method is used to build a PsiElementVisitor that will be used to visit the method calls in the code.
+     *
+     * @param holder
+     * @param isOnTheFly
+     * @return
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new JavaRecursiveElementWalkingVisitor() {
+
+            @Override
+            public void visitMethodCallExpression(PsiMethodCallExpression expression) {
+                super.visitMethodCallExpression(expression);
+                String methodName = expression.getMethodExpression().getReferenceName();
+
+                if (!METHODS_TO_CHECK_LIST.contains(methodName)) {
+                    return;
+                }
+
+                boolean hasLengthArg = false;
+
+                PsiExpressionList argumentList = expression.getArgumentList();
+                PsiExpression[] arguments = argumentList.getExpressions();
+
+                for (PsiExpression arg : arguments) {
+                    // Check if the argument is of type 'long'
+                    if (arg.getType() != null && arg.getType().toString().equals(LENGTH_TYPE)) {
+                        hasLengthArg = true;
+                        break;
+                    }
+                    // Check if the argument is a method call
+                    if (arg instanceof PsiMethodCallExpression) {
+                        PsiMethodCallExpression argMethodCall = (PsiMethodCallExpression) arg;
+
+                        // Analysing arguments that are method calls to check for 'long' type arguments
+                        hasLengthArg = checkMethodCallChain(argMethodCall);
+                    }
+                }
+                if (!hasLengthArg) {
+                    holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
+                }
+
+            }
+        };
+    }
+
+    /**
+     * Analysing arguments that are chained method calls
+     * This method is used to check if the method call chain has a constructor with 'long' type arguments.
+     * The iteration starts from the end of the chain and goes up the chain.
+     * The qualifier of the method call is checked for a constructor with 'long' type arguments.
+     *
+     * @param expression
+     * @return boolean
+     */
+    public boolean checkMethodCallChain(PsiMethodCallExpression expression) {
+
+        // Iterating up the chain of method calls
+        PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
+
+        while (qualifier instanceof PsiMethodCallExpression) {
+            PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifier;
+
+            qualifier = qualifierMethodCall.getMethodExpression().getQualifierExpression();
+
+            // Checking for constructor with 'long' type arguments
+            if (qualifier instanceof PsiNewExpression) {
+                return isLengthArgumentInCall (qualifier);
+            }
+        }
+        return false;
+    }
+
+    /**
+     * This method is used to check if the constructor of the new expression has a 'long' type argument.
+     *
+     * @param qualifier - The qualifier of the method call
+     * @return boolean
+     */
+    private boolean isLengthArgumentInCall (PsiExpression qualifier) {
+        PsiNewExpression newExpression = (PsiNewExpression) qualifier;
+
+        // Getting the arguments of the constructor
+        PsiExpressionList newExpressionArgumentList = newExpression.getArgumentList();
+        PsiExpression[] newExpressionArguments = newExpressionArgumentList.getExpressions();
+
+        // Checking if the arguments are of type 'long'
+        for (PsiExpression newExpressionArgument : newExpressionArguments) {
+            if (newExpressionArgument.getType().toString().equals(LENGTH_TYPE)) {
+                return true;
+            }
+        }
+        return false;
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
index ce47c5ec518..1d5a664817d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -4,13 +4,18 @@
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiClass;
-import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiMethodCallExpression;
 
 import com.intellij.psi.PsiType;
 import com.intellij.psi.util.PsiTreeUtil;
 import org.jetbrains.annotations.NotNull;
+import org.json.JSONArray;
+import org.json.JSONObject;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
 
 
 /**
@@ -21,7 +26,7 @@ public class UseOfBlockOnAsyncClientsCheck extends LocalInspectionTool {
 
     @NotNull
     @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+    public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         return new UseOfBlockOnAsyncClientsVisitor(holder, isOnTheFly);
     }
 
@@ -33,6 +38,34 @@ public static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
         private final boolean isOnTheFly;
 
+        private static final String RULE_NAME = "UseOfBlockOnAsyncClientsCheck";
+        private static final Map<String, Object> RULE_CONFIGS_MAP;
+
+        private static final String ANTI_PATTERN_MESSAGE_KEY = "antipattern_message";
+        private static final String ASYNC_RETURN_TYPES_KEY = "async_return_types_to_check";
+        private static final List<String> ASYNC_RETURN_TYPES;
+        static final String ANTI_PATTERN_MESSAGE;
+
+        // Load the config file
+        static {
+            try {
+                RULE_CONFIGS_MAP = getAsyncReturnTypesToCheck();
+
+                // extract the async return types to check
+                ASYNC_RETURN_TYPES = (List<String>) RULE_CONFIGS_MAP.get(ASYNC_RETURN_TYPES_KEY);
+
+                ANTI_PATTERN_MESSAGE = (String) RULE_CONFIGS_MAP.get(ANTI_PATTERN_MESSAGE_KEY);
+
+            } catch (IOException e) {
+                throw new RuntimeException("Error loading config file", e);
+            }
+        }
+
+        /**
+         * Constructor to initialize the visitor with the holder and isOnTheFly flag.
+         * @param holder ProblemsHolder
+         * @param isOnTheFly boolean
+         */
         public UseOfBlockOnAsyncClientsVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
             this.isOnTheFly = isOnTheFly;
@@ -51,15 +84,13 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
             if (expression instanceof PsiMethodCallExpression) {
                 PsiMethodCallExpression methodCall = expression;
 
-                System.out.println("methodCall.getMethodExpression().getReferenceName()): " + methodCall.getMethodExpression().getReferenceName());
-
-                // Check if the method call is block()
+                // Check if the method call is block() or a variant of block() method
                 if (methodCall.getMethodExpression().getReferenceName().startsWith("block")) {
                     boolean isAsyncContext = checkIfAsyncContext(methodCall);
+
+                    // Check if the method call is on an Azure SDK client and is in an async context
                     if (isAsyncContext && isAzureClient(methodCall)) {
-                        holder.registerProblem(expression, "Using block() method in an async client can lead to performance issues.");
-                    } else {
-                        holder.registerProblem(expression, "Consider using a synchronous client instead of block().");
+                        holder.registerProblem(expression, ANTI_PATTERN_MESSAGE);
                     }
                 }
             }
@@ -73,21 +104,21 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
          */
         private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
             PsiExpression expression = methodCall.getMethodExpression().getQualifierExpression();
-            System.out.println("Expression: " + expression);
 
+            // Check if the method call is on a reactive type
             if (expression != null) {
                 PsiType type = expression.getType();
-                System.out.println("Type: " + type);
 
+                // Check if the type is a reactive type
                 if (type != null) {
                     String typeName = type.getCanonicalText();
-                    System.out.println("TypeName: " + typeName);
 
-                    // Check for common async/reactive types directly
-                    return typeName.startsWith("reactor.core.publisher.Mono") ||
-                        typeName.startsWith("reactor.core.publisher.Flux") ||
-                        typeName.startsWith("com.azure.core.util.paging.PagedFlux") ||
-                        typeName.startsWith("com.azure.core.util.polling.PollerFlux");
+                    // Check for common async/reactive types directly in the list asyncReturnTypes
+                    for (String asyncReturnType : ASYNC_RETURN_TYPES) {
+                        if (typeName.startsWith(asyncReturnType)) {
+                            return true;
+                        }
+                    }
                 }
             }
             return false;
@@ -101,11 +132,10 @@ private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall)
          */
         private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
             PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
-            System.out.println("ContainingClass: " + containingClass);
 
+            // Check if the method call is on a class
             if (containingClass != null) {
                 String className = containingClass.getQualifiedName();
-                System.out.println("ClassName: " + className);
 
                 // Check if the class is part of the Azure SDK
                 if (className != null && className.startsWith("com.azure.")) {
@@ -114,5 +144,20 @@ private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
             }
             return false;
         }
+
+        // helper method to load config from json
+        private static  Map<String, Object> getAsyncReturnTypesToCheck() throws IOException {
+
+            //load json object
+            JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+
+            //get the async return types to check
+            JSONArray asyncReturnTypes = jsonObject.getJSONObject(RULE_NAME).getJSONArray(ASYNC_RETURN_TYPES_KEY);
+
+            // extract string from json object
+            String antiPatternMessage = jsonObject.getJSONObject(RULE_NAME).getString(ANTI_PATTERN_MESSAGE_KEY);
+
+            return Map.of(ASYNC_RETURN_TYPES_KEY, asyncReturnTypes.toList(), ANTI_PATTERN_MESSAGE_KEY, antiPatternMessage.toString());
+        }
     }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
new file mode 100644
index 00000000000..f6a75440d55
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -0,0 +1,24 @@
+{
+  "StorageUploadWithoutLengthCheck": {
+    "methods_to_check": [
+      "upload",
+      "uploadWithResponse"
+    ],
+    "antipattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
+  },
+
+  "ServiceBusReceiverAsyncClientCheck": {
+    "client_name": "ServiceBusReceiverAsyncClient",
+    "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+  },
+
+  "UseOfBlockOnAsyncClientsCheck": {
+    "async_return_types_to_check": [
+      "reactor.core.publisher.Mono",
+      "reactor.core.publisher.Flux",
+      "com.azure.core.util.paging.PagedFlux",
+      "com.azure.core.util.polling.PollerFlux"
+    ],
+    "antipattern_message": "Use of block() on async clients detected. Switch to synchronous APIs instead."
+  }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
new file mode 100644
index 00000000000..ca765b3b5da
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
@@ -0,0 +1,128 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+// Import necessary libraries
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiTypeElement;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiType;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+
+/**
+ * This class tests the ServiceBusReceiverAsyncClientCheck class by mocking the ProblemsHolder and PsiElementVisitor
+ * and verifying that a problem is registered when the ServiceBusReceiverAsyncClient is used.
+ * The test also verifies that a problem is not registered when the PsiElement is null.
+ *
+ * Here are some examples of test data where registerProblem should be called:
+ * 1. ServiceBusReceiverAsyncClient client = new ServiceBusReceiverAsyncClient();
+ * 2.private ServiceBusReceiverAsyncClient receiver;
+ * 3. final ServiceBusReceiverAsyncClient autoCompleteReceiver =
+ *             toClose(getReceiverBuilder(false, entityType, index, false)
+ *                 .buildAsyncClient());
+ */
+
+public class ServiceBusReceiverAsyncClientCheckTest {
+
+    // Create a mock ProblemsHolder to be used in the test
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    // Create a mock PsiElementVisitor for visiting the PsiTypeElement
+    @Mock
+    private PsiElementVisitor mockVisitor;
+
+    // Create a mock PsiTypeElement.
+    @Mock
+    private PsiTypeElement mockTypeElement;
+
+
+    @BeforeEach
+    public void setUp() {
+        // Set up the test
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockTypeElement = mock(PsiTypeElement.class);
+    }
+
+    @Test
+    public void testProblemRegisteredWhenUsingServiceBusReceiverAsyncClient() {
+        // Assert
+        assertVisitor();
+
+        String CLIENT_TO_CHECK = "ServiceBusReceiverAsyncClient";
+
+        // Visit Type Element
+        int NUMBER_OF_INVOCATIONS = 1;  // Number of times registerProblem should be called
+        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS, CLIENT_TO_CHECK);
+    }
+
+    /**
+     * Test that a problem is not registered when the client name is not ServiceBusReceiverAsyncClient.
+     *
+     * This test is important because it verifies that the code does not
+     * register a problem when the client name is not ServiceBusReceiverAsyncClient.
+     */
+
+    @Test
+    void testProblemNotRegisteredWhenCheckingForDiifferentClient() {
+
+        String CLIENT_TO_CHECK = "ServiceBusProcessorClient";
+
+        // Visit Type Element
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
+        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS, CLIENT_TO_CHECK);
+
+    }
+
+    /**
+     * Test that a problem is not registered when the PsiTypeElement is null and the client name is empty.
+     */
+    @Test
+    void testProblemNotRegisteredWhenClientIsEmpty() {
+        // Visit Type Element
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
+        String CLIENT_TO_CHECK = "";
+        visitTypeElement(null, NUMBER_OF_INVOCATIONS, "");
+    }
+
+    // Create a visitor by calling the buildVisitor method of ServiceBusReceiverAsyncClientCheck
+    private PsiElementVisitor createVisitor() {
+        ServiceBusReceiverAsyncClientCheck check = new ServiceBusReceiverAsyncClientCheck();
+        boolean isOnTheFly = true;
+        return check.buildVisitor(mockHolder, isOnTheFly);
+    }
+
+    // Assert that the visitor is not null and is an instance of JavaElementVisitor
+    private void assertVisitor() {
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    }
+
+    /** Visit a Type Element and verify that a problem was registered
+     * when the ServiceBusReceiverAsyncClient is used.
+     * @param typeElement The PsiTypeElement to visit
+     * @param NUMBER_OF_INVOCATIONS The number of times registerProblem should be called
+     */
+    private void visitTypeElement(PsiTypeElement typeElement, int NUMBER_OF_INVOCATIONS, String CLIENT_TO_CHECK) {
+
+        PsiType mockType = mock(PsiType.class);
+
+        when(mockTypeElement.getType()).thenReturn(mockType);
+        when(mockType.getPresentableText()).thenReturn(CLIENT_TO_CHECK);
+
+        ((JavaElementVisitor) mockVisitor).visitTypeElement(mockTypeElement);
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains("Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."));
+    }
+
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
new file mode 100644
index 00000000000..9d92008e7b0
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheckTest.java
@@ -0,0 +1,142 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaRecursiveElementWalkingVisitor;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiNewExpression;
+import com.intellij.psi.PsiType;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+import org.mockito.Mock;
+
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+
+/**
+ * This class is used to test the StorageUploadWithoutLengthCheck class.
+ * It tests the visitor method to check if the upload methods are being called without a 'length' parameter of type 'long'.
+ *
+ * These are examples of situations where the visitor method should register a problem:
+ * 1. @ServiceMethod(returns = ReturnType.SINGLE)
+ *     public void upload(InputStream data) {
+ *         uploadWithResponse(new BlobParallelUploadOptions(data), null, null);
+ *     }
+ *
+ * 2. uploadWithResponse(new BlobParallelUploadOptions(data).setRequestConditions(blobRequestConditions), null, Context.NONE);
+ *
+ * 3. upload(data, false);
+ */
+
+public class StorageUploadWithoutLengthCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+    private PsiElementVisitor mockVisitor;
+    private PsiElement mockElement;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockElement = mock(PsiElement.class);
+        mockVisitor = createVisitor();
+    }
+
+    /**
+     * assertVisitor(mockVisitor) asserts that it the visitor not null and is an instance of JavaRecursiveElementWalkingVisitor.
+     * verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS) verifies that the registerProblem method is called
+     * when the visitor visits a method call expression with the method name METHOD_TO_CHECK.
+     */
+    @Test
+    public void testStorageUploadWithoutLengthCheck() {
+        assertVisitor(mockVisitor);
+
+        String METHOD_TO_CHECK = "upload";
+        int NUMBER_OF_INVOCATIONS = 1;  // Number of times registerProblem should be called
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS);
+
+    }
+
+    // Create a visitor for the class under test
+    private PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = false;
+
+        // Create an instance of the class under test
+        StorageUploadWithoutLengthCheck check = new StorageUploadWithoutLengthCheck();
+        return check.buildVisitor(mockHolder, isOnTheFly);
+    }
+
+    // Assert that the visitor is not null and is an instance of JavaRecursiveElementWalkingVisitor
+    void assertVisitor(PsiElementVisitor visitor) {
+        assertNotNull(visitor);
+        assertTrue(visitor instanceof JavaRecursiveElementWalkingVisitor);
+    }
+
+    // Verify that the registerProblem method is called when the visitor visits a method call expression with the method name METHOD_TO_CHECK.
+    private void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS) {
+
+        // Arrange
+        PsiMethodCallExpression mockExpression = mock(PsiMethodCallExpression.class);
+        PsiExpressionList mockArgList = mock(PsiExpressionList.class);
+
+        PsiExpression mockArgExpression = mock(PsiExpression.class);
+
+        PsiMethodCallExpression mockArgMethodCall = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression mockMethodExpression = mock(PsiReferenceExpression.class);
+        PsiExpression mockQualifier = mock(PsiExpression.class);
+        PsiNewExpression nextMockQualifier = mock(PsiNewExpression.class);
+        PsiType mockType = mock(PsiType.class);
+        PsiMethodCallExpression mockQualifierMethodCall = mock(PsiMethodCallExpression.class);
+
+
+        // Act
+        when(mockExpression.getMethodExpression()).thenReturn(mockMethodExpression);
+        when(mockMethodExpression.getReferenceName()).thenReturn(METHOD_TO_CHECK);
+
+        when(mockExpression.getArgumentList()).thenReturn(mockArgList);
+        when(mockArgList.getExpressions()).thenReturn(new PsiExpression[0]);
+
+        when(mockArgExpression.getType()).thenReturn(mockType);
+        when(mockType.toString()).thenReturn("long");
+
+        when(mockArgMethodCall.getMethodExpression()).thenReturn(mockMethodExpression);
+        when(mockMethodExpression.getQualifierExpression()).thenReturn(mockQualifier);
+
+        when(mockQualifierMethodCall.getMethodExpression()).thenReturn(mockMethodExpression);
+        when(mockMethodExpression.getQualifierExpression()).thenReturn(nextMockQualifier);
+
+        when(nextMockQualifier.getArgumentList()).thenReturn(mockArgList);
+        when(mockArgList.getExpressions()).thenReturn(new PsiExpression[0]);
+
+        when(nextMockQualifier.getType()).thenReturn(mockType);
+        when(mockType.toString()).thenReturn("long");
+
+        ((JavaRecursiveElementWalkingVisitor) visitor).visitMethodCallExpression(mockExpression);
+
+        // Verify registerProblem is called
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(mockExpression), Mockito.contains("Azure Storage upload API without length parameter detected"));
+    }
+
+    /**
+     * Test the visitor method when the method call expression is not in the list of methods to check.
+     * This should not call registerProblem.
+     */
+    @Test
+    public void testMethodCallNotInList() {
+        String METHOD_TO_CHECK = "notInList";
+        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
+        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS);
+    }
+}
+
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
new file mode 100644
index 00000000000..649d8c87408
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
@@ -0,0 +1,175 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseOfBlockOnAsyncClientsCheck.UseOfBlockOnAsyncClientsVisitor;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.util.PsiTreeUtil;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+/**
+ * This class is used to test the UseOfBlockOnAsyncClientsCheck class.
+ * The UseOfBlockOnAsyncClientsCheck class is an inspection tool that checks for the use of block() method on async clients in Azure SDK.
+ * This inspection will check for the use of block() method on reactive types like Mono, Flux, etc.
+ * 1. Flux<ByteBuffer> downloadFlux = blobAsyncClient.download()
+ *                 .doOnComplete(() -> System.out.println("Download complete"))
+ *                 .doOnError(error -> System.err.println("Error downloading file: " + error.getMessage()));
+ *
+ *             // This call should be flagged
+ *             downloadFlux.blockFirst();
+ *
+ * 2. // Download a file from Azure Blob Storage using the async client
+ *             Mono<Void> downloadMono = blobAsyncClient.downloadToFile("downloadedFilePath")
+ *                 .doOnSuccess(response -> System.out.println("File downloaded successfully"))
+ *                 .doOnError(error -> System.err.println("Error downloading file: " + error.getMessage()));
+ *
+ *             // This call should also be flagged by the inspection tool
+ *             downloadMono.blockOptional();
+ */
+public class UseOfBlockOnAsyncClientsCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    @Mock
+    private PsiMethodCallExpression mockElement;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockElement = mock(PsiMethodCallExpression.class);
+    }
+
+    /**
+     * This is the main test method that tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
+     */
+    @Test
+    public void testUseOfBlockOnAsyncClientsVisitor() {
+
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 1;
+        String METHOD_NAME = "block";
+        String AZURE_PACKAGE = "com.azure.";
+
+        // verify register problem
+        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+
+    }
+
+    /**
+     * This test method tests the use of blockOptional() method on async clients.
+     * This method should be flagged by the inspection tool.
+     */
+    @Test
+    public void testUseOfDifferentBlockOnAsyncClientsVisitor() {
+
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 1;
+        String METHOD_NAME = "blockOptional";
+        String AZURE_PACKAGE = "com.azure.";
+
+        // verify register problem
+        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+    }
+
+    /**
+     * This test method tests the use of blockFirst() method on non-azure async clients.
+     * This method should not be flagged by the inspection tool.
+     */
+    @Test
+    public void testUseOfBlockOnAsyncClientsVisitorWithNonAzureClient() {
+
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 0;
+        String METHOD_NAME = "blockFirst";
+        String AZURE_PACKAGE = "com.notAzure.";
+
+        // verify register problem
+        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+    }
+
+    /**
+     * This test method tests the use of a different method call on async clients.
+     * This method should not be flagged by the inspection tool.
+     */
+    @Test
+    public void testVisitOnDifferentMethodCall() {
+
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 0;
+        String METHOD_NAME = "nonBlockingMethod";
+        String AZURE_PACKAGE = "com.azure.";
+
+        // verify register problem
+        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+    }
+
+    // Create a visitor object for the test
+    JavaElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        UseOfBlockOnAsyncClientsVisitor visitor = new UseOfBlockOnAsyncClientsCheck.UseOfBlockOnAsyncClientsVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
+
+    // Assert that the visitor object is not null and is an instance of JavaElementVisitor
+    void assertVisitor() {
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    }
+
+    // Verify that the registerProblem method is called the expected number of times
+    void verifyRegisterProblem(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_OF_INVOCATIONS) {
+
+        // Arrange
+        PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
+        PsiExpression expression = mock(PsiExpression.class);
+        PsiType type = mock(PsiType.class);
+        PsiClass containingClass = mock(PsiClass.class);
+        PsiTreeUtil mockTreeUtil = mock(PsiTreeUtil.class);
+
+
+        when(mockElement.getMethodExpression()).thenReturn(referenceExpression);
+        when(referenceExpression.getReferenceName()).thenReturn(METHOD_NAME);
+
+        when(referenceExpression.getQualifierExpression()).thenReturn(expression);
+        when(expression.getType()).thenReturn(type);
+        when(type.getCanonicalText()).thenReturn("reactor.core.publisher.Flux");
+
+        when(mockTreeUtil.getParentOfType(mockElement, PsiClass.class)).thenReturn(containingClass);
+        when(containingClass.getQualifiedName()).thenReturn(AZURE_PACKAGE);
+
+        // Act
+        mockVisitor.visitMethodCallExpression(mockElement);
+
+        // Verify registerProblem is not called
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of block() on async clients detected. Switch to synchronous APIs instead."));
+    }
+}
+

From 4b04419fdfa9eba0ffa83a0577543cd783a8f372 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 30 Jun 2024 17:35:18 -0700
Subject: [PATCH 030/144] updating README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 191fd3e94f2..e92400eb1b3 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -16,10 +16,28 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 
 ## Rules
-1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+1. #### Storage Upload without Length Check
+- **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
+- **Severity: INFO**
+- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
+
+
+2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
 - **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
 
 - **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
-- **Severity: INFO**
+- **Severity: WARNING**
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+3. #### Use sync client operation if usage of block() on an async client.
+- **Anti-Pattern**: Using `block()` on an async client. This practice turns an asynchronous operation into a synchronous one.
+
+- **Issue**: The use of `block()` goes against the non-blocking nature of reactive streams. 
+It can lead to performance issues because it blocks one of the few available threads.
+In reactive applications, avoiding blocking operations is crucial for scalability and responsiveness.
+- **Severity Level: WARNING**
+- **Recommendation**: If you find yourself frequently using `block()` in your code, consider switching to the sync client. 
+The sync client performs operations synchronously without requiring `block()`. 
+Using the sync client can make your code more straightforward and easier to understand.
\ No newline at end of file

From 8e648f5f823375aa90f5a38ddf4f6496493ef61e Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Mon, 1 Jul 2024 10:59:10 -0700
Subject: [PATCH 031/144] Update README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md      | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index db512f3d36a..a880c2d8f11 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -15,14 +15,12 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
 
 
-
 ## Rules
-1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
-- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
-- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
-- **Severity: INFO**
-- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+1. #### Storage Upload without Length Check
+- **Anti-Pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
+- **Severity: INFO**. 
+- **Recommendation**: Use APIs that take a length parameter. [Click here for more details](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java)
 
 2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
 - **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
@@ -35,4 +33,4 @@ Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/
 - **Anti-pattern**: Using Connection Strings for Authenticating Azure SDK Clients.
 - **Issue**: Cconnection strings authentication is not recommended in Azure SDKs for Java due to potential security vulnerabilities.
 - **Severity: WARNING**
-- **Recommendation**: Use [DefaultAzureCredential](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for azure service client authentication instead.
\ No newline at end of file
+- **Recommendation**: Use [DefaultAzureCredential](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for azure service client authentication instead.

From 42ad4cac51e9dd2a5c995e0c9d1710695891c732 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 1 Jul 2024 18:08:50 -0700
Subject: [PATCH 032/144] implement dynamic client creation rule

---
 .../azure-toolkit-for-intellij/.idea/misc.xml |  15 +-
 .../azure-intellij-plugin-azure-sdk/README.md |  18 +-
 .../buildtool/DynamicClientCreationCheck.java | 217 ++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  16 +-
 .../main/resources/META-INF/ruleConfigs.json  |   8 +
 .../DynamicClientCreationCheckTest.java       | 123 ++++++++++
 6 files changed, 386 insertions(+), 11 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
index 57337953a0f..86224377976 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
@@ -4,19 +4,12 @@
   <component name="FrameworkDetectionExcludesConfiguration">
     <file type="web" url="file://$PROJECT_DIR$" />
   </component>
-  <component name="MavenProjectsManager">
-    <option name="originalFiles">
-      <list>
-        <option value="$PROJECT_DIR$/../../Utils/pom.xml" />
-      </list>
-    </option>
-  </component>
   <component name="NullableNotNullManager">
     <option name="myDefaultNullable" value="javax.annotation.Nullable" />
     <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
     <option name="myNullables">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
           <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
@@ -32,12 +25,14 @@
           <item index="12" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.Nullable" />
           <item index="13" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.Nullable" />
           <item index="14" class="java.lang.String" itemvalue="io.reactivex.annotations.Nullable" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.Nullable" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nullable" />
         </list>
       </value>
     </option>
     <option name="myNotNulls">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
           <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
@@ -53,6 +48,8 @@
           <item index="12" class="java.lang.String" itemvalue="lombok.NonNull" />
           <item index="13" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.NonNull" />
           <item index="14" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.NonNull" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.NonNull" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nonnull" />
         </list>
       </value>
     </option>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 191fd3e94f2..d689ee9b219 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -22,4 +22,20 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
 - **Severity: INFO**
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
+- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
+- **Severity: WARNING**
+- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios.
+  Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+3. #### Dynamic Client Creation is wasteful
+- **Anti-pattern**: Dynamic client creation refers to creating a new client instance for each operation, without reusing existing instances.
+- **Issue**: This process can be resource-intensive and slow, especially if repeated frequently. It can lead to performance issues, increased memory usage, and unnecessary overhead.
+- **Severity: WARNING**
+- **Recommendation**: Instead of creating a new client instance for each operation, consider reusing existing client instances. 
+It's recommended to create client instances once and reuse them throughout the application's lifecycle. 
+This approach can lead to better performance and efficiency.
+Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/developer/java/sdk/overview#connect-to-and-use-azure-resources-with-client-libraries) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
new file mode 100644
index 00000000000..9edfb5887d8
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -0,0 +1,217 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiAssignmentExpression;
+import com.intellij.psi.PsiBlockStatement;
+import com.intellij.psi.PsiCodeBlock;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionStatement;
+import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiStatement;
+import org.jetbrains.annotations.NotNull;
+import org.json.JSONArray;
+import org.json.JSONObject;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+
+public class DynamicClientCreationCheck extends LocalInspectionTool {
+
+
+    /**
+     * ]
+     * This method builds a visitor to check for the discouraged client name in the code.
+     *
+     * @param holder
+     * @param isOnTheFly
+     * @return PsiElementVisitor
+     */
+    @NotNull
+    @Override
+    public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new DynamicClientCreationVisitor(holder, isOnTheFly);
+    }
+
+
+    /**
+     * This class extends the JavaElementVisitor to check for the dynamic creation of clients in the code.
+     */
+    public static class DynamicClientCreationVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+
+        // Constants
+        private static final Map<String, Object> RULE_CONFIGS_MAP;
+        private static final String RULE_NAME = "DynamicClientCreationCheck";
+        private static final String METHODS_TO_CHECK_KEY = "methods_to_check";
+        private static final String ANTI_PATTERN_MESSAGE_KEY = "antipattern_message";
+        private static final List<String> METHODS_TO_CHECK;
+        private static final String ANTI_PATTERN_MESSAGE;
+
+
+        // Load the config file
+        static {
+            try {
+                RULE_CONFIGS_MAP = getClientCreationMethodsToCheck();
+
+                // extract the methods to check and the anti-pattern message from the config file
+                METHODS_TO_CHECK = (List<String>) RULE_CONFIGS_MAP.get(METHODS_TO_CHECK_KEY);
+                ANTI_PATTERN_MESSAGE = (String) RULE_CONFIGS_MAP.get(ANTI_PATTERN_MESSAGE_KEY);
+
+            } catch (IOException e) {
+                throw new RuntimeException("Error loading config file", e);
+            }
+        }
+
+        /**
+         * This constructor initializes the ProblemsHolder and isOnTheFly variables.
+         *
+         * @param holder
+         * @param isOnTheFly
+         */
+        public DynamicClientCreationVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
+
+        /**
+         * This method checks for the dynamic creation of clients in the code.
+         *
+         * @param statement
+         */
+        @Override
+        public void visitForStatement(@NotNull PsiForStatement statement) {
+            super.visitForStatement(statement);
+
+            // Extract the body of the for loop
+            PsiStatement body = statement.getBody();
+
+            if (!(body instanceof PsiBlockStatement)) {
+                return;
+            }
+
+            // Extract the code block from the block statement
+            PsiBlockStatement blockStatement = (PsiBlockStatement) body;
+            PsiCodeBlock codeBlock = blockStatement.getCodeBlock();
+
+            // Traverse the statements within the code block
+            for (PsiStatement blockChild : codeBlock.getStatements()) {
+                checkClientCreation(blockChild);
+            }
+        }
+
+        /**
+         * This method checks for the dynamic creation of clients in the code block of a for loop.
+         * Each assignment statement and declaration statement is checked for the creation of clients.
+         * @param blockChild
+         */
+
+        private void checkClientCreation(PsiStatement blockChild) {
+
+            // This is a check for the expression statement
+            if (blockChild instanceof PsiExpressionStatement) {
+                PsiExpression expression = ((PsiExpressionStatement) blockChild).getExpression();
+
+                if (!(expression instanceof PsiAssignmentExpression)) {
+                    return;
+                }
+
+                // Extract the assignment expression
+                PsiAssignmentExpression assignment = (PsiAssignmentExpression) expression;
+
+                // Extract the right-hand side of the assignment
+                PsiExpression rhs = assignment.getRExpression();
+
+                // Check if the right-hand side is a method call expression
+                if (rhs != null) {
+                    if (isClientCreationMethod((PsiMethodCallExpression) rhs)) {
+                        holder.registerProblem(rhs, ANTI_PATTERN_MESSAGE);
+                    }
+                }
+            }
+
+            // This is a check for the declaration statement
+            PsiDeclarationStatement declarationStatement = (PsiDeclarationStatement) blockChild;
+
+            // Traverse the declared elements within the declaration statement
+            for (PsiElement declaredElement : declarationStatement.getDeclaredElements()) {
+
+                // Check if the declared element is a local variable
+                if (!(declaredElement instanceof PsiLocalVariable)) {
+                    continue;
+                }
+
+                // Extract the local variable and its initializer
+                PsiLocalVariable localVariable = (PsiLocalVariable) declaredElement;
+                PsiExpression initializer = localVariable.getInitializer();
+
+                if (!(initializer instanceof PsiMethodCallExpression)) {
+                    continue;
+                }
+                // Check if the initializer is a method call expression
+                PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) initializer;
+                if (isClientCreationMethod(methodCallExpression)) {
+                    holder.registerProblem(methodCallExpression, ANTI_PATTERN_MESSAGE);
+                }
+            }
+        }
+
+        /**
+         * This method checks if the method call expression is a client creation method.
+         * It checks the method name and the type of the qualifier expression.
+         * If the method name is buildClient or AsyncBuildClient and the qualifier expression is of type com.azure,
+         * then it is considered a client creation method.
+         * @param methodCallExpression
+         * @return
+         */
+        public boolean isClientCreationMethod (PsiMethodCallExpression methodCallExpression){
+
+            // Extract the method expression from the method call expression
+            PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
+
+            // Extract the method name
+            String methodName = methodExpression.getReferenceName();
+
+            // Check if the method name is buildClient or AsyncBuildClient
+            if (methodName != null && METHODS_TO_CHECK.contains(methodName)) {
+
+                // Extract the qualifier expression
+                PsiExpression qualifierExpression = methodExpression.getQualifierExpression();
+
+                // Check if the qualifier expression is of type com.azure
+                if (qualifierExpression.getType().getCanonicalText().startsWith("com.azure")) {
+                    return true;
+                }
+            }
+            return false;
+        }
+
+        /**
+         * This method loads the JSON configuration file and extracts the methods to check for dynamic client creation.
+         * @return Map<String, Object>
+         * @throws IOException
+         */
+        private static Map<String, Object> getClientCreationMethodsToCheck() throws IOException {
+
+            //load json object
+            JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+
+            //get the async return types to check
+            JSONArray asyncReturnTypes = jsonObject.getJSONObject(RULE_NAME).getJSONArray(METHODS_TO_CHECK_KEY);
+
+            // extract string from json object
+            String antiPatternMessage = jsonObject.getJSONObject(RULE_NAME).getString(ANTI_PATTERN_MESSAGE_KEY);
+
+            return Map.of(METHODS_TO_CHECK_KEY, asyncReturnTypes.toList(), ANTI_PATTERN_MESSAGE_KEY, antiPatternMessage.toString());
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 1b9efeb66e2..3eb8f2cbbec 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -42,7 +42,7 @@
                 language="JAVA"
                 shortName="ServiceBusReceiverAsyncClientCheck"
                 displayName="Low level ServiceBusReceiverAsyncClient check"
-                groupName="Azure SDK"
+                groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 level="WARNING"
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
@@ -51,5 +51,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="DynamicClientCreationCheck"
+                displayName="Dynamic Client Creation Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DynamicClientCreationCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DynamicClientCreationCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d0361d1b107..53e2279d91b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -10,5 +10,13 @@
   "ServiceBusReceiverAsyncClientCheck": {
     "client_name": "ServiceBusReceiverAsyncClient",
     "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+  },
+
+  "DynamicClientCreationCheck": {
+    "methods_to_check": [
+      "buildClient",
+      "buildAsyncClient"
+    ],
+    "antipattern_message": "Dynamic client creation detected. Create a single client instance and reuse it instead."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
new file mode 100644
index 00000000000..a406626fe58
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
@@ -0,0 +1,123 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.psi.PsiAssignmentExpression;
+import com.intellij.psi.PsiBlockStatement;
+import com.intellij.psi.PsiCodeBlock;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionStatement;
+import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiStatement;
+import com.intellij.psi.PsiType;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DynamicClientCreationCheck.DynamicClientCreationVisitor;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiMethodCallExpression;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class DynamicClientCreationCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    @Mock
+    private PsiForStatement mockElement;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockElement = mock(PsiForStatement.class);
+    }
+
+    /**
+     * This is the main test method that tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
+     *
+     * This tests blocks of code that are a PsiExpressionStatement in the checkClientCreation method.
+     */
+    @Test
+    public void testDynamicClientCreationWithExpressionStatement() {
+
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 1;
+        String METHOD_NAME = "buildClient";
+        String AZURE_PACKAGE = "com.azure.";
+
+        // verify register problem
+        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+    }
+
+    JavaElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        DynamicClientCreationVisitor mockVisitor = new DynamicClientCreationVisitor(mockHolder, isOnTheFly);
+        return mockVisitor;
+    }
+
+    void assertVisitor() {
+        // assert visitor
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    }
+
+    void verifyRegisterProblem(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_OF_INVOCATIONS) {
+
+        // main method
+        PsiStatement statement = mock(PsiStatement.class);
+        PsiStatement body = mock(PsiStatement.class);
+        PsiBlockStatement blockStatement = mock(PsiBlockStatement.class);
+        PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
+        PsiExpressionStatement blockChild = mock(PsiExpressionStatement.class);
+        PsiStatement[] blockStatements = new PsiStatement[] { blockChild };
+
+        // check client creation
+        PsiAssignmentExpression expression = mock(PsiAssignmentExpression.class);
+        PsiMethodCallExpression rhs = mock(PsiMethodCallExpression.class);
+
+        // isClientCreation method
+        PsiMethodCallExpression methodCallExpression = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
+        PsiExpression qualifierExpression = mock(PsiExpression.class);
+        PsiType type = mock(PsiType.class);
+
+
+        // main method
+        when(mockElement.getBody()).thenReturn(blockStatement);
+        when(blockStatement.getCodeBlock()).thenReturn(codeBlock);
+        when(codeBlock.getStatements()).thenReturn(blockStatements);
+
+        // check client creation
+        when(blockChild.getExpression()).thenReturn(expression);
+        when(expression.getRExpression()).thenReturn(rhs);
+
+        // isClientCreation method
+        when(methodCallExpression.getMethodExpression()).thenReturn(methodExpression);
+        when(methodExpression.getReferenceName()).thenReturn(METHOD_NAME);
+        when(methodExpression.getQualifierExpression()).thenReturn(qualifierExpression);
+        when(qualifierExpression.getType()).thenReturn(type);
+        when(type.getCanonicalText()).thenReturn(AZURE_PACKAGE);
+
+        mockVisitor.visitForStatement(mockElement);
+
+        // Verify problem is registered
+        verify(mockHolder,
+                times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(methodCallExpression),
+                Mockito.contains("Dynamic client creation detected. Create a single client instance and reuse it instead."));
+    }
+}

From b199a933086351903722bd777f72d031a13995db Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 1 Jul 2024 18:20:53 -0700
Subject: [PATCH 033/144] update to javadoc

---
 .../azure/sdk/buildtool/DynamicClientCreationCheck.java   | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index 9edfb5887d8..82d64d093d0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -23,12 +23,18 @@
 import java.util.List;
 import java.util.Map;
 
+/**
+ * This class is used to check for the dynamic creation of clients in the code.
+ * It extends the LocalInspectionTool class, which is used to create custom code inspections.
+ * The visitor inspects a for loop and checks for methodcall expressions that create clients using the buildClient or AsyncBuildClient methods.
+ * If a client creation method is found building a client from the com.azure package, a problem is registered.
+ */
 public class DynamicClientCreationCheck extends LocalInspectionTool {
 
 
     /**
      * ]
-     * This method builds a visitor to check for the discouraged client name in the code.
+     * This method builds the visitor that checks for the dynamic creation of clients in the code.
      *
      * @param holder
      * @param isOnTheFly

From 13e0dd43cd657b33c549193e4fde73c235bab33f Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Mon, 1 Jul 2024 18:22:54 -0700
Subject: [PATCH 034/144] 2nd update to javadoc

---
 .../azure/sdk/buildtool/DynamicClientCreationCheck.java         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index 82d64d093d0..ce5be130d11 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -26,7 +26,7 @@
 /**
  * This class is used to check for the dynamic creation of clients in the code.
  * It extends the LocalInspectionTool class, which is used to create custom code inspections.
- * The visitor inspects a for loop and checks for methodcall expressions that create clients using the buildClient or AsyncBuildClient methods.
+ * The visitor inspects a for loop and checks for methodcall expressions that create clients using the buildClient or buildAsyncClient methods.
  * If a client creation method is found building a client from the com.azure package, a problem is registered.
  */
 public class DynamicClientCreationCheck extends LocalInspectionTool {

From 43c9d69e4410640dbf6f9b25bb3aa9ea034c1d0b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 2 Jul 2024 11:59:54 -0700
Subject: [PATCH 035/144] update to integrate check for azure clients

---
 .../.idea/gradle.xml                          |   3 +
 .../azure-toolkit-for-intellij/.idea/misc.xml |  15 +-
 ...iesWithTimeIntervalInQueryStringCheck.java | 217 ++++++++++++++--
 ...ithTimeIntervalInQueryStringCheckTest.java | 243 +++++++++++-------
 4 files changed, 347 insertions(+), 131 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
index 0e2731864ba..1b74c3eb9f7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
@@ -14,6 +14,7 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-appservice-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-arm" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-azure-sdk" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-bicep" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-cognitiveservices" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-containerapps" />
@@ -28,11 +29,13 @@
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-base" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-hdinsight-lib" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-integration-services" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-keyvault" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-lib-java" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-monitor" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-redis" />
+            <option value="$PROJECT_DIR$/azure-intellij-plugin-samples" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-service-explorer" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-servicebus" />
             <option value="$PROJECT_DIR$/azure-intellij-plugin-sparkoncosmos" />
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
index 57337953a0f..86224377976 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
@@ -4,19 +4,12 @@
   <component name="FrameworkDetectionExcludesConfiguration">
     <file type="web" url="file://$PROJECT_DIR$" />
   </component>
-  <component name="MavenProjectsManager">
-    <option name="originalFiles">
-      <list>
-        <option value="$PROJECT_DIR$/../../Utils/pom.xml" />
-      </list>
-    </option>
-  </component>
   <component name="NullableNotNullManager">
     <option name="myDefaultNullable" value="javax.annotation.Nullable" />
     <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
     <option name="myNullables">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
           <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
@@ -32,12 +25,14 @@
           <item index="12" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.Nullable" />
           <item index="13" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.Nullable" />
           <item index="14" class="java.lang.String" itemvalue="io.reactivex.annotations.Nullable" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.Nullable" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nullable" />
         </list>
       </value>
     </option>
     <option name="myNotNulls">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
           <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
@@ -53,6 +48,8 @@
           <item index="12" class="java.lang.String" itemvalue="lombok.NonNull" />
           <item index="13" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.NonNull" />
           <item index="14" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.NonNull" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.NonNull" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nonnull" />
         </list>
       </value>
     </option>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index bcf8f7d0872..355e1b997b8 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -1,19 +1,35 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
+import com.azure.core.credential.TokenCredential;
+import com.azure.identity.DefaultAzureCredentialBuilder;
+import com.azure.monitor.query.LogsQueryClient;
+import com.azure.monitor.query.LogsQueryClientBuilder;
+import com.azure.monitor.query.models.LogsQueryResult;
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.JavaPsiFacade;
+import com.intellij.psi.JavaRecursiveElementVisitor;
+import com.intellij.psi.PsiClass;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementFactory;
 import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiField;
+import com.intellij.psi.PsiJavaCodeReferenceElement;
 import com.intellij.psi.PsiLiteralExpression;
 import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiParameter;
 import com.intellij.psi.PsiPolyadicExpression;
 import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiTypeElement;
+import com.intellij.psi.PsiType;
 import com.intellij.psi.PsiVariable;
+import com.intellij.psi.impl.source.PsiParameterImpl;
+import com.intellij.psi.impl.source.tree.java.PsiMethodCallExpressionImpl;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
 
@@ -21,6 +37,10 @@
 import java.io.FileNotFoundException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.time.DayOfWeek;
+import java.time.temporal.Temporal;
+import java.time.temporal.TemporalQuery;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
@@ -38,6 +58,8 @@
  * 3. Queries that use the "now" function to get the current timestamp.
  * 4. Queries that use the "startofday", "startofmonth", or "startofyear" functions.
  * 5. Queries that use the "between" function with datetime values.
+ *
+ * When the anti-patterns are detected as parameters of Azure client method calls, a problem is registered.
  */
 public class KustoQueriesWithTimeIntervalInQueryStringCheck extends LocalInspectionTool {
 
@@ -45,13 +67,14 @@ public class KustoQueriesWithTimeIntervalInQueryStringCheck extends LocalInspect
 
     /**
      * This method builds the visitor for the inspection tool
-     * @param holder ProblemsHolder is used to register problems found in the code
+     *
+     * @param holder     ProblemsHolder is used to register problems found in the code
      * @param isOnTheFly boolean to indicate if the inspection is done on the fly
      * @return PsiElementVisitor
      */
     @NotNull
     @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+    public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         return new KustoQueriesVisitor(holder, isOnTheFly);
     }
 
@@ -77,6 +100,9 @@ public static class KustoQueriesVisitor extends JavaElementVisitor {
 
         private static final String ANTI_PATTERN = ruleConfigurations.get(ANTI_PATTERN_KEY).get(0);
 
+        // empty list to store time interval parameters
+        private List<String> timeIntervalParameters = new ArrayList<>();
+
         // Define your patterns
         Pattern KQL_ANTI_PATTERN_AGO = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(0));
         Pattern KQL_ANTI_PATTERN_DATETIME = Pattern.compile(loadRuleConfigurations().get(REGEX_PATTERNS_KEY).get(1));
@@ -87,6 +113,7 @@ public static class KustoQueriesVisitor extends JavaElementVisitor {
         /**
          * Constructor for the KustoQueriesVisitor class
          * The constructor initializes the ProblemsHolder and isOnTheFly variables
+         *
          * @param holder
          * @param isOnTheFly
          */
@@ -102,60 +129,128 @@ public KustoQueriesVisitor(ProblemsHolder holder, boolean isOnTheFly) {
          * If the element is a PsiPolyadicExpression, the method processes the expression to replace the variables with their values
          * The method then checks the expression for the anti-patterns by matching regex patterns with the expression text
          * and registers a problem if an anti-pattern is detected
+         *
          * @param element
          */
+
+
         @Override
         public void visitElement(@NotNull PsiElement element) {
             super.visitElement(element);
 
-            if (!(element instanceof PsiPolyadicExpression || element instanceof PsiLocalVariable)) {
+            // Check if the element is a PsiPolyadicExpression or a PsiLocalVariable
+            if (!(element instanceof PsiPolyadicExpression
+                    || element instanceof PsiLocalVariable
+                    || element instanceof PsiMethodCallExpressionImpl)) {
                 return;
             }
-            PsiExpression initializer = null;
-            PsiPolyadicExpression originalExpression = null;
 
-            if (!(element instanceof PsiPolyadicExpression)) {
+            if (element instanceof PsiMethodCallExpressionImpl) {
+                System.out.println("Element is a PsiMethodCallExpressionImpl");
+                handleMethodCall((PsiMethodCallExpressionImpl) element);
+            }
+
+            if (element instanceof PsiLocalVariable) {
+                System.out.println("Element is a PsiLocalVariable");
+
                 PsiLocalVariable variable = (PsiLocalVariable) element;
-                initializer = variable.getInitializer();
-                if (initializer != null && initializer instanceof PsiLiteralExpression) {
-                    String text = initializer.toString();
-                    checkExpression(initializer, element, holder);
-                }
+                handleLocalVariable(variable);
             }
+
             // if element is a polyadic expression, extract the value.
             // PsiPolyadicExpressions are used to represent expressions with multiple operands
             // eg ("datetime" + startDate), where startDate is a variable
-             else if (element instanceof PsiPolyadicExpression) {
-                // process the polyadic expression to replace the variables with their values
-                PsiElement processedElement = processPsiPolyadicExpressions(element.copy());
-                initializer = processedElement instanceof PsiPolyadicExpression ? (PsiPolyadicExpression) processedElement : null;
-                checkExpression(initializer, element, holder);
+            if (element instanceof PsiPolyadicExpression) {
+                System.out.println("Element is a PsiPolyadicExpression");
+                handlePolyadicExpression((PsiPolyadicExpression) element);
+            }
+        }
+
+        private void handleLocalVariable(PsiLocalVariable variable) {
+            System.out.println("Element is a PsiLocalVariable");
+
+            PsiExpression initializer = variable.getInitializer();
+            String variableName = variable.getName();
+            System.out.println("Variable name: " + variableName);
+            if (initializer != null && initializer instanceof PsiLiteralExpression) {
+                checkExpression(initializer, variable);
+            }
+        }
+
+        private void handlePolyadicExpression(PsiPolyadicExpression polyadicExpression) {
+            System.out.println("Element is a PsiPolyadicExpression");
+
+            // Process the polyadic expression to replace the variables with their values
+            PsiElement processedElement = processPsiPolyadicExpressions(polyadicExpression.copy());
+            PsiExpression initializer = processedElement instanceof PsiPolyadicExpression ? (PsiPolyadicExpression) processedElement : null;
+            String variableName = polyadicExpression.getText();
+            System.out.println("Variable name: " + variableName);
+            checkExpression(initializer, polyadicExpression);
+        }
+
+        private void handleMethodCall(PsiMethodCallExpressionImpl methodCall) {
+//            System.out.println("Method call: " + methodCall.getText());
+
+            // check the parameters of the method call
+            PsiExpressionList argumentList = methodCall.getArgumentList();
+            PsiExpression[] arguments = argumentList.getExpressions();
+            System.out.println("Arguments: " + Arrays.toString(arguments));
+
+            for (PsiExpression argument : arguments) {
+                if (argument instanceof PsiReferenceExpression) {
+                    PsiReferenceExpression referenceExpression = (PsiReferenceExpression) argument;
+                    PsiElement resolvedElement = referenceExpression.resolve();
+                    System.out.println("Resolved element: " + resolvedElement);
+
+                    if (resolvedElement instanceof PsiVariable) {
+                        PsiVariable variable = (PsiVariable) resolvedElement;
+                        System.out.println("Variable: " + variable);
+
+                        String variableName = variable.getName();
+                        System.out.println("Variable name: " + variableName);
+                        if (timeIntervalParameters.contains(variableName)) {
+                            if (isAzureClient(methodCall)) {
+                                System.out.println("Azure client method call found:");
+                                holder.registerProblem(methodCall, "KQL queries with time intervals in the query string detected.");
+                            }
+                        }
+                    }
+                }
             }
         }
 
-        /** This method checks the expression for the anti-patterns by matching regex patterns with the expression text
+        /**
+         * This method checks the expression for the anti-patterns by matching regex patterns with the expression text
          * and registers a problem if an anti-pattern is detected
+         *
          * @param expression
          * @param element
-         * @param holder
          */
-        void checkExpression(PsiExpression expression, PsiElement element, ProblemsHolder holder) {
+        void checkExpression(PsiExpression expression, PsiElement element) {
             if (expression == null) {
                 return;
             }
             String text = expression.getText();
             if (
                     KQL_ANTI_PATTERN_AGO.matcher(text).find() ||
-                    KQL_ANTI_PATTERN_DATETIME.matcher(text).find() ||
-                    KQL_ANTI_PATTERN_NOW.matcher(text).find() ||
-                    KQL_ANTI_PATTERN_START_OF_PERIOD.matcher(text).find() ||
-                    KQL_ANTI_PATTERN_BETWEEN.matcher(text).find()
+                            KQL_ANTI_PATTERN_DATETIME.matcher(text).find() ||
+                            KQL_ANTI_PATTERN_NOW.matcher(text).find() ||
+                            KQL_ANTI_PATTERN_START_OF_PERIOD.matcher(text).find() ||
+                            KQL_ANTI_PATTERN_BETWEEN.matcher(text).find()
             ) {
-                holder.registerProblem(element, ANTI_PATTERN);
+
+                PsiElement parentElement = element.getParent();
+                PsiLocalVariable variable = (PsiLocalVariable) parentElement;
+                String variableName = variable.getName();
+                System.out.println("Variable name: " + variableName);
+
+                timeIntervalParameters.add(variableName);
             }
         }
 
-        /** This method processes the polyadic expressions to replace the variables with their values
+        /**
+         * This method processes the polyadic expressions to replace the variables with their values
+         *
          * @param element
          * @return PsiElement
          */
@@ -163,18 +258,26 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
 
             // Extract the operands from the polyadic expression
             PsiPolyadicExpression expression = (PsiPolyadicExpression) element;
+            System.out.println("Polyadic expression: " + expression);
+
             PsiExpression[] operands = expression.getOperands();
+            System.out.println("Operands: " + Arrays.toString(operands));
 
             // Iterate through the operands
             for (int i = 0; i < operands.length; i++) {
                 PsiExpression operand = operands[i];
+                System.out.println("Operand: " + operand);
 
                 // PsiReferenceExpressions are used to represent references to variables
                 if (!(operand instanceof PsiReferenceExpression)) {
                     continue;
                 }
                 PsiReferenceExpression reference = (PsiReferenceExpression) operand;
+                System.out.println("Reference: " + reference);
+
                 PsiElement resolved = reference.resolve();
+                System.out.println("Resolved: " + resolved);
+
                 if (!(resolved instanceof PsiVariable)) {
                     continue;
                 }
@@ -182,15 +285,23 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
                 // Resolve means to find the declaration of the variable
                 // Initializer is the value assigned to the variable
                 PsiVariable variable = (PsiVariable) resolved;
+                System.out.println("Variable: " + variable);
+
                 PsiExpression initializer = variable.getInitializer();
+                System.out.println("Initializer: " + initializer);
+
                 if (initializer == null) {
                     continue;
                 }
                 // Initializer.getText() returns the value of the variable in string format
                 // Create a new expression from the variable value and replace the variable with the value
                 String variableValue = initializer.getText();
+                System.out.println("Variable value: " + variableValue);
+                System.out.println("element.getProject()" + element.getProject());
                 PsiElementFactory factory = JavaPsiFacade.getInstance(element.getProject()).getElementFactory();
+                System.out.println("Factory: " + factory);
                 PsiExpression newExpression = factory.createExpressionFromText(variableValue, null);
+                System.out.println("New expression: " + newExpression);
                 if (newExpression != null) {
                     operands[i] = newExpression;
                 }
@@ -204,10 +315,62 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
         }
 
 
-        /** This method loads the rule configurations from the configuration file
+        /**
+         * This method checks if the method call is an Azure client method call
+         * by checking the type of the variable that the method is called on
+         *
+         * @param methodCall
+         * @return boolean
+         */
+        private boolean isAzureClient(PsiMethodCallExpressionImpl methodCall) {
+
+            System.out.println("timeIntervalParameters" + timeIntervalParameters);
+            PsiExpression qualifierExpression = methodCall.getMethodExpression().getQualifierExpression();
+            System.out.println("Qualifier expression: " + qualifierExpression);
+//            System.out.println("Qualifier expressionText: " + qualifierExpression.getText());
+
+            if (qualifierExpression instanceof PsiReferenceExpression) {
+                PsiReferenceExpression referenceExpression = (PsiReferenceExpression) qualifierExpression;
+                System.out.println("Reference expression: " + referenceExpression);
+
+                PsiElement resolvedElement = referenceExpression.resolve();
+                System.out.println("Resolved element: " + resolvedElement);
+
+                if (resolvedElement instanceof PsiVariable) {
+                    System.out.println("Resolved element is a variable");
+
+                    PsiVariable variable = (PsiVariable) resolvedElement;
+//                    System.out.println("Variable: " + variable.getName());
+
+                    PsiType variableType = variable.getType();
+                    System.out.println("Variable type: " + variableType.getCanonicalText());
+
+                    return isAzureClientType(variableType);
+                }
+            }
+            return false;
+        }
+
+        /**
+         * This method checks if the type of the client is an Azure client type
+         *
+         * @param type
+         * @return boolean
+         */
+        private boolean isAzureClientType(PsiType type) {
+            String qualifiedName = type.getCanonicalText();
+            System.out.println("Qualified name: " + qualifiedName);
+            // You can extend this check to include more Azure client types
+            return qualifiedName.startsWith("com.azure");
+        }
+
+
+        /**
+         * This method loads the rule configurations from the configuration file
          * The configuration file contains the regex patterns for the anti-patterns
          * and the message to display when an anti-pattern is detected
-         * @return Map<String, List<String>>
+         *
+         * @return Map<String, List < String>>
          */
         private static Map<String, List<String>> loadRuleConfigurations() {
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
index c394155355b..c1e823db519 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -1,4 +1,8 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiLiteralExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.impl.source.tree.java.PsiMethodCallExpressionImpl;
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor;
 
 // Import necessary libraries
@@ -17,12 +21,12 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.BeforeEach;
 import org.mockito.Mock;
-import org.mockito.Mockito;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.contains;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.ArgumentMatchers.isNull;
 import static org.mockito.Mockito.mock;
@@ -60,6 +64,10 @@ public void setup() {
 
     /**
      * This is the main test method that tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
+     * It tests the KustoQueriesVisitor class by calling the visitElement method with a local variable and a polyadic expression.
+     * The local variable is used in a query string or the polyadic expression is used in a query string.
+     * The method then checks if a problem is registered when a local variable or a polyadic expression is used in a query string
+     * and if the method call is to an Azure client.
      */
     @Test
     public void testKustoQueriesWithTimeIntervalInQueryStringCheck() {
@@ -67,96 +75,11 @@ public void testKustoQueriesWithTimeIntervalInQueryStringCheck() {
         // assert visitor
         assertVisitor(mockVisitor);
 
-        // Visit PsiPolyadicExpression
-        visitPsiPolyadicExpression(mockVisitor, mockElement);
+        // verify register problem with local variable as the query string
+        verifyRegisterProblemWithLocalVariable();
 
-        // Visit other literals
-        visitOtherLiterals(mockVisitor,mockElement);
-    }
-
-    /**
-     * Create a visitor by calling the buildVisitor method of KustoQueriesWithTimeIntervalInQueryStringCheck
-     * @return PsiElementVisitor
-     */
-    PsiElementVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        KustoQueriesVisitor visitor = new KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor(mockHolder, isOnTheFly);
-        return visitor;
-    }
-
-    /**
-     * Assert that the visitor is not null and is an instance of JavaElementVisitor
-     * @param visitor
-     */
-    void assertVisitor(PsiElementVisitor visitor) {
-        assertNotNull(visitor);
-        assertTrue(visitor instanceof JavaElementVisitor);
-    }
-
-    /**
-     * This method tests the processPsiPolyadicExpressions method
-     * for a PsiPolyadicExpression that should be flagged
-     * @param mockVisitor
-     * @param mockElement
-     */
-    void visitPsiPolyadicExpression(PsiElementVisitor mockVisitor, PsiElement mockElement) {
-
-        // Arrange
-        PsiPolyadicExpression mockExpression = mock(PsiPolyadicExpression.class);
-        PsiExpression mockNewExpression = mock(PsiExpression.class);
-        PsiReferenceExpression mockReference = mock(PsiReferenceExpression.class);
-        PsiVariable mockVariable = mock(PsiVariable.class);
-        PsiExpression mockInitializer = mock(PsiExpression.class);
-        JavaPsiFacade mockJavaPsiFacade = mock(JavaPsiFacade.class);
-        Project mockProject = mock(Project.class);
-        PsiElementFactory mockPsiElementFactory = mock(PsiElementFactory.class);
-
-        when(mockElement.getProject()).thenReturn(mockProject);
-        when(mockExpression.getOperands()).thenReturn(new PsiExpression[]{mockReference});
-        when(mockExpression.getText()).thenReturn("test");
-        when(mockExpression.getProject()).thenReturn(mockProject);
-        when(mockReference.resolve()).thenReturn(mockVariable);
-        when(mockVariable.getInitializer()).thenReturn(mockInitializer);
-        when(mockInitializer.getText()).thenReturn("datetime(2022-01-01)");
-        when(mockNewExpression.getText()).thenReturn("datetime(2022-01-01)");
-
-        when(mockJavaPsiFacade.getInstance(mockProject)).thenReturn(mockJavaPsiFacade);
-        when(mockJavaPsiFacade.getElementFactory()).thenReturn(mockPsiElementFactory);
-        when(mockPsiElementFactory.createExpressionFromText(eq("datetime(2022-01-01)"), isNull())).thenReturn(mockNewExpression);
-
-
-        // Act
-        PsiElement result = ((KustoQueriesVisitor) mockVisitor).processPsiPolyadicExpressions(mockExpression);
-        ((KustoQueriesVisitor) mockVisitor).checkExpression(mockInitializer, mockElement, mockHolder);
-
-        // Assert
-        assertEquals(mockNewExpression, result);
-
-        // Verify registerProblem is called
-        verify(mockHolder, times(1)).registerProblem(Mockito.eq(mockElement), Mockito.contains("KQL queries with time intervals in the query string detected."));
-    }
-
-    /**
-     * This method tests the checkExpression method for other literals that should be flagged
-     * @param mockVisitor
-     * @param mockElement
-     */
-
-    void visitOtherLiterals(PsiElementVisitor mockVisitor, PsiElement mockElement) {
-
-        // Arrange
-        PsiLocalVariable mockVariable = mock(PsiLocalVariable.class);
-        PsiExpression mockInitializer = mock(PsiExpression.class);
-
-        when(mockVariable.getInitializer()).thenReturn(mockInitializer);
-        when(mockInitializer.toString()).thenReturn("datetime(2022-01-01)");
-        when(mockInitializer.getText()).thenReturn("datetime(2022-01-01)");
-
-        // Act
-        ((KustoQueriesVisitor) mockVisitor).checkExpression(mockInitializer, mockVariable, mockHolder);
-
-        // Verify registerProblem is not called
-        verify(mockHolder, times(1)).registerProblem(Mockito.eq(mockElement), Mockito.contains("KQL queries with time intervals in the query string detected."));
+        // verify register problem with polyadic expression as the query string
+        verifyRegisterProblemWithPolyadicExpression();
     }
 
     /**
@@ -168,11 +91,7 @@ public void testCheckExpressionWithNullExpression() {
         PsiExpression nullExpression = null;
 
         // Act
-        ((KustoQueriesVisitor) mockVisitor).checkExpression(nullExpression, mockElement, mockHolder);
-
-        // Assert
-        // In this case, we expect that no problem will be registered, because the expression is null
-        verify(mockHolder, times(0)).registerProblem(any(), any());
+        ((KustoQueriesVisitor) mockVisitor).checkExpression(nullExpression, mockElement);
     }
 
     /**
@@ -203,4 +122,138 @@ public void testProcessPsiPolyadicExpressionsWithNoOperands() {
         // because the expression has no operands and therefore nothing was replaced
         assertEquals(mockExpression, result);
     }
+
+    /**
+     * Create a visitor by calling the buildVisitor method of KustoQueriesWithTimeIntervalInQueryStringCheck
+     * @return PsiElementVisitor
+     */
+    PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        KustoQueriesVisitor visitor = new KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
+
+    /**
+     * Assert that the visitor is not null and is an instance of JavaElementVisitor
+     * @param visitor
+     */
+    void assertVisitor(PsiElementVisitor visitor) {
+        assertNotNull(visitor);
+        assertTrue(visitor instanceof JavaElementVisitor);
+    }
+
+
+    /**
+     * This method tests the registerProblem method with a local variable as the query string
+     */
+    void verifyRegisterProblemWithLocalVariable() {
+
+        PsiLocalVariable variable = mock(PsiLocalVariable.class);
+        PsiLiteralExpression initializer = mock(PsiLiteralExpression.class);
+        PsiLocalVariable parentElement = mock(PsiLocalVariable.class);
+
+        PsiMethodCallExpressionImpl methodCall = mock(PsiMethodCallExpressionImpl.class);
+        PsiExpressionList argumentList = mock(PsiExpressionList.class);
+        PsiReferenceExpression argument = mock(PsiReferenceExpression.class);
+        PsiExpression[] arguments = new PsiExpression[]{argument};
+        PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
+        PsiVariable resolvedElement = mock(PsiVariable.class);
+        PsiElement resolvedElementTwo = mock(PsiElement.class);
+        PsiReferenceExpression qualifierExpression = mock(PsiReferenceExpression.class);
+        PsiVariable resolvedVariable = mock(PsiVariable.class);
+        PsiType type = mock(PsiType.class);
+
+        // stubs for handle local variable method
+        when(variable.getInitializer()).thenReturn(initializer);
+        when(variable.getName()).thenReturn("stringQuery");
+
+        // stubs for checkExpression method
+        when(initializer.getText()).thenReturn("datetime(2022-01-01)");
+        when(variable.getParent()).thenReturn(parentElement);
+        when(parentElement.getName()).thenReturn("stringQuery");
+
+        // stubs for handleMethodCall method
+        when(methodCall.getArgumentList()).thenReturn(argumentList);
+        when(argumentList.getExpressions()).thenReturn(arguments);
+        when(argument.resolve()).thenReturn(resolvedElement);
+        when(resolvedElement.getName()).thenReturn("stringQuery");
+
+        // stubs for isAzureClient method
+        when(methodCall.getMethodExpression()).thenReturn(referenceExpression);
+        when(referenceExpression.getQualifierExpression()).thenReturn(qualifierExpression);
+        when(qualifierExpression.resolve()).thenReturn(resolvedVariable);
+        when(resolvedVariable.getType()).thenReturn(type);
+        when(type.getCanonicalText()).thenReturn("com.azure");
+
+        // Visit the variable to store its name if it's a query string
+        mockVisitor.visitElement(variable);
+
+        // Visit the method call to check if the query variable is used and the method call is to an Azure client
+        mockVisitor.visitElement(methodCall);
+
+        // Verify that the problem was registered correctly for the method call
+        verify(mockHolder, times(1)).registerProblem(eq(methodCall), contains("KQL queries with time intervals in the query string detected."));
+    }
+
+    void verifyRegisterProblemWithPolyadicExpression() {
+
+        PsiPolyadicExpression polyadicExpression = mock(PsiPolyadicExpression.class);
+        PsiReferenceExpression operand = mock(PsiReferenceExpression.class);
+        PsiExpression[] operands = new PsiExpression[]{operand};
+        PsiVariable resolvedVariable = mock(PsiVariable.class);
+        PsiExpression initializer = mock(PsiExpression.class);
+        PsiElementFactory elementFactory = mock(PsiElementFactory.class);
+        Project project = mock(Project.class);
+        JavaPsiFacade javaPsiFacade = mock(JavaPsiFacade.class);
+        PsiExpression newExpression = mock(PsiExpression.class);
+        PsiLocalVariable parentElement = mock(PsiLocalVariable.class);
+
+        // stubs for handlePolyadicExpression method
+        when(polyadicExpression.copy()).thenReturn(polyadicExpression);
+        when(polyadicExpression.getText()).thenReturn("datetime(2022-01-01)");
+
+        // stubs for processPsiPolyadicExpressions method
+        when(polyadicExpression.getOperands()).thenReturn(operands);
+        when(operand.resolve()).thenReturn(resolvedVariable);
+        when(resolvedVariable.getInitializer()).thenReturn(initializer);
+        when(initializer.getText()).thenReturn("datetime(2022-01-01)");
+
+        when(polyadicExpression.getProject()).thenReturn(project);
+        when(JavaPsiFacade.getInstance(polyadicExpression.getProject())).thenReturn(javaPsiFacade);
+        when(javaPsiFacade.getElementFactory()).thenReturn(elementFactory);
+        when(elementFactory.createExpressionFromText(eq(initializer.getText()), isNull())).thenReturn(newExpression);
+
+        // stubs for checkExpression method
+        when(initializer.getText()).thenReturn("datetime(2022-01-01)");
+        when(polyadicExpression.getParent()).thenReturn(parentElement);
+        when(parentElement.getName()).thenReturn("stringQuery");
+
+        PsiMethodCallExpressionImpl methodCall = mock(PsiMethodCallExpressionImpl.class);
+        PsiExpressionList argumentList = mock(PsiExpressionList.class);
+        PsiReferenceExpression argument = mock(PsiReferenceExpression.class);
+        PsiExpression[] arguments = new PsiExpression[]{argument};
+        PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
+        PsiVariable resolvedElement = mock(PsiVariable.class);
+        PsiReferenceExpression qualifierExpression = mock(PsiReferenceExpression.class);
+        PsiType type = mock(PsiType.class);
+
+        // stubs for handleMethodCall method
+        when(methodCall.getArgumentList()).thenReturn(argumentList);
+        when(argumentList.getExpressions()).thenReturn(arguments);
+        when(argument.resolve()).thenReturn(resolvedElement);
+        when(resolvedElement.getName()).thenReturn("stringQuery");
+
+        // stubs for isAzureClient method
+        when(methodCall.getMethodExpression()).thenReturn(referenceExpression);
+        when(referenceExpression.getQualifierExpression()).thenReturn(qualifierExpression);
+        when(qualifierExpression.resolve()).thenReturn(resolvedVariable);
+        when(resolvedVariable.getType()).thenReturn(type);
+        when(type.getCanonicalText()).thenReturn("com.azure");
+
+        // Visit the variable to store its name if it's a query string
+        mockVisitor.visitElement(polyadicExpression);
+
+        // Visit the method call to check if the query variable is used and the method call is to an Azure client
+        mockVisitor.visitElement(methodCall);
+    }
 }
\ No newline at end of file

From a1a3b777fcc9a748e900f73a3d95ff5da8395bf3 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 2 Jul 2024 15:43:41 -0700
Subject: [PATCH 036/144] upgrade to tests

---
 .../buildtool/DynamicClientCreationCheck.java |  37 ++---
 .../DynamicClientCreationCheckTest.java       | 148 +++++++++++++++---
 2 files changed, 147 insertions(+), 38 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index 82d64d093d0..79200c3c39b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -144,29 +144,30 @@ private void checkClientCreation(PsiStatement blockChild) {
                     }
                 }
             }
+            else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check for the declaration statement
 
-            // This is a check for the declaration statement
-            PsiDeclarationStatement declarationStatement = (PsiDeclarationStatement) blockChild;
+                PsiDeclarationStatement declarationStatement = (PsiDeclarationStatement) blockChild;
 
-            // Traverse the declared elements within the declaration statement
-            for (PsiElement declaredElement : declarationStatement.getDeclaredElements()) {
+                // Traverse the declared elements within the declaration statement
+                for (PsiElement declaredElement : declarationStatement.getDeclaredElements()) {
 
-                // Check if the declared element is a local variable
-                if (!(declaredElement instanceof PsiLocalVariable)) {
-                    continue;
-                }
+                    // Check if the declared element is a local variable
+                    if (!(declaredElement instanceof PsiLocalVariable)) {
+                        continue;
+                    }
 
-                // Extract the local variable and its initializer
-                PsiLocalVariable localVariable = (PsiLocalVariable) declaredElement;
-                PsiExpression initializer = localVariable.getInitializer();
+                    // Extract the local variable and its initializer
+                    PsiLocalVariable localVariable = (PsiLocalVariable) declaredElement;
+                    PsiExpression initializer = localVariable.getInitializer();
 
-                if (!(initializer instanceof PsiMethodCallExpression)) {
-                    continue;
-                }
-                // Check if the initializer is a method call expression
-                PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) initializer;
-                if (isClientCreationMethod(methodCallExpression)) {
-                    holder.registerProblem(methodCallExpression, ANTI_PATTERN_MESSAGE);
+                    if (!(initializer instanceof PsiMethodCallExpression)) {
+                        continue;
+                    }
+                    // Check if the initializer is a method call expression
+                    PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) initializer;
+                    if (isClientCreationMethod(methodCallExpression)) {
+                        holder.registerProblem(methodCallExpression, ANTI_PATTERN_MESSAGE);
+                    }
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
index a406626fe58..bf48e7206d9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
@@ -3,17 +3,19 @@
 import com.intellij.psi.PsiAssignmentExpression;
 import com.intellij.psi.PsiBlockStatement;
 import com.intellij.psi.PsiCodeBlock;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiExpressionStatement;
 import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiLocalVariable;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiStatement;
 import com.intellij.psi.PsiType;
-import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DynamicClientCreationCheck.DynamicClientCreationVisitor;
-
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiMethodCallExpression;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DynamicClientCreationCheck.DynamicClientCreationVisitor;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
@@ -51,7 +53,7 @@ public void setup() {
      * This tests blocks of code that are a PsiExpressionStatement in the checkClientCreation method.
      */
     @Test
-    public void testDynamicClientCreationWithExpressionStatement() {
+    void testDynamicClientCreationWithExpressionStatement() {
 
         // assert visitor
         assertVisitor();
@@ -60,64 +62,170 @@ public void testDynamicClientCreationWithExpressionStatement() {
         String METHOD_NAME = "buildClient";
         String AZURE_PACKAGE = "com.azure.";
 
-        // verify register problem
-        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+        // verify register problem with assignment expression
+        verifyRegisterProblemWithAssignmentExpression(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+
+        // verify register problem with declaration statement
+        verifyRegisterProblemWithDeclarationStatement(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+    }
+
+    /**
+     * This is a test case that verifies the behavior of the DynamicClientCreationCheck when
+     * it encounters a code block that does not match the criteria for dynamic client creation.
+     * This involves a method call on an object that is not part of the com.azure package
+     */
+    @Test // unhappy path
+     void testDynamicClientCreationWithNonAzurePackage() {
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 0;
+        String METHOD_NAME = "buildClient";
+        String AZURE_PACKAGE = "com.Notazure.";
+
+        // verify register problem with assignment expression
+        verifyRegisterProblemWithAssignmentExpression(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+
+        // verify register problem with declaration statement
+        verifyRegisterProblemWithDeclarationStatement(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+    }
+
+    /**
+     * This is a test case that verifies the behavior of the DynamicClientCreationCheck when
+     * it encounters a code block that does not match the criteria for dynamic client creation.
+     * This involves a method call that is not part of the METHODS_TO_CHECK list.
+     */
+    @Test // unhappy path
+    void testDynamicClientCreationWithNonBuildMethod() {
+        // assert visitor
+        assertVisitor();
+
+        int NUMBER_OF_INVOCATIONS = 0;
+        String METHOD_NAME = "NotbuildClient";
+        String AZURE_PACKAGE = "com.azure.";
+
+        // verify register problem with assignment expression
+        verifyRegisterProblemWithAssignmentExpression(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+
+        // verify register problem with declaration statement
+        verifyRegisterProblemWithDeclarationStatement(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
     }
 
+    /**
+     * This helper method creates a new instance of the DynamicClientCreationVisitor class.
+     */
     JavaElementVisitor createVisitor() {
         boolean isOnTheFly = true;
         DynamicClientCreationVisitor mockVisitor = new DynamicClientCreationVisitor(mockHolder, isOnTheFly);
         return mockVisitor;
     }
 
+    /**
+     * This helper method asserts that the mockVisitor is not null and is an instance of the JavaElementVisitor class.
+     */
     void assertVisitor() {
         // assert visitor
         assertNotNull(mockVisitor);
         assertTrue(mockVisitor instanceof JavaElementVisitor);
     }
 
-    void verifyRegisterProblem(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_OF_INVOCATIONS) {
+    /**
+     * This method verifies that a problem is registered when a client creation method is found
+     * building a client from the com.azure package in an assignment expression.
+     *
+     * @param METHOD_NAME
+     * @param AZURE_PACKAGE
+     * @param NUMBER_OF_INVOCATIONS
+     */
+    void verifyRegisterProblemWithAssignmentExpression(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_OF_INVOCATIONS) {
 
         // main method
         PsiStatement statement = mock(PsiStatement.class);
-        PsiStatement body = mock(PsiStatement.class);
-        PsiBlockStatement blockStatement = mock(PsiBlockStatement.class);
+        PsiBlockStatement body = mock(PsiBlockStatement.class);
         PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
         PsiExpressionStatement blockChild = mock(PsiExpressionStatement.class);
         PsiStatement[] blockStatements = new PsiStatement[] { blockChild };
 
-        // check client creation
+        // checkClientCreation method
         PsiAssignmentExpression expression = mock(PsiAssignmentExpression.class);
         PsiMethodCallExpression rhs = mock(PsiMethodCallExpression.class);
 
-        // isClientCreation method
-        PsiMethodCallExpression methodCallExpression = mock(PsiMethodCallExpression.class);
+        // isClientCreationMethod
         PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
         PsiExpression qualifierExpression = mock(PsiExpression.class);
         PsiType type = mock(PsiType.class);
 
-
         // main method
-        when(mockElement.getBody()).thenReturn(blockStatement);
-        when(blockStatement.getCodeBlock()).thenReturn(codeBlock);
+        when(mockElement.getBody()).thenReturn(body);
+        when(body.getCodeBlock()).thenReturn(codeBlock);
         when(codeBlock.getStatements()).thenReturn(blockStatements);
 
-        // check client creation
+        // checkClientCreation method
         when(blockChild.getExpression()).thenReturn(expression);
         when(expression.getRExpression()).thenReturn(rhs);
 
-        // isClientCreation method
-        when(methodCallExpression.getMethodExpression()).thenReturn(methodExpression);
+        // isClientCreationMethod
+        when(rhs.getMethodExpression()).thenReturn(methodExpression);
+        when(methodExpression.getReferenceName()).thenReturn(METHOD_NAME);
+        when(methodExpression.getQualifierExpression()).thenReturn(qualifierExpression);
+        when(qualifierExpression.getType()).thenReturn(type);
+        when(qualifierExpression.getType().getCanonicalText()).thenReturn(AZURE_PACKAGE);
+
+        mockVisitor.visitForStatement(mockElement);
+
+        //  Verify problem is registered
+        verify(mockHolder,
+                times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(rhs),
+                Mockito.contains("Dynamic client creation detected. Create a single client instance and reuse it instead."));
+    }
+
+    /**
+     * This method verifies that a problem is registered when a client creation method is found
+     * building a client from the com.azure package in a declaration statement.
+     * @param METHOD_NAME
+     * @param AZURE_PACKAGE
+     * @param NUMBER_OF_INVOCATIONS
+     */
+    void verifyRegisterProblemWithDeclarationStatement(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_OF_INVOCATIONS) {
+
+        // main method
+        PsiStatement statement = mock(PsiStatement.class);
+        PsiBlockStatement body = mock(PsiBlockStatement.class);
+        PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
+        PsiDeclarationStatement blockChild = mock(PsiDeclarationStatement.class);
+        PsiStatement[] blockStatements = new PsiStatement[] { blockChild };
+
+        // checkClientCreation method
+        PsiLocalVariable declaredElement = mock(PsiLocalVariable.class);
+        PsiElement[] declaredElements = new PsiElement[] { declaredElement };
+        PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
+
+        // isClientCreationMethod
+        PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
+        PsiExpression qualifierExpression = mock(PsiExpression.class);
+        PsiType type = mock(PsiType.class);
+
+        // main method
+        when(mockElement.getBody()).thenReturn(body);
+        when(body.getCodeBlock()).thenReturn(codeBlock);
+        when(codeBlock.getStatements()).thenReturn(blockStatements);
+
+        // checkClientCreation method
+        when(blockChild.getDeclaredElements()).thenReturn(declaredElements);
+        when(declaredElement.getInitializer()).thenReturn(initializer);
+
+        // isClientCreationMethod
+        when(initializer.getMethodExpression()).thenReturn(methodExpression);
         when(methodExpression.getReferenceName()).thenReturn(METHOD_NAME);
         when(methodExpression.getQualifierExpression()).thenReturn(qualifierExpression);
         when(qualifierExpression.getType()).thenReturn(type);
-        when(type.getCanonicalText()).thenReturn(AZURE_PACKAGE);
+        when(qualifierExpression.getType().getCanonicalText()).thenReturn(AZURE_PACKAGE);
 
         mockVisitor.visitForStatement(mockElement);
 
-        // Verify problem is registered
+        //  Verify problem is registered
         verify(mockHolder,
-                times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(methodCallExpression),
+                times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(initializer),
                 Mockito.contains("Dynamic client creation detected. Create a single client instance and reuse it instead."));
     }
 }

From c66540a78bbc3e718e15d6e8da028c13de021be5 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 2 Jul 2024 19:11:51 -0700
Subject: [PATCH 037/144] make base class to check for discouraged clients

---
 .../azure-toolkit-for-intellij/.gitignore     |  3 +-
 .../azure-toolkit-for-intellij/.idea/misc.xml | 15 ++--
 .../azure-intellij-plugin-azure-sdk/README.md | 34 ++++++--
 ...java => DetectDiscouragedClientCheck.java} | 54 +++++++------
 .../azure-intellij-plugin-azure-sdk.xml       |  8 +-
 .../main/resources/META-INF/ruleConfigs.json  | 13 +++-
 ... => DetectDiscouragedClientCheckTest.java} | 77 ++++++++++++++-----
 7 files changed, 135 insertions(+), 69 deletions(-)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{ServiceBusReceiverAsyncClientCheck.java => DetectDiscouragedClientCheck.java} (57%)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{ServiceBusReceiverAsyncClientCheckTest.java => DetectDiscouragedClientCheckTest.java} (51%)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index e297894a61e..1043f4e0000 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -49,4 +49,5 @@ gen-external-apklibs/
 /azure-intellij-plugin-azure-sdk/.idea/
 
 # IntelliJ
-.idea/
\ No newline at end of file
+.idea/
+/.idea/
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
index 57337953a0f..86224377976 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
@@ -4,19 +4,12 @@
   <component name="FrameworkDetectionExcludesConfiguration">
     <file type="web" url="file://$PROJECT_DIR$" />
   </component>
-  <component name="MavenProjectsManager">
-    <option name="originalFiles">
-      <list>
-        <option value="$PROJECT_DIR$/../../Utils/pom.xml" />
-      </list>
-    </option>
-  </component>
   <component name="NullableNotNullManager">
     <option name="myDefaultNullable" value="javax.annotation.Nullable" />
     <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
     <option name="myNullables">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
           <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
@@ -32,12 +25,14 @@
           <item index="12" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.Nullable" />
           <item index="13" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.Nullable" />
           <item index="14" class="java.lang.String" itemvalue="io.reactivex.annotations.Nullable" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.Nullable" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nullable" />
         </list>
       </value>
     </option>
     <option name="myNotNulls">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
           <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
@@ -53,6 +48,8 @@
           <item index="12" class="java.lang.String" itemvalue="lombok.NonNull" />
           <item index="13" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.NonNull" />
           <item index="14" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.NonNull" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.NonNull" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nonnull" />
         </list>
       </value>
     </option>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 191fd3e94f2..410936314ce 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -16,10 +16,32 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 
 ## Rules
-1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
-- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
-
-- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
+1. ### Storage Upload without Length Check
+- **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
 - **Severity: INFO**
-- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
+- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
+
+
+### 2. Use These Encouraged Clients Instead of Their Corresponding Discouraged Clients
+
+#### a. Use **`ServiceBusProcessorClient`** instead of **`ServiceBusReceiverAsyncClient`**
+#### b. Use **`EventProcessorClient`** instead of **`EventHubConsumerAsyncClient`**
+
+### Anti-pattern:
+- Both `ServiceBusReceiverAsyncClient` and `EventHubConsumerAsyncClient` are low-level APIs. They provide fine-grained control over message/event handling but require a high level of proficiency in Reactive programming.
+- Due to their complexity and the need for a deep understanding of Reactive programming, there is a higher risk of these clients being used incorrectly or inefficiently, especially by developers who are not familiar with Reactive paradigms.
+
+### Issue:
+
+#### a. **ServiceBusReceiverAsyncClient**
+- **Anti-pattern**: The `ServiceBusReceiverAsyncClient` is considered an anti-pattern because it demands detailed handling of messages, which can be overly complex and unnecessary for most common use cases.
+    - **Severity: WARNING**
+    - **Recommendation**: Instead of using `ServiceBusReceiverAsyncClient`, it is recommended to use `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption, making it a more suitable option for most developers and scenarios.
+    - Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient).
+
+#### b. **EventHubConsumerAsyncClient**
+- **Anti-pattern**: The `EventHubConsumerAsyncClient` is considered an anti-pattern due to its low-level nature and the complexity involved in event handling.
+    - **Severity: WARNING**
+    - **Recommendation**: Instead of using `EventHubConsumerAsyncClient`, it is advised to use `EventProcessorClient`. The `EventProcessorClient` provides a higher-level abstraction that simplifies event processing, making it the preferred choice for most developers.
+    - Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.eventhubs.eventprocessorclient?view=azure-java-stable).
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
similarity index 57%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
index 3c03a099917..fdf5a41a6e6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
@@ -9,27 +9,27 @@
 import org.json.JSONObject;
 
 import java.io.IOException;
-import java.util.Arrays;
-import java.util.List;
+import java.util.HashMap;
+import java.util.Map;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
- * This class extends the LocalInspectionTool to check for the use of ServiceBusReceiverAsyncClient
- * in the code and suggests using ServiceBusProcessorClient instead.
+ * This class extends the LocalInspectionTool to check for the use of discouraged clients
+ * in the code and suggests using other clients instead.
  * The client data is loaded from the configuration file and the client name is checked against the
  * discouraged client name. If the client name matches, a problem is registered with the suggestion message.
  */
-public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
-    private static List<String> CLIENT_DATA = null;
+public class DetectDiscouragedClientCheck extends LocalInspectionTool {
+
+    private static Map<String, String> CLIENT_DATA;
 
     // Define constants for string literals
-    private static final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
-    private static final String RULE_NAME = "ServiceBusReceiverAsyncClientCheck";
+    private static final String RULE_NAME = "DetectDiscouragedClientCheck";
     private static final String SUGGESTION_KEY = "antipattern_message";
     private static final String CLIENT_NAME_KEY = "client_name";
-    private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
+    private static final Logger LOGGER = Logger.getLogger(DetectDiscouragedClientCheck.class.getName());
 
     static {
         try {
@@ -39,7 +39,6 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
         }
     }
 
-
     /**
      * This method builds a visitor to check for the discouraged client name in the code.
      * If the client name matches the discouraged client, a problem is registered with the suggestion message.
@@ -59,33 +58,38 @@ public void visitTypeElement(PsiTypeElement element) {
                 // Check if the element is an instance of PsiTypeElement
                 if (element instanceof PsiTypeElement && element.getType() != null) {
 
-                    if (CLIENT_DATA.isEmpty()) {
-                        return;
-                    }
-                    String clientName = CLIENT_DATA.get(0);
-                    String suggestion = CLIENT_DATA.get(1);
+                    String elementType = element.getType().getPresentableText();
+
+                    // Use the map to get the suggestion message
+                    String suggestion = CLIENT_DATA.get(elementType);
 
-                    // Register a problem if the client used matches the discouraged client
-                    if (element.getType().getPresentableText().equals(clientName)) {
+                    // Register a problem if the client used matches a discouraged client
+                    if (suggestion != null) {
                         holder.registerProblem(element, suggestion);
                     }
                 }
             }
-
         };
     }
 
     /**
      * Loading the client data from the configuration file.
-     *
-     * @return List of client name and suggestion message
+     * The client data is stored in a JSON object with the client name as the key and the suggestion message as the value.
+     * @return
      */
-    static List<String> getClientToCheck() throws IOException {
 
-        final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
-        final String clientName = jsonObject.getJSONObject(RULE_NAME).getString(CLIENT_NAME_KEY);
-        final String suggestion= jsonObject.getJSONObject(RULE_NAME).getString(SUGGESTION_KEY);
-        return Arrays.asList(clientName, suggestion);
+    static Map<String, String> getClientToCheck() throws IOException {
+        JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+        JSONObject clientData = jsonObject.getJSONObject(RULE_NAME);
+
+        Map<String, String> clientToCheckMap = new HashMap<>();
 
+        // iterate over the keys in the JSON object to get clients to check and their corresponding messages.
+        for (String key : clientData.keySet()) {
+            String clientName = clientData.getJSONObject(key).getString(CLIENT_NAME_KEY);
+            String suggestion = clientData.getJSONObject(key).getString(SUGGESTION_KEY);
+            clientToCheckMap.put(clientName, suggestion);
+        }
+        return clientToCheckMap;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 1b9efeb66e2..082f2940699 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -40,15 +40,15 @@
 
         <localInspection
                 language="JAVA"
-                shortName="ServiceBusReceiverAsyncClientCheck"
-                displayName="Low level ServiceBusReceiverAsyncClient check"
+                shortName="DetectDiscouragedClientCheck"
+                displayName="Detect Discouraged Client Check check"
                 groupName="Azure SDK"
                 enabledByDefault="true"
                 level="WARNING"
-                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedClientCheck">
 
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedClientCheck
             </class>
         </localInspection>
     </extensions>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d0361d1b107..1c386ca9adf 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -6,9 +6,14 @@
     ],
     "antipattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
   },
-
-  "ServiceBusReceiverAsyncClientCheck": {
-    "client_name": "ServiceBusReceiverAsyncClient",
-    "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+  "DetectDiscouragedClientCheck": {
+    "ServiceBusReceiverAsyncClientCheck": {
+      "client_name": "ServiceBusReceiverAsyncClient",
+      "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+    },
+    "EventHubConsumerAsyncClientCheck": {
+      "client_name": "EventHubConsumerAsyncClient",
+      "antipattern_message": "Use of EventHubConsumerAsyncClient detected. Use EventProcessorClient instead."
+    }
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
similarity index 51%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
index ca765b3b5da..5e0e43453f8 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
@@ -30,9 +30,13 @@
  * 3. final ServiceBusReceiverAsyncClient autoCompleteReceiver =
  *             toClose(getReceiverBuilder(false, entityType, index, false)
  *                 .buildAsyncClient());
+ *
+ * 4. final EventHubConsumerAsyncClient consumerClient = partitionPump.getClient();
+ * 5. EventHubConsumerAsyncClient eventHubConsumer = eventHubClientBuilder.buildAsyncClient()
+ *                 .createConsumer(claimedOwnership.getConsumerGroup(), prefetch, true);
  */
 
-public class ServiceBusReceiverAsyncClientCheckTest {
+public class DetectDiscouragedClientCheckTest {
 
     // Create a mock ProblemsHolder to be used in the test
     @Mock
@@ -55,16 +59,42 @@ public void setUp() {
         mockTypeElement = mock(PsiTypeElement.class);
     }
 
+    /**
+     * Test that a problem is registered when the client name is ServiceBusReceiverAsyncClient.
+     *
+     * This test is important because it verifies that the code registers a problem
+     * when the client name is ServiceBusReceiverAsyncClient.
+     */
     @Test
     public void testProblemRegisteredWhenUsingServiceBusReceiverAsyncClient() {
         // Assert
         assertVisitor();
 
-        String CLIENT_TO_CHECK = "ServiceBusReceiverAsyncClient";
+        String clientToCheck = "ServiceBusReceiverAsyncClient";
+        String suggestionMessage = "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead.";
 
         // Visit Type Element
-        int NUMBER_OF_INVOCATIONS = 1;  // Number of times registerProblem should be called
-        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS, CLIENT_TO_CHECK);
+        int numberOfInvocations = 1;  // Number of times registerProblem should be called
+        visitTypeElement(mockTypeElement, numberOfInvocations, clientToCheck, suggestionMessage);
+    }
+
+    /**
+     * Test that a problem is registered when the client name is EventHubConsumerAsyncClient.
+     *
+     * This test is important because it verifies that the code registers a problem
+     * when the client name is EventHubConsumerAsyncClient.
+     */
+    @Test
+    public void testProblemRegisteredWhenUsingEventHubConsumerAsyncClientCheck() {
+        // Assert
+        assertVisitor();
+
+        String clientToCheck = "EventHubConsumerAsyncClient";
+        String suggestionMessage = "Use of EventHubConsumerAsyncClient detected. Use EventProcessorClient instead.";
+
+        // Visit Type Element
+        int numberOfInvocations = 1;  // Number of times registerProblem should be called
+        visitTypeElement(mockTypeElement, numberOfInvocations, clientToCheck, suggestionMessage);
     }
 
     /**
@@ -75,13 +105,15 @@ public void testProblemRegisteredWhenUsingServiceBusReceiverAsyncClient() {
      */
 
     @Test
-    void testProblemNotRegisteredWhenCheckingForDiifferentClient() {
+    public void testProblemNotRegisteredWhenCheckingForDiifferentClient() {
 
-        String CLIENT_TO_CHECK = "ServiceBusProcessorClient";
+        String clientToCheck = "ServiceBusProcessorClient";
 
         // Visit Type Element
-        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
-        visitTypeElement(mockTypeElement, NUMBER_OF_INVOCATIONS, CLIENT_TO_CHECK);
+        int numberOfInvocations = 0;  // Number of times registerProblem should be called
+
+        String suggestionMessage = "";
+        visitTypeElement(mockTypeElement, numberOfInvocations, clientToCheck, suggestionMessage);
 
     }
 
@@ -89,21 +121,27 @@ void testProblemNotRegisteredWhenCheckingForDiifferentClient() {
      * Test that a problem is not registered when the PsiTypeElement is null and the client name is empty.
      */
     @Test
-    void testProblemNotRegisteredWhenClientIsEmpty() {
+    public void testProblemNotRegisteredWhenClientIsEmpty() {
         // Visit Type Element
-        int NUMBER_OF_INVOCATIONS = 0;  // Number of times registerProblem should be called
-        String CLIENT_TO_CHECK = "";
-        visitTypeElement(null, NUMBER_OF_INVOCATIONS, "");
+        int numberOfInvocations = 0;  // Number of times registerProblem should be called
+        String clientToCheck = "";
+        String suggestionMessage = "";
+        visitTypeElement(null, numberOfInvocations, clientToCheck, suggestionMessage);
     }
 
-    // Create a visitor by calling the buildVisitor method of ServiceBusReceiverAsyncClientCheck
+    /** Create a visitor by calling the buildVisitor method of ServiceBusReceiverAsyncClientCheck
+     * and return the visitor.
+     * @return PsiElementVisitor
+     */
     private PsiElementVisitor createVisitor() {
-        ServiceBusReceiverAsyncClientCheck check = new ServiceBusReceiverAsyncClientCheck();
+        DetectDiscouragedClientCheck check = new DetectDiscouragedClientCheck();
         boolean isOnTheFly = true;
         return check.buildVisitor(mockHolder, isOnTheFly);
     }
 
-    // Assert that the visitor is not null and is an instance of JavaElementVisitor
+    /** Assert that the visitor is not null and is an instance of JavaElementVisitor
+     * to ensure that the visitor is created correctly.
+     */
     private void assertVisitor() {
         assertNotNull(mockVisitor);
         assertTrue(mockVisitor instanceof JavaElementVisitor);
@@ -112,17 +150,16 @@ private void assertVisitor() {
     /** Visit a Type Element and verify that a problem was registered
      * when the ServiceBusReceiverAsyncClient is used.
      * @param typeElement The PsiTypeElement to visit
-     * @param NUMBER_OF_INVOCATIONS The number of times registerProblem should be called
+     * @param numberOfInvocations The number of times registerProblem should be called
      */
-    private void visitTypeElement(PsiTypeElement typeElement, int NUMBER_OF_INVOCATIONS, String CLIENT_TO_CHECK) {
+    private void visitTypeElement(PsiTypeElement typeElement, int numberOfInvocations, String clientToCheck, String suggestionMessage) {
 
         PsiType mockType = mock(PsiType.class);
 
         when(mockTypeElement.getType()).thenReturn(mockType);
-        when(mockType.getPresentableText()).thenReturn(CLIENT_TO_CHECK);
+        when(mockType.getPresentableText()).thenReturn(clientToCheck);
 
         ((JavaElementVisitor) mockVisitor).visitTypeElement(mockTypeElement);
-        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains("Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."));
+        verify(mockHolder, times(numberOfInvocations)).registerProblem((Mockito.eq(mockTypeElement)), Mockito.contains(suggestionMessage));
     }
-
 }
\ No newline at end of file

From 5ce260269087b103c86474eb5f3d33cc2500d1d1 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 3 Jul 2024 10:03:34 -0700
Subject: [PATCH 038/144] address PR comments

---
 .../sdk/buildtool/LoadJsonConfigFile.java     |  2 -
 .../UseOfBlockOnAsyncClientsCheck.java        |  8 ++-
 .../main/resources/META-INF/ruleConfigs.json  |  8 +--
 .../UseOfBlockOnAsyncClientsCheckTest.java    | 60 ++++++++++---------
 4 files changed, 42 insertions(+), 36 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
index cddb05bcf7b..3f4ca0d3c1b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -41,8 +41,6 @@ public static synchronized LoadJsonConfigFile getInstance() throws IOException {
     // Load the JSON object from the configuration file
     private void loadJsonObject() throws IOException {
 
-        System.out.println("Start loading JSON configuration");
-
         try (InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
             if (inputStream == null) {
                 throw new FileNotFoundException("Configuration file not found");
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
index 1d5a664817d..6efc4eee5e1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -115,7 +115,7 @@ private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall)
 
                     // Check for common async/reactive types directly in the list asyncReturnTypes
                     for (String asyncReturnType : ASYNC_RETURN_TYPES) {
-                        if (typeName.startsWith(asyncReturnType)) {
+                        if (typeName.contains(asyncReturnType)) {
                             return true;
                         }
                     }
@@ -145,7 +145,11 @@ private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
             return false;
         }
 
-        // helper method to load config from json
+        /** helper method to load config from json
+         *
+         * @return Map<String, Object>
+         * @throws IOException
+         */
         private static  Map<String, Object> getAsyncReturnTypesToCheck() throws IOException {
 
             //load json object
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index f6a75440d55..ecc2a3f7065 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -14,11 +14,9 @@
 
   "UseOfBlockOnAsyncClientsCheck": {
     "async_return_types_to_check": [
-      "reactor.core.publisher.Mono",
-      "reactor.core.publisher.Flux",
-      "com.azure.core.util.paging.PagedFlux",
-      "com.azure.core.util.polling.PollerFlux"
+      "Flux",
+        "Mono"
     ],
-    "antipattern_message": "Use of block() on async clients detected. Switch to synchronous APIs instead."
+    "antipattern_message": "Use of block methods on asynchronous clients detected. Switch to synchronous APIs instead."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
index 649d8c87408..1e87a9618fa 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
@@ -68,13 +68,12 @@ public void testUseOfBlockOnAsyncClientsVisitor() {
         // assert visitor
         assertVisitor();
 
-        int NUMBER_OF_INVOCATIONS = 1;
-        String METHOD_NAME = "block";
-        String AZURE_PACKAGE = "com.azure.";
+        int numberOfInvocations = 1;
+        String methodName = "block";
+        String packageName = "com.azure.";
 
         // verify register problem
-        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
-
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
     /**
@@ -87,12 +86,12 @@ public void testUseOfDifferentBlockOnAsyncClientsVisitor() {
         // assert visitor
         assertVisitor();
 
-        int NUMBER_OF_INVOCATIONS = 1;
-        String METHOD_NAME = "blockOptional";
-        String AZURE_PACKAGE = "com.azure.";
+        int numberOfInvocations = 1;
+        String methodName = "blockOptional";
+        String packageName = "com.azure.";
 
         // verify register problem
-        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
     /**
@@ -105,12 +104,12 @@ public void testUseOfBlockOnAsyncClientsVisitorWithNonAzureClient() {
         // assert visitor
         assertVisitor();
 
-        int NUMBER_OF_INVOCATIONS = 0;
-        String METHOD_NAME = "blockFirst";
-        String AZURE_PACKAGE = "com.notAzure.";
+        int numberOfInvocations = 0;
+        String methodName = "blockFirst";
+        String packageName = "com.notAzure.";
 
         // verify register problem
-        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
     /**
@@ -123,29 +122,37 @@ public void testVisitOnDifferentMethodCall() {
         // assert visitor
         assertVisitor();
 
-        int NUMBER_OF_INVOCATIONS = 0;
-        String METHOD_NAME = "nonBlockingMethod";
-        String AZURE_PACKAGE = "com.azure.";
+        int numberOfInvocations = 0;
+        String methodName = "nonBlockingMethod";
+        String packageName = "com.azure.";
 
         // verify register problem
-        verifyRegisterProblem(METHOD_NAME, AZURE_PACKAGE, NUMBER_OF_INVOCATIONS);
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
-    // Create a visitor object for the test
-    JavaElementVisitor createVisitor() {
+    /** Create a visitor object for the test
+     * @return JavaElementVisitor
+     */
+    private JavaElementVisitor createVisitor() {
         boolean isOnTheFly = true;
         UseOfBlockOnAsyncClientsVisitor visitor = new UseOfBlockOnAsyncClientsCheck.UseOfBlockOnAsyncClientsVisitor(mockHolder, isOnTheFly);
         return visitor;
     }
 
-    // Assert that the visitor object is not null and is an instance of JavaElementVisitor
-    void assertVisitor() {
+    /** Assert that the visitor object is not null and is an instance of JavaElementVisitor
+     * @return void
+     */
+    private void assertVisitor() {
         assertNotNull(mockVisitor);
         assertTrue(mockVisitor instanceof JavaElementVisitor);
     }
 
-    // Verify that the registerProblem method is called the expected number of times
-    void verifyRegisterProblem(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_OF_INVOCATIONS) {
+    /** Verify that the registerProblem method is called the expected number of times
+     * @param methodName The name of the method call -- used to determine if the method call is a block method
+     * @param packageName The package name of the class containing the method call -- used to determine if the client is an Azure SDK client
+     * @param numberOfInvocations Number of times registerProblem should be called
+     */
+    private void verifyRegisterProblem(String methodName, String packageName, int numberOfInvocations) {
 
         // Arrange
         PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
@@ -154,22 +161,21 @@ void verifyRegisterProblem(String METHOD_NAME, String AZURE_PACKAGE, int NUMBER_
         PsiClass containingClass = mock(PsiClass.class);
         PsiTreeUtil mockTreeUtil = mock(PsiTreeUtil.class);
 
-
         when(mockElement.getMethodExpression()).thenReturn(referenceExpression);
-        when(referenceExpression.getReferenceName()).thenReturn(METHOD_NAME);
+        when(referenceExpression.getReferenceName()).thenReturn(methodName);
 
         when(referenceExpression.getQualifierExpression()).thenReturn(expression);
         when(expression.getType()).thenReturn(type);
         when(type.getCanonicalText()).thenReturn("reactor.core.publisher.Flux");
 
         when(mockTreeUtil.getParentOfType(mockElement, PsiClass.class)).thenReturn(containingClass);
-        when(containingClass.getQualifiedName()).thenReturn(AZURE_PACKAGE);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
 
         // Act
         mockVisitor.visitMethodCallExpression(mockElement);
 
         // Verify registerProblem is not called
-        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of block() on async clients detected. Switch to synchronous APIs instead."));
+        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of block methods on asynchronous clients detected. Switch to synchronous APIs instead."));
     }
 }
 

From d21bd9ac30a8df17fc0f7291ab56f787bc115d21 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 3 Jul 2024 14:27:09 -0700
Subject: [PATCH 039/144] address PR comments

---
 .../sdk/buildtool/ConnectionStringCheck.java  | 120 ++++++++++--------
 .../sdk/buildtool/LoadJsonConfigFile.java     | 108 +++++++++++++++-
 .../buildtool/ConnectionStringCheckTest.java  |  45 ++++---
 3 files changed, 203 insertions(+), 70 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
index 75466b09042..9d44432a0f3 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -11,11 +11,8 @@
 import com.intellij.psi.PsiReferenceExpression;
 
 import org.jetbrains.annotations.NotNull;
-import org.json.JSONObject;
 
 import java.io.IOException;
-import java.util.Arrays;
-import java.util.List;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -25,67 +22,88 @@
  */
 public class ConnectionStringCheck extends LocalInspectionTool {
 
-    private static List <String> ruleConfigurations;
-    private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
-
-
-    // Load the rule configurations from the configuration file
-    static {
-        try {
-            ruleConfigurations = loadRuleConfigurations();
-        } catch (IOException e) {
-            LOGGER.log(Level.SEVERE, "Error loading client data", e);
-        }
-    }
-
-    private static final String RULE_NAME = "ConnectionStringCheck";
-    private static final String METHOD_TO_CHECK_KEY = "method_to_check";
-    private static final String SUGGESTION_KEY = "antipattern_message";
 
+    /**
+     * This method builds the visitor for the inspection tool.
+     * @param holder ProblemsHolder to register problems
+     * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type.
+     * @return
+     */
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new JavaElementVisitor() {
+        return new ConnectionStringVisitor(holder, isOnTheFly);
+    }
 
-            @Override
-            public void visitElement(@NotNull PsiElement element) {
-                super.visitElement(element);
+    /**
+     * This class extends the JavaElementVisitor to visit the elements in the code.
+     * It checks if the method call is a connection string call and if the class is an Azure client.
+     * If both conditions are met, a problem is registered with the suggestion message.
+     */
+    public static class ConnectionStringVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+        private static final Logger LOGGER = Logger.getLogger(ConnectionStringCheck.class.getName());
+        private static String METHOD_TO_CHECK = "";
+        private static String SUGGESTION = "";
+        private static String AZURE_PACKAGE_NAME = "";
+
+        // Load the JSON configuration file to get the method to check and the suggestion message
+        static {
+            String ruleName = "ConnectionStringCheck";
+
+            try {
+                LoadJsonConfigFile config = LoadJsonConfigFile.getInstance();
+                METHOD_TO_CHECK = config.getMethodToCheck(ruleName);
+                SUGGESTION = config.getSuggestionMessage(ruleName);
+            } catch (IOException e) {
+                // make a descriptive message
+                LOGGER.log(Level.SEVERE, "Failed to load JSON configuration for rule '" + ruleName + "' from expected path: " + LoadJsonConfigFile.CONFIG_FILE_PATH, e);            }
+        }
+
+        /**
+         * Constructor to initialize the visitor with the holder and isOnTheFly flag.
+         * @param holder     ProblemsHolder
+         * @param isOnTheFly boolean
+         */
+        public ConnectionStringVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
 
-                String METHOD_TO_CHECK = ruleConfigurations.get(0);
-                String SUGGESTION = ruleConfigurations.get(1);
+        /**
+         * This method visits the element in the code.
+         * It checks if the method call is a connection string call and if the class is an Azure client.
+         * If both conditions are met, a problem is registered with the suggestion message.
+         * @param element PsiElement
+         */
+        @Override
+        public void visitElement(@NotNull PsiElement element) {
+            super.visitElement(element);
 
-                // check if an element is an azure client
-                if (element instanceof PsiMethodCallExpression) {
+            // check if an element is an azure client
+            if (element instanceof PsiMethodCallExpression) {
 
-                    PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) element;
-                    PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
+                PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) element;
+                PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
 
-                    // resolvedMethod is the method that is being called
-                    PsiElement resolvedMethod = methodExpression.resolve();
+                // resolvedMethod is the method that is being called
+                PsiElement resolvedMethod = methodExpression.resolve();
 
-                    // check if the method is a connectionString call
-                    if (resolvedMethod != null && resolvedMethod instanceof PsiElement && ((PsiMethod) resolvedMethod).getName().equals(METHOD_TO_CHECK)) {
-                        PsiMethod method = (PsiMethod) resolvedMethod;
+                // check if the method is a connectionString call
+                if (resolvedMethod != null && resolvedMethod instanceof PsiElement && ((PsiMethod) resolvedMethod).getName().equals(METHOD_TO_CHECK)) {
+                    PsiMethod method = (PsiMethod) resolvedMethod;
 
-                        // containingClass is the client class that is being called
-                        PsiClass containingClass = method.getContainingClass();
+                    // containingClass is the client class that is being called. check if the class is an azure client
+                    PsiClass containingClass = method.getContainingClass();
 
-                        // check if the class is an azure client
-                        if (containingClass != null && containingClass.getQualifiedName() != null && containingClass.getQualifiedName().startsWith("com.azure")) {
-                            holder.registerProblem(element, SUGGESTION);
-                        }
+                    // compare the package name of the containing class to the azure package name from the configuration file
+                    if (containingClass != null && containingClass.getQualifiedName() != null && containingClass.getQualifiedName().startsWith(LoadJsonConfigFile.PACKAGE_NAME)) {
+                        holder.registerProblem(element, SUGGESTION);
                     }
                 }
             }
-        };
-    };
-
-    // Load the rule configurations from the configuration file
-    private static List<String> loadRuleConfigurations() throws IOException {
-
-        final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
-        String methodToCheck = jsonObject.getJSONObject(RULE_NAME).getString(METHOD_TO_CHECK_KEY);
-        String antipatternMessage = jsonObject.getJSONObject(RULE_NAME).getString(SUGGESTION_KEY);
-        return Arrays.asList(methodToCheck, antipatternMessage);
+        }
     }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
index 3f4ca0d3c1b..e8e39b86c5a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -5,7 +5,11 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.stream.Collectors;
+
+import org.json.JSONArray;
 import org.json.JSONObject;
 
 /**
@@ -23,14 +27,18 @@ public class LoadJsonConfigFile {
     private static LoadJsonConfigFile instance;
     private JSONObject jsonObject;
 
-    final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
+    static final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
+    static final String PACKAGE_NAME = "com.azure";
 
     // The constructor is private, so it can't be called from outside the class
     private LoadJsonConfigFile() throws IOException {
         loadJsonObject();
     }
 
-    // The getInstance method returns the single instance of the class, creating it if it doesn't exist
+    /** The getInstance method returns the single instance of the class, creating it if it doesn't exist
+     * @return LoadJsonConfigFile
+     * @throws IOException
+     */
     public static synchronized LoadJsonConfigFile getInstance() throws IOException {
         if (instance == null) {
             instance = new LoadJsonConfigFile();
@@ -38,7 +46,9 @@ public static synchronized LoadJsonConfigFile getInstance() throws IOException {
         return instance;
     }
 
-    // Load the JSON object from the configuration file
+    /** Load the JSON object from the configuration file
+     * @throws IOException
+     */
     private void loadJsonObject() throws IOException {
 
         try (InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
@@ -56,8 +66,98 @@ private void loadJsonObject() throws IOException {
         }
     }
 
-    // The getJsonObject method returns the loaded JSON object
+    /**The getJsonObject method returns the loaded JSON object
+     * @return JSONObject
+     */
     public JSONObject getJsonObject() {
         return jsonObject;
     }
+
+
+    /** Method to get the value for a given rule name and key as an Object
+     * If the rule name exists and has the key, return the value
+     * @param ruleName
+     * @param key
+     * @return Object
+     */
+    private Object getConfigValue(String ruleName, String key) {
+        if (jsonObject.has(ruleName)) {
+            JSONObject ruleConfig = jsonObject.getJSONObject(ruleName);
+            if (ruleConfig.has(key)) {
+                return ruleConfig.get(key);
+            }
+        }
+        return null;
+    }
+
+    /** Method to get the methods to check for a given rule name, which is a List of Strings
+     * @param ruleName
+     * @return List<String>
+     */
+    public List<String> getMethodsToCheck(String ruleName) {
+        String key = "methods_to_check";
+        Object value = getConfigValue(ruleName, key);
+        return processMethodsToCheck(value);
+    }
+
+    /** Method to get the method to check for a given rule name, which is a String
+     * If the rule name exists and has the key, return the value
+     * @param ruleName
+     * @return String
+     */
+    public String getMethodToCheck(String ruleName) {
+        String key = "method_to_check";
+        return (String) getConfigValue(ruleName, key);
+    }
+
+    /** Method to get the client name for a given rule name
+     * @param ruleName
+     * @return
+     */
+    public String getClientName(String ruleName) {
+        String key = "client_name";
+        return (String) getConfigValue(ruleName, key);
+    }
+
+    /** Method to get the suggestion message for a given rule name
+     * @param ruleName
+     * @return String
+     */
+    public String getSuggestionMessage(String ruleName) {
+        String key = "antipattern_message";
+        return (String) getConfigValue(ruleName, key);
+    }
+
+    /** Method to get the solution for a given rule name
+     * @param ruleName
+     * @return
+     */
+    public String getSolution(String ruleName) {
+        String key = "solution";
+        return (String) getConfigValue(ruleName, key);
+    }
+
+    /** Method to process the methods to check based on its type
+     * If the methods to check is a JSONArray, return a List of Strings
+     * @param methodsToCheck
+     * @return
+     */
+    private List<String> processMethodsToCheck(Object methodsToCheck) {
+        List<String> methods = new ArrayList<>();
+         if (methodsToCheck instanceof JSONArray) {
+            JSONArray jsonArray = (JSONArray) methodsToCheck;
+            for (int i = 0; i < jsonArray.length(); i++) {
+                methods.add(jsonArray.getString(i));
+            }
+        }
+        return methods;
+    }
+
+    /** Method to get all information for a given rule name
+     * @param ruleName
+     * @return
+     */
+    public JSONObject getCheckDetails(String ruleName) {
+        return jsonObject.optJSONObject(ruleName);
+    }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
index 52ab33beffd..6bf0a9216d2 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
@@ -9,6 +9,7 @@
 import com.intellij.psi.PsiMethod;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck.ConnectionStringVisitor;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
@@ -48,10 +49,14 @@ public void setup() {
         mockVisitor = createVisitor();
     }
 
-    PsiElementVisitor createVisitor() {
+    /**
+     * This method creates a visitor for the ConnectionStringCheck class.
+     * @return PsiElementVisitor visitor
+     */
+    private PsiElementVisitor createVisitor() {
         boolean isOnTheFly = true;
-        ConnectionStringCheck check = new ConnectionStringCheck();
-        return check.buildVisitor(mockHolder, isOnTheFly);
+        ConnectionStringVisitor visitor = new ConnectionStringCheck.ConnectionStringVisitor(mockHolder, isOnTheFly);
+        return visitor;
     }
 
     /**
@@ -64,7 +69,7 @@ PsiElementVisitor createVisitor() {
      * 2. BlobServiceClient blobServiceClient2 = new BlobServiceClientBuilder().connectionString(connectionString2).buildClient();
      */
     @Test
-    void testConnectionStringCheck() {
+    public void testConnectionStringCheck() {
 
         assertVisitor(mockVisitor);
         String METHOD_TO_CHECK = "connectionString";
@@ -74,9 +79,10 @@ void testConnectionStringCheck() {
         verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
     }
 
-    // Problem isn't registered because the method to check is different from the method that should be flagged
+    /** Problem isn't registered because the method to check is different from the method that should be flagged
+     */
     @Test
-    void differentMethodCheck() {
+    public void differentMethodCheck() {
         String METHOD_TO_CHECK = "differentMethod";
         int NUMBER_OF_INVOCATIONS = 0;
         String CLASS_NAME = "com.azure";
@@ -84,9 +90,10 @@ void differentMethodCheck() {
         verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
     }
 
-    // Problem isn't registered because the class name is different from the class that should be flagged
+    /** Problem isn't registered because the class name is different from the class that should be flagged
+     */
     @Test
-    void differentClassCheck() {
+    public void differentClassCheck() {
         String METHOD_TO_CHECK = "connectionString";
         int NUMBER_OF_INVOCATIONS = 0;
         String CLASS_NAME = "com.microsoft.azure";
@@ -94,9 +101,10 @@ void differentClassCheck() {
         verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
     }
 
-    // Problem isn't registered because the class name is null
+    /**  Problem isn't registered because the class name is null
+     */
     @Test
-    void nullClassCheck() {
+    public void nullClassCheck() {
         String METHOD_TO_CHECK = "connectionString";
         int NUMBER_OF_INVOCATIONS = 0;
         String CLASS_NAME = null;
@@ -104,14 +112,21 @@ void nullClassCheck() {
         verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
     }
 
-    // Asserts that the visitor is not null and is an instance of JavaElementVisitor
-    void assertVisitor(PsiElementVisitor visitor) {
+    /**  Asserts that the visitor is not null and is an instance of JavaElementVisitor
+     * @param visitor PsiElementVisitor
+     */
+    private void assertVisitor(PsiElementVisitor visitor) {
         assertNotNull(visitor);
         assertTrue(visitor instanceof JavaElementVisitor);
     }
 
-    // Verifies that a warning is raised when a connection string being used to create a client is detected.
-    void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS, String CLASS_NAME) {
+    /**  Verifies that a warning is raised when a connection string being used to create a client is detected.
+     * @param visitor PsiElementVisitor
+     * @param METHOD_TO_CHECK String
+     * @param NUMBER_OF_INVOCATIONS int
+     * @param CLASS_NAME String
+     */
+    private void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS, String CLASS_NAME) {
 
         PsiMethodCallExpression methodCallExpression = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
@@ -128,6 +143,6 @@ void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, in
         (visitor).visitElement(methodCallExpression);
 
         // Verify problem is registered
-        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(methodCallExpression), Mockito.contains("Connection String detected. Use AzureKeyCredentials for azure service client authentication instead."));
+        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(methodCallExpression), Mockito.contains("Connection String detected. Use DefaultAzureCredential for azure service client authentication instead."));
     }
 }

From 9e984c8109c7f679d9b6cf9045525259ef636a5a Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 3 Jul 2024 14:31:03 -0700
Subject: [PATCH 040/144] small fix to ConnectionStringCheck class

---
 .../intellij/azure/sdk/buildtool/ConnectionStringCheck.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
index 9d44432a0f3..9ebd0910d8d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -47,7 +47,6 @@ public static class ConnectionStringVisitor extends JavaElementVisitor {
         private static final Logger LOGGER = Logger.getLogger(ConnectionStringCheck.class.getName());
         private static String METHOD_TO_CHECK = "";
         private static String SUGGESTION = "";
-        private static String AZURE_PACKAGE_NAME = "";
 
         // Load the JSON configuration file to get the method to check and the suggestion message
         static {
@@ -59,7 +58,8 @@ public static class ConnectionStringVisitor extends JavaElementVisitor {
                 SUGGESTION = config.getSuggestionMessage(ruleName);
             } catch (IOException e) {
                 // make a descriptive message
-                LOGGER.log(Level.SEVERE, "Failed to load JSON configuration for rule '" + ruleName + "' from expected path: " + LoadJsonConfigFile.CONFIG_FILE_PATH, e);            }
+                LOGGER.log(Level.SEVERE, "Failed to load JSON configuration for rule '" + ruleName + "' from expected path: " + LoadJsonConfigFile.CONFIG_FILE_PATH, e);
+            }
         }
 
         /**

From d9054ab1b8eb1f8f9087418cd52d5dcfae6f5228 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 3 Jul 2024 14:41:32 -0700
Subject: [PATCH 041/144] update to recommendation

---
 .../azure-intellij-plugin-azure-sdk/README.md                 | 2 +-
 .../intellij/azure/sdk/buildtool/ConnectionStringCheck.java   | 4 ++--
 .../src/main/resources/META-INF/ruleConfigs.json              | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index a880c2d8f11..0d7b964db9e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -33,4 +33,4 @@ Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/
 - **Anti-pattern**: Using Connection Strings for Authenticating Azure SDK Clients.
 - **Issue**: Cconnection strings authentication is not recommended in Azure SDKs for Java due to potential security vulnerabilities.
 - **Severity: WARNING**
-- **Recommendation**: Use [DefaultAzureCredential](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for azure service client authentication instead.
+- **Recommendation**: [DefaultAzureCredential](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for azure service client authentication is recommended if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential or Connection Strings based authentication.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
index 9d44432a0f3..9ebd0910d8d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -47,7 +47,6 @@ public static class ConnectionStringVisitor extends JavaElementVisitor {
         private static final Logger LOGGER = Logger.getLogger(ConnectionStringCheck.class.getName());
         private static String METHOD_TO_CHECK = "";
         private static String SUGGESTION = "";
-        private static String AZURE_PACKAGE_NAME = "";
 
         // Load the JSON configuration file to get the method to check and the suggestion message
         static {
@@ -59,7 +58,8 @@ public static class ConnectionStringVisitor extends JavaElementVisitor {
                 SUGGESTION = config.getSuggestionMessage(ruleName);
             } catch (IOException e) {
                 // make a descriptive message
-                LOGGER.log(Level.SEVERE, "Failed to load JSON configuration for rule '" + ruleName + "' from expected path: " + LoadJsonConfigFile.CONFIG_FILE_PATH, e);            }
+                LOGGER.log(Level.SEVERE, "Failed to load JSON configuration for rule '" + ruleName + "' from expected path: " + LoadJsonConfigFile.CONFIG_FILE_PATH, e);
+            }
         }
 
         /**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 69fd2a214c1..422c074d5e1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -14,7 +14,7 @@
 
   "ConnectionStringCheck": {
     "method_to_check": "connectionString",
-    "antipattern_message" : "Connection String detected. Use DefaultAzureCredential for azure service client authentication instead.",
-    "solution": "Do not construct a service client with a connection string unless such connection string is available within the Azure portal or Azure CLI. Use DefaultAzureCredential or other secure methods for client authentication instead."
+    "antipattern_message" : "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
+    "solution": "DefaultAzureCredential is recommended if the service client supports Token Credential (Entra ID Authentication). if not, then use Azure Key Credential / Connection Strings based authentication"
   }
 }
\ No newline at end of file

From 1e8c39a242d3dd0b8733363a10cab01b7b33ec7c Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 3 Jul 2024 14:47:50 -0700
Subject: [PATCH 042/144] very minor tweak to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md                   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 0d7b964db9e..5a9127ae0df 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -33,4 +33,4 @@ Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/
 - **Anti-pattern**: Using Connection Strings for Authenticating Azure SDK Clients.
 - **Issue**: Cconnection strings authentication is not recommended in Azure SDKs for Java due to potential security vulnerabilities.
 - **Severity: WARNING**
-- **Recommendation**: [DefaultAzureCredential](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for azure service client authentication is recommended if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential or Connection Strings based authentication.
+- **Recommendation**: [DefaultAzureCredential](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for Azure service client authentication is recommended if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential or Connection Strings based authentication.

From 821aa7559001573d5fab52107c0c8b8beca75516 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 4 Jul 2024 09:59:20 -0700
Subject: [PATCH 043/144] initial implementation & test for
 GetSyncPollerOnPollerFluxCheck

---
 .../GetSyncPollerOnPollerFluxCheck.java       | 111 ++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  16 ++-
 .../GetSyncPollerOnPollerFluxCheckTest.java   | 135 ++++++++++++++++++
 3 files changed, 261 insertions(+), 1 deletion(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
new file mode 100644
index 00000000000..dce2420f767
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
@@ -0,0 +1,111 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.util.PsiTreeUtil;
+import org.jetbrains.annotations.NotNull;
+
+
+public class GetSyncPollerOnPollerFluxCheck extends LocalInspectionTool {
+
+    @NotNull
+    @Override
+    public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new GetSyncPollerOnPollerFluxVisitor(holder, isOnTheFly);
+    }
+
+
+    public static class GetSyncPollerOnPollerFluxVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+
+
+        public GetSyncPollerOnPollerFluxVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
+
+        @Override
+        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+            super.visitMethodCallExpression(expression);
+
+            // Check if the element is a method call expression
+            if (expression instanceof PsiMethodCallExpression) {
+                PsiMethodCallExpression methodCall = expression;
+
+                // Check if the method call is getSyncPoller
+                if (methodCall.getMethodExpression().getReferenceName().startsWith("getSyncPoller")) {
+                    System.out.println("methodCall: " + methodCall);
+                    System.out.println("methodCall.getReferenceName(): " + methodCall.getMethodExpression().getReferenceName());
+                    boolean isAsyncContext = checkIfAsyncContext(methodCall);
+
+                    if(isAsyncContext && isAzureClient(methodCall)) {
+                        holder.registerProblem(expression, "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks");
+                    }
+
+                }
+            }
+        }
+
+
+        /**
+         * Helper method to check if the method call is within an async context.
+         * This method will check if the method call is on a reactive type like Mono, Flux, etc.
+         *
+         * @param methodCall
+         * @return true if the method call is on a reactive type, false otherwise
+         */
+        private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
+            PsiExpression expression = methodCall.getMethodExpression().getQualifierExpression();
+
+            // Check if the method call is on a reactive type
+            if (expression != null) {
+                PsiType type = expression.getType();
+
+                // Check if the type is a reactive type
+                if (type != null) {
+                    String typeName = type.getCanonicalText();
+                    System.out.println("typeName: " + typeName);
+
+                    // Check for PollerFlux type
+                    if (typeName != null && typeName.contains("PollerFlux")) {
+                        return true;
+                    }
+                }
+            }
+            return false;
+        }
+
+        /**
+         * Helper method to check if the method call is on an Azure SDK client.
+         * This method will check if the method call is on a class that is part of the Azure SDK.
+         * @param methodCall
+         * @return true if the method call is on an Azure SDK client, false otherwise
+         */
+        private boolean isAzureClient (@NotNull PsiMethodCallExpression methodCall){
+
+            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
+
+            // Check if the method call is on a class
+            if (containingClass != null) {
+                String className = containingClass.getQualifiedName();
+                System.out.println("className: " + className);
+
+                // Check if the class is part of the Azure SDK
+                if (className != null && className.startsWith("com.azure.")) {
+                    return true;
+                }
+            }
+            return false;
+        }
+
+    }
+}
+
+
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 1b9efeb66e2..d8c8023ab6d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -42,7 +42,7 @@
                 language="JAVA"
                 shortName="ServiceBusReceiverAsyncClientCheck"
                 displayName="Low level ServiceBusReceiverAsyncClient check"
-                groupName="Azure SDK"
+                groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 level="WARNING"
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
@@ -51,5 +51,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="GetSyncPollerOnPollerFluxCheck"
+                displayName="GetSyncPoller On Poller Flux Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.GetSyncPollerOnPollerFluxCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.GetSyncPollerOnPollerFluxCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
new file mode 100644
index 00000000000..34bbc1230c7
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
@@ -0,0 +1,135 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.util.PsiTreeUtil;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.GetSyncPollerOnPollerFluxCheck.GetSyncPollerOnPollerFluxVisitor;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class GetSyncPollerOnPollerFluxCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    @Mock
+    private PsiMethodCallExpression mockElement;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockElement = mock(PsiMethodCallExpression.class);
+    }
+
+
+    private JavaElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        GetSyncPollerOnPollerFluxVisitor visitor = new GetSyncPollerOnPollerFluxVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
+
+
+    /**
+     * Test to verify if the visitor is able to detect the use of getSyncPoller() on a PollerFlux
+     * and register a problem with the suggestion message.
+     */
+    @Test
+    public void testGetSyncPollerOnPollerFluxCheck() {
+
+        assertVisitor();
+
+        String methodName = "getSyncPoller";
+        String packageName = "com.azure.core.util.polling.PollerFlux";
+        int numberOfInvocations = 1;
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+    }
+
+
+    @Test
+    public void testGetSyncPollerOnPollerFluxCheckWithDifferentMethodName() {
+
+        assertVisitor();
+
+        String methodName = "getAnotherMethod";
+        String packageName = "com.azure.core.util.polling.PollerFlux";
+        int numberOfInvocations = 0;
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+    }
+
+
+    @Test
+    public void testGetSyncPollerOnPollerFluxCheckWithDifferentPackageName() {
+
+        assertVisitor();
+
+        String methodName = "getSyncPoller";
+        String packageName = "com.azure.core.util.polling.DifferentPackageName";
+        int numberOfInvocations = 0;
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+    }
+
+
+    @Test
+    public void testGetSyncPollerOnPollerFluxCheckWithNullPackageName() {
+
+        assertVisitor();
+
+        String methodName = "getSyncPoller";
+        String packageName = null;
+        int numberOfInvocations = 0;
+        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+    }
+
+
+
+    private void assertVisitor() {
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    }
+
+    private void verifyRegisterProblem(String methodName, String packageName, int numberOfInvocations) {
+
+        PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
+        PsiExpression expression = mock(PsiExpression.class);
+        PsiType type = mock(PsiType.class);
+        PsiClass containingClass = mock(PsiClass.class);
+        PsiTreeUtil mockTreeUtil = mock(PsiTreeUtil.class);
+
+        when(mockElement.getMethodExpression()).thenReturn(referenceExpression);
+        when(referenceExpression.getReferenceName()).thenReturn(methodName);
+
+        when(referenceExpression.getQualifierExpression()).thenReturn(expression);
+        when(expression.getType()).thenReturn(type);
+        when(type.getCanonicalText()).thenReturn(packageName);
+
+
+        when(mockTreeUtil.getParentOfType(mockElement, PsiClass.class)).thenReturn(containingClass);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
+
+        // Act
+        mockVisitor.visitMethodCallExpression(mockElement);
+
+        // Verify registerProblem is not called
+        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"));
+    }
+}

From b3060c72a125b0a168c1120c7686b9889879e876 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 5 Jul 2024 22:36:17 -0700
Subject: [PATCH 044/144] initial implementation & test for
 SingleOperationInLoopCheck

---
 .../azure-toolkit-for-intellij/.idea/misc.xml |  12 +-
 .../buildtool/SingleOperationInLoopCheck.java | 253 ++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  16 +-
 .../SingleOperationInLoopCheckTest.java       | 273 ++++++++++++++++++
 4 files changed, 550 insertions(+), 4 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
index 57337953a0f..ee303b961d5 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.idea/misc.xml
@@ -7,7 +7,9 @@
   <component name="MavenProjectsManager">
     <option name="originalFiles">
       <list>
-        <option value="$PROJECT_DIR$/../../Utils/pom.xml" />
+        <option value="$PROJECT_DIR$/../../Utils/azure-toolkit-ide-hdinsight-libs/azure-toolkit-ide-cosmos-spark-lib/pom.xml" />
+        <option value="$PROJECT_DIR$/../../Utils/azure-toolkit-ide-libs/azure-toolkit-ide-cognitiveservices-lib/pom.xml" />
+        <option value="$PROJECT_DIR$/../../Utils/azure-toolkit-ide-libs/azure-toolkit-ide-servicebus-lib/pom.xml" />
       </list>
     </option>
   </component>
@@ -16,7 +18,7 @@
     <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
     <option name="myNullables">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
           <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
@@ -32,12 +34,14 @@
           <item index="12" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.Nullable" />
           <item index="13" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.Nullable" />
           <item index="14" class="java.lang.String" itemvalue="io.reactivex.annotations.Nullable" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.Nullable" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nullable" />
         </list>
       </value>
     </option>
     <option name="myNotNulls">
       <value>
-        <list size="15">
+        <list size="17">
           <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
           <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
           <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
@@ -53,6 +57,8 @@
           <item index="12" class="java.lang.String" itemvalue="lombok.NonNull" />
           <item index="13" class="java.lang.String" itemvalue="io.reactivex.rxjava3.annotations.NonNull" />
           <item index="14" class="java.lang.String" itemvalue="org.eclipse.jdt.annotation.NonNull" />
+          <item index="15" class="java.lang.String" itemvalue="org.jspecify.annotations.NonNull" />
+          <item index="16" class="java.lang.String" itemvalue="jakarta.annotation.Nonnull" />
         </list>
       </value>
     </option>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
new file mode 100644
index 00000000000..3baf67238a8
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
@@ -0,0 +1,253 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiBlockStatement;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiCodeBlock;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiDoWhileStatement;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionStatement;
+import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiForeachStatement;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiStatement;
+import com.intellij.psi.PsiVariable;
+import com.intellij.psi.PsiWhileStatement;
+import com.intellij.psi.util.PsiTreeUtil;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * Inspection to check if there is a single Azure client operation inside a loop.
+ */
+public class SingleOperationInLoopCheck extends LocalInspectionTool {
+
+    /**
+     * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
+     * @param holder The holder for the problems found
+     * @param isOnTheFly Whether the inspection is running on the fly. If true, the inspection is running as you type.
+     * @return
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new SingleOperationInLoopVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * Visitor class to traverse the PSI tree and check for single Azure client operation inside a loop.
+     * The visitor will check for loops of type for, foreach, while, and do-while.
+     * The visitor will check for single Azure client operation inside the loop body.
+     * If a single Azure client operation is found, a problem will be registered.
+     */
+    public static class SingleOperationInLoopVisitor extends JavaElementVisitor {
+
+        // Define the holder for the problems found and whether the inspection is running on the fly
+        private final ProblemsHolder holder;
+        private final boolean isOnTheFly;
+
+//        private static int numOfAzureClientOperations = 0;
+
+
+        /**
+         * Constructor for the visitor
+         *
+         * @param holder     The holder for the problems found
+         * @param isOnTheFly Whether the inspection is running on the fly. If true, the inspection is running as you type.
+         */
+        public SingleOperationInLoopVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
+        }
+
+        /**
+         * Visit the for statement and check for single Azure client operation inside the loop.
+         *
+         * @param statement The for statement to check
+         */
+        @Override
+        public void visitForStatement(@NotNull PsiForStatement statement) {
+            checkLoopForSingleClientOperation(statement);
+        }
+
+        /**
+         * Visit the foreach statement and check for single Azure client operation inside the loop.
+         *
+         * @param statement
+         */
+        @Override
+        public void visitForeachStatement(@NotNull PsiForeachStatement statement) {
+            checkLoopForSingleClientOperation(statement);
+        }
+
+        /**
+         * Visit the while statement and check for single Azure client operation inside the loop.
+         *
+         * @param statement
+         */
+        @Override
+        public void visitWhileStatement(@NotNull PsiWhileStatement statement) {
+            checkLoopForSingleClientOperation(statement);
+        }
+
+        /**
+         * Visit the do-while statement and check for single Azure client operation inside the loop.
+         *
+         * @param statement
+         */
+        @Override
+        public void visitDoWhileStatement(@NotNull PsiDoWhileStatement statement) {
+            System.out.println("do while statement: " + statement);
+            checkLoopForSingleClientOperation(statement);
+        }
+
+
+        /**
+         * Check if there is a single Azure client operation inside the loop.
+         * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
+         * If a single Azure client operation is found, a problem will be registered.
+         * @param loopStatement The loop statement to check
+         */
+        private void checkLoopForSingleClientOperation(PsiStatement loopStatement) {
+
+            int numOfAzureClientOperations = countAzureClientOperations(loopStatement);
+            System.out.println("StartnumOfAzureClientOperations: " + numOfAzureClientOperations);
+            if (numOfAzureClientOperations == 1) {
+                holder.registerProblem(loopStatement,
+                        "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request.");
+            }
+        }
+
+
+        /**
+         * Count the number of Azure client operations inside the loop.
+         * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
+         * If an Azure client operation is found, the count will be incremented.
+         * @param loopStatement The loop statement to check
+         */
+        private int countAzureClientOperations(PsiStatement loopStatement) {
+
+            int numOfAzureClientOperations = 0;
+
+            System.out.println("loopStatement: " + loopStatement);
+            // extract body of the loop
+            PsiStatement loopBody = getLoopBody(loopStatement);
+
+            System.out.println("loopBody: " + loopBody);
+
+            // Extract the code block from the block statement
+            PsiBlockStatement blockStatement = (PsiBlockStatement) loopBody;
+            PsiCodeBlock codeBlock = blockStatement.getCodeBlock();
+
+
+
+            if (loopBody == null) {
+                return 0;
+            }
+
+            System.out.println("loopBody: " + loopBody);
+
+            System.out.println("statements: " + codeBlock.getStatements());
+
+            // extract statements in the loop body
+
+            for (PsiStatement statement : codeBlock.getStatements()) {
+
+
+                System.out.println("statement: " + statement);
+                System.out.println("BeforenumOfAzureClientOperationsPsiExpressionStatement: " + numOfAzureClientOperations);
+                if (statement instanceof PsiExpressionStatement && isExpressionAzureClientOperation(statement)) {
+
+                    numOfAzureClientOperations++;
+                    System.out.println("AfternumOfAzureClientOperationsPsiExpressionStatement: " + numOfAzureClientOperations);
+//                    System.out.println("numOfAzureClientOperations: " + numOfAzureClientOperations);
+                }
+
+                System.out.println("BeforenumOfAzureClientOperationsPsiDeclarationStatement: " + numOfAzureClientOperations);
+                if (statement instanceof PsiDeclarationStatement && isDeclarationAzureClientOperation((PsiDeclarationStatement) statement)) {
+                    numOfAzureClientOperations++;
+                    System.out.println("AfternumOfAzureClientOperationsPsiDeclarationStatement: " + numOfAzureClientOperations);
+
+                }
+            }
+            return numOfAzureClientOperations;
+        }
+
+
+        public static PsiStatement getLoopBody(PsiStatement loopStatement) {
+            if (loopStatement instanceof PsiForStatement) return ((PsiForStatement) loopStatement).getBody();
+            if (loopStatement instanceof PsiForeachStatement) return ((PsiForeachStatement) loopStatement).getBody();
+            if (loopStatement instanceof PsiWhileStatement) return ((PsiWhileStatement) loopStatement).getBody();
+            if (loopStatement instanceof PsiDoWhileStatement) return ((PsiDoWhileStatement) loopStatement).getBody();
+            return null;
+        }
+
+        private boolean isExpressionAzureClientOperation(PsiStatement statement) {
+//            PsiExpression expression = ((PsiExpressionStatement) statement).getExpression();
+            PsiExpression expression = ((PsiExpressionStatement) statement).getExpression();
+            System.out.println("expression: " + expression);
+
+            if (!(expression instanceof PsiMethodCallExpression)) {
+                System.out.println("expression not instanceof PsiMethodCallExpression");
+                return false;
+            }
+            if (isAzureClientOperation((PsiMethodCallExpression) expression)) {
+                return true;
+            }
+            return false;
+        }
+
+        private boolean isDeclarationAzureClientOperation(PsiDeclarationStatement statement) {
+
+            // getDeclaredElements() returns the variables declared in the statement
+            // eg. int a = 5, b = 6; -> getDeclaredElements() returns a and b
+            // eg. int a = 5; -> getDeclaredElements() returns a, a list of size 1
+            for (PsiElement element :  statement.getDeclaredElements()) {
+                System.out.println("element: " + element);
+
+                if (!(element instanceof PsiVariable)) {
+                    continue;
+                }
+                PsiExpression initializer = ((PsiVariable) element).getInitializer();
+                System.out.println("initializer: " + initializer);
+
+                if (!(initializer instanceof PsiMethodCallExpression)) {
+                    continue;
+                }
+                if (isAzureClientOperation((PsiMethodCallExpression) initializer)) {
+                    return true;
+                }
+            }
+            return false;
+        }
+
+        /**
+         * Check if the method call is an Azure client operation.
+         * Check the containing class of the method call and see if it is part of the Azure SDK.
+         * If the class is part of the Azure SDK, increment the count of Azure client operations.
+         * @param methodCall The method call expression to check
+         * @return True if the method call is an Azure client operation, false otherwise
+         */
+        private static boolean isAzureClientOperation(PsiMethodCallExpression methodCall) {
+            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
+
+            System.out.println("containingClass: " + containingClass);
+
+            // Check if the method call is on a class
+            if (containingClass != null) {
+                String className = containingClass.getQualifiedName();
+                System.out.println("className: " + className);
+
+                // Check if the class is part of the Azure SDK
+                if (className != null && className.startsWith("com.azure.")) {
+                    return true;
+                }
+            }
+            return false;
+        }
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 1b9efeb66e2..a2a590346a9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -42,7 +42,7 @@
                 language="JAVA"
                 shortName="ServiceBusReceiverAsyncClientCheck"
                 displayName="Low level ServiceBusReceiverAsyncClient check"
-                groupName="Azure SDK"
+                groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 level="WARNING"
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
@@ -51,5 +51,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="SingleOperationInLoopCheck"
+                displayName="Single Operation In Loop Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.SingleOperationInLoopCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.SingleOperationInLoopCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
new file mode 100644
index 00000000000..86458cd2148
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
@@ -0,0 +1,273 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiBlockStatement;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiCodeBlock;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiDoWhileStatement;
+import com.intellij.psi.PsiExpressionStatement;
+import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiForeachStatement;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiStatement;
+import com.intellij.psi.PsiVariable;
+import com.intellij.psi.PsiWhileStatement;
+import com.intellij.psi.util.PsiTreeUtil;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.SingleOperationInLoopCheck.SingleOperationInLoopVisitor;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElement;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class SingleOperationInLoopCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+    private JavaElementVisitor mockVisitor;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiExpressionStatementInForStatement() {
+        assertVisitor();
+
+        PsiForStatement statement = mock(PsiForStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiExpressionStatementInForEachStatement() {
+        assertVisitor();
+
+        PsiForeachStatement statement = mock(PsiForeachStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiExpressionStatementInWhileStatement() {
+        assertVisitor();
+
+        PsiWhileStatement statement = mock(PsiWhileStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiExpressionStatementInDoWhileStatement() {
+        assertVisitor();
+
+        PsiDoWhileStatement statement = mock(PsiDoWhileStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiDeclarationStatementInForStatement() {
+        assertVisitor();
+
+        PsiForStatement statement = mock(PsiForStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiDeclarationStatementInForEachStatement() {
+        assertVisitor();
+
+        PsiForeachStatement statement = mock(PsiForeachStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiDeclarationStatementInWhileStatement() {
+        assertVisitor();
+
+        PsiWhileStatement statement = mock(PsiWhileStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testSingleOperationInLoopCheckPsiDeclarationStatementInDoWhileStatement() {
+        assertVisitor();
+
+        PsiDoWhileStatement statement = mock(PsiDoWhileStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 1;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+
+    @Test
+    public void testMultipleOperationsInLoopCheckPsiExpressionStatementInForEachStatement() {
+        assertVisitor();
+
+        PsiForeachStatement statement = mock(PsiForeachStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 0;
+        int numOfOperations = 4;
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    @Test
+    public void testMultipleOperationsInLoopCheckPsiDeclarationStatementInDoWhileStatement() {
+        assertVisitor();
+
+        PsiDoWhileStatement statement = mock(PsiDoWhileStatement.class);
+        String packageName = "com.azure.storage.blob";
+        int numberOfInvocations = 0;
+        int numOfOperations = 2;
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    private JavaElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        SingleOperationInLoopVisitor visitor = new SingleOperationInLoopVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
+
+    // Assert that the visitor is not null and is an instance of JavaRecursiveElementWalkingVisitor
+    private void assertVisitor() {
+        assertNotNull(mockVisitor);
+        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    }
+
+    private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, int numOfOperations) {
+
+        PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
+        PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
+        PsiMethodCallExpression expression = mock(PsiMethodCallExpression.class);
+        PsiTreeUtil treeUtil = mock(PsiTreeUtil.class);
+        PsiClass containingClass = mock(PsiClass.class);
+
+        // Create a list to dynamically add PsiStatement objects
+        List<PsiStatement> statementList = new ArrayList<>();
+
+        // Mock PsiStatement and add to the list x times
+        for (int i = 0; i < numOfOperations; i++) {
+            PsiExpressionStatement mockStatement = mock(PsiExpressionStatement.class);
+            statementList.add(mockStatement);
+            when(mockStatement.getExpression()).thenReturn(expression);
+        }
+
+        // Convert the list to an array of PsiStatement objects
+        PsiStatement[] statements = statementList.toArray(new PsiStatement[0]);
+
+        when(loopBody.getCodeBlock()).thenReturn(codeBlock);
+        when(codeBlock.getStatements()).thenReturn(statements);
+        when(treeUtil.getParentOfType(expression, PsiClass.class)).thenReturn(containingClass);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
+
+
+        // Adjusted visitor invocation based on the type of loopStatement
+        if (loopStatement instanceof PsiForStatement) {
+            when(((PsiForStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitForStatement((PsiForStatement) loopStatement);
+        } else if (loopStatement instanceof PsiForeachStatement) {
+            when(((PsiForeachStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitForeachStatement((PsiForeachStatement) loopStatement);
+        } else if (loopStatement instanceof PsiWhileStatement) {
+            when(((PsiWhileStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitWhileStatement((PsiWhileStatement) loopStatement);
+        } else if (loopStatement instanceof PsiDoWhileStatement) {
+            when(((PsiDoWhileStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitDoWhileStatement((PsiDoWhileStatement) loopStatement);
+        }
+
+        //  Verify problem is registered
+        verify(mockHolder,
+                times(numberOfInvocations)).registerProblem(Mockito.eq(loopStatement),
+                Mockito.contains(
+                        "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
+    }
+
+
+    private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, int numOfOperations) {
+
+        PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
+        PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
+        PsiVariable element = mock(PsiVariable.class);
+        PsiElement[] elements = new PsiElement[] {element};
+        PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
+        PsiTreeUtil treeUtil = mock(PsiTreeUtil.class);
+        PsiClass containingClass = mock(PsiClass.class);
+
+        // Create a list to dynamically add PsiStatement objects
+        List<PsiStatement> statementList = new ArrayList<>();
+
+        // Mock PsiStatement and add to the list x times
+        for (int i = 0; i < numOfOperations; i++) {
+            PsiDeclarationStatement mockStatement = mock(PsiDeclarationStatement.class);
+            statementList.add(mockStatement);
+            when(mockStatement.getDeclaredElements()).thenReturn(elements);
+        }
+
+        // Convert the list to an array of PsiStatement objects
+        PsiStatement[] statements = statementList.toArray(new PsiStatement[0]);
+
+        when(loopBody.getCodeBlock()).thenReturn(codeBlock);
+        when(codeBlock.getStatements()).thenReturn(statements);
+        when(element.getInitializer()).thenReturn(initializer);
+        when(treeUtil.getParentOfType(initializer, PsiClass.class)).thenReturn(containingClass);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
+
+        // Adjusted visitor invocation based on the type of loopStatement
+        if (loopStatement instanceof PsiForStatement) {
+            when(((PsiForStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitForStatement((PsiForStatement) loopStatement);
+        } else if (loopStatement instanceof PsiForeachStatement) {
+            when(((PsiForeachStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitForeachStatement((PsiForeachStatement) loopStatement);
+        } else if (loopStatement instanceof PsiWhileStatement) {
+            when(((PsiWhileStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitWhileStatement((PsiWhileStatement) loopStatement);
+        } else if (loopStatement instanceof PsiDoWhileStatement) {
+            when(((PsiDoWhileStatement) loopStatement).getBody()).thenReturn(loopBody);
+            mockVisitor.visitDoWhileStatement((PsiDoWhileStatement) loopStatement);
+        }
+
+        //  Verify problem is registered
+        verify(mockHolder,
+                times(numberOfInvocations)).registerProblem(Mockito.eq(loopStatement),
+                Mockito.contains(
+                        "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
+    }
+}
\ No newline at end of file

From 800c146b1ad5525cce9265c4903518468b48ff50 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 6 Jul 2024 11:24:15 -0700
Subject: [PATCH 045/144] complete implementation of SingleOperationInLoopCheck
 with tests

---
 .../buildtool/SingleOperationInLoopCheck.java | 152 ++++++++++++------
 .../main/resources/META-INF/ruleConfigs.json  |   4 +
 .../SingleOperationInLoopCheckTest.java       | 119 ++++++++++++--
 3 files changed, 216 insertions(+), 59 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
index 3baf67238a8..644fc943526 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
@@ -19,10 +19,42 @@
 import com.intellij.psi.PsiVariable;
 import com.intellij.psi.PsiWhileStatement;
 import com.intellij.psi.util.PsiTreeUtil;
+
 import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+import java.io.IOException;
+import java.util.logging.Logger;
 
 /**
  * Inspection to check if there is a single Azure client operation inside a loop.
+ * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
+ * If a single Azure client operation is found inside a loop, a problem will be registered.
+ *
+ * THis is an example of a situation where the inspection should register a problem:
+ *
+ * 1. With a single PsiDeclarationStatement inside a while loop
+ * // While loop
+ *         int i = 0;
+ *         while (i < 10) {
+ *
+ *             BlobAsyncClient blobAsyncClient = new BlobClientBuilder()
+ *                 .endpoint("https://<your-storage-account-name>.blob.core.windows.net")
+ *                 .sasToken("<your-sas-token>")
+ *                 .containerName("<your-container-name>")
+ *                 .blobName("<your-blob-name>")
+ *                 .buildAsyncClient();
+ *
+ *             i++;
+ *         }
+ *
+ * 2. With a single PsiExpressionStatement inside a for loop
+ * for (String documentPath : documentPaths) {
+ *
+ *             blobAsyncClient.uploadFromFile(documentPath)
+ *                 .doOnSuccess(response -> System.out.println("Blob uploaded successfully in enhanced for loop."))
+ *                 .subscribe();
+ *         }
  */
 public class SingleOperationInLoopCheck extends LocalInspectionTool {
 
@@ -30,7 +62,7 @@ public class SingleOperationInLoopCheck extends LocalInspectionTool {
      * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
      * @param holder The holder for the problems found
      * @param isOnTheFly Whether the inspection is running on the fly. If true, the inspection is running as you type.
-     * @return
+     * @return The visitor for the inspection
      */
     @NotNull
     @Override
@@ -50,12 +82,22 @@ public static class SingleOperationInLoopVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
         private final boolean isOnTheFly;
 
-//        private static int numOfAzureClientOperations = 0;
+        // Define the logger for the visitor
+        private static final Logger LOGGER = Logger.getLogger(SingleOperationInLoopCheck.class.getName());
+
+        // Define the suggestion message for the problem
+        private static String SUGGESTION = "";
 
+        static {
+            try {
+                SUGGESTION = getRuleConfigs();
+            } catch (IOException e) {
+                LOGGER.severe("Failed to load rule configurations");
+            }
+        }
 
         /**
          * Constructor for the visitor
-         *
          * @param holder     The holder for the problems found
          * @param isOnTheFly Whether the inspection is running on the fly. If true, the inspection is running as you type.
          */
@@ -66,7 +108,6 @@ public SingleOperationInLoopVisitor(ProblemsHolder holder, boolean isOnTheFly) {
 
         /**
          * Visit the for statement and check for single Azure client operation inside the loop.
-         *
          * @param statement The for statement to check
          */
         @Override
@@ -76,8 +117,7 @@ public void visitForStatement(@NotNull PsiForStatement statement) {
 
         /**
          * Visit the foreach statement and check for single Azure client operation inside the loop.
-         *
-         * @param statement
+         * @param statement The foreach statement to check
          */
         @Override
         public void visitForeachStatement(@NotNull PsiForeachStatement statement) {
@@ -86,8 +126,7 @@ public void visitForeachStatement(@NotNull PsiForeachStatement statement) {
 
         /**
          * Visit the while statement and check for single Azure client operation inside the loop.
-         *
-         * @param statement
+         * @param statement The while statement to check
          */
         @Override
         public void visitWhileStatement(@NotNull PsiWhileStatement statement) {
@@ -96,16 +135,13 @@ public void visitWhileStatement(@NotNull PsiWhileStatement statement) {
 
         /**
          * Visit the do-while statement and check for single Azure client operation inside the loop.
-         *
-         * @param statement
+         * @param statement The do-while statement to check
          */
         @Override
         public void visitDoWhileStatement(@NotNull PsiDoWhileStatement statement) {
-            System.out.println("do while statement: " + statement);
             checkLoopForSingleClientOperation(statement);
         }
 
-
         /**
          * Check if there is a single Azure client operation inside the loop.
          * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
@@ -114,17 +150,14 @@ public void visitDoWhileStatement(@NotNull PsiDoWhileStatement statement) {
          */
         private void checkLoopForSingleClientOperation(PsiStatement loopStatement) {
 
+            // Count the number of Azure client operations inside the loop
             int numOfAzureClientOperations = countAzureClientOperations(loopStatement);
-            System.out.println("StartnumOfAzureClientOperations: " + numOfAzureClientOperations);
             if (numOfAzureClientOperations == 1) {
-                holder.registerProblem(loopStatement,
-                        "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request.");
+                holder.registerProblem(loopStatement, SUGGESTION);
             }
         }
 
-
         /**
-         * Count the number of Azure client operations inside the loop.
          * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
          * If an Azure client operation is found, the count will be incremented.
          * @param loopStatement The loop statement to check
@@ -133,52 +166,49 @@ private int countAzureClientOperations(PsiStatement loopStatement) {
 
             int numOfAzureClientOperations = 0;
 
-            System.out.println("loopStatement: " + loopStatement);
             // extract body of the loop
             PsiStatement loopBody = getLoopBody(loopStatement);
 
-            System.out.println("loopBody: " + loopBody);
-
-            // Extract the code block from the block statement
-            PsiBlockStatement blockStatement = (PsiBlockStatement) loopBody;
-            PsiCodeBlock codeBlock = blockStatement.getCodeBlock();
-
-
-
             if (loopBody == null) {
                 return 0;
             }
 
-            System.out.println("loopBody: " + loopBody);
-
-            System.out.println("statements: " + codeBlock.getStatements());
+            // Extract the code block from the block statement
+            PsiBlockStatement blockStatement = (PsiBlockStatement) loopBody;
+            PsiCodeBlock codeBlock = blockStatement.getCodeBlock();
 
             // extract statements in the loop body
-
             for (PsiStatement statement : codeBlock.getStatements()) {
 
+                // Check if the statement is an expression statement and is an Azure client operation
+                if (statement instanceof PsiExpressionStatement &&
+                        isExpressionAzureClientOperation(statement)) {
 
-                System.out.println("statement: " + statement);
-                System.out.println("BeforenumOfAzureClientOperationsPsiExpressionStatement: " + numOfAzureClientOperations);
-                if (statement instanceof PsiExpressionStatement && isExpressionAzureClientOperation(statement)) {
-
+                    // Increment the count of Azure client operations if the expression statement is an Azure client operation
                     numOfAzureClientOperations++;
-                    System.out.println("AfternumOfAzureClientOperationsPsiExpressionStatement: " + numOfAzureClientOperations);
-//                    System.out.println("numOfAzureClientOperations: " + numOfAzureClientOperations);
                 }
 
-                System.out.println("BeforenumOfAzureClientOperationsPsiDeclarationStatement: " + numOfAzureClientOperations);
-                if (statement instanceof PsiDeclarationStatement && isDeclarationAzureClientOperation((PsiDeclarationStatement) statement)) {
-                    numOfAzureClientOperations++;
-                    System.out.println("AfternumOfAzureClientOperationsPsiDeclarationStatement: " + numOfAzureClientOperations);
+                // Check if the statement is a declaration statement and is an Azure client operation
+                if (statement instanceof PsiDeclarationStatement &&
+                        isDeclarationAzureClientOperation((PsiDeclarationStatement) statement)) {
 
+                    // Increment the count of Azure client operations if the declaration statement is an Azure client operation
+                    numOfAzureClientOperations++;
                 }
             }
             return numOfAzureClientOperations;
         }
 
 
+        /**
+         * Get the body of the loop statement.
+         * The body of the loop statement is the statement that is executed in the loop.
+         * @param loopStatement The loop statement to get the body from
+         * @return The body of the loop statement
+         */
         public static PsiStatement getLoopBody(PsiStatement loopStatement) {
+
+            // Check the type of the loop statement and return the body of the loop statement
             if (loopStatement instanceof PsiForStatement) return ((PsiForStatement) loopStatement).getBody();
             if (loopStatement instanceof PsiForeachStatement) return ((PsiForeachStatement) loopStatement).getBody();
             if (loopStatement instanceof PsiWhileStatement) return ((PsiWhileStatement) loopStatement).getBody();
@@ -186,38 +216,46 @@ public static PsiStatement getLoopBody(PsiStatement loopStatement) {
             return null;
         }
 
+        /**
+         * If the statement is an expression statement, check if the expression is an Azure client operation.
+         * @param statement The statement to check
+         * @return True if the statement is an Azure client operation, false otherwise
+         */
         private boolean isExpressionAzureClientOperation(PsiStatement statement) {
-//            PsiExpression expression = ((PsiExpressionStatement) statement).getExpression();
+
+            // Get the expression from the statement
             PsiExpression expression = ((PsiExpressionStatement) statement).getExpression();
-            System.out.println("expression: " + expression);
 
             if (!(expression instanceof PsiMethodCallExpression)) {
-                System.out.println("expression not instanceof PsiMethodCallExpression");
                 return false;
             }
+            // Check if the expression is an Azure client operation
             if (isAzureClientOperation((PsiMethodCallExpression) expression)) {
                 return true;
             }
             return false;
         }
 
+        /**
+         * If the statement is a declaration statement, check if the initializer is an Azure client operation.
+         * @param statement The declaration statement to check
+         * @return True if the declaration statement is an Azure client operation, false otherwise
+         */
         private boolean isDeclarationAzureClientOperation(PsiDeclarationStatement statement) {
 
             // getDeclaredElements() returns the variables declared in the statement
-            // eg. int a = 5, b = 6; -> getDeclaredElements() returns a and b
-            // eg. int a = 5; -> getDeclaredElements() returns a, a list of size 1
             for (PsiElement element :  statement.getDeclaredElements()) {
-                System.out.println("element: " + element);
 
                 if (!(element instanceof PsiVariable)) {
                     continue;
                 }
+                // Get the initializer of the variable
                 PsiExpression initializer = ((PsiVariable) element).getInitializer();
-                System.out.println("initializer: " + initializer);
 
                 if (!(initializer instanceof PsiMethodCallExpression)) {
                     continue;
                 }
+                // Check if the initializer is an Azure client operation
                 if (isAzureClientOperation((PsiMethodCallExpression) initializer)) {
                     return true;
                 }
@@ -233,14 +271,13 @@ private boolean isDeclarationAzureClientOperation(PsiDeclarationStatement statem
          * @return True if the method call is an Azure client operation, false otherwise
          */
         private static boolean isAzureClientOperation(PsiMethodCallExpression methodCall) {
-            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
 
-            System.out.println("containingClass: " + containingClass);
+            // Get the containing class of the method call
+            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
 
             // Check if the method call is on a class
             if (containingClass != null) {
                 String className = containingClass.getQualifiedName();
-                System.out.println("className: " + className);
 
                 // Check if the class is part of the Azure SDK
                 if (className != null && className.startsWith("com.azure.")) {
@@ -249,5 +286,20 @@ private static boolean isAzureClientOperation(PsiMethodCallExpression methodCall
             }
             return false;
         }
+
+        /**
+         * Get the rule configurations from the JSON file.
+         * @return The rule configurations
+         * @throws IOException
+         */
+        private static String getRuleConfigs() throws IOException {
+
+            final String ruleName = "SingleOperationInLoopCheck";
+            final String antiPatternMessageKey = "antipattern_message";
+
+            final JSONObject jsonObject =  LoadJsonConfigFile.getInstance().getJsonObject();
+            final String antiPatternMessage = jsonObject.getJSONObject(ruleName).getString(antiPatternMessageKey);
+            return antiPatternMessage;
+        }
     }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d0361d1b107..ab1216254b9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -10,5 +10,9 @@
   "ServiceBusReceiverAsyncClientCheck": {
     "client_name": "ServiceBusReceiverAsyncClient",
     "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+  },
+
+  "SingleOperationInLoopCheck": {
+    "antipattern_message": "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
index 86458cd2148..5b2a06ba794 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
@@ -15,9 +15,9 @@
 import com.intellij.psi.PsiWhileStatement;
 import com.intellij.psi.util.PsiTreeUtil;
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.SingleOperationInLoopCheck.SingleOperationInLoopVisitor;
-
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.PsiElement;
+
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
@@ -33,6 +33,37 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+/**
+ * This class is used to test the SingleOperationInLoopCheck class.
+ * The SingleOperationInLoopCheck is an inspection to check if there is a single Azure client operation inside a loop.
+ * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
+ * If a single Azure client operation is found inside a loop, a problem will be registered.
+ *
+ * THis is an example of a situation where the inspection should register a problem:
+ *
+ * 1. With a single PsiDeclarationStatement inside a while loop
+ * // While loop
+ *         int i = 0;
+ *         while (i < 10) {
+ *
+ *             BlobAsyncClient blobAsyncClient = new BlobClientBuilder()
+ *                 .endpoint("https://<your-storage-account-name>.blob.core.windows.net")
+ *                 .sasToken("<your-sas-token>")
+ *                 .containerName("<your-container-name>")
+ *                 .blobName("<your-blob-name>")
+ *                 .buildAsyncClient();
+ *
+ *             i++;
+ *         }
+ *
+ * 2. With a single PsiExpressionStatement inside a for loop
+ * for (String documentPath : documentPaths) {
+ *
+ *             blobAsyncClient.uploadFromFile(documentPath)
+ *                 .doOnSuccess(response -> System.out.println("Blob uploaded successfully in enhanced for loop."))
+ *                 .subscribe();
+ *         }
+ */
 public class SingleOperationInLoopCheckTest {
 
     // Declare as instance variables
@@ -46,6 +77,10 @@ public void setup() {
         mockVisitor = createVisitor();
     }
 
+    /**
+     * This test is used to verify a problem is registered when a
+     * single PsiExpressionStatement operation is found in a for loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiExpressionStatementInForStatement() {
         assertVisitor();
@@ -54,9 +89,14 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInForStatement()
         String packageName = "com.azure.storage.blob";
         int numberOfInvocations = 1;
         int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement,
+                packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is registered when a
+     * single PsiExpressionStatement operation is found in a for each loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiExpressionStatementInForEachStatement() {
         assertVisitor();
@@ -68,6 +108,10 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInForEachStateme
         verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is registered when a
+     * single PsiExpressionStatement operation is found in a while loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiExpressionStatementInWhileStatement() {
         assertVisitor();
@@ -79,6 +123,10 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInWhileStatement
         verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is registered when a
+     * single PsiExpressionStatement operation is found in a do while loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiExpressionStatementInDoWhileStatement() {
         assertVisitor();
@@ -90,7 +138,10 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInDoWhileStateme
         verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
-
+    /**
+     * This test is used to verify a problem is registered when a single
+     * PsiExpressionStatement operation is found in a for each loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiDeclarationStatementInForStatement() {
         assertVisitor();
@@ -102,6 +153,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInForStatement(
         verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is registered when a single
+     * PsiDeclarationStatement operation is found in a do while loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiDeclarationStatementInForEachStatement() {
         assertVisitor();
@@ -113,6 +168,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInForEachStatem
         verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is registered when a single
+     * PsiDeclarationStatement operation is found in a while loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiDeclarationStatementInWhileStatement() {
         assertVisitor();
@@ -124,6 +183,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInWhileStatemen
         verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is registered when a single
+     * PsiDeclarationStatement operation is found in a do while loop.
+     */
     @Test
     public void testSingleOperationInLoopCheckPsiDeclarationStatementInDoWhileStatement() {
         assertVisitor();
@@ -135,7 +198,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInDoWhileStatem
         verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
-
+    /**
+     * This test is used to verify a problem is NOT registered when multiple
+     * PsiExpressionStatement operations are found in a for loop.
+     */
     @Test
     public void testMultipleOperationsInLoopCheckPsiExpressionStatementInForEachStatement() {
         assertVisitor();
@@ -147,6 +213,10 @@ public void testMultipleOperationsInLoopCheckPsiExpressionStatementInForEachStat
         verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is NOT registered when multiple
+     * PsiExpressionStatement operations are found in a while loop.
+     */
     @Test
     public void testMultipleOperationsInLoopCheckPsiDeclarationStatementInDoWhileStatement() {
         assertVisitor();
@@ -158,20 +228,46 @@ public void testMultipleOperationsInLoopCheckPsiDeclarationStatementInDoWhileSta
         verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
     }
 
+    /**
+     * This test is used to verify a problem is NOT registered when a different package name
+     * is used in the PsiExpressionStatement operation in a for loop.
+     */
+    @Test
+    public void testSingleOperationInLoopCheckWithDifferentPackageName() {
+        assertVisitor();
+
+        PsiForStatement statement = mock(PsiForStatement.class);
+        String packageName = "com.microsoft.azure.storage.blob";
+        int numberOfInvocations = 0;
+        int numOfOperations = 1;
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+    }
+
+    /**
+     * This helper method is used to create a new SingleOperationInLoopVisitor object.
+     */
     private JavaElementVisitor createVisitor() {
         boolean isOnTheFly = true;
         SingleOperationInLoopVisitor visitor = new SingleOperationInLoopVisitor(mockHolder, isOnTheFly);
         return visitor;
     }
 
-    // Assert that the visitor is not null and is an instance of JavaRecursiveElementWalkingVisitor
+    /**
+     * Assert that the visitor is not null and is an instance of JavaElementVisitor
+     * to ensure the visitor is created correctly.
+     */
     private void assertVisitor() {
         assertNotNull(mockVisitor);
         assertTrue(mockVisitor instanceof JavaElementVisitor);
     }
 
+    /**
+     * This helper method is used to verify a problem is registered when a
+     * PsiExpressionStatement operation is found in a loop.
+     */
     private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, int numOfOperations) {
 
+        // Arrange
         PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
         PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
         PsiMethodCallExpression expression = mock(PsiMethodCallExpression.class);
@@ -196,9 +292,10 @@ private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement
         when(treeUtil.getParentOfType(expression, PsiClass.class)).thenReturn(containingClass);
         when(containingClass.getQualifiedName()).thenReturn(packageName);
 
-
-        // Adjusted visitor invocation based on the type of loopStatement
+        // Visitor invocation based on the type of loopStatement
         if (loopStatement instanceof PsiForStatement) {
+
+            // .getBody() is specific to objects of PsiForStatement, PsiForeachStatement, PsiWhileStatement, and PsiDoWhileStatement
             when(((PsiForStatement) loopStatement).getBody()).thenReturn(loopBody);
             mockVisitor.visitForStatement((PsiForStatement) loopStatement);
         } else if (loopStatement instanceof PsiForeachStatement) {
@@ -219,9 +316,13 @@ private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement
                         "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
     }
 
-
+    /**
+     * This helper method is used to verify a problem is registered when a
+     * PsiDeclarationStatement operation is found in a loop.
+     */
     private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, int numOfOperations) {
 
+        // Arrange
         PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
         PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
         PsiVariable element = mock(PsiVariable.class);
@@ -249,7 +350,7 @@ private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement
         when(treeUtil.getParentOfType(initializer, PsiClass.class)).thenReturn(containingClass);
         when(containingClass.getQualifiedName()).thenReturn(packageName);
 
-        // Adjusted visitor invocation based on the type of loopStatement
+        // Visitor invocation based on the type of loopStatement
         if (loopStatement instanceof PsiForStatement) {
             when(((PsiForStatement) loopStatement).getBody()).thenReturn(loopBody);
             mockVisitor.visitForStatement((PsiForStatement) loopStatement);

From 391e82917b4c2e9636b27e661e66f847c4c317d3 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 6 Jul 2024 11:27:36 -0700
Subject: [PATCH 046/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md          | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 191fd3e94f2..3175be77e54 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -16,10 +16,16 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 
 ## Rules
-1. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+1. #### Storage Upload without Length Check
+- **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
+- **Severity: INFO**
+- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
+
+2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
 - **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
 
 - **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
-- **Severity: INFO**
+- **Severity: WARNING**
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
 Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file

From 33ef7319795cda63f040466e81e5a0154d704e2d Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 6 Jul 2024 11:47:53 -0700
Subject: [PATCH 047/144] update to README.md

---
 PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore | 3 ++-
 .../azure-intellij-plugin-azure-sdk/README.md            | 9 ++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index e297894a61e..1043f4e0000 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -49,4 +49,5 @@ gen-external-apklibs/
 /azure-intellij-plugin-azure-sdk/.idea/
 
 # IntelliJ
-.idea/
\ No newline at end of file
+.idea/
+/.idea/
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3175be77e54..8e3a574d4fe 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -28,4 +28,11 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+3. #### Using Batch Operations Instead of Single Operations in a Loop
+- **Anti-pattern**: Calling a single operation in a for-loop when a batch operation API exists in the SDK that can handle multiple actions in one request.
+- **Issue**: Repeatedly calling a single operation in a loop leads to multiple network requests, which can be inefficient and slow.
+  - Multiple requests also consume more resources (e.g., network bandwidth, server processing) compared to a single batch request.
+- **Severity: WARNING**
+- **Recommendation**: Use Batch Operations: If the SDK provides a batch operation API, use it to perform multiple actions in a single request.
\ No newline at end of file

From f7d0d2c8d9cb2b2c5872423ce937149b262242e8 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 6 Jul 2024 12:55:39 -0700
Subject: [PATCH 048/144] complete implementation of
 GetSyncPollerOnPollerFluxCheck with test

---
 .../GetSyncPollerOnPollerFluxCheck.java       | 154 +++++++++++++-----
 .../main/resources/META-INF/ruleConfigs.json  |   5 +
 .../GetSyncPollerOnPollerFluxCheckTest.java   |  72 +++++---
 3 files changed, 166 insertions(+), 65 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
index dce2420f767..060aa369821 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
@@ -9,75 +9,130 @@
 import com.intellij.psi.PsiType;
 import com.intellij.psi.util.PsiTreeUtil;
 import org.jetbrains.annotations.NotNull;
-
-
+import org.json.JSONObject;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+/**
+ * Inspection tool to detect the use of getSyncPoller() on a PollerFlux.
+ * The inspection will check if the method call is on a PollerFlux and if the method call is on an Azure SDK client.
+ * If both conditions are met, the inspection will register a problem with the suggestion to use SyncPoller instead.
+ *
+ * This is an example of an anti-pattern that would be detected by the inspection tool.
+ * public void exampleUsage() {
+ *         PollerFlux<String> pollerFlux = createPollerFlux();
+ *
+ *         // Anti-pattern: Using getSyncPoller() on PollerFlux
+ *         SyncPoller<String, Void> syncPoller = pollerFlux.getSyncPoller();
+ *     }
+ */
 public class GetSyncPollerOnPollerFluxCheck extends LocalInspectionTool {
 
+    /**
+     * Method to build the visitor for the inspection tool.
+     * @param holder Holder for the problems found by the inspection
+     * @param isOnTheFly Flag to indicate if the inspection is running on the fly
+     * @return JavaElementVisitor a visitor to visit the method call expressions
+     */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         return new GetSyncPollerOnPollerFluxVisitor(holder, isOnTheFly);
     }
 
-
+    /**
+     * Visitor class to visit the method call expressions and check for the use of getSyncPoller() on a PollerFlux.
+     * The visitor will check if the method call is on a PollerFlux and if the method call is on an Azure SDK client.
+     */
     public static class GetSyncPollerOnPollerFluxVisitor extends JavaElementVisitor {
 
+        // Instance variables
         private final ProblemsHolder holder;
         private final boolean isOnTheFly;
 
+        private static String METHOD_TO_CHECK = "";
+        private static String ANTI_PATTERN_MESSAGE = "";
+
+        private static final Logger LOGGER = Logger.getLogger(GetSyncPollerOnPollerFluxCheck.class.getName());
+
+
+        // Load the config file
+        static {
+            try {
+                List<String> ruleConfigList = getRuleConfigs();
+
+                // extract the method to check and the anti-pattern message from the config file
+                METHOD_TO_CHECK = ruleConfigList.get(0);
+                ANTI_PATTERN_MESSAGE = ruleConfigList.get(1);
+
+            } catch (IOException e) {
+                LOGGER.log(Level.SEVERE, "Error loading rule data", e);
+            }
+        }
 
+        /**
+         * Constructor to initialize the visitor with the holder and isOnTheFly flag.
+         * @param holder Holder for the problems found by the inspection
+         * @param isOnTheFly Flag to indicate if the inspection is running on the fly
+         */
         public GetSyncPollerOnPollerFluxVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
             this.isOnTheFly = isOnTheFly;
         }
 
+        /**
+         * Method to visit the method call expressions and check for the use of getSyncPoller() on a PollerFlux.
+         * @param expression Method call expression to visit
+         */
         @Override
         public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
             super.visitMethodCallExpression(expression);
 
             // Check if the element is a method call expression
-            if (expression instanceof PsiMethodCallExpression) {
-                PsiMethodCallExpression methodCall = expression;
+            if (!(expression instanceof PsiMethodCallExpression)) {
+                return;
+            }
 
-                // Check if the method call is getSyncPoller
-                if (methodCall.getMethodExpression().getReferenceName().startsWith("getSyncPoller")) {
-                    System.out.println("methodCall: " + methodCall);
-                    System.out.println("methodCall.getReferenceName(): " + methodCall.getMethodExpression().getReferenceName());
-                    boolean isAsyncContext = checkIfAsyncContext(methodCall);
+            PsiMethodCallExpression methodCall = expression;
 
-                    if(isAsyncContext && isAzureClient(methodCall)) {
-                        holder.registerProblem(expression, "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks");
-                    }
+            // Check if the method call is getSyncPoller
+            if (methodCall.getMethodExpression().getReferenceName().startsWith(METHOD_TO_CHECK)) {
+                boolean isAsyncContext = checkIfAsyncContext(methodCall);
 
+                if (isAsyncContext && isAzureClient(methodCall)) {
+                    holder.registerProblem(expression, ANTI_PATTERN_MESSAGE);
                 }
             }
         }
 
-
         /**
          * Helper method to check if the method call is within an async context.
-         * This method will check if the method call is on a reactive type like Mono, Flux, etc.
+         * This method will check if the method call is on a PollerFlux type.
          *
-         * @param methodCall
+         * @param methodCall Method call expression to check
          * @return true if the method call is on a reactive type, false otherwise
          */
         private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
             PsiExpression expression = methodCall.getMethodExpression().getQualifierExpression();
 
             // Check if the method call is on a reactive type
-            if (expression != null) {
-                PsiType type = expression.getType();
-
-                // Check if the type is a reactive type
-                if (type != null) {
-                    String typeName = type.getCanonicalText();
-                    System.out.println("typeName: " + typeName);
-
-                    // Check for PollerFlux type
-                    if (typeName != null && typeName.contains("PollerFlux")) {
-                        return true;
-                    }
-                }
+            if (expression == null) {
+                return false;
+            }
+            PsiType type = expression.getType();
+
+            // Check if the type is a reactive type
+            if (type == null) {
+                return false;
+            }
+            String typeName = type.getCanonicalText();
+
+            // Check for PollerFlux type
+            if (typeName != null && typeName.contains("PollerFlux")) {
+                return true;
             }
             return false;
         }
@@ -85,7 +140,7 @@ private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall)
         /**
          * Helper method to check if the method call is on an Azure SDK client.
          * This method will check if the method call is on a class that is part of the Azure SDK.
-         * @param methodCall
+         * @param methodCall Method call expression to check
          * @return true if the method call is on an Azure SDK client, false otherwise
          */
         private boolean isAzureClient (@NotNull PsiMethodCallExpression methodCall){
@@ -93,19 +148,38 @@ private boolean isAzureClient (@NotNull PsiMethodCallExpression methodCall){
             PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
 
             // Check if the method call is on a class
-            if (containingClass != null) {
-                String className = containingClass.getQualifiedName();
-                System.out.println("className: " + className);
+            if (containingClass == null) {
+                return false;
+            }
+            String className = containingClass.getQualifiedName();
 
-                // Check if the class is part of the Azure SDK
-                if (className != null && className.startsWith("com.azure.")) {
-                    return true;
-                }
+            // Check if the class is part of the Azure SDK
+            if (className != null && className.startsWith("com.azure.")) {
+                return true;
             }
-            return false;
+        return false;
         }
 
-    }
-}
+        /**
+         * Helper method to load the rule configurations from the config file.
+         * @return List of strings containing the method to check and the anti-pattern message
+         * @throws IOException if there is an error loading the config file
+         */
+        private static List<String> getRuleConfigs() throws IOException {
+
+            String ruleName = "GetSyncPollerOnPollerFluxCheck";
+            String antiPatternMessageKey = "antipattern_message";
+            String methodToCheckKey = "method_to_check";
 
+            //load json object
+            JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
 
+            // extract string from json object
+            String antiPatternMessage = jsonObject.getJSONObject(ruleName).getString(antiPatternMessageKey);
+            String methodToCheck = jsonObject.getJSONObject(ruleName).getString(methodToCheckKey);
+
+            // return list of strings
+            return List.of(methodToCheck, antiPatternMessage);
+        }
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d0361d1b107..fdaffa67da6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -10,5 +10,10 @@
   "ServiceBusReceiverAsyncClientCheck": {
     "client_name": "ServiceBusReceiverAsyncClient",
     "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+  },
+
+  "GetSyncPollerOnPollerFluxCheck": {
+    "method_to_check": "getSyncPoller",
+    "antipattern_message": "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
index 34bbc1230c7..35722c52c88 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
@@ -1,6 +1,5 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
-
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiClass;
@@ -22,6 +21,19 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+/**
+ * Test class for the GetSyncPollerOnPollerFluxCheck inspection tool.
+ * The test class will test the visitor's ability to detect the use of getSyncPoller() on a PollerFlux
+ * and register a problem with the suggestion message.
+ *
+ * This is an example of an anti-pattern that would be detected by the inspection tool.
+ * public void exampleUsage() {
+ *         PollerFlux<String> pollerFlux = createPollerFlux();
+ *
+ *         // Anti-pattern: Using getSyncPoller() on PollerFlux
+ *         SyncPoller<String, Void> syncPoller = pollerFlux.getSyncPoller();
+ *     }
+ */
 public class GetSyncPollerOnPollerFluxCheckTest {
 
     // Declare as instance variables
@@ -41,21 +53,12 @@ public void setup() {
         mockElement = mock(PsiMethodCallExpression.class);
     }
 
-
-    private JavaElementVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        GetSyncPollerOnPollerFluxVisitor visitor = new GetSyncPollerOnPollerFluxVisitor(mockHolder, isOnTheFly);
-        return visitor;
-    }
-
-
     /**
      * Test to verify if the visitor is able to detect the use of getSyncPoller() on a PollerFlux
      * and register a problem with the suggestion message.
      */
     @Test
     public void testGetSyncPollerOnPollerFluxCheck() {
-
         assertVisitor();
 
         String methodName = "getSyncPoller";
@@ -64,49 +67,70 @@ public void testGetSyncPollerOnPollerFluxCheck() {
         verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
-
+    /**
+     * Test to verify if the visitor is not flagged when a different method name is used.
+     * The visitor should not register a problem in this case.
+     */
     @Test
     public void testGetSyncPollerOnPollerFluxCheckWithDifferentMethodName() {
 
-        assertVisitor();
-
         String methodName = "getAnotherMethod";
         String packageName = "com.azure.core.util.polling.PollerFlux";
         int numberOfInvocations = 0;
         verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
-
+    /**
+     * Test to verify if the visitor is not flagged when a different package name is used.
+     * The visitor should not register a problem in this case.
+     */
     @Test
     public void testGetSyncPollerOnPollerFluxCheckWithDifferentPackageName() {
 
-        assertVisitor();
-
         String methodName = "getSyncPoller";
         String packageName = "com.azure.core.util.polling.DifferentPackageName";
         int numberOfInvocations = 0;
         verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
-
+    /**
+     * Test to verify if the visitor is not flagged when the package name is null.
+     * The visitor should not register a problem in this case.
+     */
     @Test
     public void testGetSyncPollerOnPollerFluxCheckWithNullPackageName() {
 
-        assertVisitor();
-
         String methodName = "getSyncPoller";
         String packageName = null;
         int numberOfInvocations = 0;
         verifyRegisterProblem(methodName, packageName, numberOfInvocations);
     }
 
+    /**
+     * A helper method to create the visitor for the test.
+     * @return JavaElementVisitor
+     */
+    private JavaElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        GetSyncPollerOnPollerFluxVisitor visitor = new GetSyncPollerOnPollerFluxVisitor(mockHolder, isOnTheFly);
+        return visitor;
+    }
 
-
+    /**
+     * A helper method to assert the visitor is not null and is an instance of JavaElementVisitor.
+     */
     private void assertVisitor() {
         assertNotNull(mockVisitor);
         assertTrue(mockVisitor instanceof JavaElementVisitor);
     }
 
+    /**
+     * A helper method to verify if the visitor is able to detect the use of getSyncPoller() on a PollerFlux
+     * and register a problem with the suggestion message.
+     * @param methodName The method name to be used in the test
+     * @param packageName The package name to be used in the test
+     * @param numberOfInvocations The number of times registerProblem should be called
+     */
     private void verifyRegisterProblem(String methodName, String packageName, int numberOfInvocations) {
 
         PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
@@ -117,12 +141,9 @@ private void verifyRegisterProblem(String methodName, String packageName, int nu
 
         when(mockElement.getMethodExpression()).thenReturn(referenceExpression);
         when(referenceExpression.getReferenceName()).thenReturn(methodName);
-
         when(referenceExpression.getQualifierExpression()).thenReturn(expression);
         when(expression.getType()).thenReturn(type);
         when(type.getCanonicalText()).thenReturn(packageName);
-
-
         when(mockTreeUtil.getParentOfType(mockElement, PsiClass.class)).thenReturn(containingClass);
         when(containingClass.getQualifiedName()).thenReturn(packageName);
 
@@ -130,6 +151,7 @@ private void verifyRegisterProblem(String methodName, String packageName, int nu
         mockVisitor.visitMethodCallExpression(mockElement);
 
         // Verify registerProblem is not called
-        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"));
+        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement),
+                Mockito.contains("Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"));
     }
-}
+}
\ No newline at end of file

From b064cb4be2c03af083c296acc9b14f8789948320 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 6 Jul 2024 13:03:20 -0700
Subject: [PATCH 049/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md          | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3175be77e54..9ef0c7b2638 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -24,8 +24,14 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 
 2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
 - **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
-
 - **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+3. #### Use SyncPoller Instead of getSyncPoller() on PollerFlux
+- **Anti-pattern**: Using `getSyncPoller()` on a `PollerFlux` instance is an anti-pattern. 
+- **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
+- **Severity: WARNING**
+- **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
+  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
\ No newline at end of file

From 4bc0d0880385221670e6074893337461f501f20d Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 7 Jul 2024 20:54:51 -0700
Subject: [PATCH 050/144] completion of TelemetryClientProvider

---
 .../CONTRIBUTING.MD                           |  47 ++++++--
 .../buildtool/TelemetryClientProvider.java    | 101 +++++++++++++-----
 .../azure-intellij-plugin-azure-sdk.xml       |   2 +-
 3 files changed, 116 insertions(+), 34 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
index 957875451ac..7de070be2cc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
@@ -1,15 +1,48 @@
 ### Configuring MS Application Insights
+
+#### Prerequisites
 - An Azure account with an active subscription.
 
 #### 1. Generate the Instrumentation Key
 
+1. **Log in to the Azure Portal**: Go to the [Azure Portal](https://portal.azure.com/).
+
+2. **Create a new Application Insights resource**:
+    - In the Azure Portal, click on `Create a resource`.
+    - Search for `Application Insights` and select it.
+    - Click `Create`.
+    - Fill in the required fields such as `Name`, `Subscription`, `Resource Group`, and `Region`.
+    - Click `Review + create`, then click `Create`.
+
+3. **Get the Instrumentation Key**:
+    - After the resource is created, navigate to the Application Insights resource.
+    - In the left-hand menu, under `Configure`, click on `Properties`.
+    - Copy the `Instrumentation Key`.
+
 #### 2. Add the Instrumentation Key to the Application
 
-Add it to the `applicationinsights.json` file located in the `resources/META-INF` directory of the `azure-intellij-plugin-azure-sdk` project.
-```json
-{
-  "instrumentationKey": "your-instrumentation-key-goes-here"
-}
-```
+1. **Create `applicationinsights.json`**:
+    - Navigate to the `resources/META-INF` directory of your project. If the directory doesn't exist, create it.
+    - Create a file named `applicationinsights.json` in the `resources/META-INF` directory.
+
+2. **Add the Instrumentation Key to `applicationinsights.json`**:
+    - Open the `applicationinsights.json` file and add the following JSON content:
+   ```json
+   {
+     "instrumentationKey": "your-instrumentation-key-goes-here"
+   }
+   ```
+    - Replace `"your-instrumentation-key-goes-here"` with the actual instrumentation key you copied from the Azure Portal.
+
+#### 3. Add `applicationinsights.json` to `.gitignore`
+
+To prevent exposing your instrumentation key in version control, add the `applicationinsights.json` file to your `.gitignore` file.
+
+1. **Open `.gitignore`**:
+    - If you don't have a `.gitignore` file in your project root, create one.
 
-#### 3. Add `applicationinsights.json` to `.gitignore`
\ No newline at end of file
+2. **Add `applicationinsights.json` to `.gitignore`**:
+    - Add the following line to the `.gitignore` file:
+   ```
+   resources/META-INF/applicationinsights.json
+   ```
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 28c6d2b65ba..5ee1324d8ac 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -25,21 +25,23 @@
 public class TelemetryClientProvider extends LocalInspectionTool {
 
     private static final TelemetryClient telemetryClient = getTelemetryClient();
-    private static final ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
     private static Project project;
 
-    private static final Map<String, Integer> methodCounts = new HashMap<>();
+    private static final Map<String, Map<String, Integer>> methodCounts = new HashMap<>();
 
-    public static void setProject(Project project) {
-        System.out.println("Setting project.");
-        TelemetryClientProvider.project = project;
-        startTelemetryService();
-    }
 
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        Project project = holder.getProject();
-        TelemetryClientProvider.setProject(project);
+
+        if (TelemetryClientProvider.project == null) {
+            System.out.println("Project is null. startTelemetryService() called.");
+
+            startTelemetryService();
+        }
+        project = holder.getProject();
+
+        System.out.println("Building visitor.");
+
         // Reset the methodCounts map for each new visitor
         methodCounts.clear();
         return new JavaElementVisitor() {
@@ -51,50 +53,97 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
 
                 PsiReferenceExpression methodExpression = expression.getMethodExpression();
                 String methodName = methodExpression.getReferenceName();
-                System.out.println("Method tracked.");
+                String clientName = getClientName(expression); // Method to get client name
+
+                if (methodName == null) {
+                    return;
+                }
+
+                if (clientName != null) {
+                    synchronized (methodCounts) {
+
+                        // Increment the count of the method call for the client
+                        methodCounts
+                                .computeIfAbsent(clientName, k -> new HashMap<>())
+                                .put(methodName, methodCounts.get(clientName).getOrDefault(methodName, 0) + 1);
+                    }
+                }
+            }
+
 
-                synchronized (methodCounts) {
-                    // Increment the count of the method call
-                    methodCounts.put(methodName, methodCounts.getOrDefault(methodName, 0) + 1);
+            private String getClientName(PsiMethodCallExpression expression) {
+                // Logic to extract client name from the method call expression
+                PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
+                if (qualifier != null) {
+                    PsiType type = qualifier.getType();
+                    if (type != null && type.getCanonicalText().startsWith("com.azure")) {
+                        return type.getPresentableText();
+                    }
                 }
-                System.out.println(methodCounts.toString() + " method counts.");
+                return null;
             }
         };
     }
 
 
+
+
     private static void sendTelemetryData() {
-        System.out.println("Sending telemetry data sent at." + new Date().toString());
+        System.out.println("Sending telemetry data sent at " + new Date().toString());
 
-        // print the time of the last event (using this to verify that the telemetry is being sent)
-        telemetryClient.trackEvent("Telemetry data sent at " + new Date().toString());
+        // Outer loop: Iterate over each client entry in the methodCounts map
+        for (Map.Entry<String, Map<String, Integer>> clientEntry : methodCounts.entrySet()) {
+            String clientName = clientEntry.getKey();  // Extract the client name
+            Map<String, Integer> methods = clientEntry.getValue();  // Extract the methods map for this client
 
-        System.out.println(methodCounts.toString() + " sendTelemetryData method counts.");
+            // Inner loop: Iterate over each method entry in the methods map
+            for (Map.Entry<String, Integer> methodEntry : methods.entrySet()) {
+                String methodName = methodEntry.getKey();  // Extract the method name
+                int count = methodEntry.getValue();  // Extract the call count for this method
 
-        for (Map.Entry<String, Integer> entry : methodCounts.entrySet()) {
-            String methodName = entry.getKey();
-            int count = entry.getValue();
+                // Report as metric
+                telemetryClient.trackMetric("azure_sdk_usage_frequency", (double) count);
 
-            telemetryClient.trackMetric("Method in use " + methodName, count);
-            telemetryClient.trackEvent("Method in use " + methodName);
-        }
+                // Create custom dimensions map
+                Map<String, String> customDimensions = new HashMap<>();
+                customDimensions.put("clientName", clientName);
+                customDimensions.put("methodName", methodName);
+
+                /// Convert count to a double and create a properties map
+                Map<String, Double> properties = new HashMap<>();
+                properties.put("count", (double) count);
 
+                // Report as event
+                telemetryClient.trackEvent("azure_sdk_usage_frequency", customDimensions, properties);
+            }
+        }
         telemetryClient.flush();
     }
 
     private static void startTelemetryService() {
+
+        // Using a single-threaded ScheduledExecutorService
+        ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
+
         executorService.scheduleAtFixedRate(() ->
-            TelemetryClientProvider.sendTelemetryData(), 2, 3, TimeUnit.MINUTES);
+            TelemetryClientProvider.sendTelemetryData(), 1, 2, TimeUnit.MINUTES);
     }
 
-
+    /**
+     * This method reads the instrumentation key from the applicationinsights.json file
+     * and returns a TelemetryClient object with the instrumentation key set.
+     * This object is used to send telemetry data to Application Insights.
+     * @return
+     */
     public static TelemetryClient getTelemetryClient() {
 
+        // Create a new TelemetryClient object
         TelemetryClient telemetry;
         telemetry = new TelemetryClient();
 
         String instrumentationKey = null;
 
+        // Read the instrumentation key from the applicationinsights.json file
         try {
             InputStream inputStream = TelemetryClient.class.getClassLoader().getResourceAsStream("META-INF/applicationinsights.json");
             if (inputStream == null) {
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 7709ebe3221..daec973e314 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -31,7 +31,7 @@
                 groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryClientProvider">
-            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.MavenProjectInspection</class>
+            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryClientProvider</class>
         </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From 5b158d1f935f6bcac223d14371df75235541a0c8 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 10:08:55 -0700
Subject: [PATCH 051/144] completion of TelemetryClientProvider with tests

---
 .../CONTRIBUTING.MD                           |  36 +++-
 .../buildtool/TelemetryClientProvider.java    | 167 +++++++++++-------
 .../META-INF/applicationInsights.json         |   3 +
 .../TelemetryClientProviderTest.java          |  22 ++-
 4 files changed, 163 insertions(+), 65 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
index 7de070be2cc..0e4e3c25a6b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
@@ -45,4 +45,38 @@ To prevent exposing your instrumentation key in version control, add the `applic
     - Add the following line to the `.gitignore` file:
    ```
    resources/META-INF/applicationinsights.json
-   ```
\ No newline at end of file
+   ```
+
+#### 4. App Insights Configuration in Code
+1. **Accurate Tracking of Method Calls**:
+   - The `visitMethodCallExpression` method tracks the number of times each method of each client is called.
+   - The `methodCounts` map stores counts in a nested map structure, where the outer map's key is the client name, and the value is another map. This inner map's key is the method name, and the value is the count of calls to that method.
+
+2. **Periodic Reporting of Data**:
+   - The `startTelemetryService` method schedules the `sendTelemetryData` method to run at fixed intervals (every 3 minutes, starting 2 minutes after the service starts).
+   - Each execution of `sendTelemetryData` will report the accumulated counts since the last report.
+
+3. **Structured Telemetry Events**:
+   - Each method call count is reported as an event with the name `azure_sdk_usage_frequency`.
+   - Custom dimensions are added to these events, including:
+      - `clientName`: The name of the client (e.g., `BlobClient`).
+      - `methodName`: The name of the method (e.g., `download`).
+      - `count`: The count of calls to the method (e.g., `5`), stored as a string.
+
+### Sample Output
+
+The telemetry system will generate events that can be queried and analyzed. Here is an example of what the telemetry data might look like:
+
+#### Event 1
+- **Name**: `azure_sdk_usage_frequency`
+- **Custom Dimensions**:
+   - `clientName`: `BlobClient`
+   - `methodName`: `download`
+   - `count`: `5`
+
+#### Event 2
+- **Name**: `azure_sdk_usage_frequency`
+- **Custom Dimensions**:
+   - `clientName`: `BlobClient`
+   - `methodName`: `upload`
+   - `count`: `3`
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index d5cd744d85e..954e1a7dece 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -1,29 +1,44 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
-import com.intellij.codeInspection.*;
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.openapi.project.Project;
-import com.intellij.psi.*;
-import com.microsoft.applicationinsights.TelemetryClient;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
 import java.io.FileNotFoundException;
 
-import java.util.*;
-
+import com.microsoft.applicationinsights.TelemetryClient;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
 import java.io.InputStream;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
-import java.util.concurrent.*;
-import java.util.stream.Collectors;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 
 /**
- * This class reads the instrumentation key from the applicationinsights.json file
+ * This class reads the instrumentation key from the applicationInsights.json file
  * and returns a TelemetryClient object with the instrumentation key set.
  * This object is used to send telemetry data to Application Insights.
  */
 public class TelemetryClientProvider extends LocalInspectionTool {
 
+    /**
+     * This method is called by the IntelliJ platform to build a visitor for the inspection.
+     * @param holder
+     * @param isOnTheFly
+     * @return
+     */
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -33,34 +48,49 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
         return new TelemetryClientProviderVisitor(holder, isOnTheFly);
     }
 
-
+    /**
+     * This class is a visitor that visits the method calls in the code and tracks the method calls.
+     */
     public static class TelemetryClientProviderVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
         private final boolean isOnTheFly;
 
+        // Create a TelemetryClient object
+        // not final because the test involves Injecting the mock telemetry client to telemetryClient
+        // Package-private to allow access from tests in the same package
         static TelemetryClient telemetryClient = getTelemetryClient();
+        // Create a map to store the method counts
+        static Map<String, Map<String, Integer>> methodCounts = new HashMap<>();
+
+        // Create a Project object
         private static Project project;
 
-        static Map<String, Map<String, Integer>> methodCounts = new HashMap<>();
+        // Create a logger object
+        private static final Logger LOGGER= Logger.getLogger(TelemetryClientProvider.class.getName());
 
 
-        // This constructor is used to create a visitor for the inspection
+        /** This constructor is used to create a visitor for the inspection
+         * It initializes the holder and isOnTheFly fields.
+         * @param holder The ProblemsHolder object that holds the problems found in the code.
+         * @param isOnTheFly A boolean that indicates if the inspection is running on the fly.
+         */
         public TelemetryClientProviderVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
             this.isOnTheFly = isOnTheFly;
 
+            // Initialize start telemetry service when project is null
+            // This is to ensure that the telemetry service is started only once
             if (project == null) {
-                System.out.println("Project is null. startTelemetryService() called.");
-
                 startTelemetryService();
             }
             project = holder.getProject();
-
-            System.out.println("Building visitor.");
         }
 
-        //  will only track the methods that are being called in the code
+        /**  will only track the methods that are being called in the code
+         * This method is called when a method call expression is visited.
+         * @param expression The method call expression that is visited.
+         */
         @Override
         public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
             super.visitMethodCallExpression(expression);
@@ -84,6 +114,12 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
             }
         }
 
+        /**
+         * This method extracts the client name from the method call expression.
+         * It checks if the method call expression is from an Azure SDK client.
+         * @param expression The method call expression.
+         * @return The client name extracted from the method call expression.
+         */
         private String getClientName(PsiMethodCallExpression expression) {
             // Logic to extract client name from the method call expression
             PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
@@ -96,59 +132,23 @@ private String getClientName(PsiMethodCallExpression expression) {
             return null;
         }
 
+        /**
+         * This method starts the telemetry service.
+         * It creates a single-threaded ScheduledExecutorService and
+         * schedules the telemetry data to be sent every 2 minutes.
+         */
         static void startTelemetryService() {
-
-            System.out.println("Starting telemetry service.");
-
-            // Using a single-threaded ScheduledExecutorService
             ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
 
             executorService.scheduleAtFixedRate(() ->
-                    TelemetryClientProviderVisitor.sendTelemetryData(), 1, 2, TimeUnit.MINUTES);
+                    TelemetryClientProviderVisitor.sendTelemetryData(), 2, 3, TimeUnit.MINUTES);
         }
 
         /**
-         * This method reads the instrumentation key from the applicationinsights.json file
-         * and returns a TelemetryClient object with the instrumentation key set.
-         * This object is used to send telemetry data to Application Insights.
-         *
-         * @return
+         * This method sends the telemetry data to Application Insights.
+         * It sends the method counts as events.
          */
-        public static TelemetryClient getTelemetryClient() {
-
-            // Create a new TelemetryClient object
-            TelemetryClient telemetry;
-            telemetry = new TelemetryClient();
-
-            String instrumentationKey = null;
-
-            // Read the instrumentation key from the applicationinsights.json file
-            try {
-                InputStream inputStream = TelemetryClient.class.getClassLoader().getResourceAsStream("META-INF/applicationinsights.json");
-                if (inputStream == null) {
-                    throw new FileNotFoundException("File not found on classpath");
-                }
-
-                BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
-                String json = reader.lines().collect(Collectors.joining("\n"));
-                reader.close();
-
-                JSONObject jsonObject = new JSONObject(json);
-                instrumentationKey = jsonObject.getString("instrumentationKey");
-
-                System.out.println(instrumentationKey);
-
-            } catch (Exception e) {
-                throw new RuntimeException("Could not read the instrumentation key from the applicationinsights.json file.");
-            }
-            telemetry.getContext().setInstrumentationKey(instrumentationKey);
-            return telemetry;
-        }
-
         static void sendTelemetryData() {
-            System.out.println("Sending telemetry data sent at " + new Date().toString());
-
-            System.out.println("methodCounts: " + methodCounts);
 
             // Outer loop: Iterate over each client entry in the methodCounts map
             for (Map.Entry<String, Map<String, Integer>> clientEntry : methodCounts.entrySet()) {
@@ -160,9 +160,6 @@ static void sendTelemetryData() {
                     String methodName = methodEntry.getKey();  // Extract the method name
                     int count = methodEntry.getValue();  // Extract the call count for this method
 
-                    // Report as metric
-                    telemetryClient.trackMetric("azure_sdk_usage_frequency", (double) count);
-
                     // Create custom dimensions map
                     Map<String, String> customDimensions = new HashMap<>();
                     customDimensions.put("clientName", clientName);
@@ -178,5 +175,49 @@ static void sendTelemetryData() {
             }
             telemetryClient.flush();
         }
+
+        /**
+         * This method reads the instrumentation key from the applicationInsights.json file
+         * and returns a TelemetryClient object with the instrumentation key set.
+         * This object is used to send telemetry data to Application Insights.
+         *
+         * @return A TelemetryClient object with the instrumentation key set.
+         */
+        static TelemetryClient getTelemetryClient() {
+
+            String configFilePath = "META-INF/applicationInsights.json";
+            String instrumentationKeyJsonKey = "instrumentationKey";
+
+            // Create a new TelemetryClient object
+            TelemetryClient telemetry = new TelemetryClient();
+            StringBuilder jsonBuilder = new StringBuilder();
+
+            // Read the instrumentation key from the applicationInsights.json file
+            try (InputStream inputStream = TelemetryClient.class.getClassLoader().getResourceAsStream(configFilePath);
+                 BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream))) {
+                if (inputStream == null) {
+                    LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + configFilePath
+                            + ". Please ensure the file exists and is accessible.", new FileNotFoundException());
+                    return telemetry; // Return the telemetry client even if the config file is not found
+                }
+
+                // while loop to read the json file
+                // this is more memory efficient than reading the entire file at once and holding it in memory
+                String line;
+                while ((line = reader.readLine()) != null) {
+                    jsonBuilder.append(line).append("\n");
+                }
+
+                JSONObject jsonObject = new JSONObject(jsonBuilder.toString());
+                String instrumentationKey = jsonObject.getString(instrumentationKeyJsonKey);
+                telemetry.getContext().setInstrumentationKey(instrumentationKey);
+
+            } catch (Exception e) {
+                LOGGER.log(Level.SEVERE, "Unexpected error while loading instrumentation key"
+                        + ". Please investigate further.", e);
+            }
+
+            return telemetry;
+        }
     }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
new file mode 100644
index 00000000000..cc7152279b8
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
@@ -0,0 +1,3 @@
+{
+  "instrumentationKey":"your-instrumentation-key-goes-here"
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
index 66f5b8d8df7..99998ae68cc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
@@ -25,7 +25,10 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
-
+/**
+ * This class tests the TelemetryClientProvider class.
+ * It tests the buildVisitor, visitMethodCallExpression, and sendTelemetryData methods.
+ */
 public class TelemetryClientProviderTest {
 
     @Mock
@@ -44,6 +47,10 @@ public void setUp() {
         TelemetryClientProviderVisitor.methodCounts = new HashMap<>();
     }
 
+    /**
+     * This test method tests the buildVisitor method.
+     * It asserts that the visitor is not null and is an instance of JavaElementVisitor.
+     */
     @Test
     public void testBuildVisitor() {
 
@@ -51,6 +58,10 @@ public void testBuildVisitor() {
         assertVisitor();
     }
 
+    /**
+     * This test method tests the visitMethodCallExpression method.
+     * It tests the method with an Azure package to ensure the method count is incremented correctly.
+     */
     @Test
     public void testVisitMethodCallExpressionWithAzurePackage() {
 
@@ -84,6 +95,10 @@ public void testVisitMethodCallExpressionWithAzurePackage() {
         }
     }
 
+    /**
+     * This test method tests the visitMethodCallExpression method.
+     * It tests the method with a non-Azure package to ensure the methodcount list is not incremented.
+     */
     @Test
     public void testVisitMethodCallExpressionWithNonAzurePackage() {
 
@@ -112,6 +127,10 @@ public void testVisitMethodCallExpressionWithNonAzurePackage() {
 
     }
 
+    /**
+     * This test method tests the sendTelemetryData method.
+     * It tests that the telemetry data is sent correctly.
+     */
     @Test
     public void testSendTelemetryData() {
         // Populate methodCounts with test data
@@ -131,6 +150,7 @@ public void testSendTelemetryData() {
         verify(mockTelemetryClient, times(1)).flush();
     }
 
+    // Helper method to create a visitor
     JavaElementVisitor createVisitor() {
         boolean isOnTheFly = false;
         TelemetryClientProviderVisitor visitor = new TelemetryClientProviderVisitor(mockProblemsHolder, false);

From 8ba32e685a6c29ee86459bfa3f5808ff565eecf2 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 10:10:08 -0700
Subject: [PATCH 052/144] minor tweak to tests

---
 .../azure/sdk/buildtool/TelemetryClientProviderTest.java      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
index 99998ae68cc..96d4cb66ead 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
@@ -151,7 +151,7 @@ public void testSendTelemetryData() {
     }
 
     // Helper method to create a visitor
-    JavaElementVisitor createVisitor() {
+    private JavaElementVisitor createVisitor() {
         boolean isOnTheFly = false;
         TelemetryClientProviderVisitor visitor = new TelemetryClientProviderVisitor(mockProblemsHolder, false);
 
@@ -159,7 +159,7 @@ JavaElementVisitor createVisitor() {
     }
 
     // Helper method to assert visitor is not null and is an instance of JavaElementVisitor
-    void assertVisitor() {
+    private void assertVisitor() {
 
         assertNotNull(mockVisitor);
         assertTrue(mockVisitor instanceof JavaElementVisitor);

From c51a7a8d1117541cc7b4e4b1ce5b986dd69378af Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 10:28:32 -0700
Subject: [PATCH 053/144] address PR comments

---
 .../sdk/buildtool/ConnectionStringCheck.java  | 25 ++++--
 .../sdk/buildtool/LoadJsonConfigFile.java     | 78 ++++++++++++-------
 2 files changed, 66 insertions(+), 37 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
index 9ebd0910d8d..dfcc110ae4c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -1,5 +1,6 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
+import com.google.gson.JsonParseException;
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
@@ -12,6 +13,7 @@
 
 import org.jetbrains.annotations.NotNull;
 
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -27,7 +29,7 @@ public class ConnectionStringCheck extends LocalInspectionTool {
      * This method builds the visitor for the inspection tool.
      * @param holder ProblemsHolder to register problems
      * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type.
-     * @return
+     * @return PsiElementVisitor visitor to inspect elements in the code
      */
     @NotNull
     @Override
@@ -56,16 +58,25 @@ public static class ConnectionStringVisitor extends JavaElementVisitor {
                 LoadJsonConfigFile config = LoadJsonConfigFile.getInstance();
                 METHOD_TO_CHECK = config.getMethodToCheck(ruleName);
                 SUGGESTION = config.getSuggestionMessage(ruleName);
+            } catch (FileNotFoundException e) {
+                LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + LoadJsonConfigFile.CONFIG_FILE_PATH
+                        + ". Please ensure the file exists and is accessible. Error: " + e.getMessage(), e);
+            } catch (JsonParseException e) {
+                LOGGER.log(Level.SEVERE, "Configuration file is not a valid JSON at path: " + LoadJsonConfigFile.CONFIG_FILE_PATH
+                        + ". Please check the file format. Error: " + e.getMessage(), e);
             } catch (IOException e) {
-                // make a descriptive message
-                LOGGER.log(Level.SEVERE, "Failed to load JSON configuration for rule '" + ruleName + "' from expected path: " + LoadJsonConfigFile.CONFIG_FILE_PATH, e);
+                LOGGER.log(Level.SEVERE, "IO error while reading configuration file from path: " + LoadJsonConfigFile.CONFIG_FILE_PATH
+                        + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
+            } catch (Exception e) {
+                LOGGER.log(Level.SEVERE, "Unexpected error while loading configuration for rule '" + ruleName
+                        + "'. Please investigate further. Error: " + e.getMessage(), e);
             }
         }
 
         /**
          * Constructor to initialize the visitor with the holder and isOnTheFly flag.
-         * @param holder     ProblemsHolder
-         * @param isOnTheFly boolean
+         * @param holder     ProblemsHolder to register problems
+         * @param isOnTheFly boolean to check if the inspection is on the fly
          */
         public ConnectionStringVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
@@ -76,7 +87,7 @@ public ConnectionStringVisitor(ProblemsHolder holder, boolean isOnTheFly) {
          * This method visits the element in the code.
          * It checks if the method call is a connection string call and if the class is an Azure client.
          * If both conditions are met, a problem is registered with the suggestion message.
-         * @param element PsiElement
+         * @param element PsiElement to visit
          */
         @Override
         public void visitElement(@NotNull PsiElement element) {
@@ -92,7 +103,7 @@ public void visitElement(@NotNull PsiElement element) {
                 PsiElement resolvedMethod = methodExpression.resolve();
 
                 // check if the method is a connectionString call
-                if (resolvedMethod != null && resolvedMethod instanceof PsiElement && ((PsiMethod) resolvedMethod).getName().equals(METHOD_TO_CHECK)) {
+                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod && ((PsiMethod) resolvedMethod).getName().equals(METHOD_TO_CHECK)) {
                     PsiMethod method = (PsiMethod) resolvedMethod;
 
                     // containingClass is the client class that is being called. check if the class is an azure client
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
index e8e39b86c5a..41ef0ce6af7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -7,8 +7,11 @@
 import java.io.InputStreamReader;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 import java.util.stream.Collectors;
 
+import com.google.gson.JsonParseException;
 import org.json.JSONArray;
 import org.json.JSONObject;
 
@@ -30,14 +33,17 @@ public class LoadJsonConfigFile {
     static final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
     static final String PACKAGE_NAME = "com.azure";
 
+    private static final Logger LOGGER = Logger.getLogger(LoadJsonConfigFile.class.getName());
+
+
     // The constructor is private, so it can't be called from outside the class
     private LoadJsonConfigFile() throws IOException {
         loadJsonObject();
     }
 
     /** The getInstance method returns the single instance of the class, creating it if it doesn't exist
-     * @return LoadJsonConfigFile
-     * @throws IOException
+     * @return LoadJsonConfigFile instance of the class
+     * @throws IOException if the configuration file is not found
      */
     public static synchronized LoadJsonConfigFile getInstance() throws IOException {
         if (instance == null) {
@@ -47,7 +53,7 @@ public static synchronized LoadJsonConfigFile getInstance() throws IOException {
     }
 
     /** Load the JSON object from the configuration file
-     * @throws IOException
+     * @throws IOException if the configuration file is not found
      */
     private void loadJsonObject() throws IOException {
 
@@ -58,16 +64,24 @@ private void loadJsonObject() throws IOException {
             try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
                 jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
             }
+        } catch (FileNotFoundException e) {
+            LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + CONFIG_FILE_PATH
+                    + ". Please ensure the file exists and is accessible. Error: " + e.getMessage(), e);
+        } catch (JsonParseException e) {
+            LOGGER.log(Level.SEVERE, "Configuration file is not a valid JSON at path: " + CONFIG_FILE_PATH
+                    + ". Please check the file format. Error: " + e.getMessage(), e);
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "IO error while reading configuration file from path: " + CONFIG_FILE_PATH
+                    + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
         } catch (Exception e) {
-            // Log the error message
-            System.err.println("Error loading JSON configuration: " + e.getMessage());
-            // Rethrow the exception
-            throw e;
+            LOGGER.log(Level.SEVERE, "Unexpected error while loading configuration. " + "Please investigate further. Error: " + e.getMessage(), e);
         }
+
     }
 
-    /**The getJsonObject method returns the loaded JSON object
-     * @return JSONObject
+    /**
+     * The getJsonObject method returns the loaded JSON object
+     * @return JSONObject loaded JSON object
      */
     public JSONObject getJsonObject() {
         return jsonObject;
@@ -76,9 +90,9 @@ public JSONObject getJsonObject() {
 
     /** Method to get the value for a given rule name and key as an Object
      * If the rule name exists and has the key, return the value
-     * @param ruleName
-     * @param key
-     * @return Object
+     * @param ruleName String rule name
+     * @param key String key
+     * @return Object value for the key
      */
     private Object getConfigValue(String ruleName, String key) {
         if (jsonObject.has(ruleName)) {
@@ -90,9 +104,10 @@ private Object getConfigValue(String ruleName, String key) {
         return null;
     }
 
-    /** Method to get the methods to check for a given rule name, which is a List of Strings
-     * @param ruleName
-     * @return List<String>
+    /**
+     * Method to get the methods to check for a given rule name, which is a List of Strings
+     * @param ruleName String rule name
+     * @return List<String> methods to check
      */
     public List<String> getMethodsToCheck(String ruleName) {
         String key = "methods_to_check";
@@ -102,17 +117,18 @@ public List<String> getMethodsToCheck(String ruleName) {
 
     /** Method to get the method to check for a given rule name, which is a String
      * If the rule name exists and has the key, return the value
-     * @param ruleName
-     * @return String
+     * @param ruleName String rule name
+     * @return String method to check
      */
     public String getMethodToCheck(String ruleName) {
         String key = "method_to_check";
         return (String) getConfigValue(ruleName, key);
     }
 
-    /** Method to get the client name for a given rule name
-     * @param ruleName
-     * @return
+    /**
+     * Method to get the client name for a given rule name
+     * @param ruleName String rule name
+     * @return String client name
      */
     public String getClientName(String ruleName) {
         String key = "client_name";
@@ -120,27 +136,29 @@ public String getClientName(String ruleName) {
     }
 
     /** Method to get the suggestion message for a given rule name
-     * @param ruleName
-     * @return String
+     * @param ruleName String rule name
+     * @return String suggestion message
      */
     public String getSuggestionMessage(String ruleName) {
         String key = "antipattern_message";
         return (String) getConfigValue(ruleName, key);
     }
 
-    /** Method to get the solution for a given rule name
-     * @param ruleName
-     * @return
+    /**
+     * Method to get the solution for a given rule name
+     * @param ruleName String rule name
+     * @return String solution
      */
     public String getSolution(String ruleName) {
         String key = "solution";
         return (String) getConfigValue(ruleName, key);
     }
 
-    /** Method to process the methods to check based on its type
+    /**
+     * Method to process the methods to check based on its type
      * If the methods to check is a JSONArray, return a List of Strings
-     * @param methodsToCheck
-     * @return
+     * @param methodsToCheck Object methods to check
+     * @return List<String> methods to check
      */
     private List<String> processMethodsToCheck(Object methodsToCheck) {
         List<String> methods = new ArrayList<>();
@@ -154,8 +172,8 @@ private List<String> processMethodsToCheck(Object methodsToCheck) {
     }
 
     /** Method to get all information for a given rule name
-     * @param ruleName
-     * @return
+     * @param ruleName String rule name
+     * @return JSONObject rule details
      */
     public JSONObject getCheckDetails(String ruleName) {
         return jsonObject.optJSONObject(ruleName);

From 0e42c14b06d73e1d249611d1e1b868316eea4506 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 11:36:17 -0700
Subject: [PATCH 054/144] minor update

---
 .../KustoQueriesWithTimeIntervalInQueryStringCheck.java       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index dd6b1688868..a6a2559b8ef 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -62,10 +62,10 @@ public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean i
      * Processing of polyadic expressions is also done to replace the variables with their values in the query string
      * before checking for the anti-patterns.
      */
-    public static class KustoQueriesVisitor extends JavaElementVisitor {
+    class KustoQueriesVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
-        private final boolean isOnTheFly;
+        private final boolean isOnTheFly; // boolean to indicate if the inspection is done on the fly
 
         // Define constants for string literals
         private static final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";

From 9fa65e544fa6ae71a8133f86da0dc5efaf6c9057 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 12:37:57 -0700
Subject: [PATCH 055/144] address PR comments

---
 .../sdk/buildtool/ConnectionStringCheck.java  |  4 +-
 .../sdk/buildtool/LoadJsonConfigFile.java     | 61 ++++++++----------
 .../main/resources/META-INF/ruleConfigs.json  |  2 +-
 .../buildtool/ConnectionStringCheckTest.java  | 64 ++++++++++---------
 4 files changed, 63 insertions(+), 68 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
index dfcc110ae4c..5aed8615ad4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
@@ -56,8 +56,8 @@ public static class ConnectionStringVisitor extends JavaElementVisitor {
 
             try {
                 LoadJsonConfigFile config = LoadJsonConfigFile.getInstance();
-                METHOD_TO_CHECK = config.getMethodToCheck(ruleName);
-                SUGGESTION = config.getSuggestionMessage(ruleName);
+                METHOD_TO_CHECK = config.getMethodsToCheck(ruleName).get(0);
+                SUGGESTION = config.getAntiPatternMessage(ruleName);
             } catch (FileNotFoundException e) {
                 LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + LoadJsonConfigFile.CONFIG_FILE_PATH
                         + ". Please ensure the file exists and is accessible. Error: " + e.getMessage(), e);
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
index 41ef0ce6af7..89b0c5ebb13 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -28,7 +28,7 @@ public class LoadJsonConfigFile {
 
     // The instance variable holds the single instance of the class
     private static LoadJsonConfigFile instance;
-    private JSONObject jsonObject;
+    private final JSONObject jsonObject = loadJsonObject();
 
     static final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
     static final String PACKAGE_NAME = "com.azure";
@@ -37,7 +37,7 @@ public class LoadJsonConfigFile {
 
 
     // The constructor is private, so it can't be called from outside the class
-    private LoadJsonConfigFile() throws IOException {
+    private LoadJsonConfigFile() {
         loadJsonObject();
     }
 
@@ -55,14 +55,15 @@ public static synchronized LoadJsonConfigFile getInstance() throws IOException {
     /** Load the JSON object from the configuration file
      * @throws IOException if the configuration file is not found
      */
-    private void loadJsonObject() throws IOException {
+    private JSONObject loadJsonObject(){
+        JSONObject tempObject = null;
 
-        try (InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
+        try (InputStream inputStream = LoadJsonConfigFile.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
             if (inputStream == null) {
                 throw new FileNotFoundException("Configuration file not found");
             }
             try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
-                jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
+                tempObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
             }
         } catch (FileNotFoundException e) {
             LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + CONFIG_FILE_PATH
@@ -76,7 +77,7 @@ private void loadJsonObject() throws IOException {
         } catch (Exception e) {
             LOGGER.log(Level.SEVERE, "Unexpected error while loading configuration. " + "Please investigate further. Error: " + e.getMessage(), e);
         }
-
+        return tempObject;
     }
 
     /**
@@ -88,17 +89,21 @@ public JSONObject getJsonObject() {
     }
 
 
-    /** Method to get the value for a given rule name and key as an Object
+    /**
+     * Base Method to get the value for a given rule name and key as an Object
      * If the rule name exists and has the key, return the value
+     * eg getConfigValue("ConnectionStringCheck", "method_to_check")
+     * this will return the value for the key "method_to_check" in the rule "ConnectionStringCheck"
+     *
      * @param ruleName String rule name
      * @param key String key
      * @return Object value for the key
      */
-    private Object getConfigValue(String ruleName, String key) {
+    private String getConfigurationValueByRuleAndKey(String ruleName, String key) {
         if (jsonObject.has(ruleName)) {
             JSONObject ruleConfig = jsonObject.getJSONObject(ruleName);
             if (ruleConfig.has(key)) {
-                return ruleConfig.get(key);
+                return ruleConfig.get(key).toString();
             }
         }
         return null;
@@ -111,18 +116,15 @@ private Object getConfigValue(String ruleName, String key) {
      */
     public List<String> getMethodsToCheck(String ruleName) {
         String key = "methods_to_check";
-        Object value = getConfigValue(ruleName, key);
-        return processMethodsToCheck(value);
-    }
+        Object value =  jsonObject.getJSONObject(ruleName).get(key);
 
-    /** Method to get the method to check for a given rule name, which is a String
-     * If the rule name exists and has the key, return the value
-     * @param ruleName String rule name
-     * @return String method to check
-     */
-    public String getMethodToCheck(String ruleName) {
-        String key = "method_to_check";
-        return (String) getConfigValue(ruleName, key);
+        // check if value is a JsonString
+        if (value instanceof String) {
+            List<String> methods = new ArrayList<>();
+            methods.add((String) value);
+            return methods;
+        }
+        return processMethodsToCheck(value);
     }
 
     /**
@@ -132,26 +134,17 @@ public String getMethodToCheck(String ruleName) {
      */
     public String getClientName(String ruleName) {
         String key = "client_name";
-        return (String) getConfigValue(ruleName, key);
+        return getConfigurationValueByRuleAndKey(ruleName, key);
     }
 
-    /** Method to get the suggestion message for a given rule name
+    /**
+     * Method to get the suggestion message for a given rule name
      * @param ruleName String rule name
      * @return String suggestion message
      */
-    public String getSuggestionMessage(String ruleName) {
+    public String getAntiPatternMessage(String ruleName) {
         String key = "antipattern_message";
-        return (String) getConfigValue(ruleName, key);
-    }
-
-    /**
-     * Method to get the solution for a given rule name
-     * @param ruleName String rule name
-     * @return String solution
-     */
-    public String getSolution(String ruleName) {
-        String key = "solution";
-        return (String) getConfigValue(ruleName, key);
+        return getConfigurationValueByRuleAndKey(ruleName, key);
     }
 
     /**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 422c074d5e1..4212bae3f36 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -13,7 +13,7 @@
   },
 
   "ConnectionStringCheck": {
-    "method_to_check": "connectionString",
+    "methods_to_check": "connectionString",
     "antipattern_message" : "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
     "solution": "DefaultAzureCredential is recommended if the service client supports Token Credential (Entra ID Authentication). if not, then use Azure Key Credential / Connection Strings based authentication"
   }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
index 6bf0a9216d2..3639e020c24 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
@@ -27,8 +27,6 @@
  * This class tests the ConnectionStringCheck class.
  * It tests the buildVisitor method and the visitElement method.
  * It tests the check for the usage of connection strings API to create clients in the Azure SDK for Java.
- *
- * This
  */
 public class ConnectionStringCheckTest {
 
@@ -72,61 +70,64 @@ private PsiElementVisitor createVisitor() {
     public void testConnectionStringCheck() {
 
         assertVisitor(mockVisitor);
-        String METHOD_TO_CHECK = "connectionString";
-        int NUMBER_OF_INVOCATIONS = 1;
-        String CLASS_NAME = "com.azure";
+        String methodToCheck = "connectionString";
+        int numOfInvocations = 1;
+        String packageName = "com.azure";
 
-        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
     }
 
-    /** Problem isn't registered because the method to check is different from the method that should be flagged
+    /** Problem isn't registered because the method to check is different
+     * from the method that should be flagged
      */
     @Test
     public void differentMethodCheck() {
-        String METHOD_TO_CHECK = "differentMethod";
-        int NUMBER_OF_INVOCATIONS = 0;
-        String CLASS_NAME = "com.azure";
+        String methodToCheck = "differentMethod";
+        int numOfInvocations = 0;
+        String packageName = "com.azure";
 
-        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
     }
 
-    /** Problem isn't registered because the class name is different from the class that should be flagged
+    /** Problem isn't registered because the class name is different
+     * from the class that should be flagged
      */
     @Test
     public void differentClassCheck() {
-        String METHOD_TO_CHECK = "connectionString";
-        int NUMBER_OF_INVOCATIONS = 0;
-        String CLASS_NAME = "com.microsoft.azure";
+        String methodToCheck = "connectionString";
+        int numOfInvocations = 0;
+        String packageName = "com.microsoft.azure";
 
-        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
     }
 
-    /**  Problem isn't registered because the class name is null
+    /**
+     * Problem isn't registered because the class name is null
      */
     @Test
     public void nullClassCheck() {
-        String METHOD_TO_CHECK = "connectionString";
-        int NUMBER_OF_INVOCATIONS = 0;
-        String CLASS_NAME = null;
+        String methodToCheck = "connectionString";
+        int numOfInvocations = 0;
+        String packageName = null;
 
-        verifyRegisterProblem(mockVisitor, METHOD_TO_CHECK, NUMBER_OF_INVOCATIONS, CLASS_NAME);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
     }
 
     /**  Asserts that the visitor is not null and is an instance of JavaElementVisitor
-     * @param visitor PsiElementVisitor
+     * @param visitor PsiElementVisitor visitor to inspect elements in the code
      */
     private void assertVisitor(PsiElementVisitor visitor) {
         assertNotNull(visitor);
         assertTrue(visitor instanceof JavaElementVisitor);
     }
 
-    /**  Verifies that a warning is raised when a connection string being used to create a client is detected.
-     * @param visitor PsiElementVisitor
-     * @param METHOD_TO_CHECK String
-     * @param NUMBER_OF_INVOCATIONS int
-     * @param CLASS_NAME String
+    /** Verifies that a warning is raised when a connection string being used to create a client is detected.
+     * @param visitor PsiElementVisitor visitor to inspect elements in the code
+     * @param methodToCheck String method to check for in the code
+     * @param numOfInvocations int number of times registerProblem should be called
+     * @param packageName String package name of the class
      */
-    private void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_CHECK, int NUMBER_OF_INVOCATIONS, String CLASS_NAME) {
+    private void verifyRegisterProblem(PsiElementVisitor visitor, String methodToCheck, int numOfInvocations, String packageName) {
 
         PsiMethodCallExpression methodCallExpression = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
@@ -137,12 +138,13 @@ private void verifyRegisterProblem(PsiElementVisitor visitor, String METHOD_TO_C
         when(methodCallExpression.getMethodExpression()).thenReturn(methodExpression);
         when(methodExpression.resolve()).thenReturn(resolvedMethod);
         when(resolvedMethod.getContainingClass()).thenReturn(containingClass);
-        when(resolvedMethod.getName()).thenReturn(METHOD_TO_CHECK);
-        when(containingClass.getQualifiedName()).thenReturn(CLASS_NAME);
+        when(resolvedMethod.getName()).thenReturn(methodToCheck);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
 
         (visitor).visitElement(methodCallExpression);
 
         // Verify problem is registered
-        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(Mockito.eq(methodCallExpression), Mockito.contains("Connection String detected. Use DefaultAzureCredential for azure service client authentication instead."));
+        verify(mockHolder, times(numOfInvocations)).registerProblem(Mockito.eq(methodCallExpression),
+                Mockito.contains("Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication)."));
     }
 }

From 9a7c2096426eaffea5aeaef0fedb41f21f5d74b9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 13:14:50 -0700
Subject: [PATCH 056/144] refactor to add named class

---
 .../DetectDiscouragedClientCheck.java         | 114 ++++++++++--------
 .../DetectDiscouragedClientCheckTest.java     |  12 +-
 2 files changed, 70 insertions(+), 56 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
index fdf5a41a6e6..30fb18dbb0e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
@@ -2,7 +2,6 @@
 
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiTypeElement;
 import org.jetbrains.annotations.NotNull;
@@ -23,73 +22,84 @@
 
 public class DetectDiscouragedClientCheck extends LocalInspectionTool {
 
-    private static Map<String, String> CLIENT_DATA;
+    @NotNull
+    @Override
+    public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder,boolean isOnTheFly){
+        return new DetectDiscouragedClientVisitor(holder,isOnTheFly);
+    }
+
+    public static class DetectDiscouragedClientVisitor extends JavaElementVisitor {
 
-    // Define constants for string literals
-    private static final String RULE_NAME = "DetectDiscouragedClientCheck";
-    private static final String SUGGESTION_KEY = "antipattern_message";
-    private static final String CLIENT_NAME_KEY = "client_name";
-    private static final Logger LOGGER = Logger.getLogger(DetectDiscouragedClientCheck.class.getName());
+        // Define the fields for the visitor
+        private final boolean isOnTheFly;
+        private final ProblemsHolder holder;
 
-    static {
-        try {
-            CLIENT_DATA = getClientToCheck();
-        } catch (IOException e) {
-            LOGGER.log(Level.SEVERE, "Error loading client data", e);
+        // Constructor for the visitor
+        public DetectDiscouragedClientVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+            this.isOnTheFly = isOnTheFly;
         }
-    }
 
-    /**
-     * This method builds a visitor to check for the discouraged client name in the code.
-     * If the client name matches the discouraged client, a problem is registered with the suggestion message.
-     * @param holder
-     * @param isOnTheFly
-     * @return PsiElementVisitor
-     */
-    @NotNull
-    @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new JavaElementVisitor() {
+        private static Map<String, String> CLIENT_DATA;
 
-            @Override
-            public void visitTypeElement(PsiTypeElement element) {
-                super.visitTypeElement(element);
+        // Define constants for string literals
+        private static final String RULE_NAME = "DetectDiscouragedClientCheck";
+        private static final String SUGGESTION_KEY = "antipattern_message";
+        private static final String CLIENT_NAME_KEY = "client_name";
+        private static final Logger LOGGER = Logger.getLogger(DetectDiscouragedClientCheck.class.getName());
 
-                // Check if the element is an instance of PsiTypeElement
-                if (element instanceof PsiTypeElement && element.getType() != null) {
+        static {
+            try {
+                CLIENT_DATA = getClientToCheck();
+            } catch (IOException e) {
+                LOGGER.log(Level.SEVERE, "Error loading client data", e);
+            }
+        }
+
+        /**
+         * This method builds a visitor to check for the discouraged client name in the code.
+         * If the client name matches the discouraged client, a problem is registered with the suggestion message.
+         */
+        @Override
+        public void visitTypeElement(PsiTypeElement element) {
+            super.visitTypeElement(element);
+
+            // Check if the element is an instance of PsiTypeElement
+            if (element instanceof PsiTypeElement && element.getType() != null) {
 
-                    String elementType = element.getType().getPresentableText();
+                String elementType = element.getType().getPresentableText();
 
-                    // Use the map to get the suggestion message
-                    String suggestion = CLIENT_DATA.get(elementType);
+                // Use the map to get the suggestion message
+                String suggestion = CLIENT_DATA.get(elementType);
 
-                    // Register a problem if the client used matches a discouraged client
-                    if (suggestion != null) {
-                        holder.registerProblem(element, suggestion);
-                    }
+                // Register a problem if the client used matches a discouraged client
+                if (suggestion != null) {
+                    holder.registerProblem(element, suggestion);
                 }
             }
         };
-    }
 
-    /**
-     * Loading the client data from the configuration file.
-     * The client data is stored in a JSON object with the client name as the key and the suggestion message as the value.
-     * @return
-     */
 
-    static Map<String, String> getClientToCheck() throws IOException {
-        JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
-        JSONObject clientData = jsonObject.getJSONObject(RULE_NAME);
+        /**
+         * Loading the client data from the configuration file.
+         * The client data is stored in a JSON object with the client name as the key and the suggestion message as the value.
+         *
+         * @return
+         */
+
+        static Map<String, String> getClientToCheck() throws IOException {
+            JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+            JSONObject clientData = jsonObject.getJSONObject(RULE_NAME);
 
-        Map<String, String> clientToCheckMap = new HashMap<>();
+            Map<String, String> clientToCheckMap = new HashMap<>();
 
-        // iterate over the keys in the JSON object to get clients to check and their corresponding messages.
-        for (String key : clientData.keySet()) {
-            String clientName = clientData.getJSONObject(key).getString(CLIENT_NAME_KEY);
-            String suggestion = clientData.getJSONObject(key).getString(SUGGESTION_KEY);
-            clientToCheckMap.put(clientName, suggestion);
+            // iterate over the keys in the JSON object to get clients to check and their corresponding messages.
+            for (String key : clientData.keySet()) {
+                String clientName = clientData.getJSONObject(key).getString(CLIENT_NAME_KEY);
+                String suggestion = clientData.getJSONObject(key).getString(SUGGESTION_KEY);
+                clientToCheckMap.put(clientName, suggestion);
+            }
+            return clientToCheckMap;
         }
-        return clientToCheckMap;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
index 5e0e43453f8..a697b60e65c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
@@ -6,6 +6,7 @@
 import com.intellij.psi.PsiTypeElement;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.PsiType;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedClientCheck.DetectDiscouragedClientVisitor;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
@@ -134,12 +135,14 @@ public void testProblemNotRegisteredWhenClientIsEmpty() {
      * @return PsiElementVisitor
      */
     private PsiElementVisitor createVisitor() {
-        DetectDiscouragedClientCheck check = new DetectDiscouragedClientCheck();
+
         boolean isOnTheFly = true;
-        return check.buildVisitor(mockHolder, isOnTheFly);
+        DetectDiscouragedClientVisitor mockVisitor = new DetectDiscouragedClientVisitor(mockHolder, isOnTheFly);
+        return mockVisitor;
     }
 
-    /** Assert that the visitor is not null and is an instance of JavaElementVisitor
+    /**
+     * Assert that the visitor is not null and is an instance of JavaElementVisitor
      * to ensure that the visitor is created correctly.
      */
     private void assertVisitor() {
@@ -147,7 +150,8 @@ private void assertVisitor() {
         assertTrue(mockVisitor instanceof JavaElementVisitor);
     }
 
-    /** Visit a Type Element and verify that a problem was registered
+    /**
+     * Visit a Type Element and verify that a problem was registered
      * when the ServiceBusReceiverAsyncClient is used.
      * @param typeElement The PsiTypeElement to visit
      * @param numberOfInvocations The number of times registerProblem should be called

From b996d1c840f938dfdec7f97196caf00c064466d5 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 13:45:35 -0700
Subject: [PATCH 057/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/readme.md                 | 2 +-
 .../src/main/resources/META-INF/ruleConfigs.json              | 4 ++--
 .../sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index e48d79acd17..bf08ab649bb 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -26,4 +26,4 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Anti-pattern**: Hardcoding API keys and tokens in the source code.
 - **Issue**: The source code contains hardcoded API keys and tokens, which is a security risk. It exposes sensitive information that could be exploited if the code is publicly accessible or falls into the wrong hands.
 - **Severity**: WARNING.
-- **Recommendation**: Use secretless authentication with DefaultAzureCredential to avoid exposing sensitive information. This method provides a more secure way of handling API keys and tokens. [Click here for more details](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
\ No newline at end of file
+- **Recommendation**: DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 818ae69f4af..5bc77f48909 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -1,8 +1,8 @@
 {
   "HardcodedAPIKeysAndTokensCheck": {
     "clients_to_check": ["AzureKeyCredential", "AccessToken"],
-    "anti_pattern_message": "Use of API keys or tokens in code is not recommended. We recommend Secretless authentication through DefaultAzureCredential.",
-    "solution": "We recommend Secretless authentication through DefaultAzureCredential."
+    "anti_pattern_message": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication.",
+    "solution": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication."
   },
 
     "StorageUploadWithoutLengthCheck": {
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
index 5ded4a9981e..835a8586503 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
@@ -128,7 +128,7 @@ void verifyRegisterProblem(String CLIENT_TO_CHECK, int NUMBER_OF_INVOCATIONS) {
 
         // Verify registerProblem is called
         verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(eq(newExpression),
-                Mockito.contains("Use of API keys or tokens in code is not recommended. " +
-                        "We recommend Secretless authentication through DefaultAzureCredential"));
+                Mockito.contains("DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). " +
+                        "If not, then use Azure Key Credential for API key based authentication."));
     }
 }

From d177ee4aadd1e3a1e3767ae909ec0ead8ddd4b60 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 14:51:28 -0700
Subject: [PATCH 058/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/readme.md | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index bf08ab649bb..58e99b0fa08 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -12,18 +12,25 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 
 ## User Interface
-- **Telemetry Configuration Panel**: This space allows users to enable or disable telemetry if desired.
-- 
+- **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
+
+
 ## Rules
 1. #### Storage Upload without Length Check
-- **Anti-Pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
 - **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
-- **Severity**: INFO. 
-- **Recommendation**: Use APIs that take a length parameter. [Click here for more details](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java)
+- **Severity: INFO**
+- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
 
+2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
+- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
+- **Severity: WARNING**
+- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
 
-2. #### Hardcoded APIs & Access Tokens Check
+3. #### Hardcoded APIs & Access Tokens Check
 - **Anti-pattern**: Hardcoding API keys and tokens in the source code.
 - **Issue**: The source code contains hardcoded API keys and tokens, which is a security risk. It exposes sensitive information that could be exploited if the code is publicly accessible or falls into the wrong hands.
 - **Severity**: WARNING.
-- **Recommendation**: DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
+- **Recommendation**: DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for additional information.
\ No newline at end of file

From 2f826c722a6da7c6ef30424c3891547d3714d238 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 16:12:23 -0700
Subject: [PATCH 059/144] addressing PR comments

---
 .../sdk/buildtool/LoadJsonConfigFile.java     | 51 ++++++++++++-------
 1 file changed, 32 insertions(+), 19 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
index 89b0c5ebb13..e6e50929ef7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
@@ -6,7 +6,9 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
@@ -28,7 +30,7 @@ public class LoadJsonConfigFile {
 
     // The instance variable holds the single instance of the class
     private static LoadJsonConfigFile instance;
-    private final JSONObject jsonObject = loadJsonObject();
+    private final JSONObject JSON_OBJECT = loadJsonObject();
 
     static final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
     static final String PACKAGE_NAME = "com.azure";
@@ -85,7 +87,7 @@ private JSONObject loadJsonObject(){
      * @return JSONObject loaded JSON object
      */
     public JSONObject getJsonObject() {
-        return jsonObject;
+        return JSON_OBJECT;
     }
 
 
@@ -99,32 +101,41 @@ public JSONObject getJsonObject() {
      * @param key String key
      * @return Object value for the key
      */
-    private String getConfigurationValueByRuleAndKey(String ruleName, String key) {
-        if (jsonObject.has(ruleName)) {
-            JSONObject ruleConfig = jsonObject.getJSONObject(ruleName);
+    private Map<String, String> getRuleConfigurationValue(String ruleName, String key) {
+        Map<String, String> resultMap = new HashMap<>();
+        if (JSON_OBJECT.has(ruleName)) {
+            JSONObject ruleConfig = JSON_OBJECT.getJSONObject(ruleName);
             if (ruleConfig.has(key)) {
-                return ruleConfig.get(key).toString();
+                // Assuming all values are Strings or can be represented as Strings
+                resultMap.put(key, ruleConfig.getString(key));
             }
         }
-        return null;
+        return resultMap;
     }
 
     /**
      * Method to get the methods to check for a given rule name, which is a List of Strings
+     * or a singular String
      * @param ruleName String rule name
-     * @return List<String> methods to check
+     * @return List<String> methods to check. If the value is a singular String, return a List with one element
      */
     public List<String> getMethodsToCheck(String ruleName) {
         String key = "methods_to_check";
-        Object value =  jsonObject.getJSONObject(ruleName).get(key);
 
-        // check if value is a JsonString
-        if (value instanceof String) {
-            List<String> methods = new ArrayList<>();
-            methods.add((String) value);
-            return methods;
+        if (JSON_OBJECT.has(ruleName)) {
+            JSONObject ruleConfig = JSON_OBJECT.getJSONObject(ruleName);
+            if (ruleConfig.has(key) && ruleConfig.get(key) instanceof String) {
+                // If it's a string, convert it to a list with one element
+                String method = ruleConfig.getString(key);
+                return List.of(method);
+            } else if (ruleConfig.has(key) && ruleConfig.get(key) instanceof JSONArray) {
+                // If it's a JSONArray, process it
+                return processMethodsToCheck(ruleConfig.getJSONArray(key));
+            } else {
+                LOGGER.log(Level.WARNING, "No methods to check found for rule: " + ruleName);
+            }
         }
-        return processMethodsToCheck(value);
+        return new ArrayList<>();
     }
 
     /**
@@ -134,7 +145,8 @@ public List<String> getMethodsToCheck(String ruleName) {
      */
     public String getClientName(String ruleName) {
         String key = "client_name";
-        return getConfigurationValueByRuleAndKey(ruleName, key);
+        Map<String, String> ruleConfig = getRuleConfigurationValue(ruleName, "client_name");
+        return ruleConfig.get(key);
     }
 
     /**
@@ -144,7 +156,8 @@ public String getClientName(String ruleName) {
      */
     public String getAntiPatternMessage(String ruleName) {
         String key = "antipattern_message";
-        return getConfigurationValueByRuleAndKey(ruleName, key);
+        Map<String, String> ruleConfig = getRuleConfigurationValue(ruleName, "antipattern_message");
+        return ruleConfig.get(key);
     }
 
     /**
@@ -153,7 +166,7 @@ public String getAntiPatternMessage(String ruleName) {
      * @param methodsToCheck Object methods to check
      * @return List<String> methods to check
      */
-    private List<String> processMethodsToCheck(Object methodsToCheck) {
+    private List<String> processMethodsToCheck(JSONArray methodsToCheck) {
         List<String> methods = new ArrayList<>();
          if (methodsToCheck instanceof JSONArray) {
             JSONArray jsonArray = (JSONArray) methodsToCheck;
@@ -169,6 +182,6 @@ private List<String> processMethodsToCheck(Object methodsToCheck) {
      * @return JSONObject rule details
      */
     public JSONObject getCheckDetails(String ruleName) {
-        return jsonObject.optJSONObject(ruleName);
+        return JSON_OBJECT.optJSONObject(ruleName);
     }
 }
\ No newline at end of file

From 055fea32553516edcc7c09fa2ed2e68f74cfeffa Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 8 Jul 2024 21:58:05 -0700
Subject: [PATCH 060/144] modification to make rule specific to Text Analytics
 APIs

---
 .../buildtool/SingleOperationInLoopCheck.java | 149 ++++++++----------
 .../main/resources/META-INF/ruleConfigs.json  |   1 +
 .../SingleOperationInLoopCheckTest.java       | 138 +++++++---------
 3 files changed, 121 insertions(+), 167 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
index 644fc943526..8df3540163e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
@@ -21,40 +21,31 @@
 import com.intellij.psi.util.PsiTreeUtil;
 
 import org.jetbrains.annotations.NotNull;
+import org.json.JSONArray;
 import org.json.JSONObject;
 
 import java.io.IOException;
+import java.util.List;
+import java.util.Map;
 import java.util.logging.Logger;
 
 /**
- * Inspection to check if there is a single Azure client operation inside a loop.
- * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
- * If a single Azure client operation is found inside a loop, a problem will be registered.
+ * Inspection to check if there is a Text Analytics client operation inside a loop.
+ * If a Text Analytics client operation is found inside a loop,
+ * and the API has a batch alternative, a problem will be registered.
  *
  * THis is an example of a situation where the inspection should register a problem:
  *
- * 1. With a single PsiDeclarationStatement inside a while loop
- * // While loop
- *         int i = 0;
- *         while (i < 10) {
- *
- *             BlobAsyncClient blobAsyncClient = new BlobClientBuilder()
- *                 .endpoint("https://<your-storage-account-name>.blob.core.windows.net")
- *                 .sasToken("<your-sas-token>")
- *                 .containerName("<your-container-name>")
- *                 .blobName("<your-blob-name>")
- *                 .buildAsyncClient();
- *
- *             i++;
- *         }
- *
- * 2. With a single PsiExpressionStatement inside a for loop
- * for (String documentPath : documentPaths) {
- *
- *             blobAsyncClient.uploadFromFile(documentPath)
- *                 .doOnSuccess(response -> System.out.println("Blob uploaded successfully in enhanced for loop."))
- *                 .subscribe();
- *         }
+ * // Loop through the list of texts and detect the language for each text
+*         1. for (String text : texts) {
+*             DetectedLanguage detectedLanguage = textAnalyticsClient.detectLanguage(text);
+*             System.out.println("Text: " + text + " | Detected Language: " + detectedLanguage.getName() + " | Confidence Score: " + detectedLanguage.getConfidenceScore());
+*         }
+*
+*         // Loop through the list of texts and detect the language for each text
+*        2.  DetectedLanguage detectedLanguage = null;
+*         for (String text : texts) {
+*             textAnalyticsClient.detectLanguage(text);
  */
 public class SingleOperationInLoopCheck extends LocalInspectionTool {
 
@@ -73,13 +64,13 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
     /**
      * Visitor class to traverse the PSI tree and check for single Azure client operation inside a loop.
      * The visitor will check for loops of type for, foreach, while, and do-while.
-     * The visitor will check for single Azure client operation inside the loop body.
-     * If a single Azure client operation is found, a problem will be registered.
+     * The visitor will check for a Text Analytics client operation inside the loop.
+     * If a Text Analytics client operation is found inside the loop, and the API has a batch alternative, a problem will be registered.
      */
     public static class SingleOperationInLoopVisitor extends JavaElementVisitor {
 
         // Define the holder for the problems found and whether the inspection is running on the fly
-        private final ProblemsHolder holder;
+        private static ProblemsHolder holder = null;
         private final boolean isOnTheFly;
 
         // Define the logger for the visitor
@@ -88,9 +79,17 @@ public static class SingleOperationInLoopVisitor extends JavaElementVisitor {
         // Define the suggestion message for the problem
         private static String SUGGESTION = "";
 
+        private static List<String> AVAILABLE_BATCH_METHODS;
+
+        // Load the config file
         static {
             try {
-                SUGGESTION = getRuleConfigs();
+                Map<String, Object> ruleConfigsMap = getRuleConfigs();
+
+                // extract the async return types to check
+                AVAILABLE_BATCH_METHODS = (List<String>) ruleConfigsMap.get("methods_to_check");
+                SUGGESTION = (String) ruleConfigsMap.get("antipattern_message");
+
             } catch (IOException e) {
                 LOGGER.severe("Failed to load rule configurations");
             }
@@ -112,7 +111,7 @@ public SingleOperationInLoopVisitor(ProblemsHolder holder, boolean isOnTheFly) {
          */
         @Override
         public void visitForStatement(@NotNull PsiForStatement statement) {
-            checkLoopForSingleClientOperation(statement);
+            checkLoopForTextAnalyticsClientOperation(statement);
         }
 
         /**
@@ -121,7 +120,7 @@ public void visitForStatement(@NotNull PsiForStatement statement) {
          */
         @Override
         public void visitForeachStatement(@NotNull PsiForeachStatement statement) {
-            checkLoopForSingleClientOperation(statement);
+            checkLoopForTextAnalyticsClientOperation(statement);
         }
 
         /**
@@ -130,7 +129,7 @@ public void visitForeachStatement(@NotNull PsiForeachStatement statement) {
          */
         @Override
         public void visitWhileStatement(@NotNull PsiWhileStatement statement) {
-            checkLoopForSingleClientOperation(statement);
+            checkLoopForTextAnalyticsClientOperation(statement);
         }
 
         /**
@@ -139,38 +138,21 @@ public void visitWhileStatement(@NotNull PsiWhileStatement statement) {
          */
         @Override
         public void visitDoWhileStatement(@NotNull PsiDoWhileStatement statement) {
-            checkLoopForSingleClientOperation(statement);
+            checkLoopForTextAnalyticsClientOperation(statement);
         }
 
-        /**
-         * Check if there is a single Azure client operation inside the loop.
-         * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
-         * If a single Azure client operation is found, a problem will be registered.
-         * @param loopStatement The loop statement to check
-         */
-        private void checkLoopForSingleClientOperation(PsiStatement loopStatement) {
-
-            // Count the number of Azure client operations inside the loop
-            int numOfAzureClientOperations = countAzureClientOperations(loopStatement);
-            if (numOfAzureClientOperations == 1) {
-                holder.registerProblem(loopStatement, SUGGESTION);
-            }
-        }
 
         /**
-         * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
-         * If an Azure client operation is found, the count will be incremented.
+         * Check the loop statement for a single Text Analytics Azure client operation inside the loop.
          * @param loopStatement The loop statement to check
          */
-        private int countAzureClientOperations(PsiStatement loopStatement) {
-
-            int numOfAzureClientOperations = 0;
+        private boolean checkLoopForTextAnalyticsClientOperation(PsiStatement loopStatement) {
 
             // extract body of the loop
             PsiStatement loopBody = getLoopBody(loopStatement);
 
             if (loopBody == null) {
-                return 0;
+                return false;
             }
 
             // Extract the code block from the block statement
@@ -180,23 +162,17 @@ private int countAzureClientOperations(PsiStatement loopStatement) {
             // extract statements in the loop body
             for (PsiStatement statement : codeBlock.getStatements()) {
 
-                // Check if the statement is an expression statement and is an Azure client operation
-                if (statement instanceof PsiExpressionStatement &&
-                        isExpressionAzureClientOperation(statement)) {
-
-                    // Increment the count of Azure client operations if the expression statement is an Azure client operation
-                    numOfAzureClientOperations++;
+                    // Check if the statement is an expression statement and is an Azure client operation
+                if (statement instanceof PsiExpressionStatement) {
+                        isExpressionAzureClientOperation(statement);
                 }
 
                 // Check if the statement is a declaration statement and is an Azure client operation
-                if (statement instanceof PsiDeclarationStatement &&
-                        isDeclarationAzureClientOperation((PsiDeclarationStatement) statement)) {
-
-                    // Increment the count of Azure client operations if the declaration statement is an Azure client operation
-                    numOfAzureClientOperations++;
+                if (statement instanceof PsiDeclarationStatement) {
+                        isDeclarationAzureClientOperation((PsiDeclarationStatement) statement);
                 }
             }
-            return numOfAzureClientOperations;
+            return true;
         }
 
 
@@ -221,19 +197,17 @@ public static PsiStatement getLoopBody(PsiStatement loopStatement) {
          * @param statement The statement to check
          * @return True if the statement is an Azure client operation, false otherwise
          */
-        private boolean isExpressionAzureClientOperation(PsiStatement statement) {
+        private void isExpressionAzureClientOperation(PsiStatement statement) {
 
             // Get the expression from the statement
             PsiExpression expression = ((PsiExpressionStatement) statement).getExpression();
 
-            if (!(expression instanceof PsiMethodCallExpression)) {
-                return false;
-            }
-            // Check if the expression is an Azure client operation
-            if (isAzureClientOperation((PsiMethodCallExpression) expression)) {
-                return true;
+            if (expression instanceof PsiMethodCallExpression) {
+                // Check if the expression is an Azure client operation
+                if (isAzureTextAnalyticsClientOperation((PsiMethodCallExpression) expression)) {
+                    holder.registerProblem(expression, SUGGESTION);
+                }
             }
-            return false;
         }
 
         /**
@@ -241,7 +215,7 @@ private boolean isExpressionAzureClientOperation(PsiStatement statement) {
          * @param statement The declaration statement to check
          * @return True if the declaration statement is an Azure client operation, false otherwise
          */
-        private boolean isDeclarationAzureClientOperation(PsiDeclarationStatement statement) {
+        private void isDeclarationAzureClientOperation(PsiDeclarationStatement statement) {
 
             // getDeclaredElements() returns the variables declared in the statement
             for (PsiElement element :  statement.getDeclaredElements()) {
@@ -256,11 +230,10 @@ private boolean isDeclarationAzureClientOperation(PsiDeclarationStatement statem
                     continue;
                 }
                 // Check if the initializer is an Azure client operation
-                if (isAzureClientOperation((PsiMethodCallExpression) initializer)) {
-                    return true;
+                if (isAzureTextAnalyticsClientOperation((PsiMethodCallExpression) initializer)) {
+                    holder.registerProblem(initializer, SUGGESTION);
                 }
             }
-            return false;
         }
 
         /**
@@ -270,7 +243,7 @@ private boolean isDeclarationAzureClientOperation(PsiDeclarationStatement statem
          * @param methodCall The method call expression to check
          * @return True if the method call is an Azure client operation, false otherwise
          */
-        private static boolean isAzureClientOperation(PsiMethodCallExpression methodCall) {
+        private static boolean isAzureTextAnalyticsClientOperation(PsiMethodCallExpression methodCall) {
 
             // Get the containing class of the method call
             PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
@@ -280,8 +253,11 @@ private static boolean isAzureClientOperation(PsiMethodCallExpression methodCall
                 String className = containingClass.getQualifiedName();
 
                 // Check if the class is part of the Azure SDK
-                if (className != null && className.startsWith("com.azure.")) {
-                    return true;
+                if (className != null && className.startsWith("com.azure.ai.textanalytics")) {
+
+                    if (AVAILABLE_BATCH_METHODS.contains((methodCall.getMethodExpression().getReferenceName()) + "Batch")) {
+                        return true;
+                    }
                 }
             }
             return false;
@@ -292,14 +268,21 @@ private static boolean isAzureClientOperation(PsiMethodCallExpression methodCall
          * @return The rule configurations
          * @throws IOException
          */
-        private static String getRuleConfigs() throws IOException {
+        private static Map<String, Object> getRuleConfigs() throws IOException {
 
             final String ruleName = "SingleOperationInLoopCheck";
             final String antiPatternMessageKey = "antipattern_message";
+            final String methodsToCheckKey = "methods_to_check";
 
             final JSONObject jsonObject =  LoadJsonConfigFile.getInstance().getJsonObject();
-            final String antiPatternMessage = jsonObject.getJSONObject(ruleName).getString(antiPatternMessageKey);
-            return antiPatternMessage;
+
+            //get the methods to check
+            JSONArray methodsToCheck = jsonObject.getJSONObject(ruleName).getJSONArray(methodsToCheckKey);
+
+            // extract string from json object
+            String antiPatternMessage = jsonObject.getJSONObject(ruleName).getString(antiPatternMessageKey);
+
+            return Map.of(methodsToCheckKey, methodsToCheck.toList(), antiPatternMessageKey, antiPatternMessage.toString());
         }
     }
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index ab1216254b9..95dfc0ca0a7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -13,6 +13,7 @@
   },
 
   "SingleOperationInLoopCheck": {
+    "methods_to_check": ["detectLanguageBatch", "recognizeEntitiesBatch", "recognizePiiEntitiesBatch", "recognizeLinkedEntitiesBatch", "extractKeyPhrasesBatch", "analyzeSentimentBatch"],
     "antipattern_message": "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
index 5b2a06ba794..98d5664c662 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
@@ -10,6 +10,7 @@
 import com.intellij.psi.PsiForStatement;
 import com.intellij.psi.PsiForeachStatement;
 import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiStatement;
 import com.intellij.psi.PsiVariable;
 import com.intellij.psi.PsiWhileStatement;
@@ -23,9 +24,6 @@
 import org.mockito.Mock;
 import org.mockito.Mockito;
 
-import java.util.ArrayList;
-import java.util.List;
-
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.mock;
@@ -86,11 +84,11 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInForStatement()
         assertVisitor();
 
         PsiForStatement statement = mock(PsiForStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
+        String methodName = "detectLanguage";
         verifyRegisterProblemWithSinglePsiExpressionStatement(statement,
-                packageName, numberOfInvocations, numOfOperations);
+                packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -102,10 +100,10 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInForEachStateme
         assertVisitor();
 
         PsiForeachStatement statement = mock(PsiForeachStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -117,10 +115,10 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInWhileStatement
         assertVisitor();
 
         PsiWhileStatement statement = mock(PsiWhileStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -132,10 +130,10 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInDoWhileStateme
         assertVisitor();
 
         PsiDoWhileStatement statement = mock(PsiDoWhileStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -147,10 +145,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInForStatement(
         assertVisitor();
 
         PsiForStatement statement = mock(PsiForStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -162,10 +160,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInForEachStatem
         assertVisitor();
 
         PsiForeachStatement statement = mock(PsiForeachStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -177,10 +175,10 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInWhileStatemen
         assertVisitor();
 
         PsiWhileStatement statement = mock(PsiWhileStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -192,55 +190,40 @@ public void testSingleOperationInLoopCheckPsiDeclarationStatementInDoWhileStatem
         assertVisitor();
 
         PsiDoWhileStatement statement = mock(PsiDoWhileStatement.class);
-        String packageName = "com.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
-    }
-
-    /**
-     * This test is used to verify a problem is NOT registered when multiple
-     * PsiExpressionStatement operations are found in a for loop.
-     */
-    @Test
-    public void testMultipleOperationsInLoopCheckPsiExpressionStatementInForEachStatement() {
-        assertVisitor();
-
-        PsiForeachStatement statement = mock(PsiForeachStatement.class);
-        String packageName = "com.azure.storage.blob";
-        int numberOfInvocations = 0;
-        int numOfOperations = 4;
-        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
-     * This test is used to verify a problem is NOT registered when multiple
-     * PsiExpressionStatement operations are found in a while loop.
+     * This test is used to verify a problem is NOT registered when a different package name
+     * is used in the PsiExpressionStatement operation in a for loop.
      */
     @Test
-    public void testMultipleOperationsInLoopCheckPsiDeclarationStatementInDoWhileStatement() {
+    public void testSingleOperationInLoopCheckWithDifferentPackageName() {
         assertVisitor();
 
-        PsiDoWhileStatement statement = mock(PsiDoWhileStatement.class);
-        String packageName = "com.azure.storage.blob";
+        PsiForStatement statement = mock(PsiForStatement.class);
+        String packageName = "com.microsoft.azure.storage.blob";
         int numberOfInvocations = 0;
-        int numOfOperations = 2;
-        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "detectLanguage";
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
-     * This test is used to verify a problem is NOT registered when a different package name
+     * This test is used to verify a problem is NOT registered when a different method name
      * is used in the PsiExpressionStatement operation in a for loop.
      */
     @Test
-    public void testSingleOperationInLoopCheckWithDifferentPackageName() {
+    public void testSingleOperationInLoopCheckWithDifferentMethodName() {
         assertVisitor();
 
         PsiForStatement statement = mock(PsiForStatement.class);
-        String packageName = "com.microsoft.azure.storage.blob";
+        String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 0;
-        int numOfOperations = 1;
-        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, numOfOperations);
+        String methodName = "differentMethodName";
+        verifyRegisterProblemWithSinglePsiDeclarationStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -265,7 +248,7 @@ private void assertVisitor() {
      * This helper method is used to verify a problem is registered when a
      * PsiExpressionStatement operation is found in a loop.
      */
-    private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, int numOfOperations) {
+    private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, String methodName) {
 
         // Arrange
         PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
@@ -273,24 +256,18 @@ private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement
         PsiMethodCallExpression expression = mock(PsiMethodCallExpression.class);
         PsiTreeUtil treeUtil = mock(PsiTreeUtil.class);
         PsiClass containingClass = mock(PsiClass.class);
+        PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
+        PsiExpressionStatement mockStatement = mock(PsiExpressionStatement.class);
+        PsiStatement[] statements = new PsiStatement[]{mockStatement};
 
-        // Create a list to dynamically add PsiStatement objects
-        List<PsiStatement> statementList = new ArrayList<>();
-
-        // Mock PsiStatement and add to the list x times
-        for (int i = 0; i < numOfOperations; i++) {
-            PsiExpressionStatement mockStatement = mock(PsiExpressionStatement.class);
-            statementList.add(mockStatement);
-            when(mockStatement.getExpression()).thenReturn(expression);
-        }
-
-        // Convert the list to an array of PsiStatement objects
-        PsiStatement[] statements = statementList.toArray(new PsiStatement[0]);
-
+        when(mockStatement.getExpression()).thenReturn(expression);
         when(loopBody.getCodeBlock()).thenReturn(codeBlock);
         when(codeBlock.getStatements()).thenReturn(statements);
         when(treeUtil.getParentOfType(expression, PsiClass.class)).thenReturn(containingClass);
         when(containingClass.getQualifiedName()).thenReturn(packageName);
+        when(expression.getMethodExpression()).thenReturn(referenceExpression);
+        when(referenceExpression.getReferenceName()).thenReturn(methodName);
+
 
         // Visitor invocation based on the type of loopStatement
         if (loopStatement instanceof PsiForStatement) {
@@ -311,7 +288,7 @@ private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement
 
         //  Verify problem is registered
         verify(mockHolder,
-                times(numberOfInvocations)).registerProblem(Mockito.eq(loopStatement),
+                times(numberOfInvocations)).registerProblem(Mockito.eq(expression),
                 Mockito.contains(
                         "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
     }
@@ -320,7 +297,7 @@ private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement
      * This helper method is used to verify a problem is registered when a
      * PsiDeclarationStatement operation is found in a loop.
      */
-    private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, int numOfOperations) {
+    private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement loopStatement, String packageName, int numberOfInvocations, String methodName) {
 
         // Arrange
         PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
@@ -330,25 +307,18 @@ private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement
         PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
         PsiTreeUtil treeUtil = mock(PsiTreeUtil.class);
         PsiClass containingClass = mock(PsiClass.class);
+        PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
+        PsiDeclarationStatement mockStatement = mock(PsiDeclarationStatement.class);
+        PsiStatement[] statements = new PsiStatement[]{mockStatement};
 
-        // Create a list to dynamically add PsiStatement objects
-        List<PsiStatement> statementList = new ArrayList<>();
-
-        // Mock PsiStatement and add to the list x times
-        for (int i = 0; i < numOfOperations; i++) {
-            PsiDeclarationStatement mockStatement = mock(PsiDeclarationStatement.class);
-            statementList.add(mockStatement);
-            when(mockStatement.getDeclaredElements()).thenReturn(elements);
-        }
-
-        // Convert the list to an array of PsiStatement objects
-        PsiStatement[] statements = statementList.toArray(new PsiStatement[0]);
-
+        when(mockStatement.getDeclaredElements()).thenReturn(elements);
         when(loopBody.getCodeBlock()).thenReturn(codeBlock);
         when(codeBlock.getStatements()).thenReturn(statements);
         when(element.getInitializer()).thenReturn(initializer);
         when(treeUtil.getParentOfType(initializer, PsiClass.class)).thenReturn(containingClass);
         when(containingClass.getQualifiedName()).thenReturn(packageName);
+        when(initializer.getMethodExpression()).thenReturn(referenceExpression);
+        when(referenceExpression.getReferenceName()).thenReturn(methodName);
 
         // Visitor invocation based on the type of loopStatement
         if (loopStatement instanceof PsiForStatement) {
@@ -367,7 +337,7 @@ private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement
 
         //  Verify problem is registered
         verify(mockHolder,
-                times(numberOfInvocations)).registerProblem(Mockito.eq(loopStatement),
+                times(numberOfInvocations)).registerProblem(Mockito.eq(initializer),
                 Mockito.contains(
                         "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
     }

From 7513dc513b652c11f77e32a56a4e07c0cb05ecb3 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 10 Jul 2024 07:34:19 -0700
Subject: [PATCH 061/144] integrate central json loader engine

---
 .../build.gradle                              |   1 +
 .../buildtool/CentralRuleConfigLoader.java    | 227 ++++++++++++++++++
 .../sdk/buildtool/LoadJsonConfigFile.java     |  63 -----
 .../ServiceBusReceiverAsyncClientCheck.java   |  47 ++--
 .../StorageUploadWithoutLengthCheck.java      |  40 ++-
 5 files changed, 258 insertions(+), 120 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 7c07ef4fc6e..4234919c1f9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -14,6 +14,7 @@ dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.7.1'
     testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
     testImplementation group: 'org.mockito', name: 'mockito-core'
+    implementation group: 'com.azure', name: 'azure-json', version: '1.1.0'
 }
 
 tasks.named('test', Test) {
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
new file mode 100644
index 00000000000..23df83565b0
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
@@ -0,0 +1,227 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.azure.json.JsonReader;
+import com.azure.json.JsonToken;
+import com.azure.json.JsonProviders;
+import com.google.gson.JsonParseException;
+
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+public class CentralRuleConfigLoader {
+
+    private static CentralRuleConfigLoader instance;
+    private Map<String, RuleConfig> ruleConfigs;
+
+    private static final Logger LOGGER = Logger.getLogger(CentralRuleConfigLoader.class.getName());
+
+    private static final String CONFIG_FILE_PATH = "/META-INF/ruleConfigs.json";
+
+    // Static initializer block to load the configurations once
+    static {
+        try {
+            final String filePath = "/META-INF/ruleConfigs.json";
+            instance = new CentralRuleConfigLoader(CONFIG_FILE_PATH);
+        } catch (FileNotFoundException e) {
+            LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + CONFIG_FILE_PATH
+                    + ". Please ensure the file exists and is accessible. Error: " + e.getMessage(), e);
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "IO error while reading configuration file from path: " + CONFIG_FILE_PATH
+                    + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
+        }
+    }
+
+    /**
+     * Constructor to load the rule configurations from the JSON file
+     * @param filePath - the path to the JSON file
+     * @throws IOException - if there is an error reading the file
+     */
+    private CentralRuleConfigLoader(String filePath) throws IOException {
+        this.ruleConfigs = loadRuleConfigurations(filePath);
+    }
+
+    /**
+     * This method returns the instance of the CentralRuleConfigLoader
+     * @return CentralRuleConfigLoader instance
+     */
+    public static CentralRuleConfigLoader getInstance() {
+        return instance;
+    }
+
+    /**
+     * This method returns the RuleConfig object for the given key
+     * @param key - the key to get the RuleConfig object
+     * @return RuleConfig object
+     */
+    public RuleConfig getRuleConfig(String key) {
+        return ruleConfigs.get(key);
+    }
+
+    /**
+     * This method loads the rule configurations from the JSON file
+     * @param filePath - the path to the JSON file
+     * @return Map of RuleConfig objects
+     * @throws IOException - if there is an error reading the file
+     */
+    private Map<String, RuleConfig> loadRuleConfigurations(String filePath) throws IOException {
+
+        Map<String, RuleConfig> ruleConfigs = new HashMap<>();
+
+        // Open the input stream to the JSON file
+        try(InputStream is = CentralRuleConfigLoader.class.getResourceAsStream(filePath);
+
+            // Create a JsonReader to read the JSON file
+            JsonReader reader = JsonProviders.createReader(is)) {
+
+            // Check if the JSON file starts with an object
+            // If not, throw an exception
+            // This is to ensure that the JSON file is in the correct format
+            if (reader.nextToken() != JsonToken.START_OBJECT) {
+                throw new IOException("Expected start of object");
+            }
+
+            // Read the JSON file and parse the RuleConfig objects
+            while (reader.nextToken() != JsonToken.END_OBJECT) {
+                String key = reader.getFieldName();
+                RuleConfig ruleConfig = parseRuleConfig(reader);
+
+                // Add the RuleConfig object to the map
+                ruleConfigs.put(key, ruleConfig);
+            }
+        }
+        catch (JsonParseException e) {
+            LOGGER.log(Level.SEVERE, "Configuration file is not a valid JSON at path: " + CONFIG_FILE_PATH
+                    + ". Please check the file format. Error: " + e.getMessage(), e);
+        }
+        return ruleConfigs;
+    }
+
+    /**
+     * This method parses the RuleConfig object from the JSON file
+     * @param reader - the JsonReader object to read the JSON file
+     * @return RuleConfig object parsed from the JSON file
+     * @throws IOException - if there is an error reading the file
+     */
+    private RuleConfig parseRuleConfig(JsonReader reader) throws IOException {
+
+        // Create a new RuleConfig object
+        RuleConfig ruleConfig = new RuleConfig();
+
+        // Check if the JSON file starts with an object
+        if(reader.nextToken() != JsonToken.START_OBJECT) {
+            throw new IOException("Expected start of object");
+        }
+
+        // Read the JSON file and parse the RuleConfig object
+        while (reader.nextToken() != JsonToken.END_OBJECT) {
+
+            // Get the field name
+            String fieldName = reader.getFieldName();
+            // Check the field name and set the corresponding field in the RuleConfig object
+            switch (fieldName) {
+                case "methods_to_check":
+                    ruleConfig.setMethodsToCheck(getListFromJsonArray(reader));
+                    break;
+                case "client_name":
+                    ruleConfig.setClientName(reader.getString());
+                    break;
+                case "antipattern_message":
+                    ruleConfig.setAntipatternMessage(reader.getString());
+                    break;
+                default:
+                    reader.skipChildren();
+            }
+        }
+        // Return the RuleConfig object
+        return ruleConfig;
+    }
+
+
+    /**
+     * This method parses the list of strings from the JSON array
+     * @param reader - the JsonReader object to read the JSON file
+     * @return List of strings parsed from the JSON array
+     * @throws IOException - if there is an error reading the file
+     */
+    private List<String> getListFromJsonArray(JsonReader reader) throws IOException {
+        List<String> list = new ArrayList<>();
+
+        // Check if the JSON file starts with an array
+        if(reader.nextToken() != JsonToken.START_ARRAY) {
+            throw new IOException("Expected start of array");
+        }
+
+        // Read the JSON file and parse the list of strings
+        while (reader.nextToken() != JsonToken.END_ARRAY) {
+            list.add(reader.getString());
+        }
+        return list;
+    }
+}
+
+/**
+ * This class represents the RuleConfig object
+ * It contains the methods to check, the client name and the antipattern message
+ */
+class RuleConfig {
+    private List<String> methodsToCheck;
+    private String clientName;
+    private String antipatternMessage;
+
+    // Getters
+    /**
+     * This method returns the list of methods to check
+     * @return List of methods to check
+     */
+    public List<String> getMethodsToCheck() {
+        return methodsToCheck;
+    }
+
+    /**
+     * This method returns the client name
+     * @return Client name
+     */
+    public String getClientName() {
+        return clientName;
+    }
+
+    /**
+     * This method returns the antipattern message
+     * @return Antipattern message
+     */
+    public String getAntipatternMessage() {
+        return antipatternMessage;
+    }
+
+    // Setters
+    /**
+     * This method sets the list of methods to check
+     * @param methodsToCheck - List of methods to check
+     */
+    public void setMethodsToCheck(List<String> methodsToCheck) {
+        this.methodsToCheck = methodsToCheck;
+    }
+
+    /**
+     * This method sets the client name
+     * @param clientName - Client name
+     */
+    public void setClientName(String clientName) {
+        this.clientName = clientName;
+    }
+
+    /**
+     * This method sets the antipattern message
+     * @param antipatternMessage - Antipattern message
+     */
+    public void setAntipatternMessage(String antipatternMessage) {
+        this.antipatternMessage = antipatternMessage;
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
deleted file mode 100644
index 3f4ca0d3c1b..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/LoadJsonConfigFile.java
+++ /dev/null
@@ -1,63 +0,0 @@
-package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
-
-import java.io.BufferedReader;
-import java.io.FileNotFoundException;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.util.stream.Collectors;
-import org.json.JSONObject;
-
-/**
- * This class is used to load a JSON configuration file and provide access to the loaded JSON object.
- * The constructor is private, so it can't be called from outside the class.
- * The getInstance method returns the single instance of the class, creating it if it doesn't exist.
- * The loadJsonObject method is called in the constructor, so it only runs once when the instance is created.
- * The getJsonObject method returns the loaded JSON object.
- * To use this class, you would call LoadJsonConfigFile.getInstance().getJsonObject().
- * This ensures that the JSON object is only loaded once, no matter how many times or from where getJsonObject is called.
- * */
-public class LoadJsonConfigFile {
-
-    // The instance variable holds the single instance of the class
-    private static LoadJsonConfigFile instance;
-    private JSONObject jsonObject;
-
-    final String CONFIG_FILE_PATH = "META-INF/ruleConfigs.json";
-
-    // The constructor is private, so it can't be called from outside the class
-    private LoadJsonConfigFile() throws IOException {
-        loadJsonObject();
-    }
-
-    // The getInstance method returns the single instance of the class, creating it if it doesn't exist
-    public static synchronized LoadJsonConfigFile getInstance() throws IOException {
-        if (instance == null) {
-            instance = new LoadJsonConfigFile();
-        }
-        return instance;
-    }
-
-    // Load the JSON object from the configuration file
-    private void loadJsonObject() throws IOException {
-
-        try (InputStream inputStream = StorageUploadWithoutLengthCheck.class.getClassLoader().getResourceAsStream(CONFIG_FILE_PATH)) {
-            if (inputStream == null) {
-                throw new FileNotFoundException("Configuration file not found");
-            }
-            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
-                jsonObject = new JSONObject(bufferedReader.lines().collect(Collectors.joining()));
-            }
-        } catch (Exception e) {
-            // Log the error message
-            System.err.println("Error loading JSON configuration: " + e.getMessage());
-            // Rethrow the exception
-            throw e;
-        }
-    }
-
-    // The getJsonObject method returns the loaded JSON object
-    public JSONObject getJsonObject() {
-        return jsonObject;
-    }
-}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 3c03a099917..2df9c2faa5a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -6,12 +6,7 @@
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiTypeElement;
 import org.jetbrains.annotations.NotNull;
-import org.json.JSONObject;
 
-import java.io.IOException;
-import java.util.Arrays;
-import java.util.List;
-import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
@@ -22,24 +17,17 @@
  */
 public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
-    private static List<String> CLIENT_DATA = null;
-
     // Define constants for string literals
-    private static final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
     private static final String RULE_NAME = "ServiceBusReceiverAsyncClientCheck";
-    private static final String SUGGESTION_KEY = "antipattern_message";
-    private static final String CLIENT_NAME_KEY = "client_name";
+    private static String CLIENT_NAME;
+    private static String SUGGESTION;
     private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
 
+    // Static initializer block to load the client data once
     static {
-        try {
-            CLIENT_DATA = getClientToCheck();
-        } catch (IOException e) {
-            LOGGER.log(Level.SEVERE, "Error loading client data", e);
-        }
+        getClientToCheck();
     }
 
-
     /**
      * This method builds a visitor to check for the discouraged client name in the code.
      * If the client name matches the discouraged client, a problem is registered with the suggestion message.
@@ -59,15 +47,9 @@ public void visitTypeElement(PsiTypeElement element) {
                 // Check if the element is an instance of PsiTypeElement
                 if (element instanceof PsiTypeElement && element.getType() != null) {
 
-                    if (CLIENT_DATA.isEmpty()) {
-                        return;
-                    }
-                    String clientName = CLIENT_DATA.get(0);
-                    String suggestion = CLIENT_DATA.get(1);
-
                     // Register a problem if the client used matches the discouraged client
-                    if (element.getType().getPresentableText().equals(clientName)) {
-                        holder.registerProblem(element, suggestion);
+                    if (element.getType().getPresentableText().equals(CLIENT_NAME)) {
+                        holder.registerProblem(element, SUGGESTION);
                     }
                 }
             }
@@ -76,16 +58,17 @@ public void visitTypeElement(PsiTypeElement element) {
     }
 
     /**
-     * Loading the client data from the configuration file.
-     *
-     * @return List of client name and suggestion message
+     * Loading the client data from the configuration class.
      */
-    static List<String> getClientToCheck() throws IOException {
+    static void getClientToCheck() {
+
+        String ruleName = "ServiceBusReceiverAsyncClientCheck";
 
-        final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
-        final String clientName = jsonObject.getJSONObject(RULE_NAME).getString(CLIENT_NAME_KEY);
-        final String suggestion= jsonObject.getJSONObject(RULE_NAME).getString(SUGGESTION_KEY);
-        return Arrays.asList(clientName, suggestion);
+        CentralRuleConfigLoader centralRuleConfigLoader = CentralRuleConfigLoader.getInstance();
+        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
 
+        CLIENT_NAME = ruleConfig.getClientName();
+        SUGGESTION = ruleConfig.getAntipatternMessage();
     }
+
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 5233ac098cf..71581d4aac6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -8,16 +8,9 @@
 import com.intellij.psi.PsiExpressionList;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiNewExpression;
-import org.json.JSONArray;
-import org.json.JSONObject;
 import org.jetbrains.annotations.Nls;
 import org.jetbrains.annotations.NotNull;
-
-import java.io.IOException;
 import java.util.List;
-import java.util.logging.Level;
-import java.util.logging.Logger;
-import java.util.stream.Collectors;
 
 
 /**
@@ -36,27 +29,11 @@ public String getDisplayName() {
     }
 
     private static List<String> METHODS_TO_CHECK_LIST;
-    private static final String RULE_NAME = "StorageUploadWithoutLengthCheck";
-    private static final String METHODS_TO_CHECK_KEY = "methods_to_check";
     private static final String LENGTH_TYPE = "long";
-    private static final Logger LOGGER = Logger.getLogger(StorageUploadWithoutLengthCheck.class.getName());
-
-
 
+    // call getMethodsToCheck() to load the methods to check from the configuration file
     static {
-        try {
-            METHODS_TO_CHECK_LIST = getMethodsToCheck();
-        } catch (IOException e) {
-            LOGGER.log(Level.SEVERE, "Error loading methods to check", e);
-        }
-    }
-
-    // Get the list of methods to check from the configuration file
-    private static List<String> getMethodsToCheck() throws IOException {
-
-        JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
-        JSONArray methods = jsonObject.getJSONObject(RULE_NAME).getJSONArray(METHODS_TO_CHECK_KEY);
-        return methods.toList().stream().map(Object::toString).collect(Collectors.toList());
+        getMethodsToCheck();
     }
 
     /**
@@ -155,4 +132,17 @@ private boolean isLengthArgumentInCall (PsiExpression qualifier) {
         }
         return false;
     }
+
+    /** Get the list of methods to check from the configuration class
+     * The methods to check are defined in a JSON configuration file.
+     */
+    private static void getMethodsToCheck() {
+
+        final String ruleName = "StorageUploadWithoutLengthCheck";
+        CentralRuleConfigLoader centralRuleConfigLoader = CentralRuleConfigLoader.getInstance();
+
+        // Get the RuleConfig object for the rule
+        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+        METHODS_TO_CHECK_LIST = ruleConfig.getMethodsToCheck();
+    }
 }
\ No newline at end of file

From 3043e9aecd6ba967c44422085f795eacdf7f9a11 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 10 Jul 2024 07:37:25 -0700
Subject: [PATCH 062/144] minor edit to javadoc

---
 .../azure/sdk/buildtool/CentralRuleConfigLoader.java        | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
index 23df83565b0..1616f7e74ce 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
@@ -15,6 +15,12 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
+/**
+ * This class is used to load the rule configurations from a JSON file.
+ * The rule configurations are loaded once and stored in a map.
+ * The map contains the key-value pairs where the key is the rule name and the value is the RuleConfig object.
+ * The RuleConfig object for a given key can be retrieved using the getRuleConfig method.
+ */
 public class CentralRuleConfigLoader {
 
     private static CentralRuleConfigLoader instance;

From be00aa51eccb734effb101258359902af9b4217c Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 10 Jul 2024 10:24:47 -0700
Subject: [PATCH 063/144] make fix to client name

---
 .../buildtool/TelemetryClientProvider.java    | 13 +++++++++----
 .../TelemetryClientProviderTest.java          | 19 -------------------
 2 files changed, 9 insertions(+), 23 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 954e1a7dece..1211664740f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -35,8 +35,8 @@ public class TelemetryClientProvider extends LocalInspectionTool {
 
     /**
      * This method is called by the IntelliJ platform to build a visitor for the inspection.
-     * @param holder
-     * @param isOnTheFly
+     * @param holder The ProblemsHolder object that holds the problems found in the code.
+     * @param isOnTheFly A boolean that indicates if the inspection is running on the fly.
      * @return
      */
     @NotNull
@@ -126,7 +126,13 @@ private String getClientName(PsiMethodCallExpression expression) {
             if (qualifier != null) {
                 PsiType type = qualifier.getType();
                 if (type != null && type.getCanonicalText().startsWith("com.azure")) {
-                    return type.getPresentableText();
+
+                    // This will be "SyncPoller<String, String>"
+                    String presentableText = type.getPresentableText();
+
+                    // Strip out the generic parameters
+                    String baseTypeName = presentableText.replaceAll("<.*>", "");
+                    return baseTypeName;
                 }
             }
             return null;
@@ -216,7 +222,6 @@ static TelemetryClient getTelemetryClient() {
                 LOGGER.log(Level.SEVERE, "Unexpected error while loading instrumentation key"
                         + ". Please investigate further.", e);
             }
-
             return telemetry;
         }
     }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
index 96d4cb66ead..d284684e234 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
@@ -16,7 +16,6 @@
 import java.util.Map;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.anyMap;
 import static org.mockito.ArgumentMatchers.eq;
@@ -47,17 +46,6 @@ public void setUp() {
         TelemetryClientProviderVisitor.methodCounts = new HashMap<>();
     }
 
-    /**
-     * This test method tests the buildVisitor method.
-     * It asserts that the visitor is not null and is an instance of JavaElementVisitor.
-     */
-    @Test
-    public void testBuildVisitor() {
-
-        // Assert the visitor is not null and is an instance of JavaElementVisitor
-        assertVisitor();
-    }
-
     /**
      * This test method tests the visitMethodCallExpression method.
      * It tests the method with an Azure package to ensure the method count is incremented correctly.
@@ -157,11 +145,4 @@ private JavaElementVisitor createVisitor() {
 
         return visitor;
     }
-
-    // Helper method to assert visitor is not null and is an instance of JavaElementVisitor
-    private void assertVisitor() {
-
-        assertNotNull(mockVisitor);
-        assertTrue(mockVisitor instanceof JavaElementVisitor);
-    }
 }

From 54e14fa5eaf354cadcd055775f04ce58c02d66da Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 10 Jul 2024 16:02:16 -0700
Subject: [PATCH 064/144] extend to service call/rest api call via az clients

---
 .../buildtool/TelemetryClientProvider.java    | 121 +++++++++++++++---
 1 file changed, 101 insertions(+), 20 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 1211664740f..2b0bc1034a9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -4,13 +4,16 @@
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiClassType;
 import com.intellij.psi.PsiElementVisitor;
-import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethod;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
 import java.io.FileNotFoundException;
 
+import com.intellij.psi.util.PsiUtil;
 import com.microsoft.applicationinsights.TelemetryClient;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
@@ -99,11 +102,11 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
             String methodName = methodExpression.getReferenceName();
             String clientName = getClientName(expression); // Method to get client name
 
-            if (methodName == null) {
-                return;
-            }
-
             if (clientName != null) {
+
+                if (methodName == null || !isServiceCall(expression)) {
+                    return;
+                }
                 synchronized (methodCounts) {
 
                     // Increment the count of the method call for the client
@@ -114,30 +117,108 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
             }
         }
 
+
         /**
-         * This method extracts the client name from the method call expression.
-         * It checks if the method call expression is from an Azure SDK client.
-         * @param expression The method call expression.
+         * This method is used to get the client name from the method call expression.
+         * It resolves the method and extracts the return type to get the client name.
+         * @param expression The method call expression from which the client name is extracted.
          * @return The client name extracted from the method call expression.
          */
         private String getClientName(PsiMethodCallExpression expression) {
-            // Logic to extract client name from the method call expression
-            PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
-            if (qualifier != null) {
-                PsiType type = qualifier.getType();
-                if (type != null && type.getCanonicalText().startsWith("com.azure")) {
-
-                    // This will be "SyncPoller<String, String>"
-                    String presentableText = type.getPresentableText();
-
-                    // Strip out the generic parameters
-                    String baseTypeName = presentableText.replaceAll("<.*>", "");
-                    return baseTypeName;
+            PsiMethod method = expression.resolveMethod();
+
+            if (method != null) {
+
+                // Get the return type of the method
+                PsiType returnType = method.getReturnType();
+
+                // Check if the return type is a class type
+                if (returnType != null) {
+                    if (returnType instanceof PsiClassType) {
+
+                        // Resolve the class type to get the class
+                        PsiClass psiClass = ((PsiClassType) returnType).resolve();
+
+                        // Check if the class is an Azure SDK client
+                        if (psiClass != null && isAzureSdkClient(psiClass)) {
+
+                            // Check if the class name ends with "Client"
+                            if (psiClass.getName().endsWith("Client")) {
+                                return psiClass.getName();
+                            }
+                        }
+                    } else {
+                        // Resolve the class type to get the class
+                        PsiClass psiClass = PsiUtil.resolveClassInClassTypeOnly(returnType);
+
+                        // Check if the class is an Azure SDK client
+                        if (psiClass != null && isAzureSdkClient(psiClass)) {
+
+                            // Check if the class name ends with "Client"
+                            if (psiClass.getName().endsWith("Client")) {
+                                return psiClass.getName();
+                            }
+                        }
+                    }
                 }
             }
             return null;
         }
 
+        /**
+         * This method is used to check if the class is an Azure
+         * SDK client by checking if the class name starts with "com.azure.".
+         * @param psiClass The class to be checked.
+         * @return A boolean indicating if the class is an Azure SDK client.
+         */
+        private boolean isAzureSdkClient(PsiClass psiClass) {
+            String className = psiClass.getQualifiedName();
+            return className != null && className.startsWith("com.azure.");
+        }
+
+        /**
+         * This method is used to check if the method call expression is a service call.
+         * It checks if the method is not a builder method or a utility method.
+         * @param expression The method call expression to be checked.
+         * @return A boolean indicating if the method call expression is a service call.
+         */
+        private static boolean isServiceCall(PsiMethodCallExpression expression) {
+            PsiReferenceExpression methodExpression = expression.getMethodExpression();
+            PsiMethod method = (PsiMethod) methodExpression.resolve();
+
+            if (method == null) {
+                return false;
+            }
+
+            return !isBuilderMethod(method) &&
+                    !isUtilityMethod(method);
+        }
+
+        /**
+         * This method is used to check if the method is a builder method.
+         * It checks if the method name contains "build", "create", or "new".
+         * @param method The method to be checked.
+         * @return A boolean indicating if the method is a builder method.
+         */
+        private static boolean isBuilderMethod(PsiMethod method) {
+            String methodName = method.getName().toLowerCase();
+            return methodName.contains("build") || methodName.contains("create") ||
+                    methodName.contains("new");
+        }
+
+        /**
+         * This method is used to check if the method is a utility method.
+         * It checks if the method name contains "initialize", "setup", "utility", or "helper".
+         * @param method The method to be checked.
+         * @return A boolean indicating if the method is a utility method.
+         */
+        private static boolean isUtilityMethod(PsiMethod method) {
+            String methodName = method.getName().toLowerCase();
+            return methodName.contains("initialize") || methodName.contains("setup") ||
+                    methodName.contains("utility") || methodName.contains("helper");
+        }
+
+
         /**
          * This method starts the telemetry service.
          * It creates a single-threaded ScheduledExecutorService and

From dfe0b56250473fcece8029b262675af185571116 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 11 Jul 2024 11:02:42 -0700
Subject: [PATCH 065/144] complete implementation & test for
 DisableAutoCompleteCheck

---
 .../buildtool/DisableAutoCompleteCheck.java   | 192 +++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  16 +-
 .../main/resources/META-INF/ruleConfigs.json  |   6 +
 .../DisableAutoCompleteCheckTest.java         | 203 ++++++++++++++++++
 4 files changed, 416 insertions(+), 1 deletion(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
new file mode 100644
index 00000000000..7c787746590
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
@@ -0,0 +1,192 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiVariable;
+import org.jetbrains.annotations.NotNull;
+import org.json.JSONObject;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import java.util.stream.Collectors;
+
+/**
+ * This class extends the LocalInspectionTool and is used to inspect the usage of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients in the code.
+ * It checks if the auto-complete feature is disabled for the clients.
+ * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+ */
+public class DisableAutoCompleteCheck extends LocalInspectionTool {
+
+    /**
+     * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
+     *
+     * @param holder The holder for the problems found
+     * @return The visitor for the inspection. This is not used anywhere else in the code.
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new DisableAutoCompleteVisitor(holder, isOnTheFly);
+    }
+
+
+    /**
+     * This class extends the JavaElementVisitor and is used to visit the Java elements in the code.
+     * It checks for the usage of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients and
+     * whether the auto-complete feature is disabled.
+     * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+     */
+    static class DisableAutoCompleteVisitor extends JavaElementVisitor {
+
+        // Define constants for string literals
+        private static String SUGGESTION;
+        private static List<String> CLIENTS_TO_CHECK;
+        private static String METHOD_TO_CHECK;
+        private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
+
+        static {
+            try {
+                getRuleConfigData();
+            } catch (IOException e) {
+                LOGGER.log(Level.SEVERE, "Error loading client data", e);
+            }
+        }
+
+        // Define the holder for the problems found
+        private static ProblemsHolder holder;
+
+        /**
+         * Constructor for the visitor
+         *
+         * @param holder     The holder for the problems found
+         */
+        public DisableAutoCompleteVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+        }
+
+        /**
+         * This method is used to visit the declaration statements in the code.
+         * It checks for the declaration of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients and
+         * whether the auto-complete feature is disabled.
+         * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+         *
+         * @param statement The declaration statement to visit
+         */
+        @Override
+        public void visitDeclarationStatement(PsiDeclarationStatement statement) {
+            super.visitDeclarationStatement(statement);
+
+            // Get the declared elements
+            PsiElement[] elements = statement.getDeclaredElements();
+
+            // Get the variable declaration
+            if (elements.length > 0 && elements[0] instanceof PsiVariable) {
+                PsiVariable variable = (PsiVariable) elements[0];
+
+                // Process the variable declaration
+                processVariableDeclaration(variable);
+            }
+        }
+
+        /**
+         * This method is used to process the variable declaration.
+         * It checks for the declaration of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients and
+         * whether the auto-complete feature is disabled.
+         * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+         *
+         * @param variable The variable to process
+         */
+        private void processVariableDeclaration(PsiVariable variable) {
+
+            // Retrieve the client name (left side of the declaration)
+            PsiType clientType = variable.getType();
+
+            // Check the assignment part (right side)
+            PsiExpression initializer = variable.getInitializer();
+
+            // Check if the client type is an Azure SDK client
+            if (!clientType.getCanonicalText().startsWith("com.azure")) {
+                return;
+            }
+
+            // Check if the client type is in the list of clients to check
+            if (CLIENTS_TO_CHECK.contains(clientType.getPresentableText())) {
+
+                if (!(initializer instanceof PsiMethodCallExpression)) {
+                    return;
+                }
+
+                // Process the new expression initialization
+                if (!isAutoCompleteDisabled((PsiMethodCallExpression) initializer)){
+
+                    // Register a problem if the auto-complete feature is not disabled
+                    holder.registerProblem(initializer, SUGGESTION);
+                }
+            }
+        }
+
+        /**
+         * This method is used to check if the auto-complete feature is disabled.
+         * It iterates up the chain of method calls to check if the auto-complete feature is disabled.
+         *
+         * @param methodCallExpression The method call expression to check
+         * @return true if the auto-complete feature is disabled, false otherwise
+         */
+        private static boolean isAutoCompleteDisabled(PsiMethodCallExpression methodCallExpression) {
+
+            // Iterating up the chain of method calls
+            PsiExpression qualifier = methodCallExpression.getMethodExpression().getQualifierExpression();
+
+            // Check if the method call chain has the method to check
+            while (qualifier instanceof PsiMethodCallExpression) {
+
+                qualifier = ((PsiMethodCallExpression) qualifier).getMethodExpression().getQualifierExpression();
+
+                if (qualifier instanceof PsiMethodCallExpression) {
+
+                    // Get the method expression
+                    PsiReferenceExpression methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
+
+                    // Get the method name
+                    String methodName = methodExpression.getReferenceName();
+
+                    // Check if the method name is the method to check
+                    if (METHOD_TO_CHECK.equals(methodName)) {
+                        return true;
+                    }
+                }
+            }
+            // When the chain has been traversed and the method to check is not found
+            return false;
+        }
+
+
+        /**
+         * This method is used to get the rule configuration data from the JSON configuration file.
+         *
+         * @throws IOException if an error occurs while loading the JSON configuration file
+         */
+        private static void getRuleConfigData() throws IOException {
+
+            final String ruleName = "DisableAutoCompleteCheck";
+            final String methodToCheckKey = "methods_to_check";
+            final String suggestionKey = "antipattern_message";
+            final String clientsToCheckKey = "clients_to_check";
+
+            final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
+            METHOD_TO_CHECK = jsonObject.getJSONObject(ruleName).getString(methodToCheckKey);
+            SUGGESTION = jsonObject.getJSONObject(ruleName).getString(suggestionKey);
+            CLIENTS_TO_CHECK = jsonObject.getJSONObject(ruleName).getJSONArray(clientsToCheckKey).toList().stream().map(Object::toString).collect(Collectors.toList());
+        }
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 1b9efeb66e2..418cf5294f9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -42,7 +42,7 @@
                 language="JAVA"
                 shortName="ServiceBusReceiverAsyncClientCheck"
                 displayName="Low level ServiceBusReceiverAsyncClient check"
-                groupName="Azure SDK"
+                groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 level="WARNING"
                 implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck">
@@ -51,5 +51,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="DisableAutoCompleteCheck"
+                displayName="Disable Auto-Complete Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DisableAutoCompleteCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DisableAutoCompleteCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d0361d1b107..2f11ae25ccd 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -10,5 +10,11 @@
   "ServiceBusReceiverAsyncClientCheck": {
     "client_name": "ServiceBusReceiverAsyncClient",
     "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+  },
+
+  "DisableAutoCompleteCheck": {
+    "methods_to_check": "disableAutoComplete",
+    "clients_to_check": ["ServiceBusReceiverClient", "ServiceBusReceiverAsyncClient", "ServiceBusProcessorClient"],
+    "antipattern_message": "Auto-complete enabled by default. Use the disableAutoComplete() API call to prevent automatic message completion."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheckTest.java
new file mode 100644
index 00000000000..600bddc6b37
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheckTest.java
@@ -0,0 +1,203 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiVariable;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DisableAutoCompleteCheck.DisableAutoCompleteVisitor;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+
+import static org.mockito.ArgumentMatchers.contains;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+
+/**
+ * This class is used to test the DisableAutoCompleteCheck class.
+ * It tests the visitDeclarationStatement method of the DisableAutoCompleteVisitor class.
+ */
+public class DisableAutoCompleteCheckTest {
+
+    // Create a mock ProblemsHolder to be used in the test
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    // Create a mock JavaElementVisitor for visiting the PsiDeclarationStatement
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    // Create a mock PsiDeclarationStatement.
+    @Mock
+    private PsiDeclarationStatement mockDeclarationStatement;
+
+
+    @BeforeEach
+    public void setUp() {
+        // Set up the test
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockDeclarationStatement = mock(PsiDeclarationStatement.class);
+    }
+
+    /**
+     * Test the visitDeclarationStatement method of the DisableAutoCompleteVisitor class.
+     * This test checks if the auto-complete feature is disabled for the ServiceBusReceiverClient.
+     * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+     */
+    @Test
+    public void testProblemRegisteredWithoutDisableAutoComplete() {
+
+        String packageName = "com.azure";
+        String clientName = "ServiceBusReceiverClient";
+        int numOfInvocations = 1;
+        String methodFound = "notDisableAutoComplete";
+
+
+        // Assert
+        verifyProblemRegistered(packageName, clientName,numOfInvocations, methodFound);
+    }
+
+    /**
+     * Test the visitDeclarationStatement method of the DisableAutoCompleteVisitor class.
+     * This test checks if the auto-complete feature is disabled for the ServiceBusProcessorClient.
+     * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+     */
+    @Test
+    public void testProblemRegisteredWithoutDisableAutoCompleteWithAnotherServiceBusClientToCheck() {
+
+        String packageName = "com.azure";
+        String clientName = "ServiceBusProcessorClient";
+        int numOfInvocations = 1;
+        String methodFound = "notDisableAutoComplete";
+
+        // Assert
+        verifyProblemRegistered(packageName, clientName,numOfInvocations, methodFound);
+    }
+
+    /**
+     * Test the visitDeclarationStatement method of the DisableAutoCompleteVisitor class.
+     * This test checks if the auto-complete feature is disabled for the ServiceBusRuleManagerClient.
+     * If the auto-complete feature is not disabled, a problem will NOT be registered with the ProblemsHolder
+     * because the ServiceBusRuleManagerClient is not the correct client to check.
+     */
+    @Test
+    public void testProblemNotRegisteredWithoutDisableAutoCompleteWithWrongServiceBusClient() {
+
+        String packageName = "com.azure";
+        String clientName = "ServiceBusRuleManagerClient";
+        int numOfInvocations = 0;
+        String methodFound = "notDisableAutoComplete";
+
+        // Assert
+        verifyProblemRegistered(packageName, clientName,numOfInvocations, methodFound);
+    }
+
+    /**
+     * Test the visitDeclarationStatement method of the DisableAutoCompleteVisitor class.
+     * This test checks if the auto-complete feature is disabled for the ServiceBusReceiverClient.
+     * A problem will NOT be registered with the ProblemsHolder
+     * because the auto-complete feature is disabled.
+     */
+    @Test
+    public void testProblemNotRegisteredWithDisableAutoComplete() {
+
+        String packageName = "com.azure";
+        String clientName = "ServiceBusReceiverClient";
+        int numOfInvocations = 0;
+        String methodFound = "disableAutoComplete";
+
+
+        // Assert
+        verifyProblemRegistered(packageName, clientName,numOfInvocations, methodFound);
+    }
+
+    /**
+     * Test the visitDeclarationStatement method of the DisableAutoCompleteVisitor class.
+     * This test checks if the auto-complete feature is disabled for the ServiceBusReceiverClient.
+     * A problem will NOT be registered with the ProblemsHolder
+     * because the package name is different -- not an Azure SDK client.
+     */
+    @Test
+    public void testProblemNotRegisteredWitDifferentPackage() {
+
+        String packageName = "com.microsoft.azure";
+        String clientName = "ServiceBusReceiverClient";
+        int numOfInvocations = 0;
+        String methodFound = "disableAutoComplete";
+
+
+        // Assert
+        verifyProblemRegistered(packageName, clientName,numOfInvocations, methodFound);
+    }
+
+
+    /** Create a visitor by calling the buildVisitor method of the DisableAutoCompleteCheck class.
+     *
+     * @return The visitor created
+     */
+    private JavaElementVisitor createVisitor() {
+        DisableAutoCompleteVisitor mockVisitor = new DisableAutoCompleteVisitor(mockHolder, true);
+        return mockVisitor;
+    }
+
+
+    /**
+     * Verify that a problem is registered with the ProblemsHolder.
+     *
+     * @param packageName The package name of the client
+     * @param clientName The name of the client
+     * @param numOfInvocations The number of times the registerProblem method should be called
+     * @param methodFound The method found in the initializer
+     */
+    private void verifyProblemRegistered(String packageName, String clientName, int numOfInvocations, String methodFound) {
+
+        PsiVariable declaredElement = mock(PsiVariable.class);
+        PsiElement[] declaredElements = new PsiElement[] { declaredElement };
+
+        // processVariableDeclaration
+        PsiType clientType = mock(PsiType.class);
+        PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
+
+        // isAutoCompleteDisabled method
+        PsiReferenceExpression expression = mock(PsiReferenceExpression.class);
+        PsiMethodCallExpression qualifier = mock(PsiMethodCallExpression.class);
+        PsiMethodCallExpression finalExpression = mock(PsiMethodCallExpression.class);
+
+        when(mockDeclarationStatement.getDeclaredElements()).thenReturn(declaredElements);
+
+        // processVariableDeclaration method
+        when(declaredElement.getType()).thenReturn(clientType);
+        when(declaredElement.getInitializer()).thenReturn(initializer);
+        when(clientType.getCanonicalText()).thenReturn(packageName);
+        when(clientType.getPresentableText()).thenReturn(clientName);
+
+        // isAutoCompleteDisabled method
+        when(initializer.getMethodExpression()).thenReturn(expression);
+        when(expression.getQualifierExpression()).thenReturn(qualifier);
+
+        // First level qualifier method call
+        when(qualifier.getMethodExpression()).thenReturn(expression);
+        when(expression.getQualifierExpression()).thenReturn(finalExpression);
+        when(expression.getReferenceName()).thenReturn(methodFound);
+
+        // Final expression should return null to break the loop if the method is not disableAutoComplete
+        when(finalExpression.getMethodExpression()).thenReturn(expression);
+
+        if (methodFound!= "disableAutoComplete") {
+            when(expression.getQualifierExpression()).thenReturn(null);
+        }
+
+        mockVisitor.visitDeclarationStatement(mockDeclarationStatement);
+        verify(mockHolder, times(numOfInvocations)).registerProblem(eq(initializer),
+                contains("Auto-complete enabled by default. Use the disableAutoComplete() API call to prevent automatic message completion."));
+    }
+}
\ No newline at end of file

From 3ccc5f06912a0aaaea98d493cb49db566bc409a1 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 11 Jul 2024 12:00:10 -0700
Subject: [PATCH 066/144] address PR comments

---
 .../azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java    | 3 +--
 .../src/main/resources/META-INF/ruleConfigs.json               | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
index 054a1c25d45..8170182aea0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
@@ -94,8 +94,7 @@ private static Map<String, Object> loadRuleConfigurations() {
             final String RULE_CONFIGURATION = "META-INF/ruleConfigs.json";
 
             // Load the rule configurations from the JSON file
-            try {
-                final InputStream inputStream = HardcodedAPIKeysAndTokensCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION);
+            try (InputStream inputStream = HardcodedAPIKeysAndTokensCheck.class.getClassLoader().getResourceAsStream(RULE_CONFIGURATION)) {
                 if (inputStream == null) {
                     throw new FileNotFoundException("Configuration file not found");
                 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 5347331f8e5..0a9227c8709 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -13,7 +13,7 @@
   },
 
   "HardcodedAPIKeysAndTokensCheck": {
-    "clients_to_check": ["AzureKeyCredential", "AccessToken"],
+    "clients_to_check": ["AzureKeyCredential", "AccessToken", "KeyCredential", "AzureNamedKeyCredential", "AzureSasCredential", "AzureNamedKey", "ClientSecretCredentialBuilder", "UsernamePasswordCredentialBuilder", "BasicAuthenticationCredential"],
     "anti_pattern_message": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication.",
     "solution": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication."
   }

From 946f64dd97f115ff4a36047486ec210d4b8dfdd1 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Thu, 11 Jul 2024 12:01:37 -0700
Subject: [PATCH 067/144] Apply suggestions from code review

Co-authored-by: Bill Wert <billwert@microsoft.com>
---
 .../azure-intellij-plugin-azure-sdk/readme.md                 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
index 58e99b0fa08..06cbc92eda4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
@@ -1,13 +1,13 @@
 # Project: Java Code Quality Analyzer
 
 ## Project Description
-The Java Code Quality Analyzer, is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
+The Java Code Quality Analyzer is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
 
 ## Key Features
 
 - **Rule Set Integration**: This feature enables users to import and customize rule sets, tailoring the plugin to their specific needs.
 - **Telemetry Integration**: This feature connects the plugin to the backend with Application Insights, allowing for efficient data transmission.
-- **Azure Toolkit Integration**: This feature allows the plugin to integrate with the IntelliJ Azure toolkit, providing extended functionality.
+- **Azure Toolkit for IntelliJ Integration**: This feature allows the plugin to integrate with the Azure Toolkit for IntelliJ, providing extended functionality.
 - **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 

From ff557a2b77e39e58116bd6e90cacdc9e74d1ac09 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 11 Jul 2024 17:51:36 -0700
Subject: [PATCH 068/144] make changes suggested offline

---
 .../azure/sdk/buildtool/RuleConfig.java       | 69 ++++++++++++++
 ...onfigLoader.java => RuleConfigLoader.java} | 89 ++++---------------
 .../ServiceBusReceiverAsyncClientCheck.java   | 36 +++-----
 .../StorageUploadWithoutLengthCheck.java      | 33 +++----
 4 files changed, 108 insertions(+), 119 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{CentralRuleConfigLoader.java => RuleConfigLoader.java} (70%)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
new file mode 100644
index 00000000000..3274dc4d813
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -0,0 +1,69 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import java.util.List;
+
+/**
+ * This class represents the RuleConfig object
+ * It contains the methods to check, the client name and the antipattern message
+ */
+class RuleConfig { // make this its own file
+    private List<String> methodsToCheck;
+    private String clientName;
+    private String antipatternMessage;
+
+    // Getters
+    /**
+     * This method returns the list of methods to check
+     *
+     * @return List of methods to check
+     */
+    public List<String> getMethodsToCheck() {
+        return methodsToCheck;
+    }
+
+    /**
+     * This method returns the client name
+     *
+     * @return Client name
+     */
+    public String getClientName() {
+        return clientName;
+    }
+
+    /**
+     * This method returns the antipattern message
+     *
+     * @return Antipattern message
+     */
+    public String getAntipatternMessage() {
+        return antipatternMessage;
+    }
+
+    // Setters
+    /**
+     * This method sets the list of methods to check
+     *
+     * @param methodsToCheck - List of methods to check
+     */
+    public void setMethodsToCheck(List<String> methodsToCheck) {
+        this.methodsToCheck = methodsToCheck;
+    }
+
+    /**
+     * This method sets the client name
+     *
+     * @param clientName - Client name
+     */
+    public void setClientName(String clientName) {
+        this.clientName = clientName;
+    }
+
+    /**
+     * This method sets the antipattern message
+     *
+     * @param antipatternMessage - Antipattern message
+     */
+    public void setAntipatternMessage(String antipatternMessage) {
+        this.antipatternMessage = antipatternMessage;
+    }
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
similarity index 70%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 1616f7e74ce..6c1fa377d7b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CentralRuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -3,7 +3,6 @@
 import com.azure.json.JsonReader;
 import com.azure.json.JsonToken;
 import com.azure.json.JsonProviders;
-import com.google.gson.JsonParseException;
 
 import java.io.FileNotFoundException;
 import java.io.IOException;
@@ -21,27 +20,30 @@
  * The map contains the key-value pairs where the key is the rule name and the value is the RuleConfig object.
  * The RuleConfig object for a given key can be retrieved using the getRuleConfig method.
  */
-public class CentralRuleConfigLoader {
+public class RuleConfigLoader {
 
-    private static CentralRuleConfigLoader instance;
+    private static final RuleConfigLoader instance;
     private Map<String, RuleConfig> ruleConfigs;
 
-    private static final Logger LOGGER = Logger.getLogger(CentralRuleConfigLoader.class.getName());
+    private static final Logger LOGGER = Logger.getLogger(RuleConfigLoader.class.getName());
 
     private static final String CONFIG_FILE_PATH = "/META-INF/ruleConfigs.json";
 
     // Static initializer block to load the configurations once
     static {
+        RuleConfigLoader instanceTemp;
         try {
-            final String filePath = "/META-INF/ruleConfigs.json";
-            instance = new CentralRuleConfigLoader(CONFIG_FILE_PATH);
+            instanceTemp = new RuleConfigLoader(CONFIG_FILE_PATH);
         } catch (FileNotFoundException e) {
+            instanceTemp = null;
             LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + CONFIG_FILE_PATH
                     + ". Please ensure the file exists and is accessible. Error: " + e.getMessage(), e);
         } catch (IOException e) {
+            instanceTemp = null;
             LOGGER.log(Level.SEVERE, "IO error while reading configuration file from path: " + CONFIG_FILE_PATH
                     + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
         }
+        instance = instanceTemp;
     }
 
     /**
@@ -49,7 +51,7 @@ public class CentralRuleConfigLoader {
      * @param filePath - the path to the JSON file
      * @throws IOException - if there is an error reading the file
      */
-    private CentralRuleConfigLoader(String filePath) throws IOException {
+    private RuleConfigLoader(String filePath) throws IOException {
         this.ruleConfigs = loadRuleConfigurations(filePath);
     }
 
@@ -57,7 +59,7 @@ private CentralRuleConfigLoader(String filePath) throws IOException {
      * This method returns the instance of the CentralRuleConfigLoader
      * @return CentralRuleConfigLoader instance
      */
-    public static CentralRuleConfigLoader getInstance() {
+    public static RuleConfigLoader getInstance() {
         return instance;
     }
 
@@ -74,14 +76,13 @@ public RuleConfig getRuleConfig(String key) {
      * This method loads the rule configurations from the JSON file
      * @param filePath - the path to the JSON file
      * @return Map of RuleConfig objects
-     * @throws IOException - if there is an error reading the file
      */
-    private Map<String, RuleConfig> loadRuleConfigurations(String filePath) throws IOException {
+    private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
 
         Map<String, RuleConfig> ruleConfigs = new HashMap<>();
 
         // Open the input stream to the JSON file
-        try(InputStream is = CentralRuleConfigLoader.class.getResourceAsStream(filePath);
+        try(InputStream is = RuleConfigLoader.class.getResourceAsStream(filePath);
 
             // Create a JsonReader to read the JSON file
             JsonReader reader = JsonProviders.createReader(is)) {
@@ -102,9 +103,9 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) throws I
                 ruleConfigs.put(key, ruleConfig);
             }
         }
-        catch (JsonParseException e) {
-            LOGGER.log(Level.SEVERE, "Configuration file is not a valid JSON at path: " + CONFIG_FILE_PATH
-                    + ". Please check the file format. Error: " + e.getMessage(), e);
+        catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "IO error while parsing Json from path: " + CONFIG_FILE_PATH
+                    + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
         }
         return ruleConfigs;
     }
@@ -171,63 +172,3 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
         return list;
     }
 }
-
-/**
- * This class represents the RuleConfig object
- * It contains the methods to check, the client name and the antipattern message
- */
-class RuleConfig {
-    private List<String> methodsToCheck;
-    private String clientName;
-    private String antipatternMessage;
-
-    // Getters
-    /**
-     * This method returns the list of methods to check
-     * @return List of methods to check
-     */
-    public List<String> getMethodsToCheck() {
-        return methodsToCheck;
-    }
-
-    /**
-     * This method returns the client name
-     * @return Client name
-     */
-    public String getClientName() {
-        return clientName;
-    }
-
-    /**
-     * This method returns the antipattern message
-     * @return Antipattern message
-     */
-    public String getAntipatternMessage() {
-        return antipatternMessage;
-    }
-
-    // Setters
-    /**
-     * This method sets the list of methods to check
-     * @param methodsToCheck - List of methods to check
-     */
-    public void setMethodsToCheck(List<String> methodsToCheck) {
-        this.methodsToCheck = methodsToCheck;
-    }
-
-    /**
-     * This method sets the client name
-     * @param clientName - Client name
-     */
-    public void setClientName(String clientName) {
-        this.clientName = clientName;
-    }
-
-    /**
-     * This method sets the antipattern message
-     * @param antipatternMessage - Antipattern message
-     */
-    public void setAntipatternMessage(String antipatternMessage) {
-        this.antipatternMessage = antipatternMessage;
-    }
-}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 2df9c2faa5a..363e84d2f82 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -7,7 +7,6 @@
 import com.intellij.psi.PsiTypeElement;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.logging.Logger;
 
 /**
  * This class extends the LocalInspectionTool to check for the use of ServiceBusReceiverAsyncClient
@@ -18,22 +17,26 @@
 public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
     // Define constants for string literals
-    private static final String RULE_NAME = "ServiceBusReceiverAsyncClientCheck";
-    private static String CLIENT_NAME;
-    private static String SUGGESTION;
-    private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiverAsyncClientCheck.class.getName());
+    private static final String CLIENT_NAME;
+    private static final String SUGGESTION;
 
     // Static initializer block to load the client data once
     static {
-        getClientToCheck();
+        final String ruleName = "ServiceBusReceiverAsyncClientCheck";
+
+        RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+
+        CLIENT_NAME = ruleConfig.getClientName();
+        SUGGESTION = ruleConfig.getAntipatternMessage();
     }
 
     /**
      * This method builds a visitor to check for the discouraged client name in the code.
      * If the client name matches the discouraged client, a problem is registered with the suggestion message.
-     * @param holder
-     * @param isOnTheFly
-     * @return PsiElementVisitor
+     * @param holder ProblemsHolder object to register the problem
+     * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use
+     * @return PsiElementVisitor object to visit the elements in the code
      */
     @NotNull
     @Override
@@ -56,19 +59,4 @@ public void visitTypeElement(PsiTypeElement element) {
 
         };
     }
-
-    /**
-     * Loading the client data from the configuration class.
-     */
-    static void getClientToCheck() {
-
-        String ruleName = "ServiceBusReceiverAsyncClientCheck";
-
-        CentralRuleConfigLoader centralRuleConfigLoader = CentralRuleConfigLoader.getInstance();
-        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-
-        CLIENT_NAME = ruleConfig.getClientName();
-        SUGGESTION = ruleConfig.getAntipatternMessage();
-    }
-
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 71581d4aac6..4a44f3a3dbc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -28,20 +28,24 @@ public String getDisplayName() {
         return "Ensure Storage APIs use Length Parameter";
     }
 
-    private static List<String> METHODS_TO_CHECK_LIST;
+    private static final List<String> METHODS_TO_CHECK_LIST;
     private static final String LENGTH_TYPE = "long";
 
-    // call getMethodsToCheck() to load the methods to check from the configuration file
     static {
-        getMethodsToCheck();
+        final String ruleName = "StorageUploadWithoutLengthCheck";
+        RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+        // Get the RuleConfig object for the rule
+        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+        METHODS_TO_CHECK_LIST = ruleConfig.getMethodsToCheck();
     }
 
     /**
      * This method is used to build a PsiElementVisitor that will be used to visit the method calls in the code.
      *
-     * @param holder
-     * @param isOnTheFly
-     * @return
+     * @param holder ProblemsHolder object to register the problem
+     * @param isOnTheFly boolean to check if the inspection is on the fly -- Not in use
+     * @return PsiElementVisitor object to visit the elements in the code
      */
     @NotNull
     @Override
@@ -90,8 +94,8 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
      * The iteration starts from the end of the chain and goes up the chain.
      * The qualifier of the method call is checked for a constructor with 'long' type arguments.
      *
-     * @param expression
-     * @return boolean
+     * @param expression - The method call expression
+     * @return boolean - true if the constructor has 'long' type arguments
      */
     public boolean checkMethodCallChain(PsiMethodCallExpression expression) {
 
@@ -132,17 +136,4 @@ private boolean isLengthArgumentInCall (PsiExpression qualifier) {
         }
         return false;
     }
-
-    /** Get the list of methods to check from the configuration class
-     * The methods to check are defined in a JSON configuration file.
-     */
-    private static void getMethodsToCheck() {
-
-        final String ruleName = "StorageUploadWithoutLengthCheck";
-        CentralRuleConfigLoader centralRuleConfigLoader = CentralRuleConfigLoader.getInstance();
-
-        // Get the RuleConfig object for the rule
-        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-        METHODS_TO_CHECK_LIST = ruleConfig.getMethodsToCheck();
-    }
 }
\ No newline at end of file

From a20df311f1af35a60b22e5d3c10b4fe7b3ff8ad4 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 11 Jul 2024 23:42:18 -0700
Subject: [PATCH 069/144] initial implementation of ServiceBusReceiveModeCheck

---
 .../buildtool/ServiceBusReceiveModeCheck.java | 196 ++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  14 ++
 2 files changed, 210 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
new file mode 100644
index 00000000000..e624c893004
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -0,0 +1,196 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.openapi.util.TextRange;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiVariable;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.OptionalInt;
+
+public class ServiceBusReceiveModeCheck extends LocalInspectionTool {
+
+    /**
+     * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
+     *
+     * @param holder The holder for the problems found
+     * @return The visitor for the inspection. This is not used anywhere else in the code.
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new ServiceBusReceiveModeVisitor(holder, isOnTheFly);
+    }
+
+
+
+    static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
+
+        // Define constants for string literals
+
+
+        // Define the holder for the problems found
+        private static ProblemsHolder holder;
+
+        /**
+         * Constructor for the visitor
+         *
+         * @param holder The holder for the problems found
+         */
+        public ServiceBusReceiveModeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+        }
+
+
+        @Override
+        public void visitDeclarationStatement(PsiDeclarationStatement statement) {
+            super.visitDeclarationStatement(statement);
+
+            // Get the declared elements
+            PsiElement[] elements = statement.getDeclaredElements();
+
+            // Get the variable declaration
+            if (elements.length > 0 && elements[0] instanceof PsiVariable) {
+                PsiVariable variable = (PsiVariable) elements[0];
+
+                // Process the variable declaration
+                processVariableDeclaration(variable);
+            }
+
+        }
+
+        private void processVariableDeclaration(PsiVariable variable) {
+
+            // Retrieve the client name (left side of the declaration)
+            PsiType clientType = variable.getType();
+            System.out.println("clientType: " + clientType);
+
+            // Check the assignment part (right side)
+            PsiExpression initializer = variable.getInitializer();
+            System.out.println("initializer: " + initializer);
+
+            // Check if the client type is an Azure ServiceBus client
+            if (!clientType.getCanonicalText().contains("ServiceBus")){
+                return;
+            }
+
+            if (!(initializer instanceof PsiMethodCallExpression)) {
+                return;
+            }
+
+            // Process the new expression initialization
+            determineReceiveMode((PsiMethodCallExpression) initializer);
+
+        }
+
+        private void determineReceiveMode(PsiMethodCallExpression methodCall) {
+
+            OptionalInt prefetchCountValue = OptionalInt.empty();
+            boolean isReceiveModePeekLock = false;
+            PsiMethodCallExpression prefetchCountQualifier = null; // Declaration at the method level
+//            TextRange textRange = null;
+            PsiReferenceExpression methodExpression = null;
+
+
+            // Iterating up the chain of method calls
+            PsiExpression qualifier = methodCall.getMethodExpression().getQualifierExpression();
+            System.out.println("qualifier1: " + qualifier);
+
+            // Check if the method call chain has the method to check
+            while (qualifier instanceof PsiMethodCallExpression) {
+
+                if (qualifier instanceof PsiMethodCallExpression) {
+
+                    System.out.println("Next qualifier pass");
+                    System.out.println("qualifier2: " + qualifier);
+
+                    // Get the method expression
+                    methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
+                    System.out.println("methodExpression: " + methodExpression);
+
+                    // Get the method name
+                    String methodName = methodExpression.getReferenceName();
+
+                    System.out.println("methodName: " + methodName);
+
+                    // Check if the method name is the method to check
+                    if ("receiveMode".equals(methodName)) {
+                        // get its parameters
+
+                        isReceiveModePeekLock = receiveModePeekLockCheck((PsiMethodCallExpression) qualifier);
+                        System.out.println("isReceiveModePeekLock: " + isReceiveModePeekLock);
+
+                        // access its parameters
+                    } else if ("prefetchCount".equals(methodName)) {
+                        System.out.println("prefetchCount method detected");
+
+                        prefetchCountValue = getPrefetchCount((PsiMethodCallExpression) qualifier);
+                        prefetchCountQualifier = (PsiMethodCallExpression) qualifier; // Assigning the current qualifier
+                        System.out.println("prefetchCountValue.getAsInt(): " + prefetchCountValue.getAsInt());
+                        System.out.println("prefetchCountQualifier: " + prefetchCountQualifier);
+
+                    }
+                }
+
+                qualifier = ((PsiMethodCallExpression) qualifier).getMethodExpression().getQualifierExpression();
+
+                if (prefetchCountValue.isPresent() && prefetchCountValue.getAsInt() > 1 && isReceiveModePeekLock) {
+                    System.out.println("prefetchCountValue.getAsInt()whol: " + prefetchCountValue.getAsInt());
+                    System.out.println("prefetchCountQualifierwhol: " + prefetchCountQualifier);
+                    System.out.println("Problem detected");
+                    holder.registerProblem(prefetchCountQualifier, "A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval.");
+                }
+            }
+        }
+
+        private boolean receiveModePeekLockCheck (PsiMethodCallExpression qualifier) {
+
+            PsiExpression[] arguments = qualifier.getArgumentList().getExpressions();
+            System.out.println("arguments: " + arguments);
+
+            for (PsiExpression argument : arguments) {
+                String argumentText = argument.getText();
+                System.out.println("argumentText: " + argumentText);
+
+                if (argumentText.contains("PEEK_LOCK")) {
+                    System.out.println("Found .PEEK_LOCK in parameters");
+                    return true;
+                }
+            }
+            return false;
+        }
+
+        private OptionalInt getPrefetchCount(PsiMethodCallExpression qualifier) {
+
+            System.out.println("qualifiergetPrefetchCount: " + qualifier);
+
+            PsiExpression[] arguments = qualifier.getArgumentList().getExpressions();
+            System.out.println("arguments: " + arguments);
+            System.out.println("arguments.length: " + arguments.length);
+            if (arguments.length > 0) {
+                String argumentText = arguments[0].getText();
+                System.out.println("argumentText: " + argumentText);
+                System.out.println("argument: " + arguments[0]);
+                try {
+                    System.out.println("prefetchCountValue: " + Integer.parseInt(argumentText));
+                    return OptionalInt.of(Integer.parseInt(argumentText));
+                } catch (NumberFormatException e) {
+                    // Handle the case where the argument text is not a valid integer
+                }
+            }
+
+            // optionalInt is a wrapper for an integer value that may or may not be present
+            // This is because can't return null from a method that returns an int
+            // and returning 0 is not a good idea because 0 is a valid value for prefetchCount
+            return OptionalInt.empty();
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 1b9efeb66e2..68296d2484e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -51,5 +51,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiverAsyncClientCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="ServiceBusReceiveModeCheck"
+                displayName="ServiceBus ReceiveMode Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiveModeCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiveModeCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
\ No newline at end of file

From 514b68e354645b4cdda836d1f7c6cdac48a18a05 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Fri, 12 Jul 2024 11:11:33 -0700
Subject: [PATCH 070/144] Update RuleConfig.java comments

---
 .../toolkit/intellij/azure/sdk/buildtool/RuleConfig.java    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index 3274dc4d813..be69edbe39c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -3,10 +3,10 @@
 import java.util.List;
 
 /**
- * This class represents the RuleConfig object
+ * This class contains configuration options for code style rules.
  * It contains the methods to check, the client name and the antipattern message
  */
-class RuleConfig { // make this its own file
+class RuleConfig {
     private List<String> methodsToCheck;
     private String clientName;
     private String antipatternMessage;
@@ -66,4 +66,4 @@ public void setClientName(String clientName) {
     public void setAntipatternMessage(String antipatternMessage) {
         this.antipatternMessage = antipatternMessage;
     }
-}
\ No newline at end of file
+}

From a5ae7a25a17d9b3b9bc2a42f4e4e74813b7315a9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 11:15:39 -0700
Subject: [PATCH 071/144] update to add tests

---
 .../buildtool/ServiceBusReceiveModeCheck.java |  20 +-
 .../ServiceBusReceiveModeCheckTest.java       | 179 ++++++++++++++++++
 2 files changed, 186 insertions(+), 13 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
index e624c893004..bb1d09faa93 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -2,7 +2,6 @@
 
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.openapi.util.TextRange;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiDeclarationStatement;
 import com.intellij.psi.PsiElement;
@@ -30,12 +29,8 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
         return new ServiceBusReceiveModeVisitor(holder, isOnTheFly);
     }
 
-
-
     static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
 
-        // Define constants for string literals
-
 
         // Define the holder for the problems found
         private static ProblemsHolder holder;
@@ -64,7 +59,6 @@ public void visitDeclarationStatement(PsiDeclarationStatement statement) {
                 // Process the variable declaration
                 processVariableDeclaration(variable);
             }
-
         }
 
         private void processVariableDeclaration(PsiVariable variable) {
@@ -76,9 +70,10 @@ private void processVariableDeclaration(PsiVariable variable) {
             // Check the assignment part (right side)
             PsiExpression initializer = variable.getInitializer();
             System.out.println("initializer: " + initializer);
+            System.out.println("clientType.getCanonicalText(): " + clientType.getCanonicalText());
 
             // Check if the client type is an Azure ServiceBus client
-            if (!clientType.getCanonicalText().contains("ServiceBus")){
+            if (!clientType.getCanonicalText().contains("servicebus")){
                 return;
             }
 
@@ -96,9 +91,6 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
             OptionalInt prefetchCountValue = OptionalInt.empty();
             boolean isReceiveModePeekLock = false;
             PsiMethodCallExpression prefetchCountQualifier = null; // Declaration at the method level
-//            TextRange textRange = null;
-            PsiReferenceExpression methodExpression = null;
-
 
             // Iterating up the chain of method calls
             PsiExpression qualifier = methodCall.getMethodExpression().getQualifierExpression();
@@ -113,7 +105,7 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
                     System.out.println("qualifier2: " + qualifier);
 
                     // Get the method expression
-                    methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
+                    PsiReferenceExpression methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
                     System.out.println("methodExpression: " + methodExpression);
 
                     // Get the method name
@@ -129,14 +121,14 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
                         System.out.println("isReceiveModePeekLock: " + isReceiveModePeekLock);
 
                         // access its parameters
-                    } else if ("prefetchCount".equals(methodName)) {
+                    }
+                    else if ("prefetchCount".equals(methodName)) {
                         System.out.println("prefetchCount method detected");
 
                         prefetchCountValue = getPrefetchCount((PsiMethodCallExpression) qualifier);
                         prefetchCountQualifier = (PsiMethodCallExpression) qualifier; // Assigning the current qualifier
                         System.out.println("prefetchCountValue.getAsInt(): " + prefetchCountValue.getAsInt());
                         System.out.println("prefetchCountQualifier: " + prefetchCountQualifier);
-
                     }
                 }
 
@@ -153,10 +145,12 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
 
         private boolean receiveModePeekLockCheck (PsiMethodCallExpression qualifier) {
 
+            System.out.println("qualifier at receiveModePeekLockCheck: " + qualifier);
             PsiExpression[] arguments = qualifier.getArgumentList().getExpressions();
             System.out.println("arguments: " + arguments);
 
             for (PsiExpression argument : arguments) {
+                System.out.println("argument: " + argument);
                 String argumentText = argument.getText();
                 System.out.println("argumentText: " + argumentText);
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java
new file mode 100644
index 00000000000..7ceea0c21e0
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java
@@ -0,0 +1,179 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiDeclarationStatement;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiVariable;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiveModeCheck.ServiceBusReceiveModeVisitor;
+
+import static org.mockito.ArgumentMatchers.contains;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ServiceBusReceiveModeCheckTest {
+
+    // Create a mock ProblemsHolder to be used in the test
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    // Create a mock JavaElementVisitor for visiting the PsiDeclarationStatement
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    // Create a mock PsiDeclarationStatement.
+    @Mock
+    private PsiDeclarationStatement mockDeclarationStatement;
+
+
+    @BeforeEach
+    public void setUp() {
+        // Set up the test
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockDeclarationStatement = mock(PsiDeclarationStatement.class);
+    }
+
+
+    @Test
+    public void testProblemRegisteredWithReceiveModeAndHighPeekLock() {
+
+        String packageName = "servicebus";
+        String methodFoundOne = "receiveMode";
+        String methodFoundTwo = "prefetchCount";
+        int numOfInvocations = 1;
+        String prefetchCountValue = "100";
+
+        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+    }
+
+    @Test
+    public void testProblemRegisteredWithoutReceiveModeAndHighPeekLock() {
+
+        String packageName = "servicebus";
+        String methodFoundOne = "notreceiveMode";
+        String methodFoundTwo = "prefetchCount";
+        int numOfInvocations = 0;
+        String prefetchCountValue = "100";
+
+        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+    }
+
+    @Test
+    public void testProblemRegisteredWithReceiveModeAndNoPrefetchCount() {
+
+        String packageName = "servicebus";
+        String methodFoundOne = "receiveMode";
+        String methodFoundTwo = "noprefetchCount";
+        int numOfInvocations = 0;
+        String prefetchCountValue = "100";
+
+        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+    }
+
+    @Test
+    public void testProblemRegisteredWithoutReceiveModeAndNoPrefetchCount() {
+
+        String packageName = "servicebus";
+        String methodFoundOne = "notreceiveMode";
+        String methodFoundTwo = "noprefetchCount";
+        int numOfInvocations = 0;
+        String prefetchCountValue = "100";
+
+        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+    }
+
+
+
+
+    /**
+     * Create a visitor by calling the buildVisitor method of the ServiceBusReceiveModeCheck class.
+     *
+     * @return The visitor created
+     */
+    private JavaElementVisitor createVisitor() {
+        ServiceBusReceiveModeVisitor mockVisitor = new ServiceBusReceiveModeVisitor(mockHolder, true);
+        return mockVisitor;
+    }
+
+
+
+    private void verifyProblemRegistered(String packageName, String methodFoundOne, String methodFoundTwo, int numOfInvocations, String prefetchCountValue) {
+
+        PsiVariable declaredElement = mock(PsiVariable.class);
+        PsiElement[] declaredElements = new PsiElement[]{declaredElement};
+
+        // processVariableDeclaration method
+        PsiType clientType = mock(PsiType.class);
+        PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
+
+        // determineReceiveMode method
+        // First level qualifier method call
+        PsiReferenceExpression expressionOne = mock(PsiReferenceExpression.class);
+        PsiMethodCallExpression qualifierOne = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression methodExpressionOne = mock(PsiReferenceExpression.class);
+
+        // receiveModePeekLockCheck
+        PsiExpression receiveModePeekLockParameter = mock(PsiExpression.class);
+        PsiReferenceExpression prefetchCountParameter = mock(PsiReferenceExpression.class);
+        PsiExpressionList methodArgumentList = mock(PsiExpressionList.class);
+        PsiExpression[] methodArguments = new PsiExpression[]{prefetchCountParameter, receiveModePeekLockParameter};
+
+        PsiMethodCallExpression transitionMethodCall = mock(PsiMethodCallExpression.class);
+
+        // Second level qualifier method call
+        PsiReferenceExpression expressionTwo = mock(PsiReferenceExpression.class);
+        PsiMethodCallExpression qualifierTwo = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression methodExpressionTwo = mock(PsiReferenceExpression.class);
+
+
+        when(mockDeclarationStatement.getDeclaredElements()).thenReturn(declaredElements);
+
+        // processVariableDeclaration method
+        when(declaredElement.getType()).thenReturn(clientType);
+        when(declaredElement.getInitializer()).thenReturn(initializer);
+        when(clientType.getCanonicalText()).thenReturn(packageName);
+
+        // determineReceiveMode method
+        // First level qualifier method call
+        when(initializer.getMethodExpression()).thenReturn(expressionOne);
+        when(expressionOne.getQualifierExpression()).thenReturn(qualifierOne);
+        when(qualifierOne.getMethodExpression()).thenReturn(methodExpressionOne);
+        when(methodExpressionOne.getReferenceName()).thenReturn(methodFoundOne);
+
+        // receiveModePeekLockCheck
+        when(qualifierOne.getArgumentList()).thenReturn(methodArgumentList);
+        when(methodArgumentList.getExpressions()).thenReturn(methodArguments);
+        when(receiveModePeekLockParameter.getText()).thenReturn("PEEK_LOCK");
+
+        // Second level qualifier method call
+        when(methodExpressionOne.getQualifierExpression()).thenReturn(qualifierTwo);
+        when(qualifierTwo.getMethodExpression()).thenReturn(methodExpressionTwo);
+        when(methodExpressionTwo.getReferenceName()).thenReturn(methodFoundTwo);
+
+        // getPrefetchCount method
+        when(qualifierTwo.getArgumentList()).thenReturn(methodArgumentList);
+        when(methodArgumentList.getExpressions()).thenReturn(methodArguments);
+        when(prefetchCountParameter.getText()).thenReturn(prefetchCountValue);
+
+        if (methodFoundOne != "receiveMode" || methodFoundTwo != "prefetchCount") {
+            when(methodExpressionTwo.getQualifierExpression()).thenReturn(null);
+        }
+
+        mockVisitor.visitDeclarationStatement(mockDeclarationStatement);
+        verify(mockHolder, times(numOfInvocations)).registerProblem(eq(qualifierTwo),
+                contains("A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."));
+    }
+}
\ No newline at end of file

From 85267c240b36b644e1a3d008cb61d6fd700b9afd Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 11:26:16 -0700
Subject: [PATCH 072/144] add changes discussed offline

---
 .../azure/sdk/buildtool/RuleConfig.java       |  2 +
 .../azure/sdk/buildtool/RuleConfigLoader.java | 37 ++++++++++---------
 2 files changed, 21 insertions(+), 18 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index be69edbe39c..6fabe2f6975 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -12,6 +12,7 @@ class RuleConfig {
     private String antipatternMessage;
 
     // Getters
+
     /**
      * This method returns the list of methods to check
      *
@@ -40,6 +41,7 @@ public String getAntipatternMessage() {
     }
 
     // Setters
+
     /**
      * This method sets the list of methods to check
      *
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 6c1fa377d7b..03442fa03d4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -23,7 +23,7 @@
 public class RuleConfigLoader {
 
     private static final RuleConfigLoader instance;
-    private Map<String, RuleConfig> ruleConfigs;
+    private final Map<String, RuleConfig> ruleConfigs;
 
     private static final Logger LOGGER = Logger.getLogger(RuleConfigLoader.class.getName());
 
@@ -36,18 +36,17 @@ public class RuleConfigLoader {
             instanceTemp = new RuleConfigLoader(CONFIG_FILE_PATH);
         } catch (FileNotFoundException e) {
             instanceTemp = null;
-            LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + CONFIG_FILE_PATH
-                    + ". Please ensure the file exists and is accessible. Error: " + e.getMessage(), e);
+            LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + CONFIG_FILE_PATH + ". Please ensure the file exists and is accessible. Error: " + e);
         } catch (IOException e) {
             instanceTemp = null;
-            LOGGER.log(Level.SEVERE, "IO error while reading configuration file from path: " + CONFIG_FILE_PATH
-                    + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
+            LOGGER.log(Level.SEVERE, "IO error while reading configuration file from path: " + CONFIG_FILE_PATH + ". Please check file permissions and retry. Error: " + e);
         }
         instance = instanceTemp;
     }
 
     /**
      * Constructor to load the rule configurations from the JSON file
+     *
      * @param filePath - the path to the JSON file
      * @throws IOException - if there is an error reading the file
      */
@@ -57,6 +56,7 @@ private RuleConfigLoader(String filePath) throws IOException {
 
     /**
      * This method returns the instance of the CentralRuleConfigLoader
+     *
      * @return CentralRuleConfigLoader instance
      */
     public static RuleConfigLoader getInstance() {
@@ -65,15 +65,17 @@ public static RuleConfigLoader getInstance() {
 
     /**
      * This method returns the RuleConfig object for the given key
+     *
      * @param key - the key to get the RuleConfig object
      * @return RuleConfig object
      */
-    public RuleConfig getRuleConfig(String key) {
+    RuleConfig getRuleConfig(String key) {
         return ruleConfigs.get(key);
     }
 
     /**
      * This method loads the rule configurations from the JSON file
+     *
      * @param filePath - the path to the JSON file
      * @return Map of RuleConfig objects
      */
@@ -82,10 +84,10 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
         Map<String, RuleConfig> ruleConfigs = new HashMap<>();
 
         // Open the input stream to the JSON file
-        try(InputStream is = RuleConfigLoader.class.getResourceAsStream(filePath);
+        try (InputStream is = RuleConfigLoader.class.getResourceAsStream(filePath);
 
-            // Create a JsonReader to read the JSON file
-            JsonReader reader = JsonProviders.createReader(is)) {
+             // Create a JsonReader to read the JSON file
+             JsonReader reader = JsonProviders.createReader(is)) {
 
             // Check if the JSON file starts with an object
             // If not, throw an exception
@@ -97,32 +99,31 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
             // Read the JSON file and parse the RuleConfig objects
             while (reader.nextToken() != JsonToken.END_OBJECT) {
                 String key = reader.getFieldName();
-                RuleConfig ruleConfig = parseRuleConfig(reader);
+                RuleConfig ruleConfig = getRuleConfig(reader);
 
                 // Add the RuleConfig object to the map
                 ruleConfigs.put(key, ruleConfig);
             }
-        }
-        catch (IOException e) {
-            LOGGER.log(Level.SEVERE, "IO error while parsing Json from path: " + CONFIG_FILE_PATH
-                    + ". Please check file permissions and retry. Error: " + e.getMessage(), e);
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "IO error while parsing Json from path: " + CONFIG_FILE_PATH + ". Please check file permissions and retry. Error: " + e);
         }
         return ruleConfigs;
     }
 
     /**
      * This method parses the RuleConfig object from the JSON file
+     *
      * @param reader - the JsonReader object to read the JSON file
      * @return RuleConfig object parsed from the JSON file
      * @throws IOException - if there is an error reading the file
      */
-    private RuleConfig parseRuleConfig(JsonReader reader) throws IOException {
+    private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
 
         // Create a new RuleConfig object
         RuleConfig ruleConfig = new RuleConfig();
 
         // Check if the JSON file starts with an object
-        if(reader.nextToken() != JsonToken.START_OBJECT) {
+        if (reader.nextToken() != JsonToken.START_OBJECT) {
             throw new IOException("Expected start of object");
         }
 
@@ -146,13 +147,13 @@ private RuleConfig parseRuleConfig(JsonReader reader) throws IOException {
                     reader.skipChildren();
             }
         }
-        // Return the RuleConfig object
         return ruleConfig;
     }
 
 
     /**
      * This method parses the list of strings from the JSON array
+     *
      * @param reader - the JsonReader object to read the JSON file
      * @return List of strings parsed from the JSON array
      * @throws IOException - if there is an error reading the file
@@ -161,7 +162,7 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
         List<String> list = new ArrayList<>();
 
         // Check if the JSON file starts with an array
-        if(reader.nextToken() != JsonToken.START_ARRAY) {
+        if (reader.nextToken() != JsonToken.START_ARRAY) {
             throw new IOException("Expected start of array");
         }
 

From c192a64043f175a673292974861a55ed063c7c77 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 11:36:23 -0700
Subject: [PATCH 073/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md          | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3175be77e54..734e9f27182 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -28,4 +28,12 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
\ No newline at end of file
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+3. #### Disable Auto-complete when using ServiceBusReceiver or Processor clients
+- **Anti-pattern**:When using ServiceBusReceiver or Processor clients, auto-complete is enabled by default, but this behavior is not explicitly verified or disabled when necessary.
+- **Issue**: Auto-complete being enabled by default might lead to messages being marked as completed even if the message processing fails or encounters an error. 
+    Errors in message processing might not be noticed since the message is automatically completed regardless of success or failure, making it harder to identify and handle issues.
+- **Severity: WARNING**
+- Explicitly Disable Auto-Complete: When creating ServiceBusReceiver or Processor clients, explicitly use the disableAutoComplete() method call to prevent automatic message completion.
+Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.servicebus.servicebusclientbuilder.servicebusreceiverclientbuilder?view=azure-java-stable#com-azure-messaging-servicebus-servicebusclientbuilder-servicebusreceiverclientbuilder-disableautocomplete()) for additional information.
\ No newline at end of file

From b5a1f679f9accd787dd623584dd43acee9ca90ea Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 12:20:25 -0700
Subject: [PATCH 074/144] update to make RuleConfig an immutable class

---
 .../azure/sdk/buildtool/RuleConfig.java       | 52 +++++++------------
 .../azure/sdk/buildtool/RuleConfigLoader.java | 16 +++---
 .../ServiceBusReceiverAsyncClientCheck.java   |  5 +-
 .../StorageUploadWithoutLengthCheck.java      | 12 +++--
 4 files changed, 36 insertions(+), 49 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index 6fabe2f6975..a4b414ff787 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -7,9 +7,22 @@
  * It contains the methods to check, the client name and the antipattern message
  */
 class RuleConfig {
-    private List<String> methodsToCheck;
-    private String clientName;
-    private String antipatternMessage;
+    private final List<String> methodsToCheck;
+    private final String clientName;
+    private final String antipatternMessage;
+
+    /**
+     * Constructor for RuleConfig.
+     *
+     * @param methodsToCheck     List of methods to check.
+     * @param clientName         Client name.
+     * @param antipatternMessage Antipattern message.
+     */
+    public RuleConfig(List<String> methodsToCheck, String clientName, String antipatternMessage) {
+        this.methodsToCheck = methodsToCheck;
+        this.clientName = clientName;
+        this.antipatternMessage = antipatternMessage;
+    }
 
     // Getters
 
@@ -36,36 +49,7 @@ public String getClientName() {
      *
      * @return Antipattern message
      */
-    public String getAntipatternMessage() {
+    public String getAntiPatternMessage() {
         return antipatternMessage;
     }
-
-    // Setters
-
-    /**
-     * This method sets the list of methods to check
-     *
-     * @param methodsToCheck - List of methods to check
-     */
-    public void setMethodsToCheck(List<String> methodsToCheck) {
-        this.methodsToCheck = methodsToCheck;
-    }
-
-    /**
-     * This method sets the client name
-     *
-     * @param clientName - Client name
-     */
-    public void setClientName(String clientName) {
-        this.clientName = clientName;
-    }
-
-    /**
-     * This method sets the antipattern message
-     *
-     * @param antipatternMessage - Antipattern message
-     */
-    public void setAntipatternMessage(String antipatternMessage) {
-        this.antipatternMessage = antipatternMessage;
-    }
-}
+}
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 03442fa03d4..8849949d14e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -81,6 +81,7 @@ RuleConfig getRuleConfig(String key) {
      */
     private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
 
+        // temporary map to store the RuleConfig objects that will then be returned to the final map
         Map<String, RuleConfig> ruleConfigs = new HashMap<>();
 
         // Open the input stream to the JSON file
@@ -118,9 +119,9 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
      * @throws IOException - if there is an error reading the file
      */
     private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
-
-        // Create a new RuleConfig object
-        RuleConfig ruleConfig = new RuleConfig();
+        List<String> methodsToCheck = new ArrayList<>();
+        String clientName = null;
+        String antipatternMessage = null;
 
         // Check if the JSON file starts with an object
         if (reader.nextToken() != JsonToken.START_OBJECT) {
@@ -135,22 +136,21 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
             // Check the field name and set the corresponding field in the RuleConfig object
             switch (fieldName) {
                 case "methods_to_check":
-                    ruleConfig.setMethodsToCheck(getListFromJsonArray(reader));
+                    methodsToCheck = getListFromJsonArray(reader);
                     break;
                 case "client_name":
-                    ruleConfig.setClientName(reader.getString());
+                    clientName = reader.getString();
                     break;
                 case "antipattern_message":
-                    ruleConfig.setAntipatternMessage(reader.getString());
+                    antipatternMessage = reader.getString();
                     break;
                 default:
                     reader.skipChildren();
             }
         }
-        return ruleConfig;
+        return new RuleConfig(methodsToCheck, clientName, antipatternMessage);
     }
 
-
     /**
      * This method parses the list of strings from the JSON array
      *
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 363e84d2f82..97f2032be98 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -28,13 +28,14 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
         final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
 
         CLIENT_NAME = ruleConfig.getClientName();
-        SUGGESTION = ruleConfig.getAntipatternMessage();
+        SUGGESTION = ruleConfig.getAntiPatternMessage();
     }
 
     /**
      * This method builds a visitor to check for the discouraged client name in the code.
      * If the client name matches the discouraged client, a problem is registered with the suggestion message.
-     * @param holder ProblemsHolder object to register the problem
+     *
+     * @param holder     ProblemsHolder object to register the problem
      * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use
      * @return PsiElementVisitor object to visit the elements in the code
      */
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 4a44f3a3dbc..18676491cd8 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -10,6 +10,7 @@
 import com.intellij.psi.PsiNewExpression;
 import org.jetbrains.annotations.Nls;
 import org.jetbrains.annotations.NotNull;
+
 import java.util.List;
 
 
@@ -30,6 +31,7 @@ public String getDisplayName() {
 
     private static final List<String> METHODS_TO_CHECK_LIST;
     private static final String LENGTH_TYPE = "long";
+    private static final String SUGGESTION;
 
     static {
         final String ruleName = "StorageUploadWithoutLengthCheck";
@@ -38,12 +40,13 @@ public String getDisplayName() {
         // Get the RuleConfig object for the rule
         final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
         METHODS_TO_CHECK_LIST = ruleConfig.getMethodsToCheck();
+        SUGGESTION = ruleConfig.getAntiPatternMessage();
     }
 
     /**
      * This method is used to build a PsiElementVisitor that will be used to visit the method calls in the code.
      *
-     * @param holder ProblemsHolder object to register the problem
+     * @param holder     ProblemsHolder object to register the problem
      * @param isOnTheFly boolean to check if the inspection is on the fly -- Not in use
      * @return PsiElementVisitor object to visit the elements in the code
      */
@@ -81,9 +84,8 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                     }
                 }
                 if (!hasLengthArg) {
-                    holder.registerProblem(expression, "Azure Storage upload API without length parameter detected");
+                    holder.registerProblem(expression, SUGGESTION);
                 }
-
             }
         };
     }
@@ -109,7 +111,7 @@ public boolean checkMethodCallChain(PsiMethodCallExpression expression) {
 
             // Checking for constructor with 'long' type arguments
             if (qualifier instanceof PsiNewExpression) {
-                return isLengthArgumentInCall (qualifier);
+                return isLengthArgumentInCall(qualifier);
             }
         }
         return false;
@@ -121,7 +123,7 @@ public boolean checkMethodCallChain(PsiMethodCallExpression expression) {
      * @param qualifier - The qualifier of the method call
      * @return boolean
      */
-    private boolean isLengthArgumentInCall (PsiExpression qualifier) {
+    private boolean isLengthArgumentInCall(PsiExpression qualifier) {
         PsiNewExpression newExpression = (PsiNewExpression) qualifier;
 
         // Getting the arguments of the constructor

From 7d10b76a4bf93374c085b5bddd0dad6670bff85e Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 12:27:44 -0700
Subject: [PATCH 075/144] address PR comments

---
 .../buildtool/DynamicClientCreationCheck.java    | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index 457eddcde49..ee06082004c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -50,7 +50,7 @@ public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean i
     /**
      * This class extends the JavaElementVisitor to check for the dynamic creation of clients in the code.
      */
-    public static class DynamicClientCreationVisitor extends JavaElementVisitor {
+    static class DynamicClientCreationVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
         private final boolean isOnTheFly;
@@ -118,6 +118,7 @@ public void visitForStatement(@NotNull PsiForStatement statement) {
         /**
          * This method checks for the dynamic creation of clients in the code block of a for loop.
          * Each assignment statement and declaration statement is checked for the creation of clients.
+         *
          * @param blockChild
          */
 
@@ -138,13 +139,10 @@ private void checkClientCreation(PsiStatement blockChild) {
                 PsiExpression rhs = assignment.getRExpression();
 
                 // Check if the right-hand side is a method call expression
-                if (rhs != null) {
-                    if (isClientCreationMethod((PsiMethodCallExpression) rhs)) {
-                        holder.registerProblem(rhs, ANTI_PATTERN_MESSAGE);
-                    }
+                if (rhs != null && isClientCreationMethod((PsiMethodCallExpression) rhs)) {
+                    holder.registerProblem(rhs, ANTI_PATTERN_MESSAGE);
                 }
-            }
-            else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check for the declaration statement
+            } else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check for the declaration statement
 
                 PsiDeclarationStatement declarationStatement = (PsiDeclarationStatement) blockChild;
 
@@ -177,10 +175,11 @@ else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check
          * It checks the method name and the type of the qualifier expression.
          * If the method name is buildClient or AsyncBuildClient and the qualifier expression is of type com.azure,
          * then it is considered a client creation method.
+         *
          * @param methodCallExpression
          * @return
          */
-        public boolean isClientCreationMethod (PsiMethodCallExpression methodCallExpression){
+        public boolean isClientCreationMethod(PsiMethodCallExpression methodCallExpression) {
 
             // Extract the method expression from the method call expression
             PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
@@ -204,6 +203,7 @@ public boolean isClientCreationMethod (PsiMethodCallExpression methodCallExpress
 
         /**
          * This method loads the JSON configuration file and extracts the methods to check for dynamic client creation.
+         *
          * @return Map<String, Object>
          * @throws IOException
          */

From d38529fedebdab02b9803224f89e65803d422e6f Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 13:09:38 -0700
Subject: [PATCH 076/144] address PR comments

---
 .../azure/sdk/buildtool/RuleConfig.java       | 15 ++++++++------
 .../azure/sdk/buildtool/RuleConfigLoader.java | 20 ++++++++++++-------
 .../ServiceBusReceiverAsyncClientCheck.java   |  7 ++++++-
 .../StorageUploadWithoutLengthCheck.java      |  9 ++++++++-
 .../main/resources/META-INF/ruleConfigs.json  |  5 ++---
 5 files changed, 38 insertions(+), 18 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index a4b414ff787..39f4c46acc3 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -1,5 +1,6 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
+import java.util.Collections;
 import java.util.List;
 
 /**
@@ -9,19 +10,21 @@
 class RuleConfig {
     private final List<String> methodsToCheck;
     private final String clientName;
-    private final String antipatternMessage;
+    private final String antiPatternMessage;
+
+    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), "", "");
 
     /**
      * Constructor for RuleConfig.
      *
      * @param methodsToCheck     List of methods to check.
      * @param clientName         Client name.
-     * @param antipatternMessage Antipattern message.
+     * @param antiPatternMessage Antipattern message.
      */
-    public RuleConfig(List<String> methodsToCheck, String clientName, String antipatternMessage) {
+    public RuleConfig(List<String> methodsToCheck, String clientName, String antiPatternMessage) {
         this.methodsToCheck = methodsToCheck;
         this.clientName = clientName;
-        this.antipatternMessage = antipatternMessage;
+        this.antiPatternMessage = antiPatternMessage;
     }
 
     // Getters
@@ -50,6 +53,6 @@ public String getClientName() {
      * @return Antipattern message
      */
     public String getAntiPatternMessage() {
-        return antipatternMessage;
+        return antiPatternMessage;
     }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 8849949d14e..69996c22ce7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -67,10 +67,16 @@ public static RuleConfigLoader getInstance() {
      * This method returns the RuleConfig object for the given key
      *
      * @param key - the key to get the RuleConfig object
-     * @return RuleConfig object
+     * @return RuleConfig object or empty rule if one does not exist, {@link RuleConfig#EMPTY_RULE}
      */
     RuleConfig getRuleConfig(String key) {
-        return ruleConfigs.get(key);
+
+        RuleConfig ruleConfig = ruleConfigs.get(key);
+        if (ruleConfig == null) {
+            return RuleConfig.EMPTY_RULE;
+        } else {
+            return ruleConfig;
+        }
     }
 
     /**
@@ -87,7 +93,7 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
         // Open the input stream to the JSON file
         try (InputStream is = RuleConfigLoader.class.getResourceAsStream(filePath);
 
-             // Create a JsonReader to read the JSON file
+             // Create a JsonReader to read the JSON file -- need another try to close the json reader
              JsonReader reader = JsonProviders.createReader(is)) {
 
             // Check if the JSON file starts with an object
@@ -121,7 +127,7 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
     private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
         List<String> methodsToCheck = new ArrayList<>();
         String clientName = null;
-        String antipatternMessage = null;
+        String antiPatternMessage = null;
 
         // Check if the JSON file starts with an object
         if (reader.nextToken() != JsonToken.START_OBJECT) {
@@ -141,14 +147,14 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                 case "client_name":
                     clientName = reader.getString();
                     break;
-                case "antipattern_message":
-                    antipatternMessage = reader.getString();
+                case "anti_pattern_message":
+                    antiPatternMessage = reader.getString();
                     break;
                 default:
                     reader.skipChildren();
             }
         }
-        return new RuleConfig(methodsToCheck, clientName, antipatternMessage);
+        return new RuleConfig(methodsToCheck, clientName, antiPatternMessage);
     }
 
     /**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 97f2032be98..1fdbf12a124 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -19,6 +19,7 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
     // Define constants for string literals
     private static final String CLIENT_NAME;
     private static final String SUGGESTION;
+    private static final boolean SKIP_WHOLE_RULE;
 
     // Static initializer block to load the client data once
     static {
@@ -27,6 +28,7 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
         RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
         final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
 
+        SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE;
         CLIENT_NAME = ruleConfig.getClientName();
         SUGGESTION = ruleConfig.getAntiPatternMessage();
     }
@@ -48,6 +50,10 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
             public void visitTypeElement(PsiTypeElement element) {
                 super.visitTypeElement(element);
 
+                if (SKIP_WHOLE_RULE) {
+                    return;
+                }
+
                 // Check if the element is an instance of PsiTypeElement
                 if (element instanceof PsiTypeElement && element.getType() != null) {
 
@@ -57,7 +63,6 @@ public void visitTypeElement(PsiTypeElement element) {
                     }
                 }
             }
-
         };
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 18676491cd8..54e15694fc7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -32,6 +32,8 @@ public String getDisplayName() {
     private static final List<String> METHODS_TO_CHECK_LIST;
     private static final String LENGTH_TYPE = "long";
     private static final String SUGGESTION;
+    private static final boolean SKIP_WHOLE_RULE;
+
 
     static {
         final String ruleName = "StorageUploadWithoutLengthCheck";
@@ -41,6 +43,7 @@ public String getDisplayName() {
         final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
         METHODS_TO_CHECK_LIST = ruleConfig.getMethodsToCheck();
         SUGGESTION = ruleConfig.getAntiPatternMessage();
+        SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK_LIST.isEmpty();
     }
 
     /**
@@ -64,6 +67,10 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                     return;
                 }
 
+                if (SKIP_WHOLE_RULE) {
+                    return;
+                }
+
                 boolean hasLengthArg = false;
 
                 PsiExpressionList argumentList = expression.getArgumentList();
@@ -138,4 +145,4 @@ private boolean isLengthArgumentInCall(PsiExpression qualifier) {
         }
         return false;
     }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d0361d1b107..d34c5dbcc41 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -4,11 +4,10 @@
       "upload",
       "uploadWithResponse"
     ],
-    "antipattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
+    "anti_pattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
   },
-
   "ServiceBusReceiverAsyncClientCheck": {
     "client_name": "ServiceBusReceiverAsyncClient",
-    "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+    "anti_pattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
   }
 }

From 52930f6248a656dcc03bb3e490a19fa9534db88e Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Fri, 12 Jul 2024 16:54:18 -0700
Subject: [PATCH 077/144] small Update README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md                 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index c79e0c56a75..c90bc65b0d4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -56,7 +56,7 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 
 3. #### Disable Auto-complete when using ServiceBusReceiver or Processor clients
 
-- **Anti-pattern**:When using ServiceBusReceiver or Processor clients, auto-complete is enabled by default, but this
+- **Anti-pattern**: When using ServiceBusReceiver or Processor clients, auto-complete is enabled by default, but this
   behavior is not explicitly verified or disabled when necessary.
 - **Issue**: Auto-complete being enabled by default might lead to messages being marked as completed even if the message
   processing fails or encounters an error.
@@ -67,4 +67,4 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   disableAutoComplete() method call to prevent automatic message completion.
   Please refer to
   the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.servicebus.servicebusclientbuilder.servicebusreceiverclientbuilder?view=azure-java-stable#com-azure-messaging-servicebus-servicebusclientbuilder-servicebusreceiverclientbuilder-disableautocomplete())
-  for additional information.
\ No newline at end of file
+  for additional information.

From e72c47f21b1fb4b09fbcb8e186c143afdbe200cc Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 18:29:01 -0700
Subject: [PATCH 078/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md | 28 +++++++++++++------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 7444aa2f596..8457be7fdbd 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -55,6 +55,7 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   for additional information.
 
 3. #### Disable Auto-complete when using ServiceBusReceiver or Processor clients
+
 - **Anti-pattern**: When using ServiceBusReceiver or Processor clients, auto-complete is enabled by default, but this
   behavior is not explicitly verified or disabled when necessary.
 - **Issue**: Auto-complete being enabled by default might lead to messages being marked as completed even if the message
@@ -67,14 +68,25 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   Please refer to
   the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.servicebus.servicebusclientbuilder.servicebusreceiverclientbuilder?view=azure-java-stable#com-azure-messaging-servicebus-servicebusclientbuilder-servicebusreceiverclientbuilder-disableautocomplete())
   for additional information.
-- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use
+  the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message
+  consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This
+  makes it a more suitable option for most developers and scenarios.
+  Please refer to
+  the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient)
+  for additional information.
 
 4. #### Dynamic Client Creation is wasteful
-- **Anti-pattern**: Dynamic client creation refers to creating a new client instance for each operation, without reusing existing instances.
-- **Issue**: This process can be resource-intensive and slow, especially if repeated frequently. It can lead to performance issues, increased memory usage, and unnecessary overhead.
+
+- **Anti-pattern**: Dynamic client creation refers to creating a new client instance for each operation, without reusing
+  existing instances.
+- **Issue**: This process can be resource-intensive and slow, especially if repeated frequently. It can lead to
+  performance issues, increased memory usage, and unnecessary overhead.
 - **Severity: WARNING**
-- **Recommendation**: Instead of creating a new client instance for each operation, consider reusing existing client instances. 
-It's recommended to create client instances once and reuse them throughout the application's lifecycle. 
-This approach can lead to better performance and efficiency.
-Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/developer/java/sdk/overview#connect-to-and-use-azure-resources-with-client-libraries) for additional information.
\ No newline at end of file
+- **Recommendation**: Instead of creating a new client instance for each operation, consider reusing existing client
+  instances.
+  It's recommended to create client instances once and reuse them throughout the application's lifecycle.
+  This approach can lead to better performance and efficiency.
+  Please refer to
+  the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/developer/java/sdk/overview#connect-to-and-use-azure-resources-with-client-libraries)
+  for additional information.
\ No newline at end of file

From 6e76dbae8b7797836defae32ba24b10db058a77e Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 12 Jul 2024 19:35:00 -0700
Subject: [PATCH 079/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md | 25 ++++++-
 .../azure-intellij-plugin-azure-sdk/readme.md | 36 ---------
 .../HardcodedAPIKeysAndTokensCheckTest.java   | 73 ++++++-------------
 3 files changed, 47 insertions(+), 87 deletions(-)
 delete mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3cd55989065..bac4d0f7c45 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -1,15 +1,36 @@
 # Project: Java Code Quality Analyzer
 
 ## Project Description
-The Java Code Quality Analyzer, is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
+The Java Code Quality Analyzer is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
 
 ## Key Features
 
 - **Rule Set Integration**: This feature enables users to import and customize rule sets, tailoring the plugin to their specific needs.
 - **Telemetry Integration**: This feature connects the plugin to the backend with Application Insights, allowing for efficient data transmission.
-- **Azure Toolkit Integration**: This feature allows the plugin to integrate with the IntelliJ Azure toolkit, providing extended functionality.
+- **Azure Toolkit for IntelliJ Integration**: This feature allows the plugin to integrate with the Azure Toolkit for IntelliJ, providing extended functionality
 - **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
 - **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
 
 ## User Interface
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
+
+
+## Rules
+1. #### Storage Upload without Length Check
+- **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
+- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
+- **Severity: INFO**
+- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
+
+2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
+- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
+- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
+- **Severity: WARNING**
+- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
+Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
+
+3. #### Hardcoded APIs & Access Tokens Check
+- **Anti-pattern**: Hardcoding API keys and tokens in the source code.
+- **Issue**: The source code contains hardcoded API keys and tokens, which is a security risk. It exposes sensitive information that could be exploited if the code is publicly accessible or falls into the wrong hands.
+- **Severity**: WARNING.
+- **Recommendation**: DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
deleted file mode 100644
index 58e99b0fa08..00000000000
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/readme.md
+++ /dev/null
@@ -1,36 +0,0 @@
-# Project: Java Code Quality Analyzer
-
-## Project Description
-The Java Code Quality Analyzer, is a plugin designed to improve the quality of Java code. It provides an interactive tool window that offers real-time code suggestions. The following are proposed essential features, including rule set integration, telemetry connectivity, and Azure Toolkit integration.
-
-## Key Features
-
-- **Rule Set Integration**: This feature enables users to import and customize rule sets, tailoring the plugin to their specific needs.
-- **Telemetry Integration**: This feature connects the plugin to the backend with Application Insights, allowing for efficient data transmission.
-- **Azure Toolkit Integration**: This feature allows the plugin to integrate with the IntelliJ Azure toolkit, providing extended functionality.
-- **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding experience.
-- **Quick-Fix Actions**: This feature identifies issues and suggests quick actions within the tool window, facilitating immediate problem resolution.
-
-## User Interface
-- **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
-
-
-## Rules
-1. #### Storage Upload without Length Check
-- **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
-- **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
-- **Severity: INFO**
-- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
-
-2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
-- **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
-- **Issue**: The main issue with using `ServiceBusReceiverAsyncClient` is its complexity and the requirement for a deep understanding of Reactive programming. This can make it difficult to use correctly and efficiently, especially for developers who are not familiar with Reactive programming paradigms.
-- **Severity: WARNING**
-- **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
-Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
-
-3. #### Hardcoded APIs & Access Tokens Check
-- **Anti-pattern**: Hardcoding API keys and tokens in the source code.
-- **Issue**: The source code contains hardcoded API keys and tokens, which is a security risk. It exposes sensitive information that could be exploited if the code is publicly accessible or falls into the wrong hands.
-- **Severity**: WARNING.
-- **Recommendation**: DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
index 835a8586503..9bb8749b633 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheckTest.java
@@ -1,7 +1,6 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
-import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck.APIKeysAndTokensVisitor;
 
-import com.intellij.psi.JavaElementVisitor;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck.APIKeysAndTokensVisitor;
 import com.intellij.psi.PsiJavaCodeReferenceElement;
 import com.intellij.psi.PsiNewExpression;
 
@@ -9,11 +8,11 @@
 import com.intellij.psi.PsiElementVisitor;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.Mock;
 import org.mockito.Mockito;
 
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
@@ -23,15 +22,15 @@
 /**
  * Test the HardcodedAPIKeysAndTokensCheck class for hardcoded API keys and tokens.
  * When a client is authenticated with AzurekeyCredentials and AccessToken, a problem is registered.
- These are some instances that a flag would be raised.
+ * These are some instances that a flag would be raised.
  * 1. TextAnalyticsClient client = new TextAnalyticsClientBuilder()
- *         .endpoint(endpoint)
- *         .credential(new AzureKeyCredential(apiKey))
- *         .buildClient();
- *
+ * .endpoint(endpoint)
+ * .credential(new AzureKeyCredential(apiKey))
+ * .buildClient();
+ * <p>
  * 2. TokenCredential credential = request -> {
- *         AccessToken token = new AccessToken("<your-hardcoded-token>", OffsetDateTime.now().plusHours(1));
- *     }
+ * AccessToken token = new AccessToken("<your-hardcoded-token>", OffsetDateTime.now().plusHours(1));
+ * }
  */
 public class HardcodedAPIKeysAndTokensCheckTest {
 
@@ -53,19 +52,12 @@ public void setup() {
      * Test the HardcodedAPIKeysAndTokensCheck class for hardcoded API keys and tokens.
      * When a client is authenticated with AzurekeyCredentials and AccessToken, a problem is registered.
      */
-    @Test
-    public void testHardcodedAPIKeysAndTokensCheck() {
-
-        // assert visitor
-        assertVisitor(mockVisitor);
+    @ParameterizedTest
+    @ValueSource(strings = {"AzureKeyCredential", "AccessToken", "KeyCredential", "AzureNamedKeyCredential", "AzureSasCredential", "AzureNamedKey", "ClientSecretCredentialBuilder", "UsernamePasswordCredentialBuilder", "BasicAuthenticationCredential"})
+    public void testHardcodedAPIKeysAndTokensCheck(String clientType) {
 
-        int NUMBER_OF_INVOCATIONS = 1; // number of times registerProblem is called
-
-        String CLIENT_TO_CHECK_ONE = "AccessToken";
-        verifyRegisterProblem(CLIENT_TO_CHECK_ONE, NUMBER_OF_INVOCATIONS);
-
-        String CLIENT_TO_CHECK_TWO = "AzureKeyCredential";
-        verifyRegisterProblem(CLIENT_TO_CHECK_TWO, NUMBER_OF_INVOCATIONS);
+        int numOfInvocations = 1; // number of times registerProblem is called
+        verifyRegisterProblem(clientType, numOfInvocations);
     }
 
     /**
@@ -75,12 +67,9 @@ public void testHardcodedAPIKeysAndTokensCheck() {
     @Test
     public void testNonAuthAzureClientUse() {
 
-        // assert visitor
-        assertVisitor(mockVisitor);
-
-        String CLIENT_TO_CHECK = "SomeOtherClient";
-        int NUMBER_OF_INVOCATIONS = 0;
-        verifyRegisterProblem(CLIENT_TO_CHECK, NUMBER_OF_INVOCATIONS);
+        String authServiceToCheck = "SomeOtherClient";
+        int numOfInvocations = 0;
+        verifyRegisterProblem(authServiceToCheck, numOfInvocations);
     }
 
     /**
@@ -89,15 +78,11 @@ public void testNonAuthAzureClientUse() {
     @Test
     public void testNullClassReference() {
 
-        // assert visitor
-        assertVisitor(mockVisitor);
-
-        String CLIENT_TO_CHECK = ""; // null class reference
-        int NUMBER_OF_INVOCATIONS = 0;
-        verifyRegisterProblem(CLIENT_TO_CHECK, NUMBER_OF_INVOCATIONS);
+        String authServiceToCheck = ""; // null class reference
+        int numOfInvocations = 0;
+        verifyRegisterProblem(authServiceToCheck, numOfInvocations);
     }
 
-
     // Helper method to create visitor.
     PsiElementVisitor createVisitor() {
         boolean isOnTheFly = true;
@@ -105,30 +90,20 @@ PsiElementVisitor createVisitor() {
         return visitor;
     }
 
-
-    // Helper method to assert visitor is not null and is an instance of JavaElementVisitor
-    void assertVisitor(PsiElementVisitor mockVisitor) {
-
-        assertNotNull(mockVisitor);
-        assertTrue(mockVisitor instanceof JavaElementVisitor);
-    }
-
     // Helper method to verify registerProblem is called
-    void verifyRegisterProblem(String CLIENT_TO_CHECK, int NUMBER_OF_INVOCATIONS) {
+    private void verifyRegisterProblem(String authServiceToCheck, int numOfInvocations) {
 
         PsiNewExpression newExpression = mock(PsiNewExpression.class);
         PsiJavaCodeReferenceElement javaCodeReferenceElement = mock(PsiJavaCodeReferenceElement.class);
 
         when(newExpression.getClassReference()).thenReturn(javaCodeReferenceElement);
-        when(javaCodeReferenceElement.getReferenceName()).thenReturn(CLIENT_TO_CHECK);
+        when(javaCodeReferenceElement.getReferenceName()).thenReturn(authServiceToCheck);
 
         when(javaCodeReferenceElement.getQualifiedName()).thenReturn("com.azure");
 
         mockVisitor.visitElement(newExpression);
 
         // Verify registerProblem is called
-        verify(mockHolder, times(NUMBER_OF_INVOCATIONS)).registerProblem(eq(newExpression),
-                Mockito.contains("DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). " +
-                        "If not, then use Azure Key Credential for API key based authentication."));
+        verify(mockHolder, times(numOfInvocations)).registerProblem(eq(newExpression), Mockito.contains("DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). " + "If not, then use Azure Key Credential for API key based authentication."));
     }
 }

From dd484f8ab416525403c06dc4bd00e5bcb54d9df9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 13 Jul 2024 12:37:45 -0700
Subject: [PATCH 080/144] complete implementation of ServiceBusReceiveModeCheck

---
 .../azure-intellij-plugin-azure-sdk/README.md |  22 ++-
 .../buildtool/ServiceBusReceiveModeCheck.java | 179 +++++++++++-------
 .../main/resources/META-INF/ruleConfigs.json  |  11 +-
 .../ServiceBusReceiveModeCheckTest.java       | 106 +++++++++--
 4 files changed, 231 insertions(+), 87 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 6163f5f84bc..4bad22ef2bd 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -107,4 +107,24 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   Credential (Entra ID Authentication). If not, then use Azure Key Credential or Connection Strings based
   authentication. Please refer to
   the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
-  for additional information.
\ No newline at end of file
+  for additional information.
+
+7. #### Managing Receive Mode and Prefetch Value in Azure Service Bus
+
+- **Anti-pattern**: Setting the receive mode as PEEK_LOCK with a high prefetch value (e.g., 50 or 100) in Azure Service
+  Bus.
+- **Severity: WARNING**
+- **Issue**:
+    1. **Suboptimal Performance:** A high prefetch value in PEEK_LOCK mode can result in suboptimal performance, as one
+       client
+       locks all prefetched messages, potentially leading to processing bottlenecks.
+    2. **Message Lock Expiry:** Messages in the prefetch queue do not have their locks renewed automatically. Consequently,
+       the
+       message lock may expire by the time they are processed.
+    3. **Dead-Letter Queue:** Expired message locks can result in messages being inadvertently sent to the dead-letter
+       queue,
+       causing potential data loss or requiring additional handling to recover these messages.
+- **Recommendation**: Optimize Prefetch Value - Set a prefetch value that balances between efficient message
+  retrieval and the ability for multiple clients to process messages concurrently. Please refer to
+  the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-prefetch?tabs=dotnet#why-is-prefetch-not-the-default-option)
+  for additional information.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
index bb1d09faa93..863ca5b7f55 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -13,8 +13,16 @@
 import com.intellij.psi.PsiVariable;
 import org.jetbrains.annotations.NotNull;
 
+import java.util.List;
 import java.util.OptionalInt;
-
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+/**
+ * This class extends the LocalInspectionTool and is used to inspect the usage of Azure SDK ServiceBus & ServiceBusProcessor clients in the code.
+ * It checks if the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1.
+ * If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1, a problem is registered with the ProblemsHolder.
+ */
 public class ServiceBusReceiveModeCheck extends LocalInspectionTool {
 
     /**
@@ -29,12 +37,40 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
         return new ServiceBusReceiveModeVisitor(holder, isOnTheFly);
     }
 
+    /**
+     * This class extends the JavaElementVisitor and is used to visit the Java elements in the code.
+     * It checks for the usage of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients and
+     * whether the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1.
+     * If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1,
+     * a problem is registered with the ProblemsHolder.
+     */
     static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
 
-
         // Define the holder for the problems found
         private static ProblemsHolder holder;
 
+        // Define constants for string literals
+        private static final RuleConfig ruleConfig;
+        private static final String SUGGESTION;
+        private static final List<String> METHODS_TO_CHECK;
+        private static final List<String> CLIENTS_TO_CHECK;
+        private static boolean SKIP_WHOLE_RULE;
+
+        private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiveModeCheck.class.getName());
+
+        static {
+            final String ruleName = "ServiceBusReceiveModeCheck";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+            // Get the RuleConfig object for the rule
+            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+
+            METHODS_TO_CHECK = ruleConfig.getMethodsToCheck();
+            CLIENTS_TO_CHECK = ruleConfig.getClientsToCheck();
+            SUGGESTION = ruleConfig.getAntiPatternMessage();
+            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
+        }
+
         /**
          * Constructor for the visitor
          *
@@ -44,11 +80,23 @@ public ServiceBusReceiveModeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
         }
 
-
+        /**
+         * This method is used to visit the declaration statement in the code.
+         * It checks for the declaration of the Azure SDK ServiceBusReceiver & ServiceBusProcessor clients
+         * and whether the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1.
+         * If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1,
+         * a problem is registered with the ProblemsHolder.
+         *
+         * @param statement The declaration statement to visit
+         */
         @Override
         public void visitDeclarationStatement(PsiDeclarationStatement statement) {
             super.visitDeclarationStatement(statement);
 
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
             // Get the declared elements
             PsiElement[] elements = statement.getDeclaredElements();
 
@@ -61,22 +109,26 @@ public void visitDeclarationStatement(PsiDeclarationStatement statement) {
             }
         }
 
+        /**
+         * This method is used to process the variable declaration.
+         * It checks if the client type is an Azure ServiceBus client and
+         * retrieves the client name (left side of the declaration).
+         *
+         * @param variable The variable to process
+         */
         private void processVariableDeclaration(PsiVariable variable) {
 
             // Retrieve the client name (left side of the declaration)
             PsiType clientType = variable.getType();
-            System.out.println("clientType: " + clientType);
-
-            // Check the assignment part (right side)
-            PsiExpression initializer = variable.getInitializer();
-            System.out.println("initializer: " + initializer);
-            System.out.println("clientType.getCanonicalText(): " + clientType.getCanonicalText());
 
             // Check if the client type is an Azure ServiceBus client
-            if (!clientType.getCanonicalText().contains("servicebus")){
+            if (!clientType.getCanonicalText().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && !CLIENTS_TO_CHECK.contains(clientType.getCanonicalText())) {
                 return;
             }
 
+            // Check the assignment part (right side)
+            PsiExpression initializer = variable.getInitializer();
+
             if (!(initializer instanceof PsiMethodCallExpression)) {
                 return;
             }
@@ -86,104 +138,103 @@ private void processVariableDeclaration(PsiVariable variable) {
 
         }
 
+        /**
+         * This method is used to determine the receive mode of the Azure ServiceBus client.
+         * It checks if the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1.
+         * If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1,
+         * a problem is registered with the ProblemsHolder.
+         *
+         * @param methodCall The method call expression to check
+         */
         private void determineReceiveMode(PsiMethodCallExpression methodCall) {
 
             OptionalInt prefetchCountValue = OptionalInt.empty();
             boolean isReceiveModePeekLock = false;
-            PsiMethodCallExpression prefetchCountQualifier = null; // Declaration at the method level
+            PsiElement prefetchCountMethod = null;
 
             // Iterating up the chain of method calls
             PsiExpression qualifier = methodCall.getMethodExpression().getQualifierExpression();
-            System.out.println("qualifier1: " + qualifier);
 
             // Check if the method call chain has the method to check
             while (qualifier instanceof PsiMethodCallExpression) {
 
-                if (qualifier instanceof PsiMethodCallExpression) {
-
-                    System.out.println("Next qualifier pass");
-                    System.out.println("qualifier2: " + qualifier);
-
-                    // Get the method expression
-                    PsiReferenceExpression methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
-                    System.out.println("methodExpression: " + methodExpression);
-
-                    // Get the method name
-                    String methodName = methodExpression.getReferenceName();
-
-                    System.out.println("methodName: " + methodName);
-
-                    // Check if the method name is the method to check
-                    if ("receiveMode".equals(methodName)) {
-                        // get its parameters
+                // Get the method expression
+                PsiReferenceExpression methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
 
-                        isReceiveModePeekLock = receiveModePeekLockCheck((PsiMethodCallExpression) qualifier);
-                        System.out.println("isReceiveModePeekLock: " + isReceiveModePeekLock);
+                // Get the method name
+                String methodName = methodExpression.getReferenceName();
 
-                        // access its parameters
-                    }
-                    else if ("prefetchCount".equals(methodName)) {
-                        System.out.println("prefetchCount method detected");
+                // Check if the method name is the method to check
+                // "receiveMode is the first method to check"
 
-                        prefetchCountValue = getPrefetchCount((PsiMethodCallExpression) qualifier);
-                        prefetchCountQualifier = (PsiMethodCallExpression) qualifier; // Assigning the current qualifier
-                        System.out.println("prefetchCountValue.getAsInt(): " + prefetchCountValue.getAsInt());
-                        System.out.println("prefetchCountQualifier: " + prefetchCountQualifier);
-                    }
+                if (METHODS_TO_CHECK.get(0).equals(methodName)) {
+                    isReceiveModePeekLock = receiveModePeekLockCheck((PsiMethodCallExpression) qualifier);
+                }
+                // "prefetchCount is the second method to check"
+                else if (METHODS_TO_CHECK.get(1).equals(methodName)) {
+                    prefetchCountValue = getPrefetchCount((PsiMethodCallExpression) qualifier);
+                    prefetchCountMethod = ((PsiMethodCallExpression) qualifier).getMethodExpression().getReferenceNameElement();
                 }
 
+                // Get the qualifier of the method call expression -- the next method call in the chain
                 qualifier = ((PsiMethodCallExpression) qualifier).getMethodExpression().getQualifierExpression();
 
-                if (prefetchCountValue.isPresent() && prefetchCountValue.getAsInt() > 1 && isReceiveModePeekLock) {
-                    System.out.println("prefetchCountValue.getAsInt()whol: " + prefetchCountValue.getAsInt());
-                    System.out.println("prefetchCountQualifierwhol: " + prefetchCountQualifier);
-                    System.out.println("Problem detected");
-                    holder.registerProblem(prefetchCountQualifier, "A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval.");
+                // If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1, register a problem
+                if (prefetchCountValue.isPresent() && prefetchCountValue.getAsInt() > 1 && isReceiveModePeekLock && prefetchCountMethod != null) {
+                    holder.registerProblem(prefetchCountMethod, SUGGESTION);
+                    return;
                 }
             }
         }
 
-        private boolean receiveModePeekLockCheck (PsiMethodCallExpression qualifier) {
+        /**
+         * This method is used to check if the receive mode is set to PEEK_LOCK.
+         *
+         * @param qualifier The method call expression to check
+         * @return true if the receive mode is set to PEEK_LOCK, false otherwise
+         */
+        private boolean receiveModePeekLockCheck(PsiMethodCallExpression qualifier) {
+
+            String peekLockArgument = "PEEK_LOCK";
 
-            System.out.println("qualifier at receiveModePeekLockCheck: " + qualifier);
+            // Get the arguments of the method call expression
             PsiExpression[] arguments = qualifier.getArgumentList().getExpressions();
-            System.out.println("arguments: " + arguments);
 
             for (PsiExpression argument : arguments) {
-                System.out.println("argument: " + argument);
                 String argumentText = argument.getText();
-                System.out.println("argumentText: " + argumentText);
 
-                if (argumentText.contains("PEEK_LOCK")) {
-                    System.out.println("Found .PEEK_LOCK in parameters");
+                // Check if the argument is set to PEEK_LOCK
+                if (argumentText.contains(peekLockArgument)) {
                     return true;
                 }
             }
             return false;
         }
 
+        /**
+         * This method is used to get the prefetch count value.
+         *
+         * @param qualifier The method call expression to check
+         * @return The prefetch count value
+         */
         private OptionalInt getPrefetchCount(PsiMethodCallExpression qualifier) {
 
-            System.out.println("qualifiergetPrefetchCount: " + qualifier);
-
+            // Get the arguments of the method call expression
             PsiExpression[] arguments = qualifier.getArgumentList().getExpressions();
-            System.out.println("arguments: " + arguments);
-            System.out.println("arguments.length: " + arguments.length);
             if (arguments.length > 0) {
+
+                // Get the argument text
                 String argumentText = arguments[0].getText();
-                System.out.println("argumentText: " + argumentText);
-                System.out.println("argument: " + arguments[0]);
                 try {
-                    System.out.println("prefetchCountValue: " + Integer.parseInt(argumentText));
+                    // Parse the argument text to an integer to get the prefetch count value
                     return OptionalInt.of(Integer.parseInt(argumentText));
                 } catch (NumberFormatException e) {
-                    // Handle the case where the argument text is not a valid integer
+                    LOGGER.log(Level.SEVERE, "Failed to parse prefetch count: " + argumentText, e);
                 }
             }
-
-            // optionalInt is a wrapper for an integer value that may or may not be present
-            // This is because can't return null from a method that returns an int
-            // and returning 0 is not a good idea because 0 is a valid value for prefetchCount
+            // OptionalInt is used here as a container that can either hold an integer value or indicate that no value is present.
+            // This approach is necessary because the method signature specifies an int return type, which cannot be null
+            // Using OptionalInt avoids the ambiguity of returning a special value (like 0) to indicate absence, especially since 0 is a legitimate value for prefetchCount.
             return OptionalInt.empty();
         }
     }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 88a6c6b2b4b..405cbbe9c28 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -45,5 +45,14 @@
     "methods_to_check": "connectionString",
     "anti_pattern_message": "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
     "solution": "DefaultAzureCredential is recommended if the service client supports Token Credential (Entra ID Authentication). if not, then use Azure Key Credential / Connection Strings based authentication"
+  },
+  "ServiceBusReceiveModeCheck": {
+    "clients_to_check": [
+      "ServiceBusReceiverClient",
+      "ServiceBusReceiverAsyncClient",
+      "ServiceBusProcessorClient"
+    ],
+    "methods_to_check": ["receiveMode","prefetchCount"],
+    "anti_pattern_message": "A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."
   }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java
index 7ceea0c21e0..e2cefe1cc4e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheckTest.java
@@ -12,6 +12,8 @@
 import com.intellij.psi.PsiVariable;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.Mock;
 
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ServiceBusReceiveModeCheck.ServiceBusReceiveModeVisitor;
@@ -23,6 +25,11 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+/**
+ * This class contains the tests for the ServiceBusReceiveModeCheck class.
+ * It tests the visitDeclarationStatement method of the ServiceBusReceiveModeVisitor class.
+ * It tests the method with different combinations of the receiveMode and prefetchCount methods.
+ */
 public class ServiceBusReceiveModeCheckTest {
 
     // Create a mock ProblemsHolder to be used in the test
@@ -47,55 +54,101 @@ public void setUp() {
     }
 
 
-    @Test
-    public void testProblemRegisteredWithReceiveModeAndHighPeekLock() {
+    /**
+     * This tests the visitor with receiveMode as PEEK_LOCK and prefetchCount as 100.
+     * The test verifies that a problem is registered with the ProblemsHolder.
+     */
+    @ParameterizedTest
+    @ValueSource(strings = {"ServiceBusReceiverClient", "ServiceBusReceiverAsyncClient", "ServiceBusProcessorClient"})
+    public void testWithPeekLockAndHighPrefetchCount(String clientName) {
 
-        String packageName = "servicebus";
         String methodFoundOne = "receiveMode";
         String methodFoundTwo = "prefetchCount";
         int numOfInvocations = 1;
         String prefetchCountValue = "100";
 
-        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+        verifyProblemRegistered(clientName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
     }
 
+    /**
+     * This tests the visitor with receiveMode as PEEK_LOCK and prefetchCount as 1.
+     * The test verifies that a problem is not registered with the ProblemsHolder.
+     */
     @Test
-    public void testProblemRegisteredWithoutReceiveModeAndHighPeekLock() {
+    public void testWithPeekLockAndLowPrefetchCount() {
+
+        String clientName = "ServiceBusReceiverClient";
+        String methodFoundOne = "receiveMode";
+        String methodFoundTwo = "prefetchCount";
+        int numOfInvocations = 0;
+        String prefetchCountValue = "1";
 
-        String packageName = "servicebus";
+        verifyProblemRegistered(clientName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+    }
+
+    /**
+     * This tests the visitor without a receiveMode.
+     * The test verifies that a problem is not registered with the ProblemsHolder.
+     */
+    @Test
+    public void testWithoutPeekLockAndHighPrefetchCount() {
+
+        String clientName = "ServiceBusReceiverClient";
         String methodFoundOne = "notreceiveMode";
         String methodFoundTwo = "prefetchCount";
         int numOfInvocations = 0;
         String prefetchCountValue = "100";
 
-        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+        verifyProblemRegistered(clientName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
     }
 
+    /**
+     * This tests the visitor without a receiveMode and with a prefetchCount of 100.
+     * The test verifies that a problem is not registered with the ProblemsHolder.
+     */
     @Test
-    public void testProblemRegisteredWithReceiveModeAndNoPrefetchCount() {
+    public void testWithPeekLockAndNoPrefetchCount() {
 
-        String packageName = "servicebus";
+        String clientName = "ServiceBusReceiverClient";
         String methodFoundOne = "receiveMode";
         String methodFoundTwo = "noprefetchCount";
         int numOfInvocations = 0;
         String prefetchCountValue = "100";
 
-        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+        verifyProblemRegistered(clientName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
     }
 
+    /**
+     * This tests the visitor without a receiveMode and without a prefetchCount.
+     * The test verifies that a problem is not registered with the ProblemsHolder.
+     */
     @Test
-    public void testProblemRegisteredWithoutReceiveModeAndNoPrefetchCount() {
+    public void testWithoutPeekLockAndNoPrefetchCount() {
 
-        String packageName = "servicebus";
+        String clientName = "servicebus";
         String methodFoundOne = "notreceiveMode";
         String methodFoundTwo = "noprefetchCount";
         int numOfInvocations = 0;
         String prefetchCountValue = "100";
 
-        verifyProblemRegistered(packageName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+        verifyProblemRegistered(clientName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
     }
 
+    /**
+     * This tests the visitor with a different Azure service.
+     * The test verifies that a problem is not registered with the ProblemsHolder.
+     */
+    @Test
+    public void testDifferentAzureService() {
 
+        String clientName = "notservicebus";
+        String methodFoundOne = "notreceiveMode";
+        String methodFoundTwo = "noprefetchCount";
+        int numOfInvocations = 0;
+        String prefetchCountValue = "100";
+
+        verifyProblemRegistered(clientName, methodFoundOne, methodFoundTwo, numOfInvocations, prefetchCountValue);
+    }
 
 
     /**
@@ -109,8 +162,18 @@ private JavaElementVisitor createVisitor() {
     }
 
 
+    /**
+     * This method verifies that a problem is registered with the ProblemsHolder.
+     *
+     * @param clientName         The name of the client eg. ServiceBusReceiverClient
+     * @param methodFoundOne     The first method found, receiveMode
+     * @param methodFoundTwo     The second method found, prefetchCount
+     * @param numOfInvocations   The number of times the registerProblem method is called
+     * @param prefetchCountValue The value of the prefetchCount
+     */
+    private void verifyProblemRegistered(String clientName, String methodFoundOne, String methodFoundTwo, int numOfInvocations, String prefetchCountValue) {
 
-    private void verifyProblemRegistered(String packageName, String methodFoundOne, String methodFoundTwo, int numOfInvocations, String prefetchCountValue) {
+        String azurePackageName = "com.azure";
 
         PsiVariable declaredElement = mock(PsiVariable.class);
         PsiElement[] declaredElements = new PsiElement[]{declaredElement};
@@ -131,20 +194,20 @@ private void verifyProblemRegistered(String packageName, String methodFoundOne,
         PsiExpressionList methodArgumentList = mock(PsiExpressionList.class);
         PsiExpression[] methodArguments = new PsiExpression[]{prefetchCountParameter, receiveModePeekLockParameter};
 
-        PsiMethodCallExpression transitionMethodCall = mock(PsiMethodCallExpression.class);
-
         // Second level qualifier method call
-        PsiReferenceExpression expressionTwo = mock(PsiReferenceExpression.class);
         PsiMethodCallExpression qualifierTwo = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression methodExpressionTwo = mock(PsiReferenceExpression.class);
 
+        PsiElement prefetchCountMethod = mock(PsiElement.class);
+
 
         when(mockDeclarationStatement.getDeclaredElements()).thenReturn(declaredElements);
 
         // processVariableDeclaration method
         when(declaredElement.getType()).thenReturn(clientType);
         when(declaredElement.getInitializer()).thenReturn(initializer);
-        when(clientType.getCanonicalText()).thenReturn(packageName);
+        when(clientType.getCanonicalText()).thenReturn(azurePackageName);
+        when(clientType.getPresentableText()).thenReturn(clientName);
 
         // determineReceiveMode method
         // First level qualifier method call
@@ -168,12 +231,13 @@ private void verifyProblemRegistered(String packageName, String methodFoundOne,
         when(methodArgumentList.getExpressions()).thenReturn(methodArguments);
         when(prefetchCountParameter.getText()).thenReturn(prefetchCountValue);
 
+        when(methodExpressionTwo.getReferenceNameElement()).thenReturn(prefetchCountMethod);
+
         if (methodFoundOne != "receiveMode" || methodFoundTwo != "prefetchCount") {
             when(methodExpressionTwo.getQualifierExpression()).thenReturn(null);
         }
 
         mockVisitor.visitDeclarationStatement(mockDeclarationStatement);
-        verify(mockHolder, times(numOfInvocations)).registerProblem(eq(qualifierTwo),
-                contains("A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."));
+        verify(mockHolder, times(numOfInvocations)).registerProblem(eq(prefetchCountMethod), contains("A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."));
     }
-}
\ No newline at end of file
+}

From 1a3778b0c83e4491358f2693ac886c2b3bf00d9f Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Sat, 13 Jul 2024 12:44:49 -0700
Subject: [PATCH 081/144] minor edit to azure-intellij-plugin-azure-sdk.xml

---
 .../main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index ff29ece63b5..7b3275d7147 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -122,4 +122,4 @@
             </class>
         </localInspection>
     </extensions>
-</idea-plugin>
\ No newline at end of file
+</idea-plugin>

From 35a5f0b68f70f737f75f116d55bfc422cba5837b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 13 Jul 2024 12:55:10 -0700
Subject: [PATCH 082/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md |  5 +-
 .../buildtool/SingleOperationInLoopCheck.java | 58 ++++++++++++-------
 .../main/resources/META-INF/ruleConfigs.json  |  2 +-
 .../SingleOperationInLoopCheckTest.java       | 58 +++++++++----------
 4 files changed, 67 insertions(+), 56 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 8e3a574d4fe..32ad1f2d8d6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -31,8 +31,9 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
 
 3. #### Using Batch Operations Instead of Single Operations in a Loop
-- **Anti-pattern**: Calling a single operation in a for-loop when a batch operation API exists in the SDK that can handle multiple actions in one request.
-- **Issue**: Repeatedly calling a single operation in a loop leads to multiple network requests, which can be inefficient and slow.
+- **Anti-pattern**: Calling a single operation in a loop when a batch operation API exists in the SDK that can handle multiple actions in one request.
+- **Issue**: 
+  - Repeatedly calling a single operation in a loop leads to multiple network requests, which can be inefficient and slow.
   - Multiple requests also consume more resources (e.g., network bandwidth, server processing) compared to a single batch request.
 - **Severity: WARNING**
 - **Recommendation**: Use Batch Operations: If the SDK provides a batch operation API, use it to perform multiple actions in a single request.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
index 8df3540163e..9a996381689 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheck.java
@@ -33,25 +33,26 @@
  * Inspection to check if there is a Text Analytics client operation inside a loop.
  * If a Text Analytics client operation is found inside a loop,
  * and the API has a batch alternative, a problem will be registered.
- *
- * THis is an example of a situation where the inspection should register a problem:
- *
+ * <p>
+ * This is an example of a situation where the inspection should register a problem:
+ * <p>
  * // Loop through the list of texts and detect the language for each text
-*         1. for (String text : texts) {
-*             DetectedLanguage detectedLanguage = textAnalyticsClient.detectLanguage(text);
-*             System.out.println("Text: " + text + " | Detected Language: " + detectedLanguage.getName() + " | Confidence Score: " + detectedLanguage.getConfidenceScore());
-*         }
-*
-*         // Loop through the list of texts and detect the language for each text
-*        2.  DetectedLanguage detectedLanguage = null;
-*         for (String text : texts) {
-*             textAnalyticsClient.detectLanguage(text);
+ * 1. for (String text : texts) {
+ * DetectedLanguage detectedLanguage = textAnalyticsClient.detectLanguage(text);
+ * System.out.println("Text: " + text + " | Detected Language: " + detectedLanguage.getName() + " | Confidence Score: " + detectedLanguage.getConfidenceScore());
+ * }
+ * <p>
+ * // Loop through the list of texts and detect the language for each text
+ * 2. DetectedLanguage detectedLanguage = null;
+ * for (String text : texts) {
+ * textAnalyticsClient.detectLanguage(text));
  */
 public class SingleOperationInLoopCheck extends LocalInspectionTool {
 
     /**
      * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
-     * @param holder The holder for the problems found
+     *
+     * @param holder     The holder for the problems found
      * @param isOnTheFly Whether the inspection is running on the fly. If true, the inspection is running as you type.
      * @return The visitor for the inspection
      */
@@ -70,14 +71,14 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
     public static class SingleOperationInLoopVisitor extends JavaElementVisitor {
 
         // Define the holder for the problems found and whether the inspection is running on the fly
-        private static ProblemsHolder holder = null;
+        private final ProblemsHolder holder;
         private final boolean isOnTheFly;
 
         // Define the logger for the visitor
         private static final Logger LOGGER = Logger.getLogger(SingleOperationInLoopCheck.class.getName());
 
         // Define the suggestion message for the problem
-        private static String SUGGESTION = "";
+        private static String SUGGESTION;
 
         private static List<String> AVAILABLE_BATCH_METHODS;
 
@@ -97,6 +98,7 @@ public static class SingleOperationInLoopVisitor extends JavaElementVisitor {
 
         /**
          * Constructor for the visitor
+         *
          * @param holder     The holder for the problems found
          * @param isOnTheFly Whether the inspection is running on the fly. If true, the inspection is running as you type.
          */
@@ -107,6 +109,7 @@ public SingleOperationInLoopVisitor(ProblemsHolder holder, boolean isOnTheFly) {
 
         /**
          * Visit the for statement and check for single Azure client operation inside the loop.
+         *
          * @param statement The for statement to check
          */
         @Override
@@ -116,6 +119,7 @@ public void visitForStatement(@NotNull PsiForStatement statement) {
 
         /**
          * Visit the foreach statement and check for single Azure client operation inside the loop.
+         *
          * @param statement The foreach statement to check
          */
         @Override
@@ -125,6 +129,7 @@ public void visitForeachStatement(@NotNull PsiForeachStatement statement) {
 
         /**
          * Visit the while statement and check for single Azure client operation inside the loop.
+         *
          * @param statement The while statement to check
          */
         @Override
@@ -134,6 +139,7 @@ public void visitWhileStatement(@NotNull PsiWhileStatement statement) {
 
         /**
          * Visit the do-while statement and check for single Azure client operation inside the loop.
+         *
          * @param statement The do-while statement to check
          */
         @Override
@@ -144,6 +150,7 @@ public void visitDoWhileStatement(@NotNull PsiDoWhileStatement statement) {
 
         /**
          * Check the loop statement for a single Text Analytics Azure client operation inside the loop.
+         *
          * @param loopStatement The loop statement to check
          */
         private boolean checkLoopForTextAnalyticsClientOperation(PsiStatement loopStatement) {
@@ -155,6 +162,10 @@ private boolean checkLoopForTextAnalyticsClientOperation(PsiStatement loopStatem
                 return false;
             }
 
+            if (!(loopBody instanceof PsiBlockStatement)) {
+                return false;
+            }
+
             // Extract the code block from the block statement
             PsiBlockStatement blockStatement = (PsiBlockStatement) loopBody;
             PsiCodeBlock codeBlock = blockStatement.getCodeBlock();
@@ -162,14 +173,14 @@ private boolean checkLoopForTextAnalyticsClientOperation(PsiStatement loopStatem
             // extract statements in the loop body
             for (PsiStatement statement : codeBlock.getStatements()) {
 
-                    // Check if the statement is an expression statement and is an Azure client operation
+                // Check if the statement is an expression statement and is an Azure client operation
                 if (statement instanceof PsiExpressionStatement) {
-                        isExpressionAzureClientOperation(statement);
+                    isExpressionAzureClientOperation(statement);
                 }
 
                 // Check if the statement is a declaration statement and is an Azure client operation
                 if (statement instanceof PsiDeclarationStatement) {
-                        isDeclarationAzureClientOperation((PsiDeclarationStatement) statement);
+                    isDeclarationAzureClientOperation((PsiDeclarationStatement) statement);
                 }
             }
             return true;
@@ -179,6 +190,7 @@ private boolean checkLoopForTextAnalyticsClientOperation(PsiStatement loopStatem
         /**
          * Get the body of the loop statement.
          * The body of the loop statement is the statement that is executed in the loop.
+         *
          * @param loopStatement The loop statement to get the body from
          * @return The body of the loop statement
          */
@@ -194,6 +206,7 @@ public static PsiStatement getLoopBody(PsiStatement loopStatement) {
 
         /**
          * If the statement is an expression statement, check if the expression is an Azure client operation.
+         *
          * @param statement The statement to check
          * @return True if the statement is an Azure client operation, false otherwise
          */
@@ -212,13 +225,14 @@ private void isExpressionAzureClientOperation(PsiStatement statement) {
 
         /**
          * If the statement is a declaration statement, check if the initializer is an Azure client operation.
+         *
          * @param statement The declaration statement to check
          * @return True if the declaration statement is an Azure client operation, false otherwise
          */
         private void isDeclarationAzureClientOperation(PsiDeclarationStatement statement) {
 
             // getDeclaredElements() returns the variables declared in the statement
-            for (PsiElement element :  statement.getDeclaredElements()) {
+            for (PsiElement element : statement.getDeclaredElements()) {
 
                 if (!(element instanceof PsiVariable)) {
                     continue;
@@ -240,6 +254,7 @@ private void isDeclarationAzureClientOperation(PsiDeclarationStatement statement
          * Check if the method call is an Azure client operation.
          * Check the containing class of the method call and see if it is part of the Azure SDK.
          * If the class is part of the Azure SDK, increment the count of Azure client operations.
+         *
          * @param methodCall The method call expression to check
          * @return True if the method call is an Azure client operation, false otherwise
          */
@@ -265,16 +280,17 @@ private static boolean isAzureTextAnalyticsClientOperation(PsiMethodCallExpressi
 
         /**
          * Get the rule configurations from the JSON file.
+         *
          * @return The rule configurations
          * @throws IOException
          */
         private static Map<String, Object> getRuleConfigs() throws IOException {
 
             final String ruleName = "SingleOperationInLoopCheck";
-            final String antiPatternMessageKey = "antipattern_message";
+            final String antiPatternMessageKey = "anti_pattern_message";
             final String methodsToCheckKey = "methods_to_check";
 
-            final JSONObject jsonObject =  LoadJsonConfigFile.getInstance().getJsonObject();
+            final JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();
 
             //get the methods to check
             JSONArray methodsToCheck = jsonObject.getJSONObject(ruleName).getJSONArray(methodsToCheckKey);
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 95dfc0ca0a7..bf069751256 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -14,6 +14,6 @@
 
   "SingleOperationInLoopCheck": {
     "methods_to_check": ["detectLanguageBatch", "recognizeEntitiesBatch", "recognizePiiEntitiesBatch", "recognizeLinkedEntitiesBatch", "extractKeyPhrasesBatch", "analyzeSentimentBatch"],
-    "antipattern_message": "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."
+    "anti_pattern_message": "Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: "
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
index 98d5664c662..0de2aae1aa1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/SingleOperationInLoopCheckTest.java
@@ -36,31 +36,31 @@
  * The SingleOperationInLoopCheck is an inspection to check if there is a single Azure client operation inside a loop.
  * A single Azure client operation is defined as a method call on a class that is part of the Azure SDK.
  * If a single Azure client operation is found inside a loop, a problem will be registered.
- *
+ * <p>
  * THis is an example of a situation where the inspection should register a problem:
- *
+ * <p>
  * 1. With a single PsiDeclarationStatement inside a while loop
  * // While loop
- *         int i = 0;
- *         while (i < 10) {
- *
- *             BlobAsyncClient blobAsyncClient = new BlobClientBuilder()
- *                 .endpoint("https://<your-storage-account-name>.blob.core.windows.net")
- *                 .sasToken("<your-sas-token>")
- *                 .containerName("<your-container-name>")
- *                 .blobName("<your-blob-name>")
- *                 .buildAsyncClient();
- *
- *             i++;
- *         }
- *
+ * int i = 0;
+ * while (i < 10) {
+ * <p>
+ * BlobAsyncClient blobAsyncClient = new BlobClientBuilder()
+ * .endpoint("https://<your-storage-account-name>.blob.core.windows.net")
+ * .sasToken("<your-sas-token>")
+ * .containerName("<your-container-name>")
+ * .blobName("<your-blob-name>")
+ * .buildAsyncClient();
+ * <p>
+ * i++;
+ * }
+ * <p>
  * 2. With a single PsiExpressionStatement inside a for loop
  * for (String documentPath : documentPaths) {
- *
- *             blobAsyncClient.uploadFromFile(documentPath)
- *                 .doOnSuccess(response -> System.out.println("Blob uploaded successfully in enhanced for loop."))
- *                 .subscribe();
- *         }
+ * <p>
+ * blobAsyncClient.uploadFromFile(documentPath)
+ * .doOnSuccess(response -> System.out.println("Blob uploaded successfully in enhanced for loop."))
+ * .subscribe();
+ * }
  */
 public class SingleOperationInLoopCheckTest {
 
@@ -87,8 +87,7 @@ public void testSingleOperationInLoopCheckPsiExpressionStatementInForStatement()
         String packageName = "com.azure.ai.textanalytics";
         int numberOfInvocations = 1;
         String methodName = "detectLanguage";
-        verifyRegisterProblemWithSinglePsiExpressionStatement(statement,
-                packageName, numberOfInvocations, methodName);
+        verifyRegisterProblemWithSinglePsiExpressionStatement(statement, packageName, numberOfInvocations, methodName);
     }
 
     /**
@@ -287,12 +286,9 @@ private void verifyRegisterProblemWithSinglePsiExpressionStatement(PsiStatement
         }
 
         //  Verify problem is registered
-        verify(mockHolder,
-                times(numberOfInvocations)).registerProblem(Mockito.eq(expression),
-                Mockito.contains(
-                        "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
+        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(expression),
+                Mockito.contains("Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: " + methodName + "Batch"));
     }
-
     /**
      * This helper method is used to verify a problem is registered when a
      * PsiDeclarationStatement operation is found in a loop.
@@ -303,7 +299,7 @@ private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement
         PsiBlockStatement loopBody = mock(PsiBlockStatement.class);
         PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
         PsiVariable element = mock(PsiVariable.class);
-        PsiElement[] elements = new PsiElement[] {element};
+        PsiElement[] elements = new PsiElement[]{element};
         PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
         PsiTreeUtil treeUtil = mock(PsiTreeUtil.class);
         PsiClass containingClass = mock(PsiClass.class);
@@ -336,9 +332,7 @@ private void verifyRegisterProblemWithSinglePsiDeclarationStatement(PsiStatement
         }
 
         //  Verify problem is registered
-        verify(mockHolder,
-                times(numberOfInvocations)).registerProblem(Mockito.eq(initializer),
-                Mockito.contains(
-                        "Single operation found in loop. If the SDK provides a batch operation API, use it to perform multiple actions in a single request."));
+        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(initializer),
+                Mockito.contains("Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: " + methodName + "Batch"));
     }
 }
\ No newline at end of file

From f23d2fc1753bd1bb528947f2e27d6b572ecca039 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Sat, 13 Jul 2024 13:51:39 -0700
Subject: [PATCH 083/144] Update .gitignore

---
 PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
index 1043f4e0000..8631128eac3 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/.gitignore
@@ -50,4 +50,3 @@ gen-external-apklibs/
 
 # IntelliJ
 .idea/
-/.idea/
\ No newline at end of file

From a1144752dcf1c5f692a5664038dfb6b4f7cf4836 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 13 Jul 2024 14:38:17 -0700
Subject: [PATCH 084/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md |  6 +--
 .../GetSyncPollerOnPollerFluxCheck.java       | 32 ++++++------
 .../main/resources/META-INF/ruleConfigs.json  |  2 -
 .../GetSyncPollerOnPollerFluxCheckTest.java   | 50 +++++++++----------
 4 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 9ef0c7b2638..77bdc9d8df1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -20,7 +20,7 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Anti-pattern**: Using Azure Storage upload APIs that don’t take a length parameter, causing the entire data payload to be buffered into memory before uploading.
 - **Issue**: This can lead to OutOfMemoryErrors, especially with large files or high-volume uploads.
 - **Severity: INFO**
-- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
+- **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/azure/storage/blobs/storage-blob-upload-java) for additional information.
 
 2. #### Use ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient.
 - **Anti-pattern**: The use of the Reactor receiver, specifically the `ServiceBusReceiverAsyncClient`, is an anti-pattern. This is because it's a low-level API that provides fine-grained control over message handling. While this might seem beneficial, it requires a high level of proficiency in Reactive programming and is mainly useful when building a Reactive library or an end-to-end Reactive application.
@@ -29,9 +29,9 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Recommendation**: Instead of using the low-level `ServiceBusReceiverAsyncClient`, it's recommended to use the `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies message consumption. It's designed for most common use cases and should be the primary choice for consuming messages. This makes it a more suitable option for most developers and scenarios. 
 Please refer to the [Azure SDK for Java documentation](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient) for additional information.
 
-3. #### Use SyncPoller Instead of getSyncPoller() on PollerFlux
+3. #### Use SyncPoller instead of PollerFlux#getSyncPoller()
 - **Anti-pattern**: Using `getSyncPoller()` on a `PollerFlux` instance is an anti-pattern. 
 - **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
-  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
\ No newline at end of file
+  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
index 060aa369821..367a250730e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
@@ -20,21 +20,21 @@
  * Inspection tool to detect the use of getSyncPoller() on a PollerFlux.
  * The inspection will check if the method call is on a PollerFlux and if the method call is on an Azure SDK client.
  * If both conditions are met, the inspection will register a problem with the suggestion to use SyncPoller instead.
- *
+ * <p>
  * This is an example of an anti-pattern that would be detected by the inspection tool.
  * public void exampleUsage() {
- *         PollerFlux<String> pollerFlux = createPollerFlux();
- *
- *         // Anti-pattern: Using getSyncPoller() on PollerFlux
- *         SyncPoller<String, Void> syncPoller = pollerFlux.getSyncPoller();
- *     }
+ * PollerFlux<String> pollerFlux = createPollerFlux();
+ * <p>
+ * // Anti-pattern: Using getSyncPoller() on PollerFlux
+ * SyncPoller<String, Void> syncPoller = pollerFlux.getSyncPoller();
+ * }
  */
 public class GetSyncPollerOnPollerFluxCheck extends LocalInspectionTool {
 
     /**
      * Method to build the visitor for the inspection tool.
+     *
      * @param holder Holder for the problems found by the inspection
-     * @param isOnTheFly Flag to indicate if the inspection is running on the fly
      * @return JavaElementVisitor a visitor to visit the method call expressions
      */
     @NotNull
@@ -47,11 +47,10 @@ public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean i
      * Visitor class to visit the method call expressions and check for the use of getSyncPoller() on a PollerFlux.
      * The visitor will check if the method call is on a PollerFlux and if the method call is on an Azure SDK client.
      */
-    public static class GetSyncPollerOnPollerFluxVisitor extends JavaElementVisitor {
+    static class GetSyncPollerOnPollerFluxVisitor extends JavaElementVisitor {
 
         // Instance variables
         private final ProblemsHolder holder;
-        private final boolean isOnTheFly;
 
         private static String METHOD_TO_CHECK = "";
         private static String ANTI_PATTERN_MESSAGE = "";
@@ -75,16 +74,17 @@ public static class GetSyncPollerOnPollerFluxVisitor extends JavaElementVisitor
 
         /**
          * Constructor to initialize the visitor with the holder and isOnTheFly flag.
-         * @param holder Holder for the problems found by the inspection
-         * @param isOnTheFly Flag to indicate if the inspection is running on the fly
+         *
+         * @param holder     Holder for the problems found by the inspection
+         * @param isOnTheFly Flag to indicate if the inspection is running on the fly -- not used in this inspection
          */
         public GetSyncPollerOnPollerFluxVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
-            this.isOnTheFly = isOnTheFly;
         }
 
         /**
          * Method to visit the method call expressions and check for the use of getSyncPoller() on a PollerFlux.
+         *
          * @param expression Method call expression to visit
          */
         @Override
@@ -140,10 +140,11 @@ private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall)
         /**
          * Helper method to check if the method call is on an Azure SDK client.
          * This method will check if the method call is on a class that is part of the Azure SDK.
+         *
          * @param methodCall Method call expression to check
          * @return true if the method call is on an Azure SDK client, false otherwise
          */
-        private boolean isAzureClient (@NotNull PsiMethodCallExpression methodCall){
+        private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
 
             PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
 
@@ -157,11 +158,12 @@ private boolean isAzureClient (@NotNull PsiMethodCallExpression methodCall){
             if (className != null && className.startsWith("com.azure.")) {
                 return true;
             }
-        return false;
+            return false;
         }
 
         /**
          * Helper method to load the rule configurations from the config file.
+         *
          * @return List of strings containing the method to check and the anti-pattern message
          * @throws IOException if there is an error loading the config file
          */
@@ -182,4 +184,4 @@ private static List<String> getRuleConfigs() throws IOException {
             return List.of(methodToCheck, antiPatternMessage);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index fdaffa67da6..6a72421c4a5 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -6,12 +6,10 @@
     ],
     "antipattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
   },
-
   "ServiceBusReceiverAsyncClientCheck": {
     "client_name": "ServiceBusReceiverAsyncClient",
     "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
   },
-
   "GetSyncPollerOnPollerFluxCheck": {
     "method_to_check": "getSyncPoller",
     "antipattern_message": "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
index 35722c52c88..fa0dbdd5c1d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheckTest.java
@@ -25,14 +25,14 @@
  * Test class for the GetSyncPollerOnPollerFluxCheck inspection tool.
  * The test class will test the visitor's ability to detect the use of getSyncPoller() on a PollerFlux
  * and register a problem with the suggestion message.
- *
+ * <p>
  * This is an example of an anti-pattern that would be detected by the inspection tool.
  * public void exampleUsage() {
- *         PollerFlux<String> pollerFlux = createPollerFlux();
- *
- *         // Anti-pattern: Using getSyncPoller() on PollerFlux
- *         SyncPoller<String, Void> syncPoller = pollerFlux.getSyncPoller();
- *     }
+ * PollerFlux<String> pollerFlux = createPollerFlux();
+ * <p>
+ * // Anti-pattern: Using getSyncPoller() on PollerFlux
+ * SyncPoller<String, Void> syncPoller = pollerFlux.getSyncPoller();
+ * }
  */
 public class GetSyncPollerOnPollerFluxCheckTest {
 
@@ -62,9 +62,9 @@ public void testGetSyncPollerOnPollerFluxCheck() {
         assertVisitor();
 
         String methodName = "getSyncPoller";
-        String packageName = "com.azure.core.util.polling.PollerFlux";
+        String className = "com.azure.core.util.polling.PollerFlux";
         int numberOfInvocations = 1;
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, className, numberOfInvocations);
     }
 
     /**
@@ -75,9 +75,9 @@ public void testGetSyncPollerOnPollerFluxCheck() {
     public void testGetSyncPollerOnPollerFluxCheckWithDifferentMethodName() {
 
         String methodName = "getAnotherMethod";
-        String packageName = "com.azure.core.util.polling.PollerFlux";
+        String className = "com.azure.core.util.polling.PollerFlux";
         int numberOfInvocations = 0;
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, className, numberOfInvocations);
     }
 
     /**
@@ -85,12 +85,12 @@ public void testGetSyncPollerOnPollerFluxCheckWithDifferentMethodName() {
      * The visitor should not register a problem in this case.
      */
     @Test
-    public void testGetSyncPollerOnPollerFluxCheckWithDifferentPackageName() {
+    public void testGetSyncPollerOnPollerFluxCheckWithDifferentClassName() {
 
         String methodName = "getSyncPoller";
-        String packageName = "com.azure.core.util.polling.DifferentPackageName";
+        String className = "com.azure.core.util.polling.DifferentClassName";
         int numberOfInvocations = 0;
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, className, numberOfInvocations);
     }
 
     /**
@@ -98,16 +98,17 @@ public void testGetSyncPollerOnPollerFluxCheckWithDifferentPackageName() {
      * The visitor should not register a problem in this case.
      */
     @Test
-    public void testGetSyncPollerOnPollerFluxCheckWithNullPackageName() {
+    public void testGetSyncPollerOnPollerFluxCheckWithNullClassName() {
 
         String methodName = "getSyncPoller";
-        String packageName = null;
+        String className = null;
         int numberOfInvocations = 0;
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, className, numberOfInvocations);
     }
 
     /**
      * A helper method to create the visitor for the test.
+     *
      * @return JavaElementVisitor
      */
     private JavaElementVisitor createVisitor() {
@@ -127,11 +128,12 @@ private void assertVisitor() {
     /**
      * A helper method to verify if the visitor is able to detect the use of getSyncPoller() on a PollerFlux
      * and register a problem with the suggestion message.
-     * @param methodName The method name to be used in the test
-     * @param packageName The package name to be used in the test
+     *
+     * @param methodName          The method name to be used in the test
+     * @param className           The package name to be used in the test
      * @param numberOfInvocations The number of times registerProblem should be called
      */
-    private void verifyRegisterProblem(String methodName, String packageName, int numberOfInvocations) {
+    private void verifyRegisterProblem(String methodName, String className, int numberOfInvocations) {
 
         PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
         PsiExpression expression = mock(PsiExpression.class);
@@ -143,15 +145,13 @@ private void verifyRegisterProblem(String methodName, String packageName, int nu
         when(referenceExpression.getReferenceName()).thenReturn(methodName);
         when(referenceExpression.getQualifierExpression()).thenReturn(expression);
         when(expression.getType()).thenReturn(type);
-        when(type.getCanonicalText()).thenReturn(packageName);
+        when(type.getCanonicalText()).thenReturn(className);
         when(mockTreeUtil.getParentOfType(mockElement, PsiClass.class)).thenReturn(containingClass);
-        when(containingClass.getQualifiedName()).thenReturn(packageName);
+        when(containingClass.getQualifiedName()).thenReturn(className);
 
         // Act
         mockVisitor.visitMethodCallExpression(mockElement);
 
-        // Verify registerProblem is not called
-        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement),
-                Mockito.contains("Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"));
+        verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"));
     }
-}
\ No newline at end of file
+}

From 46c5f94df04eba7de0e5e45cee279e8f125b345d Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 14 Jul 2024 01:53:24 -0700
Subject: [PATCH 085/144] implement base class to check for discouraged APIs

---
 .../azure-intellij-plugin-azure-sdk/README.md | 38 ++++++---
 ...va => DetectDiscouragedAPIUsageCheck.java} | 48 ++++++-----
 .../azure/sdk/buildtool/RuleConfig.java       | 26 ++++--
 .../azure/sdk/buildtool/RuleConfigLoader.java | 36 +++++++-
 .../azure-intellij-plugin-azure-sdk.xml       |  8 +-
 .../main/resources/META-INF/ruleConfigs.json  | 16 ++--
 ...> DetectDiscouragedAPIUsageCheckTest.java} | 82 +++++++++++--------
 7 files changed, 173 insertions(+), 81 deletions(-)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{ConnectionStringCheck.java => DetectDiscouragedAPIUsageCheck.java} (67%)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{ConnectionStringCheckTest.java => DetectDiscouragedAPIUsageCheckTest.java} (58%)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 6163f5f84bc..2f542b91559 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -97,14 +97,32 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
   for additional information.
 
-6. #### Using Connection Strings to build Azure Service Clients
 
-- **Anti-pattern**: Using Connection Strings for Authenticating Azure SDK Clients.
-- **Issue**: Connection strings authentication is not recommended in Azure SDKs for Java due to potential security
-  vulnerabilities.
-- **Severity: WARNING**
-- **Recommendation**: Azure service client authentication is recommended if the service client supports Token
-  Credential (Entra ID Authentication). If not, then use Azure Key Credential or Connection Strings based
-  authentication. Please refer to
-  the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
-  for additional information.
\ No newline at end of file
+6. #### Use These Encouraged Alternatives Instead of Their Corresponding Discouraged APIs
+
+   #### a. Azure service client authentication instead of Connection Strings to build Azure Service Clients
+
+    - **Anti-pattern**: Using Connection Strings for Authenticating Azure SDK Clients.
+    - **Issue**: Connection strings authentication is not recommended in Azure SDKs for Java due to potential
+      security
+      vulnerabilities.
+    - **Severity: WARNING**
+    - **Recommendation**: Azure service client authentication is recommended if the service client supports Token
+      Credential (Entra ID Authentication). If not, then use Azure Key Credential or Connection Strings based
+      authentication. Please refer to
+      the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
+      for additional information.
+
+   #### b. Use `getChatCompletions` for Chat Applications instead of `getCompletions` API
+
+    - **Anti-pattern**: Using the getCompletions API
+    - **Issue**: Issue: Functionality Mismatch - The `getCompletions` API is designed for general-purpose completion
+      tasks.
+      whereas `getChatCompletions` is specifically optimized for conversational contexts.
+    - **Severity: WARNING**
+    - **Recommendation**: Use `getChatCompletions` for Chat Applications: Specifically use `getChatCompletions` API
+      when
+      generating responses for chatbot or conversational AI applications.
+    - Please refer to
+      the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/overview/azure/ai-openai-readme?view=azure-java-preview)
+      for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
similarity index 67%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
index 48dbc628f76..d87c48163b3 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
@@ -12,12 +12,12 @@
 
 import org.jetbrains.annotations.NotNull;
 
-
+import java.util.Map;
 /**
- * This class extends the LocalInspectionTool to check for the use of connection strings in the code.
+ * This class extends the LocalInspectionTool to check for the use of discouraged APIs in the code.
  * If the method is called from an Azure client class, a problem is registered with the suggestion message.
  */
-public class ConnectionStringCheck extends LocalInspectionTool {
+public class DetectDiscouragedAPIUsageCheck extends LocalInspectionTool {
 
 
     /**
@@ -30,49 +30,47 @@ public class ConnectionStringCheck extends LocalInspectionTool {
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new ConnectionStringVisitor(holder, isOnTheFly);
+        return new DetectDiscouragedAPIUsageVisitor(holder, isOnTheFly);
     }
 
     /**
      * This class extends the JavaElementVisitor to visit the elements in the code.
-     * It checks if the method call is a connection string call and if the class is an Azure client.
+     * It checks if the method call is a discouraged API call and if the class is an Azure client.
      * If both conditions are met, a problem is registered with the suggestion message.
      */
-    static class ConnectionStringVisitor extends JavaElementVisitor {
+    static class DetectDiscouragedAPIUsageVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
 
         // // Define constants for string literals
         private static final RuleConfig ruleConfig;
-        private static final String SUGGESTION;
-        private static final String METHOD_TO_CHECK;
+        private static final Map<String, String> METHODS_TO_CHECK;
         private static boolean SKIP_WHOLE_RULE;
 
         static {
-            final String ruleName = "ConnectionStringCheck";
+            final String ruleName = "DetectDiscouragedAPIUsageCheck";
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
             ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+            METHODS_TO_CHECK = ruleConfig.getDiscouragedIdentifiersMap();
 
-            METHOD_TO_CHECK = ruleConfig.getMethodsToCheck().get(0);
-            SUGGESTION = ruleConfig.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE;
+            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
         }
 
         /**
          * Constructor to initialize the visitor with the holder and isOnTheFly flag.
          *
          * @param holder     ProblemsHolder to register problems
-         * @param isOnTheFly boolean to check if the inspection is on the fly
+         * @param isOnTheFly boolean to check if the inspection is on the fly - This is not in use
          */
-        public ConnectionStringVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        public DetectDiscouragedAPIUsageVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
         }
 
         /**
          * This method visits the element in the code.
-         * It checks if the method call is a connection string call and if the class is an Azure client.
+         * It checks if the method call is a discouraged API call and if the class is an Azure client.
          * If both conditions are met, a problem is registered with the suggestion message.
          *
          * @param element PsiElement to visit
@@ -95,16 +93,28 @@ public void visitElement(@NotNull PsiElement element) {
                 // resolvedMethod is the method that is being called
                 PsiElement resolvedMethod = methodExpression.resolve();
 
-                // check if the method is a connectionString call
-                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod && ((PsiMethod) resolvedMethod).getName().equals(METHOD_TO_CHECK)) {
+                // check if the method is a discouraged API call by accessing the keys of the map stored in the configuration file
+                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod
+                        && METHODS_TO_CHECK.containsKey(((PsiMethod) resolvedMethod).getName())) {
+
                     PsiMethod method = (PsiMethod) resolvedMethod;
 
+                    // containingClass is the client class that is being called. check if the class is an azure
+
                     // containingClass is the client class that is being called. check if the class is an azure client
                     PsiClass containingClass = method.getContainingClass();
 
                     // compare the package name of the containing class to the azure package name from the configuration file
-                    if (containingClass != null && containingClass.getQualifiedName() != null && containingClass.getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME)) {
-                        holder.registerProblem(element, SUGGESTION);
+                    if (containingClass != null && containingClass.getQualifiedName() != null
+                            && containingClass.getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME)) {
+
+                        PsiElement problemElement = methodExpression.getReferenceNameElement();
+
+                        if (problemElement == null) {
+                            return;
+                        }
+                        // give the suggestion of the discouraged method
+                        holder.registerProblem(problemElement, METHODS_TO_CHECK.get(method.getName()));
                     }
                 }
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index b307c558757..79746800a09 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -2,6 +2,7 @@
 
 import java.util.Collections;
 import java.util.List;
+import java.util.Map;
 
 /**
  * This class contains configuration options for code style rules.
@@ -12,22 +13,26 @@ class RuleConfig {
     private final List<String> clientsToCheck;
     private final List<String> servicesToCheck;
     private final String antiPatternMessage;
+    private final Map<String, String> discouragedIdentifiersMap;
+
     static final String AZURE_PACKAGE_NAME = "com.azure";
 
-    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), "");
+    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), Collections.emptyMap(), "");
 
     /**
      * Constructor for RuleConfig.
      *
-     * @param methodsToCheck     List of methods to check.
-     * @param clientsToCheck     List of clients to check.
-     * @param servicesToCheck    List of services to check.
-     * @param antiPatternMessage AntiPattern message.
+     * @param methodsToCheck            List of methods to check.
+     * @param clientsToCheck            List of clients to check.
+     * @param servicesToCheck           List of services to check.
+     * @param discouragedIdentifiersMap Map of discouraged identifiers and their suggestions.
+     * @param antiPatternMessage        AntiPattern message.
      */
-    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, String antiPatternMessage) {
+    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, Map<String, String> discouragedIdentifiersMap, String antiPatternMessage) {
         this.methodsToCheck = methodsToCheck;
         this.clientsToCheck = clientsToCheck;
         this.servicesToCheck = servicesToCheck;
+        this.discouragedIdentifiersMap = discouragedIdentifiersMap;
         this.antiPatternMessage = antiPatternMessage;
     }
 
@@ -68,4 +73,13 @@ public List<String> getServicesToCheck() {
     public String getAntiPatternMessage() {
         return antiPatternMessage;
     }
+
+    /**
+     * This method returns the map of discouraged identifiers
+     *
+     * @return Map of discouraged identifiers
+     */
+    public Map<String, String> getDiscouragedIdentifiersMap() {
+        return discouragedIdentifiersMap;
+    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 9713cb8543c..c47386e8777 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -128,6 +128,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
         List<String> methodsToCheck = new ArrayList<>();
         List<String> clientsToCheck = new ArrayList<>();
         List<String> servicesToCheck = new ArrayList<>();
+        Map<String, String > discouragedIdentifiersToCheck = new HashMap<>();
         String antiPatternMessage = null;
 
         // Check if the JSON file starts with an object
@@ -155,10 +156,15 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
                 default:
-                    reader.skipChildren();
+                    if (fieldName.endsWith("Check")) {
+                        discouragedIdentifiersToCheck = getMapOfDiscouragedIdentifiers(reader, discouragedIdentifiersToCheck);
+                    } else {
+                        reader.skipChildren();
+                    }
+                    break;
             }
         }
-        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, antiPatternMessage);
+        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, discouragedIdentifiersToCheck, antiPatternMessage);
     }
 
     /**
@@ -189,4 +195,30 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
         }
         return list;
     }
+
+    private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Map<String, String> discouragedIdentifiersToCheckMap) throws IOException {
+
+        String identifiersToCheck = null;
+        String antiPatternMessage = null;
+
+        // Read the JSON file and parse the RuleConfig object
+        while (reader.nextToken() != JsonToken.END_OBJECT) {
+
+            // Get the field name
+            String fieldName = reader.getFieldName();
+
+            switch (fieldName) {
+                case "methods_to_check":
+                    identifiersToCheck = getListFromJsonArray(reader).get(0);
+                    break;
+                case "anti_pattern_message":
+                    antiPatternMessage = reader.getString();
+                    break;
+            }
+            if (identifiersToCheck != null && antiPatternMessage != null) {
+                discouragedIdentifiersToCheckMap.put(identifiersToCheck, antiPatternMessage);
+            }
+        }
+        return discouragedIdentifiersToCheckMap;
+    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 22cbdca2442..3bb46c3ca22 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -96,15 +96,15 @@
 
         <localInspection
                 language="JAVA"
-                shortName="ConnectionStringCheck"
-                displayName="Connection String Check"
+                shortName="DetectDiscouragedAPIUsageCheck"
+                displayName="Detect Discouraged API UsageCheck"
                 groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 level="WARNING"
-                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck">
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedAPIUsageCheck">
 
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedAPIUsageCheck
             </class>
         </localInspection>
     </extensions>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 88a6c6b2b4b..4432a942bcb 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -41,9 +41,15 @@
     "anti_pattern_message": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication.",
     "solution": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication."
   },
-  "ConnectionStringCheck": {
-    "methods_to_check": "connectionString",
-    "anti_pattern_message": "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
-    "solution": "DefaultAzureCredential is recommended if the service client supports Token Credential (Entra ID Authentication). if not, then use Azure Key Credential / Connection Strings based authentication"
+  "DetectDiscouragedAPIUsageCheck" : {
+    "ConnectionStringCheck": {
+      "methods_to_check": "connectionString",
+      "anti_pattern_message": "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
+      "solution": "DefaultAzureCredential is recommended if the service client supports Token Credential (Entra ID Authentication). if not, then use Azure Key Credential / Connection Strings based authentication"
+    },
+    "GetCompletionsInChatApplicationsCheck": {
+      "methods_to_check": "getCompletions",
+      "anti_pattern_message": "getCompletions API detected. Use the getChatCompletions API instead."
+    }
   }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheckTest.java
similarity index 58%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheckTest.java
index 30f5884d490..4df2725717f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ConnectionStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheckTest.java
@@ -2,14 +2,17 @@
 
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementVisitor;
 
 import com.intellij.psi.PsiMethod;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
-import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.ConnectionStringCheck.ConnectionStringVisitor;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedAPIUsageCheck.DetectDiscouragedAPIUsageVisitor;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
 import org.mockito.Mock;
 import org.mockito.Mockito;
 
@@ -20,11 +23,19 @@
 
 
 /**
- * This class tests the ConnectionStringCheck class.
+ * This class tests the DetectDiscouragedAPIUsageCheck class.
  * It tests the buildVisitor method and the visitElement method.
- * It tests the check for the usage of connection strings API to create clients in the Azure SDK for Java.
+ * It tests the check for the usage of discouraged APIs in the code.
+ * The test checks for the use of the following discouraged APIs:
+ * 1. connectionString
+ * 2. getCompletions
+ * <p>
+ * This is an example of a problem that would be raised:
+ * 1. ServiceBusSenderClient senderClient2 = new ServiceBusClientBuilder().connectionString(connectionString2).sender().queueName("myQueueName2").buildClient();
+ * * 2. BlobServiceClient blobServiceClient2 = new BlobServiceClientBuilder().connectionString(connectionString2).buildClient();
+ * 3. Completions completions = client.getCompletions(deploymentOrModelId, new CompletionsOptions(prompt));
  */
-public class ConnectionStringCheckTest {
+public class DetectDiscouragedAPIUsageCheckTest {
 
     @Mock
     private ProblemsHolder mockHolder;
@@ -39,98 +50,99 @@ public void setup() {
         mockVisitor = createVisitor();
     }
 
-    /**
-     * This method creates a visitor for the ConnectionStringCheck class.
-     *
-     * @return PsiElementVisitor visitor
-     */
-    private PsiElementVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        ConnectionStringVisitor visitor = new ConnectionStringCheck.ConnectionStringVisitor(mockHolder, isOnTheFly);
-        return visitor;
-    }
-
     /**
      * This test checks the buildVisitor method.
      * It checks if the visitor is created and if it is an instance of JavaElementVisitor.
-     * It also verifies that a warning is raised when a connection string being used to create a client is detected.
-     * <p>
-     * This is an example of a passing test.
-     * 1. ServiceBusSenderClient senderClient2 = new ServiceBusClientBuilder().connectionString(connectionString2).sender().queueName("myQueueName2").buildClient();
-     * 2. BlobServiceClient blobServiceClient2 = new BlobServiceClientBuilder().connectionString(connectionString2).buildClient();
+     * It also verifies that a warning is raised when a discouraged API is detected.
      */
-    @Test
-    public void testConnectionStringCheck() {
+    @ParameterizedTest
+    @CsvSource({"connectionString, Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication)", "getCompletions, getCompletions API detected. Use the getChatCompletions API instead."})
+    public void testDetectDiscouragedAPIUsageCheck(String methodToCheck, String suggestionMessage) {
 
-        String methodToCheck = "connectionString";
         int numOfInvocations = 1;
         String packageName = "com.azure";
 
-        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName, suggestionMessage);
     }
 
     /**
      * Problem isn't registered because the method to check is different
-     * from the method that should be flagged
+     * from the methods that should be flagged
      */
     @Test
     public void differentMethodCheck() {
         String methodToCheck = "differentMethod";
         int numOfInvocations = 0;
         String packageName = "com.azure";
+        String suggestionMessage = "";
 
-        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName, suggestionMessage);
     }
 
     /**
-     * Problem isn't registered because the class name is different
-     * from the class that should be flagged
+     * Problem isn't registered because the package name is different
+     * from the package that should be flagged
      */
     @Test
     public void differentClassCheck() {
         String methodToCheck = "connectionString";
         int numOfInvocations = 0;
         String packageName = "com.microsoft.azure";
+        String suggestionMessage = "";
 
-        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName, suggestionMessage);
     }
 
     /**
-     * Problem isn't registered because the class name is null
+     * Problem isn't registered because the package name is null
      */
     @Test
     public void nullClassCheck() {
-        String methodToCheck = "connectionString";
+        String methodToCheck = "getCompletions";
         int numOfInvocations = 0;
         String packageName = null;
+        String suggestionMessage = "";
+
+        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName, suggestionMessage);
+    }
 
-        verifyRegisterProblem(mockVisitor, methodToCheck, numOfInvocations, packageName);
+    /**
+     * This method creates a visitor for the DetectDiscouragedAPIUsageCheck class.
+     *
+     * @return PsiElementVisitor visitor
+     */
+    private PsiElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        DetectDiscouragedAPIUsageVisitor visitor = new DetectDiscouragedAPIUsageVisitor(mockHolder, isOnTheFly);
+        return visitor;
     }
 
     /**
-     * Verifies that a warning is raised when a connection string being used to create a client is detected.
+     * Verifies that a warning is raised when a discouraged API is detected.
      *
      * @param visitor          PsiElementVisitor visitor to inspect elements in the code
      * @param methodToCheck    String method to check for in the code
      * @param numOfInvocations int number of times registerProblem should be called
      * @param packageName      String package name of the class
      */
-    private void verifyRegisterProblem(PsiElementVisitor visitor, String methodToCheck, int numOfInvocations, String packageName) {
+    private void verifyRegisterProblem(PsiElementVisitor visitor, String methodToCheck, int numOfInvocations, String packageName, String suggestionMessage) {
 
         PsiMethodCallExpression methodCallExpression = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
         PsiMethod resolvedMethod = mock(PsiMethod.class);
         PsiClass containingClass = mock(PsiClass.class);
+        PsiElement problemElement = mock(PsiElement.class);
 
         when(methodCallExpression.getMethodExpression()).thenReturn(methodExpression);
         when(methodExpression.resolve()).thenReturn(resolvedMethod);
         when(resolvedMethod.getContainingClass()).thenReturn(containingClass);
         when(resolvedMethod.getName()).thenReturn(methodToCheck);
         when(containingClass.getQualifiedName()).thenReturn(packageName);
+        when(methodExpression.getReferenceNameElement()).thenReturn(problemElement);
 
         (visitor).visitElement(methodCallExpression);
 
         // Verify problem is registered
-        verify(mockHolder, times(numOfInvocations)).registerProblem(Mockito.eq(methodCallExpression), Mockito.contains("Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication)."));
+        verify(mockHolder, times(numOfInvocations)).registerProblem(Mockito.eq(problemElement), Mockito.contains(suggestionMessage));
     }
 }

From 3e898b7587dc9ef10a51054fc384ee62538a3ada Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 14 Jul 2024 18:27:32 -0700
Subject: [PATCH 086/144] modify to correctly find service APIs

---
 .../buildtool/TelemetryClientProvider.java    | 145 +++++++-----------
 1 file changed, 58 insertions(+), 87 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 2b0bc1034a9..0fe4373f9f7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -6,21 +6,25 @@
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiClass;
 import com.intellij.psi.PsiClassType;
+import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiMethod;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
 import java.io.FileNotFoundException;
 
-import com.intellij.psi.util.PsiUtil;
+import com.intellij.psi.PsiVariable;
 import com.microsoft.applicationinsights.TelemetryClient;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
 import java.io.InputStream;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
+import java.util.Arrays;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
@@ -69,6 +73,10 @@ public static class TelemetryClientProviderVisitor extends JavaElementVisitor {
         // Create a Project object
         private static Project project;
 
+        private static final List<String> AZURE_METHOD_PREFIXES = Arrays.asList(
+                "upsert", "set", "create", "update", "replace", "delete", "add", "get", "list", "upload"
+        );
+
         // Create a logger object
         private static final Logger LOGGER= Logger.getLogger(TelemetryClientProvider.class.getName());
 
@@ -90,21 +98,25 @@ public TelemetryClientProviderVisitor(ProblemsHolder holder, boolean isOnTheFly)
             project = holder.getProject();
         }
 
-        /**  will only track the methods that are being called in the code
-         * This method is called when a method call expression is visited.
-         * @param expression The method call expression that is visited.
-         */
+
         @Override
-        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
-            super.visitMethodCallExpression(expression);
+        public void visitElement(PsiElement element) {
+            super.visitElement(element);
+
+            // Handle method call expressions
+            if (element instanceof PsiMethodCallExpression) {
 
-            PsiReferenceExpression methodExpression = expression.getMethodExpression();
-            String methodName = methodExpression.getReferenceName();
-            String clientName = getClientName(expression); // Method to get client name
+                PsiMethodCallExpression methodCall = (PsiMethodCallExpression) element;
 
-            if (clientName != null) {
+                PsiReferenceExpression methodExpression = methodCall.getMethodExpression();
+                String methodName = methodExpression.getReferenceName();
+                String clientName = getClientName(methodCall); // Method to get client name
 
-                if (methodName == null || !isServiceCall(expression)) {
+                if (clientName == null) {
+                    return;
+                }
+
+                if (methodName == null || !isAzureServiceMethodCall(methodName)) {
                     return;
                 }
                 synchronized (methodCounts) {
@@ -127,97 +139,56 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
         private String getClientName(PsiMethodCallExpression expression) {
             PsiMethod method = expression.resolveMethod();
 
-            if (method != null) {
-
-                // Get the return type of the method
-                PsiType returnType = method.getReturnType();
+            PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
 
-                // Check if the return type is a class type
-                if (returnType != null) {
-                    if (returnType instanceof PsiClassType) {
+            if (!(qualifier instanceof PsiReferenceExpression)) {
+                return null;
+            }
 
-                        // Resolve the class type to get the class
-                        PsiClass psiClass = ((PsiClassType) returnType).resolve();
+            PsiElement resolvedElement = ((PsiReferenceExpression) qualifier).resolve();
 
-                        // Check if the class is an Azure SDK client
-                        if (psiClass != null && isAzureSdkClient(psiClass)) {
+            if (!(resolvedElement instanceof PsiVariable)) {
+                return null;
+            }
 
-                            // Check if the class name ends with "Client"
-                            if (psiClass.getName().endsWith("Client")) {
-                                return psiClass.getName();
-                            }
-                        }
-                    } else {
-                        // Resolve the class type to get the class
-                        PsiClass psiClass = PsiUtil.resolveClassInClassTypeOnly(returnType);
+            PsiVariable variable = (PsiVariable) resolvedElement;
 
-                        // Check if the class is an Azure SDK client
-                        if (psiClass != null && isAzureSdkClient(psiClass)) {
+            PsiType type = variable.getType();
 
-                            // Check if the class name ends with "Client"
-                            if (psiClass.getName().endsWith("Client")) {
-                                return psiClass.getName();
-                            }
-                        }
-                    }
-                }
+            if (!(type instanceof PsiClassType)) {
+                return null;
             }
-            return null;
-        }
+            PsiClassType classType = (PsiClassType) type;
 
-        /**
-         * This method is used to check if the class is an Azure
-         * SDK client by checking if the class name starts with "com.azure.".
-         * @param psiClass The class to be checked.
-         * @return A boolean indicating if the class is an Azure SDK client.
-         */
-        private boolean isAzureSdkClient(PsiClass psiClass) {
-            String className = psiClass.getQualifiedName();
-            return className != null && className.startsWith("com.azure.");
-        }
-
-        /**
-         * This method is used to check if the method call expression is a service call.
-         * It checks if the method is not a builder method or a utility method.
-         * @param expression The method call expression to be checked.
-         * @return A boolean indicating if the method call expression is a service call.
-         */
-        private static boolean isServiceCall(PsiMethodCallExpression expression) {
-            PsiReferenceExpression methodExpression = expression.getMethodExpression();
-            PsiMethod method = (PsiMethod) methodExpression.resolve();
+            PsiClass psiClass = classType.resolve();
 
-            if (method == null) {
-                return false;
+            if (psiClass == null) {
+                return null;
             }
+            String className = psiClass.getQualifiedName();
 
-            return !isBuilderMethod(method) &&
-                    !isUtilityMethod(method);
+            // return the last part of the qualified name as the client name
+            // eg. com.azure.storage.blob.BlobServiceClient -> BlobServiceClient
+            // without string manipulation
+            if (isAzureSdkClient(className)) {
+                return classType.getPresentableText();
+                }
+            return null;
         }
 
-        /**
-         * This method is used to check if the method is a builder method.
-         * It checks if the method name contains "build", "create", or "new".
-         * @param method The method to be checked.
-         * @return A boolean indicating if the method is a builder method.
-         */
-        private static boolean isBuilderMethod(PsiMethod method) {
-            String methodName = method.getName().toLowerCase();
-            return methodName.contains("build") || methodName.contains("create") ||
-                    methodName.contains("new");
-        }
 
-        /**
-         * This method is used to check if the method is a utility method.
-         * It checks if the method name contains "initialize", "setup", "utility", or "helper".
-         * @param method The method to be checked.
-         * @return A boolean indicating if the method is a utility method.
-         */
-        private static boolean isUtilityMethod(PsiMethod method) {
-            String methodName = method.getName().toLowerCase();
-            return methodName.contains("initialize") || methodName.contains("setup") ||
-                    methodName.contains("utility") || methodName.contains("helper");
+        private boolean isAzureSdkClient(String className) {
+            return className != null && className.startsWith("com.azure.") && className.endsWith("Client");
         }
 
+        private boolean isAzureServiceMethodCall(String methodName) {
+            for (String prefix : AZURE_METHOD_PREFIXES) {
+                if (methodName.startsWith(prefix)) {
+                    return true;
+                }
+            }
+            return false;
+        }
 
         /**
          * This method starts the telemetry service.

From 1cf1fd77a0e850754dec886a3ae254458f0cd41c Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 14 Jul 2024 22:14:01 -0700
Subject: [PATCH 087/144] address PR comments

---
 ...iesWithTimeIntervalInQueryStringCheck.java | 121 +++++++-----------
 .../main/resources/META-INF/ruleConfigs.json  |  10 +-
 ...ithTimeIntervalInQueryStringCheckTest.java |  94 ++++----------
 3 files changed, 75 insertions(+), 150 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index a6a2559b8ef..0eec3ea542e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -5,18 +5,25 @@
 import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.JavaPsiFacade;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiClassType;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementFactory;
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiExpressionList;
 import com.intellij.psi.PsiLiteralExpression;
 import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiMethod;
+import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiPolyadicExpression;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiTypeElement;
 import com.intellij.psi.PsiVariable;
 import com.intellij.psi.impl.source.tree.java.PsiMethodCallExpressionImpl;
 
+import com.intellij.psi.util.PsiTreeUtil;
+import com.intellij.psi.util.PsiUtil;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
 
@@ -62,7 +69,7 @@ public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean i
      * Processing of polyadic expressions is also done to replace the variables with their values in the query string
      * before checking for the anti-patterns.
      */
-    class KustoQueriesVisitor extends JavaElementVisitor {
+    static class KustoQueriesVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
         private final boolean isOnTheFly; // boolean to indicate if the inspection is done on the fly
@@ -156,10 +163,8 @@ private void handleLocalVariable(PsiLocalVariable variable) {
          * @param polyadicExpression
          */
         private void handlePolyadicExpression(PsiPolyadicExpression polyadicExpression) {
-
             // Process the polyadic expression to replace the variables with their values
-            PsiElement processedElement = processPsiPolyadicExpressions(polyadicExpression.copy());
-            PsiExpression initializer = processedElement instanceof PsiPolyadicExpression ? (PsiPolyadicExpression) processedElement : null;
+            PsiExpression initializer = polyadicExpression instanceof PsiPolyadicExpression ? polyadicExpression : null;
             checkExpression(initializer, polyadicExpression);
         }
 
@@ -188,13 +193,19 @@ private void handleMethodCall(PsiMethodCallExpressionImpl methodCall) {
                 }
                 PsiVariable variable = (PsiVariable) resolvedElement;
                 String variableName = variable.getName();
-
-                // check if the variable name is in the list of time interval parameters
+                     // check if the variable name is in the list of time interval parameters
                 // if the variable name is in the list, check if the method call is an Azure client method call
                 if (!(timeIntervalParameters.contains(variableName))) {
                     continue;
                 }
-                if (isAzureClient(methodCall)) {
+
+                // case methodcall to PsiMethodCallExpression
+                PsiMethodCallExpression methodCallExpression = methodCall;
+
+                System.out.println("methodCallExpression: " + methodCallExpression);
+//                System.out.println("methodCall: " + methodCall.getMethodExpression().getText());
+                if (isAzureClient(methodCallExpression)) {
+                    System.out.println("Registering problem for method call: " + methodCall);
                     holder.registerProblem(methodCall, "KQL queries with time intervals in the query string detected.");
                 }
             }
@@ -217,71 +228,25 @@ void checkExpression(PsiExpression expression, PsiElement element) {
             boolean foundAntiPattern = regexPatterns.values().stream()
                     .anyMatch(pattern -> pattern.matcher(text).find());
 
+
             // If an anti-pattern is detected, register a problem
             if (foundAntiPattern) {
 
-                PsiElement parentElement = element.getParent();
-                PsiLocalVariable variable = (PsiLocalVariable) parentElement;
-                String variableName = variable.getName();
-
-                timeIntervalParameters.add(variableName);
-            }
-        }
-
-        /**
-         * This method processes the polyadic expressions to replace the variables with their values
-         *
-         * @param element
-         * @return PsiElement
-         */
-        public PsiElement processPsiPolyadicExpressions(PsiElement element) {
-
-            // Extract the operands from the polyadic expression
-            PsiPolyadicExpression expression = (PsiPolyadicExpression) element;
+                System.out.println("Found anti-pattern in expression: " + text);
+                System.out.println("Element: " + element);
+                System.out.println("ElementText: " + element.getText());
 
-            PsiExpression[] operands = expression.getOperands();
-
-            // Iterate through the operands
-            for (int i = 0; i < operands.length; i++) {
-                PsiExpression operand = operands[i];
-
-                // PsiReferenceExpressions are used to represent references to variables
-                if (!(operand instanceof PsiReferenceExpression)) {
-                    continue;
-                }
-                PsiReferenceExpression reference = (PsiReferenceExpression) operand;
-
-                PsiElement resolved = reference.resolve();
-
-                if (!(resolved instanceof PsiVariable)) {
-                    continue;
-                }
-                // Extract the value of the variable
-                // Resolve means to find the declaration of the variable
-                // Initializer is the value assigned to the variable
-                PsiVariable variable = (PsiVariable) resolved;
+                PsiElement parentElement = element.getParent();
 
-                PsiExpression initializer = variable.getInitializer();
+                System.out.println("Parent element: " + parentElement);
 
-                if (initializer == null) {
-                    continue;
-                }
-                // Initializer.getText() returns the value of the variable in string format
-                // Create a new expression from the variable value and replace the variable with the value
-                String variableValue = initializer.getText();
-
-                PsiElementFactory factory = JavaPsiFacade.getInstance(element.getProject()).getElementFactory();
-                PsiExpression newExpression = factory.createExpressionFromText(variableValue, null);
-                if (newExpression != null) {
-                    operands[i] = newExpression;
+                if (parentElement instanceof PsiLocalVariable) {
+                    PsiLocalVariable variable = (PsiLocalVariable) parentElement;
+                    String variableName = variable.getName();
+                    timeIntervalParameters.add(variableName);
+                    System.out.println("Time interval parameters2: " + timeIntervalParameters);
                 }
             }
-            // Create a new expression from the operands after replacing the variables with their values
-            // Return the new expression if it is not null, else return the original element
-            PsiElementFactory factory = JavaPsiFacade.getInstance(element.getProject()).getElementFactory();
-            String newExpressionText = StringUtil.join(operands, PsiElement::getText, "+");
-            PsiExpression newExpression = factory.createExpressionFromText(newExpressionText, null);
-            return newExpression != null ? newExpression : element;
         }
 
 
@@ -292,27 +257,29 @@ public PsiElement processPsiPolyadicExpressions(PsiElement element) {
          * @param methodCall
          * @return boolean
          */
-        private boolean isAzureClient(PsiMethodCallExpressionImpl methodCall) {
+        private boolean isAzureClient(PsiMethodCallExpression methodCall) {
 
-            // Get the qualifier expression of the method call
-            PsiExpression qualifierExpression = methodCall.getMethodExpression().getQualifierExpression();
+            PsiReferenceExpression methodExpression = methodCall.getMethodExpression();
+            System.out.println("Method expression: " + methodExpression);
 
-            // If the qualifier expression is a reference expression, resolve the reference
-            if (qualifierExpression instanceof PsiReferenceExpression) {
-                PsiReferenceExpression referenceExpression = (PsiReferenceExpression) qualifierExpression;
-                PsiElement resolvedElement = referenceExpression.resolve();
+            PsiExpression qualifierExpression = methodExpression.getQualifierExpression();
+            System.out.println("Qualifier expression: " + qualifierExpression);
 
-                // If the resolved element is a variable, check if the type of the variable is an Azure client type
-                if (resolvedElement instanceof PsiVariable) {
-                    PsiVariable variable = (PsiVariable) resolvedElement;
-                    PsiType variableType = variable.getType();
+            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
+            System.out.println("Containing class: " + containingClass);
 
-                    return variableType.getCanonicalText().startsWith("com.azure");
-                }
+            if (containingClass != null) {
+                String className = containingClass.getQualifiedName();
+                System.out.println("Class name: " + className);
+                // Check if the class name belongs to the com.azure namespace or any specific Azure SDK namespace
+                return className != null && className.startsWith("com.azure");
             }
+
             return false;
         }
 
+
+
         /**
          * This method loads the regex patterns from the configuration file and compiles them
          * The method reads the JSON configuration file and extracts the regex patterns
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d9c138f8236..f5c7847283c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -13,11 +13,11 @@
   },
   "KustoQueriesWithTimeIntervalInQueryStringCheck": {
     "regex_patterns": {
-      "KQL_ANTI_PATTERN_AGO": "\"?ago\\(\"?\\+?\"?\\d+[smhdw]\"?\\+?\"?\\)?\"?",
-      "KQL_ANTI_PATTERN_DATETIME": ".*datetime\\s*\\(\\s*[\"\\+\\s]*\\d{4}-\\d{2}-\\d{2}(?:T\\d{2}:\\d{2}:\\d{2}Z)?[\"\\+\\s]*\\s*\\)",
-      "KQL_ANTI_PATTERN_NOW": "now\\(\\)",
-      "KQL_ANTI_PATTERN_START_OF_PERIOD": "startofday\\(\\)|startofmonth\\(\\)|startofyear\\(\\)",
-      "KQL_ANTI_PATTERN_BETWEEN": ".*between\\\\(datetime\\\\(\\\\d{4}-\\\\d{2}-\\\\d{2}\\\\), datetime\\\\(\\\\d{4}-\\\\d{2}-\\\\d{2}\\\\)\\\\)\n"
+      "KQL_ANTI_PATTERN_AGO": ".*ago\\(",
+      "KQL_ANTI_PATTERN_DATETIME": ".*datetime\\s*\\(",
+      "KQL_ANTI_PATTERN_NOW": ".*now\\(",
+      "KQL_ANTI_PATTERN_START_OF_PERIOD": ".*startofday\\(\\)|.*startofmonth\\(\\)|.*startofyear\\(\\)",
+      "KQL_ANTI_PATTERN_BETWEEN": ".*between\\(datetime\\("
     },
     "antipattern_message": "KQL queries with time intervals in the query string detected.",
     "solution": "Use the QueryTimeInterval parameter in the client method parameters to specify the time interval for the query"
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
index 53d7c8595ac..67542eb7e88 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -1,8 +1,10 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+import com.intellij.psi.PsiClass;
 import com.intellij.psi.PsiExpressionList;
 import com.intellij.psi.PsiLiteralExpression;
 import com.intellij.psi.PsiType;
 import com.intellij.psi.impl.source.tree.java.PsiMethodCallExpressionImpl;
+import com.intellij.psi.util.PsiTreeUtil;
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor;
 
 // Import necessary libraries
@@ -20,6 +22,8 @@
 import com.intellij.psi.PsiVariable;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.Mock;
 
 import static org.junit.Assert.assertEquals;
@@ -54,7 +58,6 @@
  *
  *     String result = blobAsyncClient.query(kqlQueryOne);
  */
-
 public class KustoQueriesWithTimeIntervalInQueryStringCheckTest {
 
     // Declare as instance variables
@@ -77,17 +80,17 @@ public void setup() {
      * The method then checks if a problem is registered when a local variable or a polyadic expression is used in a query string
      * and if the method call is to an Azure client.
      */
-    @Test
-    public void testKustoQueriesWithTimeIntervalInQueryStringCheck() {
+    @ParameterizedTest
+    @ValueSource(strings = {"datetime(startDate)", "filter.datetime(2022-01-01)", "time.now()", "time.startofday()", "time.startofmonth()", "range.between(datetime(2022-01-01), datetime(2022-02-01)"})
+    public void testKustoQueriesWithTimeIntervalInQueryStringCheck(String queryString) {
 
-        // assert visitor
-        assertVisitor(mockVisitor);
+        String packageName = "com.azure";
 
         // verify register problem with local variable as the query string
-        verifyRegisterProblemWithLocalVariable();
+        verifyRegisterProblemWithLocalVariable(queryString, packageName);
 
         // verify register problem with polyadic expression as the query string
-        verifyRegisterProblemWithPolyadicExpression();
+        verifyRegisterProblemWithPolyadicExpression(queryString, packageName);
     }
 
     /**
@@ -102,34 +105,6 @@ public void testCheckExpressionWithNullExpression() {
         ((KustoQueriesVisitor) mockVisitor).checkExpression(nullExpression, mockElement);
     }
 
-    /**
-     * This test checks the checkExpression method with no operands,
-     * which may be due to a PolyadicExpressions that was not formed correctly
-     */
-    @Test
-    public void testProcessPsiPolyadicExpressionsWithNoOperands() {
-
-        // Arrange
-        Project mockProject = mock(Project.class);
-        PsiExpression mockNewExpression = mock(PsiExpression.class);
-        PsiPolyadicExpression mockExpression = mock(PsiPolyadicExpression.class);
-        PsiElementFactory mockPsiElementFactory = mock(PsiElementFactory.class);
-        JavaPsiFacade mockJavaPsiFacade = mock(JavaPsiFacade.class);
-
-        when(mockExpression.getOperands()).thenReturn(new PsiExpression[]{});
-        when(mockExpression.getProject()).thenReturn(mockProject);
-        when(mockJavaPsiFacade.getInstance(mockProject)).thenReturn(mockJavaPsiFacade);
-        when(mockJavaPsiFacade.getElementFactory()).thenReturn(mockPsiElementFactory);
-        when(mockPsiElementFactory.createExpressionFromText(eq("datetime(2d)"), isNull())).thenReturn(mockNewExpression);
-
-        // Act
-        PsiElement result = ((KustoQueriesVisitor) mockVisitor).processPsiPolyadicExpressions(mockExpression);
-
-        // Assert
-        // In this case, we expect that the result is the same as the original expression,
-        // because the expression has no operands and therefore nothing was replaced
-        assertEquals(mockExpression, result);
-    }
 
     /**
      * Create a visitor by calling the buildVisitor method of KustoQueriesWithTimeIntervalInQueryStringCheck
@@ -141,24 +116,16 @@ PsiElementVisitor createVisitor() {
         return visitor;
     }
 
-    /**
-     * Assert that the visitor is not null and is an instance of JavaElementVisitor
-     * @param visitor
-     */
-    void assertVisitor(PsiElementVisitor visitor) {
-        assertNotNull(visitor);
-        assertTrue(visitor instanceof JavaElementVisitor);
-    }
-
 
     /**
      * This method tests the registerProblem method with a local variable as the query string
      */
-    void verifyRegisterProblemWithLocalVariable() {
+    void verifyRegisterProblemWithLocalVariable(String queryString, String packageName) {
 
         PsiLocalVariable variable = mock(PsiLocalVariable.class);
         PsiLiteralExpression initializer = mock(PsiLiteralExpression.class);
         PsiLocalVariable parentElement = mock(PsiLocalVariable.class);
+        PsiClass containingClass = mock(PsiClass.class);
 
         PsiMethodCallExpressionImpl methodCall = mock(PsiMethodCallExpressionImpl.class);
         PsiExpressionList argumentList = mock(PsiExpressionList.class);
@@ -176,7 +143,7 @@ void verifyRegisterProblemWithLocalVariable() {
         when(variable.getName()).thenReturn("stringQuery");
 
         // stubs for checkExpression method
-        when(initializer.getText()).thenReturn("datetime(2022-01-01)");
+        when(initializer.getText()).thenReturn(queryString);
         when(variable.getParent()).thenReturn(parentElement);
         when(parentElement.getName()).thenReturn("stringQuery");
 
@@ -189,9 +156,8 @@ void verifyRegisterProblemWithLocalVariable() {
         // stubs for isAzureClient method
         when(methodCall.getMethodExpression()).thenReturn(referenceExpression);
         when(referenceExpression.getQualifierExpression()).thenReturn(qualifierExpression);
-        when(qualifierExpression.resolve()).thenReturn(resolvedVariable);
-        when(resolvedVariable.getType()).thenReturn(type);
-        when(type.getCanonicalText()).thenReturn("com.azure");
+        when(PsiTreeUtil.getParentOfType(methodCall, PsiClass.class)).thenReturn(containingClass);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
 
         // Visit the variable to store its name if it's a query string
         mockVisitor.visitElement(variable);
@@ -203,11 +169,11 @@ void verifyRegisterProblemWithLocalVariable() {
         verify(mockHolder, times(1)).registerProblem(eq(methodCall), contains("KQL queries with time intervals in the query string detected."));
     }
 
-    void verifyRegisterProblemWithPolyadicExpression() {
+    void verifyRegisterProblemWithPolyadicExpression(String queryString, String packageName) {
 
         PsiPolyadicExpression polyadicExpression = mock(PsiPolyadicExpression.class);
         PsiReferenceExpression operand = mock(PsiReferenceExpression.class);
-        PsiExpression[] operands = new PsiExpression[]{operand};
+//        PsiExpression[] operands = new PsiExpression[]{operand};
         PsiVariable resolvedVariable = mock(PsiVariable.class);
         PsiExpression initializer = mock(PsiExpression.class);
         PsiElementFactory elementFactory = mock(PsiElementFactory.class);
@@ -215,24 +181,14 @@ void verifyRegisterProblemWithPolyadicExpression() {
         JavaPsiFacade javaPsiFacade = mock(JavaPsiFacade.class);
         PsiExpression newExpression = mock(PsiExpression.class);
         PsiLocalVariable parentElement = mock(PsiLocalVariable.class);
+        PsiClass containingClass = mock(PsiClass.class);
 
         // stubs for handlePolyadicExpression method
-        when(polyadicExpression.copy()).thenReturn(polyadicExpression);
-        when(polyadicExpression.getText()).thenReturn("datetime(2022-01-01)");
-
-        // stubs for processPsiPolyadicExpressions method
-        when(polyadicExpression.getOperands()).thenReturn(operands);
-        when(operand.resolve()).thenReturn(resolvedVariable);
-        when(resolvedVariable.getInitializer()).thenReturn(initializer);
-        when(initializer.getText()).thenReturn("datetime(2022-01-01)");
-
-        when(polyadicExpression.getProject()).thenReturn(project);
-        when(JavaPsiFacade.getInstance(polyadicExpression.getProject())).thenReturn(javaPsiFacade);
-        when(javaPsiFacade.getElementFactory()).thenReturn(elementFactory);
-        when(elementFactory.createExpressionFromText(eq(initializer.getText()), isNull())).thenReturn(newExpression);
+//        when(polyadicExpression.copy()).thenReturn(polyadicExpression);
+        when(polyadicExpression.getText()).thenReturn(queryString);
 
         // stubs for checkExpression method
-        when(initializer.getText()).thenReturn("datetime(2022-01-01)");
+        when(initializer.getText()).thenReturn(queryString);
         when(polyadicExpression.getParent()).thenReturn(parentElement);
         when(parentElement.getName()).thenReturn("stringQuery");
 
@@ -254,14 +210,16 @@ void verifyRegisterProblemWithPolyadicExpression() {
         // stubs for isAzureClient method
         when(methodCall.getMethodExpression()).thenReturn(referenceExpression);
         when(referenceExpression.getQualifierExpression()).thenReturn(qualifierExpression);
-        when(qualifierExpression.resolve()).thenReturn(resolvedVariable);
-        when(resolvedVariable.getType()).thenReturn(type);
-        when(type.getCanonicalText()).thenReturn("com.azure");
+        when(PsiTreeUtil.getParentOfType(methodCall, PsiClass.class)).thenReturn(containingClass);
+        when(containingClass.getQualifiedName()).thenReturn(packageName);
 
         // Visit the variable to store its name if it's a query string
         mockVisitor.visitElement(polyadicExpression);
 
         // Visit the method call to check if the query variable is used and the method call is to an Azure client
         mockVisitor.visitElement(methodCall);
+
+        // Verify that the problem was registered correctly for the method call
+        verify(mockHolder, times(1)).registerProblem(eq(methodCall), contains("KQL queries with time intervals in the query string detected."));
     }
 }
\ No newline at end of file

From 6c05ea4cbd16e8de9f39d9a209e9ee8f5ca40b0e Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 14 Jul 2024 23:19:59 -0700
Subject: [PATCH 088/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md         | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 312d5fabc40..ec469febbb3 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -110,8 +110,13 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   for additional information.
 
 7. #### Kusto Queries Having a Time Interval in the Query String
+
 - **Anti-pattern**: Writing KQL queries with hard-coded time intervals directly in the query string.
 - **Issue**: This approach makes queries less flexible and harder to troubleshoot.
-  -**Recommendation**: Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the time interval for the query.
-  By passing the time range as an argument in the method call, you make it easier to troubleshoot and understand the context of an API call.
-  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable) for additional information.
\ No newline at end of file
+  -**Recommendation**: Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the
+  time interval for the query.
+  By passing the time range as an argument in the method call, you make it easier to troubleshoot and understand the
+  context of an API call.
+  Please refer to
+  the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable)
+  for additional information.
\ No newline at end of file

From 32307d71724adcd7e4d3e9f0bf75cdc702e35c79 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 15 Jul 2024 11:50:02 -0700
Subject: [PATCH 089/144] integrate toggle telemetry UI

---
 .../buildtool/TelemetryClientProvider.java    | 103 ++++++++++++------
 .../sdk/buildtool/TelemetryToggleAction.java  |  65 +++++++++++
 .../META-INF/applicationInsights.json         |   2 +-
 .../azure-intellij-plugin-azure-sdk.xml       |  21 +++-
 .../TelemetryClientProviderTest.java          |  40 ++++---
 5 files changed, 179 insertions(+), 52 deletions(-)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index 0fe4373f9f7..3506bae5101 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -9,16 +9,17 @@
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiExpression;
-import com.intellij.psi.PsiMethod;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
+
 import java.io.FileNotFoundException;
 
 import com.intellij.psi.PsiVariable;
 import com.microsoft.applicationinsights.TelemetryClient;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONObject;
+
 import java.io.InputStream;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
@@ -42,9 +43,10 @@ public class TelemetryClientProvider extends LocalInspectionTool {
 
     /**
      * This method is called by the IntelliJ platform to build a visitor for the inspection.
-     * @param holder The ProblemsHolder object that holds the problems found in the code.
+     *
+     * @param holder     The ProblemsHolder object that holds the problems found in the code.
      * @param isOnTheFly A boolean that indicates if the inspection is running on the fly.
-     * @return
+     * @return A PsiElementVisitor object that visits the method calls in the code.
      */
     @NotNull
     @Override
@@ -52,7 +54,12 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
 
         // Reset the methodCounts map for each new visitor
         TelemetryClientProviderVisitor.methodCounts.clear();
-        return new TelemetryClientProviderVisitor(holder, isOnTheFly);
+        TelemetryClientProviderVisitor visitor = new TelemetryClientProviderVisitor(holder, isOnTheFly);
+
+        // Set the visitor instance in TelemetryToggleAction
+        TelemetryToggleAction.setTelemetryService(visitor);
+
+        return visitor;
     }
 
     /**
@@ -61,7 +68,8 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
     public static class TelemetryClientProviderVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
-        private final boolean isOnTheFly;
+        private static boolean running = false; // Flag to indicate if the telemetry service is running
+        private static ScheduledExecutorService executorService; // Executor service to schedule telemetry data sending
 
         // Create a TelemetryClient object
         // not final because the test involves Injecting the mock telemetry client to telemetryClient
@@ -73,22 +81,21 @@ public static class TelemetryClientProviderVisitor extends JavaElementVisitor {
         // Create a Project object
         private static Project project;
 
-        private static final List<String> AZURE_METHOD_PREFIXES = Arrays.asList(
-                "upsert", "set", "create", "update", "replace", "delete", "add", "get", "list", "upload"
-        );
+        private static final List<String> AZURE_METHOD_PREFIXES = Arrays.asList("upsert", "set", "create", "update", "replace", "delete", "add", "get", "list", "upload");
 
         // Create a logger object
-        private static final Logger LOGGER= Logger.getLogger(TelemetryClientProvider.class.getName());
+        private static final Logger LOGGER = Logger.getLogger(TelemetryClientProvider.class.getName());
 
 
-        /** This constructor is used to create a visitor for the inspection
+        /**
+         * This constructor is used to create a visitor for the inspection
          * It initializes the holder and isOnTheFly fields.
-         * @param holder The ProblemsHolder object that holds the problems found in the code.
-         * @param isOnTheFly A boolean that indicates if the inspection is running on the fly.
+         *
+         * @param holder     The ProblemsHolder object that holds the problems found in the code.
+         * @param isOnTheFly A boolean that indicates if the inspection is running on the fly. - This is not used in this implementation.
          */
         public TelemetryClientProviderVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
-            this.isOnTheFly = isOnTheFly;
 
             // Initialize start telemetry service when project is null
             // This is to ensure that the telemetry service is started only once
@@ -98,7 +105,12 @@ public TelemetryClientProviderVisitor(ProblemsHolder holder, boolean isOnTheFly)
             project = holder.getProject();
         }
 
-
+        /**
+         * This method is called by the IntelliJ platform to visit the elements in the code.
+         * It visits the method calls in the code and tracks the method calls.
+         *
+         * @param element The element to be visited.
+         */
         @Override
         public void visitElement(PsiElement element) {
             super.visitElement(element);
@@ -119,12 +131,11 @@ public void visitElement(PsiElement element) {
                 if (methodName == null || !isAzureServiceMethodCall(methodName)) {
                     return;
                 }
+
                 synchronized (methodCounts) {
 
                     // Increment the count of the method call for the client
-                    methodCounts
-                            .computeIfAbsent(clientName, k -> new HashMap<>())
-                            .put(methodName, methodCounts.get(clientName).getOrDefault(methodName, 0) + 1);
+                    methodCounts.computeIfAbsent(clientName, k -> new HashMap<>()).put(methodName, methodCounts.get(clientName).getOrDefault(methodName, 0) + 1);
                 }
             }
         }
@@ -132,12 +143,12 @@ public void visitElement(PsiElement element) {
 
         /**
          * This method is used to get the client name from the method call expression.
-         * It resolves the method and extracts the return type to get the client name.
+         * It extracts the client name from the method call expression.
+         *
          * @param expression The method call expression from which the client name is extracted.
          * @return The client name extracted from the method call expression.
          */
         private String getClientName(PsiMethodCallExpression expression) {
-            PsiMethod method = expression.resolveMethod();
 
             PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
 
@@ -152,7 +163,6 @@ private String getClientName(PsiMethodCallExpression expression) {
             }
 
             PsiVariable variable = (PsiVariable) resolvedElement;
-
             PsiType type = variable.getType();
 
             if (!(type instanceof PsiClassType)) {
@@ -172,15 +182,29 @@ private String getClientName(PsiMethodCallExpression expression) {
             // without string manipulation
             if (isAzureSdkClient(className)) {
                 return classType.getPresentableText();
-                }
+            }
             return null;
         }
 
 
+        /**
+         * This method checks if the class name is an Azure SDK client.
+         * It checks if the class name starts with "com.azure." and ends with "Client".
+         *
+         * @param className The class name to be checked.
+         * @return A boolean indicating if the class name is an Azure SDK client.
+         */
         private boolean isAzureSdkClient(String className) {
             return className != null && className.startsWith("com.azure.") && className.endsWith("Client");
         }
 
+        /**
+         * This method checks if the method call is an Azure service method call.
+         * It checks if the method name starts with any of the prefixes in the AZURE_METHOD_PREFIXES list.
+         *
+         * @param methodName The method name to be checked.
+         * @return A boolean indicating if the method call is an Azure service method call.
+         */
         private boolean isAzureServiceMethodCall(String methodName) {
             for (String prefix : AZURE_METHOD_PREFIXES) {
                 if (methodName.startsWith(prefix)) {
@@ -196,10 +220,30 @@ private boolean isAzureServiceMethodCall(String methodName) {
          * schedules the telemetry data to be sent every 2 minutes.
          */
         static void startTelemetryService() {
-            ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
 
-            executorService.scheduleAtFixedRate(() ->
-                    TelemetryClientProviderVisitor.sendTelemetryData(), 2, 3, TimeUnit.MINUTES);
+            if (!running) {
+                running = true;
+                executorService = Executors.newSingleThreadScheduledExecutor();
+
+                executorService.scheduleAtFixedRate(() -> TelemetryClientProviderVisitor.sendTelemetryData(), 2, 3, TimeUnit.MINUTES);
+            }
+        }
+
+        /**
+         * This method stops the telemetry service.
+         * It shuts down the executor service.
+         */
+        static void stopTelemetryService() {
+            if (running) {
+                running = false;
+                if (executorService != null) {
+                    executorService.shutdown();
+                }
+            }
+        }
+
+        public static boolean isRunning() {
+            return running;
         }
 
         /**
@@ -251,11 +295,9 @@ static TelemetryClient getTelemetryClient() {
             StringBuilder jsonBuilder = new StringBuilder();
 
             // Read the instrumentation key from the applicationInsights.json file
-            try (InputStream inputStream = TelemetryClient.class.getClassLoader().getResourceAsStream(configFilePath);
-                 BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream))) {
+            try (InputStream inputStream = TelemetryClient.class.getClassLoader().getResourceAsStream(configFilePath); BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream))) {
                 if (inputStream == null) {
-                    LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + configFilePath
-                            + ". Please ensure the file exists and is accessible.", new FileNotFoundException());
+                    LOGGER.log(Level.SEVERE, "Configuration file not found at path: " + configFilePath + ". Please ensure the file exists and is accessible.", new FileNotFoundException());
                     return telemetry; // Return the telemetry client even if the config file is not found
                 }
 
@@ -271,10 +313,9 @@ static TelemetryClient getTelemetryClient() {
                 telemetry.getContext().setInstrumentationKey(instrumentationKey);
 
             } catch (Exception e) {
-                LOGGER.log(Level.SEVERE, "Unexpected error while loading instrumentation key"
-                        + ". Please investigate further.", e);
+                LOGGER.log(Level.SEVERE, "Unexpected error while loading instrumentation key" + ". Please investigate further.", e);
             }
             return telemetry;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java
new file mode 100644
index 00000000000..f13925e8059
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java
@@ -0,0 +1,65 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.openapi.actionSystem.AnAction;
+import com.intellij.openapi.actionSystem.Presentation;
+import com.intellij.openapi.project.DumbAware;
+
+import com.intellij.openapi.actionSystem.AnActionEvent;
+import com.intellij.openapi.project.Project;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryClientProvider.TelemetryClientProviderVisitor;
+
+/**
+ * This class is responsible for toggling the telemetry service on and off.
+ */
+public class TelemetryToggleAction extends AnAction implements DumbAware {
+
+    // This is the telemetry service that will be toggled on and off.
+    private static TelemetryClientProviderVisitor telemetryService;
+
+    // This method sets the telemetry service
+    public static void setTelemetryService(TelemetryClientProviderVisitor service) {
+        telemetryService = service;
+    }
+
+    /**
+     * This method is called when the action is performed.
+     * It toggles the telemetry service on and off.
+     */
+    @Override
+    public void actionPerformed(AnActionEvent e) {
+        Project project = e.getProject();
+        if (project == null || telemetryService == null) {
+            return;
+        }
+
+        // If the telemetry service is running, stop it. Otherwise, start it.
+        if (telemetryService.isRunning()) {
+            telemetryService.stopTelemetryService();
+        } else {
+            telemetryService.startTelemetryService();
+        }
+        // Update the presentation of the action.
+        updatePresentation(e.getPresentation());
+    }
+
+    /**
+     * This method updates the presentation of the action.
+     * It sets the text of the action to "Toggle Telemetry ON" if the telemetry service is not running.
+     * Otherwise, it sets the text of the action to "Toggle Telemetry OFF".
+     */
+    private void updatePresentation(Presentation presentation) {
+        if (telemetryService != null && telemetryService.isRunning()) {
+            presentation.setText("Toggle Telemetry OFF");
+        } else {
+            presentation.setText("Toggle Telemetry ON");
+        }
+    }
+
+    /**
+     * This method updates the action event.
+     */
+    @Override
+    public void update(AnActionEvent e) {
+        updatePresentation(e.getPresentation());
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
index cc7152279b8..8b4494b2b87 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
@@ -1,3 +1,3 @@
 {
-  "instrumentationKey":"your-instrumentation-key-goes-here"
+  "instrumentationKey":"add8c402-bfc7-447e-a1e5-c7739f5d0a02"
 }
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 9a0133ebd5f..de3788c23a8 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -4,12 +4,21 @@
     <depends>com.intellij.modules.java</depends>
 
     <actions>
-            <action
-                    class="com.microsoft.azure.toolkit.intellij.azure.sdk.experiment.ExperimentalFeature"
-                    id="AzSdkHelpAction"
-                    text="Ask Azure SDK Help">
-                <add-to-group group-id="ToolsMenu" anchor="last" />
-            </action>
+        <action
+                class="com.microsoft.azure.toolkit.intellij.azure.sdk.experiment.ExperimentalFeature"
+                id="AzSdkHelpAction"
+                text="Ask Azure SDK Help">
+            <add-to-group group-id="ToolsMenu" anchor="last"/>
+        </action>
+
+        <action class="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryToggleAction"
+                id="TelemetryToggleAction"
+                text="Enable Telemetry"
+                description="Toggle Telemetry">
+            <add-to-group group-id="ProblemsView.ToolWindow.Toolbar" anchor="first"/>
+            <keyboard-shortcut keymap="$default" first-keystroke="ctrl shift T"/>
+        </action>
+
     </actions>
 
     <extensions defaultExtensionNs="com.intellij">
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
index d284684e234..f8f67d568ee 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
@@ -2,9 +2,11 @@
 
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiClassType;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
-import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiVariable;
 import com.microsoft.applicationinsights.TelemetryClient;
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryClientProvider.TelemetryClientProviderVisitor;
 import org.junit.jupiter.api.BeforeEach;
@@ -53,26 +55,32 @@ public void setUp() {
     @Test
     public void testVisitMethodCallExpressionWithAzurePackage() {
 
-        String packageName = "com.azure.management";
+        String packageName = "com.azure.testClient";
         String className = "testClient";
-        String methodName = "testMethod";
+        String methodName = "upsertMethod";
         int numCountIncrease = 1;
 
         // Mock necessary objects
         PsiMethodCallExpression mockExpression = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression mockMethodExpression = mock(PsiReferenceExpression.class);
-        PsiType mockType = mock(PsiType.class);
+        PsiReferenceExpression mockQualifier = mock(PsiReferenceExpression.class);
+        PsiVariable mockElement = mock(PsiVariable.class);
+        PsiClassType mockType = mock(PsiClassType.class);
+        PsiClass mockClass = mock(PsiClass.class);
+
 
         // Mock method name and client name
         when(mockExpression.getMethodExpression()).thenReturn(mockMethodExpression);
         when(mockMethodExpression.getReferenceName()).thenReturn(methodName);
-        when(mockMethodExpression.getQualifierExpression()).thenReturn(mockExpression);
-        when(mockExpression.getType()).thenReturn(mockType);
-        when(mockType.getCanonicalText()).thenReturn(packageName);
+        when(mockMethodExpression.getQualifierExpression()).thenReturn(mockQualifier);
+        when(mockQualifier.resolve()).thenReturn(mockElement);
+        when(mockElement.getType()).thenReturn(mockType);
+        when(mockType.resolve()).thenReturn(mockClass);
+        when(mockClass.getQualifiedName()).thenReturn(packageName);
         when(mockType.getPresentableText()).thenReturn(className);
 
         // Build the visitor and visit the method call expression
-        mockVisitor.visitMethodCallExpression(mockExpression);
+        mockVisitor.visitElement(mockExpression);
 
         // Verify the method count increment
         assertTrue(TelemetryClientProviderVisitor.methodCounts.containsKey(className));
@@ -94,19 +102,24 @@ public void testVisitMethodCallExpressionWithNonAzurePackage() {
         String className = null;
         String methodName = null;
 
-        // Mock necessary objects
         PsiMethodCallExpression mockExpression = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression mockMethodExpression = mock(PsiReferenceExpression.class);
-        PsiType mockType = mock(PsiType.class);
+        PsiReferenceExpression mockQualifier = mock(PsiReferenceExpression.class);
+        PsiVariable mockElement = mock(PsiVariable.class);
+        PsiClassType mockType = mock(PsiClassType.class);
+        PsiClass mockClass = mock(PsiClass.class);
 
         // Mock method name and client name
         when(mockExpression.getMethodExpression()).thenReturn(mockMethodExpression);
         when(mockMethodExpression.getReferenceName()).thenReturn(methodName);
-        when(mockMethodExpression.getQualifierExpression()).thenReturn(mockExpression);
-        when(mockExpression.getType()).thenReturn(mockType);
-        when(mockType.getCanonicalText()).thenReturn(packageName);
+        when(mockMethodExpression.getQualifierExpression()).thenReturn(mockQualifier);
+        when(mockQualifier.resolve()).thenReturn(mockElement);
+        when(mockElement.getType()).thenReturn(mockType);
+        when(mockType.resolve()).thenReturn(mockClass);
+        when(mockClass.getQualifiedName()).thenReturn(packageName);
         when(mockType.getPresentableText()).thenReturn(className);
 
+
         // Build the visitor and visit the method call expression
         mockVisitor.visitMethodCallExpression(mockExpression);
 
@@ -133,7 +146,6 @@ public void testSendTelemetryData() {
         TelemetryClientProviderVisitor.sendTelemetryData();
 
         // Verify that trackMetric and trackEvent were called
-        verify(mockTelemetryClient, times(1)).trackMetric(eq("azure_sdk_usage_frequency"), eq(1.0));
         verify(mockTelemetryClient, times(1)).trackEvent(eq("azure_sdk_usage_frequency"), anyMap(), anyMap());
         verify(mockTelemetryClient, times(1)).flush();
     }

From 66eb550679fe413686efec534efbdbc6a437b515 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Tue, 16 Jul 2024 08:29:52 -0700
Subject: [PATCH 090/144] Update to comment on
 GetSyncPollerOnPollerFluxCheck.java

---
 .../azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
index 97a9756feb8..0de7bb2f616 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
@@ -118,7 +118,6 @@ private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall)
 
             PsiExpression expression = methodCall.getMethodExpression().getQualifierExpression();
 
-            // Check if the method call is on a reactive type
             if (expression == null) {
                 return false;
             }

From 7e5066a7ebe8958c0a0109ae2558c60504dbb179 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 16 Jul 2024 12:19:55 -0700
Subject: [PATCH 091/144] address PR comments

---
 .../buildtool/ServiceBusReceiveModeCheck.java | 29 ++++++++++---------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
index 863ca5b7f55..2f9a30e1fdd 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -29,6 +29,7 @@ public class ServiceBusReceiveModeCheck extends LocalInspectionTool {
      * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
      *
      * @param holder The holder for the problems found
+     * @param isOnTheFly Whether the inspection is on the fly -- not in use
      * @return The visitor for the inspection. This is not used anywhere else in the code.
      */
     @NotNull
@@ -47,14 +48,14 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
     static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
 
         // Define the holder for the problems found
-        private static ProblemsHolder holder;
+        private final ProblemsHolder holder;
 
         // Define constants for string literals
-        private static final RuleConfig ruleConfig;
+        private static final RuleConfig RULE_CONFIG;
         private static final String SUGGESTION;
         private static final List<String> METHODS_TO_CHECK;
         private static final List<String> CLIENTS_TO_CHECK;
-        private static boolean SKIP_WHOLE_RULE;
+        private static final boolean SKIP_WHOLE_RULE;
 
         private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiveModeCheck.class.getName());
 
@@ -63,18 +64,20 @@ static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            METHODS_TO_CHECK = RULE_CONFIG.getMethodsToCheck();
+            CLIENTS_TO_CHECK = RULE_CONFIG.getClientsToCheck();
+            SUGGESTION = RULE_CONFIG.getAntiPatternMessage();
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
+
 
-            METHODS_TO_CHECK = ruleConfig.getMethodsToCheck();
-            CLIENTS_TO_CHECK = ruleConfig.getClientsToCheck();
-            SUGGESTION = ruleConfig.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
         }
 
         /**
          * Constructor for the visitor
          *
          * @param holder The holder for the problems found
+         * @param isOnTheFly Whether the inspection is on the fly -- not in use
          */
         public ServiceBusReceiveModeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
@@ -165,13 +168,13 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
                 String methodName = methodExpression.getReferenceName();
 
                 // Check if the method name is the method to check
-                // "receiveMode is the first method to check"
-
-                if (METHODS_TO_CHECK.get(0).equals(methodName)) {
+                if (!(METHODS_TO_CHECK.contains(methodName))) {
+                    return;
+                }
+                if ("receiveMode".equals(methodName)) {
                     isReceiveModePeekLock = receiveModePeekLockCheck((PsiMethodCallExpression) qualifier);
                 }
-                // "prefetchCount is the second method to check"
-                else if (METHODS_TO_CHECK.get(1).equals(methodName)) {
+                else if ("prefetchCount".equals(methodName)) {
                     prefetchCountValue = getPrefetchCount((PsiMethodCallExpression) qualifier);
                     prefetchCountMethod = ((PsiMethodCallExpression) qualifier).getMethodExpression().getReferenceNameElement();
                 }

From c71b40ac88e31a8657e716272e4dd4c9774a1af2 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 16 Jul 2024 14:25:07 -0700
Subject: [PATCH 092/144] address PR comments

---
 .../{CONTRIBUTING.MD => configure-telemetry.md}              | 0
 .../azure/sdk/buildtool/TelemetryClientProvider.java         | 5 ++++-
 .../intellij/azure/sdk/buildtool/TelemetryToggleAction.java  | 2 ++
 .../src/main/resources/META-INF/applicationInsights.json     | 2 +-
 4 files changed, 7 insertions(+), 2 deletions(-)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/{CONTRIBUTING.MD => configure-telemetry.md} (100%)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/configure-telemetry.md
similarity index 100%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/CONTRIBUTING.MD
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/configure-telemetry.md
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index ba4bf7eb017..c4ec9b8b265 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -81,6 +81,8 @@ static class TelemetryClientProviderVisitor extends JavaElementVisitor {
         // Create a Project object
         private static Project project;
 
+        // Create a list of prefixes for Azure service method calls
+        // source: https://azure.github.io/azure-sdk/java_introduction.html#service-methods
         private static final List<String> AZURE_METHOD_PREFIXES = Arrays.asList("upsert", "set", "create", "update", "replace", "delete", "add", "get", "list", "upload");
 
         // Create a logger object
@@ -96,6 +98,7 @@ static class TelemetryClientProviderVisitor extends JavaElementVisitor {
 
             // Get the RuleConfig object for the rule
             // There is no rule associated with this inspection, so the ruleConfig is set to an empty RuleConfig object
+            // to access RuleConfig.AZURE_PACKAGE_NAME
             ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
         }
 
@@ -106,7 +109,7 @@ static class TelemetryClientProviderVisitor extends JavaElementVisitor {
          * @param holder     The ProblemsHolder object that holds the problems found in the code.
          * @param isOnTheFly A boolean that indicates if the inspection is running on the fly. - This is not used in this implementation.
          */
-        public TelemetryClientProviderVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        TelemetryClientProviderVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
 
             // Initialize start telemetry service when project is null
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java
index f13925e8059..efe98efcbae 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryToggleAction.java
@@ -44,6 +44,8 @@ public void actionPerformed(AnActionEvent e) {
 
     /**
      * This method updates the presentation of the action.
+     * "Presentation of the action" means the UI representation of the action
+     *  It ensures the UI is updated to reflect the current state of the telemetry service.
      * It sets the text of the action to "Toggle Telemetry ON" if the telemetry service is not running.
      * Otherwise, it sets the text of the action to "Toggle Telemetry OFF".
      */
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
index 8b4494b2b87..0cbfbda4b9d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
@@ -1,3 +1,3 @@
 {
-  "instrumentationKey":"add8c402-bfc7-447e-a1e5-c7739f5d0a02"
+  "instrumentationKey":"<instrumentationKey>",
 }
\ No newline at end of file

From f8003745a887fb76307ad27a7aa61ecd2f1dcc8a Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 16 Jul 2024 15:22:37 -0700
Subject: [PATCH 093/144] address PR comments

---
 .../azure/sdk/buildtool/RuleConfig.java       | 20 +++++++++-----
 .../buildtool/ServiceBusReceiveModeCheck.java | 26 ++++++-------------
 2 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index b307c558757..fcf89d25195 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -24,21 +24,29 @@ class RuleConfig {
      * @param servicesToCheck    List of services to check.
      * @param antiPatternMessage AntiPattern message.
      */
-    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, String antiPatternMessage) {
+    RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, String antiPatternMessage) {
         this.methodsToCheck = methodsToCheck;
         this.clientsToCheck = clientsToCheck;
         this.servicesToCheck = servicesToCheck;
         this.antiPatternMessage = antiPatternMessage;
     }
 
-    // Getters
+    /**
+     * This method checks if the rule should be skipped.
+     *
+     * @return True if the rule should be skipped, false otherwise.
+     */
+    boolean skipRuleCheck() {
+        return this == RuleConfig.EMPTY_RULE;
+    }
 
+    // Getters
     /**
      * This method returns the list of methods to check
      *
      * @return List of methods to check
      */
-    public List<String> getMethodsToCheck() {
+    List<String> getMethodsToCheck() {
         return methodsToCheck;
     }
 
@@ -47,7 +55,7 @@ public List<String> getMethodsToCheck() {
      *
      * @return List of clients to check
      */
-    public List<String> getClientsToCheck() {
+    List<String> getClientsToCheck() {
         return clientsToCheck;
     }
 
@@ -56,7 +64,7 @@ public List<String> getClientsToCheck() {
      *
      * @return List of services to check
      */
-    public List<String> getServicesToCheck() {
+    List<String> getServicesToCheck() {
         return servicesToCheck;
     }
 
@@ -65,7 +73,7 @@ public List<String> getServicesToCheck() {
      *
      * @return Antipattern message
      */
-    public String getAntiPatternMessage() {
+    String getAntiPatternMessage() {
         return antiPatternMessage;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
index 2f9a30e1fdd..4779e9516b6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -13,7 +13,6 @@
 import com.intellij.psi.PsiVariable;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.List;
 import java.util.OptionalInt;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -28,7 +27,7 @@ public class ServiceBusReceiveModeCheck extends LocalInspectionTool {
     /**
      * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
      *
-     * @param holder The holder for the problems found
+     * @param holder     The holder for the problems found
      * @param isOnTheFly Whether the inspection is on the fly -- not in use
      * @return The visitor for the inspection. This is not used anywhere else in the code.
      */
@@ -52,9 +51,6 @@ static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
 
         // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
-        private static final String SUGGESTION;
-        private static final List<String> METHODS_TO_CHECK;
-        private static final List<String> CLIENTS_TO_CHECK;
         private static final boolean SKIP_WHOLE_RULE;
 
         private static final Logger LOGGER = Logger.getLogger(ServiceBusReceiveModeCheck.class.getName());
@@ -65,21 +61,16 @@ static class ServiceBusReceiveModeVisitor extends JavaElementVisitor {
 
             // Get the RuleConfig object for the rule
             RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
-            METHODS_TO_CHECK = RULE_CONFIG.getMethodsToCheck();
-            CLIENTS_TO_CHECK = RULE_CONFIG.getClientsToCheck();
-            SUGGESTION = RULE_CONFIG.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
-
-
+            SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getMethodsToCheck().isEmpty();
         }
 
         /**
          * Constructor for the visitor
          *
-         * @param holder The holder for the problems found
+         * @param holder     The holder for the problems found
          * @param isOnTheFly Whether the inspection is on the fly -- not in use
          */
-        public ServiceBusReceiveModeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        ServiceBusReceiveModeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
         }
 
@@ -125,7 +116,7 @@ private void processVariableDeclaration(PsiVariable variable) {
             PsiType clientType = variable.getType();
 
             // Check if the client type is an Azure ServiceBus client
-            if (!clientType.getCanonicalText().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && !CLIENTS_TO_CHECK.contains(clientType.getCanonicalText())) {
+            if (!clientType.getCanonicalText().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && !RULE_CONFIG.getClientsToCheck().contains(clientType.getCanonicalText())) {
                 return;
             }
 
@@ -168,13 +159,12 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
                 String methodName = methodExpression.getReferenceName();
 
                 // Check if the method name is the method to check
-                if (!(METHODS_TO_CHECK.contains(methodName))) {
+                if (!(RULE_CONFIG.getMethodsToCheck().contains(methodName))) {
                     return;
                 }
                 if ("receiveMode".equals(methodName)) {
                     isReceiveModePeekLock = receiveModePeekLockCheck((PsiMethodCallExpression) qualifier);
-                }
-                else if ("prefetchCount".equals(methodName)) {
+                } else if ("prefetchCount".equals(methodName)) {
                     prefetchCountValue = getPrefetchCount((PsiMethodCallExpression) qualifier);
                     prefetchCountMethod = ((PsiMethodCallExpression) qualifier).getMethodExpression().getReferenceNameElement();
                 }
@@ -184,7 +174,7 @@ else if ("prefetchCount".equals(methodName)) {
 
                 // If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1, register a problem
                 if (prefetchCountValue.isPresent() && prefetchCountValue.getAsInt() > 1 && isReceiveModePeekLock && prefetchCountMethod != null) {
-                    holder.registerProblem(prefetchCountMethod, SUGGESTION);
+                    holder.registerProblem(prefetchCountMethod, RULE_CONFIG.getAntiPatternMessage());
                     return;
                 }
             }

From 0d79413c387c0a93b2f4d9784b9532098cf0ab68 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 16 Jul 2024 17:08:12 -0700
Subject: [PATCH 094/144] address PR comments

---
 .../buildtool/TelemetryClientProvider.java    | 27 +++++++------------
 .../TelemetryClientProviderTest.java          | 20 +++++++++++---
 2 files changed, 27 insertions(+), 20 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
index c4ec9b8b265..90a0223af94 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProvider.java
@@ -81,27 +81,15 @@ static class TelemetryClientProviderVisitor extends JavaElementVisitor {
         // Create a Project object
         private static Project project;
 
-        // Create a list of prefixes for Azure service method calls
-        // source: https://azure.github.io/azure-sdk/java_introduction.html#service-methods
-        private static final List<String> AZURE_METHOD_PREFIXES = Arrays.asList("upsert", "set", "create", "update", "replace", "delete", "add", "get", "list", "upload");
+        // Create a list of prefixes for Azure service method calls -- Source in the link below
+        /**
+         * <a href="https://azure.github.io/azure-sdk/java_introduction.html#service-methods">Azure SDK Java Service Methods</a>
+         */
+        static final List<String> AZURE_METHOD_PREFIXES = Arrays.asList("upsert", "set", "create", "update", "replace", "delete", "add", "get", "list", "upload");
 
         // Create a logger object
         private static final Logger LOGGER = Logger.getLogger(TelemetryClientProvider.class.getName());
 
-        // Create a RuleConfig object
-        private static final RuleConfig ruleConfig;
-
-
-        static {
-            final String ruleName = "TelemetryClientProvider";
-            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
-
-            // Get the RuleConfig object for the rule
-            // There is no rule associated with this inspection, so the ruleConfig is set to an empty RuleConfig object
-            // to access RuleConfig.AZURE_PACKAGE_NAME
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-        }
-
         /**
          * This constructor is used to create a visitor for the inspection
          * It initializes the holder and isOnTheFly fields.
@@ -254,6 +242,11 @@ static void stopTelemetryService() {
             }
         }
 
+        /**
+         * This method checks if the telemetry service is running.
+         *
+         * @return A boolean indicating if the telemetry service is running.
+         */
         public static boolean isRunning() {
             return running;
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
index f8f67d568ee..78333c046a4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/TelemetryClientProviderTest.java
@@ -9,6 +9,7 @@
 import com.intellij.psi.PsiVariable;
 import com.microsoft.applicationinsights.TelemetryClient;
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.TelemetryClientProvider.TelemetryClientProviderVisitor;
+import org.junit.Assert;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
@@ -82,10 +83,23 @@ public void testVisitMethodCallExpressionWithAzurePackage() {
         // Build the visitor and visit the method call expression
         mockVisitor.visitElement(mockExpression);
 
-        // Verify the method count increment
+        // Assert method name starts with one of the prefixes
+        boolean startsWithPrefix = false;
+        for (String prefix : TelemetryClientProviderVisitor.AZURE_METHOD_PREFIXES) {
+            if (methodName.startsWith(prefix)) {
+                startsWithPrefix = true;
+                break;
+            }
+        }
+        assertTrue(startsWithPrefix);
+
+        // Assert class name ends with "Client"
+        assertTrue(className.endsWith("Client"));
+
+
         assertTrue(TelemetryClientProviderVisitor.methodCounts.containsKey(className));
 
-        // have this assertion if the client is an azure client
+        // Verify the method count increment
         if (numCountIncrease > 0) {
             assertEquals(numCountIncrease, TelemetryClientProviderVisitor.methodCounts.get(className).get(methodName).intValue());
         }
@@ -136,7 +150,7 @@ public void testVisitMethodCallExpressionWithNonAzurePackage() {
     public void testSendTelemetryData() {
         // Populate methodCounts with test data
         Map<String, Integer> methodMap = new HashMap<>();
-        methodMap.put("testMethod", 1);
+        methodMap.put("upsertMethod", 1);
         TelemetryClientProviderVisitor.methodCounts.put("testClient", methodMap);
 
         // Inject the mock telemetry client

From 24049016bf5da8c5259fc8e18b2bc9705e0f9e7f Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 16 Jul 2024 20:52:24 -0700
Subject: [PATCH 095/144] initial implementation of UpdateCheckpointAsyncCheck
 with tests

---
 .../buildtool/UpdateCheckpointAsyncCheck.java | 151 ++++++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  14 ++
 .../main/resources/META-INF/ruleConfigs.json  |   4 +
 .../UpdateCheckpointAsyncCheckTest.java       | 126 +++++++++++++++
 4 files changed, 295 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
new file mode 100644
index 00000000000..27f31779a31
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
@@ -0,0 +1,151 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.JavaRecursiveElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiClassType;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiLambdaExpression;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiParameter;
+import com.intellij.psi.PsiParameterList;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.util.PsiUtil;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.List;
+
+public class UpdateCheckpointAsyncCheck extends LocalInspectionTool {
+
+    /**
+     * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
+     *
+     * @param holder The holder for the problems found
+     * @return The visitor for the inspection. This is not used anywhere else in the code.
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new UpdateCheckpointAsyncCheck.UpdateCheckpointAsyncVisitor(holder, isOnTheFly);
+    }
+
+
+    /**
+     * This class extends the JavaElementVisitor and is used to visit the Java elements in the code.
+     * It checks for the usage of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients and
+     * whether the auto-complete feature is disabled.
+     * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+     */
+    static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
+
+        // Define the holder for the problems found
+        private final ProblemsHolder holder;
+
+        /**
+         * Constructor for the visitor
+         *
+         * @param holder     The holder for the problems found
+         * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use
+         */
+        public UpdateCheckpointAsyncVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+        }
+
+
+        @Override
+        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+            super.visitMethodCallExpression(expression);
+
+            if ("updateCheckpointAsync".equals(expression.getMethodExpression().getReferenceName())) {
+                String followingMethod = getFollowingMethodName(expression);
+                System.out.println("Following method: " + followingMethod);
+
+                if (followingMethod == null) {   // flag for not using block()
+                    System.out.println("Antipattern detected: updateCheckpointAsync() used without block() or block(timeout) or subscribe(): " + expression.getText());
+                    if (isCalledOnEventBatchContext(expression)) {
+                        System.out.println("updateCheckpointAsync() is called on an EventBatchContext object from the Azure SDK: " + expression.getText());
+                        // Add your custom logic here
+                        holder.registerProblem(expression, "The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint()");
+                    }
+                } else if ("subscribe".equals(followingMethod)) {  // if WITH subscribe -- FLAG for using subscribe & for not using block()
+                    System.out.println("Antipattern detected: updateCheckpointAsync() used with subscribe(): ");
+                    if (isCalledOnEventBatchContext(expression)) {
+                        System.out.println("updateCheckpointAsync() is called on an EventBatchContext object from the Azure SDK: " + expression.getText());
+                        // Add your custom logic here
+                        holder.registerProblem(expression, "Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint().");
+                    }
+                }
+            }
+        }
+
+        private String getFollowingMethodName(PsiMethodCallExpression expression) {
+
+//            System.out.println("Expression: " + expression.getText());
+
+            PsiElement parent = expression.getParent();
+            System.out.println("Parent: " + parent);
+//            System.out.println("Parent getText: " + parent.getText());
+
+            if (parent instanceof PsiReferenceExpression) {
+                PsiElement grandParent = parent.getParent();
+                System.out.println("Grandparent: " + grandParent);
+//                System.out.println("Grandparent getText: " + grandParent.getText());
+                if (grandParent instanceof PsiMethodCallExpression) {
+                    System.out.println("Grandparent is PsiMethodCallExpression");
+                    System.out.println("Grandparent method: " + ((PsiMethodCallExpression) grandParent).getMethodExpression().getReferenceName());
+                    PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
+//                    System.out.println("Grandparent call: " + parentCall.getText());
+
+                    String methodName = parentCall.getMethodExpression().getReferenceName();
+                    System.out.println("Grandparent method name: " + methodName);
+                    if ("block".equals(methodName) || "subscribe".equals(methodName)) {
+                        return methodName;
+                    }
+                }
+            }
+            return null;
+        }
+
+        private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression) {
+            System.out.println("Checking if updateCheckpointAsync() is called on an EventBatchContext object: " + expression.getText());
+
+            PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
+            System.out.println("Qualifier: " + qualifier);
+
+            if (qualifier instanceof PsiReferenceExpression) {
+                PsiElement resolvedElement = ((PsiReferenceExpression) qualifier).resolve();
+                System.out.println("Resolved element: " + resolvedElement);
+
+                if (resolvedElement instanceof PsiParameter) {
+                    PsiParameter parameter = (PsiParameter) resolvedElement;
+                    System.out.println("Parameter: " + parameter);
+
+                    PsiType parameterType = parameter.getType();
+                    System.out.println("Parameter type: " + parameterType);
+
+                    if ("EventBatchContext".equals(parameterType.getPresentableText())) {
+                        if (parameterType instanceof PsiClassType) {
+                            System.out.println("Parameter type is PsiClassType");
+                            PsiClassType classType = (PsiClassType) parameterType;
+                            System.out.println("Class type: " + classType);
+                            PsiClass psiClass = classType.resolve();
+                            System.out.println("PsiClass: " + psiClass);
+
+                            if (psiClass != null) {
+                                String qualifiedName = psiClass.getQualifiedName();
+                                System.out.println("Qualified name: " + qualifiedName);
+
+                                return qualifiedName != null && qualifiedName.startsWith("com.azure");
+                            }
+                        }
+                    }
+                }
+            } return false;
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 09b87f7d4e6..b1baf3d3ff5 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -121,5 +121,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.GetSyncPollerOnPollerFluxCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="UpdateCheckpointAsyncCheck"
+                displayName="Update Checkpoint Async Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index ad6d2a16555..765d8e667d4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -49,5 +49,9 @@
   "GetSyncPollerOnPollerFluxCheck": {
     "methods_to_check": "getSyncPoller",
     "anti_pattern_message": "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"
+  },
+  "UpdateCheckpointAsyncCheck" : {
+    "methods_to_check": ["updateCheckpointAsync", "block", "block(timeout)", "subscribe"]
+
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
new file mode 100644
index 00000000000..8fa452633cb
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
@@ -0,0 +1,126 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiClassType;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiParameter;
+import com.intellij.psi.PsiReferenceExpression;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncCheck.UpdateCheckpointAsyncVisitor;
+
+import static org.mockito.ArgumentMatchers.contains;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class UpdateCheckpointAsyncCheckTest {
+
+    // Create a mock ProblemsHolder to be used in the test
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    // Create a mock JavaElementVisitor for visiting the PsiMethodCallExpression
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    // Create a mock PsiMethodCallExpression.
+    @Mock
+    private PsiMethodCallExpression mockMethodCallExpression;
+
+
+    @BeforeEach
+    public void setUp() {
+        // Set up the test
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockMethodCallExpression = mock(PsiMethodCallExpression.class);
+    }
+
+    @Test
+    public void testWithSubscribe() {
+        String packageName = "com.azure";
+        String followingMethod = "subscribe";
+        int numOfInvocations = 1;
+        String mainMethodFound = "updateCheckpointAsync";
+        String objectType = "EventBatchContext";
+
+        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+    }
+
+    @Test
+    public void testWithBlock() {
+        String packageName = "com.azure";
+        String followingMethod = "block";
+        int numOfInvocations = 0;
+        String mainMethodFound = "updateCheckpointAsync";
+        String objectType = "EventBatchContext";
+
+        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+    }
+
+    @Test
+    public void testWithNullFollowingMethod() {
+        String packageName = "com.azure";
+        String followingMethod = null;
+        int numOfInvocations = 1;
+        String mainMethodFound = "updateCheckpointAsync";
+        String objectType = "EventBatchContext";
+
+        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+    }
+
+
+    private JavaElementVisitor createVisitor() {
+        UpdateCheckpointAsyncVisitor mockVisitor = new UpdateCheckpointAsyncVisitor(mockHolder, true);
+        return mockVisitor;
+    }
+
+
+    private void verifyProblemRegistered(String packageName, String mainMethodFound, int numOfInvocations, String followingMethod, String objectType) {
+
+        PsiReferenceExpression mockReferenceExpression = mock(PsiReferenceExpression.class);
+
+        // getFollowingMethodName mocking
+        PsiReferenceExpression parentReferenceExpression = mock(PsiReferenceExpression.class);
+        PsiMethodCallExpression grandParentMethodCalLExpression = mock(PsiMethodCallExpression.class);
+
+        // isCalledOnEventBatchContext
+        PsiReferenceExpression mockQualifier = mock(PsiReferenceExpression.class);
+        PsiParameter mockParameter = mock(PsiParameter.class);
+        PsiClassType parameterType = mock(PsiClassType.class);
+        PsiClass psiClass = mock(PsiClass.class);
+
+        when(mockMethodCallExpression.getMethodExpression()).thenReturn(mockReferenceExpression);
+        when(mockReferenceExpression.getReferenceName()).thenReturn(mainMethodFound);
+
+        // getFollowingMethodName mocking
+        when(mockMethodCallExpression.getParent()).thenReturn(mockReferenceExpression);
+        when(mockReferenceExpression.getParent()).thenReturn(grandParentMethodCalLExpression);
+        when(grandParentMethodCalLExpression.getMethodExpression()).thenReturn(parentReferenceExpression);
+        when(parentReferenceExpression.getReferenceName()).thenReturn(followingMethod);
+
+        // isCalledOnEventBatchContext
+        when(mockReferenceExpression.getQualifierExpression()).thenReturn(mockQualifier);
+        when(mockQualifier.resolve()).thenReturn(mockParameter);
+        when(mockParameter.getType()).thenReturn(parameterType);
+        when(parameterType.getPresentableText()).thenReturn(objectType);
+        when(parameterType.resolve()).thenReturn(psiClass);
+        when(psiClass.getQualifiedName()).thenReturn(packageName);
+
+        mockVisitor.visitMethodCallExpression(mockMethodCallExpression);
+
+        if (followingMethod != null && followingMethod.equals("subscribe")) {
+            verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint()."));
+        }
+        else {
+            verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint()"));
+        }
+    }
+}

From 824c19eef46427986a86ef7fc04039c05f6b6db5 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 16 Jul 2024 21:48:13 -0700
Subject: [PATCH 096/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md | 18 ++++++++++-----
 .../DetectDiscouragedAPIUsageCheck.java       | 22 ++++++++-----------
 2 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 4e496c58314..ee1b44a6d55 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -100,10 +100,15 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 6. #### Use SyncPoller instead of PollerFlux#getSyncPoller()
 
 - **Anti-pattern**: Using `getSyncPoller()` on a `PollerFlux` instance is an anti-pattern.
-- **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
+- **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an
+  asynchronous polling mechanism to a synchronous one, which should be avoided.
 - **Severity: WARNING**
-- **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
-  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
+- **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle
+  synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred
+  method for synchronous operations.
+  Please refer to
+  the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable)
+  for additional information.
 
 7. #### Managing Receive Mode and Prefetch Value in Azure Service Bus
 
@@ -114,7 +119,8 @@ integration, telemetry connectivity, and Azure Toolkit integration.
     1. **Suboptimal Performance:** A high prefetch value in PEEK_LOCK mode can result in suboptimal performance, as one
        client
        locks all prefetched messages, potentially leading to processing bottlenecks.
-    2. **Message Lock Expiry:** Messages in the prefetch queue do not have their locks renewed automatically. Consequently,
+    2. **Message Lock Expiry:** Messages in the prefetch queue do not have their locks renewed automatically.
+       Consequently,
        the
        message lock may expire by the time they are processed.
     3. **Dead-Letter Queue:** Expired message locks can result in messages being inadvertently sent to the dead-letter
@@ -140,7 +146,7 @@ integration, telemetry connectivity, and Azure Toolkit integration.
       the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable)
       for additional information.
 
-   #### b. Use `getChatCompletions` for Chat Applications instead of `getCompletions` API
+   #### b. Use Azure OpenAI's `getChatCompletions` for Chat Applications instead of `getCompletions` API
 
     - **Anti-pattern**: Using the getCompletions API
     - **Issue**: Issue: Functionality Mismatch - The `getCompletions` API is designed for general-purpose completion
@@ -151,5 +157,5 @@ integration, telemetry connectivity, and Azure Toolkit integration.
       when
       generating responses for chatbot or conversational AI applications.
     - Please refer to
-      the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/overview/azure/ai-openai-readme?view=azure-java-preview)
+      the [Azure OpenAI client library for Java](https://learn.microsoft.com/java/api/overview/azure/ai-openai-readme?view=azure-java-preview)
       for additional information.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
index d87c48163b3..85732d4501a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
@@ -13,6 +13,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import java.util.Map;
+
 /**
  * This class extends the LocalInspectionTool to check for the use of discouraged APIs in the code.
  * If the method is called from an Azure client class, a problem is registered with the suggestion message.
@@ -42,20 +43,19 @@ static class DetectDiscouragedAPIUsageVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
 
-        // // Define constants for string literals
-        private static final RuleConfig ruleConfig;
+        // Define constants for string literals
+        private static final RuleConfig RULE_CONFIG;
         private static final Map<String, String> METHODS_TO_CHECK;
-        private static boolean SKIP_WHOLE_RULE;
+        private static final boolean SKIP_WHOLE_RULE;
 
         static {
             final String ruleName = "DetectDiscouragedAPIUsageCheck";
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-            METHODS_TO_CHECK = ruleConfig.getDiscouragedIdentifiersMap();
-
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            METHODS_TO_CHECK = RULE_CONFIG.getDiscouragedIdentifiersMap();
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
         }
 
         /**
@@ -94,19 +94,15 @@ public void visitElement(@NotNull PsiElement element) {
                 PsiElement resolvedMethod = methodExpression.resolve();
 
                 // check if the method is a discouraged API call by accessing the keys of the map stored in the configuration file
-                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod
-                        && METHODS_TO_CHECK.containsKey(((PsiMethod) resolvedMethod).getName())) {
+                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod && METHODS_TO_CHECK.containsKey(((PsiMethod) resolvedMethod).getName())) {
 
                     PsiMethod method = (PsiMethod) resolvedMethod;
 
-                    // containingClass is the client class that is being called. check if the class is an azure
-
                     // containingClass is the client class that is being called. check if the class is an azure client
                     PsiClass containingClass = method.getContainingClass();
 
                     // compare the package name of the containing class to the azure package name from the configuration file
-                    if (containingClass != null && containingClass.getQualifiedName() != null
-                            && containingClass.getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME)) {
+                    if (containingClass != null && containingClass.getQualifiedName() != null && containingClass.getQualifiedName().startsWith("com.azure.ai.openai")) {
 
                         PsiElement problemElement = methodExpression.getReferenceNameElement();
 

From 10582304a1b4e68ad3ce1e274f383fa7f8469d51 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 17 Jul 2024 00:05:39 -0700
Subject: [PATCH 097/144] complete implementation of UpdateCheckpointAsyncCheck

---
 .../azure-intellij-plugin-azure-sdk/README.md |  22 +++
 .../azure/sdk/buildtool/RuleConfig.java       |  16 +-
 .../azure/sdk/buildtool/RuleConfigLoader.java |  27 ++-
 .../buildtool/UpdateCheckpointAsyncCheck.java | 184 +++++++++++-------
 .../main/resources/META-INF/ruleConfigs.json  |  23 ++-
 .../UpdateCheckpointAsyncCheckTest.java       |  59 +++++-
 6 files changed, 244 insertions(+), 87 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index ee1b44a6d55..d635942800b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -159,3 +159,25 @@ integration, telemetry connectivity, and Azure Toolkit integration.
     - Please refer to
       the [Azure OpenAI client library for Java](https://learn.microsoft.com/java/api/overview/azure/ai-openai-readme?view=azure-java-preview)
       for additional information.
+
+9. #### EventProcessorClient: Using `updateCheckpointAsync() API` of EventBatchContext object:
+   #### Anti-pattern a. Without `block()` or `block(timeout)`
+
+    - **Issue**: The `updateCheckpointAsync()` without `block()` will not do anything.
+    - **Severity: WARNING**
+    - **Recommendation**: Use `block()` operator with a timeout or consider using the synchronous
+      version `updateCheckpoint()`.
+
+   #### Anti-pattern b. With `subscribe()`
+
+    - **Issue**: If you use subscribe() with `updateCheckpointAsync()`, you might get the next batch of events before
+      you
+      finish checkpointing the previous batch, or you might have checkpointing of several batches happening out of order
+    - **Severity: WARNING**
+    - **Recommendation**: . Instead of `subscribe()`, use `block()` or `block()` with timeout or use the synchronous
+      version
+      `updateCheckpoint()`.
+
+   Please refer to
+   the [updateCheckpointAsync documentation](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.eventhubs.models.eventbatchcontext?view=azure-java-stable#com-azure-messaging-eventhubs-models-eventbatchcontext-updatecheckpointasync())
+   for additional information.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index 7830b6c626f..b3f614afe08 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -14,10 +14,11 @@ class RuleConfig {
     private final List<String> servicesToCheck;
     private final String antiPatternMessage;
     private final Map<String, String> discouragedIdentifiersMap;
+    private final Map<String, String> antiPatternMessageMap;
 
     static final String AZURE_PACKAGE_NAME = "com.azure";
 
-    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), Collections.emptyMap(), "");
+    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), Collections.emptyMap(), "", Collections.emptyMap());
 
     /**
      * Constructor for RuleConfig.
@@ -27,13 +28,15 @@ class RuleConfig {
      * @param servicesToCheck           List of services to check.
      * @param discouragedIdentifiersMap Map of discouraged identifiers and their suggestions.
      * @param antiPatternMessage        AntiPattern message.
+     * @param antiPatternMessageMap     Map of antiPattern messages.
      */
-    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, Map<String, String> discouragedIdentifiersMap, String antiPatternMessage) {
+    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, Map<String, String> discouragedIdentifiersMap, String antiPatternMessage, Map<String, String> antiPatternMessageMap) {
         this.methodsToCheck = methodsToCheck;
         this.clientsToCheck = clientsToCheck;
         this.servicesToCheck = servicesToCheck;
         this.discouragedIdentifiersMap = discouragedIdentifiersMap;
         this.antiPatternMessage = antiPatternMessage;
+        this.antiPatternMessageMap = antiPatternMessageMap;
     }
 
     /**
@@ -90,4 +93,13 @@ String getAntiPatternMessage() {
     public Map<String, String> getDiscouragedIdentifiersMap() {
         return discouragedIdentifiersMap;
     }
+
+    /**
+     * This method returns the map of antipattern messages
+     *
+     * @return Map of antipattern messages
+     */
+    public Map<String, String> getAntiPatternMessageMap() {
+        return antiPatternMessageMap;
+    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index c47386e8777..01282dc8010 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -130,6 +130,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
         List<String> servicesToCheck = new ArrayList<>();
         Map<String, String > discouragedIdentifiersToCheck = new HashMap<>();
         String antiPatternMessage = null;
+        Map<String, String> antiPatternMessageMap = new HashMap<>();
 
         // Check if the JSON file starts with an object
         if (reader.nextToken() != JsonToken.START_OBJECT) {
@@ -155,6 +156,8 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                 case "services_to_check":
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
+                case "anti_pattern_message_map":
+                    antiPatternMessageMap = getAntiPatternMessageMap(reader, antiPatternMessageMap);
                 default:
                     if (fieldName.endsWith("Check")) {
                         discouragedIdentifiersToCheck = getMapOfDiscouragedIdentifiers(reader, discouragedIdentifiersToCheck);
@@ -164,7 +167,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                     break;
             }
         }
-        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, discouragedIdentifiersToCheck, antiPatternMessage);
+        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, discouragedIdentifiersToCheck, antiPatternMessage, antiPatternMessageMap);
     }
 
     /**
@@ -221,4 +224,26 @@ private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Ma
         }
         return discouragedIdentifiersToCheckMap;
     }
+
+    private Map<String, String> getAntiPatternMessageMap(JsonReader reader, Map<String, String> antiPatternMessageMap) throws IOException {
+        String antiPatternMessage = null;
+
+        // Read the JSON file and parse the RuleConfig object
+        while (reader.nextToken() != JsonToken.END_OBJECT) {
+
+            // Get the field name
+            String fieldName = reader.getFieldName();
+
+            switch (fieldName) {
+                case "no_block":
+                case "with_subscribe":
+                    antiPatternMessage = reader.getString();
+                    break;
+            }
+            if (antiPatternMessage != null) {
+                antiPatternMessageMap.put(fieldName, antiPatternMessage);
+            }
+        }
+        return antiPatternMessageMap;
+    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
index 27f31779a31..1bf3a5b4380 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
@@ -3,22 +3,17 @@
 import com.intellij.codeInspection.LocalInspectionTool;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
-import com.intellij.psi.JavaRecursiveElementVisitor;
 import com.intellij.psi.PsiClass;
 import com.intellij.psi.PsiClassType;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiExpression;
-import com.intellij.psi.PsiLambdaExpression;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiParameter;
-import com.intellij.psi.PsiParameterList;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
-import com.intellij.psi.util.PsiUtil;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.List;
 
 public class UpdateCheckpointAsyncCheck extends LocalInspectionTool {
 
@@ -46,106 +41,145 @@ static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
         // Define the holder for the problems found
         private final ProblemsHolder holder;
 
+        // Define constants for string literals
+        private static final RuleConfig RULE_CONFIG;
+        private static final boolean SKIP_WHOLE_RULE;
+
+        static {
+            final String ruleName = "UpdateCheckpointAsyncCheck";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+            // Get the RuleConfig object for the rule
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+
+            // Get the methods to check from the RuleConfig object
+            SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getMethodsToCheck().isEmpty();
+        }
+
         /**
          * Constructor for the visitor
          *
          * @param holder     The holder for the problems found
          * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use
          */
-        public UpdateCheckpointAsyncVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        UpdateCheckpointAsyncVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
         }
 
-
         @Override
         public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
             super.visitMethodCallExpression(expression);
 
+            // Check if the rule should be skipped
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
+            // Check if the method call is updateCheckpointAsync()
             if ("updateCheckpointAsync".equals(expression.getMethodExpression().getReferenceName())) {
+
+                // Get the method name following the updateCheckpointAsync() method call
                 String followingMethod = getFollowingMethodName(expression);
-                System.out.println("Following method: " + followingMethod);
-
-                if (followingMethod == null) {   // flag for not using block()
-                    System.out.println("Antipattern detected: updateCheckpointAsync() used without block() or block(timeout) or subscribe(): " + expression.getText());
-                    if (isCalledOnEventBatchContext(expression)) {
-                        System.out.println("updateCheckpointAsync() is called on an EventBatchContext object from the Azure SDK: " + expression.getText());
-                        // Add your custom logic here
-                        holder.registerProblem(expression, "The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint()");
-                    }
-                } else if ("subscribe".equals(followingMethod)) {  // if WITH subscribe -- FLAG for using subscribe & for not using block()
-                    System.out.println("Antipattern detected: updateCheckpointAsync() used with subscribe(): ");
-                    if (isCalledOnEventBatchContext(expression)) {
-                        System.out.println("updateCheckpointAsync() is called on an EventBatchContext object from the Azure SDK: " + expression.getText());
-                        // Add your custom logic here
-                        holder.registerProblem(expression, "Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint().");
-                    }
+
+                // Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
+                if (followingMethod == null && isCalledOnEventBatchContext(expression)) {
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("no_block"));
+
+                    // Check if the following method is `subscribe` and
+                    //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
+                } else if ("subscribe".equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("with_subscribe"));
                 }
             }
         }
 
+        /**
+         * This method checks if the method call is following a updateCheckpointAsync() method call.
+         * If the method call is following a updateCheckpointAsync(), the method name is returned.
+         *
+         * @param expression The method call expression
+         * @return The method name if the method call is following a specific method call, null otherwise
+         */
         private String getFollowingMethodName(PsiMethodCallExpression expression) {
 
-//            System.out.println("Expression: " + expression.getText());
-
+            // Get the parent of the method call expression
             PsiElement parent = expression.getParent();
-            System.out.println("Parent: " + parent);
-//            System.out.println("Parent getText: " + parent.getText());
-
-            if (parent instanceof PsiReferenceExpression) {
-                PsiElement grandParent = parent.getParent();
-                System.out.println("Grandparent: " + grandParent);
-//                System.out.println("Grandparent getText: " + grandParent.getText());
-                if (grandParent instanceof PsiMethodCallExpression) {
-                    System.out.println("Grandparent is PsiMethodCallExpression");
-                    System.out.println("Grandparent method: " + ((PsiMethodCallExpression) grandParent).getMethodExpression().getReferenceName());
-                    PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
-//                    System.out.println("Grandparent call: " + parentCall.getText());
-
-                    String methodName = parentCall.getMethodExpression().getReferenceName();
-                    System.out.println("Grandparent method name: " + methodName);
-                    if ("block".equals(methodName) || "subscribe".equals(methodName)) {
-                        return methodName;
-                    }
+
+            if (!(parent instanceof PsiReferenceExpression)) {
+                return null;
+            }
+
+            // Get the grandparent of the method call expression
+            PsiElement grandParent = parent.getParent();
+
+            // Check if the grandparent is a method call expression
+            if (grandParent instanceof PsiMethodCallExpression) {
+
+                // Cast the grandparent to a method call expression
+                PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
+
+                // Get the method name from the parent call
+                String methodName = parentCall.getMethodExpression().getReferenceName();
+
+                // Check if the method name is in the list of methods to check
+                if (RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
+                    return methodName;
                 }
             }
             return null;
         }
 
+        /**
+         * This method checks if the method call is called on an EventBatchContext object from the Azure SDK.
+         *
+         * @param expression The method call expression
+         * @return True if the method call is called on an EventBatchContext object from the Azure SDK, false otherwise
+         */
         private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression) {
-            System.out.println("Checking if updateCheckpointAsync() is called on an EventBatchContext object: " + expression.getText());
 
+            // Get the qualifier expression from the method call expression
             PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
-            System.out.println("Qualifier: " + qualifier);
-
-            if (qualifier instanceof PsiReferenceExpression) {
-                PsiElement resolvedElement = ((PsiReferenceExpression) qualifier).resolve();
-                System.out.println("Resolved element: " + resolvedElement);
-
-                if (resolvedElement instanceof PsiParameter) {
-                    PsiParameter parameter = (PsiParameter) resolvedElement;
-                    System.out.println("Parameter: " + parameter);
-
-                    PsiType parameterType = parameter.getType();
-                    System.out.println("Parameter type: " + parameterType);
-
-                    if ("EventBatchContext".equals(parameterType.getPresentableText())) {
-                        if (parameterType instanceof PsiClassType) {
-                            System.out.println("Parameter type is PsiClassType");
-                            PsiClassType classType = (PsiClassType) parameterType;
-                            System.out.println("Class type: " + classType);
-                            PsiClass psiClass = classType.resolve();
-                            System.out.println("PsiClass: " + psiClass);
-
-                            if (psiClass != null) {
-                                String qualifiedName = psiClass.getQualifiedName();
-                                System.out.println("Qualified name: " + qualifiedName);
-
-                                return qualifiedName != null && qualifiedName.startsWith("com.azure");
-                            }
-                        }
-                    }
-                }
-            } return false;
+
+            // Check if the qualifier is a reference expression
+            if (!(qualifier instanceof PsiReferenceExpression)) {
+                return false;
+            }
+
+            // Resolve the qualifier element
+            PsiElement resolvedElement = ((PsiReferenceExpression) qualifier).resolve();
+
+            // Check if the resolved element is a parameter
+            if (!(resolvedElement instanceof PsiParameter)) {
+                return false;
+            }
+
+            // Check if the resolved element is a class type
+            PsiParameter parameter = (PsiParameter) resolvedElement;
+
+            // Get the type of the parameter
+            PsiType parameterType = parameter.getType();
+
+            // Check if the parameter type is a EventBatchContext object from the Azure SDK
+            if (!("EventBatchContext".equals(parameterType.getPresentableText()))) {
+                return false;
+            }
+
+            if (!(parameterType instanceof PsiClassType)) {
+                return false;
+            }
+
+            // Resolve the parameter type to a class type and get the class
+            PsiClassType classType = (PsiClassType) parameterType;
+            PsiClass psiClass = classType.resolve();
+
+            if (psiClass != null) {
+                // Get the qualified name of the class
+                String qualifiedName = psiClass.getQualifiedName();
+
+                // Check if the qualified name starts with the Azure package name
+                return qualifiedName != null && qualifiedName.startsWith(RuleConfig.AZURE_PACKAGE_NAME);
+            }
+            return false;
         }
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index b78755054df..dfa0fd995de 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -51,10 +51,13 @@
       "ServiceBusReceiverAsyncClient",
       "ServiceBusProcessorClient"
     ],
-    "methods_to_check": ["receiveMode","prefetchCount"],
+    "methods_to_check": [
+      "receiveMode",
+      "prefetchCount"
+    ],
     "anti_pattern_message": "A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."
   },
-  "DetectDiscouragedAPIUsageCheck" : {
+  "DetectDiscouragedAPIUsageCheck": {
     "ConnectionStringCheck": {
       "methods_to_check": "connectionString",
       "anti_pattern_message": "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
@@ -65,8 +68,16 @@
       "anti_pattern_message": "getCompletions API detected. Use the getChatCompletions API instead."
     }
   },
-  "UpdateCheckpointAsyncCheck" : {
-    "methods_to_check": ["updateCheckpointAsync", "block", "block(timeout)", "subscribe"]
-
+  "UpdateCheckpointAsyncCheck": {
+    "methods_to_check": [
+      "updateCheckpointAsync",
+      "block",
+      "block(timeout)",
+      "subscribe"
+    ],
+    "anti_pattern_message_map": {
+      "no_block": "The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint().",
+      "with_subscribe": "If you use subscribe() with updateCheckpointAsync(), you might get the next batch of events before you finish checkpointing the previous batch, or you might have checkpointing of several batches happening out of order. Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint()."
+    }
   }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
index 8fa452633cb..2c40aed7fde 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
@@ -20,6 +20,10 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+/**
+ * This class is used to test the UpdateCheckpointAsyncCheck class.
+ * The test methods test the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+ */
 public class UpdateCheckpointAsyncCheckTest {
 
     // Create a mock ProblemsHolder to be used in the test
@@ -43,6 +47,10 @@ public void setUp() {
         mockMethodCallExpression = mock(PsiMethodCallExpression.class);
     }
 
+    /**
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * The test checks if the problem is registered when the following method is subscribe.
+     */
     @Test
     public void testWithSubscribe() {
         String packageName = "com.azure";
@@ -54,6 +62,11 @@ public void testWithSubscribe() {
         verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
+    /**
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * The test checks if the problem is registered when the following method is block.
+     * A problem should NOT be registered in this case.
+     */
     @Test
     public void testWithBlock() {
         String packageName = "com.azure";
@@ -65,6 +78,27 @@ public void testWithBlock() {
         verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
+    /**
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * The test checks if the problem is registered when the following method is block.
+     * A problem should NOT be registered in this case.
+     */
+    @Test
+    public void testWithBlockTimeout() {
+        String packageName = "com.azure";
+        String followingMethod = "block(timeout)";
+        int numOfInvocations = 0;
+        String mainMethodFound = "updateCheckpointAsync";
+        String objectType = "EventBatchContext";
+
+        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+    }
+
+    /**
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * The test checks if the problem is registered when the following method is null.
+     * A problem should be registered in this case -- there is no 'block' or 'block(timeout)' method following the 'updateCheckpointAsync' method.
+     */
     @Test
     public void testWithNullFollowingMethod() {
         String packageName = "com.azure";
@@ -76,13 +110,33 @@ public void testWithNullFollowingMethod() {
         verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
+    /**
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * The test checks if the problem is registered when the package name is wrong.
+     * A problem should NOT be registered in this case.
+     */
+    @Test
+    public void testWithWrongPackage() {
+        String packageName = "com.microsoft.azure";
+        String followingMethod = "block";
+        int numOfInvocations = 0;
+        String mainMethodFound = "updateCheckpointAsync";
+        String objectType = "EventBatchContext";
 
+        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+    }
+
+    /**
+     * This creates a new UpdateCheckpointAsyncVisitor object.
+     */
     private JavaElementVisitor createVisitor() {
         UpdateCheckpointAsyncVisitor mockVisitor = new UpdateCheckpointAsyncVisitor(mockHolder, true);
         return mockVisitor;
     }
 
-
+    /**
+     * This method verifies if the problem is registered with the ProblemsHolder.
+     */
     private void verifyProblemRegistered(String packageName, String mainMethodFound, int numOfInvocations, String followingMethod, String objectType) {
 
         PsiReferenceExpression mockReferenceExpression = mock(PsiReferenceExpression.class);
@@ -118,8 +172,7 @@ private void verifyProblemRegistered(String packageName, String mainMethodFound,
 
         if (followingMethod != null && followingMethod.equals("subscribe")) {
             verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint()."));
-        }
-        else {
+        } else {
             verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint()"));
         }
     }

From 2590838e409ef0edbe73e33ec3c3e965cd52e60d Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 17 Jul 2024 00:08:33 -0700
Subject: [PATCH 098/144] update to javadocs

---
 .../sdk/buildtool/UpdateCheckpointAsyncCheck.java  | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
index 1bf3a5b4380..a4580f86b7c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
@@ -32,9 +32,9 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
 
     /**
      * This class extends the JavaElementVisitor and is used to visit the Java elements in the code.
-     * It checks for the usage of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients and
-     * whether the auto-complete feature is disabled.
-     * If the auto-complete feature is not disabled, a problem is registered with the ProblemsHolder.
+     * It checks for the usage of the updateCheckpointAsync() method call in the code.
+     * The method call should not be followed by a subscribe method call
+     * and instead should be followed by a block() method call.
      */
     static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
 
@@ -66,6 +66,14 @@ static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
             this.holder = holder;
         }
 
+        /**
+         * This method is used to visit the method call expressions in the code.
+         * It checks for the usage of the updateCheckpointAsync() method call in the code.
+         * The method call should not be followed by a subscribe method call
+         * and instead should be followed by a block() method call.
+         *
+         * @param expression The method call expression
+         */
         @Override
         public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
             super.visitMethodCallExpression(expression);

From 0e4ce1bc6cf35b1dd98e4d12bc6d252340cdf0c9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 17 Jul 2024 10:33:10 -0700
Subject: [PATCH 099/144] update to implementation

---
 .../azure-intellij-plugin-azure-sdk/README.md |  8 ++--
 .../azure/sdk/buildtool/RuleConfig.java       |  6 ++-
 .../azure/sdk/buildtool/RuleConfigLoader.java | 45 +++++++++++++----
 .../buildtool/UpdateCheckpointAsyncCheck.java | 48 +++++++++++--------
 .../main/resources/META-INF/ruleConfigs.json  |  5 +-
 .../UpdateCheckpointAsyncCheckTest.java       | 31 +++++-------
 6 files changed, 87 insertions(+), 56 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index d635942800b..62a54bef8b5 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -160,21 +160,21 @@ integration, telemetry connectivity, and Azure Toolkit integration.
       the [Azure OpenAI client library for Java](https://learn.microsoft.com/java/api/overview/azure/ai-openai-readme?view=azure-java-preview)
       for additional information.
 
-9. #### EventProcessorClient: Using `updateCheckpointAsync() API` of EventBatchContext object:
+9. #### EventProcessorClient: Using `updateCheckpointAsync()` API of EventBatchContext object:
    #### Anti-pattern a. Without `block()` or `block(timeout)`
 
-    - **Issue**: The `updateCheckpointAsync()` without `block()` will not do anything.
+    - **Issue**: Calling `updateCheckpointAsync()` without `block()` will not do anything.
     - **Severity: WARNING**
     - **Recommendation**: Use `block()` operator with a timeout or consider using the synchronous
       version `updateCheckpoint()`.
 
    #### Anti-pattern b. With `subscribe()`
 
-    - **Issue**: If you use subscribe() with `updateCheckpointAsync()`, you might get the next batch of events before
+    - **Issue**: If you call `subscribe()` with `updateCheckpointAsync()`, you might get the next batch of events before
       you
       finish checkpointing the previous batch, or you might have checkpointing of several batches happening out of order
     - **Severity: WARNING**
-    - **Recommendation**: . Instead of `subscribe()`, use `block()` or `block()` with timeout or use the synchronous
+    - **Recommendation**: Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous
       version
       `updateCheckpoint()`.
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index b3f614afe08..dfa96fefbab 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -49,6 +49,7 @@ boolean skipRuleCheck() {
     }
 
     // Getters
+
     /**
      * This method returns the list of methods to check
      *
@@ -87,6 +88,8 @@ String getAntiPatternMessage() {
 
     /**
      * This method returns the map of discouraged identifiers
+     * This is used for base classes that have a set of discouraged identifiers
+     * and a corresponding set of antipattern messages.
      *
      * @return Map of discouraged identifiers
      */
@@ -95,7 +98,8 @@ public Map<String, String> getDiscouragedIdentifiersMap() {
     }
 
     /**
-     * This method returns the map of antipattern messages
+     * This method returns the map of antipattern messages.
+     * This is used in rulechecks with 2 different antipattern messages depending on a certain condition.
      *
      * @return Map of antipattern messages
      */
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 01282dc8010..f03bba47ad1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -59,7 +59,7 @@ private RuleConfigLoader(String filePath) throws IOException {
      *
      * @return CentralRuleConfigLoader instance
      */
-    public static RuleConfigLoader getInstance() {
+    static RuleConfigLoader getInstance() {
         return instance;
     }
 
@@ -128,7 +128,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
         List<String> methodsToCheck = new ArrayList<>();
         List<String> clientsToCheck = new ArrayList<>();
         List<String> servicesToCheck = new ArrayList<>();
-        Map<String, String > discouragedIdentifiersToCheck = new HashMap<>();
+        Map<String, String> discouragedIdentifiersToCheck = new HashMap<>();
         String antiPatternMessage = null;
         Map<String, String> antiPatternMessageMap = new HashMap<>();
 
@@ -199,11 +199,23 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
         return list;
     }
 
+    /**
+     * This method parses the map of discouraged identifiers from the JSON file
+     * This is used for base classes that have a set of discouraged identifiers and a corresponding set of antipattern messages.
+     *
+     * @param reader - the JsonReader object to read the JSON file
+     * @return Map of discouraged identifiers parsed from the JSON file
+     * @throws IOException - if there is an error reading the file
+     */
     private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Map<String, String> discouragedIdentifiersToCheckMap) throws IOException {
 
         String identifiersToCheck = null;
         String antiPatternMessage = null;
 
+        if (reader.nextToken() != JsonToken.START_OBJECT) {
+            throw new IOException("Expected start of object");
+        }
+
         // Read the JSON file and parse the RuleConfig object
         while (reader.nextToken() != JsonToken.END_OBJECT) {
 
@@ -217,6 +229,8 @@ private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Ma
                 case "anti_pattern_message":
                     antiPatternMessage = reader.getString();
                     break;
+                default:
+                    reader.skipChildren();
             }
             if (identifiersToCheck != null && antiPatternMessage != null) {
                 discouragedIdentifiersToCheckMap.put(identifiersToCheck, antiPatternMessage);
@@ -225,8 +239,19 @@ private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Ma
         return discouragedIdentifiersToCheckMap;
     }
 
+    /**
+     * This method parses the map of anti-pattern messages from the JSON file
+     * This is used in rulechecks with 2 different antipattern messages depending on a certain condition.
+     *
+     * @param reader - the JsonReader object to read the JSON file
+     * @return Map of anti-pattern messages parsed from the JSON file
+     * @throws IOException - if there is an error reading the file
+     */
     private Map<String, String> getAntiPatternMessageMap(JsonReader reader, Map<String, String> antiPatternMessageMap) throws IOException {
-        String antiPatternMessage = null;
+
+        if (reader.nextToken() != JsonToken.START_OBJECT) {
+            throw new IOException("Expected start of object");
+        }
 
         // Read the JSON file and parse the RuleConfig object
         while (reader.nextToken() != JsonToken.END_OBJECT) {
@@ -235,13 +260,13 @@ private Map<String, String> getAntiPatternMessageMap(JsonReader reader, Map<Stri
             String fieldName = reader.getFieldName();
 
             switch (fieldName) {
-                case "no_block":
-                case "with_subscribe":
-                    antiPatternMessage = reader.getString();
-                    break;
-            }
-            if (antiPatternMessage != null) {
-                antiPatternMessageMap.put(fieldName, antiPatternMessage);
+                case "no_block", "with_subscribe" -> {
+                    String antiPatternMessage = reader.getString();
+                    if (antiPatternMessage != null) {
+                        antiPatternMessageMap.put(fieldName, antiPatternMessage);
+                    }
+                }
+                default -> reader.skipChildren();
             }
         }
         return antiPatternMessageMap;
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
index a4580f86b7c..f437d0e1555 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
@@ -8,19 +8,26 @@
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiParameter;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
 import org.jetbrains.annotations.NotNull;
 
-
+/**
+ * This class is a custom inspection tool that checks for the usage of the updateCheckpointAsync() method call in the code.
+ * It extends the LocalInspectionTool class and overrides the buildVisitor method to create a visitor for the inspection.
+ * The visitor checks for the usage of the updateCheckpointAsync() method call in the code.
+ * The method call should not be followed by a subscribe method call and instead should be followed by a block() method call.
+ */
 public class UpdateCheckpointAsyncCheck extends LocalInspectionTool {
 
     /**
      * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
      *
-     * @param holder The holder for the problems found
+     * @param holder     The holder for the problems found
+     * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use but is required by the method signature
      * @return The visitor for the inspection. This is not used anywhere else in the code.
      */
     @NotNull
@@ -57,7 +64,7 @@ static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
         }
 
         /**
-         * Constructor for the visitor
+         * Constructs a new instance of the UpdateCheckpointAsyncVisitor
          *
          * @param holder     The holder for the problems found
          * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use
@@ -83,21 +90,25 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 return;
             }
 
+            if (expression.getMethodExpression() == null || expression.getMethodExpression().getReferenceName() == null) {
+                return;
+            }
+
             // Check if the method call is updateCheckpointAsync()
             if ("updateCheckpointAsync".equals(expression.getMethodExpression().getReferenceName())) {
 
                 // Get the method name following the updateCheckpointAsync() method call
                 String followingMethod = getFollowingMethodName(expression);
 
-                // Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
-                if (followingMethod == null && isCalledOnEventBatchContext(expression)) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("no_block"));
-
-                    // Check if the following method is `subscribe` and
-                    //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
-                } else if ("subscribe".equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
+                // Check if the following method is `subscribe` and
+                //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
+                if ("subscribe".equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
                     holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("with_subscribe"));
                 }
+                //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
+                else if (followingMethod == null || (!followingMethod.equals("block") && !followingMethod.equals("block_with_timeout")) && isCalledOnEventBatchContext(expression)) {
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("no_block"));
+                }
             }
         }
 
@@ -116,14 +127,10 @@ private String getFollowingMethodName(PsiMethodCallExpression expression) {
             if (!(parent instanceof PsiReferenceExpression)) {
                 return null;
             }
-
-            // Get the grandparent of the method call expression
             PsiElement grandParent = parent.getParent();
 
-            // Check if the grandparent is a method call expression
             if (grandParent instanceof PsiMethodCallExpression) {
 
-                // Cast the grandparent to a method call expression
                 PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
 
                 // Get the method name from the parent call
@@ -131,8 +138,14 @@ private String getFollowingMethodName(PsiMethodCallExpression expression) {
 
                 // Check if the method name is in the list of methods to check
                 if (RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
-                    return methodName;
+                    if ("block".equals(methodName)) {
+                        PsiExpressionList arguments = parentCall.getArgumentList();
+                        if (arguments.getExpressions().length == 1 && arguments.getExpressions()[0].getType() != null && arguments.getExpressions()[0].getType().equalsToText("java.time.Duration")) {
+                            return "block_with_timeout";
+                        }
+                    }
                 }
+                return methodName;
             }
             return null;
         }
@@ -148,7 +161,6 @@ private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression)
             // Get the qualifier expression from the method call expression
             PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
 
-            // Check if the qualifier is a reference expression
             if (!(qualifier instanceof PsiReferenceExpression)) {
                 return false;
             }
@@ -163,8 +175,6 @@ private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression)
 
             // Check if the resolved element is a class type
             PsiParameter parameter = (PsiParameter) resolvedElement;
-
-            // Get the type of the parameter
             PsiType parameterType = parameter.getType();
 
             // Check if the parameter type is a EventBatchContext object from the Azure SDK
@@ -176,12 +186,10 @@ private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression)
                 return false;
             }
 
-            // Resolve the parameter type to a class type and get the class
             PsiClassType classType = (PsiClassType) parameterType;
             PsiClass psiClass = classType.resolve();
 
             if (psiClass != null) {
-                // Get the qualified name of the class
                 String qualifiedName = psiClass.getQualifiedName();
 
                 // Check if the qualified name starts with the Azure package name
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index dfa0fd995de..fe7a38e2438 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -72,12 +72,11 @@
     "methods_to_check": [
       "updateCheckpointAsync",
       "block",
-      "block(timeout)",
       "subscribe"
     ],
     "anti_pattern_message_map": {
-      "no_block": "The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint().",
-      "with_subscribe": "If you use subscribe() with updateCheckpointAsync(), you might get the next batch of events before you finish checkpointing the previous batch, or you might have checkpointing of several batches happening out of order. Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint()."
+      "no_block": "Calling updateCheckpointAsync() without block() will not do anything, use `block()` or `block` operator with a timeout, or consider using the synchronous version `updateCheckpoint().",
+      "with_subscribe": "Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous version `updateCheckpoint()`"
     }
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
index 2c40aed7fde..24750a9135d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
@@ -4,9 +4,12 @@
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiClass;
 import com.intellij.psi.PsiClassType;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiParameter;
 import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
@@ -78,22 +81,6 @@ public void testWithBlock() {
         verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
-    /**
-     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
-     * The test checks if the problem is registered when the following method is block.
-     * A problem should NOT be registered in this case.
-     */
-    @Test
-    public void testWithBlockTimeout() {
-        String packageName = "com.azure";
-        String followingMethod = "block(timeout)";
-        int numOfInvocations = 0;
-        String mainMethodFound = "updateCheckpointAsync";
-        String objectType = "EventBatchContext";
-
-        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
-    }
-
     /**
      * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
      * The test checks if the problem is registered when the following method is null.
@@ -150,6 +137,10 @@ private void verifyProblemRegistered(String packageName, String mainMethodFound,
         PsiParameter mockParameter = mock(PsiParameter.class);
         PsiClassType parameterType = mock(PsiClassType.class);
         PsiClass psiClass = mock(PsiClass.class);
+        PsiExpression duration = mock(PsiExpression.class);
+        PsiExpressionList arguments = mock(PsiExpressionList.class);
+        PsiExpression[] expressions = new PsiExpression[]{duration};
+        PsiType durationType = mock(PsiType.class);
 
         when(mockMethodCallExpression.getMethodExpression()).thenReturn(mockReferenceExpression);
         when(mockReferenceExpression.getReferenceName()).thenReturn(mainMethodFound);
@@ -159,6 +150,10 @@ private void verifyProblemRegistered(String packageName, String mainMethodFound,
         when(mockReferenceExpression.getParent()).thenReturn(grandParentMethodCalLExpression);
         when(grandParentMethodCalLExpression.getMethodExpression()).thenReturn(parentReferenceExpression);
         when(parentReferenceExpression.getReferenceName()).thenReturn(followingMethod);
+        when(grandParentMethodCalLExpression.getArgumentList()).thenReturn(arguments);
+        when(arguments.getExpressions()).thenReturn(expressions);
+        when(expressions[0].getType()).thenReturn(durationType);
+        when(durationType.getPresentableText()).thenReturn("java.time.Duration");
 
         // isCalledOnEventBatchContext
         when(mockReferenceExpression.getQualifierExpression()).thenReturn(mockQualifier);
@@ -171,9 +166,9 @@ private void verifyProblemRegistered(String packageName, String mainMethodFound,
         mockVisitor.visitMethodCallExpression(mockMethodCallExpression);
 
         if (followingMethod != null && followingMethod.equals("subscribe")) {
-            verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("Instead of subscribe(), use block() or block() with timeout or use the synchronous version updateCheckpoint()."));
+            verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous version `updateCheckpoint()`"));
         } else {
-            verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("The updateCheckpointAsync() without block() will not do anything, use block() operator with a timeout or consider using the synchronous version updateCheckpoint()"));
+            verify(mockHolder, times(numOfInvocations)).registerProblem(eq(mockMethodCallExpression), contains("Calling updateCheckpointAsync() without block() will not do anything, use `block()` or `block` operator with a timeout, or consider using the synchronous version `updateCheckpoint()."));
         }
     }
 }

From fa1b8648a1d44bcd3a7140f10c31e16c0824bf00 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 17 Jul 2024 10:50:37 -0700
Subject: [PATCH 100/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md                 | 2 +-
 .../azure/sdk/buildtool/DetectDiscouragedClientCheck.java     | 2 +-
 .../resources/META-INF/azure-intellij-plugin-azure-sdk.xml    | 2 +-
 .../src/main/resources/META-INF/ruleConfigs.json              | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 410936314ce..dc1baf72aff 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -23,7 +23,7 @@ The Java Code Quality Analyzer, is a plugin designed to improve the quality of J
 - **Recommendation**: Use APIs that take a length parameter. Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-java) for additional information.
 
 
-### 2. Use These Encouraged Clients Instead of Their Corresponding Discouraged Clients
+### 2. Use these encouraged clients instead of their corresponding discouraged clients
 
 #### a. Use **`ServiceBusProcessorClient`** instead of **`ServiceBusReceiverAsyncClient`**
 #### b. Use **`EventProcessorClient`** instead of **`EventHubConsumerAsyncClient`**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
index 30fb18dbb0e..6b0b1bd6298 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
@@ -28,7 +28,7 @@ public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder,boolean is
         return new DetectDiscouragedClientVisitor(holder,isOnTheFly);
     }
 
-    public static class DetectDiscouragedClientVisitor extends JavaElementVisitor {
+    static class DetectDiscouragedClientVisitor extends JavaElementVisitor {
 
         // Define the fields for the visitor
         private final boolean isOnTheFly;
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 082f2940699..1b94d123d79 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -41,7 +41,7 @@
         <localInspection
                 language="JAVA"
                 shortName="DetectDiscouragedClientCheck"
-                displayName="Detect Discouraged Client Check check"
+                displayName="Detect discouraged client check"
                 groupName="Azure SDK"
                 enabledByDefault="true"
                 level="WARNING"
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 1c386ca9adf..da35de27dc1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -9,11 +9,11 @@
   "DetectDiscouragedClientCheck": {
     "ServiceBusReceiverAsyncClientCheck": {
       "client_name": "ServiceBusReceiverAsyncClient",
-      "antipattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+      "anti_pattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
     },
     "EventHubConsumerAsyncClientCheck": {
       "client_name": "EventHubConsumerAsyncClient",
-      "antipattern_message": "Use of EventHubConsumerAsyncClient detected. Use EventProcessorClient instead."
+      "anti_pattern_message": "Use of EventHubConsumerAsyncClient detected. Use EventProcessorClient instead which provides a higher-level abstraction that simplifies event processing, making it the preferred choice for most developers."
     }
   }
 }

From a8b7f1dfb2c84b32d439e1477c870f9f1433a789 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 17 Jul 2024 13:28:43 -0700
Subject: [PATCH 101/144] remove change diff from README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md         | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index cee4532e4a6..af547451252 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -113,12 +113,7 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 7. #### Use SyncPoller instead of PollerFlux#getSyncPoller()
 
 - **Anti-pattern**: Using `getSyncPoller()` on a `PollerFlux` instance is an anti-pattern.
-- **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an
-  asynchronous polling mechanism to a synchronous one, which should be avoided.
+- **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
 - **Severity: WARNING**
-- **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle
-  synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred
-  method for synchronous operations.
-  Please refer to
-  the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable)
-  for additional information.
+- **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
+  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.

From b33a7e96889f738a3d796de27d74375e323b1ebd Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 17 Jul 2024 13:31:32 -0700
Subject: [PATCH 102/144] remove change diff README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md                   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index af547451252..d2efae7781d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -116,4 +116,4 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 - **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
-  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
+Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.

From 1b512ab1287ccacaeb41582cb73e74e4afb684c1 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 17 Jul 2024 13:40:25 -0700
Subject: [PATCH 103/144] Update README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md               | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index d2efae7781d..6096f2052d1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -11,7 +11,7 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 - **Rule Set Integration**: This feature enables users to import and customize rule sets, tailoring the plugin to their
   specific needs.
 - **Telemetry Integration**: This feature connects the plugin to the backend with Application Insights, allowing for
-  efficient data transmission.
+  efficient data transmission. Refer to [configure-telmetry.md](configure-telemetry.md) on details to setup this feature
 - **Azure Toolkit for IntelliJ Integration**: This feature allows the plugin to integrate with the Azure Toolkit for
   IntelliJ, providing extended functionality
 - **Editor Integration**: This feature offers continuous analysis and real-time code suggestions, enhancing the coding
@@ -23,6 +23,8 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
 
+
+
 ## Rules
 
 1. #### Storage Upload without Length Check
@@ -116,4 +118,4 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 - **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
-Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
+ Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.

From fcffaf03c0a40ada62e87c094a51c955b191dcb5 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 17 Jul 2024 13:42:40 -0700
Subject: [PATCH 104/144] remove change diff from README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md                 | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 6096f2052d1..6fb2f81acf5 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -23,8 +23,6 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 
 - **Telemetry Configuration Panel** : This space allows users to enable or disable telemetry if desired.
 
-
-
 ## Rules
 
 1. #### Storage Upload without Length Check
@@ -118,4 +116,4 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 - **Issue**: The main issue with using `getSyncPoller()` is that it introduces additional complexity by converting an asynchronous polling mechanism to a synchronous one, which should be avoided.
 - **Severity: WARNING**
 - **Recommendation**: Instead of using `getSyncPoller()`, it's recommended to use the `SyncPoller` directly to handle synchronous polling tasks. `SyncPoller` provides a synchronous way to interact with the poller and is the preferred method for synchronous operations.
- Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.
+  Please refer to the [Azure SDK for Java documentation](https://learn.microsoft.com/java/api/com.azure.core.util.polling.syncpoller?view=azure-java-stable) for additional information.

From 7bc2e512262b487926090aea935afe588054e76b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Wed, 17 Jul 2024 16:40:04 -0700
Subject: [PATCH 105/144] syntax update to
 KustoQueriesWithTimeIntervalInQueryStringCheck.java

---
 ...KustoQueriesWithTimeIntervalInQueryStringCheck.java | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index e229d630f4a..d3ac92f836e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -64,7 +64,7 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
 
         // // Define constants for string literals
-        private static final RuleConfig ruleConfig;
+        private static final RuleConfig RULE_CONFIG;
         private static final String ANTI_PATTERN_MESSAGE;
         private static final Map<String, Pattern> REGEX_PATTERNS = new HashMap<>();
         private static boolean SKIP_WHOLE_RULE;
@@ -74,17 +74,17 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
 
-            Map<String, String> regexPatterns = ruleConfig.getMappedItemsToCheck();
-            ANTI_PATTERN_MESSAGE = ruleConfig.getAntiPatternMessage();
+            Map<String, String> regexPatterns = RULE_CONFIG.getMappedItemsToCheck();
+            ANTI_PATTERN_MESSAGE = RULE_CONFIG.getAntiPatternMessage();
 
             for (String key : regexPatterns.keySet()) {
                 String patternStr = regexPatterns.get(key);
                 REGEX_PATTERNS.put(key, Pattern.compile(patternStr));
             }
 
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || REGEX_PATTERNS.isEmpty();
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || REGEX_PATTERNS.isEmpty();
         }
 
         // empty list to store time interval parameter names

From f2816f9dec8d080301d13194674be8a36294b48c Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 18 Jul 2024 15:01:20 -0700
Subject: [PATCH 106/144] refactor antipattern message extraction in
 RuleConfigLoader

---
 .../DetectDiscouragedAPIUsageCheck.java       | 10 +--
 .../buildtool/DisableAutoCompleteCheck.java   | 24 ++----
 .../buildtool/DynamicClientCreationCheck.java | 19 ++---
 .../GetSyncPollerOnPollerFluxCheck.java       | 19 ++---
 .../HardcodedAPIKeysAndTokensCheck.java       | 20 ++---
 .../azure/sdk/buildtool/RuleConfig.java       | 43 ++--------
 .../azure/sdk/buildtool/RuleConfigLoader.java | 84 ++++++++-----------
 .../buildtool/ServiceBusReceiveModeCheck.java |  2 +-
 .../ServiceBusReceiverAsyncClientCheck.java   |  2 +-
 .../StorageUploadWithoutLengthCheck.java      | 16 ++--
 .../buildtool/UpdateCheckpointAsyncCheck.java | 11 ++-
 11 files changed, 88 insertions(+), 162 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
index 85732d4501a..7b6d0ec91c6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedAPIUsageCheck.java
@@ -12,8 +12,6 @@
 
 import org.jetbrains.annotations.NotNull;
 
-import java.util.Map;
-
 /**
  * This class extends the LocalInspectionTool to check for the use of discouraged APIs in the code.
  * If the method is called from an Azure client class, a problem is registered with the suggestion message.
@@ -45,7 +43,6 @@ static class DetectDiscouragedAPIUsageVisitor extends JavaElementVisitor {
 
         // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
-        private static final Map<String, String> METHODS_TO_CHECK;
         private static final boolean SKIP_WHOLE_RULE;
 
         static {
@@ -54,8 +51,7 @@ static class DetectDiscouragedAPIUsageVisitor extends JavaElementVisitor {
 
             // Get the RuleConfig object for the rule
             RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
-            METHODS_TO_CHECK = RULE_CONFIG.getDiscouragedIdentifiersMap();
-            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || RULE_CONFIG.getAntiPatternMessageMap().isEmpty();
         }
 
         /**
@@ -94,7 +90,7 @@ public void visitElement(@NotNull PsiElement element) {
                 PsiElement resolvedMethod = methodExpression.resolve();
 
                 // check if the method is a discouraged API call by accessing the keys of the map stored in the configuration file
-                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod && METHODS_TO_CHECK.containsKey(((PsiMethod) resolvedMethod).getName())) {
+                if (resolvedMethod != null && resolvedMethod instanceof PsiMethod && RULE_CONFIG.getAntiPatternMessageMap().containsKey(((PsiMethod) resolvedMethod).getName())) {
 
                     PsiMethod method = (PsiMethod) resolvedMethod;
 
@@ -110,7 +106,7 @@ public void visitElement(@NotNull PsiElement element) {
                             return;
                         }
                         // give the suggestion of the discouraged method
-                        holder.registerProblem(problemElement, METHODS_TO_CHECK.get(method.getName()));
+                        holder.registerProblem(problemElement, RULE_CONFIG.getAntiPatternMessageMap().get(method.getName()));
                     }
                 }
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
index f6820b684ad..830e25a2c05 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
@@ -13,8 +13,6 @@
 import com.intellij.psi.PsiVariable;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.List;
-
 /**
  * This class extends the LocalInspectionTool and is used to inspect the usage of Azure SDK ServiceBusReceiver & ServiceBusProcessor clients in the code.
  * It checks if the auto-complete feature is disabled for the clients.
@@ -44,10 +42,7 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
     static class DisableAutoCompleteVisitor extends JavaElementVisitor {
 
         // Define constants for string literals
-        private static final RuleConfig ruleConfig;
-        private static final String SUGGESTION;
-        private static final List<String> CLIENTS_TO_CHECK;
-        private static final String METHOD_TO_CHECK;
+        private static final RuleConfig RULE_CONFIG;
         private static boolean SKIP_WHOLE_RULE;
 
         static {
@@ -55,12 +50,8 @@ static class DisableAutoCompleteVisitor extends JavaElementVisitor {
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-
-            METHOD_TO_CHECK = ruleConfig.getMethodsToCheck().get(0);
-            CLIENTS_TO_CHECK = ruleConfig.getClientsToCheck();
-            SUGGESTION = ruleConfig.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || CLIENTS_TO_CHECK.isEmpty();
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || RULE_CONFIG.getClientsToCheck().isEmpty();
         }
 
         // Define the holder for the problems found
@@ -120,12 +111,12 @@ private void processVariableDeclaration(PsiVariable variable) {
             PsiExpression initializer = variable.getInitializer();
 
             // Check if the client type is an Azure SDK client
-            if (!clientType.getCanonicalText().startsWith(ruleConfig.AZURE_PACKAGE_NAME)) {
+            if (!clientType.getCanonicalText().startsWith(RuleConfig.AZURE_PACKAGE_NAME)) {
                 return;
             }
 
             // Check if the client type is in the list of clients to check
-            if (CLIENTS_TO_CHECK.contains(clientType.getPresentableText())) {
+            if (RULE_CONFIG.getClientsToCheck().contains(clientType.getPresentableText())) {
 
                 if (!(initializer instanceof PsiMethodCallExpression)) {
                     return;
@@ -133,7 +124,7 @@ private void processVariableDeclaration(PsiVariable variable) {
                 // Process the new expression initialization
                 if (!isAutoCompleteDisabled((PsiMethodCallExpression) initializer)) {
                     // Register a problem if the auto-complete feature is not disabled
-                    holder.registerProblem(initializer, SUGGESTION);
+                    holder.registerProblem(initializer, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                 }
             }
         }
@@ -162,11 +153,10 @@ private static boolean isAutoCompleteDisabled(PsiMethodCallExpression methodCall
                     String methodName = methodExpression.getReferenceName();
 
                     // Check if the method name is the method to check
-                    if (METHOD_TO_CHECK.equals(methodName)) {
+                    if (RULE_CONFIG.getMethodsToCheck().get(0).equals(methodName)) {
                         return true;
                     }
                 }
-
                 qualifier = ((PsiMethodCallExpression) qualifier).getMethodExpression().getQualifierExpression();
             }
             // When the chain has been traversed and the method to check is not found
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index 13209343357..f0159735784 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -17,8 +17,6 @@
 import com.intellij.psi.PsiStatement;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.List;
-
 /**
  * This class is used to check for the dynamic creation of clients in the code.
  * It extends the LocalInspectionTool class, which is used to create custom code inspections.
@@ -49,9 +47,7 @@ static class DynamicClientCreationVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
 
         // Define constants for string literals
-        private static final RuleConfig ruleConfig;
-        private static final String ANTI_PATTERN_MESSAGE;
-        private static final List<String> METHODS_TO_CHECK;
+        private static final RuleConfig RULE_CONFIG;
         private static boolean SKIP_WHOLE_RULE;
 
         static {
@@ -59,11 +55,8 @@ static class DynamicClientCreationVisitor extends JavaElementVisitor {
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-
-            METHODS_TO_CHECK = ruleConfig.getMethodsToCheck();
-            ANTI_PATTERN_MESSAGE = ruleConfig.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK.isEmpty();
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || RULE_CONFIG.getMethodsToCheck().isEmpty();
         }
 
         /**
@@ -134,7 +127,7 @@ private void checkClientCreation(PsiStatement blockChild) {
 
                 // Check if the right-hand side is a method call expression
                 if (rhs != null && isClientCreationMethod((PsiMethodCallExpression) rhs)) {
-                    holder.registerProblem(rhs, ANTI_PATTERN_MESSAGE);
+                    holder.registerProblem(rhs, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                 }
             } else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check for the declaration statement
 
@@ -159,7 +152,7 @@ private void checkClientCreation(PsiStatement blockChild) {
                     // Check if the initializer is a method call expression
                     PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) initializer;
                     if (isClientCreationMethod(methodCallExpression)) {
-                        holder.registerProblem(methodCallExpression, ANTI_PATTERN_MESSAGE);
+                        holder.registerProblem(methodCallExpression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                     }
                 }
             }
@@ -183,7 +176,7 @@ public boolean isClientCreationMethod(PsiMethodCallExpression methodCallExpressi
             String methodName = methodExpression.getReferenceName();
 
             // Check if the method name is buildClient or AsyncBuildClient
-            if (methodName != null && METHODS_TO_CHECK.contains(methodName)) {
+            if (methodName != null && RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
 
                 // Extract the qualifier expression
                 PsiExpression qualifierExpression = methodExpression.getQualifierExpression();
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
index 0de7bb2f616..074b75235ee 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
@@ -47,21 +47,16 @@ static class GetSyncPollerOnPollerFluxVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
 
         // Define constants for string literals
-        private static final RuleConfig ruleConfig;
-        private static final String ANTI_PATTERN_MESSAGE;
-        private static final String METHOD_TO_CHECK;
-        private static boolean SKIP_WHOLE_RULE;
+        private static final RuleConfig RULE_CONFIG;
+        private static final boolean SKIP_WHOLE_RULE;
 
         static {
             final String ruleName = "GetSyncPollerOnPollerFluxCheck";
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-
-            METHOD_TO_CHECK = ruleConfig.getMethodsToCheck().get(0);
-            ANTI_PATTERN_MESSAGE = ruleConfig.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE;
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE;
         }
 
         /**
@@ -96,11 +91,11 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
             PsiMethodCallExpression methodCall = expression;
 
             // Check if the method call is getSyncPoller
-            if (methodCall.getMethodExpression().getReferenceName().startsWith(METHOD_TO_CHECK)) {
+            if (methodCall.getMethodExpression().getReferenceName().startsWith(RULE_CONFIG.getMethodsToCheck().get(0))) {
                 boolean isAsyncContext = checkIfAsyncContext(methodCall);
 
                 if (isAsyncContext && isAzureClient(methodCall)) {
-                    holder.registerProblem(expression, ANTI_PATTERN_MESSAGE);
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                 }
             }
         }
@@ -154,7 +149,7 @@ private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
             String className = containingClass.getQualifiedName();
 
             // Check if the class is part of the Azure SDK
-            if (className != null && className.startsWith(ruleConfig.AZURE_PACKAGE_NAME)) {
+            if (className != null && className.startsWith(RuleConfig.AZURE_PACKAGE_NAME)) {
                 return true;
             }
             return false;
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
index 0e0169f3a15..b3ee93df9e5 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
@@ -8,9 +8,6 @@
 import com.intellij.psi.PsiNewExpression;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.List;
-
-
 /**
  * This class is a custom inspection tool that checks for hardcoded API keys and tokens in the code.
  * It extends the LocalInspectionTool class and overrides the buildVisitor method to create a visitor for the inspection.
@@ -41,21 +38,16 @@ static class APIKeysAndTokensVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
 
         // // Define constants for string literals
-        private static final RuleConfig ruleConfig;
-        private static final String ANTI_PATTERN_MESSAGE;
-        private static final List<String> SERVICES_TO_CHECK;
-        private static boolean SKIP_WHOLE_RULE;
+        private static final RuleConfig RULE_CONFIG;
+        private static final boolean SKIP_WHOLE_RULE;
 
         static {
             final String ruleName = "HardcodedAPIKeysAndTokensCheck";
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-
-            SERVICES_TO_CHECK = ruleConfig.getServicesToCheck();
-            ANTI_PATTERN_MESSAGE = ruleConfig.getAntiPatternMessage();
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || SERVICES_TO_CHECK.isEmpty();
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || RULE_CONFIG.getServicesToCheck().isEmpty();
         }
 
 
@@ -83,8 +75,8 @@ public void visitElement(@NotNull PsiElement element) {
 
                 // Check if the class reference is not null, the qualifier name starts with "com.azure" and
                 // the class reference is in the list of clients to check
-                if (newExpression.getClassReference() != null && newExpression.getClassReference().getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && SERVICES_TO_CHECK.contains(classReference)) {
-                    this.holder.registerProblem(newExpression, ANTI_PATTERN_MESSAGE);
+                if (newExpression.getClassReference() != null && newExpression.getClassReference().getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && RULE_CONFIG.getServicesToCheck().contains(classReference)) {
+                    this.holder.registerProblem(newExpression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index dfa96fefbab..5625a1f7f76 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -12,13 +12,11 @@ class RuleConfig {
     private final List<String> methodsToCheck;
     private final List<String> clientsToCheck;
     private final List<String> servicesToCheck;
-    private final String antiPatternMessage;
-    private final Map<String, String> discouragedIdentifiersMap;
     private final Map<String, String> antiPatternMessageMap;
 
     static final String AZURE_PACKAGE_NAME = "com.azure";
 
-    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), Collections.emptyMap(), "", Collections.emptyMap());
+    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), Collections.emptyMap());
 
     /**
      * Constructor for RuleConfig.
@@ -26,16 +24,12 @@ class RuleConfig {
      * @param methodsToCheck            List of methods to check.
      * @param clientsToCheck            List of clients to check.
      * @param servicesToCheck           List of services to check.
-     * @param discouragedIdentifiersMap Map of discouraged identifiers and their suggestions.
-     * @param antiPatternMessage        AntiPattern message.
-     * @param antiPatternMessageMap     Map of antiPattern messages.
+     * @param antiPatternMessageMap     Map of antipattern messages to display.
      */
-    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, Map<String, String> discouragedIdentifiersMap, String antiPatternMessage, Map<String, String> antiPatternMessageMap) {
+    RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, Map<String, String> antiPatternMessageMap) {
         this.methodsToCheck = methodsToCheck;
         this.clientsToCheck = clientsToCheck;
         this.servicesToCheck = servicesToCheck;
-        this.discouragedIdentifiersMap = discouragedIdentifiersMap;
-        this.antiPatternMessage = antiPatternMessage;
         this.antiPatternMessageMap = antiPatternMessageMap;
     }
 
@@ -49,7 +43,6 @@ boolean skipRuleCheck() {
     }
 
     // Getters
-
     /**
      * This method returns the list of methods to check
      *
@@ -78,32 +71,14 @@ List<String> getServicesToCheck() {
     }
 
     /**
-     * This method returns the antipattern message
-     *
-     * @return Antipattern message
-     */
-    String getAntiPatternMessage() {
-        return antiPatternMessage;
-    }
-
-    /**
-     * This method returns the map of discouraged identifiers
-     * This is used for base classes that have a set of discouraged identifiers
-     * and a corresponding set of antipattern messages.
-     *
-     * @return Map of discouraged identifiers
-     */
-    public Map<String, String> getDiscouragedIdentifiersMap() {
-        return discouragedIdentifiersMap;
-    }
-
-    /**
-     * This method returns the map of antipattern messages.
-     * This is used in rulechecks with 2 different antipattern messages depending on a certain condition.
-     *
+     * This method returns a map of antipattern messages.
+     * The key is the antipattern message key and the value is the antipattern message.
+     * Generally, most rules have an antipattern message key of "anti_pattern_message".
+     * Discouraged identifiers have an antipattern message key of the discouraged client or API being used.
+     * "UpdateCheckpointAsync" rule has antipattern message keys of "with_subscribe" and "no_block".
      * @return Map of antipattern messages
      */
-    public Map<String, String> getAntiPatternMessageMap() {
+    Map<String, String> getAntiPatternMessageMap() {
         return antiPatternMessageMap;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index f03bba47ad1..64fb6f2e272 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -20,7 +20,7 @@
  * The map contains the key-value pairs where the key is the rule name and the value is the RuleConfig object.
  * The RuleConfig object for a given key can be retrieved using the getRuleConfig method.
  */
-public class RuleConfigLoader {
+class RuleConfigLoader {
 
     private static final RuleConfigLoader instance;
     private final Map<String, RuleConfig> ruleConfigs;
@@ -119,6 +119,8 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
 
     /**
      * This method parses the RuleConfig object from the JSON file
+     * The RuleConfig object either contains the methods to check, clients to check or services to check,
+     * and the anti-pattern messages
      *
      * @param reader - the JsonReader object to read the JSON file
      * @return RuleConfig object parsed from the JSON file
@@ -128,8 +130,6 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
         List<String> methodsToCheck = new ArrayList<>();
         List<String> clientsToCheck = new ArrayList<>();
         List<String> servicesToCheck = new ArrayList<>();
-        Map<String, String> discouragedIdentifiersToCheck = new HashMap<>();
-        String antiPatternMessage = null;
         Map<String, String> antiPatternMessageMap = new HashMap<>();
 
         // Check if the JSON file starts with an object
@@ -148,7 +148,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                     methodsToCheck = getListFromJsonArray(reader);
                     break;
                 case "anti_pattern_message":
-                    antiPatternMessage = reader.getString();
+                    antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
                     break;
                 case "clients_to_check":
                     clientsToCheck = getListFromJsonArray(reader);
@@ -157,17 +157,22 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
                 case "anti_pattern_message_map":
-                    antiPatternMessageMap = getAntiPatternMessageMap(reader, antiPatternMessageMap);
+                    // Move to the next token to process the nested object
+                    reader.nextToken();
+                    antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
+                    break;
                 default:
                     if (fieldName.endsWith("Check")) {
-                        discouragedIdentifiersToCheck = getMapOfDiscouragedIdentifiers(reader, discouragedIdentifiersToCheck);
+                        // Move to the next token to process the nested object
+                        reader.nextToken();
+                        antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
                     } else {
                         reader.skipChildren();
                     }
                     break;
             }
         }
-        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, discouragedIdentifiersToCheck, antiPatternMessage, antiPatternMessageMap);
+        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, antiPatternMessageMap);
     }
 
     /**
@@ -200,28 +205,25 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
     }
 
     /**
-     * This method parses the map of discouraged identifiers from the JSON file
-     * This is used for base classes that have a set of discouraged identifiers and a corresponding set of antipattern messages.
+     * This method is used to parse the anti-pattern messages from a JSON file
+     * The anti-pattern messages can be for a set of methods, clients, or services
+     * The anti-pattern messages can also be for specific rules like "no_block" and "with_subscribe"
      *
      * @param reader - the JsonReader object to read the JSON file
-     * @return Map of discouraged identifiers parsed from the JSON file
+     * @param antiPatternMessageMap - the map to store the anti-pattern messages
+     * @return Map of strings parsed from the JSON object
      * @throws IOException - if there is an error reading the file
      */
-    private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Map<String, String> discouragedIdentifiersToCheckMap) throws IOException {
+    private Map<String, String> getMapFromJsonObject(JsonReader reader, Map<String, String> antiPatternMessageMap) throws IOException {
 
         String identifiersToCheck = null;
         String antiPatternMessage = null;
 
-        if (reader.nextToken() != JsonToken.START_OBJECT) {
-            throw new IOException("Expected start of object");
-        }
-
         // Read the JSON file and parse the RuleConfig object
         while (reader.nextToken() != JsonToken.END_OBJECT) {
 
             // Get the field name
             String fieldName = reader.getFieldName();
-
             switch (fieldName) {
                 case "methods_to_check":
                     identifiersToCheck = getListFromJsonArray(reader).get(0);
@@ -229,46 +231,32 @@ private Map<String, String> getMapOfDiscouragedIdentifiers(JsonReader reader, Ma
                 case "anti_pattern_message":
                     antiPatternMessage = reader.getString();
                     break;
+                case "no_block":
+                case "with_subscribe":
+                    reader.nextToken();
+                    antiPatternMessage = reader.getString();
+                    if (antiPatternMessage != null) {
+                        antiPatternMessageMap.put(fieldName, antiPatternMessage);
+                    }
                 default:
                     reader.skipChildren();
+                    break;
             }
-            if (identifiersToCheck != null && antiPatternMessage != null) {
-                discouragedIdentifiersToCheckMap.put(identifiersToCheck, antiPatternMessage);
-            }
-        }
-        return discouragedIdentifiersToCheckMap;
-    }
+            // Add to map based on conditions
+            if (antiPatternMessage != null) {
 
-    /**
-     * This method parses the map of anti-pattern messages from the JSON file
-     * This is used in rulechecks with 2 different antipattern messages depending on a certain condition.
-     *
-     * @param reader - the JsonReader object to read the JSON file
-     * @return Map of anti-pattern messages parsed from the JSON file
-     * @throws IOException - if there is an error reading the file
-     */
-    private Map<String, String> getAntiPatternMessageMap(JsonReader reader, Map<String, String> antiPatternMessageMap) throws IOException {
+                // This map is for base classes that have a set of discouraged identifiers and a corresponding set of antipattern messages
+                if (identifiersToCheck != null) {
+                    antiPatternMessageMap.put(identifiersToCheck, antiPatternMessage);
+                } else if (fieldName != "no_block" && fieldName != "with_subscribe") {
 
-        if (reader.nextToken() != JsonToken.START_OBJECT) {
-            throw new IOException("Expected start of object");
-        }
-
-        // Read the JSON file and parse the RuleConfig object
-        while (reader.nextToken() != JsonToken.END_OBJECT) {
-
-            // Get the field name
-            String fieldName = reader.getFieldName();
-
-            switch (fieldName) {
-                case "no_block", "with_subscribe" -> {
-                    String antiPatternMessage = reader.getString();
-                    if (antiPatternMessage != null) {
-                        antiPatternMessageMap.put(fieldName, antiPatternMessage);
-                    }
+                    // This map is for single anti-pattern messages of a particular rule
+                    antiPatternMessageMap.put(fieldName, antiPatternMessage);
+                    return antiPatternMessageMap;
                 }
-                default -> reader.skipChildren();
             }
         }
+        // This map is to return "no_block" and "with_subscribe" anti-pattern messages
         return antiPatternMessageMap;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
index 4779e9516b6..f1331776b12 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -174,7 +174,7 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
 
                 // If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1, register a problem
                 if (prefetchCountValue.isPresent() && prefetchCountValue.getAsInt() > 1 && isReceiveModePeekLock && prefetchCountMethod != null) {
-                    holder.registerProblem(prefetchCountMethod, RULE_CONFIG.getAntiPatternMessage());
+                    holder.registerProblem(prefetchCountMethod, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                     return;
                 }
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index 9a38283f407..a8a5a105479 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -30,7 +30,7 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
         SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE;
         CLIENT_NAME = ruleConfig.getClientsToCheck().get(0);
-        SUGGESTION = ruleConfig.getAntiPatternMessage();
+        SUGGESTION = ruleConfig.getAntiPatternMessageMap().get("anti_pattern_message");
     }
 
     /**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 54e15694fc7..36c74288348 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -11,9 +11,6 @@
 import org.jetbrains.annotations.Nls;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.List;
-
-
 /**
  * This class extends the LocalInspectionTool and is used to inspect the usage of Azure Storage upload APIs in the code.
  * It checks if the upload methods are being called without a 'length' parameter of type 'long'.
@@ -29,9 +26,8 @@ public String getDisplayName() {
         return "Ensure Storage APIs use Length Parameter";
     }
 
-    private static final List<String> METHODS_TO_CHECK_LIST;
+    private static final RuleConfig RULE_CONFIG;
     private static final String LENGTH_TYPE = "long";
-    private static final String SUGGESTION;
     private static final boolean SKIP_WHOLE_RULE;
 
 
@@ -40,10 +36,8 @@ public String getDisplayName() {
         RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
         // Get the RuleConfig object for the rule
-        final RuleConfig ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
-        METHODS_TO_CHECK_LIST = ruleConfig.getMethodsToCheck();
-        SUGGESTION = ruleConfig.getAntiPatternMessage();
-        SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || METHODS_TO_CHECK_LIST.isEmpty();
+        RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+        SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || RULE_CONFIG.getMethodsToCheck().isEmpty();
     }
 
     /**
@@ -63,7 +57,7 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                 super.visitMethodCallExpression(expression);
                 String methodName = expression.getMethodExpression().getReferenceName();
 
-                if (!METHODS_TO_CHECK_LIST.contains(methodName)) {
+                if (!RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
                     return;
                 }
 
@@ -91,7 +85,7 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                     }
                 }
                 if (!hasLengthArg) {
-                    holder.registerProblem(expression, SUGGESTION);
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
                 }
             }
         };
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
index f437d0e1555..2bbffa395b0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
@@ -51,6 +51,9 @@ static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
         // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
         private static final boolean SKIP_WHOLE_RULE;
+        private static final String BLOCK_METHOD = "block";
+        private static final String SUBSCRIBE_METHOD = "subscribe";
+        private static final String BLOCK_WITH_TIMEOUT_METHOD = "block_with_timeout";
 
         static {
             final String ruleName = "UpdateCheckpointAsyncCheck";
@@ -102,11 +105,11 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
 
                 // Check if the following method is `subscribe` and
                 //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
-                if ("subscribe".equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
+                if (SUBSCRIBE_METHOD.equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
                     holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("with_subscribe"));
                 }
                 //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
-                else if (followingMethod == null || (!followingMethod.equals("block") && !followingMethod.equals("block_with_timeout")) && isCalledOnEventBatchContext(expression)) {
+                else if (followingMethod == null || (!followingMethod.equals(BLOCK_METHOD) && !followingMethod.equals(BLOCK_WITH_TIMEOUT_METHOD)) && isCalledOnEventBatchContext(expression)) {
                     holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("no_block"));
                 }
             }
@@ -138,10 +141,10 @@ private String getFollowingMethodName(PsiMethodCallExpression expression) {
 
                 // Check if the method name is in the list of methods to check
                 if (RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
-                    if ("block".equals(methodName)) {
+                    if (BLOCK_METHOD.equals(methodName)) {
                         PsiExpressionList arguments = parentCall.getArgumentList();
                         if (arguments.getExpressions().length == 1 && arguments.getExpressions()[0].getType() != null && arguments.getExpressions()[0].getType().equalsToText("java.time.Duration")) {
-                            return "block_with_timeout";
+                            return BLOCK_WITH_TIMEOUT_METHOD;
                         }
                     }
                 }

From 62e5615912ef6bd1462300a0816e8086b316b8d9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 09:31:39 -0700
Subject: [PATCH 107/144] address PR changes

---
 .../azure-intellij-plugin-azure-sdk/README.md |  2 +-
 .../DetectDiscouragedClientCheck.java         | 25 ++++++++++++++-----
 .../azure-intellij-plugin-azure-sdk.xml       | 16 ++++++------
 3 files changed, 28 insertions(+), 15 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 51a50769027..9b0c6e41f5a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -185,7 +185,7 @@ integration, telemetry connectivity, and Azure Toolkit integration.
      use `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies
      message consumption, making it a more suitable option for most developers and scenarios.
    - Please refer to
-     the [Azure Service Bus client library for Java](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient)
+     the [Azure Service Bus client for Java](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient)
      for more information.
 
     ##### b. **EventHubConsumerAsyncClient**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
index c2a4d1b6a32..f78b8767a95 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
@@ -17,26 +17,35 @@
 
 public class DetectDiscouragedClientCheck extends LocalInspectionTool {
 
+    /**
+     * This method builds a visitor to check for the discouraged client name in the code.
+     * If the client name matches the discouraged client, a problem is registered with the suggestion message.
+     */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
         return new DetectDiscouragedClientVisitor(holder, isOnTheFly);
     }
 
+    /**
+     * This class is a visitor that checks for the use of discouraged clients in the code.
+     * If the client name matches the discouraged client, a problem is registered with the suggestion message.
+     */
     static class DetectDiscouragedClientVisitor extends JavaElementVisitor {
 
         // Define the fields for the visitor
-        private final boolean isOnTheFly;
         private final ProblemsHolder holder;
 
-        // Constructor for the visitor
-        public DetectDiscouragedClientVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        /**
+         * Constructor for the visitor
+         *
+         * @param holder     - the ProblemsHolder object to register the problem
+         * @param isOnTheFly - whether the inspection is on the fly - not used in this implementation but required by the parent class
+         */
+        DetectDiscouragedClientVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
-            this.isOnTheFly = isOnTheFly;
         }
 
-        private static Map<String, String> CLIENT_DATA;
-
         // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
         private static final Map<String, String> CLIENTS_TO_CHECK;
@@ -60,6 +69,10 @@ public DetectDiscouragedClientVisitor(ProblemsHolder holder, boolean isOnTheFly)
         public void visitTypeElement(PsiTypeElement element) {
             super.visitTypeElement(element);
 
+            // Skip the whole rule if the configuration is empty
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
             // Check if the element is an instance of PsiTypeElement
             if (element instanceof PsiTypeElement && element.getType() != null) {
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 566cb3faf6d..e5818cd6068 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -76,16 +76,16 @@
         </localInspection>
 
         <localInspection
-                language="JAVA"
-                shortName="HardcodedAPIKeysAndTokensCheck"
-                displayName="Hardcoded API Keys And Tokens Check"
-                groupName="Azure SDK Rules"
-                enabledByDefault="true"
-                level="WARNING"
-                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck">
+            language="JAVA"
+            shortName="HardcodedAPIKeysAndTokensCheck"
+            displayName="Hardcoded API Keys And Tokens Check"
+            groupName="Azure SDK Rules"
+            enabledByDefault="true"
+            level="WARNING"
+            implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck">
 
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck
+            com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.HardcodedAPIKeysAndTokensCheck
             </class>
         </localInspection>
 

From e56585c47144fb7c9e896c466552e37289ed37d3 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Fri, 19 Jul 2024 09:33:01 -0700
Subject: [PATCH 108/144] remove diff from applicationInsights.json

---
 .../src/main/resources/META-INF/applicationInsights.json      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
index c496cbb3125..0d970dcabe7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
@@ -1,3 +1,3 @@
 {
-  "instrumentationKey":"<instrumentationKey>"
-}
\ No newline at end of file
+  "instrumentationKey":"<instrumentationKey>",
+}

From e2786e31f073511af50373f1fd20bba4cdb0e7d6 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <96387542+Njeriiii@users.noreply.github.com>
Date: Fri, 19 Jul 2024 09:33:40 -0700
Subject: [PATCH 109/144] remove diff from applicationInsights.json


From 58aa6f465e524d9c7d8151da18897156c9a06f75 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 09:38:41 -0700
Subject: [PATCH 110/144] remove diff from appinsights.json

---
 .../src/main/resources/META-INF/applicationInsights.json        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
index 0d970dcabe7..0cbfbda4b9d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/applicationInsights.json
@@ -1,3 +1,3 @@
 {
   "instrumentationKey":"<instrumentationKey>",
-}
+}
\ No newline at end of file

From c282b2b9d9ccf5cf28fced9ea039eb2614a3962e Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 11:00:49 -0700
Subject: [PATCH 111/144] address PR comments

---
 ...iesWithTimeIntervalInQueryStringCheck.java | 27 +++++++---------
 .../azure/sdk/buildtool/RuleConfig.java       | 16 +++++-----
 .../azure/sdk/buildtool/RuleConfigLoader.java | 31 +++++++++++++------
 ...ithTimeIntervalInQueryStringCheckTest.java |  2 +-
 4 files changed, 41 insertions(+), 35 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index e229d630f4a..509a56e9719 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -19,9 +19,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 import java.util.regex.Pattern;
 
 /**
@@ -64,9 +62,8 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
         private final ProblemsHolder holder;
 
         // // Define constants for string literals
-        private static final RuleConfig ruleConfig;
-        private static final String ANTI_PATTERN_MESSAGE;
-        private static final Map<String, Pattern> REGEX_PATTERNS = new HashMap<>();
+        private static final RuleConfig RULE_CONFIG;
+        private static final List <Pattern> REGEX_PATTERNS = new ArrayList<>();
         private static boolean SKIP_WHOLE_RULE;
 
         static {
@@ -74,17 +71,15 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            ruleConfig = centralRuleConfigLoader.getRuleConfig(ruleName);
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
 
-            Map<String, String> regexPatterns = ruleConfig.getMappedItemsToCheck();
-            ANTI_PATTERN_MESSAGE = ruleConfig.getAntiPatternMessage();
-
-            for (String key : regexPatterns.keySet()) {
-                String patternStr = regexPatterns.get(key);
-                REGEX_PATTERNS.put(key, Pattern.compile(patternStr));
+            List<String> regexPatterns = RULE_CONFIG.getListedItemsToCheck();
+            // Compile the regex patterns
+            for (String pattern : regexPatterns) {
+                REGEX_PATTERNS.add(Pattern.compile(pattern));
             }
 
-            SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE || REGEX_PATTERNS.isEmpty();
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE || REGEX_PATTERNS.isEmpty();
         }
 
         // empty list to store time interval parameter names
@@ -97,7 +92,7 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
          * @param holder     - ProblemsHolder is used to register problems found in the code
          * @param isOnTheFly - boolean to indicate if the inspection is done on the fly - This is not used in this implementation
          */
-        public KustoQueriesVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        KustoQueriesVisitor(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
         }
 
@@ -200,7 +195,7 @@ private void handleMethodCall(PsiMethodCallExpressionImpl methodCall) {
                 }
 
                 if (isAzureClient(methodCall)) {
-                    holder.registerProblem(methodCall, ANTI_PATTERN_MESSAGE);
+                    holder.registerProblem(methodCall, RULE_CONFIG.getAntiPatternMessage());
                 }
             }
         }
@@ -219,7 +214,7 @@ void checkExpression(PsiExpression expression, PsiElement element) {
             String text = expression.getText();
 
             // Check if the expression text contains any of the regex patterns
-            boolean foundAntiPattern = REGEX_PATTERNS.values().stream().anyMatch(pattern -> pattern.matcher(text).find());
+            boolean foundAntiPattern = REGEX_PATTERNS.stream().anyMatch(pattern -> pattern.matcher(text).find());
 
 
             // If an anti-pattern is detected, register a problem
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index 5e3926209e7..c6b4b433cac 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -13,10 +13,10 @@ class RuleConfig {
     private final List<String> clientsToCheck;
     private final List<String> servicesToCheck;
     private final String antiPatternMessage;
-    private final Map<String, String> mappedItemsToCheck;
+    private final List <String> listedItemsToCheck;
     static final String AZURE_PACKAGE_NAME = "com.azure";
 
-    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), "", Collections.emptyMap());
+    static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), "", Collections.emptyList());
 
     /**
      * Constructor for RuleConfig.
@@ -26,12 +26,12 @@ class RuleConfig {
      * @param servicesToCheck    List of services to check.
      * @param antiPatternMessage AntiPattern message.
      */
-    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, String antiPatternMessage, Map<String, String> mappedItemsToCheck) {
+    public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, String antiPatternMessage, List<String> listedItemsToCheck) {
         this.methodsToCheck = methodsToCheck;
         this.clientsToCheck = clientsToCheck;
         this.servicesToCheck = servicesToCheck;
         this.antiPatternMessage = antiPatternMessage;
-        this.mappedItemsToCheck = mappedItemsToCheck;
+        this.listedItemsToCheck = listedItemsToCheck;
     }
 
     // Getters
@@ -73,11 +73,11 @@ public String getAntiPatternMessage() {
     }
 
     /**
-     * This method returns the mapped items to check
+     * This method returns the list of items to check
      *
-     * @return Mapped items to check
+     * @return List of items to check
      */
-    public Map<String, String> getMappedItemsToCheck() {
-        return mappedItemsToCheck;
+    public List<String> getListedItemsToCheck() {
+        return listedItemsToCheck;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index b30292897a2..b1524686115 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -129,7 +129,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
         List<String> clientsToCheck = new ArrayList<>();
         List<String> servicesToCheck = new ArrayList<>();
         String antiPatternMessage = null;
-        Map <String, String> mappedItemsToCheck = new HashMap<>();
+        List<String> listedItemsToCheck = new ArrayList<>();
 
         // Check if the JSON file starts with an object
         if (reader.nextToken() != JsonToken.START_OBJECT) {
@@ -156,13 +156,13 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
                 case "regex_patterns":
-                    mappedItemsToCheck = getMappedItemsFromJsonReader(reader, mappedItemsToCheck);
+                    listedItemsToCheck = getValuesFromJsonReader(reader);
                     break;
                 default:
                     reader.skipChildren();
             }
         }
-        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, antiPatternMessage, mappedItemsToCheck);
+        return new RuleConfig(methodsToCheck, clientsToCheck, servicesToCheck, antiPatternMessage, listedItemsToCheck);
     }
 
     /**
@@ -194,20 +194,31 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
         return list;
     }
 
-    private Map<String, String> getMappedItemsFromJsonReader(JsonReader reader, Map <String, String> mappedItemsToCheck) throws IOException {
+    /**
+     * This method parses the values from the JSON object
+     *
+     * @param reader - the JsonReader object to read the JSON file
+     * @return List of strings parsed from the JSON object
+     * @throws IOException - if there is an error reading the file
+     */
+    private List<String> getValuesFromJsonReader(JsonReader reader) throws IOException {
+
+        List<String> values = new ArrayList<>();
 
         // Check if the JSON file starts with an object
         if (reader.nextToken() != JsonToken.START_OBJECT) {
             throw new IOException("Expected start of object");
         }
 
-        // Read the JSON file and parse the RuleConfig object
+        // Read the JSON file and parse the values
         while (reader.nextToken() != JsonToken.END_OBJECT) {
-            String key = reader.getFieldName();
-            String value = reader.getString();
-            mappedItemsToCheck.put(key, value);
-        }
 
-        return mappedItemsToCheck;
+            // Skip the field name and read only the value
+            reader.getFieldName(); // Move to the field name
+            reader.nextToken(); // Move to the value
+            String value = reader.getString(); // Read the value
+            values.add(value);
+        }
+        return values;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
index dc33f92b004..1fefb41e3a4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -121,7 +121,7 @@ public void testCheckExpressionWithNullExpression() {
      */
     PsiElementVisitor createVisitor() {
         boolean isOnTheFly = true;
-        KustoQueriesVisitor visitor = new KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor(mockHolder, isOnTheFly);
+        KustoQueriesVisitor visitor = new KustoQueriesVisitor(mockHolder, isOnTheFly);
         return visitor;
     }
 

From 8cacb67a33d3c17f3a5b34f9ce2c4d428975fbe3 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 13:08:07 -0700
Subject: [PATCH 112/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md         |  4 ++--
 ...ustoQueriesWithTimeIntervalInQueryStringCheck.java |  4 ++--
 .../intellij/azure/sdk/buildtool/RuleConfig.java      |  5 ++++-
 ...QueriesWithTimeIntervalInQueryStringCheckTest.java | 11 +++++------
 4 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index ec469febbb3..2101aeeedef 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -113,10 +113,10 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 
 - **Anti-pattern**: Writing KQL queries with hard-coded time intervals directly in the query string.
 - **Issue**: This approach makes queries less flexible and harder to troubleshoot.
-  -**Recommendation**: Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the
+- **Recommendation**: Consider using the `QueryTimeInterval` parameter in the client method parameters to specify the
   time interval for the query.
   By passing the time range as an argument in the method call, you make it easier to troubleshoot and understand the
   context of an API call.
   Please refer to
-  the [Azure SDK for Java documentation](https://learn.microsoft.com/en-us/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable)
+  the [QueryTimeInterval Class documentation](https://learn.microsoft.com/java/api/com.azure.monitor.query.models.querytimeinterval?view=azure-java-stable)
   for additional information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index 509a56e9719..267e3767036 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -63,8 +63,8 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
 
         // // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
-        private static final List <Pattern> REGEX_PATTERNS = new ArrayList<>();
-        private static boolean SKIP_WHOLE_RULE;
+        private static final List<Pattern> REGEX_PATTERNS = new ArrayList<>();
+        private static final boolean SKIP_WHOLE_RULE;
 
         static {
             final String ruleName = "KustoQueriesWithTimeIntervalInQueryStringCheck";
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
index c6b4b433cac..9a95b23d0d7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfig.java
@@ -13,7 +13,7 @@ class RuleConfig {
     private final List<String> clientsToCheck;
     private final List<String> servicesToCheck;
     private final String antiPatternMessage;
-    private final List <String> listedItemsToCheck;
+    private final List<String> listedItemsToCheck;
     static final String AZURE_PACKAGE_NAME = "com.azure";
 
     static final RuleConfig EMPTY_RULE = new RuleConfig(Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), "", Collections.emptyList());
@@ -25,6 +25,7 @@ class RuleConfig {
      * @param clientsToCheck     List of clients to check.
      * @param servicesToCheck    List of services to check.
      * @param antiPatternMessage AntiPattern message.
+     * @param listedItemsToCheck List of items to check for.
      */
     public RuleConfig(List<String> methodsToCheck, List<String> clientsToCheck, List<String> servicesToCheck, String antiPatternMessage, List<String> listedItemsToCheck) {
         this.methodsToCheck = methodsToCheck;
@@ -74,6 +75,8 @@ public String getAntiPatternMessage() {
 
     /**
      * This method returns the list of items to check
+     * The items to check are any types that are not an Azure service, client or method
+     * This includes regex patterns, object types etc
      *
      * @return List of items to check
      */
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
index 1fefb41e3a4..e49504803a0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -8,7 +8,6 @@
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck.KustoQueriesVisitor;
 
 import com.intellij.psi.PsiElement;
-import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiLocalVariable;
 import com.intellij.psi.PsiPolyadicExpression;
@@ -49,12 +48,12 @@
  * <p>
  * String result = blobAsyncClient.query(kqlQueryOne);
  */
-public class KustoQueriesWithTimeIntervalInQueryStringCheckTest {
+class KustoQueriesWithTimeIntervalInQueryStringCheckTest {
 
     // Declare as instance variables
     @Mock
     private ProblemsHolder mockHolder;
-    private PsiElementVisitor mockVisitor;
+    private KustoQueriesVisitor mockVisitor;
     private PsiElement mockElement;
 
     @BeforeEach
@@ -110,7 +109,7 @@ public void testCheckExpressionWithNullExpression() {
         PsiExpression nullExpression = null;
 
         // Act
-        ((KustoQueriesVisitor) mockVisitor).checkExpression(nullExpression, mockElement);
+        mockVisitor.checkExpression(nullExpression, mockElement);
     }
 
 
@@ -119,7 +118,7 @@ public void testCheckExpressionWithNullExpression() {
      *
      * @return PsiElementVisitor
      */
-    PsiElementVisitor createVisitor() {
+    private KustoQueriesVisitor createVisitor() {
         boolean isOnTheFly = true;
         KustoQueriesVisitor visitor = new KustoQueriesVisitor(mockHolder, isOnTheFly);
         return visitor;
@@ -129,7 +128,7 @@ PsiElementVisitor createVisitor() {
     /**
      * This method tests the registerProblem method with a local variable as the query string
      */
-    void verifyRegisterProblemWithLocalVariable(String queryString, String packageName, int numOfInvocations) {
+    private void verifyRegisterProblemWithLocalVariable(String queryString, String packageName, int numOfInvocations) {
 
         PsiLocalVariable variable = mock(PsiLocalVariable.class);
         PsiLiteralExpression initializer = mock(PsiLiteralExpression.class);

From 89aadfd9ffd3bb6e19aa5a1059a3b44b61fa56b5 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 16:56:38 -0700
Subject: [PATCH 113/144] refactor to create abstract base class for 2 checkers

---
 ...AbstractUpdateCheckpointAsyncChecker.java} | 105 +++++-------------
 .../azure-intellij-plugin-azure-sdk.xml       |  24 +++-
 .../main/resources/META-INF/ruleConfigs.json  |  17 +--
 ...ractUpdateCheckpointAsyncCheckerTest.java} |  75 ++++++++-----
 4 files changed, 107 insertions(+), 114 deletions(-)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{UpdateCheckpointAsyncCheck.java => AbstractUpdateCheckpointAsyncChecker.java} (50%)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{UpdateCheckpointAsyncCheckTest.java => AbstractUpdateCheckpointAsyncCheckerTest.java} (72%)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java
similarity index 50%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java
index 2bbffa395b0..2f6c5ebc862 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java
@@ -16,114 +16,71 @@
 import org.jetbrains.annotations.NotNull;
 
 /**
- * This class is a custom inspection tool that checks for the usage of the updateCheckpointAsync() method call in the code.
- * It extends the LocalInspectionTool class and overrides the buildVisitor method to create a visitor for the inspection.
- * The visitor checks for the usage of the updateCheckpointAsync() method call in the code.
- * The method call should not be followed by a subscribe method call and instead should be followed by a block() method call.
+ * Abstract base class for checking the usage of the updateCheckpointAsync() method call in the code.
  */
-public class UpdateCheckpointAsyncCheck extends LocalInspectionTool {
+public abstract class AbstractUpdateCheckpointAsyncChecker extends LocalInspectionTool {
 
     /**
-     * Build the visitor for the inspection. This visitor will be used to traverse the PSI tree.
+     * Abstract method to build the specific visitor for the inspection.
      *
      * @param holder     The holder for the problems found
-     * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use but is required by the method signature
-     * @return The visitor for the inspection. This is not used anywhere else in the code.
+     * @param isOnTheFly boolean to check if the inspection is on the fly
+     * @return The visitor for the inspection
      */
     @NotNull
     @Override
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new UpdateCheckpointAsyncCheck.UpdateCheckpointAsyncVisitor(holder, isOnTheFly);
+        return createVisitor(holder, isOnTheFly);
     }
 
+    /**
+     * Creates the specific visitor for the inspection.
+     *
+     * @param holder     The holder for the problems found
+     * @param isOnTheFly boolean to check if the inspection is on the fly
+     * @return The specific visitor for the inspection
+     */
+    protected abstract PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly);
 
     /**
-     * This class extends the JavaElementVisitor and is used to visit the Java elements in the code.
-     * It checks for the usage of the updateCheckpointAsync() method call in the code.
-     * The method call should not be followed by a subscribe method call
-     * and instead should be followed by a block() method call.
+     * This abstract class is a base visitor used to visit Java elements in the code.
      */
-    static class UpdateCheckpointAsyncVisitor extends JavaElementVisitor {
+    static abstract class UpdateCheckpointAsyncVisitorBase extends JavaElementVisitor {
 
         // Define the holder for the problems found
-        private final ProblemsHolder holder;
+        protected final ProblemsHolder holder;
 
         // Define constants for string literals
-        private static final RuleConfig RULE_CONFIG;
-        private static final boolean SKIP_WHOLE_RULE;
-        private static final String BLOCK_METHOD = "block";
-        private static final String SUBSCRIBE_METHOD = "subscribe";
-        private static final String BLOCK_WITH_TIMEOUT_METHOD = "block_with_timeout";
+        protected static final RuleConfig RULE_CONFIG;
+        protected static final String BLOCK_METHOD = "block";
+        protected static final String BLOCK_WITH_TIMEOUT_METHOD = "block_with_timeout";
 
         static {
-            final String ruleName = "UpdateCheckpointAsyncCheck";
+            final String ruleName = "AbstractUpdateCheckpointAsyncChecker";
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
             RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
-
-            // Get the methods to check from the RuleConfig object
-            SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getMethodsToCheck().isEmpty();
         }
 
         /**
-         * Constructs a new instance of the UpdateCheckpointAsyncVisitor
+         * Constructs a new instance of the UpdateCheckpointAsyncVisitorBase.
          *
          * @param holder     The holder for the problems found
-         * @param isOnTheFly boolean to check if the inspection is on the fly -- This is not in use
+         * @param isOnTheFly boolean to check if the inspection is on the fly
          */
-        UpdateCheckpointAsyncVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        UpdateCheckpointAsyncVisitorBase(ProblemsHolder holder, boolean isOnTheFly) {
             this.holder = holder;
         }
 
         /**
-         * This method is used to visit the method call expressions in the code.
-         * It checks for the usage of the updateCheckpointAsync() method call in the code.
-         * The method call should not be followed by a subscribe method call
-         * and instead should be followed by a block() method call.
-         *
-         * @param expression The method call expression
-         */
-        @Override
-        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
-            super.visitMethodCallExpression(expression);
-
-            // Check if the rule should be skipped
-            if (SKIP_WHOLE_RULE) {
-                return;
-            }
-
-            if (expression.getMethodExpression() == null || expression.getMethodExpression().getReferenceName() == null) {
-                return;
-            }
-
-            // Check if the method call is updateCheckpointAsync()
-            if ("updateCheckpointAsync".equals(expression.getMethodExpression().getReferenceName())) {
-
-                // Get the method name following the updateCheckpointAsync() method call
-                String followingMethod = getFollowingMethodName(expression);
-
-                // Check if the following method is `subscribe` and
-                //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
-                if (SUBSCRIBE_METHOD.equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("with_subscribe"));
-                }
-                //  Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
-                else if (followingMethod == null || (!followingMethod.equals(BLOCK_METHOD) && !followingMethod.equals(BLOCK_WITH_TIMEOUT_METHOD)) && isCalledOnEventBatchContext(expression)) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("no_block"));
-                }
-            }
-        }
-
-        /**
-         * This method checks if the method call is following a updateCheckpointAsync() method call.
-         * If the method call is following a updateCheckpointAsync(), the method name is returned.
+         * This method checks if the method call is following an updateCheckpointAsync() method call.
+         * If the method call is following an updateCheckpointAsync(), the method name is returned.
          *
          * @param expression The method call expression
          * @return The method name if the method call is following a specific method call, null otherwise
          */
-        private String getFollowingMethodName(PsiMethodCallExpression expression) {
-
+        protected String getFollowingMethodName(PsiMethodCallExpression expression) {
             // Get the parent of the method call expression
             PsiElement parent = expression.getParent();
 
@@ -133,7 +90,6 @@ private String getFollowingMethodName(PsiMethodCallExpression expression) {
             PsiElement grandParent = parent.getParent();
 
             if (grandParent instanceof PsiMethodCallExpression) {
-
                 PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
 
                 // Get the method name from the parent call
@@ -159,8 +115,7 @@ private String getFollowingMethodName(PsiMethodCallExpression expression) {
          * @param expression The method call expression
          * @return True if the method call is called on an EventBatchContext object from the Azure SDK, false otherwise
          */
-        private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression) {
-
+        protected boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression) {
             // Get the qualifier expression from the method call expression
             PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
 
@@ -180,8 +135,8 @@ private boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression)
             PsiParameter parameter = (PsiParameter) resolvedElement;
             PsiType parameterType = parameter.getType();
 
-            // Check if the parameter type is a EventBatchContext object from the Azure SDK
-            if (!("EventBatchContext".equals(parameterType.getPresentableText()))) {
+            // Check if the parameter type is an EventBatchContext object from the Azure SDK
+            if (!"EventBatchContext".equals(parameterType.getPresentableText())) {
                 return false;
             }
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 874a9a0e2b4..8844253030a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -138,16 +138,32 @@
 
         <localInspection
                 language="JAVA"
-                shortName="UpdateCheckpointAsyncCheck"
-                displayName="Update Checkpoint Async Check"
+                shortName="UpdateCheckpointAsyncSubscribeChecker"
+                displayName="Update Checkpoint Async Subscribe Checker"
                 groupName="Azure SDK Rules"
                 enabledByDefault="true"
                 level="WARNING"
-                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncCheck">
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncSubscribeChecker">
 
             <class>
-                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncCheck
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncSubscribeChecker
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="UpdateCheckpointAsyncBlockChecker"
+                displayName="Update Checkpoint Async Block Checker"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncBlockChecker">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncBlockChecker
+            </class>
+        </localInspection>
+
+
     </extensions>
 </idea-plugin>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index fe7a38e2438..6e2b47e7c36 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -68,15 +68,18 @@
       "anti_pattern_message": "getCompletions API detected. Use the getChatCompletions API instead."
     }
   },
-  "UpdateCheckpointAsyncCheck": {
+  "AbstractUpdateCheckpointAsyncChecker": {
+    "methods_to_check": "updateCheckpointAsync"
+  },
+  "UpdateCheckpointAsyncSubscribeChecker": {
+    "methods_to_check": "subscribe",
+    "anti_pattern_message": "Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous version `updateCheckpoint()`"
+  },
+  "UpdateCheckpointAsyncBlockChecker": {
     "methods_to_check": [
-      "updateCheckpointAsync",
       "block",
-      "subscribe"
+      "block_with_timeout"
     ],
-    "anti_pattern_message_map": {
-      "no_block": "Calling updateCheckpointAsync() without block() will not do anything, use `block()` or `block` operator with a timeout, or consider using the synchronous version `updateCheckpoint().",
-      "with_subscribe": "Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous version `updateCheckpoint()`"
-    }
+    "anti_pattern_message": "Calling updateCheckpointAsync() without block() will not do anything, use `block()` or `block` operator with a timeout, or consider using the synchronous version `updateCheckpoint()."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncCheckerTest.java
similarity index 72%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncCheckerTest.java
index 24750a9135d..ab3e503a9ff 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncCheckerTest.java
@@ -10,12 +10,12 @@
 import com.intellij.psi.PsiParameter;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncBlockChecker.BlockVisitor;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncSubscribeChecker.SubscribeVisitor;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
 
-import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncCheck.UpdateCheckpointAsyncVisitor;
-
 import static org.mockito.ArgumentMatchers.contains;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.mock;
@@ -24,19 +24,16 @@
 import static org.mockito.Mockito.when;
 
 /**
- * This class is used to test the UpdateCheckpointAsyncCheck class.
- * The test methods test the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+ * This class is used to test the AbstractUpdateCheckpointChecker class.
+ * The test methods test the visitMethodCallExpression method of the classes that extend the AbstractUpdateCheckpointChecker class.
+ * These are the UpdateCheckpointBlockChecker and UpdateCheckpointSubscribeChecker classes.
  */
-public class UpdateCheckpointAsyncCheckTest {
+public class AbstractUpdateCheckpointAsyncCheckerTest {
 
     // Create a mock ProblemsHolder to be used in the test
     @Mock
     private ProblemsHolder mockHolder;
 
-    // Create a mock JavaElementVisitor for visiting the PsiMethodCallExpression
-    @Mock
-    private JavaElementVisitor mockVisitor;
-
     // Create a mock PsiMethodCallExpression.
     @Mock
     private PsiMethodCallExpression mockMethodCallExpression;
@@ -46,85 +43,107 @@ public class UpdateCheckpointAsyncCheckTest {
     public void setUp() {
         // Set up the test
         mockHolder = mock(ProblemsHolder.class);
-        mockVisitor = createVisitor();
         mockMethodCallExpression = mock(PsiMethodCallExpression.class);
     }
 
     /**
-     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncSubscribeVisitor class.
      * The test checks if the problem is registered when the following method is subscribe.
      */
     @Test
     public void testWithSubscribe() {
+
+        SubscribeVisitor mockSubscribeVisitor = new SubscribeVisitor(mockHolder, true);
+
         String packageName = "com.azure";
         String followingMethod = "subscribe";
         int numOfInvocations = 1;
         String mainMethodFound = "updateCheckpointAsync";
         String objectType = "EventBatchContext";
 
-        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+        verifyProblemRegistered(mockSubscribeVisitor, packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
     /**
-     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncBlockVisitor class.
      * The test checks if the problem is registered when the following method is block.
      * A problem should NOT be registered in this case.
      */
     @Test
     public void testWithBlock() {
+
+        BlockVisitor mockBlockVisitor = new BlockVisitor(mockHolder, true);
+
         String packageName = "com.azure";
         String followingMethod = "block";
         int numOfInvocations = 0;
         String mainMethodFound = "updateCheckpointAsync";
         String objectType = "EventBatchContext";
 
-        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+        verifyProblemRegistered(mockBlockVisitor, packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
     /**
-     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncBlockVisitor class.
      * The test checks if the problem is registered when the following method is null.
      * A problem should be registered in this case -- there is no 'block' or 'block(timeout)' method following the 'updateCheckpointAsync' method.
      */
     @Test
     public void testWithNullFollowingMethod() {
+
+        BlockVisitor mockBlockVisitor = new BlockVisitor(mockHolder, true);
+
         String packageName = "com.azure";
         String followingMethod = null;
         int numOfInvocations = 1;
         String mainMethodFound = "updateCheckpointAsync";
         String objectType = "EventBatchContext";
 
-        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+        verifyProblemRegistered(mockBlockVisitor, packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
     /**
-     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncVisitor class.
-     * The test checks if the problem is registered when the package name is wrong.
-     * A problem should NOT be registered in this case.
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncSubscribeVisitor class.
+     * The test checks if the problem is registered when the following method is null.
+     * A problem should NOT be registered in this case because the 'subscribe' method is not called
      */
     @Test
-    public void testWithWrongPackage() {
-        String packageName = "com.microsoft.azure";
-        String followingMethod = "block";
+    public void testSubscribeCheckerWithNullFollowingMethod() {
+
+        SubscribeVisitor mockSubscribeVisitor = new SubscribeVisitor(mockHolder, true);
+
+        String packageName = "com.azure";
+        String followingMethod = null;
         int numOfInvocations = 0;
         String mainMethodFound = "updateCheckpointAsync";
         String objectType = "EventBatchContext";
 
-        verifyProblemRegistered(packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
+        verifyProblemRegistered(mockSubscribeVisitor, packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
     /**
-     * This creates a new UpdateCheckpointAsyncVisitor object.
+     * This test method tests the visitMethodCallExpression method of the UpdateCheckpointAsyncBlockVisitor class.
+     * The test checks if the problem is registered when the package name is not com.azure....
+     * A problem should NOT be registered in this case.
      */
-    private JavaElementVisitor createVisitor() {
-        UpdateCheckpointAsyncVisitor mockVisitor = new UpdateCheckpointAsyncVisitor(mockHolder, true);
-        return mockVisitor;
+    @Test
+    public void testWithWrongPackage() {
+
+        BlockVisitor mockBlockVisitor = new BlockVisitor(mockHolder, true);
+
+        String packageName = "com.microsoft.azure";
+        String followingMethod = "block";
+        int numOfInvocations = 0;
+        String mainMethodFound = "updateCheckpointAsync";
+        String objectType = "EventBatchContext";
+
+        verifyProblemRegistered(mockBlockVisitor, packageName, mainMethodFound, numOfInvocations, followingMethod, objectType);
     }
 
     /**
      * This method verifies if the problem is registered with the ProblemsHolder.
      */
-    private void verifyProblemRegistered(String packageName, String mainMethodFound, int numOfInvocations, String followingMethod, String objectType) {
+    private void verifyProblemRegistered(JavaElementVisitor mockVisitor, String packageName, String mainMethodFound, int numOfInvocations, String followingMethod, String objectType) {
 
         PsiReferenceExpression mockReferenceExpression = mock(PsiReferenceExpression.class);
 

From 164f0182d8199abfedf20034bfe1724b8fb493d8 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 17:03:48 -0700
Subject: [PATCH 114/144] refactor to create abstract base class for 2 checkers

---
 .../UpdateCheckpointAsyncBlockChecker.java    | 92 +++++++++++++++++++
 ...UpdateCheckpointAsyncSubscribeChecker.java | 91 ++++++++++++++++++
 2 files changed, 183 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
new file mode 100644
index 00000000000..04e215bf8e5
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
@@ -0,0 +1,92 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiMethodCallExpression;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * This class extends the AbstractUpdateCheckpointChecker to check for the use of the updateCheckpointAsync() method call in the code.
+ * If the method is called from an EventBatchContext object and the following method is not `block` or `block_with_timeout`,
+ * a problem is registered with the suggestion message.
+ */
+public class UpdateCheckpointAsyncBlockChecker extends AbstractUpdateCheckpointAsyncChecker {
+
+    /**
+     * This method creates the visitor for the inspection tool.
+     *
+     * @param holder     ProblemsHolder to register problems
+     * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type. - This parameter is not used in the method but is required by the method signature.
+     * @return PsiElementVisitor visitor to inspect elements in the code
+     */
+    @Override
+    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        return new BlockVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * This class extends the UpdateCheckpointAsyncVisitorBase to visit the elements in the code.
+     * It checks if the method call is updateCheckpointAsync() and if the following method is not `block` or `block_with_timeout`.
+     * If both conditions are met, a problem is registered with the suggestion message.
+     */
+    static class BlockVisitor extends UpdateCheckpointAsyncVisitorBase {
+
+        /**
+         * Constructor to initialize the visitor with the holder and isOnTheFly flag.
+         *
+         * @param holder     ProblemsHolder to register problems
+         * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type.
+         */
+        BlockVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            super(holder, isOnTheFly);
+        }
+
+        // Define constants for string literals
+        protected static final RuleConfig RULE_CONFIG;
+        protected static final boolean SKIP_WHOLE_RULE;
+
+        static {
+            final String ruleName = "UpdateCheckpointAsyncBlockChecker";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+            // Get the RuleConfig object for the rule
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getAntiPatternMessageMap().isEmpty();
+        }
+
+        /**
+         * This method visits the method call expressions in the code.
+         * It checks if the method call is updateCheckpointAsync() and if the following method is not `block` or `block_with_timeout`.
+         * If both conditions are met, a problem is registered with the suggestion message.
+         *
+         * @param expression The method call expression to visit
+         */
+        @Override
+        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+            super.visitMethodCallExpression(expression);
+
+            // Check if the rule should be skipped
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
+            if (expression.getMethodExpression() == null || expression.getMethodExpression().getReferenceName() == null) {
+                return;
+            }
+
+            // Check if the method call is updateCheckpointAsync()
+            if ("updateCheckpointAsync".equals(expression.getMethodExpression().getReferenceName())) {
+
+                // Get the method name following the updateCheckpointAsync() method call
+                String followingMethod = getFollowingMethodName(expression);
+
+                // Check if the following method is not `block` or `block_with_timeout` and
+                // Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
+                if ((followingMethod == null || !RULE_CONFIG.getMethodsToCheck().contains(followingMethod)) && isCalledOnEventBatchContext(expression)) {
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                }
+            }
+        }
+    }
+}
+
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
new file mode 100644
index 00000000000..98d12fb225e
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
@@ -0,0 +1,91 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiMethodCallExpression;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * This class extends the AbstractUpdateCheckpointChecker class to check for the usage of the updateCheckpointAsync() method call in the code.
+ * The visitor inspects the method call expressions and checks if the method call is updateCheckpointAsync().
+ * If the method call is updateCheckpointAsync() and the following method is subscribe, a problem is registered.
+ */
+public class UpdateCheckpointAsyncSubscribeChecker extends AbstractUpdateCheckpointAsyncChecker {
+
+    /**
+     * This method creates the visitor for the inspection tool.
+     *
+     * @param holder     ProblemsHolder to register problems
+     * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type. - This parameter is not used in the method but is required by the method signature.
+     * @return PsiElementVisitor visitor to inspect elements in the code
+     */
+    @Override
+    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        return new SubscribeVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * This class extends the UpdateCheckpointAsyncVisitorBase to visit the elements in the code.
+     * It checks if the method call is updateCheckpointAsync() and if the following method is `subscribe`.
+     * If both conditions are met, a problem is registered with the suggestion message.
+     */
+    static class SubscribeVisitor extends UpdateCheckpointAsyncVisitorBase {
+
+        /**
+         * Constructor to initialize the visitor with the holder and isOnTheFly flag.
+         *
+         * @param holder     ProblemsHolder to register problems
+         * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type.
+         */
+        SubscribeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            super(holder, isOnTheFly);
+        }
+
+        // Define constants for string literals
+        protected static final RuleConfig RULE_CONFIG;
+        protected static final boolean SKIP_WHOLE_RULE;
+
+        static {
+            final String ruleName = "UpdateCheckpointAsyncSubscribeChecker";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+            // Get the RuleConfig object for the rule
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getAntiPatternMessageMap().isEmpty();
+        }
+
+        /**
+         * This method visits the method call expressions in the code.
+         * It checks if the method call is updateCheckpointAsync() and if the following method is `subscribe`.
+         * If both conditions are met, a problem is registered with the suggestion message.
+         *
+         * @param expression The method call expression to inspect
+         */
+        @Override
+        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+            super.visitMethodCallExpression(expression);
+
+            // Check if the rule should be skipped
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
+            if (expression.getMethodExpression() == null || expression.getMethodExpression().getReferenceName() == null) {
+                return;
+            }
+
+            // Check if the method call is updateCheckpointAsync()
+            if ("updateCheckpointAsync".equals(expression.getMethodExpression().getReferenceName())) {
+
+                // Get the method name following the updateCheckpointAsync() method call
+                String followingMethod = getFollowingMethodName(expression);
+
+                // Check if the following method is `subscribe` and
+                // Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
+                if (RULE_CONFIG.getMethodsToCheck().get(0).equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                }
+            }
+        }
+    }
+}

From 1823d1c26ec222a88a51c80811295b6e384f08ab Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Fri, 19 Jul 2024 17:35:45 -0700
Subject: [PATCH 115/144] rename ruleConfigs.json for consistency

---
 .../buildtool/DisableAutoCompleteCheck.java   |  2 +-
 .../buildtool/DynamicClientCreationCheck.java |  4 +-
 .../GetSyncPollerOnPollerFluxCheck.java       |  2 +-
 .../HardcodedAPIKeysAndTokensCheck.java       |  2 +-
 .../azure/sdk/buildtool/RuleConfigLoader.java | 32 ++++--------
 .../buildtool/ServiceBusReceiveModeCheck.java |  2 +-
 .../ServiceBusReceiverAsyncClientCheck.java   |  2 +-
 .../StorageUploadWithoutLengthCheck.java      |  2 +-
 .../UpdateCheckpointAsyncBlockChecker.java    |  2 +-
 ...UpdateCheckpointAsyncSubscribeChecker.java |  2 +-
 .../main/resources/META-INF/ruleConfigs.json  | 50 +++++++++----------
 11 files changed, 45 insertions(+), 57 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
index 830e25a2c05..d769c3bb692 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DisableAutoCompleteCheck.java
@@ -124,7 +124,7 @@ private void processVariableDeclaration(PsiVariable variable) {
                 // Process the new expression initialization
                 if (!isAutoCompleteDisabled((PsiMethodCallExpression) initializer)) {
                     // Register a problem if the auto-complete feature is not disabled
-                    holder.registerProblem(initializer, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(initializer, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index f0159735784..625f303908c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -127,7 +127,7 @@ private void checkClientCreation(PsiStatement blockChild) {
 
                 // Check if the right-hand side is a method call expression
                 if (rhs != null && isClientCreationMethod((PsiMethodCallExpression) rhs)) {
-                    holder.registerProblem(rhs, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(rhs, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             } else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check for the declaration statement
 
@@ -152,7 +152,7 @@ private void checkClientCreation(PsiStatement blockChild) {
                     // Check if the initializer is a method call expression
                     PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression) initializer;
                     if (isClientCreationMethod(methodCallExpression)) {
-                        holder.registerProblem(methodCallExpression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                        holder.registerProblem(methodCallExpression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                     }
                 }
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
index 074b75235ee..78c25779ba1 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GetSyncPollerOnPollerFluxCheck.java
@@ -95,7 +95,7 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 boolean isAsyncContext = checkIfAsyncContext(methodCall);
 
                 if (isAsyncContext && isAzureClient(methodCall)) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
index b3ee93df9e5..84a6ce7c527 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
@@ -76,7 +76,7 @@ public void visitElement(@NotNull PsiElement element) {
                 // Check if the class reference is not null, the qualifier name starts with "com.azure" and
                 // the class reference is in the list of clients to check
                 if (newExpression.getClassReference() != null && newExpression.getClassReference().getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && RULE_CONFIG.getServicesToCheck().contains(classReference)) {
-                    this.holder.registerProblem(newExpression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    this.holder.registerProblem(newExpression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 64fb6f2e272..6ecdb247c48 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -144,23 +144,18 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
             String fieldName = reader.getFieldName();
             // Check the field name and set the corresponding field in the RuleConfig object
             switch (fieldName) {
-                case "methods_to_check":
+                case "methodsToCheck":
                     methodsToCheck = getListFromJsonArray(reader);
                     break;
-                case "anti_pattern_message":
+                case "antiPatternMessage":
                     antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
                     break;
-                case "clients_to_check":
+                case "clientsToCheck":
                     clientsToCheck = getListFromJsonArray(reader);
                     break;
-                case "services_to_check":
+                case "servicesToCheck":
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
-                case "anti_pattern_message_map":
-                    // Move to the next token to process the nested object
-                    reader.nextToken();
-                    antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
-                    break;
                 default:
                     if (fieldName.endsWith("Check")) {
                         // Move to the next token to process the nested object
@@ -209,7 +204,7 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
      * The anti-pattern messages can be for a set of methods, clients, or services
      * The anti-pattern messages can also be for specific rules like "no_block" and "with_subscribe"
      *
-     * @param reader - the JsonReader object to read the JSON file
+     * @param reader                - the JsonReader object to read the JSON file
      * @param antiPatternMessageMap - the map to store the anti-pattern messages
      * @return Map of strings parsed from the JSON object
      * @throws IOException - if there is an error reading the file
@@ -225,19 +220,12 @@ private Map<String, String> getMapFromJsonObject(JsonReader reader, Map<String,
             // Get the field name
             String fieldName = reader.getFieldName();
             switch (fieldName) {
-                case "methods_to_check":
+                case "methodsToCheck":
                     identifiersToCheck = getListFromJsonArray(reader).get(0);
                     break;
-                case "anti_pattern_message":
+                case "antiPatternMessage":
                     antiPatternMessage = reader.getString();
                     break;
-                case "no_block":
-                case "with_subscribe":
-                    reader.nextToken();
-                    antiPatternMessage = reader.getString();
-                    if (antiPatternMessage != null) {
-                        antiPatternMessageMap.put(fieldName, antiPatternMessage);
-                    }
                 default:
                     reader.skipChildren();
                     break;
@@ -248,15 +236,15 @@ private Map<String, String> getMapFromJsonObject(JsonReader reader, Map<String,
                 // This map is for base classes that have a set of discouraged identifiers and a corresponding set of antipattern messages
                 if (identifiersToCheck != null) {
                     antiPatternMessageMap.put(identifiersToCheck, antiPatternMessage);
-                } else if (fieldName != "no_block" && fieldName != "with_subscribe") {
-
+                    System.out.println(antiPatternMessageMap);
+                } else {
                     // This map is for single anti-pattern messages of a particular rule
                     antiPatternMessageMap.put(fieldName, antiPatternMessage);
                     return antiPatternMessageMap;
                 }
             }
         }
-        // This map is to return "no_block" and "with_subscribe" anti-pattern messages
+        // This map is to return mapped anti-pattern messages that have a set of discouraged identifiers and a corresponding set of antipattern messages
         return antiPatternMessageMap;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
index f1331776b12..08886e9f260 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiveModeCheck.java
@@ -174,7 +174,7 @@ private void determineReceiveMode(PsiMethodCallExpression methodCall) {
 
                 // If the receive mode is set to PEEK_LOCK and the prefetch count is set to a value greater than 1, register a problem
                 if (prefetchCountValue.isPresent() && prefetchCountValue.getAsInt() > 1 && isReceiveModePeekLock && prefetchCountMethod != null) {
-                    holder.registerProblem(prefetchCountMethod, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(prefetchCountMethod, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                     return;
                 }
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
index a8a5a105479..250f59ddacc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/ServiceBusReceiverAsyncClientCheck.java
@@ -30,7 +30,7 @@ public class ServiceBusReceiverAsyncClientCheck extends LocalInspectionTool {
 
         SKIP_WHOLE_RULE = ruleConfig == RuleConfig.EMPTY_RULE;
         CLIENT_NAME = ruleConfig.getClientsToCheck().get(0);
-        SUGGESTION = ruleConfig.getAntiPatternMessageMap().get("anti_pattern_message");
+        SUGGESTION = ruleConfig.getAntiPatternMessageMap().get("antiPatternMessage");
     }
 
     /**
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
index 36c74288348..ff77e0ca84a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/StorageUploadWithoutLengthCheck.java
@@ -85,7 +85,7 @@ public void visitMethodCallExpression(PsiMethodCallExpression expression) {
                     }
                 }
                 if (!hasLengthArg) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         };
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
index 04e215bf8e5..4df918a4b21 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
@@ -83,7 +83,7 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 // Check if the following method is not `block` or `block_with_timeout` and
                 // Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
                 if ((followingMethod == null || !RULE_CONFIG.getMethodsToCheck().contains(followingMethod)) && isCalledOnEventBatchContext(expression)) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
index 98d12fb225e..5e64a1cbaac 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
@@ -83,7 +83,7 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 // Check if the following method is `subscribe` and
                 // Check if the updateCheckpointAsync() method call is called on an EventBatchContext object
                 if (RULE_CONFIG.getMethodsToCheck().get(0).equals(followingMethod) && isCalledOnEventBatchContext(expression)) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("anti_pattern_message"));
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 6e2b47e7c36..7854c25a32b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -1,33 +1,33 @@
 {
   "StorageUploadWithoutLengthCheck": {
-    "methods_to_check": [
+    "methodsToCheck": [
       "upload",
       "uploadWithResponse"
     ],
-    "anti_pattern_message": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
+    "antiPatternMessage": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
   },
   "ServiceBusReceiverAsyncClientCheck": {
-    "clients_to_check": "ServiceBusReceiverAsyncClient",
-    "anti_pattern_message": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
+    "clientsToCheck": "ServiceBusReceiverAsyncClient",
+    "antiPatternMessage": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
   },
   "DisableAutoCompleteCheck": {
-    "methods_to_check": "disableAutoComplete",
-    "clients_to_check": [
+    "methodsToCheck": "disableAutoComplete",
+    "clientsToCheck": [
       "ServiceBusReceiverClient",
       "ServiceBusReceiverAsyncClient",
       "ServiceBusProcessorClient"
     ],
-    "anti_pattern_message": "Auto-complete enabled by default. Use the disableAutoComplete() API call to prevent automatic message completion."
+    "antiPatternMessage": "Auto-complete enabled by default. Use the disableAutoComplete() API call to prevent automatic message completion."
   },
   "DynamicClientCreationCheck": {
-    "methods_to_check": [
+    "methodsToCheck": [
       "buildClient",
       "buildAsyncClient"
     ],
-    "anti_pattern_message": "Dynamic client creation detected. Create a single client instance and reuse it instead."
+    "antiPatternMessage": "Dynamic client creation detected. Create a single client instance and reuse it instead."
   },
   "HardcodedAPIKeysAndTokensCheck": {
-    "services_to_check": [
+    "servicesToCheck": [
       "AzureKeyCredential",
       "AccessToken",
       "KeyCredential",
@@ -38,48 +38,48 @@
       "UsernamePasswordCredentialBuilder",
       "BasicAuthenticationCredential"
     ],
-    "anti_pattern_message": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication.",
+    "antiPatternMessage": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication.",
     "solution": "DefaultAzureCredential is recommended for authentication if the service client supports Token Credential (Entra ID Authentication). If not, then use Azure Key Credential for API key based authentication."
   },
   "GetSyncPollerOnPollerFluxCheck": {
-    "methods_to_check": "getSyncPoller",
-    "anti_pattern_message": "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"
+    "methodsToCheck": "getSyncPoller",
+    "antiPatternMessage": "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"
   },
   "ServiceBusReceiveModeCheck": {
-    "clients_to_check": [
+    "clientsToCheck": [
       "ServiceBusReceiverClient",
       "ServiceBusReceiverAsyncClient",
       "ServiceBusProcessorClient"
     ],
-    "methods_to_check": [
+    "methodsToCheck": [
       "receiveMode",
       "prefetchCount"
     ],
-    "anti_pattern_message": "A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."
+    "antiPatternMessage": "A high prefetch value in PEEK_LOCK detected. We recommend a prefetch value of 0 or 1 for efficient message retrieval."
   },
   "DetectDiscouragedAPIUsageCheck": {
     "ConnectionStringCheck": {
-      "methods_to_check": "connectionString",
-      "anti_pattern_message": "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
+      "methodsToCheck": "connectionString",
+      "antiPatternMessage": "Connection String detected. Use DefaultAzureCredential for Azure service client authentication instead if the service client supports Token Credential (Entra ID Authentication).",
       "solution": "DefaultAzureCredential is recommended if the service client supports Token Credential (Entra ID Authentication). if not, then use Azure Key Credential / Connection Strings based authentication"
     },
     "GetCompletionsInChatApplicationsCheck": {
-      "methods_to_check": "getCompletions",
-      "anti_pattern_message": "getCompletions API detected. Use the getChatCompletions API instead."
+      "methodsToCheck": "getCompletions",
+      "antiPatternMessage": "getCompletions API detected. Use the getChatCompletions API instead."
     }
   },
   "AbstractUpdateCheckpointAsyncChecker": {
-    "methods_to_check": "updateCheckpointAsync"
+    "methodsToCheck": "updateCheckpointAsync"
   },
   "UpdateCheckpointAsyncSubscribeChecker": {
-    "methods_to_check": "subscribe",
-    "anti_pattern_message": "Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous version `updateCheckpoint()`"
+    "methodsToCheck": "subscribe",
+    "antiPatternMessage": "Instead of `subscribe()`, call `block()` or `block()` with timeout, or use the synchronous version `updateCheckpoint()`"
   },
   "UpdateCheckpointAsyncBlockChecker": {
-    "methods_to_check": [
+    "methodsToCheck": [
       "block",
       "block_with_timeout"
     ],
-    "anti_pattern_message": "Calling updateCheckpointAsync() without block() will not do anything, use `block()` or `block` operator with a timeout, or consider using the synchronous version `updateCheckpoint()."
+    "antiPatternMessage": "Calling updateCheckpointAsync() without block() will not do anything, use `block()` or `block` operator with a timeout, or consider using the synchronous version `updateCheckpoint()."
   }
 }

From 328854ae0dff6cd43d685b0dae2fbb372222d82b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 21 Jul 2024 16:37:55 -0700
Subject: [PATCH 116/144] implement versioning rules with tests

---
 .../build.gradle                              |   2 +
 .../AbstractLibraryVersionCheck.java          | 137 +++++++++++
 .../sdk/buildtool/GitHubFileFetcher.java      | 168 ++++++++++++++
 .../IncompatibleDependencyCheck.java          | 208 +++++++++++++++++
 .../buildtool/UpgradeLibraryVersionCheck.java | 155 +++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  26 +++
 .../main/resources/META-INF/ruleConfigs.json  |   6 +
 .../AbstractLibraryVersionCheckTest.java      | 219 ++++++++++++++++++
 8 files changed, 921 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 089526d8f8f..3c81c9d147d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -15,6 +15,8 @@ dependencies {
     testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
     testImplementation group: 'org.mockito', name: 'mockito-core'
     implementation group: 'com.azure', name: 'azure-json', version: '1.1.0'
+    implementation group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.17.1'
+    implementation group: 'com.squareup.okhttp3', name: 'okhttp', version: '5.0.0-alpha.14'
 }
 
 tasks.named('test', Test) {
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
new file mode 100644
index 00000000000..8f61ae853a7
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
@@ -0,0 +1,137 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.lang.StdLanguages;
+import com.intellij.psi.FileViewProvider;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.xml.XmlFile;
+import com.intellij.psi.xml.XmlTag;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.idea.maven.project.MavenProjectsManager;
+
+import java.io.IOException;
+
+/**
+ * Abstract class for the library version check inspection.
+ * The UpgradeLibraryVersionCheck and IncompatibleDependencyCheck classes extend this class.
+ * <p>
+ * The UpgradeLibraryVersionCheck class checks the version of the libraries in the pom.xml file against the recommended version.
+ * The IncompatibleDependencyCheck class checks the version of the libraries in the pom.xml file against compatible versions.
+ */
+public abstract class AbstractLibraryVersionCheck extends LocalInspectionTool {
+
+    /**
+     * Abstract method to build the specific visitor for the inspection.
+     *
+     * @param holder     The holder for the problems found
+     * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
+     * @return The visitor for the inspection
+     */
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return createVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * Creates the specific visitor for the inspection.
+     *
+     * @param holder     The holder for the problems found
+     * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
+     * @return The specific visitor for the inspection
+     */
+    protected abstract PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly);
+
+    /**
+     * Abstract class for the library version visitor.
+     * The UpgradeLibraryVersionVisitor and IncompatibleDependencyVisitor classes extend this class.
+     * <p>
+     * The UpgradeLibraryVersionVisitor class checks the version of the libraries in the pom.xml file against the recommended version.
+     * The IncompatibleDependencyVisitor class checks the version of the libraries in the pom.xml file against compatible versions.
+     */
+    static abstract class LibraryVersionVisitorBase extends PsiElementVisitor {
+
+        // The holder for the problems found
+        protected final ProblemsHolder holder;
+
+        /**
+         * Constructs a new instance of the visitor.
+         *
+         * @param holder     The holder for the problems found
+         * @param isOnTheFly boolean to check if the inspection is on the fly
+         */
+        protected LibraryVersionVisitorBase(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+        }
+
+        /**
+         * Method to check the pom.xml file for the libraries and their versions.
+         *
+         * @param file   The pom.xml file to check for the libraries and their versions
+         * @param holder The holder for the problems found in the file
+         * @throws IOException If an error occurs while reading the file
+         */
+        protected void checkPomXml(XmlFile file, ProblemsHolder holder) throws IOException {
+
+            // Get the MavenProjectsManager for the file
+            MavenProjectsManager mavenProjectsManager = MavenProjectsManager.getInstance(file.getProject());
+            if (!mavenProjectsManager.isMavenizedProject()) {
+                return;
+            }
+
+            // Get the root tag of the file
+            FileViewProvider viewProvider = file.getViewProvider();
+            XmlFile xmlFile = (XmlFile) viewProvider.getPsi(StdLanguages.XML);
+            XmlTag rootTag = xmlFile.getRootTag();
+
+            // Check the dependencies in the file and get the groupId, artifactId, and version
+            if (rootTag != null && "project".equals(rootTag.getName())) {
+                XmlTag[] dependenciesTags = rootTag.findSubTags("dependencies");
+                for (XmlTag dependenciesTag : dependenciesTags) {
+                    XmlTag[] dependencyTags = dependenciesTag.findSubTags("dependency");
+                    for (XmlTag dependencyTag : dependencyTags) {
+                        XmlTag groupIdTag = dependencyTag.findFirstSubTag("groupId");
+                        XmlTag artifactIdTag = dependencyTag.findFirstSubTag("artifactId");
+                        XmlTag versionTag = dependencyTag.findFirstSubTag("version");
+
+                        if (groupIdTag != null && artifactIdTag != null && versionTag != null) {
+                            String groupId = groupIdTag.getValue().getText();
+                            String artifactId = artifactIdTag.getValue().getText();
+                            String currentVersion = versionTag.getValue().getText();
+
+                            // Get the full name of the library
+                            String fullName = groupId + ":" + artifactId;
+
+                            // Determine if the version should be flagged
+                            checkAndFlagVersion(fullName, currentVersion, holder, versionTag);
+                        }
+                    }
+                }
+            }
+        }
+
+        /**
+         * Method to get the formatted message for the anti-pattern.
+         *
+         * @param fullName           The full name of the library eg "com.azure:azure-core"
+         * @param recommendedVersion The recommended version of the library eg "1.0"
+         * @param RULE_CONFIG        The rule configuration object
+         * @return The formatted message for the anti-pattern with the full name and recommended version
+         */
+        protected static String getFormattedMessage(String fullName, String recommendedVersion, RuleConfig RULE_CONFIG) {
+            return RULE_CONFIG.getAntiPatternMessage().replace("{{fullName}}", fullName).replace("{{recommendedVersion}}", recommendedVersion);
+        }
+
+        /**
+         * Abstract method to check the version of the library and flag it if necessary.
+         *
+         * @param fullName       The full name of the library eg "com.azure:azure-core"
+         * @param currentVersion The current version of the library eg "1.0"
+         * @param holder         The holder for the problems found
+         * @param versionElement The element for the version of the library
+         */
+        protected abstract void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionElement) throws IOException;
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
new file mode 100644
index 00000000000..8cb5e8a7e00
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
@@ -0,0 +1,168 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.azure.json.JsonProviders;
+import com.azure.json.JsonReader;
+import com.azure.json.JsonToken;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.logging.Logger;
+
+/**
+ * Class to fetch files from GitHub.
+ * The class fetches .txt and .json files from GitHub and parses them to get the data.
+ * The data is used to check the version of the libraries in the pom.xml file against the recommended version.
+ */
+class GitHubFileFetcher {
+
+    private static final Logger LOGGER = Logger.getLogger(GitHubFileFetcher.class.getName());
+
+    /**
+     * The fetchTxtFileFromGitHub method fetches a .txt file from GitHub and parses it to get the recommended version for each library.
+     * This method is used to fetch the recommended version for the libraries in the pom.xml file. It is used by the UpgradeLibraryVersionCheck inspection.
+     *
+     * @param fileUrl The URL of the .txt file to fetch
+     * @return A map of the recommended version for each library
+     * @throws IOException If an error occurs while reading the file
+     */
+    static Map<String, String> fetchTxtFileFromGitHub(String fileUrl) throws IOException {
+        StringBuilder content = new StringBuilder();
+
+        URL url = new URL(fileUrl);
+
+        HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+        connection.setRequestMethod("GET");
+
+        // Read the file from the URL
+        try (BufferedReader in = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {
+            String inputLine;
+            while ((inputLine = in.readLine()) != null) {
+                if (inputLine.startsWith("#")) {
+                    continue; // Ignore comment lines
+                }
+                content.append(inputLine).append("\n");
+            }
+        } catch (IOException e) {
+            LOGGER.severe("Error reading file from GitHub: " + e);
+        } catch (SecurityException e) {
+            LOGGER.severe("Security exception accessing URL: " + e);
+        } catch (IllegalArgumentException e) {
+            LOGGER.severe("Illegal argument: " + e);
+        } catch (IllegalStateException e) {
+            LOGGER.severe("Illegal state: " + e);
+        } catch (Exception e) {
+            LOGGER.severe("Unexpected error: " + e);
+        } finally {
+            connection.disconnect();
+        }
+        return parseTxtFile(content.toString());
+    }
+
+    /**
+     * The parseTxtFile method parses the content of the .txt file to get the recommended version for each library.
+     * The content of the file is in the format "artifactId: minor version".
+     * The method returns a map where the key is the artifactId and the value is the recommended version.
+     *
+     * @param content The content of the .txt file
+     * @return A map of the recommended version for each library
+     */
+    private static Map<String, String> parseTxtFile(String content) {
+
+        Map<String, String> fileContent = new ConcurrentHashMap<>();
+
+        if (content != null) {
+            String[] lines = content.toString().split("\n");
+
+            for (String line : lines) {
+                String[] parts = line.split(";");
+                if (parts.length > 1) {
+                    String artifactId = parts[0];
+                    String[] versionParts = parts[1].split("\\.");
+                    fileContent.put(artifactId, versionParts[0] + "." + versionParts[1]); // key is artifactId, value is recommended version
+                }
+            }
+        }
+        return fileContent;
+    }
+
+    /**
+     * The loadJsonDataFromUrl method fetches a .json file from GitHub and parses it to get the data.
+     * This method is used to fetch the data for the libraries in the pom.xml file. It is used by the IncompatibleDependencyCheck inspection.
+     *
+     * @param jsonUrl The URL of the .json file to fetch
+     * @return A map of the data for the libraries
+     */
+    static Map<String, Set<String>> loadJsonDataFromUrl(String jsonUrl) {
+
+        HttpURLConnection connection;
+        try {
+            URL url = new URL(jsonUrl);
+            connection = (HttpURLConnection) url.openConnection();
+            connection.setRequestMethod("GET");
+
+            try (InputStream inputStream = connection.getInputStream(); JsonReader jsonReader = JsonProviders.createReader(inputStream)) {
+                return parseJson(jsonReader);
+            }
+        } catch (IOException e) {
+            LOGGER.severe("Error reading file from GitHub: " + e);
+        } catch (SecurityException e) {
+            LOGGER.severe("Security exception accessing URL: " + e);
+        } catch (IllegalArgumentException e) {
+            LOGGER.severe("Illegal argument: " + e);
+        } catch (IllegalStateException e) {
+            LOGGER.severe("Illegal state: " + e);
+        } catch (Exception e) {
+            LOGGER.severe("Unexpected error: " + e);
+        }
+        return new HashMap<>();
+    }
+
+    /**
+     * Method to parse JSON data into a nested map structure
+     * The method reads the JSON data from the JsonReader and parses it to get the data for the libraries.
+     * The data is in a Map<String, Set<String>> format where the key is the group and the value is a set of artifactIds.
+     * For example, the data for the Jackson library is in the format
+     * "jackson_2.10: [com.fasterxml.jackson.core:jackson-annotations, com.fasterxml.jackson.core:jackson-core, com.fasterxml.jackson.core:jackson-databind]".
+     *
+     * @param jsonReader The JsonReader object to read the JSON data
+     * @return A map of the data for the libraries
+     * @throws IOException If an error occurs while reading the JSON data
+     */
+    private static Map<String, Set<String>> parseJson(JsonReader jsonReader) throws IOException {
+        Map<String, Set<String>> versionData = new ConcurrentHashMap<>();
+        // Read the start of the JSON object
+        if (jsonReader.nextToken() == JsonToken.START_OBJECT) {
+            while (jsonReader.nextToken() != JsonToken.END_OBJECT) {
+                // Read the key for the current group (e.g., "jackson_2.10")
+                String groupKey = jsonReader.getFieldName();
+                Set<String> groupSet = new HashSet<>();
+
+                // Ensure we're at the start of the array for the current group
+                if (jsonReader.nextToken() == JsonToken.START_ARRAY) {
+                    while (jsonReader.nextToken() != JsonToken.END_ARRAY) {
+                        // Ensure we're at the start of an object within the array
+                        if (jsonReader.nextToken() == JsonToken.FIELD_NAME) {
+                            // Read the artifactId and version within the object
+                            String groupAndArtifactId = jsonReader.getFieldName();
+                            groupSet.add(groupAndArtifactId);
+                        }
+                        while (jsonReader.nextToken() != JsonToken.END_OBJECT) {
+                            // Do nothing just skip
+                        }
+                    }
+                }
+                versionData.put(groupKey, groupSet);
+            }
+        }
+        return versionData;
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
new file mode 100644
index 00000000000..9b337fb7ae0
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
@@ -0,0 +1,208 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiFile;
+import com.intellij.psi.xml.XmlFile;
+import org.jetbrains.annotations.NotNull;
+
+import java.io.IOException;
+import java.lang.ref.WeakReference;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import java.util.logging.Logger;
+
+/**
+ * Inspection class to check the version of the libraries in the pom.xml file against compatible versions.
+ * The compatible versions are fetched from a file hosted on GitHub.
+ * The compatible versions are compared against the minor version of the library. Minor version is the first two parts of the version number.
+ * If the minor version is different from the compatible version, a warning is flagged and the compatible version is suggested.
+ */
+public class IncompatibleDependencyCheck extends AbstractLibraryVersionCheck {
+
+    /**
+     * Abstract method to build the specific visitor for the inspection.
+     *
+     * @param holder     The holder for the problems found
+     * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
+     * @return The visitor for the inspection
+     */
+    @Override
+    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        return new IncompatibleDependencyVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * Visitor class for the inspection.
+     * Checks the version of the libraries in the pom.xml file against compatible versions.
+     * The compatible versions are fetched from a file hosted on GitHub.
+     * The compatible versions are compared against the minor version of the library. Minor version is the first two parts of the version number.
+     * If the minor version is different from the compatible version, a warning is flagged and the compatible version is suggested.
+     */
+    static class IncompatibleDependencyVisitor extends LibraryVersionVisitorBase {
+
+        // Set to store the encountered version groups
+        static Set<String> encounteredVersionGroups = new HashSet<>();
+        private static final Logger LOGGER = Logger.getLogger(IncompatibleDependencyCheck.class.getName());
+
+        /**
+         * Constructs a new instance of the IncompatibleDependencyVisitor.
+         *
+         * @param holder     The holder for the problems found
+         * @param isOnTheFly boolean to check if the inspection is on the fly
+         */
+        IncompatibleDependencyVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            super(holder, isOnTheFly);
+        }
+
+        // Map to store the compatible versions for each library
+        private static WeakReference<Map<String, Set<String>>> FILE_CONTENT_REF;
+        private static final RuleConfig RULE_CONFIG;
+        private static final boolean SKIP_WHOLE_RULE;
+
+
+        static {
+            final String ruleName = "IncompatibleDependencyCheck";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+            // Get the RuleConfig object for the rule
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE;
+        }
+
+        /**
+         * Method to check the pom.xml file for the library version.
+         *
+         * @param file The pom.xml file to check
+         */
+        @Override
+        public void visitFile(@NotNull PsiFile file) {
+            super.visitFile(file);
+
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+            if (!file.getName().equals("pom.xml")) {
+                return;
+            }
+            if (file instanceof XmlFile && file.getName().equals("pom.xml")) {
+
+                // Check the pom.xml file for the library version
+                try {
+                    checkPomXml((XmlFile) file, holder);
+                } catch (IOException e) {
+                    LOGGER.severe("Error checking pom.xml file: " + e);
+                }
+            }
+        }
+
+
+        /**
+         * Method to check the version of the dependency found in the project code against the compatible versions.
+         * If the version is not compatible, a warning is flagged and the compatible version is suggested.
+         *
+         * @param fullName       The full name of the library eg "com.azure:azure-core"
+         * @param currentVersion The current version of the library
+         * @param holder         The holder for the problems found
+         * @param versionElement The version element in the pom.xml file to check
+         */
+        @Override
+        protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionElement) {
+
+            // get version group of the dependency found in the project code
+            String versionGroup = getGroupVersion(fullName, currentVersion);
+
+            if (versionGroup == null) {
+                return;
+            }
+
+            // add an encountered version group to the encountered version groups
+            if (encounteredVersionGroups.isEmpty()) {
+                encounteredVersionGroups.add(versionGroup);
+            }
+
+            // check if the encountered version group is not already in the encountered version groups
+            for (String encounteredVersionGroup : encounteredVersionGroups) {
+
+                // check if the encountered version group is not the same as the current version group
+                // and the encountered version group starts with the version group's substring
+                // eg if versionGroup = "jackson_2.10" and encounteredVersionGroup = "jackson_2.10, no problem is flagged
+                // if versionGroup = "jackson_2.10" and encounteredVersionGroup = "jackson_2.11", a problem is flagged
+
+                // The substring check is used to determine if versionGroup and encounteredVersionGroup are in the same library
+                if (!encounteredVersionGroup.equals(versionGroup) && encounteredVersionGroup.startsWith(versionGroup.substring(0, versionGroup.lastIndexOf("_")))) {
+                    String recommendedVersion = encounteredVersionGroup.substring(encounteredVersionGroup.lastIndexOf("_") + 1);
+
+                    // Flag the version if the minor version is different from the recommended version
+                    String message = getFormattedMessage(fullName, recommendedVersion, RULE_CONFIG);
+                    holder.registerProblem(versionElement, message);
+                }
+            }
+        }
+
+        /**
+         * Method to get the version group for the library.
+         * The version group is used to get the compatible versions for the library.
+         * The version group is determined by the major and minor version of the library.
+         * Eg if the major version is 2 and the minor version is 10, the version group is "jackson_2.10".
+         *
+         * @param fullName       The full name of the library eg "com.azure:azure-core"
+         * @param currentVersion The current version of the library
+         * @return The version group for the library
+         */
+        private static String getGroupVersion(String fullName, String currentVersion) {
+
+            // Split currentVersion to extract major and minor version
+            String[] versionParts = currentVersion.split("\\.");
+            String majorVersion = versionParts[0];
+            String minorVersion = versionParts.length > 1 ? versionParts[1] : "";
+            String versionSuffix = "_" + majorVersion + "." + minorVersion;
+
+            // Search the file content for the version group
+            String versionGroup = null;
+
+            for (Map.Entry<String, Set<String>> entry : getFileContent().entrySet()) {
+
+                // Check if the set of artifactIds contains the fullName and the corresponding key ends with the versionSuffix
+                // This will be the version group of the dependency
+                if (entry.getValue().contains(fullName) && entry.getKey().endsWith(versionSuffix)) {
+                    versionGroup = entry.getKey();
+                    break;
+                }
+            }
+            if (versionGroup != null) {
+                return versionGroup;
+            } else {
+                return null;
+            }
+        }
+
+        /**
+         * Method to get the content of the file hosted on GitHub.
+         * The file contains the compatible versions for the libraries.
+         * A WeakReference is used to store the content of the file to allow for garbage collection.
+         *
+         * @return The content of the file as a map
+         */
+        private static Map<String, Set<String>> getFileContent() {
+
+            // Load the file content from the URL if it is not already loaded
+
+            Map<String, Set<String>> fileContent = FILE_CONTENT_REF == null ? null : FILE_CONTENT_REF.get();
+
+            if (fileContent == null) {
+                synchronized (IncompatibleDependencyVisitor.class) {
+                    fileContent = FILE_CONTENT_REF == null ? null : FILE_CONTENT_REF.get();
+                    if (fileContent == null) {
+                        String fileUrl = "https://raw.githubusercontent.com/Azure/azure-sdk-for-java/main/eng/versioning/supported_external_dependency_versions.json";
+                        fileContent = GitHubFileFetcher.loadJsonDataFromUrl(fileUrl);
+                        FILE_CONTENT_REF = new WeakReference<>(fileContent);
+                    }
+                }
+            }
+            return fileContent;
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
new file mode 100644
index 00000000000..1eaf296b8c1
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
@@ -0,0 +1,155 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.PsiFile;
+import com.intellij.psi.xml.XmlFile;
+import org.jetbrains.annotations.NotNull;
+
+import java.io.IOException;
+import java.lang.ref.WeakReference;
+import java.util.Map;
+
+/**
+ * Inspection class to check the version of the libraries in the pom.xml file against the recommended version.
+ * The recommended version is fetched from a file hosted on GitHub.
+ * The recommended version is compared against the minor version of the library. Minor version is the first two parts of the version number.
+ * If the minor version is different from the recommended version, a warning is flagged and the recommended version is suggested.
+ */
+public class UpgradeLibraryVersionCheck extends AbstractLibraryVersionCheck {
+
+    /**
+     * Abstract method to build the specific visitor for the inspection.
+     *
+     * @param holder     The holder for the problems found
+     * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
+     * @return The visitor for the inspection
+     */
+    @Override
+    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        return new UpgradeLibraryVersionVisitor(holder, isOnTheFly);
+    }
+
+    /**
+     * Visitor class for the inspection.
+     * Checks the version of the libraries in the pom.xml file against the recommended version.
+     * The recommended version is fetched from a file hosted on GitHub.
+     * The recommended version is compared against the minor version of the library. Minor version is the first two parts of the version number.
+     * If the minor version is different from the recommended version, a warning is flagged and the recommended version is suggested.
+     */
+    static class UpgradeLibraryVersionVisitor extends LibraryVersionVisitorBase {
+
+        /**
+         * Constructs a new instance of the visitor.
+         *
+         * @param holder     The holder for the problems found
+         * @param isOnTheFly boolean to check if the inspection is on the fly
+         */
+        UpgradeLibraryVersionVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            super(holder, isOnTheFly);
+        }
+
+        // Map to store the recommended version for each library
+        private static WeakReference<Map<String, String>> LIBRARY_RECOMMENDED_VERSION_MAP_REF;
+
+        private static final RuleConfig RULE_CONFIG;
+        private static final boolean SKIP_WHOLE_RULE;
+
+        static {
+            final String ruleName = "UpgradeLibraryVersionCheck";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+            // Get the RuleConfig object for the rule
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG == RuleConfig.EMPTY_RULE;
+        }
+
+        /**
+         * Visitor to check the pom.xml file for the library version.
+         *
+         * @param file The pom.xml file
+         */
+        @Override
+        public void visitFile(@NotNull PsiFile file) {
+            super.visitFile(file);
+
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
+            if (!file.getName().equals("pom.xml")) {
+                return;
+            }
+
+            if (file instanceof XmlFile && file.getName().equals("pom.xml")) {
+                try {
+                    checkPomXml((XmlFile) file, holder);
+                } catch (IOException e) {
+                    throw new RuntimeException(e);
+                }
+            }
+        }
+
+        /**
+         * Method to check the version of the library against the recommended version.
+         *
+         * @param fullName       The full name of the library
+         * @param currentVersion The current version of the library
+         * @param holder         The holder for the problems found
+         * @param versionTag     The version tag in the pom.xml file for the library version
+         */
+        @Override
+        protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionTag) throws IOException {
+
+            // Check if the recommended version is available for the library
+            if (!(getLibraryRecommendedVersionMap().containsKey(fullName))) {
+                return;
+            }
+            String recommendedVersion = getLibraryRecommendedVersionMap().get(fullName);
+
+            // Compare minor versions only
+            String[] currentVersionParts = currentVersion.split("\\.");
+
+            // Check if the version is in the correct format
+            if (!(currentVersionParts.length > 1)) {
+                return;
+            }
+
+            // Parse to get the minor version
+            String currentMinor = currentVersionParts[0] + "." + currentVersionParts[1];
+
+            // Flag the version if the minor version is different from the recommended version
+            if (!currentMinor.equals(recommendedVersion)) {
+                holder.registerProblem(versionTag, getFormattedMessage(fullName, recommendedVersion, RULE_CONFIG));
+            }
+        }
+
+        /**
+         * Method to get the recommended version for each library from the file hosted on GitHub.
+         * The file is fetched only once and the content is stored in a WeakReference.
+         * A WeakReference is used to allow the garbage collector to collect the content if necessary.
+         * If the content is not available in the WeakReference, the file is fetched again.
+         *
+         * @return The map of the recommended version for each library
+         * @throws IOException If there is an error in fetching the file from the URL
+         */
+        private static Map<String, String> getLibraryRecommendedVersionMap() throws IOException {
+
+            // Load the file content from the URL if it is not already loaded
+            Map<String, String> fileContent = LIBRARY_RECOMMENDED_VERSION_MAP_REF == null ? null : LIBRARY_RECOMMENDED_VERSION_MAP_REF.get();
+
+            if (fileContent == null) {
+                synchronized (IncompatibleDependencyCheck.IncompatibleDependencyVisitor.class) {
+                    fileContent = LIBRARY_RECOMMENDED_VERSION_MAP_REF == null ? null : LIBRARY_RECOMMENDED_VERSION_MAP_REF.get();
+                    if (fileContent == null) {
+                        String fileUrl = "https://raw.githubusercontent.com/Azure/azure-sdk-for-java/main/eng/versioning/version_client.txt";
+                        fileContent = GitHubFileFetcher.fetchTxtFileFromGitHub(fileUrl);
+                        LIBRARY_RECOMMENDED_VERSION_MAP_REF = new WeakReference<>(fileContent);
+                    }
+                }
+            }
+            return fileContent;
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 09b87f7d4e6..d1dbdaca51e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -121,5 +121,31 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.GetSyncPollerOnPollerFluxCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="XML"
+                shortName="UpgradeLibraryVersionCheck"
+                displayName="Upgrade Library Version Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpgradeLibraryVersionCheck">
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpgradeLibraryVersionCheck
+            </class>
+        </localInspection>
+
+        <localInspection
+                language="XML"
+                shortName="IncompatibleDependencyCheck"
+                displayName="Incompatible Dependency Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.IncompatibleDependencyCheck">
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.IncompatibleDependencyCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index ad6d2a16555..f0ddabbcf61 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -49,5 +49,11 @@
   "GetSyncPollerOnPollerFluxCheck": {
     "methods_to_check": "getSyncPoller",
     "anti_pattern_message": "Use of getSyncPoller() on a PollerFlux detected. Directly use SyncPoller to handle synchronous polling tasks"
+  },
+  "UpgradeLibraryVersionCheck": {
+    "anti_pattern_message": "A newer stable minor version of {{fullName}} is available. We recommend you update to version {{recommendedVersion}}."
+  },
+  "IncompatibleDependencyCheck": {
+    "anti_pattern_message": "The version of {{fullName}} is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group {{recommendedVersion}} to ensure proper functionality."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
new file mode 100644
index 00000000000..758f26f74c1
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
@@ -0,0 +1,219 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.lang.StdLanguages;
+import com.intellij.openapi.project.Project;
+import com.intellij.psi.FileViewProvider;
+import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.xml.XmlFile;
+import com.intellij.psi.xml.XmlTag;
+import com.intellij.psi.xml.XmlTagValue;
+import org.jetbrains.idea.maven.project.MavenProjectsManager;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpgradeLibraryVersionCheck.UpgradeLibraryVersionVisitor;
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.IncompatibleDependencyCheck.IncompatibleDependencyVisitor;
+
+import java.util.Arrays;
+import java.util.HashSet;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+/**
+ * Abstract class for the library version check inspection.
+ * The UpgradeLibraryVersionCheck and IncompatibleDependencyCheck classes extend this class.
+ * <p>
+ * The UpgradeLibraryVersionCheck class checks the version of the libraries in the pom.xml file against the recommended version.
+ * The IncompatibleDependencyCheck class checks the version of the libraries in the pom.xml file against compatible versions.
+ */
+class AbstractLibraryVersionCheckTest {
+
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private PsiElementVisitor mockVisitor;
+
+    @Mock
+    private XmlFile mockFile;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockFile = mock(XmlFile.class);
+
+        // Set the version groups that are "discovered" by the visitor to test the IncompatibleDependencyVisitor
+        IncompatibleDependencyVisitor.encounteredVersionGroups = new HashSet<>(Arrays.asList("jackson_2.10", "gson_2.10"));
+    }
+
+    /**
+     * Test the UpgradeLibraryVersionVisitor with a library that is out of date.
+     * The test checks that the visitor registers a problem when the version of the library is out of date.
+     */
+    @Test
+    public void testUpgradeCheckOutOfDate() {
+
+        UpgradeLibraryVersionVisitor mockVisitor = new UpgradeLibraryVersionVisitor(mockHolder, true);
+        String groupIDValue = "com.azure";
+        String artifactIDValue = "azure-messaging-servicebus";
+        String versionValue = "7.0.0";
+        int numOfInvocations = 1;
+        String recommendedVersion = "7.17";
+
+        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+    }
+
+    /**
+     * Test the UpgradeLibraryVersionVisitor with a library that is up to date.
+     * The test checks that the visitor does not register a problem when the version of the library is up to date.
+     */
+    @Test
+    public void testUpgradeCheckUpToDate() {
+
+        UpgradeLibraryVersionVisitor mockVisitor = new UpgradeLibraryVersionVisitor(mockHolder, true);
+        String groupIDValue = "com.azure";
+        String artifactIDValue = "azure-messaging-servicebus";
+        String versionValue = "7.17.1";
+        int numOfInvocations = 0;
+        String recommendedVersion = "7.17";
+
+        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+    }
+
+    /**
+     * Test the UpgradeLibraryVersionVisitor with a library that has a missing version.
+     * The test checks that the visitor does not register a problem when the version of the library is missing.
+     * A missing version is considered out of scope for this inspection.
+     */
+    @Test
+    public void testUpgradeCheckMissingVersion() {
+        UpgradeLibraryVersionVisitor mockVisitor = new UpgradeLibraryVersionVisitor(mockHolder, true);
+        String groupIDValue = "com.example";
+        String artifactIDValue = "example-lib";
+        String versionValue = "";  // Empty version
+        int numOfInvocations = 0;  // No problems will be registered by this checker because its out of scope
+        String recommendedVersion = null;
+
+        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+    }
+
+    /**
+     * Test the IncompatibleDependencyVisitor with a library that has a different minor version.
+     * The test checks that the visitor registers a problem when the version of the library is different from the recommended version.
+     */
+    @Test
+    public void testIncompatibleDifferentMinorGroup() {
+
+        IncompatibleDependencyVisitor mockVisitor = new IncompatibleDependencyVisitor(mockHolder, true);
+        String groupIDValue = "com.google.code.gson";
+        String artifactIDValue = "gson";
+        String versionValue = "2.9.0";
+        int numOfInvocations = 1;
+        String recommendedVersion = "2.10";
+
+        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+    }
+
+    /**
+     * Test the IncompatibleDependencyVisitor with a library that has the same minor version.
+     * The test checks that the visitor does not register a problem when the version of the library is the same as the recommended version.
+     */
+    @Test
+    public void testIncompatibleCheckSameMinorGroup() {
+
+        IncompatibleDependencyVisitor mockVisitor = new IncompatibleDependencyVisitor(mockHolder, true);
+        String groupIDValue = "com.fasterxml.jackson.core";
+        String artifactIDValue = "jackson-databind";
+        String versionValue = "2.10.0";
+        int numOfInvocations = 0;
+        String recommendedVersion = "2.10";
+
+        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+    }
+
+    /**
+     * Test the IncompatibleDependencyVisitor with a library that is not in the database.
+     * The test checks that the visitor does not register a problem when the library is not in the database.
+     * This is because the visitor only checks for libraries that are in the database.
+     */
+    @Test
+    public void testIncompatibleCheckDifferentMajorVersion() {
+        IncompatibleDependencyVisitor mockVisitor = new IncompatibleDependencyVisitor(mockHolder, true);
+        String groupIDValue = "com.fasterxml.jackson.core";
+        String artifactIDValue = "jackson-databind";
+        String versionValue = "3.0.0";  // Different major version
+        int numOfInvocations = 0;
+        String recommendedVersion = null;
+
+        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+    }
+
+    /**
+     * Helper method to verify the registration of a problem by the visitor.
+     *
+     * @param visitor            The visitor to check the pom.xml file
+     * @param groupIDValue       The group ID of the library
+     * @param artifactIDValue    The artifact ID of the library
+     * @param versionIDValue     The version of the library
+     * @param numOfInvocations   The number of times the visitor should register a problem
+     * @param recommendedVersion The recommended version of the library
+     */
+    private void verifyRegisterProblem(PsiElementVisitor visitor, String groupIDValue, String artifactIDValue, String versionIDValue, int numOfInvocations, String recommendedVersion) {
+
+        Project project = mock(Project.class);
+        MavenProjectsManager mavenProjectsManager = mock(MavenProjectsManager.class);
+        FileViewProvider viewProvider = mock(FileViewProvider.class);
+        XmlTag rootTag = mock(XmlTag.class);
+
+        XmlTag dependenciesTag = mock(XmlTag.class);
+        XmlTag[] dependenciesTags = new XmlTag[]{dependenciesTag};
+
+        XmlTag dependencyTag = mock(XmlTag.class);
+        XmlTag[] dependencyTags = new XmlTag[]{dependencyTag};
+
+        XmlTag groupIdTag = mock(XmlTag.class);
+        XmlTagValue groupIdValue = mock(XmlTagValue.class);
+        XmlTag artifactIdTag = mock(XmlTag.class);
+        XmlTagValue artifactIdValue = mock(XmlTagValue.class);
+        XmlTag versionTag = mock(XmlTag.class);
+        XmlTagValue versionValue = mock(XmlTagValue.class);
+
+        when(mockFile.getName()).thenReturn("pom.xml");
+        when(mockFile.getProject()).thenReturn(project);
+        when(MavenProjectsManager.getInstance(project)).thenReturn(mavenProjectsManager);
+        when(mavenProjectsManager.isMavenizedProject()).thenReturn(true);
+
+        when(mockFile.getViewProvider()).thenReturn(viewProvider);
+        when(viewProvider.getPsi(StdLanguages.XML)).thenReturn(mockFile);
+        when(mockFile.getRootTag()).thenReturn(rootTag);
+        when(rootTag.getName()).thenReturn("project");
+
+        when(rootTag.findSubTags("dependencies")).thenReturn(dependenciesTags);
+        when(dependenciesTag.findSubTags("dependency")).thenReturn(dependencyTags);
+
+        when(dependencyTag.findFirstSubTag("groupId")).thenReturn(groupIdTag);
+        when(dependencyTag.findFirstSubTag("artifactId")).thenReturn(artifactIdTag);
+        when(dependencyTag.findFirstSubTag("version")).thenReturn(versionTag);
+
+        when(groupIdTag.getValue()).thenReturn(groupIdValue);
+        when(artifactIdTag.getValue()).thenReturn(artifactIdValue);
+        when(versionTag.getValue()).thenReturn(versionValue);
+
+        when(groupIdValue.getText()).thenReturn(groupIDValue);
+        when(artifactIdValue.getText()).thenReturn(artifactIDValue);
+        when(versionValue.getText()).thenReturn(versionIDValue);
+
+        visitor.visitFile(mockFile);
+
+        if (visitor instanceof UpgradeLibraryVersionVisitor) {
+            verify(mockHolder, times(numOfInvocations)).registerProblem(versionTag, "A newer stable minor version of " + groupIDValue + ":" + artifactIDValue + " is available. We recommend you update to version " + recommendedVersion + ".");
+        } else if (visitor instanceof IncompatibleDependencyVisitor) {
+            verify(mockHolder, times(numOfInvocations)).registerProblem(versionTag, "The version of " + groupIDValue + ":" + artifactIDValue + " is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group " + recommendedVersion + " to ensure proper functionality.");
+        }
+    }
+}

From 9f3c09b4e9848f7ab2d55c3dcfc7a9f556a4e9e6 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 21 Jul 2024 16:44:08 -0700
Subject: [PATCH 117/144] update to build.gradle

---
 .../azure-intellij-plugin-azure-sdk/build.gradle                | 2 --
 1 file changed, 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
index 3c81c9d147d..089526d8f8f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/build.gradle
@@ -15,8 +15,6 @@ dependencies {
     testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
     testImplementation group: 'org.mockito', name: 'mockito-core'
     implementation group: 'com.azure', name: 'azure-json', version: '1.1.0'
-    implementation group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.17.1'
-    implementation group: 'com.squareup.okhttp3', name: 'okhttp', version: '5.0.0-alpha.14'
 }
 
 tasks.named('test', Test) {

From cc94d942eb885a8c2d279e77054d2a549c11bd04 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 21 Jul 2024 17:09:54 -0700
Subject: [PATCH 118/144] update to README.md

---
 .../azure-intellij-plugin-azure-sdk/README.md | 29 ++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3b50212774b..bc9dfa5b1a7 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -211,4 +211,31 @@ integration, telemetry connectivity, and Azure Toolkit integration.
       batch request.
 - **Severity: WARNING**
 - **Recommendation**: Use Batch Operations: If the SDK provides a batch operation API, use it to perform multiple
-  actions in a single request.
\ No newline at end of file
+  actions in a single request.
+
+11. #### Upgrading library versions if versions in use known to have performance or reliability issues
+
+- **Anti-pattern**: Using library versions known to have performance or reliability issues.
+- **Issue**: Using outdated library versions can lead to performance bottlenecks, security vulnerabilities, and
+  compatibility
+  issues.
+- **Severity: WARNING**
+- **Recommendation**: Upgrade to the Latest Minor Version. It's recommended to upgrade to the latest minor version of
+  the
+  library to benefit from performance improvements, bug fixes, and security patches. Importantly, if you encounter any
+  issues while using Service Bus Clients, you should first attempt to solve them by upgrading to the latest version of
+  the Service Bus SDK. Please refer to
+  the [ServiceBus Azure SDK Java documentation](https://learn.microsoft.com/azure/developer/java/sdk/troubleshooting-messaging-service-bus-overview#upgrade-to-715x-or-latest)
+  for more information on the latest version of the Service Bus SDK.
+
+12. #### Using Incompatible Versions of Dependencies
+
+- **Anti-pattern**: Using incompatible versions of dependencies in the project.
+- **Issue**: Incompatible versions of dependencies can lead to runtime errors, classpath conflicts, and unexpected
+  behavior.
+- **Severity: WARNING**
+- **Recommendation**: Use a consistent version of dependencies across the project. It's recommended to use a consistent
+  version of dependencies across the project to avoid compatibility issues and ensure smooth integration. Please refer
+  to
+  the [Troubleshoot dependency version conflicts documentation](https://learn.microsoft.com/en-us/azure/developer/java/sdk/troubleshooting-dependency-version-conflict)
+  for additional information on resolving dependency version conflicts.

From 7e414b279bdb51ea4ed9db8b2206be8c60685d39 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sun, 21 Jul 2024 17:27:41 -0700
Subject: [PATCH 119/144] update to ruleConfigs.json

---
 .../src/main/resources/META-INF/ruleConfigs.json              | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index ab79bad0f9a..162ba88dace 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -83,9 +83,9 @@
     "anti_pattern_message": "Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: "
   },
   "UpgradeLibraryVersionCheck": {
-    "anti_pattern_message": "A newer stable minor version of {{fullName}} is available. We recommend you update to version {{recommendedVersion}}."
+    "anti_pattern_message": "A newer stable minor version of {{fullName}} is available. We recommend you update to version {{recommendedVersion}}.x"
   },
   "IncompatibleDependencyCheck": {
-    "anti_pattern_message": "The version of {{fullName}} is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group {{recommendedVersion}} to ensure proper functionality."
+    "anti_pattern_message": "The version of {{fullName}} is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group {{recommendedVersion}}.x to ensure proper functionality."
   }
 }

From 9fdc8f0024d52e215349056f5b5d27b8062f6b71 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 22 Jul 2024 09:33:18 -0700
Subject: [PATCH 120/144] update to abstract class

---
 .../AbstractUpdateCheckpointAsyncChecker.java | 183 +++++++-----------
 .../UpdateCheckpointAsyncBlockChecker.java    |  14 +-
 ...UpdateCheckpointAsyncSubscribeChecker.java |  13 +-
 3 files changed, 90 insertions(+), 120 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java
index 2f6c5ebc862..27573835566 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractUpdateCheckpointAsyncChecker.java
@@ -21,139 +21,104 @@
 public abstract class AbstractUpdateCheckpointAsyncChecker extends LocalInspectionTool {
 
     /**
-     * Abstract method to build the specific visitor for the inspection.
-     *
-     * @param holder     The holder for the problems found
-     * @param isOnTheFly boolean to check if the inspection is on the fly
-     * @return The visitor for the inspection
+     * An abstract method to create the visitor for the inspection tool.
+     * This method is implemented by the subclasses to create the visitor for the specific inspection tool.
      */
-    @NotNull
-    @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return createVisitor(holder, isOnTheFly);
+    protected abstract JavaElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly);
+
+    // Define constants for string literals
+    protected static final RuleConfig RULE_CONFIG;
+    protected static final String BLOCK_METHOD = "block";
+    protected static final String BLOCK_WITH_TIMEOUT_METHOD = "block_with_timeout";
+
+    static {
+        final String ruleName = "AbstractUpdateCheckpointAsyncChecker";
+        RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
+
+        // Get the RuleConfig object for the rule
+        RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
     }
 
     /**
-     * Creates the specific visitor for the inspection.
+     * This method checks if the method call is following an updateCheckpointAsync() method call.
+     * If the method call is following an updateCheckpointAsync(), the method name is returned.
      *
-     * @param holder     The holder for the problems found
-     * @param isOnTheFly boolean to check if the inspection is on the fly
-     * @return The specific visitor for the inspection
+     * @param expression The method call expression
+     * @return The method name if the method call is following a specific method call, null otherwise
      */
-    protected abstract PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly);
-
-    /**
-     * This abstract class is a base visitor used to visit Java elements in the code.
-     */
-    static abstract class UpdateCheckpointAsyncVisitorBase extends JavaElementVisitor {
-
-        // Define the holder for the problems found
-        protected final ProblemsHolder holder;
-
-        // Define constants for string literals
-        protected static final RuleConfig RULE_CONFIG;
-        protected static final String BLOCK_METHOD = "block";
-        protected static final String BLOCK_WITH_TIMEOUT_METHOD = "block_with_timeout";
+    protected static String getFollowingMethodName(PsiMethodCallExpression expression) {
+        // Get the parent of the method call expression
+        PsiElement parent = expression.getParent();
 
-        static {
-            final String ruleName = "AbstractUpdateCheckpointAsyncChecker";
-            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
-
-            // Get the RuleConfig object for the rule
-            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
-        }
-
-        /**
-         * Constructs a new instance of the UpdateCheckpointAsyncVisitorBase.
-         *
-         * @param holder     The holder for the problems found
-         * @param isOnTheFly boolean to check if the inspection is on the fly
-         */
-        UpdateCheckpointAsyncVisitorBase(ProblemsHolder holder, boolean isOnTheFly) {
-            this.holder = holder;
+        if (!(parent instanceof PsiReferenceExpression)) {
+            return null;
         }
+        PsiElement grandParent = parent.getParent();
 
-        /**
-         * This method checks if the method call is following an updateCheckpointAsync() method call.
-         * If the method call is following an updateCheckpointAsync(), the method name is returned.
-         *
-         * @param expression The method call expression
-         * @return The method name if the method call is following a specific method call, null otherwise
-         */
-        protected String getFollowingMethodName(PsiMethodCallExpression expression) {
-            // Get the parent of the method call expression
-            PsiElement parent = expression.getParent();
-
-            if (!(parent instanceof PsiReferenceExpression)) {
-                return null;
-            }
-            PsiElement grandParent = parent.getParent();
+        if (grandParent instanceof PsiMethodCallExpression) {
+            PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
 
-            if (grandParent instanceof PsiMethodCallExpression) {
-                PsiMethodCallExpression parentCall = (PsiMethodCallExpression) grandParent;
+            // Get the method name from the parent call
+            String methodName = parentCall.getMethodExpression().getReferenceName();
 
-                // Get the method name from the parent call
-                String methodName = parentCall.getMethodExpression().getReferenceName();
-
-                // Check if the method name is in the list of methods to check
-                if (RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
-                    if (BLOCK_METHOD.equals(methodName)) {
-                        PsiExpressionList arguments = parentCall.getArgumentList();
-                        if (arguments.getExpressions().length == 1 && arguments.getExpressions()[0].getType() != null && arguments.getExpressions()[0].getType().equalsToText("java.time.Duration")) {
-                            return BLOCK_WITH_TIMEOUT_METHOD;
-                        }
+            // Check if the method name is in the list of methods to check
+            if (RULE_CONFIG.getMethodsToCheck().contains(methodName)) {
+                if (BLOCK_METHOD.equals(methodName)) {
+                    PsiExpressionList arguments = parentCall.getArgumentList();
+                    if (arguments.getExpressions().length == 1 && arguments.getExpressions()[0].getType() != null && arguments.getExpressions()[0].getType().equalsToText("java.time.Duration")) {
+                        return BLOCK_WITH_TIMEOUT_METHOD;
                     }
                 }
-                return methodName;
             }
-            return null;
+            return methodName;
         }
+        return null;
+    }
 
-        /**
-         * This method checks if the method call is called on an EventBatchContext object from the Azure SDK.
-         *
-         * @param expression The method call expression
-         * @return True if the method call is called on an EventBatchContext object from the Azure SDK, false otherwise
-         */
-        protected boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression) {
-            // Get the qualifier expression from the method call expression
-            PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
-
-            if (!(qualifier instanceof PsiReferenceExpression)) {
-                return false;
-            }
+    /**
+     * This method checks if the method call is called on an EventBatchContext object from the Azure SDK.
+     *
+     * @param expression The method call expression
+     * @return True if the method call is called on an EventBatchContext object from the Azure SDK, false otherwise
+     */
+    protected static boolean isCalledOnEventBatchContext(PsiMethodCallExpression expression) {
+        // Get the qualifier expression from the method call expression
+        PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
 
-            // Resolve the qualifier element
-            PsiElement resolvedElement = ((PsiReferenceExpression) qualifier).resolve();
+        if (!(qualifier instanceof PsiReferenceExpression)) {
+            return false;
+        }
 
-            // Check if the resolved element is a parameter
-            if (!(resolvedElement instanceof PsiParameter)) {
-                return false;
-            }
+        // Resolve the qualifier element
+        PsiElement resolvedElement = ((PsiReferenceExpression) qualifier).resolve();
 
-            // Check if the resolved element is a class type
-            PsiParameter parameter = (PsiParameter) resolvedElement;
-            PsiType parameterType = parameter.getType();
+        // Check if the resolved element is a parameter
+        if (!(resolvedElement instanceof PsiParameter)) {
+            return false;
+        }
 
-            // Check if the parameter type is an EventBatchContext object from the Azure SDK
-            if (!"EventBatchContext".equals(parameterType.getPresentableText())) {
-                return false;
-            }
+        // Check if the resolved element is a class type
+        PsiParameter parameter = (PsiParameter) resolvedElement;
+        PsiType parameterType = parameter.getType();
 
-            if (!(parameterType instanceof PsiClassType)) {
-                return false;
-            }
+        // Check if the parameter type is an EventBatchContext object from the Azure SDK
+        if (!"EventBatchContext".equals(parameterType.getPresentableText())) {
+            return false;
+        }
+
+        if (!(parameterType instanceof PsiClassType)) {
+            return false;
+        }
 
-            PsiClassType classType = (PsiClassType) parameterType;
-            PsiClass psiClass = classType.resolve();
+        PsiClassType classType = (PsiClassType) parameterType;
+        PsiClass psiClass = classType.resolve();
 
-            if (psiClass != null) {
-                String qualifiedName = psiClass.getQualifiedName();
+        if (psiClass != null) {
+            String qualifiedName = psiClass.getQualifiedName();
 
-                // Check if the qualified name starts with the Azure package name
-                return qualifiedName != null && qualifiedName.startsWith(RuleConfig.AZURE_PACKAGE_NAME);
-            }
-            return false;
+            // Check if the qualified name starts with the Azure package name
+            return qualifiedName != null && qualifiedName.startsWith(RuleConfig.AZURE_PACKAGE_NAME);
         }
+        return false;
     }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
index 4df918a4b21..be716ddcc98 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncBlockChecker.java
@@ -1,7 +1,7 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
 import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiMethodCallExpression;
 import org.jetbrains.annotations.NotNull;
 
@@ -20,16 +20,19 @@ public class UpdateCheckpointAsyncBlockChecker extends AbstractUpdateCheckpointA
      * @return PsiElementVisitor visitor to inspect elements in the code
      */
     @Override
-    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+    protected JavaElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
         return new BlockVisitor(holder, isOnTheFly);
     }
 
     /**
-     * This class extends the UpdateCheckpointAsyncVisitorBase to visit the elements in the code.
+     * This class extends the JavaElementVisitor to visit the elements in the code.
      * It checks if the method call is updateCheckpointAsync() and if the following method is not `block` or `block_with_timeout`.
      * If both conditions are met, a problem is registered with the suggestion message.
      */
-    static class BlockVisitor extends UpdateCheckpointAsyncVisitorBase {
+    static class BlockVisitor extends JavaElementVisitor {
+
+        // Define the holder to register problems
+        private final ProblemsHolder holder;
 
         /**
          * Constructor to initialize the visitor with the holder and isOnTheFly flag.
@@ -38,7 +41,7 @@ static class BlockVisitor extends UpdateCheckpointAsyncVisitorBase {
          * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type.
          */
         BlockVisitor(ProblemsHolder holder, boolean isOnTheFly) {
-            super(holder, isOnTheFly);
+            this.holder = holder;
         }
 
         // Define constants for string literals
@@ -89,4 +92,3 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
         }
     }
 }
-
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
index 5e64a1cbaac..b4a4419cb9d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpdateCheckpointAsyncSubscribeChecker.java
@@ -1,7 +1,7 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
 
 import com.intellij.codeInspection.ProblemsHolder;
-import com.intellij.psi.PsiElementVisitor;
+import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiMethodCallExpression;
 import org.jetbrains.annotations.NotNull;
 
@@ -20,16 +20,19 @@ public class UpdateCheckpointAsyncSubscribeChecker extends AbstractUpdateCheckpo
      * @return PsiElementVisitor visitor to inspect elements in the code
      */
     @Override
-    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+    protected JavaElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
         return new SubscribeVisitor(holder, isOnTheFly);
     }
 
     /**
-     * This class extends the UpdateCheckpointAsyncVisitorBase to visit the elements in the code.
+     * This class extends the JavaElementVisitor to visit the elements in the code.
      * It checks if the method call is updateCheckpointAsync() and if the following method is `subscribe`.
      * If both conditions are met, a problem is registered with the suggestion message.
      */
-    static class SubscribeVisitor extends UpdateCheckpointAsyncVisitorBase {
+    static class SubscribeVisitor extends JavaElementVisitor {
+
+        // Define the holder to register problems
+        private final ProblemsHolder holder;
 
         /**
          * Constructor to initialize the visitor with the holder and isOnTheFly flag.
@@ -38,7 +41,7 @@ static class SubscribeVisitor extends UpdateCheckpointAsyncVisitorBase {
          * @param isOnTheFly boolean to check if the inspection is on the fly. If true, the inspection is performed as you type.
          */
         SubscribeVisitor(ProblemsHolder holder, boolean isOnTheFly) {
-            super(holder, isOnTheFly);
+            this.holder = holder;
         }
 
         // Define constants for string literals

From 28e95d08133bc7dab959d9195e6d24dc8970adef Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 22 Jul 2024 11:12:53 -0700
Subject: [PATCH 121/144] update to abstract class

---
 .../AbstractLibraryVersionCheck.java          | 151 +++++++-----------
 .../IncompatibleDependencyCheck.java          | 105 ++++++------
 .../buildtool/UpgradeLibraryVersionCheck.java |  76 ++++-----
 .../AbstractLibraryVersionCheckTest.java      |  39 +++--
 4 files changed, 169 insertions(+), 202 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
index 8f61ae853a7..9f1ddab0349 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
@@ -8,7 +8,6 @@
 import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.xml.XmlFile;
 import com.intellij.psi.xml.XmlTag;
-import org.jetbrains.annotations.NotNull;
 import org.jetbrains.idea.maven.project.MavenProjectsManager;
 
 import java.io.IOException;
@@ -23,20 +22,7 @@
 public abstract class AbstractLibraryVersionCheck extends LocalInspectionTool {
 
     /**
-     * Abstract method to build the specific visitor for the inspection.
-     *
-     * @param holder     The holder for the problems found
-     * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
-     * @return The visitor for the inspection
-     */
-    @NotNull
-    @Override
-    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return createVisitor(holder, isOnTheFly);
-    }
-
-    /**
-     * Creates the specific visitor for the inspection.
+     * Creates the specific visitor for the inspection for subclasses to implement.
      *
      * @param holder     The holder for the problems found
      * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
@@ -45,93 +31,70 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
     protected abstract PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly);
 
     /**
-     * Abstract class for the library version visitor.
-     * The UpgradeLibraryVersionVisitor and IncompatibleDependencyVisitor classes extend this class.
-     * <p>
-     * The UpgradeLibraryVersionVisitor class checks the version of the libraries in the pom.xml file against the recommended version.
-     * The IncompatibleDependencyVisitor class checks the version of the libraries in the pom.xml file against compatible versions.
+     * Method to check the pom.xml file for the libraries and their versions.
+     *
+     * @param file   The pom.xml file to check for the libraries and their versions
+     * @param holder The holder for the problems found in the file
+     * @throws IOException If an error occurs while reading the file
      */
-    static abstract class LibraryVersionVisitorBase extends PsiElementVisitor {
-
-        // The holder for the problems found
-        protected final ProblemsHolder holder;
+    protected void checkPomXml(XmlFile file, ProblemsHolder holder) throws IOException {
 
-        /**
-         * Constructs a new instance of the visitor.
-         *
-         * @param holder     The holder for the problems found
-         * @param isOnTheFly boolean to check if the inspection is on the fly
-         */
-        protected LibraryVersionVisitorBase(ProblemsHolder holder, boolean isOnTheFly) {
-            this.holder = holder;
+        // Get the MavenProjectsManager for the file
+        MavenProjectsManager mavenProjectsManager = MavenProjectsManager.getInstance(file.getProject());
+        if (!mavenProjectsManager.isMavenizedProject()) {
+            return;
         }
 
-        /**
-         * Method to check the pom.xml file for the libraries and their versions.
-         *
-         * @param file   The pom.xml file to check for the libraries and their versions
-         * @param holder The holder for the problems found in the file
-         * @throws IOException If an error occurs while reading the file
-         */
-        protected void checkPomXml(XmlFile file, ProblemsHolder holder) throws IOException {
-
-            // Get the MavenProjectsManager for the file
-            MavenProjectsManager mavenProjectsManager = MavenProjectsManager.getInstance(file.getProject());
-            if (!mavenProjectsManager.isMavenizedProject()) {
-                return;
-            }
-
-            // Get the root tag of the file
-            FileViewProvider viewProvider = file.getViewProvider();
-            XmlFile xmlFile = (XmlFile) viewProvider.getPsi(StdLanguages.XML);
-            XmlTag rootTag = xmlFile.getRootTag();
-
-            // Check the dependencies in the file and get the groupId, artifactId, and version
-            if (rootTag != null && "project".equals(rootTag.getName())) {
-                XmlTag[] dependenciesTags = rootTag.findSubTags("dependencies");
-                for (XmlTag dependenciesTag : dependenciesTags) {
-                    XmlTag[] dependencyTags = dependenciesTag.findSubTags("dependency");
-                    for (XmlTag dependencyTag : dependencyTags) {
-                        XmlTag groupIdTag = dependencyTag.findFirstSubTag("groupId");
-                        XmlTag artifactIdTag = dependencyTag.findFirstSubTag("artifactId");
-                        XmlTag versionTag = dependencyTag.findFirstSubTag("version");
-
-                        if (groupIdTag != null && artifactIdTag != null && versionTag != null) {
-                            String groupId = groupIdTag.getValue().getText();
-                            String artifactId = artifactIdTag.getValue().getText();
-                            String currentVersion = versionTag.getValue().getText();
-
-                            // Get the full name of the library
-                            String fullName = groupId + ":" + artifactId;
-
-                            // Determine if the version should be flagged
-                            checkAndFlagVersion(fullName, currentVersion, holder, versionTag);
-                        }
+        // Get the root tag of the file
+        FileViewProvider viewProvider = file.getViewProvider();
+        XmlFile xmlFile = (XmlFile) viewProvider.getPsi(StdLanguages.XML);
+        XmlTag rootTag = xmlFile.getRootTag();
+
+        // Check the dependencies in the file and get the groupId, artifactId, and version
+        if (rootTag != null && "project".equals(rootTag.getName())) {
+            XmlTag[] dependenciesTags = rootTag.findSubTags("dependencies");
+            for (XmlTag dependenciesTag : dependenciesTags) {
+                XmlTag[] dependencyTags = dependenciesTag.findSubTags("dependency");
+                for (XmlTag dependencyTag : dependencyTags) {
+                    XmlTag groupIdTag = dependencyTag.findFirstSubTag("groupId");
+                    XmlTag artifactIdTag = dependencyTag.findFirstSubTag("artifactId");
+                    XmlTag versionTag = dependencyTag.findFirstSubTag("version");
+
+                    if (groupIdTag != null && artifactIdTag != null && versionTag != null) {
+                        String groupId = groupIdTag.getValue().getText();
+                        String artifactId = artifactIdTag.getValue().getText();
+                        String currentVersion = versionTag.getValue().getText();
+
+                        // Get the full name of the library
+                        String fullName = groupId + ":" + artifactId;
+
+                        // Determine if the version should be flagged
+                        this.checkAndFlagVersion(fullName, currentVersion, holder, versionTag);
                     }
                 }
             }
         }
+    }
 
-        /**
-         * Method to get the formatted message for the anti-pattern.
-         *
-         * @param fullName           The full name of the library eg "com.azure:azure-core"
-         * @param recommendedVersion The recommended version of the library eg "1.0"
-         * @param RULE_CONFIG        The rule configuration object
-         * @return The formatted message for the anti-pattern with the full name and recommended version
-         */
-        protected static String getFormattedMessage(String fullName, String recommendedVersion, RuleConfig RULE_CONFIG) {
-            return RULE_CONFIG.getAntiPatternMessage().replace("{{fullName}}", fullName).replace("{{recommendedVersion}}", recommendedVersion);
-        }
-
-        /**
-         * Abstract method to check the version of the library and flag it if necessary.
-         *
-         * @param fullName       The full name of the library eg "com.azure:azure-core"
-         * @param currentVersion The current version of the library eg "1.0"
-         * @param holder         The holder for the problems found
-         * @param versionElement The element for the version of the library
-         */
-        protected abstract void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionElement) throws IOException;
+    /**
+     * Method to get the formatted message for the anti-pattern.
+     *
+     * @param fullName           The full name of the library eg "com.azure:azure-core"
+     * @param recommendedVersion The recommended version of the library eg "1.0"
+     * @param RULE_CONFIG        The rule configuration object
+     * @return The formatted message for the anti-pattern with the full name and recommended version
+     */
+    protected static String getFormattedMessage(String fullName, String recommendedVersion, RuleConfig RULE_CONFIG) {
+        return RULE_CONFIG.getAntiPatternMessage().replace("{{fullName}}", fullName).replace("{{recommendedVersion}}", recommendedVersion);
     }
+
+    /**
+     * Abstract method to check the version of the library and flag it if necessary.
+     *
+     * @param fullName       The full name of the library eg "com.azure:azure-core"
+     * @param currentVersion The current version of the library eg "1.0"
+     * @param holder         The holder for the problems found
+     * @param versionElement The element for the version of the library
+     */
+    protected abstract void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionElement) throws IOException;
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
index 9b337fb7ae0..aa9d61b1e7a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
@@ -22,6 +22,9 @@
  */
 public class IncompatibleDependencyCheck extends AbstractLibraryVersionCheck {
 
+    // Set to store the encountered version groups
+    static Set<String> encounteredVersionGroups = new HashSet<>();
+
     /**
      * Abstract method to build the specific visitor for the inspection.
      *
@@ -34,6 +37,49 @@ protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnThe
         return new IncompatibleDependencyVisitor(holder, isOnTheFly);
     }
 
+    /**
+     * Method to check the version of the dependency found in the project code against the compatible versions.
+     * If the version is not compatible, a warning is flagged and the compatible version is suggested.
+     *
+     * @param fullName       The full name of the library eg "com.azure:azure-core"
+     * @param currentVersion The current version of the library
+     * @param holder         The holder for the problems found
+     * @param versionElement The version element in the pom.xml file to check
+     */
+    @Override
+    protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionElement) {
+
+        // get version group of the dependency found in the project code
+        String versionGroup = IncompatibleDependencyVisitor.getGroupVersion(fullName, currentVersion);
+
+        if (versionGroup == null) {
+            return;
+        }
+
+        // add an encountered version group to the encountered version groups
+        if (encounteredVersionGroups.isEmpty()) {
+            encounteredVersionGroups.add(versionGroup);
+        }
+
+        // check if the encountered version group is not already in the encountered version groups
+        for (String encounteredVersionGroup : encounteredVersionGroups) {
+
+            // check if the encountered version group is not the same as the current version group
+            // and the encountered version group starts with the version group's substring
+            // eg if versionGroup = "jackson_2.10" and encounteredVersionGroup = "jackson_2.10, no problem is flagged
+            // if versionGroup = "jackson_2.10" and encounteredVersionGroup = "jackson_2.11", a problem is flagged
+
+            // The substring check is used to determine if versionGroup and encounteredVersionGroup are in the same library
+            if (!encounteredVersionGroup.equals(versionGroup) && encounteredVersionGroup.startsWith(versionGroup.substring(0, versionGroup.lastIndexOf("_")))) {
+                String recommendedVersion = encounteredVersionGroup.substring(encounteredVersionGroup.lastIndexOf("_") + 1);
+
+                // Flag the version if the minor version is different from the recommended version
+                String message = getFormattedMessage(fullName, recommendedVersion, IncompatibleDependencyVisitor.RULE_CONFIG);
+                holder.registerProblem(versionElement, message);
+            }
+        }
+    }
+
     /**
      * Visitor class for the inspection.
      * Checks the version of the libraries in the pom.xml file against compatible versions.
@@ -41,10 +87,13 @@ protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnThe
      * The compatible versions are compared against the minor version of the library. Minor version is the first two parts of the version number.
      * If the minor version is different from the compatible version, a warning is flagged and the compatible version is suggested.
      */
-    static class IncompatibleDependencyVisitor extends LibraryVersionVisitorBase {
+    class IncompatibleDependencyVisitor extends PsiElementVisitor {
+
+        // Holder for the problems found
+        private final ProblemsHolder holder;
 
-        // Set to store the encountered version groups
-        static Set<String> encounteredVersionGroups = new HashSet<>();
+        // Map to store the compatible versions for each library
+        private static WeakReference<Map<String, Set<String>>> FILE_CONTENT_REF;
         private static final Logger LOGGER = Logger.getLogger(IncompatibleDependencyCheck.class.getName());
 
         /**
@@ -54,11 +103,9 @@ static class IncompatibleDependencyVisitor extends LibraryVersionVisitorBase {
          * @param isOnTheFly boolean to check if the inspection is on the fly
          */
         IncompatibleDependencyVisitor(ProblemsHolder holder, boolean isOnTheFly) {
-            super(holder, isOnTheFly);
+            this.holder = holder;
         }
 
-        // Map to store the compatible versions for each library
-        private static WeakReference<Map<String, Set<String>>> FILE_CONTENT_REF;
         private static final RuleConfig RULE_CONFIG;
         private static final boolean SKIP_WHOLE_RULE;
 
@@ -91,57 +138,13 @@ public void visitFile(@NotNull PsiFile file) {
 
                 // Check the pom.xml file for the library version
                 try {
-                    checkPomXml((XmlFile) file, holder);
+                    IncompatibleDependencyCheck.this.checkPomXml((XmlFile) file, holder);
                 } catch (IOException e) {
                     LOGGER.severe("Error checking pom.xml file: " + e);
                 }
             }
         }
 
-
-        /**
-         * Method to check the version of the dependency found in the project code against the compatible versions.
-         * If the version is not compatible, a warning is flagged and the compatible version is suggested.
-         *
-         * @param fullName       The full name of the library eg "com.azure:azure-core"
-         * @param currentVersion The current version of the library
-         * @param holder         The holder for the problems found
-         * @param versionElement The version element in the pom.xml file to check
-         */
-        @Override
-        protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionElement) {
-
-            // get version group of the dependency found in the project code
-            String versionGroup = getGroupVersion(fullName, currentVersion);
-
-            if (versionGroup == null) {
-                return;
-            }
-
-            // add an encountered version group to the encountered version groups
-            if (encounteredVersionGroups.isEmpty()) {
-                encounteredVersionGroups.add(versionGroup);
-            }
-
-            // check if the encountered version group is not already in the encountered version groups
-            for (String encounteredVersionGroup : encounteredVersionGroups) {
-
-                // check if the encountered version group is not the same as the current version group
-                // and the encountered version group starts with the version group's substring
-                // eg if versionGroup = "jackson_2.10" and encounteredVersionGroup = "jackson_2.10, no problem is flagged
-                // if versionGroup = "jackson_2.10" and encounteredVersionGroup = "jackson_2.11", a problem is flagged
-
-                // The substring check is used to determine if versionGroup and encounteredVersionGroup are in the same library
-                if (!encounteredVersionGroup.equals(versionGroup) && encounteredVersionGroup.startsWith(versionGroup.substring(0, versionGroup.lastIndexOf("_")))) {
-                    String recommendedVersion = encounteredVersionGroup.substring(encounteredVersionGroup.lastIndexOf("_") + 1);
-
-                    // Flag the version if the minor version is different from the recommended version
-                    String message = getFormattedMessage(fullName, recommendedVersion, RULE_CONFIG);
-                    holder.registerProblem(versionElement, message);
-                }
-            }
-        }
-
         /**
          * Method to get the version group for the library.
          * The version group is used to get the compatible versions for the library.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
index 1eaf296b8c1..89154d9555a 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
@@ -31,6 +31,40 @@ protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnThe
         return new UpgradeLibraryVersionVisitor(holder, isOnTheFly);
     }
 
+    /**
+     * Method to check the version of the library against the recommended version.
+     *
+     * @param fullName       The full name of the library
+     * @param currentVersion The current version of the library
+     * @param holder         The holder for the problems found
+     * @param versionTag     The version tag in the pom.xml file for the library version
+     */
+    @Override
+    protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionTag) throws IOException {
+
+        // Check if the recommended version is available for the library
+        if (!(UpgradeLibraryVersionVisitor.getLibraryRecommendedVersionMap().containsKey(fullName))) {
+            return;
+        }
+        String recommendedVersion = UpgradeLibraryVersionVisitor.getLibraryRecommendedVersionMap().get(fullName);
+
+        // Compare minor versions only
+        String[] currentVersionParts = currentVersion.split("\\.");
+
+        // Check if the version is in the correct format
+        if (!(currentVersionParts.length > 1)) {
+            return;
+        }
+
+        // Parse to get the minor version
+        String currentMinor = currentVersionParts[0] + "." + currentVersionParts[1];
+
+        // Flag the version if the minor version is different from the recommended version
+        if (!currentMinor.equals(recommendedVersion)) {
+            holder.registerProblem(versionTag, getFormattedMessage(fullName, recommendedVersion, UpgradeLibraryVersionVisitor.RULE_CONFIG));
+        }
+    }
+
     /**
      * Visitor class for the inspection.
      * Checks the version of the libraries in the pom.xml file against the recommended version.
@@ -38,7 +72,9 @@ protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnThe
      * The recommended version is compared against the minor version of the library. Minor version is the first two parts of the version number.
      * If the minor version is different from the recommended version, a warning is flagged and the recommended version is suggested.
      */
-    static class UpgradeLibraryVersionVisitor extends LibraryVersionVisitorBase {
+    class UpgradeLibraryVersionVisitor extends PsiElementVisitor {
+
+        private final ProblemsHolder holder;
 
         /**
          * Constructs a new instance of the visitor.
@@ -47,7 +83,7 @@ static class UpgradeLibraryVersionVisitor extends LibraryVersionVisitorBase {
          * @param isOnTheFly boolean to check if the inspection is on the fly
          */
         UpgradeLibraryVersionVisitor(ProblemsHolder holder, boolean isOnTheFly) {
-            super(holder, isOnTheFly);
+            this.holder = holder;
         }
 
         // Map to store the recommended version for each library
@@ -84,47 +120,13 @@ public void visitFile(@NotNull PsiFile file) {
 
             if (file instanceof XmlFile && file.getName().equals("pom.xml")) {
                 try {
-                    checkPomXml((XmlFile) file, holder);
+                    UpgradeLibraryVersionCheck.this.checkPomXml((XmlFile) file, holder);
                 } catch (IOException e) {
                     throw new RuntimeException(e);
                 }
             }
         }
 
-        /**
-         * Method to check the version of the library against the recommended version.
-         *
-         * @param fullName       The full name of the library
-         * @param currentVersion The current version of the library
-         * @param holder         The holder for the problems found
-         * @param versionTag     The version tag in the pom.xml file for the library version
-         */
-        @Override
-        protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionTag) throws IOException {
-
-            // Check if the recommended version is available for the library
-            if (!(getLibraryRecommendedVersionMap().containsKey(fullName))) {
-                return;
-            }
-            String recommendedVersion = getLibraryRecommendedVersionMap().get(fullName);
-
-            // Compare minor versions only
-            String[] currentVersionParts = currentVersion.split("\\.");
-
-            // Check if the version is in the correct format
-            if (!(currentVersionParts.length > 1)) {
-                return;
-            }
-
-            // Parse to get the minor version
-            String currentMinor = currentVersionParts[0] + "." + currentVersionParts[1];
-
-            // Flag the version if the minor version is different from the recommended version
-            if (!currentMinor.equals(recommendedVersion)) {
-                holder.registerProblem(versionTag, getFormattedMessage(fullName, recommendedVersion, RULE_CONFIG));
-            }
-        }
-
         /**
          * Method to get the recommended version for each library from the file hosted on GitHub.
          * The file is fetched only once and the content is stored in a WeakReference.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
index 758f26f74c1..95ef6d8c1af 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
@@ -37,7 +37,10 @@ class AbstractLibraryVersionCheckTest {
     private ProblemsHolder mockHolder;
 
     @Mock
-    private PsiElementVisitor mockVisitor;
+    private UpgradeLibraryVersionVisitor mockUpgradeLibraryVersionVisitor;
+
+    @Mock
+    private IncompatibleDependencyVisitor mockIncompatibleDependencyVisitor;
 
     @Mock
     private XmlFile mockFile;
@@ -48,7 +51,13 @@ public void setup() {
         mockFile = mock(XmlFile.class);
 
         // Set the version groups that are "discovered" by the visitor to test the IncompatibleDependencyVisitor
-        IncompatibleDependencyVisitor.encounteredVersionGroups = new HashSet<>(Arrays.asList("jackson_2.10", "gson_2.10"));
+        IncompatibleDependencyCheck.encounteredVersionGroups = new HashSet<>(Arrays.asList("jackson_2.10", "gson_2.10"));
+
+        UpgradeLibraryVersionCheck mockCheck = new UpgradeLibraryVersionCheck();
+        mockUpgradeLibraryVersionVisitor = mockCheck.new UpgradeLibraryVersionVisitor(mockHolder, true);
+
+        IncompatibleDependencyCheck mockIncompatibleDependencyCheck = new IncompatibleDependencyCheck();
+        mockIncompatibleDependencyVisitor = mockIncompatibleDependencyCheck.new IncompatibleDependencyVisitor(mockHolder, true);
     }
 
     /**
@@ -57,15 +66,13 @@ public void setup() {
      */
     @Test
     public void testUpgradeCheckOutOfDate() {
-
-        UpgradeLibraryVersionVisitor mockVisitor = new UpgradeLibraryVersionVisitor(mockHolder, true);
         String groupIDValue = "com.azure";
         String artifactIDValue = "azure-messaging-servicebus";
         String versionValue = "7.0.0";
         int numOfInvocations = 1;
         String recommendedVersion = "7.17";
 
-        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+        verifyRegisterProblem(mockUpgradeLibraryVersionVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
     }
 
     /**
@@ -74,15 +81,13 @@ public void testUpgradeCheckOutOfDate() {
      */
     @Test
     public void testUpgradeCheckUpToDate() {
-
-        UpgradeLibraryVersionVisitor mockVisitor = new UpgradeLibraryVersionVisitor(mockHolder, true);
         String groupIDValue = "com.azure";
         String artifactIDValue = "azure-messaging-servicebus";
         String versionValue = "7.17.1";
         int numOfInvocations = 0;
         String recommendedVersion = "7.17";
 
-        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+        verifyRegisterProblem(mockUpgradeLibraryVersionVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
     }
 
     /**
@@ -92,14 +97,13 @@ public void testUpgradeCheckUpToDate() {
      */
     @Test
     public void testUpgradeCheckMissingVersion() {
-        UpgradeLibraryVersionVisitor mockVisitor = new UpgradeLibraryVersionVisitor(mockHolder, true);
         String groupIDValue = "com.example";
         String artifactIDValue = "example-lib";
         String versionValue = "";  // Empty version
         int numOfInvocations = 0;  // No problems will be registered by this checker because its out of scope
         String recommendedVersion = null;
 
-        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+        verifyRegisterProblem(mockUpgradeLibraryVersionVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
     }
 
     /**
@@ -108,15 +112,13 @@ public void testUpgradeCheckMissingVersion() {
      */
     @Test
     public void testIncompatibleDifferentMinorGroup() {
-
-        IncompatibleDependencyVisitor mockVisitor = new IncompatibleDependencyVisitor(mockHolder, true);
         String groupIDValue = "com.google.code.gson";
         String artifactIDValue = "gson";
         String versionValue = "2.9.0";
         int numOfInvocations = 1;
         String recommendedVersion = "2.10";
 
-        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+        verifyRegisterProblem(mockIncompatibleDependencyVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
     }
 
     /**
@@ -125,15 +127,13 @@ public void testIncompatibleDifferentMinorGroup() {
      */
     @Test
     public void testIncompatibleCheckSameMinorGroup() {
-
-        IncompatibleDependencyVisitor mockVisitor = new IncompatibleDependencyVisitor(mockHolder, true);
         String groupIDValue = "com.fasterxml.jackson.core";
         String artifactIDValue = "jackson-databind";
         String versionValue = "2.10.0";
         int numOfInvocations = 0;
         String recommendedVersion = "2.10";
 
-        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+        verifyRegisterProblem(mockIncompatibleDependencyVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
     }
 
     /**
@@ -143,14 +143,13 @@ public void testIncompatibleCheckSameMinorGroup() {
      */
     @Test
     public void testIncompatibleCheckDifferentMajorVersion() {
-        IncompatibleDependencyVisitor mockVisitor = new IncompatibleDependencyVisitor(mockHolder, true);
         String groupIDValue = "com.fasterxml.jackson.core";
         String artifactIDValue = "jackson-databind";
         String versionValue = "3.0.0";  // Different major version
         int numOfInvocations = 0;
         String recommendedVersion = null;
 
-        verifyRegisterProblem(mockVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
+        verifyRegisterProblem(mockIncompatibleDependencyVisitor, groupIDValue, artifactIDValue, versionValue, numOfInvocations, recommendedVersion);
     }
 
     /**
@@ -211,9 +210,9 @@ private void verifyRegisterProblem(PsiElementVisitor visitor, String groupIDValu
         visitor.visitFile(mockFile);
 
         if (visitor instanceof UpgradeLibraryVersionVisitor) {
-            verify(mockHolder, times(numOfInvocations)).registerProblem(versionTag, "A newer stable minor version of " + groupIDValue + ":" + artifactIDValue + " is available. We recommend you update to version " + recommendedVersion + ".");
+            verify(mockHolder, times(numOfInvocations)).registerProblem(versionTag, "A newer stable minor version of " + groupIDValue + ":" + artifactIDValue + " is available. We recommend you update to version " + recommendedVersion + ".x");
         } else if (visitor instanceof IncompatibleDependencyVisitor) {
-            verify(mockHolder, times(numOfInvocations)).registerProblem(versionTag, "The version of " + groupIDValue + ":" + artifactIDValue + " is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group " + recommendedVersion + " to ensure proper functionality.");
+            verify(mockHolder, times(numOfInvocations)).registerProblem(versionTag, "The version of " + groupIDValue + ":" + artifactIDValue + " is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group " + recommendedVersion + ".x to ensure proper functionality.");
         }
     }
 }

From 77561cb8a48c9eca2315e18d3a771c44b3eb4486 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 22 Jul 2024 11:56:50 -0700
Subject: [PATCH 122/144] address PR comments

---
 ...iesWithTimeIntervalInQueryStringCheck.java | 76 ++++++++++---------
 ...ithTimeIntervalInQueryStringCheckTest.java | 16 ++--
 2 files changed, 48 insertions(+), 44 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index 2d8e4257d20..71ec4245409 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -26,11 +26,13 @@
  * This class is an inspection tool that checks for Kusto queries with time intervals in the query string.
  * This approach makes queries less flexible and harder to troubleshoot.
  * This inspection tool checks for the following anti-patterns:
- * 1. Queries that use the "ago" function with a time interval.
- * 2. Queries that use the "datetime" function with a specific datetime.
- * 3. Queries that use the "now" function to get the current timestamp.
- * 4. Queries that use the "startofday", "startofmonth", or "startofyear" functions.
- * 5. Queries that use the "between" function with datetime values.
+ * <ul>
+ * <li> Queries that use the "ago" function with a time interval.</li>
+ * <li> Queries that use the "datetime" function with a specific datetime.</li>
+ * <li> Queries that use the "now" function to get the current timestamp.</li>
+ * <li> Queries that use the "startofday", "startofmonth", or "startofyear" functions.</li>
+ * <li> Queries that use the "between" function with datetime values.</li>
+ * </ul>
  * <p>
  * When the anti-patterns are detected as parameters of Azure client method calls, a problem is registered.
  */
@@ -83,7 +85,7 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
         }
 
         // empty list to store time interval parameter names
-        private List<String> timeIntervalParameters = new ArrayList<>();
+        private final List<String> timeIntervalParameters = new ArrayList<>();
 
         /**
          * Constructor for the KustoQueriesVisitor class
@@ -120,7 +122,7 @@ public void visitElement(@NotNull PsiElement element) {
             }
 
             if (element instanceof PsiMethodCallExpressionImpl) {
-                handleMethodCall((PsiMethodCallExpressionImpl) element);
+                checkParameterNames((PsiMethodCallExpressionImpl) element);
             }
 
             if (element instanceof PsiLocalVariable) {
@@ -136,6 +138,35 @@ public void visitElement(@NotNull PsiElement element) {
             }
         }
 
+        /**
+         * This method checks the expression for the anti-patterns by matching regex patterns with the expression text
+         * and registers a problem if an anti-pattern is detected
+         *
+         * @param expression - the expression to check
+         * @param element    - the element to check
+         */
+        void checkExpression(PsiExpression expression, PsiElement element) {
+            if (expression == null) {
+                return;
+            }
+            String text = expression.getText();
+
+            // Check if the expression text contains any of the regex patterns
+            boolean foundAntiPattern = REGEX_PATTERNS.stream().anyMatch(pattern -> pattern.matcher(text).find());
+
+
+            // If an anti-pattern is detected, register a problem
+            if (foundAntiPattern) {
+                PsiElement parentElement = element.getParent();
+
+                if (parentElement instanceof PsiLocalVariable) {
+                    PsiLocalVariable variable = (PsiLocalVariable) parentElement;
+                    String variableName = variable.getName();
+                    timeIntervalParameters.add(variableName);
+                }
+            }
+        }
+
         /**
          * This method handles the local variable by checking the initializer of the variable
          * If the initializer is a PsiLiteralExpression, the method checks the expression for the anti-patterns
@@ -170,7 +201,7 @@ private void handlePolyadicExpression(PsiPolyadicExpression polyadicExpression)
          *
          * @param methodCall - the method call to check
          */
-        private void handleMethodCall(PsiMethodCallExpressionImpl methodCall) {
+        private void checkParameterNames(PsiMethodCallExpressionImpl methodCall) {
             // check the parameters of the method call
             PsiExpressionList argumentList = methodCall.getArgumentList();
             PsiExpression[] arguments = argumentList.getExpressions();
@@ -200,35 +231,6 @@ private void handleMethodCall(PsiMethodCallExpressionImpl methodCall) {
             }
         }
 
-        /**
-         * This method checks the expression for the anti-patterns by matching regex patterns with the expression text
-         * and registers a problem if an anti-pattern is detected
-         *
-         * @param expression - the expression to check
-         * @param element    - the element to check
-         */
-        void checkExpression(PsiExpression expression, PsiElement element) {
-            if (expression == null) {
-                return;
-            }
-            String text = expression.getText();
-
-            // Check if the expression text contains any of the regex patterns
-            boolean foundAntiPattern = REGEX_PATTERNS.stream().anyMatch(pattern -> pattern.matcher(text).find());
-
-
-            // If an anti-pattern is detected, register a problem
-            if (foundAntiPattern) {
-                PsiElement parentElement = element.getParent();
-
-                if (parentElement instanceof PsiLocalVariable) {
-                    PsiLocalVariable variable = (PsiLocalVariable) parentElement;
-                    String variableName = variable.getName();
-                    timeIntervalParameters.add(variableName);
-                }
-            }
-        }
-
 
         /**
          * This method checks if the method call is an Azure client method call
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
index e49504803a0..f59b7b06642 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -31,13 +31,15 @@
  * This class tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
  * <p>
  * These are some example queries that should be flagged:
- * 1. "String query1 = \"| where timestamp > ago(1d)\";": This query uses the ago function to create a time interval of 1 day. This should be FLAGGED.
- * 2. "String query2 = \"| where timestamp > datetime(2021-01-01)\";": This query compares the timestamp to a specific datetime. This should be FLAGGED.
- * 3. "String query3 = \"| where timestamp > now()\";": This query uses the now function to get the current timestamp. This should be FLAGGED.
- * 4. "String query4 = \"| where timestamp > startofday()\";": This query uses the startofday function to get the start of the current day. This should be FLAGGED.
- * 5. "String query5 = \"| where timestamp > startofmonth()\";": This query uses the startofmonth function to get the start of the current month. This should be FLAGGED.
- * 6. "String query11 = \"| where timestamp > ago(\" + days + \")\";": This query uses a variable to define the time interval. This should be FLAGGED.
- * 7. "String query12 = \"| where timestamp > datetime(\" + date + \")\";": This query uses a variable to define the datetime. This should not be FLAGGED.
+ * <ul>
+ * <li> "String query1 = \"| where timestamp > ago(1d)\";": This query uses the ago function to create a time interval of 1 day. This should be FLAGGED </li>
+ * <li> "String query2 = \"| where timestamp > datetime(2021-01-01)\";": This query compares the timestamp to a specific datetime. This should be FLAGGED </li>
+ * <li> "String query3 = \"| where timestamp > now()\";": This query uses the now function to get the current timestamp. This should be FLAGGED </li>
+ * <li> "String query4 = \"| where timestamp > startofday()\";": This query uses the startofday function to get the start of the current day. This should be FLAGGED </li>
+ * <li> "String query5 = \"| where timestamp > startofmonth()\";": This query uses the startofmonth function to get the start of the current month. This should be FLAGGED </li>
+ * <li> "String query11 = \"| where timestamp > ago(\" + days + \")\";": This query uses a variable to define the time interval. This should be FLAGGED </li>
+ * <li> "String query12 = \"| where timestamp > datetime(\" + date + \")\";": This query uses a variable to define the datetime. This should not be FLAGGED </li>
+ * </ul>
  * If these queries are used in a method call to an Azure client, they should be flagged.
  * <p>
  * eg BlobClient blobAsyncClient = new BlobClientBuilder().buildClient();

From 277146b09a82841a9aeb2e991c61c194b735bb67 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 23 Jul 2024 11:48:38 -0700
Subject: [PATCH 123/144] implementation with test

---
 .../EndpointOnNonAzureOpenAIAuthCheck.java    | 125 +++++++++++++++
 .../azure-intellij-plugin-azure-sdk.xml       |  14 ++
 ...EndpointOnNonAzureOpenAIAuthCheckTest.java | 144 ++++++++++++++++++
 3 files changed, 283 insertions(+)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
new file mode 100644
index 00000000000..509b9f3a111
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
@@ -0,0 +1,125 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.LocalInspectionTool;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiLocalVariable;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiTypeElement;
+import com.intellij.psi.PsiVariable;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.Arrays;
+
+public class EndpointOnNonAzureOpenAIAuthCheck extends LocalInspectionTool {
+
+    @NotNull
+    @Override
+    public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new EndpointOnNonAzureOpenAIAuthVisitor(holder, isOnTheFly);
+    }
+
+
+    static class EndpointOnNonAzureOpenAIAuthVisitor extends JavaElementVisitor {
+
+        private final ProblemsHolder holder;
+
+        EndpointOnNonAzureOpenAIAuthVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+            this.holder = holder;
+        }
+
+
+        @Override
+        public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
+            super.visitMethodCallExpression(expression);
+
+            PsiReferenceExpression methodExpression = expression.getMethodExpression();
+            String methodName = methodExpression.getReferenceName();
+
+            System.out.println("methodName: " + methodName);
+
+            if ("endpoint".equals(methodName)) {
+                if (isUsingKeyCredential(expression)) {
+                    holder.registerProblem(expression, "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients");
+                }
+            }
+
+
+        }
+
+        private static boolean isUsingKeyCredential(PsiMethodCallExpression expression) {
+
+            // Iterating up the chain of method calls
+            PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
+
+            System.out.println("qualifier: " + qualifier);
+
+            // Check if the method call chain has the method to check -- need to traverse up and down
+            while (qualifier instanceof PsiMethodCallExpression) {
+
+                // Get the method expression
+                PsiReferenceExpression methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
+                System.out.println("methodExpression: " + methodExpression);
+
+                PsiMethodCallExpression methodCall = (PsiMethodCallExpression) qualifier;
+                System.out.println("methodCall: " + methodCall);
+
+                // Get the method name
+                String methodName = methodExpression.getReferenceName();
+                System.out.println("methodName: " + methodName);
+
+                if ("credential".equals(methodName)) {
+
+                    System.out.println("credential method found");
+                    PsiExpressionList argumentList = methodCall.getArgumentList();
+                    System.out.println("argumentList: " + argumentList);
+                    System.out.println("methodCall.getArgumentList(): " + methodCall.getArgumentList());
+                    System.out.println("methodCall: " + methodCall);
+                    PsiExpression[] arguments = methodCall.getArgumentList().getExpressions();
+                    System.out.println("arguments: " + arguments);
+                    if (arguments.length == 1 && isKeyCredential(arguments[0])) {
+                        return isNonAzureOpenAIClient(methodCall);
+                    }
+                    return false;
+                }
+
+                // Iterating up the chain of method calls
+                qualifier = methodCall.getMethodExpression().getQualifierExpression();
+            }
+            return false;
+        }
+
+        private static boolean isKeyCredential(PsiExpression expression) {
+
+            System.out.println("expression.getType().getCanonicalText()): " + expression.getType().getCanonicalText());
+            System.out.println("expression.getType()); " + expression.getType());
+
+            return expression.getType()!= null && expression.getType().getCanonicalText().equals("com.azure.core.credential.KeyCredential");
+        }
+
+        private static boolean isNonAzureOpenAIClient(PsiMethodCallExpression expression) {
+            PsiElement parent = expression.getParent();
+            System.out.println("parent: " + parent);
+
+            while (parent != null) {
+                System.out.println("parent: " + parent);
+                if (parent instanceof PsiVariable) {
+
+                    PsiType type = ((PsiVariable) parent).getType();
+                    System.out.println("type: " + type);
+                    System.out.println("type.getCanonicalText(): " + type.getCanonicalText());
+                    if(type != null){
+                        return type.getCanonicalText().startsWith("com.azure.ai.openai");
+                    }
+                }
+                parent = parent.getParent();
+            }
+            return false;
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 980f8c6bbd7..6efec606603 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -168,5 +168,19 @@
                 com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.DetectDiscouragedClientCheck
             </class>
         </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="EndpointOnNonAzureOpenAIAuthCheck"
+                displayName="Endpoint On Non-Azure OpenAI Auth Check"
+                groupName="Azure SDK"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.EndpointOnNonAzureOpenAIAuthCheck">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.EndpointOnNonAzureOpenAIAuthCheck
+            </class>
+        </localInspection>
     </extensions>
 </idea-plugin>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
new file mode 100644
index 00000000000..f460a713deb
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
@@ -0,0 +1,144 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.JavaElementVisitor;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiExpression;
+import com.intellij.psi.PsiExpressionList;
+import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
+import com.intellij.psi.PsiType;
+import com.intellij.psi.PsiVariable;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+
+import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.EndpointOnNonAzureOpenAIAuthCheck.EndpointOnNonAzureOpenAIAuthVisitor;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class EndpointOnNonAzureOpenAIAuthCheckTest {
+
+    // Declare as instance variables
+    @Mock
+    private ProblemsHolder mockHolder;
+
+    @Mock
+    private JavaElementVisitor mockVisitor;
+
+    @Mock
+    private PsiMethodCallExpression mockMethodCall;
+
+    @BeforeEach
+    public void setup() {
+        mockHolder = mock(ProblemsHolder.class);
+        mockVisitor = createVisitor();
+        mockMethodCall = mock(PsiMethodCallExpression.class);
+    }
+
+    @Test
+    public void testEndpointOnNonAzureOpenAIAuthCheck() {
+
+        int numOfInvocation = 1;
+        String endpoint = "endpoint";
+        String credential = "credential";
+        String KeyCredentialPackageName = "com.azure.core.credential.KeyCredential";
+        String azurePackageName = "com.azure.ai.openai";
+
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+    }
+
+    @Test
+    public void testNoEndpoint(){
+
+        int numOfInvocation = 0;
+        String endpoint = "notEndpoint";
+        String credential = "credential";
+        String KeyCredentialPackageName = "com.azure.core.credential.KeyCredential";
+        String azurePackageName = "com.azure.ai.openai";
+
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+    }
+
+    @Test
+    public void testNoCredential(){
+
+        int numOfInvocation = 0;
+        String endpoint = "endpoint";
+        String credential = "notCredential";
+        String KeyCredentialPackageName = "com.azure.core.credential.KeyCredential";
+        String azurePackageName = "com.azure.ai.openai";
+
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+    }
+
+    @Test
+    public void testWithAzureKeyCredential(){
+
+        int numOfInvocation = 0;
+        String endpoint = "endpoint";
+        String credential = "notCredential";
+        String KeyCredentialPackageName = "com.azure.core.credential.AzureKeyCredential";
+        String azurePackageName = "com.azure.ai.openai";
+
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+    }
+
+
+
+    private JavaElementVisitor createVisitor() {
+        boolean isOnTheFly = true;
+        EndpointOnNonAzureOpenAIAuthVisitor mockVisitor = new EndpointOnNonAzureOpenAIAuthVisitor(mockHolder, isOnTheFly);
+        return mockVisitor;
+    }
+
+
+    private void verifyRegisterProblem(int numOfInvocation, String endpoint, String credential, String KeyCredentialPackageName, String azurePackageName) {
+
+
+        PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
+
+        PsiMethodCallExpression qualifierOne = mock(PsiMethodCallExpression.class);
+        PsiReferenceExpression methodExpressionOne = mock(PsiReferenceExpression.class);
+
+        PsiExpression expression = mock(PsiExpression.class);
+        PsiExpressionList argumentList = mock(PsiExpressionList.class);
+        PsiExpression[] arguments = new PsiExpression[]{expression};
+
+        PsiType type = mock(PsiType.class);
+        PsiVariable parent = mock(PsiVariable.class);
+        PsiType qualifierTYpe = mock(PsiType.class);
+
+
+        when(mockMethodCall.getMethodExpression()).thenReturn(methodExpression);
+        when(methodExpression.getReferenceName()).thenReturn(endpoint);
+
+        // isUsingKeyCredential
+        when(methodExpression.getQualifierExpression()).thenReturn(qualifierOne);
+        when(qualifierOne.getMethodExpression()).thenReturn(methodExpressionOne);
+        when(methodExpressionOne.getReferenceName()).thenReturn(credential);
+        when(methodExpressionOne.getQualifierExpression()).thenReturn(null);
+
+        when(qualifierOne.getArgumentList()).thenReturn(argumentList);
+        when(argumentList.getExpressions()).thenReturn(arguments);
+
+        // isKeyCredential
+        when(expression.getType()).thenReturn(type);
+        when(type.getCanonicalText()).thenReturn(KeyCredentialPackageName);
+
+        // isNonAzureOpenAIClient
+        when(qualifierOne.getParent()).thenReturn(parent);
+        when(parent.getType()).thenReturn(qualifierTYpe);
+        when(qualifierTYpe.getCanonicalText()).thenReturn(azurePackageName);
+
+        mockVisitor.visitMethodCallExpression(mockMethodCall);
+
+        verify(mockHolder, times(numOfInvocation)).registerProblem(mockMethodCall, "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients");
+
+
+    }
+}

From c7afa6e182614416f8b2f38ea135c59b13081ada Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 23 Jul 2024 11:51:26 -0700
Subject: [PATCH 124/144] address PR comments

---
 .../intellij/azure/sdk/buildtool/RuleConfigLoader.java      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index d434a80a9bd..37083721056 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -100,7 +100,7 @@ private Map<String, RuleConfig> loadRuleConfigurations(String filePath) {
             // If not, throw an exception
             // This is to ensure that the JSON file is in the correct format
             if (reader.nextToken() != JsonToken.START_OBJECT) {
-                throw new IOException("Expected start of object");
+                throw new IllegalArgumentException("Expected start of object");
             }
 
             // Read the JSON file and parse the RuleConfig objects
@@ -134,7 +134,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
 
         // Check if the JSON file starts with an object
         if (reader.nextToken() != JsonToken.START_OBJECT) {
-            throw new IOException("Expected start of object");
+            throw new IllegalArgumentException("Expected start of object");
         }
 
         // Read the JSON file and parse the RuleConfig object
@@ -189,7 +189,7 @@ private List<String> getListFromJsonArray(JsonReader reader) throws IOException
                 list.add(reader.getString());
                 return list;
             } else {
-                throw new IOException("Expected start of array");
+                throw new IllegalArgumentException("Expected start of array");
             }
         }
 

From c3c4b26fc6605752044ae49af406a966450c7f61 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 23 Jul 2024 16:40:20 -0700
Subject: [PATCH 125/144] implement rule with tests

---
 .../azure-intellij-plugin-azure-sdk/README.md |  70 ++++++----
 .../EndpointOnNonAzureOpenAIAuthCheck.java    | 125 +++++++++++++-----
 .../main/resources/META-INF/ruleConfigs.json  |  17 ++-
 ...EndpointOnNonAzureOpenAIAuthCheckTest.java |  71 ++++++----
 4 files changed, 197 insertions(+), 86 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index 3b50212774b..b58be0e7588 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -162,43 +162,46 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 
 9. #### Use these encouraged clients instead of their corresponding discouraged clients
 
-    ##### a. Use **`ServiceBusProcessorClient`** instead of **`ServiceBusReceiverAsyncClient`**
+   ##### a. Use **`ServiceBusProcessorClient`** instead of **`ServiceBusReceiverAsyncClient`**
 
-    ##### b. Use **`EventProcessorClient`** instead of **`EventHubConsumerAsyncClient`**
-    
-    ##### Anti-pattern:
-    
-    - Both `ServiceBusReceiverAsyncClient` and `EventHubConsumerAsyncClient` are low-level APIs. They provide fine-grained
+   ##### b. Use **`EventProcessorClient`** instead of **`EventHubConsumerAsyncClient`**
+
+   ##### Anti-pattern:
+
+    - Both `ServiceBusReceiverAsyncClient` and `EventHubConsumerAsyncClient` are low-level APIs. They provide
+      fine-grained
       control over message/event handling but require a high level of proficiency in Reactive programming.
-    - Due to their complexity and the need for a deep understanding of Reactive programming, there is a higher risk of these
+    - Due to their complexity and the need for a deep understanding of Reactive programming, there is a higher risk of
+      these
       clients being used incorrectly or inefficiently, especially by developers who are not familiar with Reactive
       paradigms.
 
-    ##### Issue:
+   ##### Issue:
+
+   ##### a. **ServiceBusReceiverAsyncClient**
 
-    ##### a. **ServiceBusReceiverAsyncClient**
+    - **Anti-pattern**: The `ServiceBusReceiverAsyncClient` is considered an anti-pattern because it demands detailed
+      handling of messages, which can be overly complex and unnecessary for most common use cases.
+    - **Severity: WARNING**
+    - **Recommendation**: Instead of using `ServiceBusReceiverAsyncClient`, it is recommended to
+      use `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies
+      message consumption, making it a more suitable option for most developers and scenarios.
+    - Please refer to
+      the [Azure Service Bus client for Java](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient)
+      for more information.
 
-   - **Anti-pattern**: The `ServiceBusReceiverAsyncClient` is considered an anti-pattern because it demands detailed
-   handling of messages, which can be overly complex and unnecessary for most common use cases.
-   - **Severity: WARNING**
-   - **Recommendation**: Instead of using `ServiceBusReceiverAsyncClient`, it is recommended to
-     use `ServiceBusProcessorClient`. The `ServiceBusProcessorClient` is a higher-level abstraction that simplifies
-     message consumption, making it a more suitable option for most developers and scenarios.
-   - Please refer to
-     the [Azure Service Bus client for Java](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/README.md#when-to-use-servicebusprocessorclient)
-     for more information.
+   ##### b. **EventHubConsumerAsyncClient**
 
-    ##### b. **EventHubConsumerAsyncClient**
-    
-    - **Anti-pattern**: The `EventHubConsumerAsyncClient` is considered an anti-pattern due to its low-level nature and the
-    complexity involved in event handling.
+    - **Anti-pattern**: The `EventHubConsumerAsyncClient` is considered an anti-pattern due to its low-level nature and
+      the
+      complexity involved in event handling.
     - **Severity: WARNING**
     - **Recommendation**: Instead of using `EventHubConsumerAsyncClient`, it is advised to use `EventProcessorClient`.
-    The `EventProcessorClient` provides a higher-level abstraction that simplifies event processing, making it the
-    preferred choice for most developers.
+      The `EventProcessorClient` provides a higher-level abstraction that simplifies event processing, making it the
+      preferred choice for most developers.
     - Please refer to
-    the [EventProcessorClient Class](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.eventhubs.eventprocessorclient?view=azure-java-stable)
-    for more information.
+      the [EventProcessorClient Class](https://learn.microsoft.com/en-us/java/api/com.azure.messaging.eventhubs.eventprocessorclient?view=azure-java-stable)
+      for more information.
 
 10. #### Using Batch Operations Instead of Single Operations in a Loop
 
@@ -211,4 +214,17 @@ integration, telemetry connectivity, and Azure Toolkit integration.
       batch request.
 - **Severity: WARNING**
 - **Recommendation**: Use Batch Operations: If the SDK provides a batch operation API, use it to perform multiple
-  actions in a single request.
\ No newline at end of file
+  actions in a single request.
+
+11. #### Authenticating a Non-Azure OpenAI Client with KeyCredential
+
+- **Anti-pattern**: Assigning the endpoint value when creating a Non-Azure OpenAI client using the KeyCredential in
+  .credential(KeyCredential).
+- **Issue**: KeyCredential is the only required parameter in `.credential(KeyCredential)` for authenticating requests to
+  non-Azure OpenAI APIs.
+- **Severity: WARNING**
+- **Recommendation**: Omit Endpoint: Do not specify the endpoint parameter unless you are working with Azure-specific
+  OpenAI services that require it.
+  Please refer to
+  the [KeyCredential Class documentation](https://learn.microsoft.com/java/api/com.azure.core.credential.keycredential?view=azure-java-stable)
+  for more information.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
index 509b9f3a111..0e41cd3679f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
@@ -5,83 +5,122 @@
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiExpression;
-import com.intellij.psi.PsiExpressionList;
-import com.intellij.psi.PsiLocalVariable;
 import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiNewExpression;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
-import com.intellij.psi.PsiTypeElement;
 import com.intellij.psi.PsiVariable;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.Arrays;
-
+/**
+ * This class is a LocalInspectionTool that checks if the endpoint method is used with KeyCredential for non-Azure OpenAI clients.
+ * If the endpoint method is used with KeyCredential for non-Azure OpenAI clients, a warning is registered.
+ */
 public class EndpointOnNonAzureOpenAIAuthCheck extends LocalInspectionTool {
 
+    /**
+     * This method builds the visitor for the inspection tool.
+     *
+     * @param holder     The ProblemsHolder object that holds the problems found by the inspection tool.
+     * @param isOnTheFly A boolean that indicates if the inspection tool is running on the fly. - this is not used in this implementation but is required by the method signature.
+     * @return The JavaElementVisitor object that will be used to visit the elements in the code.
+     */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new EndpointOnNonAzureOpenAIAuthVisitor(holder, isOnTheFly);
+        return new EndpointOnNonAzureOpenAIAuthVisitor(holder);
     }
 
-
+    /**
+     * This class is a JavaElementVisitor that visits the elements in the code and checks if the endpoint method is used with KeyCredential for non-Azure OpenAI clients.
+     */
     static class EndpointOnNonAzureOpenAIAuthVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
+        private static final RuleConfig RULE_CONFIG;
+
+        // The boolean that indicates if the rule should be skipped
+        private static final boolean SKIP_WHOLE_RULE;
 
-        EndpointOnNonAzureOpenAIAuthVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        /**
+         * Constructor for the visitor.
+         *
+         * @param holder The ProblemsHolder object that holds the problems found by the inspection tool.
+         */
+        EndpointOnNonAzureOpenAIAuthVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
+        // Static initializer block to load the configurations once
+        static {
+            String ruleName = "EndpointOnNonAzureOpenAIAuthCheck";
+            RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
+            // Get the RuleConfig object for the rule
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getMethodsToCheck().isEmpty();
+        }
+
+        /**
+         * This method visits the method call expressions in the code.
+         * If the method call expression is the endpoint method, the method call chain is checked to see if it is a non-Azure OpenAI client.
+         * If the method call chain uses the credential method with KeyCredential for non-Azure OpenAI clients, a warning is registered.
+         *
+         * @param expression The method call expression to visit.
+         */
         @Override
         public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
             super.visitMethodCallExpression(expression);
 
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
             PsiReferenceExpression methodExpression = expression.getMethodExpression();
             String methodName = methodExpression.getReferenceName();
 
-            System.out.println("methodName: " + methodName);
+            if (!(RULE_CONFIG.getMethodsToCheck().contains(methodName))) {
+                return;
+            }
 
+            // Check if the method is the endpoint method
             if ("endpoint".equals(methodName)) {
+
+                // Using KeyCredential indicates authentication of a non-Azure OpenAI client
+                // If the endpoint method is used with KeyCredential for non-Azure OpenAI clients, a warning is registered
                 if (isUsingKeyCredential(expression)) {
                     holder.registerProblem(expression, "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients");
                 }
             }
-
-
         }
 
+        /**
+         * This method checks if the method call chain uses the credential method with KeyCredential.
+         * If this is the case, the method call chain is checked to see if it is a non-Azure OpenAI client.
+         *
+         * @param expression The method call expression to check.
+         * @return True if the method call chain uses the credential method with KeyCredential, false otherwise.
+         */
         private static boolean isUsingKeyCredential(PsiMethodCallExpression expression) {
 
             // Iterating up the chain of method calls
             PsiExpression qualifier = expression.getMethodExpression().getQualifierExpression();
 
-            System.out.println("qualifier: " + qualifier);
-
-            // Check if the method call chain has the method to check -- need to traverse up and down
+            // Check if the method call chain has 'credential' method
             while (qualifier instanceof PsiMethodCallExpression) {
 
-                // Get the method expression
                 PsiReferenceExpression methodExpression = ((PsiMethodCallExpression) qualifier).getMethodExpression();
-                System.out.println("methodExpression: " + methodExpression);
-
                 PsiMethodCallExpression methodCall = (PsiMethodCallExpression) qualifier;
-                System.out.println("methodCall: " + methodCall);
-
-                // Get the method name
                 String methodName = methodExpression.getReferenceName();
-                System.out.println("methodName: " + methodName);
+
+                if (!(RULE_CONFIG.getMethodsToCheck().contains(methodName))) {
+                    return false;
+                }
 
                 if ("credential".equals(methodName)) {
 
-                    System.out.println("credential method found");
-                    PsiExpressionList argumentList = methodCall.getArgumentList();
-                    System.out.println("argumentList: " + argumentList);
-                    System.out.println("methodCall.getArgumentList(): " + methodCall.getArgumentList());
-                    System.out.println("methodCall: " + methodCall);
+                    // Check if the credential method is used with KeyCredential
                     PsiExpression[] arguments = methodCall.getArgumentList().getExpressions();
-                    System.out.println("arguments: " + arguments);
                     if (arguments.length == 1 && isKeyCredential(arguments[0])) {
                         return isNonAzureOpenAIClient(methodCall);
                     }
@@ -94,26 +133,42 @@ private static boolean isUsingKeyCredential(PsiMethodCallExpression expression)
             return false;
         }
 
+        /**
+         * This method checks if the expression is a KeyCredential.
+         *
+         * @param expression The expression to check.
+         * @return True if the expression is a KeyCredential, false otherwise.
+         */
         private static boolean isKeyCredential(PsiExpression expression) {
 
-            System.out.println("expression.getType().getCanonicalText()): " + expression.getType().getCanonicalText());
-            System.out.println("expression.getType()); " + expression.getType());
+            if (expression instanceof PsiNewExpression) {
+
+                // Cast the element to a new expression
+                PsiNewExpression newExpression = (PsiNewExpression) expression;
 
-            return expression.getType()!= null && expression.getType().getCanonicalText().equals("com.azure.core.credential.KeyCredential");
+                // Get the class reference name from the new expression
+                String classReference = newExpression.getClassReference().getReferenceName();
+                if (classReference != null) {
+                    return RULE_CONFIG.getServicesToCheck().contains(classReference);
+                }
+            }
+            return false;
         }
 
+        /**
+         * This method checks if the method call chain is on a non-Azure OpenAI client.
+         *
+         * @param expression The method call expression to check.
+         * @return True if the client is a non-Azure OpenAI client, false otherwise.
+         */
         private static boolean isNonAzureOpenAIClient(PsiMethodCallExpression expression) {
             PsiElement parent = expression.getParent();
-            System.out.println("parent: " + parent);
 
             while (parent != null) {
-                System.out.println("parent: " + parent);
                 if (parent instanceof PsiVariable) {
 
                     PsiType type = ((PsiVariable) parent).getType();
-                    System.out.println("type: " + type);
-                    System.out.println("type.getCanonicalText(): " + type.getCanonicalText());
-                    if(type != null){
+                    if (type != null) {
                         return type.getCanonicalText().startsWith("com.azure.ai.openai");
                     }
                 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index efa6841f495..c56deb5e60e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -79,7 +79,22 @@
     }
   },
   "SingleOperationInLoopCheck": {
-    "methods_to_check": ["detectLanguageBatch", "recognizeEntitiesBatch", "recognizePiiEntitiesBatch", "recognizeLinkedEntitiesBatch", "extractKeyPhrasesBatch", "analyzeSentimentBatch"],
+    "methods_to_check": [
+      "detectLanguageBatch",
+      "recognizeEntitiesBatch",
+      "recognizePiiEntitiesBatch",
+      "recognizeLinkedEntitiesBatch",
+      "extractKeyPhrasesBatch",
+      "analyzeSentimentBatch"
+    ],
     "anti_pattern_message": "Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: "
+  },
+  "EndpointOnNonAzureOpenAIAuthCheck": {
+    "methods_to_check": [
+      "endpoint",
+      "credential"
+    ],
+    "services_to_check": "KeyCredential",
+    "anti_pattern_message": "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients"
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
index f460a713deb..de88218ca1f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
@@ -2,11 +2,11 @@
 
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
-import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiExpressionList;
-import com.intellij.psi.PsiForStatement;
+import com.intellij.psi.PsiJavaCodeReferenceElement;
 import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiNewExpression;
 import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
 import com.intellij.psi.PsiVariable;
@@ -21,6 +21,16 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+/**
+ * This class is used to test the EndpointOnNonAzureOpenAIAuthCheck class.
+ * The EndpointOnNonAzureOpenAIAuthCheck class is a LocalInspectionTool that checks if the endpoint method is used with KeyCredential for non-Azure OpenAI clients.
+ * If the endpoint method is used with KeyCredential for non-Azure OpenAI clients, a warning is registered.
+ * An example that should be flagged is:
+ * OpenAI Client client = new OpenAIClientBuilder()
+ * .credential(new KeyCredential("key"))
+ * .endpoint("endpoint")
+ * .buildClient();
+ */
 public class EndpointOnNonAzureOpenAIAuthCheckTest {
 
     // Declare as instance variables
@@ -40,44 +50,60 @@ public void setup() {
         mockMethodCall = mock(PsiMethodCallExpression.class);
     }
 
+    /**
+     * This test checks if the endpoint method is used with KeyCredential for non-Azure OpenAI clients.
+     * If the endpoint method is used with KeyCredential for non-Azure OpenAI clients, a warning is registered.
+     */
     @Test
     public void testEndpointOnNonAzureOpenAIAuthCheck() {
 
         int numOfInvocation = 1;
         String endpoint = "endpoint";
         String credential = "credential";
-        String KeyCredentialPackageName = "com.azure.core.credential.KeyCredential";
+        String KeyCredentialPackageName = "KeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
         verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
     }
 
+    /**
+     * This test checks if the endpoint method is not used with KeyCredential for non-Azure OpenAI clients.
+     * If the endpoint method is not used with KeyCredential for non-Azure OpenAI clients, no warning is registered.
+     */
     @Test
-    public void testNoEndpoint(){
+    public void testNoEndpoint() {
 
         int numOfInvocation = 0;
         String endpoint = "notEndpoint";
         String credential = "credential";
-        String KeyCredentialPackageName = "com.azure.core.credential.KeyCredential";
+        String KeyCredentialPackageName = "KeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
         verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
     }
 
+    /**
+     * This test checks if the endpoint method is used but credential is not used.
+     * If the endpoint method is used but credential is not used, no warning is registered.
+     */
     @Test
-    public void testNoCredential(){
+    public void testNoCredential() {
 
         int numOfInvocation = 0;
         String endpoint = "endpoint";
         String credential = "notCredential";
-        String KeyCredentialPackageName = "com.azure.core.credential.KeyCredential";
+        String KeyCredentialPackageName = "KeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
         verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
     }
 
+    /**
+     * This test checks if the endpoint method is used with KeyCredential but for Azure OpenAI clients.
+     * If the endpoint method is used with KeyCredential but for Azure OpenAI clients, no warning is registered.
+     */
     @Test
-    public void testWithAzureKeyCredential(){
+    public void testWithAzureKeyCredential() {
 
         int numOfInvocation = 0;
         String endpoint = "endpoint";
@@ -88,32 +114,32 @@ public void testWithAzureKeyCredential(){
         verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
     }
 
-
-
+    /**
+     * creates a JavaElementVisitor object for visiting method call expressions
+     */
     private JavaElementVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        EndpointOnNonAzureOpenAIAuthVisitor mockVisitor = new EndpointOnNonAzureOpenAIAuthVisitor(mockHolder, isOnTheFly);
-        return mockVisitor;
+        return new EndpointOnNonAzureOpenAIAuthVisitor(mockHolder);
     }
 
-
+    /**
+     * This method verifies if the registerProblem method is called with the correct parameters
+     */
     private void verifyRegisterProblem(int numOfInvocation, String endpoint, String credential, String KeyCredentialPackageName, String azurePackageName) {
 
-
         PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
 
         PsiMethodCallExpression qualifierOne = mock(PsiMethodCallExpression.class);
         PsiReferenceExpression methodExpressionOne = mock(PsiReferenceExpression.class);
 
-        PsiExpression expression = mock(PsiExpression.class);
+        PsiNewExpression newExpression = mock(PsiNewExpression.class);
         PsiExpressionList argumentList = mock(PsiExpressionList.class);
-        PsiExpression[] arguments = new PsiExpression[]{expression};
+        PsiExpression[] arguments = new PsiExpression[]{newExpression};
+
+        PsiJavaCodeReferenceElement classReference = mock(PsiJavaCodeReferenceElement.class);
 
-        PsiType type = mock(PsiType.class);
         PsiVariable parent = mock(PsiVariable.class);
         PsiType qualifierTYpe = mock(PsiType.class);
 
-
         when(mockMethodCall.getMethodExpression()).thenReturn(methodExpression);
         when(methodExpression.getReferenceName()).thenReturn(endpoint);
 
@@ -127,8 +153,9 @@ private void verifyRegisterProblem(int numOfInvocation, String endpoint, String
         when(argumentList.getExpressions()).thenReturn(arguments);
 
         // isKeyCredential
-        when(expression.getType()).thenReturn(type);
-        when(type.getCanonicalText()).thenReturn(KeyCredentialPackageName);
+
+        when(newExpression.getClassReference()).thenReturn(classReference);
+        when(classReference.getReferenceName()).thenReturn(KeyCredentialPackageName);
 
         // isNonAzureOpenAIClient
         when(qualifierOne.getParent()).thenReturn(parent);
@@ -138,7 +165,5 @@ private void verifyRegisterProblem(int numOfInvocation, String endpoint, String
         mockVisitor.visitMethodCallExpression(mockMethodCall);
 
         verify(mockHolder, times(numOfInvocation)).registerProblem(mockMethodCall, "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients");
-
-
     }
 }

From 5cf5e7bed91bcfb6e91cd6bb876d24a78c748b70 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 23 Jul 2024 20:42:58 -0700
Subject: [PATCH 126/144] address PR comments

---
 ...iesWithTimeIntervalInQueryStringCheck.java | 23 +++++++++++--------
 ...ithTimeIntervalInQueryStringCheckTest.java |  3 +--
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index 71ec4245409..21867eef1e9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -19,6 +19,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.regex.Pattern;
 
@@ -42,13 +43,17 @@ public class KustoQueriesWithTimeIntervalInQueryStringCheck extends LocalInspect
      * This method builds the visitor for the inspection tool
      *
      * @param holder     ProblemsHolder is used to register problems found in the code
-     * @param isOnTheFly boolean to indicate if the inspection is done on the fly -
+     * @param isOnTheFly boolean to indicate if the inspection is done on the fly - THis is not used in this implementation but is required by the method signature
      * @return PsiElementVisitor
      */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new KustoQueriesVisitor(holder, isOnTheFly);
+
+        // clear the timeIntervalParameters list in every visit
+        KustoQueriesVisitor.timeIntervalParameters.clear();
+
+        return new KustoQueriesVisitor(holder);
     }
 
     /**
@@ -65,7 +70,7 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
 
         // // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
-        private static final List<Pattern> REGEX_PATTERNS = new ArrayList<>();
+        private static final List<Pattern> REGEX_PATTERNS;
         private static final boolean SKIP_WHOLE_RULE;
 
         static {
@@ -76,25 +81,25 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
             RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
 
             List<String> regexPatterns = RULE_CONFIG.getListedItemsToCheck();
+            List<Pattern> tempPatterns = new ArrayList<>();
             // Compile the regex patterns
             for (String pattern : regexPatterns) {
-                REGEX_PATTERNS.add(Pattern.compile(pattern));
+                tempPatterns.add(Pattern.compile(pattern));
             }
-
+            REGEX_PATTERNS = Collections.unmodifiableList(tempPatterns);
             SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || REGEX_PATTERNS.isEmpty();
         }
 
         // empty list to store time interval parameter names
-        private final List<String> timeIntervalParameters = new ArrayList<>();
+        private static final List<String> timeIntervalParameters = new ArrayList<>();
 
         /**
          * Constructor for the KustoQueriesVisitor class
          * The constructor initializes the ProblemsHolder and isOnTheFly variables
          *
-         * @param holder     - ProblemsHolder is used to register problems found in the code
-         * @param isOnTheFly - boolean to indicate if the inspection is done on the fly - This is not used in this implementation
+         * @param holder - ProblemsHolder is used to register problems found in the code
          */
-        KustoQueriesVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        KustoQueriesVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
index f59b7b06642..4e2ccddedad 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheckTest.java
@@ -121,8 +121,7 @@ public void testCheckExpressionWithNullExpression() {
      * @return PsiElementVisitor
      */
     private KustoQueriesVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        KustoQueriesVisitor visitor = new KustoQueriesVisitor(mockHolder, isOnTheFly);
+        KustoQueriesVisitor visitor = new KustoQueriesVisitor(mockHolder);
         return visitor;
     }
 

From 02a8cf28cb78f74ace8184717d3c58c47e722897 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Wed, 24 Jul 2024 21:06:36 -0700
Subject: [PATCH 127/144] update to implementation

---
 .../UseOfBlockOnAsyncClientsCheck.java        | 90 ++++++++++++-------
 1 file changed, 60 insertions(+), 30 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
index 6efc4eee5e1..c320998ca8c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -4,10 +4,12 @@
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiClassType;
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiMethodCallExpression;
 
 import com.intellij.psi.PsiType;
+import com.intellij.psi.util.InheritanceUtil;
 import com.intellij.psi.util.PsiTreeUtil;
 import org.jetbrains.annotations.NotNull;
 import org.json.JSONArray;
@@ -63,7 +65,8 @@ public static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
 
         /**
          * Constructor to initialize the visitor with the holder and isOnTheFly flag.
-         * @param holder ProblemsHolder
+         *
+         * @param holder     ProblemsHolder
          * @param isOnTheFly boolean
          */
         public UseOfBlockOnAsyncClientsVisitor(ProblemsHolder holder, boolean isOnTheFly) {
@@ -74,6 +77,7 @@ public UseOfBlockOnAsyncClientsVisitor(ProblemsHolder holder, boolean isOnTheFly
         /**
          * Visit method call expressions to check for the use of block() method on async clients.
          * This method will check if the method call is block() and if it is used in an async context.
+         *
          * @param expression
          */
         @Override
@@ -87,9 +91,9 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 // Check if the method call is block() or a variant of block() method
                 if (methodCall.getMethodExpression().getReferenceName().startsWith("block")) {
                     boolean isAsyncContext = checkIfAsyncContext(methodCall);
-
-                    // Check if the method call is on an Azure SDK client and is in an async context
-                    if (isAsyncContext && isAzureClient(methodCall)) {
+                    System.out.println("isAsyncContext: " + isAsyncContext);
+                    if (isAsyncContext) {
+                        // Report the problem
                         holder.registerProblem(expression, ANTI_PATTERN_MESSAGE);
                     }
                 }
@@ -99,58 +103,84 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
         /**
          * Helper method to check if the method call is within an async context.
          * This method will check if the method call is on a reactive type like Mono, Flux, etc.
+         *
          * @param methodCall
          * @return true if the method call is on a reactive type, false otherwise
          */
         private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
-            PsiExpression expression = methodCall.getMethodExpression().getQualifierExpression();
+            PsiExpression qualifierExpression = methodCall.getMethodExpression().getQualifierExpression();
+
+            System.out.println("qualifierExpression: " + qualifierExpression);
+
+            if (qualifierExpression instanceof PsiMethodCallExpression) {
+                PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifierExpression;
+                System.out.println("qualifierMethodCall: " + qualifierMethodCall);
 
-            // Check if the method call is on a reactive type
-            if (expression != null) {
-                PsiType type = expression.getType();
+                // Get the type of the qualifier method call
+                PsiType qualifierReturnType = qualifierMethodCall.getType();
+                System.out.println("qualifierReturnType: " + qualifierReturnType);
 
-                // Check if the type is a reactive type
-                if (type != null) {
-                    String typeName = type.getCanonicalText();
+                if (qualifierReturnType instanceof PsiClassType) {
+                    PsiClass qualifierReturnTypeClass = ((PsiClassType) qualifierReturnType).resolve();
+                    System.out.println("qualifierReturnTypeClass: " + qualifierReturnTypeClass);
 
-                    // Check for common async/reactive types directly in the list asyncReturnTypes
-                    for (String asyncReturnType : ASYNC_RETURN_TYPES) {
-                        if (typeName.contains(asyncReturnType)) {
+                    if (qualifierReturnTypeClass != null && isSubclassOfMonoOrFlux(qualifierReturnTypeClass)) {
+
+                        if (isAzureAsyncClient(qualifierMethodCall)) {
+                            System.out.println("isAzureAsyncClient: " + qualifierMethodCall);
+
+                            // Report the problem
                             return true;
                         }
                     }
                 }
             }
+
             return false;
         }
 
-        /**
-         * Helper method to check if the method call is on an Azure SDK client.
-         * This method will check if the method call is on a class that is part of the Azure SDK.
-         * @param methodCall
-         * @return true if the method call is on an Azure SDK client, false otherwise
-         */
-        private boolean isAzureClient(@NotNull PsiMethodCallExpression methodCall) {
-            PsiClass containingClass = PsiTreeUtil.getParentOfType(methodCall, PsiClass.class);
+        private boolean isAzureAsyncClient(PsiMethodCallExpression qualifierMethodCall) {
+
+            // Get the expression that calls the method returning a reactive type
+            PsiExpression clientExpression = qualifierMethodCall.getMethodExpression().getQualifierExpression();
+            System.out.println("clientExpression: " + clientExpression);
+
+            if (clientExpression != null) {
+                PsiType clientType = clientExpression.getType();
+                System.out.println("clientType: " + clientType);
 
-            // Check if the method call is on a class
-            if (containingClass != null) {
-                String className = containingClass.getQualifiedName();
+                if (clientType instanceof PsiClassType) {
+                    PsiClass clientClass = ((PsiClassType) clientType).resolve();
+                    System.out.println("clientClass: " + clientClass);
 
-                // Check if the class is part of the Azure SDK
-                if (className != null && className.startsWith("com.azure.")) {
-                    return true;
+                    if (clientClass != null && clientClass.getQualifiedName().startsWith("com.azure.") && clientClass.getQualifiedName().endsWith("AsyncClient")) {
+                        return true;
+                    }
                 }
             }
             return false;
         }
 
-        /** helper method to load config from json
+        /**
+         * Helper method to check if the class is a subclass of Mono or Flux.
+         *
+         * @param psiClass
+         * @return true if the class is a subclass of Mono or Flux, false otherwise
+         */
+        private boolean isSubclassOfMonoOrFlux(PsiClass psiClass) {
+            System.out.println("psiClass: " + psiClass);
+            return InheritanceUtil.isInheritor(psiClass, "reactor.core.publisher.Mono") ||
+                    InheritanceUtil.isInheritor(psiClass, "reactor.core.publisher.Flux");
+        }
+
+
+        /**
+         * helper method to load config from json
          *
          * @return Map<String, Object>
          * @throws IOException
          */
-        private static  Map<String, Object> getAsyncReturnTypesToCheck() throws IOException {
+        private static Map<String, Object> getAsyncReturnTypesToCheck() throws IOException {
 
             //load json object
             JSONObject jsonObject = LoadJsonConfigFile.getInstance().getJsonObject();

From 366983011b27b0d19df8685d1827b7d45094034a Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 25 Jul 2024 15:09:14 -0700
Subject: [PATCH 128/144] address PR comments

---
 .../EndpointOnNonAzureOpenAIAuthCheck.java    |  2 +-
 .../azure-intellij-plugin-azure-sdk.xml       |  2 +-
 .../main/resources/META-INF/ruleConfigs.json  |  6 +++---
 ...EndpointOnNonAzureOpenAIAuthCheckTest.java | 20 +++++++++----------
 4 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
index 0e41cd3679f..b59f3b8108c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheck.java
@@ -89,7 +89,7 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 // Using KeyCredential indicates authentication of a non-Azure OpenAI client
                 // If the endpoint method is used with KeyCredential for non-Azure OpenAI clients, a warning is registered
                 if (isUsingKeyCredential(expression)) {
-                    holder.registerProblem(expression, "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients");
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index a75c6f60eb7..2a9110a0799 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -211,7 +211,7 @@
         <localInspection
                 language="JAVA"
                 shortName="EndpointOnNonAzureOpenAIAuthCheck"
-                displayName="Endpoint On Non-Azure OpenAI Auth Check"
+                displayName="Endpoint On Non-Azure OpenAI Authentication Check"
                 groupName="Azure SDK"
                 enabledByDefault="true"
                 level="WARNING"
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 7e0843aebc7..a54a2732d87 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -111,11 +111,11 @@
     "solution": "Use the QueryTimeInterval parameter in the client method parameters to specify the time interval for the query"
   },
   "EndpointOnNonAzureOpenAIAuthCheck": {
-    "methods_to_check": [
+    "methodsToCheck": [
       "endpoint",
       "credential"
     ],
-    "services_to_check": "KeyCredential",
-    "anti_pattern_message": "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients"
+    "servicesToCheck": "KeyCredential",
+    "antiPatternMessage": "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients"
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
index de88218ca1f..abfa8021ddb 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/EndpointOnNonAzureOpenAIAuthCheckTest.java
@@ -60,10 +60,10 @@ public void testEndpointOnNonAzureOpenAIAuthCheck() {
         int numOfInvocation = 1;
         String endpoint = "endpoint";
         String credential = "credential";
-        String KeyCredentialPackageName = "KeyCredential";
+        String keyCredentialPackageName = "KeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
-        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, keyCredentialPackageName, azurePackageName);
     }
 
     /**
@@ -76,10 +76,10 @@ public void testNoEndpoint() {
         int numOfInvocation = 0;
         String endpoint = "notEndpoint";
         String credential = "credential";
-        String KeyCredentialPackageName = "KeyCredential";
+        String keyCredentialPackageName = "KeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
-        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, keyCredentialPackageName, azurePackageName);
     }
 
     /**
@@ -92,10 +92,10 @@ public void testNoCredential() {
         int numOfInvocation = 0;
         String endpoint = "endpoint";
         String credential = "notCredential";
-        String KeyCredentialPackageName = "KeyCredential";
+        String keyCredentialPackageName = "KeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
-        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, keyCredentialPackageName, azurePackageName);
     }
 
     /**
@@ -108,10 +108,10 @@ public void testWithAzureKeyCredential() {
         int numOfInvocation = 0;
         String endpoint = "endpoint";
         String credential = "notCredential";
-        String KeyCredentialPackageName = "com.azure.core.credential.AzureKeyCredential";
+        String keyCredentialPackageName = "com.azure.core.credential.AzureKeyCredential";
         String azurePackageName = "com.azure.ai.openai";
 
-        verifyRegisterProblem(numOfInvocation, endpoint, credential, KeyCredentialPackageName, azurePackageName);
+        verifyRegisterProblem(numOfInvocation, endpoint, credential, keyCredentialPackageName, azurePackageName);
     }
 
     /**
@@ -124,7 +124,7 @@ private JavaElementVisitor createVisitor() {
     /**
      * This method verifies if the registerProblem method is called with the correct parameters
      */
-    private void verifyRegisterProblem(int numOfInvocation, String endpoint, String credential, String KeyCredentialPackageName, String azurePackageName) {
+    private void verifyRegisterProblem(int numOfInvocation, String endpoint, String credential, String keyCredentialPackageName, String azurePackageName) {
 
         PsiReferenceExpression methodExpression = mock(PsiReferenceExpression.class);
 
@@ -155,7 +155,7 @@ private void verifyRegisterProblem(int numOfInvocation, String endpoint, String
         // isKeyCredential
 
         when(newExpression.getClassReference()).thenReturn(classReference);
-        when(classReference.getReferenceName()).thenReturn(KeyCredentialPackageName);
+        when(classReference.getReferenceName()).thenReturn(keyCredentialPackageName);
 
         // isNonAzureOpenAIClient
         when(qualifierOne.getParent()).thenReturn(parent);

From dec4ca174c910b513683c6d7b05a60f1e32b35e8 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 25 Jul 2024 15:12:30 -0700
Subject: [PATCH 129/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md                 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index b72c5aeeeed..d5bd9b38543 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -255,8 +255,8 @@ integration, telemetry connectivity, and Azure Toolkit integration.
 - **Issue**: KeyCredential is the only required parameter in `.credential(KeyCredential)` for authenticating requests to
   non-Azure OpenAI APIs.
 - **Severity: WARNING**
-- **Recommendation**: Omit Endpoint: Do not specify the endpoint parameter unless you are working with Azure-specific
-  OpenAI services that require it.
+- **Recommendation**: Omit Endpoint: Only specify the endpoint parameter if you are working with Azure OpenAI services
+  that require it. Otherwise, it is not necessary to authenticate non-Azure Open-AI clients.
   Please refer to
   the [KeyCredential Class documentation](https://learn.microsoft.com/java/api/com.azure.core.credential.keycredential?view=azure-java-stable)
   for more information.
\ No newline at end of file

From 86bfbeb9de07a089635e646ffc17302284da0e83 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 25 Jul 2024 17:20:38 -0700
Subject: [PATCH 130/144] complete implementation with tests

---
 .../azure-intellij-plugin-azure-sdk/README.md |  15 +-
 .../azure/sdk/buildtool/RuleConfigLoader.java |   9 +-
 .../UseOfBlockOnAsyncClientsCheck.java        | 132 +++++++-------
 .../main/resources/META-INF/ruleConfigs.json  |   9 +-
 .../UseOfBlockOnAsyncClientsCheckTest.java    | 165 +++++++++++-------
 5 files changed, 188 insertions(+), 142 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index d5bd9b38543..a7f0ff2a231 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -259,4 +259,17 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   that require it. Otherwise, it is not necessary to authenticate non-Azure Open-AI clients.
   Please refer to
   the [KeyCredential Class documentation](https://learn.microsoft.com/java/api/com.azure.core.credential.keycredential?view=azure-java-stable)
-  for more information.
\ No newline at end of file
+  for more information.
+
+14. #### Use sync client operation if calling block methods on an async client.
+
+- **Anti-Pattern**: Using `block()` on an async client. This practice turns an asynchronous operation into a synchronous
+  one.
+- **Issue**: The use of `block()` goes against the non-blocking nature of reactive streams.
+  It can lead to performance issues because it blocks one of the few available threads.
+  In reactive applications, avoiding blocking operations is crucial for scalability and responsiveness.
+- **Severity Level: WARNING**
+- **Recommendation**: If you find yourself frequently using `block()` in your code, consider switching to the sync
+  client.
+  The sync client performs operations synchronously without requiring `block()`.
+  Using the sync client can make your code more straightforward and easier to understand.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 5d7604f5f65..a8eae759b5d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -157,11 +157,12 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                 case "servicesToCheck":
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
-                case "regexPatterns":
-                    listedItemsToCheck = getValuesFromJsonReader(reader);
-                    break;
                 default:
-                    if (fieldName.endsWith("Check")) {
+                    if (fieldName == "typesToCheck") {
+                        listedItemsToCheck = getListFromJsonArray(reader);
+                    } else if (fieldName == "regexPatterns") {
+                        listedItemsToCheck = getValuesFromJsonReader(reader);
+                    } else if (fieldName.endsWith("Check")) {
                         // Move to the next token to process the nested object
                         reader.nextToken();
                         antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
index b52d332d9f1..0b1b0cca699 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -8,38 +8,37 @@
 import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiMethodCallExpression;
 
+import com.intellij.psi.PsiReferenceExpression;
 import com.intellij.psi.PsiType;
-import com.intellij.psi.util.InheritanceUtil;
-import com.intellij.psi.util.PsiTreeUtil;
 import org.jetbrains.annotations.NotNull;
-import org.json.JSONArray;
-import org.json.JSONObject;
-
-import java.io.IOException;
-import java.util.List;
-import java.util.Map;
-
 
 /**
- * Inspection to check for the use of block() method on async clients in Azure SDK.
- * This inspection will check for the use of block() method on reactive types like Mono, Flux, etc.
+ * Inspection tool to check for the use of block() method on async clients in Azure SDK.
  */
 public class UseOfBlockOnAsyncClientsCheck extends LocalInspectionTool {
 
+    /**
+     * This method is used to get the visitor for the inspection tool.
+     * The visitor is used to check for the use of block() method on async clients in Azure SDK.
+     * The visitor checks if the method call is a block() method call on a reactive type
+     * and if the reactive type is an async client in Azure SDK.
+     * If the method call is a block() method call on an async client, it reports a problem.
+     */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new UseOfBlockOnAsyncClientsVisitor(holder, isOnTheFly);
+        return new UseOfBlockOnAsyncClientsVisitor(holder);
     }
 
     /**
      * Visitor to check for the use of block() method on async clients in Azure SDK.
+     * The visitor checks if the method call is a block() method call on a reactive type
+     * and if the reactive type is an async client in Azure SDK.
+     * If the method call is a block() method call on an async client, it reports a problem.
      */
-    public static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
+    static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
-        private final boolean isOnTheFly;
-
 
         // Define constants for string literals
         private static final RuleConfig RULE_CONFIG;
@@ -55,113 +54,112 @@ public static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
         }
 
         /**
-         * Constructor to initialize the visitor with the holder and isOnTheFly flag.
+         * Constructor to initialize the visitor with the holder
          *
-         * @param holder     ProblemsHolder
-         * @param isOnTheFly boolean
+         * @param holder ProblemsHolder - the holder to report the problems
          */
-        UseOfBlockOnAsyncClientsVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        UseOfBlockOnAsyncClientsVisitor(ProblemsHolder holder) {
             this.holder = holder;
-            this.isOnTheFly = isOnTheFly;
         }
 
         /**
-         * Visit method call expressions to check for the use of block() method on async clients.
-         * This method will check if the method call is block() and if it is used in an async context.
+         * This method is used to visit the method call expression.
+         * The method call expression is checked to see if it is a block() method call on an async client.
+         * If the method call is a block() method call on an async client, it reports a problem.
          *
-         * @param expression
+         * @param expression PsiMethodCallExpression - the method call expression to visit
          */
         @Override
         public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
             super.visitMethodCallExpression(expression);
 
-            // Check if the element is a method call expression
-            if (expression instanceof PsiMethodCallExpression) {
-                PsiMethodCallExpression methodCall = expression;
-
-                // Check if the method call is block() or a variant of block() method
-                if (methodCall.getMethodExpression().getReferenceName().startsWith("block")) {
-                    boolean isAsyncContext = checkIfAsyncContext(methodCall);
-                    System.out.println("isAsyncContext: " + isAsyncContext);
-                    if (isAsyncContext) {
-                        // Report the problem
-                        holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
-                    }
+            if (SKIP_WHOLE_RULE) {
+                return;
+            }
+
+            // Check if the method call is block() or a variant of block() method
+            if (expression.getMethodExpression().getReferenceName().startsWith(RULE_CONFIG.getMethodsToCheck().get(0))) {
+
+                // Check if the method call is on a reactive type
+                boolean isAsyncContext = checkIfAsyncContext(expression);
+
+                if (isAsyncContext) {
+                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
                 }
             }
         }
 
         /**
-         * Helper method to check if the method call is within an async context.
-         * This method will check if the method call is on a reactive type like Mono, Flux, etc.
+         * This method is used to check if the method call is a block() method call on a reactive type.
+         * The method call is checked to see if it is a block() method call on a reactive type
+         * and if the reactive type is an async client in Azure SDK.
          *
-         * @param methodCall
-         * @return true if the method call is on a reactive type, false otherwise
+         * @param methodCall PsiMethodCallExpression - the method call expression to check
+         * @return true if the method call is a block() method call on an async client, false otherwise
          */
         private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
-            PsiExpression qualifierExpression = methodCall.getMethodExpression().getQualifierExpression();
 
-            System.out.println("qualifierExpression: " + qualifierExpression);
+            // Get the qualifier expression of the method call -- the expression before the 'block' method call
+            PsiExpression qualifierExpression = methodCall.getMethodExpression().getQualifierExpression();
 
             if (qualifierExpression instanceof PsiMethodCallExpression) {
                 PsiMethodCallExpression qualifierMethodCall = (PsiMethodCallExpression) qualifierExpression;
-                System.out.println("qualifierMethodCall: " + qualifierMethodCall);
 
-                // Get the type of the qualifier method call
+                // Get the return type of the qualifier method call
                 PsiType qualifierReturnType = qualifierMethodCall.getType();
-                System.out.println("qualifierReturnType: " + qualifierReturnType);
 
                 if (qualifierReturnType instanceof PsiClassType) {
                     PsiClass qualifierReturnTypeClass = ((PsiClassType) qualifierReturnType).resolve();
-                    System.out.println("qualifierReturnTypeClass: " + qualifierReturnTypeClass);
-
-                    if (qualifierReturnTypeClass != null && isSubclassOfMonoOrFlux(qualifierReturnTypeClass)) {
 
-                        if (isAzureAsyncClient(qualifierMethodCall)) {
-                            System.out.println("isAzureAsyncClient: " + qualifierMethodCall);
+                    // Check if the return type is a subclass of Mono or Flux
+                    if (qualifierReturnTypeClass != null && isReactiveType(qualifierReturnTypeClass)) {
 
-                            // Report the problem
-                            return true;
-                        }
+                        return isAzureAsyncClient(qualifierMethodCall);
                     }
                 }
             }
-
             return false;
         }
 
+        /**
+         * This method is used to check if the method call is on an async client in Azure SDK.
+         * The method call is checked to see if it is on an async client in Azure SDK.
+         *
+         * @param qualifierMethodCall PsiMethodCallExpression - the method call expression to check
+         * @return true if the method call is on an async client in Azure SDK, false otherwise
+         */
         private boolean isAzureAsyncClient(PsiMethodCallExpression qualifierMethodCall) {
 
             // Get the expression that calls the method returning a reactive type
             PsiExpression clientExpression = qualifierMethodCall.getMethodExpression().getQualifierExpression();
-            System.out.println("clientExpression: " + clientExpression);
 
-            if (clientExpression != null) {
+            // Travel up the method call chain to get the client expression
+            while (clientExpression instanceof PsiMethodCallExpression) {
+
+                clientExpression = ((PsiMethodCallExpression) clientExpression).getMethodExpression().getQualifierExpression();
+            }
+
+            // a ReferenceExpression is the last expression in the chain - the client object
+            if (clientExpression instanceof PsiReferenceExpression) {
                 PsiType clientType = clientExpression.getType();
-                System.out.println("clientType: " + clientType);
 
                 if (clientType instanceof PsiClassType) {
                     PsiClass clientClass = ((PsiClassType) clientType).resolve();
-                    System.out.println("clientClass: " + clientClass);
 
-                    if (clientClass != null && clientClass.getQualifiedName().startsWith("com.azure.") && clientClass.getQualifiedName().endsWith("AsyncClient")) {
-                        return true;
-                    }
+                    return clientClass != null && clientClass.getQualifiedName().startsWith(RuleConfig.AZURE_PACKAGE_NAME) && clientClass.getQualifiedName().endsWith("AsyncClient");
                 }
             }
             return false;
         }
 
         /**
-         * Helper method to check if the class is a subclass of Mono or Flux.
+         * Helper method to check if the class / return type is a subclass of Mono or Flux.
          *
-         * @param psiClass
+         * @param psiClass PsiClass - the class to check
          * @return true if the class is a subclass of Mono or Flux, false otherwise
          */
-        private boolean isSubclassOfMonoOrFlux(PsiClass psiClass) {
-            System.out.println("psiClass: " + psiClass);
-            return InheritanceUtil.isInheritor(psiClass, "reactor.core.publisher.Mono") ||
-                    InheritanceUtil.isInheritor(psiClass, "reactor.core.publisher.Flux");
+        private boolean isReactiveType(PsiClass psiClass) {
+            return RULE_CONFIG.getListedItemsToCheck().contains(psiClass.getQualifiedName());
         }
     }
-}
\ No newline at end of file
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d3c233bf0b5..a10ed9e51ce 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -123,10 +123,11 @@
     "antiPatternMessage": "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients"
   },
   "UseOfBlockOnAsyncClientsCheck": {
-    "async_return_types_to_check": [
-      "Flux",
-      "Mono"
+    "methodsToCheck": "block",
+    "typesToCheck": [
+      "reactor.core.publisher.Flux",
+      "reactor.core.publisher.Mono"
     ],
-    "antipattern_message": "Use of block methods on asynchronous clients detected. Switch to synchronous APIs instead."
+    "antiPatternMessage": "Use of block methods on asynchronous clients detected. Switch to synchronous APIs instead."
   }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
index 1e87a9618fa..f52eff7ff8b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
@@ -1,21 +1,19 @@
 package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import com.intellij.psi.PsiClassType;
 import com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UseOfBlockOnAsyncClientsCheck.UseOfBlockOnAsyncClientsVisitor;
 
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.psi.JavaElementVisitor;
 import com.intellij.psi.PsiClass;
-import com.intellij.psi.PsiExpression;
 import com.intellij.psi.PsiMethodCallExpression;
 import com.intellij.psi.PsiReferenceExpression;
-import com.intellij.psi.PsiType;
-import com.intellij.psi.util.PsiTreeUtil;
+
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
 import org.mockito.Mockito;
 
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
@@ -25,20 +23,25 @@
  * This class is used to test the UseOfBlockOnAsyncClientsCheck class.
  * The UseOfBlockOnAsyncClientsCheck class is an inspection tool that checks for the use of block() method on async clients in Azure SDK.
  * This inspection will check for the use of block() method on reactive types like Mono, Flux, etc.
- * 1. Flux<ByteBuffer> downloadFlux = blobAsyncClient.download()
- *                 .doOnComplete(() -> System.out.println("Download complete"))
- *                 .doOnError(error -> System.err.println("Error downloading file: " + error.getMessage()));
+ *  This is an example of what should be flagged:
  *
- *             // This call should be flagged
- *             downloadFlux.blockFirst();
+ *  private ServiceBusReceiverAsyncClient receiver;
+ *  receiver.complete(received).block(Duration.ofSeconds(15));
  *
- * 2. // Download a file from Azure Blob Storage using the async client
- *             Mono<Void> downloadMono = blobAsyncClient.downloadToFile("downloadedFilePath")
- *                 .doOnSuccess(response -> System.out.println("File downloaded successfully"))
- *                 .doOnError(error -> System.err.println("Error downloading file: " + error.getMessage()));
+ *  private final ServiceBusReceiverAsyncClient client;
+ *  try {
+ *                 if (isComplete) {
+ *                     client.complete(message)
+ *                         .doOnSuccess(success -> System.out.println("Message completed successfully"))
+ *                         .doOnError(error -> System.err.println("Error completing message: " + error.getMessage()))
+ *                         .log()
+ *                         .timeout(Duration.ofSeconds(30))
+ *                         .retry(3)
+ *                         .block();
  *
- *             // This call should also be flagged by the inspection tool
- *             downloadMono.blockOptional();
+ *                 } else {
+ *                     client.abandon(message).block();
+ *                 }
  */
 public class UseOfBlockOnAsyncClientsCheckTest {
 
@@ -60,56 +63,51 @@ public void setup() {
     }
 
     /**
-     * This is the main test method that tests the KustoQueriesWithTimeIntervalInQueryStringCheck class.
+     * This is the main test method that tests the use of block() method on async clients.
+     * This method should be flagged by the inspection tool as it is a block() method call on an async client.
      */
     @Test
-    public void testUseOfBlockOnAsyncClientsVisitor() {
-
-        // assert visitor
-        assertVisitor();
+    public void testUseOfBlockOnAsyncClient() {
 
         int numberOfInvocations = 1;
         String methodName = "block";
-        String packageName = "com.azure.";
+        String clientPackageName = "com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient";
+        String reactivePackageName = "reactor.core.publisher.Flux";
 
         // verify register problem
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, clientPackageName, numberOfInvocations, reactivePackageName);
     }
 
     /**
      * This test method tests the use of blockOptional() method on async clients.
-     * This method should be flagged by the inspection tool.
+     * This method should be flagged by the inspection tool as it is a blockOptional() method call on an async client.
      */
     @Test
-    public void testUseOfDifferentBlockOnAsyncClientsVisitor() {
-
-        // assert visitor
-        assertVisitor();
+    public void testUseOfDifferentBlockOnAsyncClient() {
 
         int numberOfInvocations = 1;
         String methodName = "blockOptional";
-        String packageName = "com.azure.";
+        String clientPackageName = "com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient";
+        String reactivePackageName = "reactor.core.publisher.Mono";
 
         // verify register problem
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, clientPackageName, numberOfInvocations, reactivePackageName);
     }
 
     /**
      * This test method tests the use of blockFirst() method on non-azure async clients.
-     * This method should not be flagged by the inspection tool.
+     * This method should not be flagged by the inspection tool
      */
     @Test
-    public void testUseOfBlockOnAsyncClientsVisitorWithNonAzureClient() {
-
-        // assert visitor
-        assertVisitor();
+    public void testBlockOnAsyncClientsWithNonAzureClient() {
 
         int numberOfInvocations = 0;
         String methodName = "blockFirst";
-        String packageName = "com.notAzure.";
+        String clientPackageName = "com.notAzure.";
+        String reactivePackageName = "reactor.core.publisher.Flux";
 
         // verify register problem
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, clientPackageName, numberOfInvocations, reactivePackageName);
     }
 
     /**
@@ -119,57 +117,93 @@ public void testUseOfBlockOnAsyncClientsVisitorWithNonAzureClient() {
     @Test
     public void testVisitOnDifferentMethodCall() {
 
-        // assert visitor
-        assertVisitor();
-
         int numberOfInvocations = 0;
         String methodName = "nonBlockingMethod";
-        String packageName = "com.azure.";
+        String clientPackageName = "com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient";
+        String reactivePackageName = "reactor.core.publisher.Flux";
 
         // verify register problem
-        verifyRegisterProblem(methodName, packageName, numberOfInvocations);
+        verifyRegisterProblem(methodName, clientPackageName, numberOfInvocations, reactivePackageName);
     }
 
-    /** Create a visitor object for the test
-     * @return JavaElementVisitor
+    /**
+     * This test method tests the use of block() method on a non-reactive type.
+     * This method should not be flagged by the inspection tool.
      */
-    private JavaElementVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        UseOfBlockOnAsyncClientsVisitor visitor = new UseOfBlockOnAsyncClientsCheck.UseOfBlockOnAsyncClientsVisitor(mockHolder, isOnTheFly);
-        return visitor;
+    @Test
+    public void testBlockOnNonReactiveType() {
+        int numberOfInvocations = 0;
+        String methodName = "block";
+        String clientPackageName = "com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient";
+        String nonReactivePackageName = "java.util.List";
+
+        // verify register problem
+        verifyRegisterProblem(methodName, clientPackageName, numberOfInvocations, nonReactivePackageName);
     }
 
-    /** Assert that the visitor object is not null and is an instance of JavaElementVisitor
-     * @return void
+    /**
+     * This test method tests the use of block() method on a non-async client.
+     * This method should not be flagged by the inspection tool.
+     */
+    @Test
+    public void testBlockOnAzureNonAsyncClient() {
+        int numberOfInvocations = 0;
+        String methodName = "block";
+        String nonAsyncClientPackageName = "com.azure.messaging.servicebus.ServiceBusReceiverClient";
+        String reactivePackageName = "reactor.core.publisher.Mono";
+
+        // verify register problem
+        verifyRegisterProblem(methodName, nonAsyncClientPackageName, numberOfInvocations, reactivePackageName);
+    }
+
+    /**
+     * Create a visitor object for the test
+     *
+     * @return JavaElementVisitor
      */
-    private void assertVisitor() {
-        assertNotNull(mockVisitor);
-        assertTrue(mockVisitor instanceof JavaElementVisitor);
+    private JavaElementVisitor createVisitor() {
+        return new UseOfBlockOnAsyncClientsVisitor(mockHolder);
     }
 
-    /** Verify that the registerProblem method is called the expected number of times
-     * @param methodName The name of the method call -- used to determine if the method call is a block method
-     * @param packageName The package name of the class containing the method call -- used to determine if the client is an Azure SDK client
-     * @param numberOfInvocations Number of times registerProblem should be called
+    /**
+     * This method is used to verify the registerProblem method is called when the method call is a block() method call on an async client.
+     *
+     * @param methodName          String - the name of the method called
+     * @param clientPackageName   String - the package name of the async client
+     * @param numberOfInvocations int - the number of times registerProblem should be called
+     * @param reactivePackageName String - the package name of the reactive type
      */
-    private void verifyRegisterProblem(String methodName, String packageName, int numberOfInvocations) {
+    private void verifyRegisterProblem(String methodName, String clientPackageName, int numberOfInvocations, String reactivePackageName) {
 
         // Arrange
         PsiReferenceExpression referenceExpression = mock(PsiReferenceExpression.class);
-        PsiExpression expression = mock(PsiExpression.class);
-        PsiType type = mock(PsiType.class);
-        PsiClass containingClass = mock(PsiClass.class);
-        PsiTreeUtil mockTreeUtil = mock(PsiTreeUtil.class);
+        PsiMethodCallExpression expression = mock(PsiMethodCallExpression.class);
+        PsiClassType type = mock(PsiClassType.class);
+        PsiClass qualifierReturnTypeClass = mock(PsiClass.class);
+
+        PsiReferenceExpression clientReferenceExpression = mock(PsiReferenceExpression.class);
+        PsiReferenceExpression clientQualifierExpression = mock(PsiReferenceExpression.class);
+        PsiClassType clientType = mock(PsiClassType.class);
+        PsiClass clientReturnTypeClass = mock(PsiClass.class);
 
+        // visitMethodCallExpression method
         when(mockElement.getMethodExpression()).thenReturn(referenceExpression);
         when(referenceExpression.getReferenceName()).thenReturn(methodName);
 
+        // checkIfAsyncContext method
         when(referenceExpression.getQualifierExpression()).thenReturn(expression);
         when(expression.getType()).thenReturn(type);
-        when(type.getCanonicalText()).thenReturn("reactor.core.publisher.Flux");
+        when(type.resolve()).thenReturn(qualifierReturnTypeClass);
 
-        when(mockTreeUtil.getParentOfType(mockElement, PsiClass.class)).thenReturn(containingClass);
-        when(containingClass.getQualifiedName()).thenReturn(packageName);
+        // isReactiveType method
+        when(qualifierReturnTypeClass.getQualifiedName()).thenReturn(reactivePackageName);
+
+        // isAzureAsyncClient method
+        when(expression.getMethodExpression()).thenReturn(clientReferenceExpression);
+        when(clientReferenceExpression.getQualifierExpression()).thenReturn(clientQualifierExpression);
+        when(clientQualifierExpression.getType()).thenReturn(clientType);
+        when(clientType.resolve()).thenReturn(clientReturnTypeClass);
+        when(clientReturnTypeClass.getQualifiedName()).thenReturn(clientPackageName);
 
         // Act
         mockVisitor.visitMethodCallExpression(mockElement);
@@ -178,4 +212,3 @@ private void verifyRegisterProblem(String methodName, String packageName, int nu
         verify(mockHolder, times(numberOfInvocations)).registerProblem(Mockito.eq(mockElement), Mockito.contains("Use of block methods on asynchronous clients detected. Switch to synchronous APIs instead."));
     }
 }
-

From db499d1b34c66fd30b5a0ee87a4c0d5f710cc216 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 27 Jul 2024 12:52:20 -0700
Subject: [PATCH 131/144] refactor to use mvn central data source

---
 .../sdk/buildtool/GitHubFileFetcher.java      | 159 ++++++++++++++++++
 .../buildtool/UpgradeLibraryVersionCheck.java |  12 +-
 2 files changed, 168 insertions(+), 3 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
index 8cb5e8a7e00..2d3b3d02d71 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
@@ -3,12 +3,20 @@
 import com.azure.json.JsonProviders;
 import com.azure.json.JsonReader;
 import com.azure.json.JsonToken;
+import org.w3c.dom.Document;
+import org.w3c.dom.NodeList;
+import org.xml.sax.SAXException;
 
+import javax.xml.parsers.DocumentBuilder;
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
+import java.net.MalformedURLException;
+import java.net.ProtocolException;
 import java.net.URL;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -26,6 +34,157 @@ class GitHubFileFetcher {
 
     private static final Logger LOGGER = Logger.getLogger(GitHubFileFetcher.class.getName());
 
+    /**
+     * The parsePomFile method fetches the pom.xml file from the URL and parses it to get the dependencies.
+     * This method is used to fetch the pom.xml file from the URL and parse it to get the dependencies.
+     * It is used by the UpgradeLibraryVersionCheck inspection.
+     *
+     * @param pomUrl The URL of the pom.xml file to fetch
+     * @return A map of the dependencies in the pom.xml file
+     * @throws IOException                  If an error occurs while reading the file
+     * @throws ParserConfigurationException If an error occurs while configuring the parser
+     * @throws SAXException                 If an error occurs while parsing the file
+     */
+    static Map<String, String> parsePomFile(String pomUrl) {
+
+        // Fetch the pom.xml file from the URL and parse it to get the dependencies
+        Document pomDoc = fetchXmlDocument(pomUrl);
+
+        // Get the list of dependencies from the pom.xml file
+        NodeList dependencies = pomDoc.getElementsByTagName("dependency");
+
+        // Parse the dependencies and get the groupId, artifactId, and version
+        Map<String, String> artifactVersionMap = new HashMap<>();
+
+        for (int i = 0; i < dependencies.getLength(); i++) {
+            NodeList dependency = dependencies.item(i).getChildNodes();
+            String groupId = null;
+            String artifactId = null;
+            String version = null;
+
+            for (int j = 0; j < dependency.getLength(); j++) {
+                if (dependency.item(j).getNodeName().equals("groupId")) {
+                    groupId = dependency.item(j).getTextContent();
+                } else if (dependency.item(j).getNodeName().equals("artifactId")) {
+                    artifactId = dependency.item(j).getTextContent();
+                } else if (dependency.item(j).getNodeName().equals("version")) {
+                    version = dependency.item(j).getTextContent();
+                }
+            }
+
+            if (groupId != null && artifactId != null && version != null) {
+
+                // if we have version: 4.1.9 get 4.1
+                String minorVersion = version.substring(0, version.lastIndexOf("."));
+
+                // Add the groupId and artifactId to the map with the minor version as the value
+                artifactVersionMap.put((groupId + ":" + artifactId), minorVersion);
+            }
+        }
+
+        return artifactVersionMap;
+    }
+
+    /**
+     * The getLatestVersion method fetches the latest Azure Client release versions from Maven Central.
+     * This method is used to fetch the latest version of the library from the metadata file hosted on Maven Central.
+     * It is used by the UpgradeLibraryVersionCheck inspection.
+     *
+     * @param metadataUrl The URL of the metadata file to fetch
+     * @return The latest version of the library
+     * @throws IOException                  If an error occurs while reading the file
+     * @throws ParserConfigurationException If an error occurs while configuring the parser
+     * @throws SAXException                 If an error occurs while parsing the file
+     */
+    static String getLatestVersion(String metadataUrl) {
+
+        // Fetch the metadata file from the URL and parse it
+        Document metadataDoc = fetchXmlDocument(metadataUrl);
+
+        // Get the list of versions from the metadata file
+        NodeList versions = metadataDoc.getElementsByTagName("version");
+
+        // Return the latest version from the list of versions
+        return versions.item(versions.getLength() - 1).getTextContent();
+    }
+
+    /**
+     * The fetchXmlDocument method fetches an XML document from a URL and parses it.
+     * This method is used to fetch the pom.xml file from the URL and parse it to get the dependencies.
+     * It is used by the UpgradeLibraryVersionCheck inspection.
+     *
+     * @param urlString The URL of the XML document to fetch
+     * @return The parsed XML document
+     * @throws IOException                  If an error occurs while reading the document
+     * @throws ParserConfigurationException If an error occurs while configuring the parser
+     * @throws SAXException                 If an error occurs while parsing the document
+     */
+    private static Document fetchXmlDocument(String urlString) {
+
+        // Open connection to the URL and get the input stream
+        HttpURLConnection conn = null;
+        InputStream inputStream = null;
+
+        try {
+            URL url = null;
+            try {
+                url = new URL(urlString);
+            } catch (MalformedURLException e) {
+                throw new RuntimeException(e);
+            }
+
+            // Open connection to the URL
+            try {
+                conn = (HttpURLConnection) url.openConnection();
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+            try {
+                conn.setRequestMethod("GET");
+            } catch (ProtocolException e) {
+                throw new RuntimeException(e);
+            }
+
+            // Get the input stream from the connection
+            try {
+                inputStream = conn.getInputStream();
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+
+            // Create a document builder to parse the XML document
+            DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+
+            // Parse the document from the connection input stream
+            DocumentBuilder builder = null;
+            try {
+                builder = factory.newDocumentBuilder();
+            } catch (ParserConfigurationException e) {
+                throw new RuntimeException(e);
+            }
+
+            try {
+                return builder.parse(inputStream);
+            } catch (SAXException e) {
+                throw new RuntimeException(e);
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+        } finally {
+            if (inputStream != null) {
+                try {
+                    inputStream.close();
+                } catch (IOException e) {
+                    throw new RuntimeException(e);
+                }
+            }
+            if (conn != null) {
+                conn.disconnect();
+            }
+        }
+    }
+
+
     /**
      * The fetchTxtFileFromGitHub method fetches a .txt file from GitHub and parses it to get the recommended version for each library.
      * This method is used to fetch the recommended version for the libraries in the pom.xml file. It is used by the UpgradeLibraryVersionCheck inspection.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
index 89154d9555a..dade13ded3f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
@@ -145,9 +145,15 @@ private static Map<String, String> getLibraryRecommendedVersionMap() throws IOEx
                 synchronized (IncompatibleDependencyCheck.IncompatibleDependencyVisitor.class) {
                     fileContent = LIBRARY_RECOMMENDED_VERSION_MAP_REF == null ? null : LIBRARY_RECOMMENDED_VERSION_MAP_REF.get();
                     if (fileContent == null) {
-                        String fileUrl = "https://raw.githubusercontent.com/Azure/azure-sdk-for-java/main/eng/versioning/version_client.txt";
-                        fileContent = GitHubFileFetcher.fetchTxtFileFromGitHub(fileUrl);
-                        LIBRARY_RECOMMENDED_VERSION_MAP_REF = new WeakReference<>(fileContent);
+
+                        String metadataUrl = "https://repo1.maven.org/maven2/com/azure/azure-sdk-bom/maven-metadata.xml";
+                        String latestVersion = GitHubFileFetcher.getLatestVersion(metadataUrl);
+
+                        if (latestVersion != null) {
+                            String pomUrl = String.format("https://repo1.maven.org/maven2/com/azure/azure-sdk-bom/%s/azure-sdk-bom-%s.pom", latestVersion, latestVersion);
+                            fileContent = GitHubFileFetcher.parsePomFile(pomUrl);
+                            LIBRARY_RECOMMENDED_VERSION_MAP_REF = new WeakReference<>(fileContent);
+                        }
                     }
                 }
             }

From 1bc9d324a77018bafdda981371ad2660984a8289 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 27 Jul 2024 14:32:36 -0700
Subject: [PATCH 132/144] update to abstract class

---
 .../sdk/buildtool/AbstractLibraryVersionCheck.java  | 10 ----------
 .../sdk/buildtool/IncompatibleDependencyCheck.java  |  8 ++++----
 .../sdk/buildtool/UpgradeLibraryVersionCheck.java   | 13 +++++++------
 .../buildtool/AbstractLibraryVersionCheckTest.java  |  4 ++--
 4 files changed, 13 insertions(+), 22 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
index da3426ae493..122a985a49f 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheck.java
@@ -5,7 +5,6 @@
 import com.intellij.lang.StdLanguages;
 import com.intellij.psi.FileViewProvider;
 import com.intellij.psi.PsiElement;
-import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.xml.XmlFile;
 import com.intellij.psi.xml.XmlTag;
 import org.jetbrains.idea.maven.project.MavenProjectsManager;
@@ -21,15 +20,6 @@
  */
 public abstract class AbstractLibraryVersionCheck extends LocalInspectionTool {
 
-    /**
-     * Creates the specific visitor for the inspection for subclasses to implement.
-     *
-     * @param holder     The holder for the problems found
-     * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
-     * @return The specific visitor for the inspection
-     */
-    protected abstract PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly);
-
     /**
      * Method to check the pom.xml file for the libraries and their versions.
      *
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
index aa9d61b1e7a..1bf814a707c 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
@@ -32,9 +32,10 @@ public class IncompatibleDependencyCheck extends AbstractLibraryVersionCheck {
      * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
      * @return The visitor for the inspection
      */
+    @NotNull
     @Override
-    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
-        return new IncompatibleDependencyVisitor(holder, isOnTheFly);
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new IncompatibleDependencyVisitor(holder);
     }
 
     /**
@@ -100,9 +101,8 @@ class IncompatibleDependencyVisitor extends PsiElementVisitor {
          * Constructs a new instance of the IncompatibleDependencyVisitor.
          *
          * @param holder     The holder for the problems found
-         * @param isOnTheFly boolean to check if the inspection is on the fly
          */
-        IncompatibleDependencyVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        IncompatibleDependencyVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
index dade13ded3f..dd52c5764a0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
@@ -20,15 +20,17 @@
 public class UpgradeLibraryVersionCheck extends AbstractLibraryVersionCheck {
 
     /**
-     * Abstract method to build the specific visitor for the inspection.
+     * Build the specific visitor for the inspection.
      *
      * @param holder     The holder for the problems found
      * @param isOnTheFly boolean to check if the inspection is on the fly - not used in this implementation but is part of the method signature
      * @return The visitor for the inspection
      */
+
+    @NotNull
     @Override
-    protected PsiElementVisitor createVisitor(ProblemsHolder holder, boolean isOnTheFly) {
-        return new UpgradeLibraryVersionVisitor(holder, isOnTheFly);
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
+        return new UpgradeLibraryVersionVisitor(holder);
     }
 
     /**
@@ -79,10 +81,9 @@ class UpgradeLibraryVersionVisitor extends PsiElementVisitor {
         /**
          * Constructs a new instance of the visitor.
          *
-         * @param holder     The holder for the problems found
-         * @param isOnTheFly boolean to check if the inspection is on the fly
+         * @param holder The holder for the problems found
          */
-        UpgradeLibraryVersionVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        UpgradeLibraryVersionVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
index 95ef6d8c1af..d9110fa1842 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/AbstractLibraryVersionCheckTest.java
@@ -54,10 +54,10 @@ public void setup() {
         IncompatibleDependencyCheck.encounteredVersionGroups = new HashSet<>(Arrays.asList("jackson_2.10", "gson_2.10"));
 
         UpgradeLibraryVersionCheck mockCheck = new UpgradeLibraryVersionCheck();
-        mockUpgradeLibraryVersionVisitor = mockCheck.new UpgradeLibraryVersionVisitor(mockHolder, true);
+        mockUpgradeLibraryVersionVisitor = mockCheck.new UpgradeLibraryVersionVisitor(mockHolder);
 
         IncompatibleDependencyCheck mockIncompatibleDependencyCheck = new IncompatibleDependencyCheck();
-        mockIncompatibleDependencyVisitor = mockIncompatibleDependencyCheck.new IncompatibleDependencyVisitor(mockHolder, true);
+        mockIncompatibleDependencyVisitor = mockIncompatibleDependencyCheck.new IncompatibleDependencyVisitor(mockHolder);
     }
 
     /**

From bfe58c3d090310fe6bc5da344bb87d31cfb6e5ee Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 27 Jul 2024 17:01:09 -0700
Subject: [PATCH 133/144] integrate caching

---
 ...java => DependencyVersionFileFetcher.java} | 183 ++++++------------
 .../DependencyVersionsDataCache.java          | 127 ++++++++++++
 .../IncompatibleDependencyCheck.java          |  12 +-
 .../azure/sdk/buildtool/RuleConfigLoader.java |   9 +-
 .../buildtool/UpgradeLibraryVersionCheck.java |  11 +-
 .../main/resources/META-INF/ruleConfigs.json  |   2 +
 6 files changed, 198 insertions(+), 146 deletions(-)
 rename PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/{GitHubFileFetcher.java => DependencyVersionFileFetcher.java} (60%)
 create mode 100644 PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionFileFetcher.java
similarity index 60%
rename from PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
rename to PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionFileFetcher.java
index 2d3b3d02d71..2edf90eb641 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/GitHubFileFetcher.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionFileFetcher.java
@@ -10,10 +10,8 @@
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
-import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStream;
-import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
 import java.net.ProtocolException;
@@ -23,16 +21,21 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
- * Class to fetch files from GitHub.
- * The class fetches .txt and .json files from GitHub and parses them to get the data.
+ * Class to fetch files from their corresponding data sources
+ * The class fetches these sources and parses them to get the data.
  * The data is used to check the version of the libraries in the pom.xml file against the recommended version.
  */
-class GitHubFileFetcher {
+class DependencyVersionFileFetcher {
 
-    private static final Logger LOGGER = Logger.getLogger(GitHubFileFetcher.class.getName());
+    private static final Logger LOGGER = Logger.getLogger(DependencyVersionFileFetcher.class.getName());
+
+    private static final DependencyVersionsDataCache<Map<String, String>> pomCache = new DependencyVersionsDataCache<>("pomCache.ser");
+    private static final DependencyVersionsDataCache<String> versionCache = new DependencyVersionsDataCache<>("versionCache.ser");
+    private static final DependencyVersionsDataCache<Map<String, Set<String>>> incompatibleVersionsCache = new DependencyVersionsDataCache<>("incompatibleVersionsCache.ser");
 
     /**
      * The parsePomFile method fetches the pom.xml file from the URL and parses it to get the dependencies.
@@ -41,12 +44,14 @@ class GitHubFileFetcher {
      *
      * @param pomUrl The URL of the pom.xml file to fetch
      * @return A map of the dependencies in the pom.xml file
-     * @throws IOException                  If an error occurs while reading the file
-     * @throws ParserConfigurationException If an error occurs while configuring the parser
-     * @throws SAXException                 If an error occurs while parsing the file
      */
     static Map<String, String> parsePomFile(String pomUrl) {
 
+        // Check the cache first
+        Map<String, String> artifactVersionMap = pomCache.get(pomUrl);
+        if (artifactVersionMap != null) {
+            return artifactVersionMap;
+        }
         // Fetch the pom.xml file from the URL and parse it to get the dependencies
         Document pomDoc = fetchXmlDocument(pomUrl);
 
@@ -54,7 +59,7 @@ static Map<String, String> parsePomFile(String pomUrl) {
         NodeList dependencies = pomDoc.getElementsByTagName("dependency");
 
         // Parse the dependencies and get the groupId, artifactId, and version
-        Map<String, String> artifactVersionMap = new HashMap<>();
+        artifactVersionMap = new HashMap<>();
 
         for (int i = 0; i < dependencies.getLength(); i++) {
             NodeList dependency = dependencies.item(i).getChildNodes();
@@ -82,6 +87,8 @@ static Map<String, String> parsePomFile(String pomUrl) {
             }
         }
 
+        // Update the cache
+        pomCache.put(pomUrl, artifactVersionMap);
         return artifactVersionMap;
     }
 
@@ -92,20 +99,25 @@ static Map<String, String> parsePomFile(String pomUrl) {
      *
      * @param metadataUrl The URL of the metadata file to fetch
      * @return The latest version of the library
-     * @throws IOException                  If an error occurs while reading the file
-     * @throws ParserConfigurationException If an error occurs while configuring the parser
-     * @throws SAXException                 If an error occurs while parsing the file
      */
     static String getLatestVersion(String metadataUrl) {
 
+        // Check the cache first
+        String cachedVersion = versionCache.get(metadataUrl);
+        if (cachedVersion != null) {
+            return cachedVersion;
+        }
         // Fetch the metadata file from the URL and parse it
         Document metadataDoc = fetchXmlDocument(metadataUrl);
 
         // Get the list of versions from the metadata file
         NodeList versions = metadataDoc.getElementsByTagName("version");
 
-        // Return the latest version from the list of versions
-        return versions.item(versions.getLength() - 1).getTextContent();
+        String latestVersion = versions.item(versions.getLength() - 1).getTextContent();
+
+        // Update the cache
+        versionCache.put(metadataUrl, latestVersion);
+        return latestVersion;
     }
 
     /**
@@ -115,9 +127,6 @@ static String getLatestVersion(String metadataUrl) {
      *
      * @param urlString The URL of the XML document to fetch
      * @return The parsed XML document
-     * @throws IOException                  If an error occurs while reading the document
-     * @throws ParserConfigurationException If an error occurs while configuring the parser
-     * @throws SAXException                 If an error occurs while parsing the document
      */
     private static Document fetchXmlDocument(String urlString) {
 
@@ -126,56 +135,36 @@ private static Document fetchXmlDocument(String urlString) {
         InputStream inputStream = null;
 
         try {
-            URL url = null;
-            try {
-                url = new URL(urlString);
-            } catch (MalformedURLException e) {
-                throw new RuntimeException(e);
-            }
-
-            // Open connection to the URL
-            try {
-                conn = (HttpURLConnection) url.openConnection();
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            }
-            try {
-                conn.setRequestMethod("GET");
-            } catch (ProtocolException e) {
-                throw new RuntimeException(e);
-            }
-
-            // Get the input stream from the connection
-            try {
-                inputStream = conn.getInputStream();
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            }
+            URL url = new URL(urlString);
+            conn = (HttpURLConnection) url.openConnection();
+            conn.setRequestMethod("GET");
+            inputStream = conn.getInputStream();
 
             // Create a document builder to parse the XML document
             DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
 
             // Parse the document from the connection input stream
-            DocumentBuilder builder = null;
-            try {
-                builder = factory.newDocumentBuilder();
-            } catch (ParserConfigurationException e) {
-                throw new RuntimeException(e);
-            }
-
-            try {
-                return builder.parse(inputStream);
-            } catch (SAXException e) {
-                throw new RuntimeException(e);
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            }
+            DocumentBuilder builder = factory.newDocumentBuilder();
+            return builder.parse(inputStream);
+
+        } catch (MalformedURLException e) {
+            LOGGER.log(Level.SEVERE, "Invalid URL: " + urlString, e);
+            throw new RuntimeException(e);
+        } catch (ProtocolException e) {
+            LOGGER.log(Level.SEVERE, "Protocol error while fetching URL: " + urlString, e);
+            throw new RuntimeException(e);
+        } catch (IOException e) {
+            LOGGER.log(Level.SEVERE, "I/O error while fetching URL: " + urlString, e);
+            throw new RuntimeException(e);
+        } catch (ParserConfigurationException | SAXException e) {
+            LOGGER.log(Level.SEVERE, "Error parsing XML from URL: " + urlString, e);
+            throw new RuntimeException(e);
         } finally {
             if (inputStream != null) {
                 try {
                     inputStream.close();
                 } catch (IOException e) {
-                    throw new RuntimeException(e);
+                    LOGGER.log(Level.SEVERE, "Failed to close input stream", e);
                 }
             }
             if (conn != null) {
@@ -184,75 +173,6 @@ private static Document fetchXmlDocument(String urlString) {
         }
     }
 
-
-    /**
-     * The fetchTxtFileFromGitHub method fetches a .txt file from GitHub and parses it to get the recommended version for each library.
-     * This method is used to fetch the recommended version for the libraries in the pom.xml file. It is used by the UpgradeLibraryVersionCheck inspection.
-     *
-     * @param fileUrl The URL of the .txt file to fetch
-     * @return A map of the recommended version for each library
-     * @throws IOException If an error occurs while reading the file
-     */
-    static Map<String, String> fetchTxtFileFromGitHub(String fileUrl) throws IOException {
-        StringBuilder content = new StringBuilder();
-
-        URL url = new URL(fileUrl);
-
-        HttpURLConnection connection = (HttpURLConnection) url.openConnection();
-        connection.setRequestMethod("GET");
-
-        // Read the file from the URL
-        try (BufferedReader in = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {
-            String inputLine;
-            while ((inputLine = in.readLine()) != null) {
-                if (inputLine.startsWith("#")) {
-                    continue; // Ignore comment lines
-                }
-                content.append(inputLine).append("\n");
-            }
-        } catch (IOException e) {
-            LOGGER.severe("Error reading file from GitHub: " + e);
-        } catch (SecurityException e) {
-            LOGGER.severe("Security exception accessing URL: " + e);
-        } catch (IllegalArgumentException e) {
-            LOGGER.severe("Illegal argument: " + e);
-        } catch (IllegalStateException e) {
-            LOGGER.severe("Illegal state: " + e);
-        } catch (Exception e) {
-            LOGGER.severe("Unexpected error: " + e);
-        } finally {
-            connection.disconnect();
-        }
-        return parseTxtFile(content.toString());
-    }
-
-    /**
-     * The parseTxtFile method parses the content of the .txt file to get the recommended version for each library.
-     * The content of the file is in the format "artifactId: minor version".
-     * The method returns a map where the key is the artifactId and the value is the recommended version.
-     *
-     * @param content The content of the .txt file
-     * @return A map of the recommended version for each library
-     */
-    private static Map<String, String> parseTxtFile(String content) {
-
-        Map<String, String> fileContent = new ConcurrentHashMap<>();
-
-        if (content != null) {
-            String[] lines = content.toString().split("\n");
-
-            for (String line : lines) {
-                String[] parts = line.split(";");
-                if (parts.length > 1) {
-                    String artifactId = parts[0];
-                    String[] versionParts = parts[1].split("\\.");
-                    fileContent.put(artifactId, versionParts[0] + "." + versionParts[1]); // key is artifactId, value is recommended version
-                }
-            }
-        }
-        return fileContent;
-    }
-
     /**
      * The loadJsonDataFromUrl method fetches a .json file from GitHub and parses it to get the data.
      * This method is used to fetch the data for the libraries in the pom.xml file. It is used by the IncompatibleDependencyCheck inspection.
@@ -262,6 +182,11 @@ private static Map<String, String> parseTxtFile(String content) {
      */
     static Map<String, Set<String>> loadJsonDataFromUrl(String jsonUrl) {
 
+        Map<String, Set<String>> jsonData = incompatibleVersionsCache.get(jsonUrl);
+
+        if (jsonData != null) {
+            return jsonData;
+        }
         HttpURLConnection connection;
         try {
             URL url = new URL(jsonUrl);
@@ -269,7 +194,9 @@ static Map<String, Set<String>> loadJsonDataFromUrl(String jsonUrl) {
             connection.setRequestMethod("GET");
 
             try (InputStream inputStream = connection.getInputStream(); JsonReader jsonReader = JsonProviders.createReader(inputStream)) {
-                return parseJson(jsonReader);
+                jsonData = parseJson(jsonReader);
+                incompatibleVersionsCache.put(jsonUrl, jsonData);
+                return jsonData;
             }
         } catch (IOException e) {
             LOGGER.severe("Error reading file from GitHub: " + e);
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java
new file mode 100644
index 00000000000..1598e1842c2
--- /dev/null
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java
@@ -0,0 +1,127 @@
+package com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.io.Serial;
+import java.io.Serializable;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.logging.Logger;
+
+/**
+ * A cache to store the dependency versions data for a certain period of time.
+ * The cache is stored in memory and also saved to a file to persist the data across IDE restarts.
+ * The cache is cleared at regular intervals to prevent it from growing indefinitely.
+ *
+ * @param <T> The type of the data to be stored in the cache.
+ */
+class DependencyVersionsDataCache<T> implements Serializable {
+    private static final Logger LOGGER = Logger.getLogger(DependencyVersionsDataCache.class.getName());
+
+    // The serial version UID is used to verify that the class is compatible with the serialized object.
+    @Serial
+    private static final long serialVersionUID = 1L;
+
+    // The cache is stored in a ConcurrentHashMap to ensure thread safety.
+    private final ConcurrentHashMap<String, T> cache = new ConcurrentHashMap<>();
+
+    // The interval at which the cache is cleared. The cache is cleared every 30 days.
+    private static final long CLEANUP_INTERVAL = TimeUnit.DAYS.toMillis(30); // 1 day
+
+    // The file where the cache is saved.
+    private final File cacheFile;
+
+    /**
+     * Creates a new instance of the DependencyVersionsDataCache class.
+     *
+     * @param cacheFileName The name of the file where the cache is saved.
+     */
+    DependencyVersionsDataCache(String cacheFileName) {
+        this.cacheFile = new File(cacheFileName);
+        loadCacheFromFile();
+
+        // Schedule the cache cleanup task to run at regular intervals
+        ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1);
+        scheduler.scheduleAtFixedRate(this::clear, CLEANUP_INTERVAL, CLEANUP_INTERVAL, TimeUnit.MILLISECONDS);
+    }
+
+    /**
+     * Puts a value into the cache.
+     *
+     * @param key   The key to associate with the value.
+     * @param value The value to store in the cache.
+     */
+    void put(String key, T value) {
+        cache.put(key, value);
+        saveCacheToFile();
+    }
+
+    /**
+     * Gets a value from the cache.
+     *
+     * @param key The key to retrieve the value for.
+     * @return The value associated with the key, or null if the key is not found.
+     */
+    T get(String key) {
+        return cache.get(key);
+    }
+
+    /**
+     * Clears the cache.
+     * This method is called at regular intervals to prevent the cache from growing indefinitely.
+     */
+    void clear() {
+        cache.clear();
+        saveCacheToFile();
+    }
+
+    /**
+     * Loads the cache from the file.
+     * If the file exists, the cache is loaded from the file.
+     * If the file does not exist, the cache is left empty.
+     */
+    private void loadCacheFromFile() {
+        if (cacheFile.exists()) {
+            // Load the cache from the file
+            try (ObjectInputStream ois = new ObjectInputStream(new FileInputStream(cacheFile))) {
+
+                // Use a temporary variable to hold the deserialized object
+                Object loadedObject = ois.readObject();
+
+                // Check if the deserialized object is an instance of ConcurrentHashMap
+                if (loadedObject instanceof ConcurrentHashMap) {
+
+                    // Cast the object to ConcurrentHashMap<String, T>
+                    ConcurrentHashMap<String, T> loadedCache = (ConcurrentHashMap<String, T>) loadedObject;
+
+                    // Put all the entries from the loaded cache into the current cache
+                    cache.putAll(loadedCache);
+                } else {
+                    LOGGER.severe("Failed to load cache from file: Invalid cache format");
+                }
+            } catch (IOException | ClassNotFoundException e) {
+                LOGGER.severe("Failed to load cache from file: " + e);
+            }
+        }
+    }
+
+    /**
+     * Saves the cache to the file.
+     * The cache is saved to the file to persist the data across IDE restarts.
+     */
+    private void saveCacheToFile() {
+
+        // Save the cache to the file using the ObjectOutputStream class.
+        try (ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream(cacheFile))) {
+            oos.writeObject(cache);
+        } catch (IOException e) {
+            LOGGER.severe("Failed to save cache to file: " + e.getMessage());
+        }
+    }
+}
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
index 1bf814a707c..0d0ebeef7a2 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
@@ -100,7 +100,7 @@ class IncompatibleDependencyVisitor extends PsiElementVisitor {
         /**
          * Constructs a new instance of the IncompatibleDependencyVisitor.
          *
-         * @param holder     The holder for the problems found
+         * @param holder The holder for the problems found
          */
         IncompatibleDependencyVisitor(ProblemsHolder holder) {
             this.holder = holder;
@@ -175,11 +175,7 @@ private static String getGroupVersion(String fullName, String currentVersion) {
                     break;
                 }
             }
-            if (versionGroup != null) {
-                return versionGroup;
-            } else {
-                return null;
-            }
+            return versionGroup;
         }
 
         /**
@@ -199,8 +195,8 @@ private static Map<String, Set<String>> getFileContent() {
                 synchronized (IncompatibleDependencyVisitor.class) {
                     fileContent = FILE_CONTENT_REF == null ? null : FILE_CONTENT_REF.get();
                     if (fileContent == null) {
-                        String fileUrl = "https://raw.githubusercontent.com/Azure/azure-sdk-for-java/main/eng/versioning/supported_external_dependency_versions.json";
-                        fileContent = GitHubFileFetcher.loadJsonDataFromUrl(fileUrl);
+                        String fileUrl = RULE_CONFIG.getListedItemsToCheck().get(0);
+                        fileContent = DependencyVersionFileFetcher.loadJsonDataFromUrl(fileUrl);
                         FILE_CONTENT_REF = new WeakReference<>(fileContent);
                     }
                 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index 5d7604f5f65..1f16755eca6 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -157,11 +157,12 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                 case "servicesToCheck":
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
-                case "regexPatterns":
-                    listedItemsToCheck = getValuesFromJsonReader(reader);
-                    break;
                 default:
-                    if (fieldName.endsWith("Check")) {
+                    if (fieldName == "url") {
+                        listedItemsToCheck = getListFromJsonArray(reader);
+                    } else if (fieldName == "regexPatterns") {
+                        listedItemsToCheck = getValuesFromJsonReader(reader);
+                    } else if (fieldName.endsWith("Check")) {
                         // Move to the next token to process the nested object
                         reader.nextToken();
                         antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
index dd52c5764a0..025e374b8b0 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UpgradeLibraryVersionCheck.java
@@ -42,7 +42,7 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean is
      * @param versionTag     The version tag in the pom.xml file for the library version
      */
     @Override
-    protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionTag) throws IOException {
+    protected void checkAndFlagVersion(String fullName, String currentVersion, ProblemsHolder holder, PsiElement versionTag) {
 
         // Check if the recommended version is available for the library
         if (!(UpgradeLibraryVersionVisitor.getLibraryRecommendedVersionMap().containsKey(fullName))) {
@@ -135,9 +135,8 @@ public void visitFile(@NotNull PsiFile file) {
          * If the content is not available in the WeakReference, the file is fetched again.
          *
          * @return The map of the recommended version for each library
-         * @throws IOException If there is an error in fetching the file from the URL
          */
-        private static Map<String, String> getLibraryRecommendedVersionMap() throws IOException {
+        private static Map<String, String> getLibraryRecommendedVersionMap() {
 
             // Load the file content from the URL if it is not already loaded
             Map<String, String> fileContent = LIBRARY_RECOMMENDED_VERSION_MAP_REF == null ? null : LIBRARY_RECOMMENDED_VERSION_MAP_REF.get();
@@ -147,12 +146,12 @@ private static Map<String, String> getLibraryRecommendedVersionMap() throws IOEx
                     fileContent = LIBRARY_RECOMMENDED_VERSION_MAP_REF == null ? null : LIBRARY_RECOMMENDED_VERSION_MAP_REF.get();
                     if (fileContent == null) {
 
-                        String metadataUrl = "https://repo1.maven.org/maven2/com/azure/azure-sdk-bom/maven-metadata.xml";
-                        String latestVersion = GitHubFileFetcher.getLatestVersion(metadataUrl);
+                        String metadataUrl = RULE_CONFIG.getListedItemsToCheck().get(0);
+                        String latestVersion = DependencyVersionFileFetcher.getLatestVersion(metadataUrl);
 
                         if (latestVersion != null) {
                             String pomUrl = String.format("https://repo1.maven.org/maven2/com/azure/azure-sdk-bom/%s/azure-sdk-bom-%s.pom", latestVersion, latestVersion);
-                            fileContent = GitHubFileFetcher.parsePomFile(pomUrl);
+                            fileContent = DependencyVersionFileFetcher.parsePomFile(pomUrl);
                             LIBRARY_RECOMMENDED_VERSION_MAP_REF = new WeakReference<>(fileContent);
                         }
                     }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index 57e26f9c1b5..54fc6912bdb 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -119,9 +119,11 @@
     "antiPatternMessage": "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients"
   },
   "UpgradeLibraryVersionCheck": {
+    "url": "https://repo1.maven.org/maven2/com/azure/azure-sdk-bom/maven-metadata.xml",
     "antiPatternMessage": "A newer stable minor version of {{fullName}} is available. We recommend you update to version {{recommendedVersion}}.x"
   },
   "IncompatibleDependencyCheck": {
+    "url": "https://raw.githubusercontent.com/Azure/azure-sdk-for-java/main/eng/versioning/supported_external_dependency_versions.json",
     "antiPatternMessage": "The version of {{fullName}} is not compatible with other dependencies of the same library defined in the pom.xml. Please use versions of the same library release group {{recommendedVersion}}.x to ensure proper functionality."
   }
 }

From f19f1a437ce81071879aee2e4d070fdaeaf307bd Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 29 Jul 2024 12:43:14 -0700
Subject: [PATCH 134/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md | 10 +++---
 .../UseOfBlockOnAsyncClientsCheck.java        | 33 +++++++++++--------
 .../main/resources/META-INF/ruleConfigs.json  | 12 ++++++-
 3 files changed, 35 insertions(+), 20 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index a7f0ff2a231..bb3f7913352 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -261,15 +261,15 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   the [KeyCredential Class documentation](https://learn.microsoft.com/java/api/com.azure.core.credential.keycredential?view=azure-java-stable)
   for more information.
 
-14. #### Use sync client operation if calling block methods on an async client.
+14. #### Use sync client operation if calling blocking calls on an async client.
 
-- **Anti-Pattern**: Using `block()` on an async client. This practice turns an asynchronous operation into a synchronous
+- **Anti-Pattern**: Calling blocking calls on an async client. This practice turns an asynchronous operation into a synchronous
   one.
-- **Issue**: The use of `block()` goes against the non-blocking nature of reactive streams.
+- **Issue**: Blocking calls go against the non-blocking nature of reactive streams.
   It can lead to performance issues because it blocks one of the few available threads.
   In reactive applications, avoiding blocking operations is crucial for scalability and responsiveness.
 - **Severity Level: WARNING**
-- **Recommendation**: If you find yourself frequently using `block()` in your code, consider switching to the sync
+- **Recommendation**: If you find yourself frequently using blocking calls in your code, consider switching to the sync
   client.
-  The sync client performs operations synchronously without requiring `block()`.
+  The sync client performs operations synchronously without requiring locking calls.
   Using the sync client can make your code more straightforward and easier to understand.
\ No newline at end of file
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
index 0b1b0cca699..013e1ffc27e 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -19,10 +19,13 @@ public class UseOfBlockOnAsyncClientsCheck extends LocalInspectionTool {
 
     /**
      * This method is used to get the visitor for the inspection tool.
-     * The visitor is used to check for the use of block() method on async clients in Azure SDK.
-     * The visitor checks if the method call is a block() method call on a reactive type
+     * The visitor is used to check for the use of blocking calls on async clients in Azure SDK.
+     * The visitor checks if the method call is a blocking method call on a reactive type
      * and if the reactive type is an async client in Azure SDK.
-     * If the method call is a block() method call on an async client, it reports a problem.
+     * If the method call is a blocking call on an async Azure client, it reports a problem.
+     *
+     * @param holder ProblemsHolder - the holder to report the problems
+     *               isOnTheFly boolean - whether the inspection is on the fly - not used in this implementation but required by the interface
      */
     @NotNull
     @Override
@@ -31,25 +34,25 @@ public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean i
     }
 
     /**
-     * Visitor to check for the use of block() method on async clients in Azure SDK.
-     * The visitor checks if the method call is a block() method call on a reactive type
+     * Visitor to check for the use of blocking methods on async clients in Azure SDK.
+     * The visitor checks if the method call is a blocking method call on a reactive type
      * and if the reactive type is an async client in Azure SDK.
-     * If the method call is a block() method call on an async client, it reports a problem.
+     * If the method call is a blocking method call on an async client, it reports a problem.
      */
     static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
 
         private final ProblemsHolder holder;
 
         // Define constants for string literals
+        private static final String RULE_NAME = "UseOfBlockOnAsyncClientsCheck";
         private static final RuleConfig RULE_CONFIG;
         private static final boolean SKIP_WHOLE_RULE;
 
         static {
-            final String ruleName = "UseOfBlockOnAsyncClientsCheck";
             RuleConfigLoader centralRuleConfigLoader = RuleConfigLoader.getInstance();
 
             // Get the RuleConfig object for the rule
-            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(ruleName);
+            RULE_CONFIG = centralRuleConfigLoader.getRuleConfig(RULE_NAME);
             SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || RULE_CONFIG.getListedItemsToCheck().isEmpty();
         }
 
@@ -77,14 +80,16 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
                 return;
             }
 
-            // Check if the method call is block() or a variant of block() method
-            if (expression.getMethodExpression().getReferenceName().startsWith(RULE_CONFIG.getMethodsToCheck().get(0))) {
+            // Check if the method call is a blocking method call on a reactive type
+            for (String methodToCheck : RULE_CONFIG.getMethodsToCheck()) {
+                if (expression.getMethodExpression().getReferenceName().equals(methodToCheck)) {
 
-                // Check if the method call is on a reactive type
-                boolean isAsyncContext = checkIfAsyncContext(expression);
+                    // Check if the method call is on a reactive type
+                    boolean isAsyncContext = checkIfAsyncContext(expression);
 
-                if (isAsyncContext) {
-                    holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
+                    if (isAsyncContext) {
+                        holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
+                    }
                 }
             }
         }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index a10ed9e51ce..d22aa161485 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -123,7 +123,17 @@
     "antiPatternMessage": "Endpoint should not be used with KeyCredential for non-Azure OpenAI clients"
   },
   "UseOfBlockOnAsyncClientsCheck": {
-    "methodsToCheck": "block",
+    "methodsToCheck": [
+      "block",
+      "blockOptional",
+      "blockFirst",
+      "blockLast",
+      "toIterable",
+      "toStream",
+      "toFuture",
+      "blockFirstOptional",
+      "blockLastOptional"
+    ],
     "typesToCheck": [
       "reactor.core.publisher.Flux",
       "reactor.core.publisher.Mono"

From 524019f197e226ffb7e37ac76777ab7d77b6a1e9 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 29 Jul 2024 12:48:56 -0700
Subject: [PATCH 135/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk.xml       | 41 ++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
index 7ad428273c6..8a0e43d1ff9 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/azure-intellij-plugin-azure-sdk.xml
@@ -169,6 +169,45 @@
             </class>
         </localInspection>
 
+        <localInspection
+                language="JAVA"
+                shortName="UpdateCheckpointAsyncSubscribeChecker"
+                displayName="Update Checkpoint Async Subscribe Checker"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncSubscribeChecker">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncSubscribeChecker
+            </class>
+        </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="UpdateCheckpointAsyncBlockChecker"
+                displayName="Update Checkpoint Async Block Checker"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncBlockChecker">
+
+            <class>
+                com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.UpdateCheckpointAsyncBlockChecker
+            </class>
+        </localInspection>
+
+        <localInspection
+                language="JAVA"
+                shortName="KustoQueriesWithTimeIntervalInQueryStringCheck"
+                displayName="Kusto Queries With Time Interval In Query String Check"
+                groupName="Azure SDK Rules"
+                enabledByDefault="true"
+                level="WARNING"
+                implementationClass="com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck">
+            <class>com.microsoft.azure.toolkit.intellij.azure.sdk.buildtool.KustoQueriesWithTimeIntervalInQueryStringCheck</class>
+        </localInspection>
+
         <localInspection
                 language="JAVA"
                 shortName="UseOfBlockOnAsyncClientsCheck"
@@ -197,4 +236,4 @@
             </class>
         </localInspection>
     </extensions>
-</idea-plugin>
\ No newline at end of file
+</idea-plugin>

From 2673679e7610318b92f3667d8a1f9535488b43ff Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 29 Jul 2024 13:07:36 -0700
Subject: [PATCH 136/144] address PR comments

---
 .../azure/sdk/buildtool/RuleConfigLoader.java         | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index a8eae759b5d..d309bab1b30 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -157,12 +157,13 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                 case "servicesToCheck":
                     servicesToCheck = getListFromJsonArray(reader);
                     break;
+                case "typesToCheck":
+                    listedItemsToCheck = getListFromJsonArray(reader);
+                    break;
+                case "regexPatterns":
+                    listedItemsToCheck = getValuesFromJsonReader(reader);
                 default:
-                    if (fieldName == "typesToCheck") {
-                        listedItemsToCheck = getListFromJsonArray(reader);
-                    } else if (fieldName == "regexPatterns") {
-                        listedItemsToCheck = getValuesFromJsonReader(reader);
-                    } else if (fieldName.endsWith("Check")) {
+                    if (fieldName.endsWith("Check")) {
                         // Move to the next token to process the nested object
                         reader.nextToken();
                         antiPatternMessageMap = getMapFromJsonObject(reader, antiPatternMessageMap);

From 48813c50663e88fa746337551eb9dc6f81a41e0c Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 29 Jul 2024 13:11:50 -0700
Subject: [PATCH 137/144] address PR comments

---
 .../azure-intellij-plugin-azure-sdk/README.md                | 5 +++--
 .../intellij/azure/sdk/buildtool/RuleConfigLoader.java       | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
index bb3f7913352..5047e7468fc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/README.md
@@ -261,9 +261,10 @@ integration, telemetry connectivity, and Azure Toolkit integration.
   the [KeyCredential Class documentation](https://learn.microsoft.com/java/api/com.azure.core.credential.keycredential?view=azure-java-stable)
   for more information.
 
-14. #### Use sync client operation if calling blocking calls on an async client.
+14. #### Use sync client operation if calling blocking calls on asynchronous operations of an Azure asynchronous client.
 
-- **Anti-Pattern**: Calling blocking calls on an async client. This practice turns an asynchronous operation into a synchronous
+- **Anti-Pattern**: Calling blocking calls on asynchronous operations of an Azure asynchronous client. This practice
+  turns an asynchronous operation into a synchronous
   one.
 - **Issue**: Blocking calls go against the non-blocking nature of reactive streams.
   It can lead to performance issues because it blocks one of the few available threads.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
index d309bab1b30..a6d10ab4b43 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/RuleConfigLoader.java
@@ -162,6 +162,7 @@ private RuleConfig getRuleConfig(JsonReader reader) throws IOException {
                     break;
                 case "regexPatterns":
                     listedItemsToCheck = getValuesFromJsonReader(reader);
+                    break;
                 default:
                     if (fieldName.endsWith("Check")) {
                         // Move to the next token to process the nested object

From cbd4bd3813559898437e101d658107157ad39d66 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Mon, 29 Jul 2024 13:13:54 -0700
Subject: [PATCH 138/144] remove changes from diff

---
 .../src/main/resources/META-INF/ruleConfigs.json              | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
index d22aa161485..d50344031c2 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/resources/META-INF/ruleConfigs.json
@@ -6,10 +6,6 @@
     ],
     "antiPatternMessage": "Azure Storage upload API without length parameter detected. Use upload API with length parameter instead."
   },
-  "ServiceBusReceiverAsyncClientCheck": {
-    "clientsToCheck": "ServiceBusReceiverAsyncClient",
-    "antiPatternMessage": "Use of ServiceBusReceiverAsyncClient detected. Use ServiceBusProcessorClient instead."
-  },
   "DisableAutoCompleteCheck": {
     "methodsToCheck": "disableAutoComplete",
     "clientsToCheck": [

From 6e421e43e4972d77a9170d6f0185d4d34eb0d416 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 30 Jul 2024 11:04:48 -0700
Subject: [PATCH 139/144] address PR comments

---
 .../DependencyVersionsDataCache.java          | 74 +++++++++++++++++--
 .../IncompatibleDependencyCheck.java          |  4 +-
 2 files changed, 70 insertions(+), 8 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java
index 1598e1842c2..a49be01cb75 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DependencyVersionsDataCache.java
@@ -31,12 +31,18 @@ class DependencyVersionsDataCache<T> implements Serializable {
     // The cache is stored in a ConcurrentHashMap to ensure thread safety.
     private final ConcurrentHashMap<String, T> cache = new ConcurrentHashMap<>();
 
-    // The interval at which the cache is cleared. The cache is cleared every 30 days.
-    private static final long CLEANUP_INTERVAL = TimeUnit.DAYS.toMillis(30); // 1 day
+    // The interval at which the cache is cleared. The cache is cleared every 5 days.
+    private static final long CLEANUP_INTERVAL = TimeUnit.DAYS.toMillis(5);
 
     // The file where the cache is saved.
     private final File cacheFile;
 
+    // The timestamp when the cache was last updated.
+    private long lastUpdated;
+
+    // The timestamp when the cache will be refreshed.
+    private long nextRefresh;
+
     /**
      * Creates a new instance of the DependencyVersionsDataCache class.
      *
@@ -46,6 +52,9 @@ class DependencyVersionsDataCache<T> implements Serializable {
         this.cacheFile = new File(cacheFileName);
         loadCacheFromFile();
 
+        // Check if the cache needs to be cleared immediately
+        checkAndClearOnStartup();
+
         // Schedule the cache cleanup task to run at regular intervals
         ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1);
         scheduler.scheduleAtFixedRate(this::clear, CLEANUP_INTERVAL, CLEANUP_INTERVAL, TimeUnit.MILLISECONDS);
@@ -59,6 +68,7 @@ class DependencyVersionsDataCache<T> implements Serializable {
      */
     void put(String key, T value) {
         cache.put(key, value);
+        updateTimestamps();
         saveCacheToFile();
     }
 
@@ -78,6 +88,7 @@ T get(String key) {
      */
     void clear() {
         cache.clear();
+        updateTimestamps();
         saveCacheToFile();
     }
 
@@ -95,13 +106,15 @@ private void loadCacheFromFile() {
                 Object loadedObject = ois.readObject();
 
                 // Check if the deserialized object is an instance of ConcurrentHashMap
-                if (loadedObject instanceof ConcurrentHashMap) {
+                if (loadedObject instanceof CacheData) {
 
-                    // Cast the object to ConcurrentHashMap<String, T>
-                    ConcurrentHashMap<String, T> loadedCache = (ConcurrentHashMap<String, T>) loadedObject;
+                    CacheData<T> loadedCacheData = (CacheData<T>) loadedObject;
 
                     // Put all the entries from the loaded cache into the current cache
-                    cache.putAll(loadedCache);
+                    // Update the lastUpdated and nextRefresh timestamps
+                    cache.putAll(loadedCacheData.cache);
+                    lastUpdated = loadedCacheData.lastUpdated;
+                    nextRefresh = loadedCacheData.nextRefresh;
                 } else {
                     LOGGER.severe("Failed to load cache from file: Invalid cache format");
                 }
@@ -119,9 +132,56 @@ private void saveCacheToFile() {
 
         // Save the cache to the file using the ObjectOutputStream class.
         try (ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream(cacheFile))) {
-            oos.writeObject(cache);
+            CacheData<T> cacheData = new CacheData<>(cache, lastUpdated, nextRefresh);
+            oos.writeObject(cacheData);
         } catch (IOException e) {
             LOGGER.severe("Failed to save cache to file: " + e.getMessage());
         }
     }
+
+    /**
+     * Updates the timestamps for the cache.
+     * The lastUpdated timestamp is updated to the current time.
+     * The nextRefresh timestamp is updated to the current time plus the cleanup interval.
+     */
+    private void updateTimestamps() {
+        lastUpdated = System.currentTimeMillis();
+        nextRefresh = lastUpdated + CLEANUP_INTERVAL;
+    }
+
+    /**
+     * Checks if the cache needs to be cleared on startup.
+     * The cache is cleared if the lastUpdated timestamp is older than the cleanup interval.
+     */
+    private void checkAndClearOnStartup() {
+        long currentTime = System.currentTimeMillis();
+        if (currentTime - lastUpdated >= CLEANUP_INTERVAL) {
+            clear();
+        }
+    }
+
+    /**
+     * The CacheData class is a static inner class used to store the cache data in a serializable format.
+     * The class contains the cache, lastUpdated, and nextRefresh timestamps.
+     */
+    private static class CacheData<T> implements Serializable {
+        @Serial
+        private static final long serialVersionUID = 1L;
+        private final ConcurrentHashMap<String, T> cache;
+        private final long lastUpdated;
+        private final long nextRefresh;
+
+        /**
+         * Creates a new instance of the CacheData class.
+         *
+         * @param cache       The cache to store in the object.
+         * @param lastUpdated The timestamp when the cache was last updated.
+         * @param nextRefresh The timestamp when the cache will be refreshed.
+         */
+        CacheData(ConcurrentHashMap<String, T> cache, long lastUpdated, long nextRefresh) {
+            this.cache = cache;
+            this.lastUpdated = lastUpdated;
+            this.nextRefresh = nextRefresh;
+        }
+    }
 }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
index 0d0ebeef7a2..8f593480c68 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/IncompatibleDependencyCheck.java
@@ -62,7 +62,7 @@ protected void checkAndFlagVersion(String fullName, String currentVersion, Probl
             encounteredVersionGroups.add(versionGroup);
         }
 
-        // check if the encountered version group is not already in the encountered version groups
+        // check if the versionGroup found is not already in the encounteredVersionGroups set
         for (String encounteredVersionGroup : encounteredVersionGroups) {
 
             // check if the encountered version group is not the same as the current version group
@@ -77,8 +77,10 @@ protected void checkAndFlagVersion(String fullName, String currentVersion, Probl
                 // Flag the version if the minor version is different from the recommended version
                 String message = getFormattedMessage(fullName, recommendedVersion, IncompatibleDependencyVisitor.RULE_CONFIG);
                 holder.registerProblem(versionElement, message);
+                return;
             }
         }
+        encounteredVersionGroups.add(versionGroup);
     }
 
     /**

From d6a4e00251eca3e488acdc746df6b9976016791c Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Tue, 30 Jul 2024 20:03:52 -0700
Subject: [PATCH 140/144] address PR comments

---
 .../buildtool/UseOfBlockOnAsyncClientsCheck.java   | 13 +++++++------
 .../UseOfBlockOnAsyncClientsCheckTest.java         | 14 +++++++-------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
index 013e1ffc27e..2e98efafe53 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheck.java
@@ -13,7 +13,7 @@
 import org.jetbrains.annotations.NotNull;
 
 /**
- * Inspection tool to check for the use of block() method on async clients in Azure SDK.
+ * Inspection tool to check for the use of blocking method calls on async clients in Azure SDK.
  */
 public class UseOfBlockOnAsyncClientsCheck extends LocalInspectionTool {
 
@@ -67,8 +67,8 @@ static class UseOfBlockOnAsyncClientsVisitor extends JavaElementVisitor {
 
         /**
          * This method is used to visit the method call expression.
-         * The method call expression is checked to see if it is a block() method call on an async client.
-         * If the method call is a block() method call on an async client, it reports a problem.
+         * The method call expression is checked to see if it is a blocking method call on an async client.
+         * If the method call is a blocking method call on an async client, it reports a problem.
          *
          * @param expression PsiMethodCallExpression - the method call expression to visit
          */
@@ -89,18 +89,19 @@ public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expressio
 
                     if (isAsyncContext) {
                         holder.registerProblem(expression, RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
+                        return;
                     }
                 }
             }
         }
 
         /**
-         * This method is used to check if the method call is a block() method call on a reactive type.
-         * The method call is checked to see if it is a block() method call on a reactive type
+         * This method is used to check if the method call is a blocking method calls on a reactive type.
+         * The method call is checked to see if it is a blocking method call on a reactive type
          * and if the reactive type is an async client in Azure SDK.
          *
          * @param methodCall PsiMethodCallExpression - the method call expression to check
-         * @return true if the method call is a block() method call on an async client, false otherwise
+         * @return true if the method call is a blocking method calls on an async client, false otherwise
          */
         private boolean checkIfAsyncContext(@NotNull PsiMethodCallExpression methodCall) {
 
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
index f52eff7ff8b..f94f1471752 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/UseOfBlockOnAsyncClientsCheckTest.java
@@ -21,8 +21,8 @@
 
 /**
  * This class is used to test the UseOfBlockOnAsyncClientsCheck class.
- * The UseOfBlockOnAsyncClientsCheck class is an inspection tool that checks for the use of block() method on async clients in Azure SDK.
- * This inspection will check for the use of block() method on reactive types like Mono, Flux, etc.
+ * The UseOfBlockOnAsyncClientsCheck class is an inspection tool that checks for the use of blocking method on async clients in Azure SDK.
+ * This inspection will check for the use of blocking method on reactive types like Mono, Flux, etc.
  *  This is an example of what should be flagged:
  *
  *  private ServiceBusReceiverAsyncClient receiver;
@@ -63,8 +63,8 @@ public void setup() {
     }
 
     /**
-     * This is the main test method that tests the use of block() method on async clients.
-     * This method should be flagged by the inspection tool as it is a block() method call on an async client.
+     * This is the main test method that tests the use of blocking method on async clients.
+     * This method should be flagged by the inspection tool as it is a blocking method calls on an async client.
      */
     @Test
     public void testUseOfBlockOnAsyncClient() {
@@ -127,7 +127,7 @@ public void testVisitOnDifferentMethodCall() {
     }
 
     /**
-     * This test method tests the use of block() method on a non-reactive type.
+     * This test method tests the use of blocking method on a non-reactive type.
      * This method should not be flagged by the inspection tool.
      */
     @Test
@@ -142,7 +142,7 @@ public void testBlockOnNonReactiveType() {
     }
 
     /**
-     * This test method tests the use of block() method on a non-async client.
+     * This test method tests the use of blocking method on a non-async client.
      * This method should not be flagged by the inspection tool.
      */
     @Test
@@ -166,7 +166,7 @@ private JavaElementVisitor createVisitor() {
     }
 
     /**
-     * This method is used to verify the registerProblem method is called when the method call is a block() method call on an async client.
+     * This method is used to verify the registerProblem method is called when the method call is a blocking method call on an async client.
      *
      * @param methodName          String - the name of the method called
      * @param clientPackageName   String - the package name of the async client

From fb74cb827bf05ae78d5702d66f2540670dc1b443 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Sat, 3 Aug 2024 13:32:28 -0700
Subject: [PATCH 141/144] bug fix to prevent null exceptions & remove
 isOnTheFly

---
 .../buildtool/DetectDiscouragedClientCheck.java    | 14 ++++++++++----
 .../DetectDiscouragedClientCheckTest.java          |  3 +--
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
index 3bc80939151..4b8b100eff4 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheck.java
@@ -18,11 +18,14 @@ public class DetectDiscouragedClientCheck extends LocalInspectionTool {
     /**
      * This method builds a visitor to check for the discouraged client name in the code.
      * If the client name matches the discouraged client, a problem is registered with the suggestion message.
+     *
+     * @param holder     - the ProblemsHolder object to register the problem
+     * @param isOnTheFly - whether the inspection is on the fly - not used in this implementation but required by the parent class
      */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new DetectDiscouragedClientVisitor(holder, isOnTheFly);
+        return new DetectDiscouragedClientVisitor(holder);
     }
 
     /**
@@ -37,10 +40,9 @@ static class DetectDiscouragedClientVisitor extends JavaElementVisitor {
         /**
          * Constructor for the visitor
          *
-         * @param holder     - the ProblemsHolder object to register the problem
-         * @param isOnTheFly - whether the inspection is on the fly - not used in this implementation but required by the parent class
+         * @param holder - the ProblemsHolder object to register the problem
          */
-        DetectDiscouragedClientVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        DetectDiscouragedClientVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
@@ -74,6 +76,10 @@ public void visitTypeElement(PsiTypeElement element) {
 
                 String elementType = element.getType().getPresentableText();
 
+                if (!RULE_CONFIG.getAntiPatternMessageMap().containsKey(elementType)) {
+                    return;
+                }
+
                 // Register a problem if the client used matches a discouraged client
                 holder.registerProblem(element, RULE_CONFIG.getAntiPatternMessageMap().get(elementType));
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
index 3ad6b7df359..287cf1115cb 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DetectDiscouragedClientCheckTest.java
@@ -133,8 +133,7 @@ public void testProblemNotRegisteredWhenClientIsEmpty() {
      */
     private PsiElementVisitor createVisitor() {
 
-        boolean isOnTheFly = true;
-        DetectDiscouragedClientVisitor mockVisitor = new DetectDiscouragedClientVisitor(mockHolder, isOnTheFly);
+        DetectDiscouragedClientVisitor mockVisitor = new DetectDiscouragedClientVisitor(mockHolder);
         return mockVisitor;
     }
 

From 017b60aec67d317b75e815cb44dbca8e8203a357 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 8 Aug 2024 11:19:53 -0700
Subject: [PATCH 142/144] fix to handle an exception

---
 .../azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
index 84a6ce7c527..0f89529a7fc 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/HardcodedAPIKeysAndTokensCheck.java
@@ -69,6 +69,9 @@ public void visitElement(@NotNull PsiElement element) {
 
                 // Cast the element to a new expression
                 PsiNewExpression newExpression = (PsiNewExpression) element;
+                if (newExpression.getClassReference() == null) {
+                    return;
+                }
 
                 // Get the class reference name from the new expression
                 String classReference = newExpression.getClassReference().getReferenceName();

From 773f2611be036e0514338e965e9064e644a0bf67 Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 8 Aug 2024 14:53:44 -0700
Subject: [PATCH 143/144] bug fix to handle exception

---
 .../buildtool/DynamicClientCreationCheck.java | 15 +++++------
 .../DynamicClientCreationCheckTest.java       | 25 +++++++++----------
 2 files changed, 18 insertions(+), 22 deletions(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
index 13209343357..30c8b608b32 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheck.java
@@ -31,13 +31,13 @@ public class DynamicClientCreationCheck extends LocalInspectionTool {
     /**
      * This method builds the visitor that checks for the dynamic creation of clients in the code.
      *
-     * @param holder The holder for the problems found
+     * @param holder     The holder for the problems found
      * @return PsiElementVisitor
      */
     @NotNull
     @Override
     public JavaElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        return new DynamicClientCreationVisitor(holder, isOnTheFly);
+        return new DynamicClientCreationVisitor(holder);
     }
 
 
@@ -52,7 +52,7 @@ static class DynamicClientCreationVisitor extends JavaElementVisitor {
         private static final RuleConfig ruleConfig;
         private static final String ANTI_PATTERN_MESSAGE;
         private static final List<String> METHODS_TO_CHECK;
-        private static boolean SKIP_WHOLE_RULE;
+        private static final boolean SKIP_WHOLE_RULE;
 
         static {
             final String ruleName = "DynamicClientCreationCheck";
@@ -69,13 +69,10 @@ static class DynamicClientCreationVisitor extends JavaElementVisitor {
         /**
          * This constructor initializes the ProblemsHolder object.
          * It is used to register problems found in the code.
-         * <p>
-         * isOnTheFly is a boolean that indicates if the inspection is run on the fly.
-         * It is not in use in this implementation, but present by default in the method signature.
          *
-         * @param holder
+         * @param holder The holder for the problems found
          */
-        public DynamicClientCreationVisitor(ProblemsHolder holder, boolean isOnTheFly) {
+        public DynamicClientCreationVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
@@ -133,7 +130,7 @@ private void checkClientCreation(PsiStatement blockChild) {
                 PsiExpression rhs = assignment.getRExpression();
 
                 // Check if the right-hand side is a method call expression
-                if (rhs != null && isClientCreationMethod((PsiMethodCallExpression) rhs)) {
+                if (rhs instanceof PsiMethodCallExpression && isClientCreationMethod((PsiMethodCallExpression) rhs)) {
                     holder.registerProblem(rhs, ANTI_PATTERN_MESSAGE);
                 }
             } else if (blockChild instanceof PsiDeclarationStatement) {    // This is a check for the declaration statement
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
index d8d05606fdd..9a84f00e02b 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/test/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/DynamicClientCreationCheckTest.java
@@ -21,8 +21,6 @@
 import org.mockito.Mock;
 import org.mockito.Mockito;
 
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
@@ -71,8 +69,9 @@ void testDynamicClientCreationWithExpressionStatement() {
      * it encounters a code block that does not match the criteria for dynamic client creation.
      * This involves a method call on an object that is not part of the com.azure package
      */
-    @Test // unhappy path
-     void testDynamicClientCreationWithNonAzurePackage() {
+    @Test
+    // unhappy path
+    void testDynamicClientCreationWithNonAzurePackage() {
 
         int numOfInvocations = 0;
         String methodName = "buildClient";
@@ -108,8 +107,7 @@ void testDynamicClientCreationWithNonBuildMethod() {
      * This helper method creates a new instance of the DynamicClientCreationVisitor class.
      */
     private JavaElementVisitor createVisitor() {
-        boolean isOnTheFly = true;
-        DynamicClientCreationVisitor mockVisitor = new DynamicClientCreationVisitor(mockHolder, isOnTheFly);
+        DynamicClientCreationVisitor mockVisitor = new DynamicClientCreationVisitor(mockHolder);
         return mockVisitor;
     }
 
@@ -117,8 +115,8 @@ private JavaElementVisitor createVisitor() {
      * This method verifies that a problem is registered when a client creation method is found
      * building a client from the com.azure package in an assignment expression.
      *
-     * @param methodName this is the method name that is being checked for
-     * @param packageName this is the package name that is being checked for
+     * @param methodName       this is the method name that is being checked for
+     * @param packageName      this is the package name that is being checked for
      * @param numOfInvocations this is the number of times the registerProblem method should be called
      */
     private void verifyRegisterProblemWithAssignmentExpression(String methodName, String packageName, int numOfInvocations) {
@@ -128,7 +126,7 @@ private void verifyRegisterProblemWithAssignmentExpression(String methodName, St
         PsiBlockStatement body = mock(PsiBlockStatement.class);
         PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
         PsiExpressionStatement blockChild = mock(PsiExpressionStatement.class);
-        PsiStatement[] blockStatements = new PsiStatement[] { blockChild };
+        PsiStatement[] blockStatements = new PsiStatement[]{blockChild};
 
         // checkClientCreation method
         PsiAssignmentExpression expression = mock(PsiAssignmentExpression.class);
@@ -166,8 +164,9 @@ private void verifyRegisterProblemWithAssignmentExpression(String methodName, St
     /**
      * This method verifies that a problem is registered when a client creation method is found
      * building a client from the com.azure package in a declaration statement.
-     * @param methodName this is the method name that is being checked for
-     * @param packageName this is the package name that is being checked for
+     *
+     * @param methodName       this is the method name that is being checked for
+     * @param packageName      this is the package name that is being checked for
      * @param numOfInvocations this is the number of times the registerProblem method should be called
      */
     private void verifyRegisterProblemWithDeclarationStatement(String methodName, String packageName, int numOfInvocations) {
@@ -177,11 +176,11 @@ private void verifyRegisterProblemWithDeclarationStatement(String methodName, St
         PsiBlockStatement body = mock(PsiBlockStatement.class);
         PsiCodeBlock codeBlock = mock(PsiCodeBlock.class);
         PsiDeclarationStatement blockChild = mock(PsiDeclarationStatement.class);
-        PsiStatement[] blockStatements = new PsiStatement[] { blockChild };
+        PsiStatement[] blockStatements = new PsiStatement[]{blockChild};
 
         // checkClientCreation method
         PsiLocalVariable declaredElement = mock(PsiLocalVariable.class);
-        PsiElement[] declaredElements = new PsiElement[] { declaredElement };
+        PsiElement[] declaredElements = new PsiElement[]{declaredElement};
         PsiMethodCallExpression initializer = mock(PsiMethodCallExpression.class);
 
         // isClientCreationMethod

From 6386714bdcea1f13d1899096d495ecca16d7a29b Mon Sep 17 00:00:00 2001
From: Njeri Mwenjwa <joymwenjwa@gmail.com>
Date: Thu, 8 Aug 2024 15:25:23 -0700
Subject: [PATCH 144/144] small edit

---
 .../KustoQueriesWithTimeIntervalInQueryStringCheck.java          | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
index 6bca268d2a5..0da18bc491d 100644
--- a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
+++ b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-azure-sdk/src/main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/KustoQueriesWithTimeIntervalInQueryStringCheck.java
@@ -88,7 +88,6 @@ static class KustoQueriesVisitor extends JavaElementVisitor {
             }
             REGEX_PATTERNS = Collections.unmodifiableList(tempPatterns);
             SKIP_WHOLE_RULE = RULE_CONFIG.skipRuleCheck() || REGEX_PATTERNS.isEmpty();
-            System.out.println("SKIP_WHOLE_RULE: " + RULE_CONFIG.getAntiPatternMessageMap().get("antiPatternMessage"));
         }
 
         // empty list to store time interval parameter names