Skip to content

Commit 709e977

Browse files
authored
[Medium] patch gh for CVE-2025-22872 (#13531)
1 parent 43dfa39 commit 709e977

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed

SPECS/gh/CVE-2025-22872.patch

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
From 01035da6c5be2080f75765d9ebbb462614d7e81a Mon Sep 17 00:00:00 2001
2+
From: jykanase <[email protected]>
3+
Date: Tue, 22 Apr 2025 08:15:38 +0000
4+
Subject: [PATCH] CVE-2025-22872
5+
6+
Upstream patch reference: https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9
7+
---
8+
vendor/golang.org/x/net/html/token.go | 18 ++++++++++++++++--
9+
1 file changed, 16 insertions(+), 2 deletions(-)
10+
11+
diff --git a/vendor/golang.org/x/net/html/token.go b/vendor/golang.org/x/net/html/token.go
12+
index 3c57880..6598c1f 100644
13+
--- a/vendor/golang.org/x/net/html/token.go
14+
+++ b/vendor/golang.org/x/net/html/token.go
15+
@@ -839,8 +839,22 @@ func (z *Tokenizer) readStartTag() TokenType {
16+
if raw {
17+
z.rawTag = strings.ToLower(string(z.buf[z.data.start:z.data.end]))
18+
}
19+
- // Look for a self-closing token like "<br/>".
20+
- if z.err == nil && z.buf[z.raw.end-2] == '/' {
21+
+ // Look for a self-closing token (e.g. <br/>).
22+
+ //
23+
+ // Originally, we did this by just checking that the last character of the
24+
+ // tag (ignoring the closing bracket) was a solidus (/) character, but this
25+
+ // is not always accurate.
26+
+ //
27+
+ // We need to be careful that we don't misinterpret a non-self-closing tag
28+
+ // as self-closing, as can happen if the tag contains unquoted attribute
29+
+ // values (i.e. <p a=/>).
30+
+ //
31+
+ // To avoid this, we check that the last non-bracket character of the tag
32+
+ // (z.raw.end-2) isn't the same character as the last non-quote character of
33+
+ // the last attribute of the tag (z.pendingAttr[1].end-1), if the tag has
34+
+ // attributes.
35+
+ nAttrs := len(z.attr)
36+
+ if z.err == nil && z.buf[z.raw.end-2] == '/' && (nAttrs == 0 || z.raw.end-2 != z.attr[nAttrs-1][1].end-1) {
37+
return SelfClosingTagToken
38+
}
39+
return StartTagToken
40+
--
41+
2.45.2
42+

SPECS/gh/gh.spec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Summary: GitHub official command line tool
22
Name: gh
33
Version: 2.62.0
4-
Release: 7%{?dist}
4+
Release: 8%{?dist}
55
License: MIT
66
Vendor: Microsoft Corporation
77
Distribution: Azure Linux
@@ -21,6 +21,7 @@ Patch5: CVE-2024-53859.patch
2121
Patch6: CVE-2025-25204.patch
2222
Patch7: CVE-2025-27144.patch
2323
Patch8: CVE-2025-22869.patch
24+
Patch9: CVE-2025-22872.patch
2425

2526
BuildRequires: golang < 1.23
2627
BuildRequires: git
@@ -63,6 +64,9 @@ make test
6364
%{_datadir}/zsh/site-functions/_gh
6465

6566
%changelog
67+
* Tue Apr 22 2025 Jyoti Kanase <[email protected]> - 2.62.0-8
68+
- Patch CVE-2025-22872
69+
6670
* Fri Feb 28 2025 Kanishk Bansal <[email protected]> - 2.62.0-7
6771
- Fix CVE-2025-27144, CVE-2025-22869 with an upstream patch
6872

0 commit comments

Comments
 (0)