Skip to content

Fix "Conda init bash" issue. #14458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

Fix "Conda init bash" issue. #14458

merged 4 commits into from
Aug 20, 2025

Conversation

rikenm1
Copy link
Contributor

@rikenm1 rikenm1 commented Aug 7, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?
=> This PR fixes bash init issue: This issue is when the customer does conda init bash, it fails.
=> To fix the 1st issue added the missing shell files. These new hook files will never be used as we do not provide xsh and fish shell but conda does look for them regardless when we init conda for bash.

Change Log
  • Change: Fix conda init bash
Does this affect the toolchain?

YES/NO
NO

Fixes bug: 58420438

Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Aug 7, 2025
@CBL-Mariner-Bot
Copy link
Collaborator

CBL-Mariner-Bot commented Aug 7, 2025 •
edited
Loading

✅ PR Check Passed

No critical issues detected in spec file changes.

🤖 AI Analysis Summary:

Brief Analysis: The changes update the release version from 3 to 4 and adjust installation paths (adding conda.xsh and relocating the fish configuration), with no new CVE-specific patches or CVE-YYYY-XXXXX.patch references introduced.

Critical Issues Found:
• No CVE patch names or references in the expected format were added, so no missing or improperly named CVE patches were detected.

Recommended Actions:
• Verify that the new conda.xsh file and fish config changes maintain proper file permissions and security contexts.
• Ensure that any future security patches follow the prescribed CVE-YYYY-XXXXX.patch naming and ordering.
• Confirm test suites cover the installation path changes to avoid regressions.

📋 For detailed analysis and recommendations, check the Azure DevOps pipeline logs.

@rikenm1 rikenm1 marked this pull request as ready for review August 7, 2025 23:12
@rikenm1 rikenm1 requested a review from a team as a code owner August 7, 2025 23:12
@rikenm1 rikenm1 changed the title Fix Conda "Conda init bash" issue. Fix "Conda init bash" issue. Aug 7, 2025
@rikenm1 rikenm1 changed the title Fix "Conda init bash" issue. Fix "Conda init bash" issue and Also add missing conda runtime packages for container . Aug 14, 2025
@rikenm1 rikenm1 changed the title Fix "Conda init bash" issue and Also add missing conda runtime packages for container . Fix "Conda init bash" issue and also add missing conda runtime packages for container . Aug 14, 2025
@rikenm1 rikenm1 changed the title Fix "Conda init bash" issue and also add missing conda runtime packages for container . Fix "Conda init bash" issue and also add missing conda runtime packages for container. Aug 15, 2025
@rikenm1 rikenm1 changed the title Fix "Conda init bash" issue and also add missing conda runtime packages for container. Fix "Conda init bash" issue. Aug 18, 2025
@rikenm1 rikenm1 merged commit b9f003c into 3.0-dev Aug 20, 2025
32 checks passed
@rikenm1 rikenm1 deleted the rmaharjan/fix-conda-init branch August 20, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherco christopherco christopherco approved these changes

Assignees
No one assigned
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikenm1 @CBL-Mariner-Bot @christopherco