Skip to content

Commit a0bb896

Browse files
committed
Chore commits should map to 'none' type beachball changes
1 parent 5261efb commit a0bb896

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/__tests__/changefile/conventionalCommits.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ import { parseConventionalCommit } from '../../changefile/conventionalCommits';
22

33
describe.each<[string, ReturnType<typeof parseConventionalCommit>]>([
44
['fix: change message\nbody', { type: 'patch', message: 'change message' }],
5-
['chore: change', { type: 'patch', message: 'change' }],
5+
['chore: change', { type: 'none', message: 'change' }],
66
['feat: change', { type: 'minor', message: 'change' }],
77
['feat(scope): change', { type: 'minor', message: 'change' }],
88
['feat!: change', { type: 'major', message: 'change' }],
99
['feat(scope)!: change', { type: 'major', message: 'change' }],
1010
['foo', undefined],
11+
['fix(foo-bar): change', { type: 'patch', message: 'change' }],
1112
])('parse(%s)', (s, expected) => {
1213
test('should parse correctly', () => expect(parseConventionalCommit(s)).toEqual(expected));
1314
});

src/changefile/conventionalCommits.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { ChangeType } from '../types/ChangeInfo';
66
* 3. breaking
77
* 4. message
88
*/
9-
const COMMIT_RE = /([a-z]+)(?:\(([a-z]+)\))?(!)?: (.+)/;
9+
const COMMIT_RE = /([a-z]+)(?:\(([a-z\-]+)\))?(!)?: (.+)/;
1010

1111
interface ConventionalCommit {
1212
type: string;
@@ -34,8 +34,9 @@ function map(d: ConventionalCommit): Change | undefined {
3434
}
3535

3636
switch (d.type) {
37-
case 'fix':
3837
case 'chore':
38+
return { type: 'none', message: d.message };
39+
case 'fix':
3940
return { type: 'patch', message: d.message };
4041
case 'feat':
4142
return { type: 'minor', message: d.message };

0 commit comments

Comments
 (0)