Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit 104f81a

Browse files
JSprumunozemilio
authored andcommitted
LUIS application create - update to bring in line w latest spec (#360)
* Update to bring in line w latest spec * Adding tokenizerVersion flag
1 parent 4ac2e29 commit 104f81a

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

packages/luis/src/commands/luis/application/create.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class LuisApplicationCreate extends Command {
1212

1313
static examples = [`
1414
$ bf luis:application:create --endpoint {ENDPOINT} --subscriptionKey {SUBSCRIPTION_KEY} --name {NAME} --culture {CULTURE}
15-
--domain {DOMAIN} --description {DESCRIPTION} --initialVersionId {INITIAL_VERSION_ID} --usageScenario {USAGE_SCENARIO}
15+
--domain {DOMAIN} --description {DESCRIPTION} --versionId {INITIAL_VERSION_ID} --usageScenario {USAGE_SCENARIO}
1616
`]
1717

1818
static flags = {
@@ -21,10 +21,9 @@ export default class LuisApplicationCreate extends Command {
2121
subscriptionKey: flags.string({description: 'LUIS cognitive services subscription key (aka Ocp-Apim-Subscription-Key)'}),
2222
name: flags.string({description: 'LUIS application name'}),
2323
culture: flags.string({description: 'LUIS application culture'}),
24-
domain: flags.string({description: 'LUIS application domain'}),
2524
description: flags.string({description: 'LUIS application description'}),
26-
initialVersionId: flags.string({description: 'LUIS application initial version Id'}),
27-
usageScenario: flags.string({description: 'LUIS application usage scenario'}),
25+
versionId: flags.string({description: 'LUIS application initial version Id'}),
26+
tokenizerVersion: flags.string({description: 'Version specifies how sentences are tokenized.'}),
2827
}
2928

3029
async run() {
@@ -37,19 +36,20 @@ export default class LuisApplicationCreate extends Command {
3736
subscriptionKey,
3837
name,
3938
culture,
40-
domain,
4139
description,
42-
initialVersionId,
43-
usageScenario
40+
versionId,
41+
tokenizerVersion
4442
} = await utils.processInputs(flags, flagLabels, configDir)
4543

46-
const requiredProps = {endpoint, subscriptionKey, name, domain}
44+
const usageScenario = 'Bot Framework'
45+
46+
const requiredProps = {endpoint, subscriptionKey, name}
4747
utils.validateRequiredProps(requiredProps)
4848

4949
const client = utils.getLUISClient(subscriptionKey, endpoint)
5050
const options = {}
5151

52-
const applicationCreateObject = {name, culture, domain, description, initialVersionId, usageScenario}
52+
const applicationCreateObject = {name, culture, description, versionId, usageScenario, tokenizerVersion}
5353

5454
try {
5555
const newAppId = await client.apps.add(applicationCreateObject, options)

packages/luis/test/commands/luis/application/create.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ describe('luis:application:create', () => {
2727
test
2828
.stdout()
2929
.stderr()
30-
.command(['luis:application:create', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--subscriptionKey', uuidv1(), '--culture', 'en-us', '--domain', 'Comics', '--description', 'test description', '--initialVersionId', '0.04', '--usageScenario', 'For use in our test app'])
30+
.command(['luis:application:create', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--subscriptionKey', uuidv1(), '--culture', 'en-us', '--description', 'test description', '--versionId', '0.04'])
3131
.it('displays an error if any required input parameters are missing', ctx => {
3232
expect(ctx.stderr).to.contain(`Required input property 'name' missing.`)
3333
})
3434

3535
test
3636
.stdout()
3737
.stderr()
38-
.command(['luis:application:create', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--name', 'orange_app', '--culture', 'en-us', '--domain', 'Comics', '--description', 'test description', '--initialVersionId', '0.04', '--usageScenario', 'For use in our test app'])
38+
.command(['luis:application:create', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--name', 'orange_app', '--culture', 'en-us', '--description', 'test description', '--versionId', '0.04'])
3939
.it('displays an error if any required input parameters are missing', ctx => {
4040
expect(ctx.stderr).to.contain(`Required input property 'subscriptionKey' missing.`)
4141
})
@@ -46,15 +46,15 @@ describe('luis:application:create', () => {
4646
.reply(201, '99999')
4747
)
4848
.stdout()
49-
.command(['luis:application:create', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--name', 'orange_app', '--subscriptionKey', uuidv1(), '--culture', 'en-us', '--domain', 'Comics', '--description', 'test description', '--initialVersionId', '0.04', '--usageScenario', 'For use in our test app'])
49+
.command(['luis:application:create', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--name', 'orange_app', '--subscriptionKey', uuidv1(), '--culture', 'en-us', '--description', 'test description', '--versionId', '0.04'])
5050
.it('creates a luis app and returns the new app\'s id', ctx => {
5151
expect(ctx.stdout).to.contain('App successfully created with id 99999')
5252
})
5353

5454
test
5555
.stdout()
5656
.stderr()
57-
.command(['luis:application:create', '--endpoint', 'undefined', '--name', 'orange_app', '--subscriptionKey', uuidv1(), '--culture', 'en-us', '--domain', 'Comics', '--description', 'test description', '--initialVersionId', '0.04', '--usageScenario', 'For use in our test app'])
57+
.command(['luis:application:create', '--endpoint', 'undefined', '--name', 'orange_app', '--subscriptionKey', uuidv1(), '--culture', 'en-us', '--description', 'test description', '--versionId', '0.04'])
5858
.it('fails to create an app and displays an error message if the endpoint is null', ctx => {
5959
expect(ctx.stderr).to.contain('Access denied due to invalid subscription key or wrong API endpoint.')
6060
})

0 commit comments

Comments
 (0)