Shared root tsconfig.json with overrides (#1003)

* Shared root tsconfig.json with overrides

Also move test hook to repo root and reference in mocha.opts

* Fix dialog compilation issues

* Luis compilation issue fixes

* Chatdown test fixes

* Luis test fixes

* Fix dialog verify test

* Bump ts-node and clean up test tsconfigs

Author: joshgummersall

common/config/rush/pnpm-lock.yaml

@@ -30,6 +30,7 @@
     "@oclif/test": "^1.2.4",
     "@oclif/tslint": "^3.1.1",
     "@types/chai": "^4.1.7",
+    "@types/fs-extra": "^5.0.5",
     "@types/mocha": "^5.2.6",
     "@types/node": "^10.14.6",
     "@types/rimraf": "^2.0.2",
@@ -38,9 +39,9 @@
     "mocha": "^6.2.2",
     "nyc": "^14.1.1",
     "rimraf": "^2.6.3",
-    "ts-node": "^8.1.0",
+    "ts-node": "^9.0.0",
     "tslint": "^5.16.0",
-    "typescript": "3.5.3"
+    "typescript": "^4.0.3"
   },
   "engines": {
     "node": ">=8.0.0"

packages/chatdown/package.json

@@ -1,9 +1,10 @@
-import {expect, test} from '@oclif/test'
 import * as cp from 'child_process';
-import * as rimraf from 'rimraf';
-let pkg = require('../../../package.json');
-let assert = require('assert');
-const fs = require('fs-extra')
+import assert from 'assert';
+import fs from 'fs-extra';
+import rimraf from 'rimraf';
+import {expect, test} from '@oclif/test'
+
+const pkg = require('../../../package.json');
 
 describe('chatdown:convert', function() {
 

packages/chatdown/test/commands/chatdown/convert.test.ts

@@ -1,5 +1,5 @@
---require test/hook.js
+--require ../../test/hook.js
 --require source-map-support/register
 --recursive
 --timeout 10000
-**/*.test.{ts,js}
+**/*.test.{ts,js}

packages/chatdown/test/hook.js

@@ -1,9 +1,5 @@
 {
-  "extends": "../tsconfig",
-  "compilerOptions": {
-    "noEmit": true,
-    "noImplicitAny": false
-  },
+  "extends": "../tsconfig.json",
   "references": [
     {"path": ".."}
   ]

packages/chatdown/test/mocha.opts

@@ -1,13 +1,8 @@
 {
+  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "declaration": true,
-    "importHelpers": true,
-    "module": "commonjs",
     "outDir": "lib",
-    "rootDir": "src",
-    "strict": true,
-    "target": "es2017",
-    "composite": true
+    "rootDir": "src"
   },
   "include": [
     "src/**/*"

packages/chatdown/test/tsconfig.json

@@ -89,8 +89,8 @@
     "nock": "^11.7.0",
     "nyc": "^14.1.1",
     "rimraf": "^2.6.3",
-    "ts-node": "^8.1.0",
+    "ts-node": "^9.0.0",
     "tslint": "^5.16.0",
-    "typescript": "^3.5.3"
+    "typescript": "^4.0.3"
   }
 }

packages/chatdown/tsconfig.json

@@ -1,5 +1,5 @@
---require test/hook.js
+--require ../../test/hook.js
 --require source-map-support/register
 --recursive
 --timeout 60000
-**/*.test.{ts,js}
+**/*.test.{ts,js}