Merge pull request #210 from microsoft/emimunoz/config

Adding flag to enable telemetry

Author: munozemilio

packages/config/src/commands/config/set/telemetry.ts

@@ -6,14 +6,18 @@ export default class ConfigSetTelemetry extends Command {
 
   static flags = {
     help: flags.help({char: 'h'}),
-    disable: flags.boolean({char: 'd', description: 'Disable tlemetry', default: false})
+    disable: flags.boolean({char: 'd', description: 'Disable tlemetry'}),
+    enable: flags.boolean({char: 'e', description: 'Enable tlemetry'})
   }
 
   async run() {
     const {flags} = this.parse(ConfigSetTelemetry)
     let userConfig: Config = await getConfigFile(this.config.configDir)
-    userConfig.telemetry = !flags.disable
+    if (!flags.enable && !flags.disable) {
+      this._help()
+    }
+    userConfig.telemetry = flags.enable ? true : false
     await writeConfigFile(this.config.configDir, userConfig)
-    this.log('Telemetry set to ' + !flags.disable)
+    this.log('Telemetry set to ' + userConfig.telemetry)
   }
 }

packages/config/test/commands/config/set/telemetry.test.ts

@@ -4,27 +4,36 @@ const fs = require('fs-extra')
 
 describe('config:set:telemetry', () => {
   test
-    before(async function() {
+    beforeEach(async function() {
       await initTestConfigFile()
     });
 
     after(async function() {
       await deleteTestConfigFile()
     });
-  
-    test
+
+      test
+      .stdout()
+      .command(['config:set:telemetry', '--disable'])
+      .it('Disables telemetry in config file', async ctx => {
+        let config = await fs.readJSON(getConfigFile())
+        expect(config.telemetry).to.be.false
+      })
+
+      test
       .stdout()
       .command(['config:set:telemetry'])
-      .it('Enables telemetry in config file', async ctx => {
+      .it('Shows help and keeps the same seetings', async ctx => {
         let config = await fs.readJSON(getConfigFile())
         expect(config.telemetry).to.be.true
+        expect(ctx.stdout).to.be.contain('Enable or disable telemetry')
       })
 
       test
       .stdout()
-      .command(['config:set:telemetry', '--disable'])
-      .it('Disables telemetry in config file', async ctx => {
+      .command(['config:set:telemetry', '--enable'])
+      .it('Enables telemetry in config file', async ctx => {
         let config = await fs.readJSON(getConfigFile())
-        expect(config.telemetry).to.be.false
+        expect(config.telemetry).to.be.true
       })
 })