Merge branch 'master' into scheyal-patch-3

Author: Eyal

Internal-Hackathon-Oct-18-2019.md

@@ -58,6 +58,8 @@ export default class Chatdown extends Command {
           if (typeof writeConfirmation === 'string') {
             process.stdout.write(`${chalk.green('Successfully wrote file:')}  ${writeConfirmation}\n`)
           }
+        } else if (flags.in && !fileContents) {
+          throw new CLIError('No file contents found in: ' + flags.in)
         } else {
           return this._help()
         }

README.md

@@ -38,7 +38,7 @@ const getUserConfig = async () => {
     const userConfig = await getUserConfig()
     userConfig.lastVersionCheck = new Date()
     if (userConfig.telemetry === null) {
-      const disableTelemetry = await cli.prompt(chalk.red('Telemetry is disabled. Would you like to opt in? Only command and flags usage will be sent. (Y/N)'))
+      const disableTelemetry = await cli.prompt(chalk.red('Help us improve products by allowing Microsoft to collect anonymous command and flags usage: (Y/N)'))
       if (disableTelemetry === 'Y' || disableTelemetry === 'y') {
         userConfig.telemetry = true
         console.log(chalk.blue('Telemetry has been enabled.'))

packages/chatdown/README.md

@@ -66,7 +66,7 @@ const hook: Hook<'init'> = async function (opts) {
   // Ensure telemetry is set
   try {
     if (userConfig.telemetry === null) {
-      const disableTelemetry = await cli.prompt(chalk.red('Telemetry is disabled. Would you like to opt in?. Only command and flags usage will be sent. (Y/N)'))
+      const disableTelemetry = await cli.prompt(chalk.red('Help us improve products by allowing Microsoft to collect anonymous command and flags usage: (Y/N)'))
       if (disableTelemetry === 'Y' || disableTelemetry === 'y') {
         userConfig.telemetry = true
         this.log(chalk.blue('Telemetry has been enabled.'))

packages/chatdown/src/commands/chatdown.ts

@@ -16,6 +16,7 @@ const ReadPipedStdin = {
       }, 1000)
 
       stdin.on('data', chunk => {
+        clearTimeout(timer)
         input += chunk
       })
 

packages/cli/README.md

@@ -95,20 +95,6 @@ describe('command', () => {
   .do(output => expect(output.stderr).to.equal(''))
   .it('Command should return empty string if no stdin')
 
-  fancy
-  .stdin('test reading of piped data')
-  .stdout()
-  .do(async () => {
-    try {
-      const resp: any = await ReadPipedStdin.read()
-      if (resp) console.log(resp)
-    } catch (error) {
-      if (error) console.log(`Error: ${error}`)
-    }
-  })
-  .do(output => expect(output.stdout).to.equal('test reading of piped data\n'))
-  .it('should read and echo the stdin input')
-
   fancy
   .stdin('')
   .stdout()