Change static flag to stamp, reorder file write functions (#275)

* Change static flag to stamp, reorder file write functions

* Update timestamp test

* Fix tests

* Fix lint

* Add unit test to bump coverage percent

Author: JSpru

packages/chatdown/src/commands/chatdown/convert.ts

@@ -24,7 +24,7 @@ export default class ChatdownConvert extends Command {
   static flags = {
     in: flags.string({char: 'i', description: 'The path of the chat file or directory to be parsed. A glob expression may be passed containing chat files to be processed all at once, ex. ./**/*.chat. If flag is omitted, stdin will be used. If an output directory is not present (-o), it will default the output to the current working directory.'}),
     out: flags.string({char: 'o', description: 'Path to the directory where the output of the multiple chat file processing (-o) will be placed.'}),
-    static: flags.boolean({char: 's', description: 'Use static timestamps when generating timestamps on activities.'}),
+    stamp: flags.boolean({char: 's', description: 'Use static timestamps when generating timestamps on activities.'}),
     prefix: flags.boolean({char: 'p', description: 'Prefix stdout with package name.'}),
     force: flags.boolean({char: 'f', description: 'If --out flag is provided with the path to an existing file, overwrites that file', default: false}),
     help: flags.help({char: 'h', description: 'Chatdown command help'})
@@ -150,8 +150,8 @@ export default class ChatdownConvert extends Command {
   private async writeOut(activities: any, fileName: string, outputDir: any, force: boolean) {
     if (fileName && outputDir) {
       let writeFile = path.join(outputDir, `${fileName}.transcript`)
-      await fs.ensureFile(writeFile)
       let validatedPath = utils.validatePath(writeFile, '', force)
+      await fs.ensureFile(writeFile)
       await fs.writeJson(validatedPath, activities, {spaces: 2})
       return writeFile
     }

packages/chatdown/test/commands/chatdown/convert.test.ts

@@ -3,9 +3,14 @@ import * as cp from 'child_process';
 import * as rimraf from 'rimraf';
 let pkg = require('../../../package.json');
 let assert = require('assert');
+const fs = require('fs-extra')
 
 describe('chatdown:convert', () => {
 
+  before(() => { 
+    fs.mkdirSync('./testout');
+  });
+
   after(() => {
     rimraf('./testout', (err) => {
       if (err) console.log(err);
@@ -40,8 +45,8 @@ describe('chatdown:convert', () => {
     });
   });
 
-  it('should generate static based timestamps when --static is passed as an argument', done => {
-    cp.exec(`(echo user=Joe && [ConversationUpdate=MembersAdded=Joe]) | node ./bin/run chatdown:convert --static`, (error, stdout) => {
+  it('should generate timestamps when --stamp is passed as an argument', done => {
+    cp.exec(`(echo user=Joe && [ConversationUpdate=MembersAdded=Joe]) | node ./bin/run chatdown:convert --stamp`, (error, stdout) => {
       assert.doesNotThrow(() => JSON.parse(stdout));
       done();
     });
@@ -89,4 +94,11 @@ describe('chatdown:convert', () => {
     });
   });
 
+  it('should display an error message when the out directory does not exist', done => {
+    cp.exec(`node ./bin/run chatdown:convert -i "./test/utils/cli.sample.chat" -o ./xyz`, (error, stdout, stderr) => {
+      assert(stderr.includes('Containing directory path doesn\'t exist'));
+        done();
+      });
+  });
+
 })

packages/chatdown/utils/index.js

@@ -37,7 +37,7 @@ let workingDirectory;
  * @returns {Promise<Array>} Resolves with an array of Activity objects.
  */
 module.exports = async function readContents(fileContents, args = {}) {
-    if (args.static || args.s) {
+    if (args.stamp || args.s) {
         now = new Date(2015, 9, 15, 12, 0, 0, 0).getTime();
     }
     // Resolve file paths based on the input file with a fallback to the cwd