Refactor file writing fo rconfig

Author: Jonathan Spruance (Insight Global)

packages/cli/scripts/postinstall.js

@@ -13,6 +13,7 @@ const packageName = pjson.name
 const platform = os.platform()
 const isWindows = platform === 'win32'
 const home = process.env.HOME || (isWindows && windowsHome()) || os.homedir() || os.tmpdir()
+const today = new Date();
 
 const getConfigDir = (isWindows, home, pname) => {
     const base = process.env[`XDG_CONFIG_HOME`]
@@ -36,6 +37,7 @@ const getUserConfig = async () => {
  const promptTelemetry = async () => {
   try {
     const userConfig = await getUserConfig()
+    userConfig.lastVersionCheck = today;
     if (userConfig.telemetry === null) {
       const disableTelemetry = await cli.prompt(chalk.red('Telemetry is disabled. Would you like to opt in? Only command and flags usage will be sent. (Y/N)'))
       if (disableTelemetry === 'Y' || disableTelemetry === 'y') {
@@ -53,7 +55,6 @@ const getUserConfig = async () => {
       }
 
       await fs.mkdirp(pathToConfigJson)
-      
       await fs.writeFile(path.join(pathToConfigJson, 'config.json'), JSON.stringify(userConfig, null, 2))
     }
   /* tslint:disable:no-unused */

packages/cli/src/hooks/init/inithook.ts

@@ -12,8 +12,9 @@ const hook: Hook<'init'> = async function (opts) {
   const curDateTime = new Date()
   const configFileExists = fs.existsSync(path.join(this.config.configDir, 'config.json'))
 
-  const createConfigDir = async (path: string) => {
+  const writeUserConfig = async (userconfig: any) => {
     await fs.mkdirp(this.config.configDir)
+    await fs.writeFile(path.join(this.config.configDir, 'config.json'), JSON.stringify(userconfig, null, 2))
   }
 
   try {
@@ -37,10 +38,9 @@ const hook: Hook<'init'> = async function (opts) {
       }
     }
 
-    const updateUserConfig = (curVersionCheck: Date) => {
+    const updateUserConfig = async (curVersionCheck: Date) => {
       userConfig.lastVersionCheck = curVersionCheck
-      createConfigDir(this.config.configDir)
-      fs.writeFileSync(path.join(this.config.configDir, 'config.json'), JSON.stringify(userConfig, null, 2))
+      await writeUserConfig(userConfig)
     }
 
     const isToday = (dateObj: Date | null, today: Date) => {
@@ -81,9 +81,7 @@ const hook: Hook<'init'> = async function (opts) {
         this.log(chalk.blue('bf config:telemetry:enable'))
       }
 
-      createConfigDir(this.config.configDir)
-
-      await fs.writeFile(path.join(this.config.configDir, 'config.json'), JSON.stringify(userConfig, null, 2))
+      await writeUserConfig(userConfig)
     }
 
     this.config.pjson.telemetry = userConfig.telemetry