Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit 50bae19

Browse files
authored
Adding fix and test for luis:convert on missing luis members (#1115)
1 parent 94a5217 commit 50bae19

File tree

4 files changed

+973
-1
lines changed

4 files changed

+973
-1
lines changed

packages/luis/src/utils/luisinstanceutils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
export function sort(luisInstance: any) {
1010
let props = ['intents', 'composites', 'entities', 'closedLists', 'regex_entities', 'model_features', 'patternAnyEntities', 'prebuiltEntities']
1111
for (const key of props) {
12-
luisInstance[key].sort(sortComparers.compareNameFn)
12+
luisInstance[key]?.sort(sortComparers.compareNameFn)
1313
}
1414

1515
luisInstance.utterances.sort(sortComparers.compareIntentFn)

packages/luis/test/commands/luis/convert.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,13 @@ describe('luis:convert sort option enabled', () => {
461461
.it('luis:convert With -r/ --sort option, correctly sorts a LUIS model', async () => {
462462
expect(await compareLuFiles('./../../../results/root50.lu', './../../fixtures/verified/luis_sorted.lu')).to.be.true
463463
})
464+
465+
test
466+
.stdout()
467+
.command(['luis:convert', '--in', `${path.join(__dirname, './../../fixtures/testcases/missing_member.json')}`, '--out', './results/root51.lu', '--sort'])
468+
.it('luis:convert With -r/ --sort option, correctly sorts a LUIS model with missing members', async () => {
469+
expect(await compareLuFiles('./../../../results/root51.lu', './../../fixtures/verified/luis_sorted_missing_member.lu')).to.be.true
470+
})
464471
})
465472

466473
describe('luis:convert file creation', () => {

0 commit comments

Comments
 (0)