Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit 591a4b6

Browse files
authored
Upgrade Antlr to 4.9.2 (#1254)
* Upgrade to antlr 4.9 import changes * Fixing ErrorListener * Upgrading engine reqs in build and cli package.json * Setting engine reqs for bf-lu * Adding generated files to gitignore file
1 parent 3ce503f commit 591a4b6

23 files changed

+6392
-6485
lines changed

build/bf-cli-build-test-steps.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ steps:
3030
continueOnError: true
3131

3232
- task: NodeTool@0
33-
displayName: 'Use Node 12.x'
33+
displayName: 'Use Node 14.x'
3434
inputs:
35-
versionSpec: 12.x
35+
versionSpec: 14.x
3636

3737
- task: Npm@1
3838
displayName: 'npm install --global @microsoft/rush'

build/botframework-cli-beta.yml

Lines changed: 0 additions & 33 deletions
This file was deleted.

build/botframework-cli.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ jobs:
2828
continueOnError: true
2929

3030
- task: NodeTool@0
31-
displayName: 'Use Node 12.x'
31+
displayName: 'Use Node 14.x'
3232
inputs:
33-
versionSpec: 12.x
33+
versionSpec: 14.x
3434

3535
- task: Npm@1
3636
displayName: 'npm install --global @microsoft/rush'

common/config/rush/pnpm-lock.yaml

Lines changed: 53 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
},
99
"bugs": "https://github.com/microsoft/botframework-cli",
1010
"engines": {
11-
"node": ">=8.0.0 <14"
11+
"node": ">=14.0.0"
1212
},
1313
"files": [
1414
"/bin",

packages/lu/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@
88
node_modules
99
**/.antlr
1010
**/java_generated
11+
src/parser/lufile/generated/* linguist-generated=true
1112

1213
results

packages/lu/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"main": "lib/parser/index.js",
77
"browser": "lib/parser/composerindex.js",
88
"engines": {
9-
"node": ">=8.0.0"
9+
"node": ">=14.0.0"
1010
},
1111
"files": [
1212
"/lib",
@@ -34,7 +34,7 @@
3434
},
3535
"dependencies": {
3636
"@types/node-fetch": "~2.5.5",
37-
"antlr4": "~4.8.0",
37+
"antlr4": "4.9.2",
3838
"axios": "~0.21.1",
3939
"https-proxy-agent": "^5.0.0",
4040
"chalk": "2.4.1",

packages/lu/src/parser/lufile/entitySection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const EntitySectionContext = require('./generated/LUFileParser').LUFileParser.EntitySectionContext;
1+
import EntitySectionContext from './generated/LUFileParser.js'
22
const DiagnosticSeverity = require('./diagnostic').DiagnosticSeverity;
33
const BuildDiagnostic = require('./diagnostic').BuildDiagnostic;
44
const LUSectionTypes = require('./../utils/enums/lusectiontypes');

0 commit comments

Comments
 (0)