Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit 6acb191

Browse files
authored
fix lowercase settings issue (#969)
1 parent c063415 commit 6acb191

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/lu/src/parser/lufile/parseFileContents.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1934,14 +1934,14 @@ const parseAndHandleModelInfoSection = function (parsedContent, luResource, log)
19341934
let settingsPair = settingsRegExp.exec(kvPair[2]);
19351935
if (settingsPair && settingsPair.groups && settingsPair.groups.property) {
19361936
if (!parsedContent.LUISJsonStructure.settings) {
1937-
parsedContent.LUISJsonStructure.settings = [{name : settingsPair.groups.property, value : kvPair[3] === "true"}];
1937+
parsedContent.LUISJsonStructure.settings = [{name : settingsPair.groups.property, value : kvPair[3].toLowerCase() === "true"}];
19381938
} else {
19391939
// find the setting
19401940
let sFound = parsedContent.LUISJsonStructure.settings.find(setting => setting.name == settingsPair.groups.property);
19411941
if (sFound) {
19421942
sFound.value = kvPair[3] === "true";
19431943
} else {
1944-
parsedContent.LUISJsonStructure.settings.push({name : settingsPair.groups.property, value : kvPair[3] === "true"})
1944+
parsedContent.LUISJsonStructure.settings.push({name : settingsPair.groups.property, value : kvPair[3].toLowerCase() === "true"})
19451945
}
19461946
}
19471947
}

packages/lu/test/parser/lufile/appKbMetaData.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ describe('App/ Kb meta data information', function () {
8787
it ('Settings information is parsed correctly', function(done){
8888
let testLU = `
8989
> !# @app.settings.NormalizeDiacritics = true
90-
> !# @app.settings.NormalizePunctuation = false
90+
> !# @app.settings.NormalizePunctuation = True
9191
> !# @app.settings.UseAllTrainingData = true
9292
9393
# test
@@ -97,7 +97,7 @@ describe('App/ Kb meta data information', function () {
9797
.then(res => {
9898
assert.equal(res.LUISJsonStructure.settings.length, 3);
9999
assert.equal(res.LUISJsonStructure.settings[1].name, "NormalizePunctuation")
100-
assert.equal(res.LUISJsonStructure.settings[1].value, false)
100+
assert.equal(res.LUISJsonStructure.settings[1].value, true)
101101
done();
102102
})
103103
.catch(err => done(err))

0 commit comments

Comments
 (0)