Fixing default for QnA to be .qna

Author: Vishwac Sena Kannan

packages/luis/src/commands/luis/translate.ts

@@ -18,8 +18,8 @@ export default class LuisTranslate extends Command {
     srclang: flags.string({description: 'Source lang code. Auto detect if missing.'}),
     tgtlang: flags.string({description: 'Comma separated list of target languages.', required: true}),
     translatekey: flags.string({description: 'Machine translation endpoint key.', required: true}),
-    translate_comments: flags.string({description: 'When set, machine translate comments found in .lu or .qna file'}),
-    translate_link_text: flags.string({description: 'When set, machine translate link description in .lu or .qna file'}),
+    translate_comments: flags.string({description: 'When set, machine translate comments found in .lu file'}),
+    translate_link_text: flags.string({description: 'When set, machine translate link description in .lu file'}),
   }
 
   /* tslint:disable:forin no-for-in*/

packages/luis/src/commands/qnamaker/convert.ts

@@ -13,7 +13,7 @@ export default class QnamakerConvert extends Command {
     in: flags.string({description: 'Source .qna file(s) or QnA KB JSON file', required: true}),
     alterations: flags.boolean({description: 'Indicates if files is QnA Alterations'}),
     log: flags.boolean({description: 'Enables log messages', default: false}),
-    sort: flags.boolean({description: 'When set, questions collections are alphabetically sorted are alphabetically sorted in .lu files', default: false}),
+    sort: flags.boolean({description: 'When set, questions collections are alphabetically sorted are alphabetically sorted in .qna files', default: false}),
     recurse: flags.boolean({description: 'Indicates if sub-folders need to be considered to file .qna file(s)'}),
     out: flags.string({description: 'Output file or folder name. If not specified stdout will be used as output'}),
     name: flags.string({description: 'Name of the QnA KB'}),
@@ -70,12 +70,12 @@ export default class QnamakerConvert extends Command {
   }
 
   private async writeOutput(convertedObject: any, flags: any, isQnA: boolean) {
-    let filePath = await file.generateNewFilePath(flags.out, flags.in, isQnA)
+    let filePath = await file.generateNewFilePath(flags.out, flags.in, isQnA, '', fileExtEnum.QnAFile)
     try {
       if (isQnA) {
         await fs.writeFile(filePath, JSON.stringify(convertedObject.finalQnAJSON, null, 2), 'utf-8')
         if (convertedObject.finalQnAAlterations) {
-          let filePathAlterations = await file.generateNewFilePath(flags.out, flags.in, isQnA, 'alterations_')
+          let filePathAlterations = await file.generateNewFilePath(flags.out, flags.in, isQnA, 'alterations_', fileExtEnum.QnAFile)
           await fs.writeFile(filePathAlterations, JSON.stringify(convertedObject.finalQnAAlterations, null, 2), 'utf-8')
         }
       } else {

packages/luis/src/commands/qnamaker/translate.ts

@@ -9,17 +9,17 @@ const luConverter = require('./../../parser/lufile/parseFileContents')
 const fileExtEnum = require('./../../parser/lufile/helpers').FileExtTypeEnum
 
 export default class QnamakerTranslate extends Command {
-  static description = 'Translate given LUIS application JSON model or lu file(s)'
+  static description = 'Translate given QnA maker application JSON model or qna file(s)'
 
   static flags: flags.Input<any> = {
-    in: flags.string({description: 'Source .lu file(s) or LUIS application JSON model', required: true}),
-    recurse: flags.boolean({description: 'Indicates if sub-folders need to be considered to file .lu file(s)'}),
+    in: flags.string({description: 'Source .qna file(s) or QnA maker application JSON model', required: true}),
+    recurse: flags.boolean({description: 'Indicates if sub-folders need to be considered to find .qna file(s)'}),
     out: flags.string({description: 'Output folder name. If not specified stdout will be used as output'}),
     srclang: flags.string({description: 'Source lang code. Auto detect if missing.'}),
     tgtlang: flags.string({description: 'Comma separated list of target languages.', required: true}),
     translatekey: flags.string({description: 'Machine translation endpoint key.', required: true}),
-    translate_comments: flags.string({description: 'When set, machine translate comments found in .lu or .qna file'}),
-    translate_link_text: flags.string({description: 'When set, machine translate link description in .lu or .qna file'}),
+    translate_comments: flags.string({description: 'When set, machine translate comments found in .qna file'}),
+    translate_link_text: flags.string({description: 'When set, machine translate link description in .qna file'}),
   }
 
   /* tslint:disable:forin no-for-in*/

packages/luis/src/utils/filehelper.ts

@@ -58,7 +58,7 @@ export async function getContentFromFile(file: string) {
   return fileContent
 }
 
-export async function generateNewFilePath(outFileName: string, inputfile: string, isLu: boolean, prefix = ''): Promise<string> {
+export async function generateNewFilePath(outFileName: string, inputfile: string, isLu: boolean, prefix = '', extType: string = helpers.FileExtTypeEnum.LUFile): Promise<string> {
   let base = path.resolve(outFileName)
   let extension = path.extname(base)
   if (extension) {
@@ -70,9 +70,9 @@ export async function generateNewFilePath(outFileName: string, inputfile: string
   let name = ''
   let inputStat = await fs.stat(inputfile)
   if (inputStat.isFile()) {
-    name += path.basename(inputfile, path.extname(inputfile)) + (isLu ? '.json' : '.lu')
+    name += path.basename(inputfile, path.extname(inputfile)) + (isLu ? '.json' : extType)
   } else {
-    name += isLu ? 'converted.json' : 'converted.lu'
+    name += isLu ? 'converted.json' : `converted.${extType}`
   }
   return path.join(base, prefix + name)
 }