Fix entity type case sensitive issue and class definition typo issue (#1091)

* support output to file for kb:export command

* fix entity type case sensitive issue and a typo

Author: feich-ms

packages/lu/src/parser/lu/luMerger.js

@@ -144,7 +144,7 @@ const resolveRefs = function(refTree, srcId) {
             if (result.utterances !== undefined) {
                 result.utterances.forEach(utt => {
                     if (luObj.uttHash[utt] === undefined) {
-                        luObj.utterances.push(new hClasses.uttereances(utt, ref.uttObj.intent));
+                        luObj.utterances.push(new hClasses.utterances(utt, ref.uttObj.intent));
                         luObj.uttHash[utt] = '';
                     }
                 })

packages/lu/src/parser/lufile/classes/hclasses.js

@@ -23,7 +23,7 @@ const readerObj = {
             this.utterances = utterances?utterances:[]
         }
     }, 
-    uttereances: class {
+    utterances: class {
         constructor(text, intent, entities) {
             this.text = text?text:'';
             this.intent = intent?intent:''; 

packages/lu/src/parser/lufile/newEntitySection.js

@@ -54,7 +54,7 @@ class NewEntitySection  extends BaseSection {
 
     ExtractType(parseTree) {
         if (parseTree.newEntityDefinition().newEntityLine().newEntityType()) {
-            return parseTree.newEntityDefinition().newEntityLine().newEntityType().getText().trim();
+            return parseTree.newEntityDefinition().newEntityLine().newEntityType().getText().trim().toLowerCase();
         }
     }
 

packages/lu/src/parser/lufile/parseFileContents.js

@@ -1152,7 +1152,7 @@ const parseAndHandleSimpleIntentSection = function (parsedContent, luResource, c
                         if (hashTable[uttHash]) {
                             utteranceObject = hashTable[uttHash];
                         } else {
-                            utteranceObject = new helperClass.uttereances(utterance, intentName, []);
+                            utteranceObject = new helperClass.utterances(utterance, intentName, []);
                             parsedContent.LUISJsonStructure.utterances.push(utteranceObject);
                             hashTable[uttHash] = utteranceObject;
                         }
@@ -1230,7 +1230,7 @@ const parseAndHandleSimpleIntentSection = function (parsedContent, luResource, c
                         }
                     } else {
                         if(!hashTable[uttHash]) {
-                            let utteranceObject = new helperClass.uttereances(utterance, intentName, []);
+                            let utteranceObject = new helperClass.utterances(utterance, intentName, []);
                             parsedContent.LUISJsonStructure.utterances.push(utteranceObject);
                             hashTable[uttHash] = utteranceObject;
                         }

packages/lu/src/parser/luis/luConverter.js

@@ -498,7 +498,7 @@ const addUtteranceToCollection = function (attribute, srcItem, matchInTarget) {
     if(attribute === 'text') {
         matchInTarget.utterances.push(srcItem); 
     } else {
-        matchInTarget.utterances.push(new helperClasses.uttereances(srcItem.pattern.replace('{', '{@'),srcItem.intent,[]));
+        matchInTarget.utterances.push(new helperClasses.utterances(srcItem.pattern.replace('{', '{@'),srcItem.intent,[]));
     }
 }
 

packages/lu/test/parser/lufile/classes/classes.test.js

@@ -102,9 +102,9 @@ describe('Testing all classes', function() {
         });
     });
 
-    describe('uttereances class', function() {
+    describe('utterances class', function() {
         it('can create a new instance with no values passed in', function() {
-            assert.equal(new hClasses.uttereances().text, '');
+            assert.equal(new hClasses.utterances().text, '');
         });
     });
 

packages/lu/test/parser/lufile/parseFileContents.parseFile.test.js

@@ -1090,4 +1090,26 @@ describe('parseFile correctly parses utterances', function () {
                         })
                         .catch(err => done(err))
         })
+
+        it ('Correctly parses entity type that is case insensitive', function(done){
+            let testLU = `
+                @ ML test
+                @ PREbuilt personName
+                @ phraseList abc(interchangeable) disabledforallmodels = 
+                    - a, b, c`;
+            parseFile.parseFile(testLU)
+                .then(res => {
+                    assert.equal(res.LUISJsonStructure.entities.length, 1);
+                    assert.equal(res.LUISJsonStructure.entities[0].name, "test");
+                    assert.equal(res.LUISJsonStructure.prebuiltEntities.length, 1);
+                    assert.equal(res.LUISJsonStructure.prebuiltEntities[0].name, "personName");
+                    assert.equal(res.LUISJsonStructure.model_features[0].enabledForAllModels, false);
+                    assert.equal(res.LUISJsonStructure.model_features.length, 1);
+                    assert.equal(res.LUISJsonStructure.model_features[0].name, "abc");
+                    assert.equal(res.LUISJsonStructure.model_features[0].words, "a,b,c");
+                    assert.equal(res.LUISJsonStructure.model_features[0].enabledForAllModels, false);
+                    done();
+                })
+                .catch(err => done(err))
+        })
 })