Formatting publish response json (#419)

* Formatting publish response json

* Remove success message from query cmd

* Convert --staging flag from string to boolean

* Rename variable

Author: JSpru

packages/luis/src/commands/luis/application/publish.ts

@@ -20,8 +20,8 @@ export default class LuisApplicationPublish extends Command {
     subscriptionKey: flags.string({description: 'LUIS cognitive services subscription key (mandatory, default: config:LUIS:subscriptionKey)'}),
     appId: flags.string({description: 'LUIS application Id (mandatory, defaults to config:LUIS:appId)'}),
     versionId: flags.string({description: 'Version to publish (mandatory, defaults to config:LUIS:versionId)'}),
-    staging: flags.string({description: 'Publishes application version to Staging slot, otherwise publish to production (default: false)'}),
-    direct: flags.string({description: 'Available only in direct version query. Do not publish to staging or production (default: false)'})
+    staging: flags.boolean({description: 'Publishes application version to Staging slot, otherwise publish to production (default: false)'}),
+    direct: flags.boolean({description: 'Available only in direct version query. Do not publish to staging or production (default: false)'})
   }
 
   async run() {
@@ -43,15 +43,15 @@ export default class LuisApplicationPublish extends Command {
 
     const client = utils.getLUISClient(subscriptionKey, endpoint)
 
-    const applicationCreateObject = {
+    const applicationPublishObject = {
       versionId,
-      isStaging: (staging === 'true'),
-      directVersionPublish: (direct === 'true')
+      isStaging: staging,
+      directVersionPublish: direct
     }
 
     try {
-      const publishedAppData = await client.apps.publish(appId, applicationCreateObject)
-      this.log(`App successfully published.\n${JSON.stringify(publishedAppData)}`)
+      const publishedAppData = await client.apps.publish(appId, applicationPublishObject)
+      this.log(`${JSON.stringify(publishedAppData, null, 2)}`)
     } catch (err) {
       throw new CLIError(`Failed to publish app: ${err}`)
     }

packages/luis/src/commands/luis/application/query.ts

@@ -71,7 +71,7 @@ export default class LuisApplicationQuery extends Command {
 
     try {
       const predictionData = await client.predictionOperations.getSlotPrediction(appId, slotName, predictionRequest, options)
-      this.log(`Successfully fetched prediction data ${JSON.stringify(predictionData, null, 2)}.`)
+      this.log(`${JSON.stringify(predictionData, null, 2)}`)
     } catch (err) {
       throw new CLIError(`Failed to fetch prediction data: ${err}`)
     }

packages/luis/test/commands/luis/application/publish.test.ts

@@ -60,7 +60,7 @@ describe('luis:application:publish', () => {
   .reply(201, {"versionId":"0.1","isStaging":true,"endpointUrl":"https://westus.api.cognitive.microsoft.com/luis/v2.0/apps/4e3d6aec-f79e-4688-b686-feaf6dc2feee","region":"westus","endpointRegion":"westus","failedRegions":"","publishedDateTime":"2019-11-21T21:54:30Z"})
   )
   .stdout()
-  .command(['luis:application:publish', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--appId', uuidv1(), '--subscriptionKey', uuidv1(), '--versionId', '0.01', '--staging', 'true', '--direct', 'false' ])
+  .command(['luis:application:publish', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--appId', uuidv1(), '--subscriptionKey', uuidv1(), '--versionId', '0.01', '--direct', '--staging' ])
   .it('publishes a luis app with optional flags and displays the published app data', ctx => {
     expect(ctx.stdout).to.contain('versionId')
     expect(ctx.stdout).to.contain('isStaging')

packages/luis/test/commands/luis/application/query.test.ts

@@ -55,7 +55,6 @@ describe('luis:application:query', () => {
   .stderr()
   .command(['luis:application:query', '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--appId', uuidv1(), '--subscriptionKey', uuidv1(), '--staging', '--query', 'test query'])
   .it('queries an application for intent predictions and displays the results', ctx => {
-    expect(ctx.stdout).to.contain('Successfully fetched prediction data')
     expect(ctx.stdout).to.contain('test intent')
   })