Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit 968ef75

Browse files
author
Shuai Wang
authored
filtering output files from luis:cross-train when encounter Composer generated source luis and qna files (#1227)
* filter composer generate source lu and qna file * fix tslint error
1 parent c0be653 commit 968ef75

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/luis/src/commands/luis/cross-train.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,10 @@ export default class LuisCrossTrain extends Command {
8888
validatedPath = utils.validatePath(fileId + fileExt, '', force)
8989
}
9090

91-
await fs.writeFile(validatedPath, fileIdToLuResourceMap.get(fileId).Content, 'utf-8')
91+
const composerSourceFileRegex = new RegExp(`[\\w-]+\\.source\\.([\\w-]+\\.)?${fileExt.substring(1)}`)
92+
if (!composerSourceFileRegex.test(validatedPath)) {
93+
await fs.writeFile(validatedPath, fileIdToLuResourceMap.get(fileId).Content, 'utf-8')
94+
}
9295
} catch (err) {
9396
throw new CLIError(`Unable to write to file ${fileId}. Error: ${err.message}`)
9497
}

packages/luis/test/commands/luis/crossTrain.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,5 +173,6 @@ describe('luis:cross-train tests for lu and qna contents', () => {
173173
expect(await compareLuFiles('./../../../interruptionGen/ChitchatDialog.en-us.lu', './../../fixtures/verified/interruption9/ChitchatDialog.en-us.lu')).to.be.true
174174
expect(await compareLuFiles('./../../../interruptionGen/ChitchatDialog.en-us.qna', './../../fixtures/verified/interruption9/ChitchatDialog.en-us.qna')).to.be.true
175175
expect(fs.existsSync('./../../../interruptionGen/extra.en-us.lu')).to.be.false
176+
expect(fs.existsSync('./../../../interruptionGen/chitchat_professional.source.en-us.qna')).to.be.false
176177
})
177178
})

0 commit comments

Comments
 (0)