Create bf luis plugin (#349)

* bf-luis-cli plugin initial commit

* Adding clone cmd

* Deleting files

* Get values from config if not present in flags

* Add unit tests with HTTP mock

* Lint fixes

* Update readme

* Move endpoint monkey patch into shared utils file so we only have to remove it once later

* Convert utils filte to TS, lint fixes, read config dir refactor

* Regenerate readme

* Eliminate redundant var

* Lint fix

* Remove duplicate content from readme

* Update readme

* Remove outer try catch

* Move input processing into utils file, add config filter and reducer

* Only filter config if config

* Update test mock to reflect input processing change

* Remove space

Author: JSpru

packages/luis/src/commands/luis/version/clone.ts

@@ -26,12 +26,9 @@ export default class LuisVersionClone extends Command {
   async run() {
     const {flags} = this.parse(LuisVersionClone)
     const configDir = this.config.configDir
+    const configPrefix = 'luis__'
 
-    const appId = flags.appId || await utils.getPropFromConfig('appId', configDir)
-    const endpoint = flags.endpoint || await utils.getPropFromConfig('endpoint', configDir)
-    const subscriptionKey = flags.subscriptionKey || await utils.getPropFromConfig('subscriptionKey', configDir)
-    const versionId = flags.versionId || await utils.getPropFromConfig('versionId', configDir)
-    const targetVersionId = flags.targetVersionId || await utils.getPropFromConfig('targetVersionId', configDir)
+    const {appId, endpoint, subscriptionKey, versionId, targetVersionId} = await utils.processInputs(flags, configDir, configPrefix)
 
     const requiredProps = {appId, endpoint, subscriptionKey, versionId, targetVersionId}
     utils.validateRequiredProps(requiredProps)

packages/luis/src/utils/index.ts

@@ -1,4 +1,3 @@
-
 /*!
  * Copyright (c) Microsoft Corporation. All rights reserved.
  * Licensed under the MIT License.
@@ -10,6 +9,15 @@ const fs = require('fs-extra')
 const msRest = require('ms-rest')
 const {LUISAuthoringClient} = require('azure-cognitiveservices-luis-authoring')
 
+const filterConfig = (config: any, prefix: string) => {
+  return Object.keys(config)
+    .filter((key: string) => key.startsWith(prefix))
+    .reduce((filteredConfig: any, key: string) => {
+      filteredConfig[key] = config[key]
+      return filteredConfig
+    }, {})
+}
+
 const getUserConfig = async (configPath: string) => {
   if (fs.existsSync(path.join(configPath, 'config.json'))) {
     return fs.readJSON(path.join(configPath, 'config.json'), {throws: false})
@@ -35,6 +43,19 @@ const getPropFromConfig = async (prop: string, configDir: string) => {
   }
 }
 
+const processInputs = async (flags: any, configDir: string, prefix: string) => {
+  let config = await getUserConfig(configDir)
+  config = config ? filterConfig(config, prefix) : config
+  const input = {
+    appId: flags.appId || (config ? config.luis__appId : null),
+    endpoint: flags.endpoint || (config ? config.luis__endpoint : null),
+    subscriptionKey: flags.subscriptionKey || (config ? config.luis__subscriptionKey : null),
+    versionId: flags.versionId || (config ? config.luis__versionId : null),
+    targetVersionId: flags.targetVersionId || (config ? config.luis__targetVersionId : null)
+  }
+  return input
+}
+
 const validateRequiredProps = (configObj: any) => {
   Object.keys(configObj).forEach(key => {
     if (!configObj[key]) {
@@ -44,5 +65,7 @@ const validateRequiredProps = (configObj: any) => {
 }
 
 module.exports.getLUISClient = getLUISClient
+module.exports.getUserConfig = getUserConfig
 module.exports.getPropFromConfig = getPropFromConfig
+module.exports.processInputs = processInputs
 module.exports.validateRequiredProps = validateRequiredProps

packages/luis/test/commands/luis/version/clone.test.ts

@@ -6,7 +6,7 @@ const utils = require('../../../../src/utils/index')
 describe('luis:version:clone', () => {
 
   beforeEach(() => {
-    sinon.stub(utils, 'getPropFromConfig').callsFake(() => null)
+    sinon.stub(utils, 'processInputs').returnsArg(0)
   })
 
   afterEach(() => {