Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit be92c6f

Browse files
committed
Stopping timer to stdin, handling wrong input in lu
1 parent 13314f9 commit be92c6f

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

packages/command/src/readpipeddata.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ const ReadPipedStdin = {
1010
}
1111

1212
const timer = setTimeout(async () => {
13+
clearTimeout(timer)
14+
if (input) return resolve(input)
1315
reject(new Error('No input'))
1416
}, 1000)
1517

packages/lu/src/commands/luis/translate.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,9 @@ export default class LuisTranslate extends Command {
2828
const {flags} = this.parse(LuisTranslate)
2929
// Check if data piped in stdin
3030
let stdin = await this.readStdin()
31-
let outputStat = flags.out ? await fs.stat(flags.out) : null
32-
33-
if (outputStat && outputStat.isFile()) {
34-
throw new CLIError('Output can only be writen to a folder')
35-
}
36-
3731
let isLu = await fileHelper.detectLuContent(stdin, flags.in)
3832
let result: any
33+
3934
if (isLu) {
4035
let luFiles = await fileHelper.getLuObjects(stdin, flags.in, flags.recurse, fileExtEnum.LUFile)
4136
result = await luTranslator.translateLuList(luFiles, flags.translatekey, flags.tgtlang, flags.srclang, flags.translate_comments, flags.translate_link_text)

packages/lu/src/commands/qnamaker/translate.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ export default class QnamakerTranslate extends Command {
2828
const {flags} = this.parse(QnamakerTranslate)
2929
// Check if data piped in stdin
3030
let stdin = await this.readStdin()
31-
let outputStat = flags.out ? await fs.stat(flags.out) : null
32-
33-
if (outputStat && outputStat.isFile()) {
34-
throw new CLIError('Output can only be writen to a folder')
35-
}
3631

3732
let isLu = await fileHelper.detectLuContent(stdin, flags.in)
3833
let result: any

packages/lu/src/utils/filehelper.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,16 @@ export async function generateNewFilePath(outFileName: string, inputfile: string
8282

8383
export async function generateNewTranslatedFilePath(fileName: string, translatedLanguage: string, output: string): Promise<string> {
8484
let newPath = path.resolve(output)
85+
86+
let extension = path.extname(newPath)
87+
if (extension) {
88+
throw new CLIError('Output can only be writen to a folder')
89+
}
90+
8591
if (!fs.existsSync(newPath)) {
8692
throw new CLIError('Path not found: ' + newPath)
8793
}
94+
8895
newPath = path.join(output, translatedLanguage)
8996
await fs.mkdirp(newPath)
9097
return path.join(newPath, fileName)

0 commit comments

Comments
 (0)