Adding mode flag to train command (#1113)

* Adding mode flag to train command

* Checking for error object

* Applying PR feedback

Author: munozemilio

packages/luis/src/api/http-request.ts

@@ -78,7 +78,8 @@ const httpRequest = async function (subscriptionKey: string, config: any) {
     if (error.response) {
       // The request was made and the server responded with a status code
       // that falls out of the range of 2xx
-      throw Error(error.response.statusText)
+      let message = error?.response?.data?.error?.message ?? ''
+      throw Error(`Code: ${error.response.statusText} ${message}`)
     } else {
       // Something happened in setting up the request that triggered an Error
       throw Error(error.message)

packages/luis/src/api/train.ts

@@ -6,9 +6,12 @@ const urlPath = '/luis/authoring/v3.0-preview/apps'
 export default {
   async train(
     param: EndpointParameters,
-    versionId: string) {
+    versionId: string,
+    mode: string) {
     let url = buildUrl(param.endpoint) + `/${param.appId}/versions/${versionId}/train`
-
+    if (mode) {
+      url += `?mode=${mode}`
+    }
     return http.post(url, param.subscriptionKey, {})
   },
 

packages/luis/src/commands/luis/train/run.ts

@@ -22,6 +22,7 @@ export default class LuisTrainRun extends Command {
     subscriptionKey: flags.string({description: '(required) LUIS cognitive services subscription key (default: config:LUIS:subscriptionKey)'}),
     appId: flags.string({description: '(required) LUIS application Id (defaults to config:LUIS:appId)'}),
     versionId: flags.string({description: '(required) Version to show training status (defaults to config:LUIS:versionId)'}),
+    mode: flags.string({description: 'Value specifying mode of training (Standard | Neural).'}),
     wait: flags.boolean({description: 'Wait until training complete and then display status'}),
     json: flags.boolean({description: 'Display output as JSON'}),
   }
@@ -37,7 +38,7 @@ export default class LuisTrainRun extends Command {
     utils.validateRequiredProps(requiredProps)
 
     try {
-      const trainingRequestStatus = await Train.train({subscriptionKey, endpoint, appId}, versionId)
+      const trainingRequestStatus = await Train.train({subscriptionKey, endpoint, appId}, versionId, flags.mode)
       if (trainingRequestStatus) {
         await utils.writeToConsole(trainingRequestStatus)
         const output = flags.json ? JSON.stringify({Status: 'Success'}, null, 2) : '\nTraining request successfully issued'
@@ -52,7 +53,7 @@ export default class LuisTrainRun extends Command {
         return this.checkTrainingStatus({subscriptionKey, endpoint, appId}, versionId, flags.json)
       }
     } catch (err) {
-      throw new CLIError(`Failed to issue training request: ${err}`)
+      throw new CLIError(`Failed to issue training request: ${err.message}`)
     }
   }
 

packages/luis/test/commands/luis/train/run.test.ts

@@ -53,4 +53,15 @@ describe('luis:train:run', () => {
     expect(ctx.stdout).to.contain('checking training status...')
   })
 
+  test
+  .nock('https://westus.api.cognitive.microsoft.com', api => api
+  .post(uri => uri.includes('train?mode=Standard'))
+  .reply(202, {"statusId": 2,"status": "UpToDate"})
+  )
+  .stdout()
+  .command(['luis:train:run', '--appId', uuidv1(), '--versionId', '0.1', '--subscriptionKey', uuidv1(), '--endpoint', 'https://westus.api.cognitive.microsoft.com', '--mode', 'Standard'])
+  .it('issues an asynchronous training request and reports when complete using trainning mode Standard', ctx => {
+    expect(ctx.stdout).to.contain('Training request successfully issued')
+  })
+
 })