fix lu build bug when training empty intents (#643)

* fix lu build bug when training empty intents

* change warning message test

Author: feich-ms

packages/lu/src/parser/lubuild/builder.ts

@@ -258,6 +258,9 @@ export class Builder {
       currentApp.name = `${botName}(${suffix})-${content.name}`
     }
 
+    // remove empty intents from current app to avoid fewLabels error when training
+    this.filterEmptyIntents(currentApp)
+
     return currentApp
   }
 
@@ -352,4 +355,19 @@ export class Builder {
 
     return new Content(settings.save(), new LUOptions(path.basename(settings.getSettingsPath()), true, '', settings.getSettingsPath()))
   }
+
+  filterEmptyIntents(app: any) {
+    const intents = app.intents
+    const utterances = app.utterances
+    const patterns = app.patterns
+
+    const emptyIntents = intents.filter((intent: any) => !utterances.some((utterance: any) => utterance.intent === intent.name)
+      && !patterns.some((pattern: any) => pattern.intent === intent.name))
+
+    if (emptyIntents && emptyIntents.length > 0) {
+      const filteredIntents = intents.filter((intent: any) => !emptyIntents.some((emptyIntent: any) => emptyIntent.name === intent.name))
+      this.handler(`[WARN]: empty intent(s) ${emptyIntents.map((intent: any) => '# ' + intent.name).join(', ')} are filtered when handling luis application`)
+      app.intents = filteredIntents
+    }
+  }
 }

packages/lu/src/parser/lufile/parseFileContents.js

@@ -1800,7 +1800,11 @@ const parseAndHandleModelInfoSection = function (parsedContent, luResource, log)
     if (modelInfos && modelInfos.length > 0) {
         for (const modelInfo of modelInfos) {
             let line = modelInfo.ModelInfo
-            let kvPair = line.split(/@(app|kb|intent|entity|enableMergeIntents|patternAnyEntity).(.*)=/g).map(item => item.trim());
+            let kvPair = line.split(/@(app|kb|intent|entity|enableSections|enableMergeIntents|patternAnyEntity).(.*)=/g).map(item => item.trim());
+            
+            // avoid to throw invalid model info when meeting enableSections info which is handled in luParser.js
+            if (kvPair[1] === 'enableSections') continue
+
             if (kvPair.length === 4) {
                 if (kvPair[1] === 'enableMergeIntents' && kvPair[3] === 'false') {
                     enableMergeIntents = false;

packages/luis/test/commands/luis/build.test.ts

@@ -549,6 +549,8 @@ describe('luis:build update dialog assets successfully when dialog assets exist'
       expect(ctx.stdout).to.contain('foo.en-us.lu.dialog loaded')
       expect(ctx.stdout).to.contain('foo.fr-fr.lu.dialog loaded')
 
+      expect(ctx.stdout).to.contain('[WARN]: empty intent(s) # emptyIntent are filtered when handling luis application')
+
       expect(ctx.stdout).to.contain('Creating LUIS.ai application')
       expect(ctx.stdout).to.contain('training version=0.1')
       expect(ctx.stdout).to.contain('waiting for training for version=0.1')

packages/luis/test/fixtures/testcases/lubuild/foo2/lufiles-and-dialog-assets/foo.lu

@@ -2,4 +2,6 @@
 - hey carlos!
 - yo carlos!
 - hello
-- hi
+- hi
+
+# emptyIntent