Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit e06f70f

Browse files
author
Chris McConnell
authored
Lowercase package names (#1073)
* Lowercase package names Mac/linux dotnet lowercases all package names. * Address review feedback. Co-authored-by: Chris McConnell <chrimc>
1 parent a2ab9dd commit e06f70f

File tree

3 files changed

+32
-14
lines changed

3 files changed

+32
-14
lines changed

.vscode/launch.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,9 @@
209209
"outFiles": ["./packages/dialog/lib/**"],
210210
"args": [
211211
"dialog:merge",
212-
"runbot.csproj",
212+
"RunBot.csproj",
213213
"-o",
214-
"runbot.schema",
214+
"RunBot.schema",
215215
"--verbose"
216216
],
217217
"internalConsoleOptions": "openOnSessionStart",

common/config/rush/pnpm-lock.yaml

Lines changed: 27 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/dialog/src/library/schemaMerger.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1056,8 +1056,10 @@ export class SchemaMerger {
10561056

10571057
// Expand nuget package and all of its dependencies
10581058
private async expandNuget(packageName: string, minVersion: string): Promise<void> {
1059+
// Linux/Mac are case sensitive and nuget/dotnet lowercase package names
1060+
packageName = packageName.toLowerCase()
10591061
let pkgPath = ppath.join(this.nugetRoot, packageName)
1060-
if (!this.packages.has(pkgPath) && !packageName.startsWith('System')) {
1062+
if (!this.packages.has(pkgPath) && !packageName.startsWith('system')) {
10611063
try {
10621064
this.currentFile = pkgPath
10631065
this.packages.add(pkgPath)

0 commit comments

Comments
 (0)