Fixing stdin input reading

Author: munozemilio

packages/command/src/readpipeddata.ts

@@ -10,12 +10,11 @@ const ReadPipedStdin = {
       }
 
       const timer = setTimeout(async () => {
-        clearTimeout(timer)
-        if (input) return resolve(input)
         reject(new Error('No input'))
       }, 1000)
 
       stdin.on('data', chunk => {
+        clearTimeout(timer)
         input += chunk
       })
 

packages/command/test/command.test.ts

@@ -95,20 +95,6 @@ describe('command', () => {
   .do(output => expect(output.stderr).to.equal(''))
   .it('Command should return empty string if no stdin')
 
-  fancy
-  .stdin('test reading of piped data')
-  .stdout()
-  .do(async () => {
-    try {
-      const resp: any = await ReadPipedStdin.read()
-      if (resp) console.log(resp)
-    } catch (error) {
-      if (error) console.log(`Error: ${error}`)
-    }
-  })
-  .do(output => expect(output.stdout).to.equal('test reading of piped data\n'))
-  .it('should read and echo the stdin input')
-
   fancy
   .stdin('')
   .stdout()

packages/lu/package.json

@@ -63,5 +63,10 @@
     "prepack": "rm -rf lib && tsc -b && oclif-dev manifest && oclif-dev readme",
     "test": "nyc --extension .ts mocha --forbid-only \"test/**/*.test.**\"",
     "version": "oclif-dev readme && git add README.md"
+  },
+  "nyc": {
+    "exclude": [
+      "**/lufile/generated/**"
+    ]
   }
 }

packages/lu/src/commands/luis/convert.ts

@@ -77,7 +77,6 @@ export default class LuisConvert extends Command {
     // write out the final file
     try {
       await fs.writeFile(filePath, convertedObject, 'utf-8')
-
     } catch (err) {
       throw new CLIError('Unable to write file - ' + filePath + ' Error: ' + err.message)
     }

packages/lu/src/utils/filehelper.ts

@@ -60,11 +60,14 @@ export async function getContentFromFile(file: string) {
 
 export async function generateNewFilePath(outFileName: string, inputfile: string, isLu: boolean, prefix = '', extType: string = helpers.FileExtTypeEnum.LUFile): Promise<string> {
   let base = path.resolve(outFileName)
+  let root = path.dirname(base)
+  if (!fs.existsSync(root)) {
+    throw new CLIError('Path not found: ' + root)
+  }
+
   let extension = path.extname(base)
   if (extension) {
-    let root = path.dirname(base)
-    let file = path.basename(base)
-    return path.join(root, prefix + file)
+    return path.join(root, prefix + path.basename(base))
   }
 
   let name = ''
@@ -79,6 +82,9 @@ export async function generateNewFilePath(outFileName: string, inputfile: string
 
 export async function generateNewTranslatedFilePath(fileName: string, translatedLanguage: string, output: string): Promise<string> {
   let newPath = path.resolve(output)
+  if (!fs.existsSync(newPath)) {
+    throw new CLIError('Path not found: ' + newPath)
+  }
   newPath = path.join(output, translatedLanguage)
   await fs.mkdirp(newPath)
   return path.join(newPath, fileName)

packages/lu/test/commands/luis/convert.test.ts

@@ -470,3 +470,12 @@ describe('luis:convert new entity format', () => {
   })
 })
 
+describe('luis:convert file creation', () => {
+  test
+  .stderr()
+  .command(['luis:convert', '--in', `${path.join(__dirname, './../../fixtures/testcases/newEntity1.json')}`, '--out', './newfolder/newEntity.lu'])
+  .it('luis:convert throws error if path to write doesnt exist', async (ctx) => {
+    expect(ctx.stderr).to.contain('Path not found:')
+  })
+})
+

packages/lu/test/commands/qnamaker/convert.test.ts

@@ -102,3 +102,12 @@ describe('qnamaker:convert with --sort option', () => {
     expect(await compareLuFiles('./../../../qna.lu', './../../fixtures/verified/qna_a_sorted.lu')).to.be.true
   })
 })
+
+describe('qnamaker:convert file creation', () => {
+  test
+  .stderr()
+  .command(['qnamaker:convert', '--in', `${path.join(__dirname, './../../fixtures/verified/all-qna.json')}`, '--out', '/testfolder/qna.lu'])
+  .it('qnamaker:convert refresh command successfully reconstructs a markdown file from QnA input file', async (ctx) => {
+    expect(ctx.stderr).to.contain('Path not found:')
+  })
+})