Adding 'convert' cmd and cleaning up transcript files after chatdown … (#262)

* Adding 'convert' cmd and cleaning up transcript files after chatdown unit tests

* Fix urls in readmes

Author: JSpru

packages/chatdown/README.md

@@ -10,6 +10,7 @@ Tool for parsing chat files and outputting replayable activities
 # Commands
 <!-- commands -->
 * [`bf chatdown`](#bf-chatdown)
+* [`bf chatdown:convert`](#bf-chatdownconvert)
 
 ## `bf chatdown`
 
@@ -19,6 +20,20 @@ Converts chat dialog files in <filename>.chat format into transcript file. Write
 USAGE
   $ bf chatdown
 
+OPTIONS
+  -h, --help  Chatdown command help
+```
+
+_See code: [src\commands\chatdown\index.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/chatdown/src/commands/chatdown/index.ts)_
+
+## `bf chatdown:convert`
+
+Converts chat dialog files in <filename>.chat format into transcript file. Writes corresponding <filename>.transcript for each .chat file
+
+```
+USAGE
+  $ bf chatdown:convert
+
 OPTIONS
   -f, --force    If --out flag is provided with the path to an existing file, overwrites that file
   -h, --help     Chatdown command help
@@ -41,5 +56,5 @@ EXAMPLE
      $ (echo user=Joe && [ConversationUpdate=MembersAdded=Joe]) | bf chatdown --static
 ```
 
-_See code: [src/commands/chatdown.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/chatdown/src/commands/chatdown.ts)_
+_See code: [src\commands\chatdown\convert.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/chatdown/src/commands/chatdown/convert.ts)_
 <!-- commandsstop -->

packages/chatdown/cli.transcript

@@ -32,6 +32,7 @@
     "@types/chai": "^4.1.7",
     "@types/mocha": "^5.2.6",
     "@types/node": "^10.14.6",
+    "@types/rimraf": "^2.0.2",
     "chai": "^4.2.0",
     "globby": "^8.0.2",
     "mocha": "^5.2.0",

packages/chatdown/package.json

@@ -6,13 +6,13 @@
 import {flags} from '@oclif/command'
 import {CLIError, Command, utils} from '@microsoft/bf-cli-command'
 const chalk = require('chalk')
-const chatdown = require('../../utils/index')
+const chatdown = require('../../../utils/index')
 const fs = require('fs-extra')
 const glob = require('glob')
 const intercept = require('intercept-stdout')
 const path = require('path')
 
-export default class Chatdown extends Command {
+export default class ChatdownConvert extends Command {
   static description = 'Converts chat dialog files in <filename>.chat format into transcript file. Writes corresponding <filename>.transcript for each .chat file'
 
   static examples = [`
@@ -32,7 +32,7 @@ export default class Chatdown extends Command {
 
   async run() {
     try {
-      const {flags} = this.parse(Chatdown)
+      const {flags} = this.parse(ChatdownConvert)
 
       let inputIsDirectory = flags.in ? (flags.in.includes('*') || this.isDir(flags.in)) : false
 

…ckages/chatdown/src/commands/chatdown.ts …hatdown/src/commands/chatdown/convert.tspackages/chatdown/src/commands/chatdown.ts renamed to packages/chatdown/src/commands/chatdown/convert.ts packages/chatdown/src/commands/chatdown.ts renamed to packages/chatdown/src/commands/chatdown/convert.ts

@@ -0,0 +1,18 @@
+/*!
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License.
+ */
+
+import {Command, flags} from '@microsoft/bf-cli-command'
+
+export default class ChatdownIndex extends Command {
+  static description = 'Converts chat dialog files in <filename>.chat format into transcript file. Writes corresponding <filename>.transcript for each .chat file'
+
+  static flags: flags.Input<any> = {
+    help: flags.help({char: 'h', description: 'Chatdown command help'})
+  }
+
+  async run() {
+    this._help()
+  }
+}

packages/chatdown/src/commands/chatdown/index.ts

@@ -1,10 +1,4 @@
 import {expect, test} from '@oclif/test'
-import * as cp from 'child_process';
-import * as path from 'path';
-
-let pkg = require('../../package.json');
-let assert = require('assert');
-let sv = require('semver');
 
 describe('chatdown', () => {
 
@@ -15,74 +9,4 @@ describe('chatdown', () => {
       expect(ctx.stdout).to.contain('Converts chat dialog files in <filename>.')
     })
 
-    it('should accept data as a pipe and output the results', done => {
-        cp.exec(`(echo user=Joe && echo bot=LuliBot && echo LuliBot: hello! && echo joe:can I get some help?) | node ./bin/run chatdown`, (error, stdout) => {
-            assert.doesNotThrow(() => JSON.parse(stdout));
-            done();
-        });
-    });
-
-    test
-    .stdout()
-    .command(['chatdown'])
-    .it('should print the help contents when no input is passed', ctx => {
-      expect(ctx.stdout).to.contain('Converts chat dialog files in <filename>.')
-    })
-
-    it('should throw when a malformed config options is encountered in the input', done => {
-        cp.exec(`echo bot=LuliBot=joe | node ./bin/run chatdown`, (error, stdout, stderr) => {
-            assert(stderr.trim().indexOf('Malformed configurations options detected. Options must be in the format optionName=optionValue') >= 0);
-            done();
-        });
-    });
-
-    it('should generate static based timestamps when --static is passed as an argument', done => {
-        cp.exec(`(echo user=Joe && [ConversationUpdate=MembersAdded=Joe]) | node ./bin/run chatdown --static`, (error, stdout) => {
-            assert.doesNotThrow(() => JSON.parse(stdout));
-            done();
-        });
-    });
-
-    it('should read from file when chat file is passed as an argument', done => {
-        cp.exec(`node ./bin/run chatdown --in "./test/utils/cli.sample.chat"`, (error, stdout) => {
-            assert.doesNotThrow(() => JSON.parse(stdout));
-            done();
-        });
-    });
-
-    it('should process all files when a glob is passed in with the -i argument, and the -o is passed in for the output directory', done => {
-        cp.exec(`node ./bin/run chatdown -i "./test/utils/*.sample.chat" -o ./`, (error, stdout, stderr) => {
-            assert(stdout.includes('Successfully wrote'));
-            done();
-        });
-    });
-
-    it('should process all files when a glob is passed in with the -i argument', done => {
-        cp.exec(`node ./bin/run chatdown -i "./test/utils/*.sample.chat"`, (error, stdout, stderr) => {
-            assert(stdout.includes('Successfully wrote'));
-            done();
-        });
-    });
-
-    it('should not prefix [chatdown] to stdout when --prefix is not passed as an argument', done => {
-        cp.exec(`echo bot=LuliBot | node ./bin/run chatdown`, (error, stdout, stderr) => {
-            assert.notEqual(stdout.startsWith(`[${pkg.name}]`), `It should not show the tag '[${pkg.name}]' when not using the argument --prefix`);
-            done();
-        });
-    });
-
-    it('should prefix [chatdown] to stderr when --prefix is passed as an argument', done => {
-        cp.exec(`echo bot=LuliBot | node ./bin/run chatdown --prefix`, (error, stdout, stderr) => {
-            assert(stdout.startsWith(`[${pkg.name}]`), `It should show the tag '[${pkg.name}]' when using the argument --prefix`);
-            done();
-        });
-    });
-
-    it('throw error if invalid path in argument', done => {
-        cp.exec(`node ./bin/run chatdown --in 'aaaaa'`, (error, stdout, stderr) => {
-            assert(stderr.includes('no such file or directory') || stderr.includes('error'));
-            done();
-        });
-    });
-
 })