Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Commit 048f9c9

Browse files
authored
Lamil/va bug fix (#492)
* fixed to do skill * fixed intro card localization * fix to support to do tests. Needs to be reevaluated in future
1 parent eeba9a3 commit 048f9c9

File tree

15 files changed

+57
-21
lines changed

15 files changed

+57
-21
lines changed

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/MainResponses.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public MainResponses()
6060

6161
public static IMessageActivity BuildIntroCard(ITurnContext turnContext, dynamic data)
6262
{
63-
var introCard = File.ReadAllText(@".\Dialogs\Main\Resources\Intro.json");
63+
var introCard = File.ReadAllText(MainStrings.INTRO_PATH);
6464
var card = AdaptiveCard.FromJson(introCard).Card;
6565
var attachment = new Attachment(AdaptiveCard.ContentType, content: card);
6666

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/Intro.de.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{
1+
{
22
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
33
"type": "AdaptiveCard",
44
"version": "1.0",
@@ -23,7 +23,7 @@
2323
"type": "TextBlock",
2424
"size": "default",
2525
"isSubtle": true,
26-
"text": "Nun, da Sie Ihren virtuellen Assistenten erfolgreich geführt haben, folgen Sie den Links in dieser adaptiven Karte, um weiter zu erforschen.",
26+
"text": "Nun, da Sie Ihren virtuellen Assistenten erfolgreich geführt haben, folgen Sie den Links in dieser adaptiven Karte, um weiter zu erforschen.",
2727
"speak": "Jetzt, wo Sie loslegen lassen.",
2828
"wrap": true,
2929
"maxLines": 0

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/Intro.es.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
{
1+
{
22
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
33
"type": "AdaptiveCard",
44
"version": "1.0",
5-
"speak": "¡ Bienvenido a tu asistente virtual! Ahora que estás en marcha, empecemos.",
5+
"speak": "¡ Bienvenido a tu asistente virtual! Ahora que estás en marcha, empecemos.",
66
"body": [
77
{
88
"type": "Image",
@@ -23,7 +23,7 @@
2323
"type": "TextBlock",
2424
"size": "default",
2525
"isSubtle": true,
26-
"text": "Ahora que ha ejecutado correctamente su asistente virtual, siga los enlaces de esta tarjeta adaptativa para explorar más.",
26+
"text": "Ahora que ha ejecutado correctamente su asistente virtual, siga los enlaces de esta tarjeta adaptativa para explorar más.",
2727
"speak": "Ahora que su funcionamiento vamos a empezar.",
2828
"wrap": true,
2929
"maxLines": 0
@@ -32,7 +32,7 @@
3232
"actions": [
3333
{
3434
"type": "Action.OpenUrl",
35-
"title": "Documentación",
35+
"title": "Documentación",
3636
"url": "https://aka.ms/customassistantdocs"
3737
},
3838
{

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/Intro.fr.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
{
1+
{
22
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
33
"type": "AdaptiveCard",
44
"version": "1.0",
5-
"speak": "Bienvenue à votre assistant virtuel! Maintenant que vous êtes en marche, commençons.",
5+
"speak": "Bienvenue à votre assistant virtuel! Maintenant que vous êtes en marche, commençons.",
66
"body": [
77
{
88
"type": "Image",
@@ -14,17 +14,17 @@
1414
"spacing": "medium",
1515
"size": "default",
1616
"weight": "bolder",
17-
"text": "Bienvenue à votre assistant virtuel",
18-
"speak": "Bienvenue à votre assistant virtuel",
17+
"text": "Bienvenue à votre assistant virtuel",
18+
"speak": "Bienvenue à votre assistant virtuel",
1919
"wrap": true,
2020
"maxLines": 0
2121
},
2222
{
2323
"type": "TextBlock",
2424
"size": "default",
2525
"isSubtle": true,
26-
"text": "Maintenant que vous avez réussi à exécuter votre assistant virtuel, suivez les liens dans cette carte adaptative pour explorer plus loin.",
27-
"speak": "Maintenant que votre place et en cours d'exécution nous allons commencer.",
26+
"text": "Maintenant que vous avez réussi à exécuter votre assistant virtuel, suivez les liens dans cette carte adaptative pour explorer plus loin.",
27+
"speak": "Maintenant que votre place et en cours d'exécution nous allons commencer.",
2828
"wrap": true,
2929
"maxLines": 0
3030
}
@@ -37,7 +37,7 @@
3737
},
3838
{
3939
"type": "Action.OpenUrl",
40-
"title": "Comptes liés",
40+
"title": "Comptes liés",
4141
"url": "https://github.com/Microsoft/AI/blob/master/solutions/Virtual-Assistant/docs/virtualassistant-linkedaccounts.md"
4242
},
4343
{

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/Intro.it.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{
1+
{
22
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
33
"type": "AdaptiveCard",
44
"version": "1.0",

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/Intro.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{
1+
{
22
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
33
"type": "AdaptiveCard",
44
"version": "1.0",

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/MainStrings.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/MainStrings.de.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@
151151
<data name="Intro" type="System.Resources.ResXFileRef, System.Windows.Forms">
152152
<value>Intro.de.json;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value>
153153
</data>
154+
<data name="INTRO_PATH" xml:space="preserve">
155+
<value>.\Dialogs\Main\Resources\Intro.de.json</value>
156+
</data>
154157
<data name="LOGOUT" xml:space="preserve">
155158
<value>OK, du bist abgemeldet.</value>
156159
</data>

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/MainStrings.es.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@
151151
<data name="Intro" type="System.Resources.ResXFileRef, System.Windows.Forms">
152152
<value>Intro.es.json;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value>
153153
</data>
154+
<data name="INTRO_PATH" xml:space="preserve">
155+
<value>.\Dialogs\Main\Resources\Intro.es.json</value>
156+
</data>
154157
<data name="LOGOUT" xml:space="preserve">
155158
<value>OK, estás desconectado.</value>
156159
</data>

solutions/Virtual-Assistant/src/csharp/assistant/Dialogs/Main/Resources/MainStrings.fr.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@
151151
<data name="Intro" type="System.Resources.ResXFileRef, System.Windows.Forms">
152152
<value>Intro.fr.json;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
153153
</data>
154+
<data name="INTRO_PATH" xml:space="preserve">
155+
<value>.\Dialogs\Main\Resources\Intro.fr.json</value>
156+
</data>
154157
<data name="LOGOUT" xml:space="preserve">
155158
<value>OK, vous êtes déconnecté.</value>
156159
</data>

0 commit comments

Comments
 (0)