[Calendar] Add Exception Handling, Code Refine, Add More Tests (#455)

* refine namespace

* add more tests

* add tests for common tools

* add exception handling

* add timezone converter test

* fix google client error message

* refine and fix stylecop

* fix stylecop

* add exception test in service tests

* add exception test for msgraph service tgest

* add exception handling flow test

* fix stylecop

* fix style cop

* change static to const

Author: ChengxianMo

solutions/Virtual-Assistant/src/csharp/skills/calendarskill/CalendarSkill.cs

@@ -2,12 +2,11 @@
 // Licensed under the MIT License.
 
 using System;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
+using CalendarSkill.ServiceClients;
 using Microsoft.Bot.Builder;
 using Microsoft.Bot.Builder.Dialogs;
-using Microsoft.Bot.Schema;
 using Microsoft.Bot.Solutions.Skills;
 
 namespace CalendarSkill
@@ -22,7 +21,7 @@ public class CalendarSkill : IBot
         private readonly ConversationState _conversationState;
         private readonly IBotTelemetryClient _telemetryClient;
         private readonly IServiceManager _serviceManager;
-        private bool _skillMode;
+        private readonly bool _skillMode;
         private DialogSet _dialogs;
 
         public CalendarSkill(ISkillConfiguration services, ConversationState conversationState, UserState userState, IBotTelemetryClient telemetryClient, IServiceManager serviceManager = null, bool skillMode = false)

solutions/Virtual-Assistant/src/csharp/skills/calendarskill/CalendarSkill.csproj

@@ -145,7 +145,7 @@
     <None Update="Models\Resources\AskParameterTemplate.txt">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Update="ServiceClients\WindowsIanaMapping">
+    <None Update="Common\WindowsIanaMapping">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
   </ItemGroup>
@@ -222,4 +222,8 @@
       <LastGenOutput>CalendarCommonStrings.Designer.cs</LastGenOutput>
     </EmbeddedResource>
   </ItemGroup>
+  
+  <ItemGroup>
+    <Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" />
+  </ItemGroup>
 </Project>

solutions/Virtual-Assistant/src/csharp/skills/calendarskill/CalendarSkillState.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using CalendarSkill.Models;
 using Microsoft.Graph;
 
 namespace CalendarSkill

solutions/Virtual-Assistant/src/csharp/skills/calendarskill/ServiceClients/TimeZoneConverter.cs renamed to solutions/Virtual-Assistant/src/csharp/skills/calendarskill/Common/TimeZoneConverter.cs

@@ -3,7 +3,7 @@
 using System.IO;
 using System.Reflection;
 
-namespace CalendarSkill
+namespace CalendarSkill.Common
 {
     public static class TimeZoneConverter
     {
@@ -35,7 +35,7 @@ public static string WindowsToIana(string windowsTimeZoneId)
         private static void LoadData()
         {
             var dir = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
-            var resDir = Path.Combine(dir, @"ServiceClients\WindowsIanaMapping");
+            var resDir = Path.Combine(dir, @"Common\WindowsIanaMapping");
 
             using (var mappingFile = new FileStream(resDir, FileMode.Open))
             using (var sr = new StreamReader(mappingFile))