Add validation for Skill manifest id special characters (#1333)

David Favretto · darrenj · commit 3fc1e488e3da · 2019-05-09T22:44:49.000-07:00
diff --git a/lib/typescript/botskills/src/functionality/connectSkill.ts b/lib/typescript/botskills/src/functionality/connectSkill.ts
@@ -51,6 +51,9 @@ function validateManifestSchema(skillManifest: ISkillManifest): void {
     }
     if (!skillManifest.id) {
         logger.error(`Missing property 'id' of the manifest`);
+    } else if (skillManifest.id.match(/^\d|[^\w]/g) !== null) {
+        // tslint:disable-next-line:max-line-length
+        logger.error(`The 'id' of the manifest contains some characters not allowed. Make sure the 'id' contains only letters, numbers and underscores, but doesn't start with number.`);
     }
     if (!skillManifest.endpoint) {
         logger.error(`Missing property 'endpoint' of the manifest`);

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ function validateManifestSchema(skillManifest: ISkillManifest): void {`
`51`	`51`	`}`
`52`	`52`	`if (!skillManifest.id) {`
`53`	`53`	logger.error(`Missing property 'id' of the manifest`);
	`54`	`+ } else if (skillManifest.id.match(/^\d\|[^\w]/g) !== null) {`
	`55`	`+ // tslint:disable-next-line:max-line-length`
	`56`	+ logger.error(`The 'id' of the manifest contains some characters not allowed. Make sure the 'id' contains only letters, numbers and underscores, but doesn't start with number.`);
`54`	`57`	`}`
`55`	`58`	`if (!skillManifest.endpoint) {`
`56`	`59`	logger.error(`Missing property 'endpoint' of the manifest`);