POI returns no route for not covered areas (#1960) (#1993)

Author: xieofxie

skills/src/csharp/pointofinterestskill/pointofinterestskill/Dialogs/RouteDialog.cs

@@ -241,7 +241,7 @@ public async Task<DialogTurnResult> RouteToFindPointOfInterestBeforeRouteDialog(
 
                 if (cards.Count() == 0)
                 {
-                    var replyMessage = ResponseManager.GetResponse(POISharedResponses.NoLocationsFound);
+                    var replyMessage = ResponseManager.GetResponse(POISharedResponses.NoRouteFound);
                     await sc.Context.SendActivityAsync(replyMessage);
                 }
                 else if (cards.Count() == 1)

skills/src/csharp/pointofinterestskill/pointofinterestskill/Responses/Shared/POISharedResponses.cs

@@ -25,6 +25,7 @@ public class POISharedResponses : IResponseIdCollection
         public const string NoLocationsFound = "NoLocationsFound";
         public const string MultipleRoutesFound = "MultipleRoutesFound";
         public const string SingleRouteFound = "SingleRouteFound";
+        public const string NoRouteFound = "NoRouteFound";
         public const string PointOfInterestSelection = "PointOfInterestSelection";
         public const string CurrentLocationMultipleSelection = "CurrentLocationMultipleSelection";
         public const string CurrentLocationSingleSelection = "CurrentLocationSingleSelection";

skills/src/csharp/pointofinterestskill/pointofinterestskill/Responses/Shared/POISharedResponses.de.json

@@ -216,6 +216,15 @@
     ],
     "inputHint": "expectingInput"
   },
+  "NoRouteFound": {
+    "replies": [
+      {
+        "text": "Sorry, I didn't find any route.",
+        "speak": "Sorry, I didn't find any route."
+      }
+    ],
+    "inputHint": "acceptingInput"
+  },
   "PointOfInterestSelection": {
     "replies": [
       {

skills/src/csharp/pointofinterestskill/pointofinterestskill/Responses/Shared/POISharedResponses.es.json

@@ -226,6 +226,15 @@
     ],
     "inputHint": "expectingInput"
   },
+  "NoRouteFound": {
+    "inputHint": "acceptingInput",
+    "replies": [
+      {
+        "text": "对不起,我找不到任何路线。",
+        "speak": "对不起,我找不到任何路线。"
+      }
+    ]
+  },
   "CurrentLocationSingleSelection": {
     "replies": [
       {

skills/src/csharp/pointofinterestskill/pointofinterestskill/Responses/Shared/POISharedResponses.fr.json

@@ -265,9 +265,16 @@ void AddPoint(double longitude, double latitude)
         /// <returns>RouteDirections.</returns>
         private async Task<RouteDirections> GetRouteDirectionsAsync(string url)
         {
-            var response = await httpClient.GetStringAsync(url);
+            var response = await httpClient.GetAsync(url);
+
+            var apiResponse = new RouteDirections();
 
-            var apiResponse = JsonConvert.DeserializeObject<RouteDirections>(response);
+            // TODO when it returns 400 for uncovered areas, we return no route instead. For other unsuccessful codes, exception is thrown as usual
+            if (response.StatusCode != System.Net.HttpStatusCode.BadRequest)
+            {
+                response = response.EnsureSuccessStatusCode();
+                apiResponse = JsonConvert.DeserializeObject<RouteDirections>(await response.Content.ReadAsStringAsync());
+            }
 
             apiResponse.Provider = PointOfInterestModel.AzureMaps;