Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Commit a6b2b60

Browse files
authored
Merge pull request #3458 from microsoft/next
1.0.1 Release
2 parents c013d77 + 1b09e31 commit a6b2b60

File tree

65 files changed

+14920
-677
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+14920
-677
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ ASALocalRun/
361361
**/.deployment
362362
**/ComposerDialogs/generated
363363
**/ComposerDialogs/settings
364+
**/VirtualAssistant/generated
364365

365366
# Zip files
366367
*.7z

docs/_docs/skills/tutorials/create-skill/csharp/7-add-your-skill.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To add your new Skill to your assistant we provide the [botskills](https://www.n
2222
Run the following command from a command prompt **within the directory of your assistant/Bot**.
2323

2424
```bash
25-
botskills connect --remoteManifest "https://<YOUR_SKILL_NAME>.azurewebsites.net/manifest/manifest-1.1.json" --cs
25+
botskills connect --remoteManifest "https://<YOUR_SKILL_NAME>.azurewebsites.net/manifest/manifest-1.1.json" --cs --luisFolder "path-to-lu-folder"
2626
```
2727
Remember to re-publish your assistant to Azure after you’ve added a Skill unless you plan on testing locally only.
2828

docs/_docs/skills/tutorials/create-skill/typescript/6-add-your-skill.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To add your new Skill to your assistant we provide the [botskills](https://www.n
2222
Run the following command from a command prompt **within the directory of your assistant/Bot**.
2323

2424
```bash
25-
botskills connect --remoteManifest "https://<YOUR_SKILL_NAME>.azurewebsites.net/manifest/manifest-1.1.json" --ts
25+
botskills connect --remoteManifest "https://<YOUR_SKILL_NAME>.azurewebsites.net/manifest/manifest-1.1.json" --ts --luisFolder "path-to-lu-folder"
2626
```
2727

2828
Remember to re-publish your assistant to Azure after you’ve added a Skill unless you plan on testing locally only.

samples/csharp/assistants/enterprise-assistant/VirtualAssistantSample/Deployment/Scripts/publish.ps1

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,13 @@ if (-not $resourceGroup) {
5050
$resourceGroup = Read-Host "? Bot Resource Group"
5151
}
5252

53+
# Get path to csproj file
54+
$projFile = Get-ChildItem $projFolder `
55+
| Where-Object {$_.extension -eq ".csproj" } `
56+
| Select-Object -First 1
57+
5358
# Check for existing deployment files
5459
if (-not (Test-Path (Join-Path $projFolder '.deployment'))) {
55-
56-
# Get path to csproj file
57-
$projFile = Get-ChildItem $projFolder `
58-
| Where-Object {$_.extension -eq ".csproj" } `
59-
| Select-Object -First 1
60-
6160
# Add needed deployment files for az
6261
az bot prepare-deploy --lang Csharp --code-dir $projFolder --proj-file-path $projFile.name --output json | Out-Null
6362
}
@@ -70,7 +69,7 @@ if (Test-Path $zipPath) {
7069

7170
# Perform dotnet publish step ahead of zipping up
7271
$publishFolder = $(Join-Path $projFolder 'bin\Release\netcoreapp3.0')
73-
dotnet publish -c release -o $publishFolder -v q > $logFile
72+
dotnet publish $projFile -c release -o $publishFolder -v q > $logFile
7473

7574
if($?) {
7675
# Compress source code

samples/csharp/assistants/enterprise-assistant/VirtualAssistantSample/Deployment/Scripts/qna_functions.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function DeployKB ($name, $luFile, $qnaSubscriptionKey, $qnaEndpoint, $language,
2323

2424
while ($retryAttemptsRemaining -ge 0) {
2525
$bfconfig = (bf qnamaker:kb:create `
26-
--name $name `
26+
--name "$($name)_$($id)" `
2727
--subscriptionKey $qnaSubscriptionKey `
2828
--endpoint $qnaEndpoint `
2929
--in $(Join-Path $outFolder $outFile) | ConvertFrom-Json) 2>> $log

samples/csharp/assistants/hospitality-assistant/VirtualAssistantSample/Deployment/Scripts/publish.ps1

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,13 @@ if (-not $resourceGroup) {
5050
$resourceGroup = Read-Host "? Bot Resource Group"
5151
}
5252

53+
# Get path to csproj file
54+
$projFile = Get-ChildItem $projFolder `
55+
| Where-Object {$_.extension -eq ".csproj" } `
56+
| Select-Object -First 1
57+
5358
# Check for existing deployment files
5459
if (-not (Test-Path (Join-Path $projFolder '.deployment'))) {
55-
56-
# Get path to csproj file
57-
$projFile = Get-ChildItem $projFolder `
58-
| Where-Object {$_.extension -eq ".csproj" } `
59-
| Select-Object -First 1
60-
6160
# Add needed deployment files for az
6261
az bot prepare-deploy --lang Csharp --code-dir $projFolder --proj-file-path $projFile.name --output json | Out-Null
6362
}
@@ -70,7 +69,7 @@ if (Test-Path $zipPath) {
7069

7170
# Perform dotnet publish step ahead of zipping up
7271
$publishFolder = $(Join-Path $projFolder 'bin\Release\netcoreapp3.0')
73-
dotnet publish -c release -o $publishFolder -v q > $logFile
72+
dotnet publish $projFile -c release -o $publishFolder -v q > $logFile
7473

7574
if($?) {
7675
# Compress source code

samples/csharp/assistants/hospitality-assistant/VirtualAssistantSample/Deployment/Scripts/qna_functions.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function DeployKB ($name, $luFile, $qnaSubscriptionKey, $qnaEndpoint, $language,
2323

2424
while ($retryAttemptsRemaining -ge 0) {
2525
$bfconfig = (bf qnamaker:kb:create `
26-
--name $name `
26+
--name "$($name)_$($id)" `
2727
--subscriptionKey $qnaSubscriptionKey `
2828
--endpoint $qnaEndpoint `
2929
--in $(Join-Path $outFolder $outFile) | ConvertFrom-Json) 2>> $log

samples/csharp/assistants/virtual-assistant/VirtualAssistantSample/Deployment/Resources/template.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@
216216
"options": {
217217
"throughput": "[parameters('cosmosDbDatabaseThroughput')]"
218218
}
219-
}
219+
},
220+
"condition": "[parameters('useCosmosDb')]"
220221
},
221222
{
222223
"comments": "storage account",

samples/csharp/assistants/virtual-assistant/VirtualAssistantSample/Deployment/Scripts/deploy.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ if (-not $armLuisAuthoringRegion) {
210210
}
211211

212212
# Get timestamp
213-
$timestamp = Get-Date -f MMddyyyyHHmmss
213+
$timestamp = Get-Date -Format MMddyyyyHHmmss
214214

215215
# Create resource group
216216
Write-Host "> Creating resource group ..." -NoNewline

samples/csharp/assistants/virtual-assistant/VirtualAssistantSample/Deployment/Scripts/publish.ps1

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,13 @@ if (-not $resourceGroup) {
5050
$resourceGroup = Read-Host "? Bot Resource Group"
5151
}
5252

53+
# Get path to csproj file
54+
$projFile = Get-ChildItem $projFolder `
55+
| Where-Object {$_.extension -eq ".csproj" } `
56+
| Select-Object -First 1
57+
5358
# Check for existing deployment files
5459
if (-not (Test-Path (Join-Path $projFolder '.deployment'))) {
55-
56-
# Get path to csproj file
57-
$projFile = Get-ChildItem $projFolder `
58-
| Where-Object {$_.extension -eq ".csproj" } `
59-
| Select-Object -First 1
60-
6160
# Add needed deployment files for az
6261
az bot prepare-deploy --lang Csharp --code-dir $projFolder --proj-file-path $projFile.name --output json | Out-Null
6362
}
@@ -70,7 +69,7 @@ if (Test-Path $zipPath) {
7069

7170
# Perform dotnet publish step ahead of zipping up
7271
$publishFolder = $(Join-Path $projFolder 'bin\release\netcoreapp3.0')
73-
dotnet publish -c release -o $publishFolder -v q > $logFile
72+
dotnet publish $projFile -c release -o $publishFolder -v q > $logFile
7473

7574
if($?) {
7675
# Compress source code

0 commit comments

Comments
 (0)