Skip to content

Commit 8fa85ee

Browse files
Fix package.json and bump Nodejs LTS version (#32)
1 parent 4c84466 commit 8fa85ee

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
FROM ghcr.io/microsoft/ccf/app/dev/virtual:ccf-5.0.0
22

3-
RUN curl -fsSL https://deb.nodesource.com/setup_16.x | sudo -E bash - && sudo apt-get install -y nodejs
3+
RUN curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash - && sudo apt-get install -y nodejs

.github/workflows/ci.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,16 @@ jobs:
3131
run: mkdir -p build && cd build && CC="$(which clang-15)" CXX="$(which clang++-15)" cmake -GNinja -DCOMPILE_TARGET=virtual .. && ninja
3232
working-directory: cpp
3333

34+
build-js-app:
35+
steps:
36+
- uses: actions/checkout@v4
37+
- uses: actions/setup-node@v4
38+
with:
39+
node-version: 18
40+
- name: Build js app
41+
run: npm install && npm run build
42+
working-directory: js
43+
3444
build-containers:
3545
runs-on: ubuntu-20.04
3646
container: ghcr.io/microsoft/ccf/app/dev/sgx:ccf-5.0.0

js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"devDependencies": {
1616
"@rollup/plugin-commonjs": "^26.0.1",
17-
"@rollup/plugin-node-resolve": "^15.2
17+
"@rollup/plugin-node-resolve": "^15.2",
1818
"@rollup/plugin-typescript": "^11.1.6",
1919
"del-cli": "^5.1.0",
2020
"rollup": "^2.41.0",

0 commit comments

Comments
 (0)