Skip to content

Commit 0307860

Browse files
committed
Reinstate private markers on additional predicates
1 parent 312508e commit 0307860

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

java/ql/lib/semmle/code/java/security/UnsafeDeserializationQuery.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ private module SafeKryoConfig implements DataFlow::ConfigSig {
7575
* Holds when a functional expression is used to create a `KryoPool.Builder`.
7676
* Eg. `new KryoPool.Builder(() -> new Kryo())`
7777
*/
78-
additional predicate stepKryoPoolBuilderFactoryArgToConstructor(
78+
private predicate stepKryoPoolBuilderFactoryArgToConstructor(
7979
DataFlow::Node node1, DataFlow::Node node2
8080
) {
8181
exists(ConstructorCall cc, FunctionalExpr fe |
@@ -90,7 +90,7 @@ private module SafeKryoConfig implements DataFlow::ConfigSig {
9090
* Holds when a `KryoPool.run` is called to use a `Kryo` instance.
9191
* Eg. `pool.run(kryo -> ...)`
9292
*/
93-
additional predicate stepKryoPoolRunMethodAccessQualifierToFunctionalArgument(
93+
private predicate stepKryoPoolRunMethodAccessQualifierToFunctionalArgument(
9494
DataFlow::Node node1, DataFlow::Node node2
9595
) {
9696
exists(MethodAccess ma |
@@ -103,7 +103,7 @@ private module SafeKryoConfig implements DataFlow::ConfigSig {
103103
/**
104104
* Holds when a `KryoPool.Builder` method is called fluently.
105105
*/
106-
additional predicate stepKryoPoolBuilderChainMethod(DataFlow::Node node1, DataFlow::Node node2) {
106+
private predicate stepKryoPoolBuilderChainMethod(DataFlow::Node node1, DataFlow::Node node2) {
107107
exists(MethodAccess ma |
108108
ma.getMethod() instanceof KryoPoolBuilderMethod and
109109
ma = node2.asExpr() and
@@ -114,7 +114,7 @@ private module SafeKryoConfig implements DataFlow::ConfigSig {
114114
/**
115115
* Holds when a `KryoPool.borrow` method is called.
116116
*/
117-
additional predicate stepKryoPoolBorrowMethod(DataFlow::Node node1, DataFlow::Node node2) {
117+
private predicate stepKryoPoolBorrowMethod(DataFlow::Node node1, DataFlow::Node node2) {
118118
exists(MethodAccess ma |
119119
ma.getMethod() =
120120
any(Method m | m.getDeclaringType() instanceof KryoPool and m.hasName("borrow")) and

0 commit comments

Comments
 (0)