Skip to content

Commit 047494d

Browse files
geoffw0geoffw0
committed
Swift: Bank account numbers are a credential now, I guess they don't need to be private data as well.
1 parent 252b72b commit 047494d

File tree

2 files changed

+41
-41
lines changed

2 files changed

+41
-41
lines changed

‎swift/ql/lib/codeql/swift/security/SensitiveExprs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class SensitivePrivateInfo extends SensitiveDataType, TPrivateInfo {
5454
// Geographic location - where the user is (or was)
5555
"latitude|longitude|" +
5656
// Financial data - such as credit card numbers, salary, bank accounts, and debts
57-
"credit.?card|debit.?card|salary|bank.?account|" +
57+
"credit.?card|debit.?card|salary|" +
5858
// Communications - e-mail addresses, private e-mail messages, SMS text messages, chat logs, etc.
5959
"email|" +
6060
// Health - medical conditions, insurance status, prescription records

‎swift/ql/test/query-tests/Security/CWE-311/SensitiveExprs.expected

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -12,46 +12,46 @@
1212
| testAlamofire.swift:205:62:205:62 | password | label:password, type:credential |
1313
| testAlamofire.swift:213:48:213:48 | username | label:username, type:credential |
1414
| testAlamofire.swift:213:65:213:65 | password | label:password, type:credential |
15-
| testCoreData2.swift:37:16:37:16 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
16-
| testCoreData2.swift:38:2:38:6 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
17-
| testCoreData2.swift:39:2:39:6 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
18-
| testCoreData2.swift:39:28:39:28 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
19-
| testCoreData2.swift:40:2:40:6 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential, type:private information |
20-
| testCoreData2.swift:41:2:41:6 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential, type:private information |
21-
| testCoreData2.swift:41:29:41:29 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
22-
| testCoreData2.swift:42:2:42:6 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential, type:private information |
23-
| testCoreData2.swift:43:2:43:6 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential, type:private information |
24-
| testCoreData2.swift:43:35:43:35 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
25-
| testCoreData2.swift:46:22:46:22 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
26-
| testCoreData2.swift:47:2:47:12 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
27-
| testCoreData2.swift:48:2:48:12 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
28-
| testCoreData2.swift:48:34:48:34 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
29-
| testCoreData2.swift:49:2:49:12 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential, type:private information |
30-
| testCoreData2.swift:50:2:50:12 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential, type:private information |
31-
| testCoreData2.swift:50:35:50:35 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
32-
| testCoreData2.swift:51:2:51:12 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential, type:private information |
33-
| testCoreData2.swift:52:2:52:12 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential, type:private information |
34-
| testCoreData2.swift:52:41:52:41 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
35-
| testCoreData2.swift:57:3:57:7 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
36-
| testCoreData2.swift:57:29:57:29 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
37-
| testCoreData2.swift:60:4:60:8 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
38-
| testCoreData2.swift:60:30:60:30 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
39-
| testCoreData2.swift:62:4:62:8 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
40-
| testCoreData2.swift:62:30:62:30 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
41-
| testCoreData2.swift:65:3:65:7 | .myBankAccountNumber | label:myBankAccountNumber, type:credential, type:private information |
42-
| testCoreData2.swift:65:29:65:29 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
43-
| testCoreData2.swift:79:18:79:28 | .bankAccountNo | label:bankAccountNo, type:credential, type:private information |
44-
| testCoreData2.swift:80:18:80:28 | .bankAccountNo2 | label:bankAccountNo2, type:credential, type:private information |
45-
| testCoreData2.swift:82:18:82:18 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
46-
| testCoreData2.swift:83:18:83:18 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
47-
| testCoreData2.swift:84:18:84:18 | bankAccountNo2 | label:bankAccountNo2, type:credential, type:private information |
48-
| testCoreData2.swift:85:18:85:18 | bankAccountNo2 | label:bankAccountNo2, type:credential, type:private information |
49-
| testCoreData2.swift:87:22:87:32 | .bankAccountNo | label:bankAccountNo, type:credential, type:private information |
50-
| testCoreData2.swift:88:22:88:22 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
51-
| testCoreData2.swift:89:22:89:22 | bankAccountNo2 | label:bankAccountNo2, type:credential, type:private information |
52-
| testCoreData2.swift:91:10:91:10 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
53-
| testCoreData2.swift:95:10:95:10 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
54-
| testCoreData2.swift:101:10:101:10 | bankAccountNo | label:bankAccountNo, type:credential, type:private information |
15+
| testCoreData2.swift:37:16:37:16 | bankAccountNo | label:bankAccountNo, type:credential |
16+
| testCoreData2.swift:38:2:38:6 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
17+
| testCoreData2.swift:39:2:39:6 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
18+
| testCoreData2.swift:39:28:39:28 | bankAccountNo | label:bankAccountNo, type:credential |
19+
| testCoreData2.swift:40:2:40:6 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential |
20+
| testCoreData2.swift:41:2:41:6 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential |
21+
| testCoreData2.swift:41:29:41:29 | bankAccountNo | label:bankAccountNo, type:credential |
22+
| testCoreData2.swift:42:2:42:6 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential |
23+
| testCoreData2.swift:43:2:43:6 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential |
24+
| testCoreData2.swift:43:35:43:35 | bankAccountNo | label:bankAccountNo, type:credential |
25+
| testCoreData2.swift:46:22:46:22 | bankAccountNo | label:bankAccountNo, type:credential |
26+
| testCoreData2.swift:47:2:47:12 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
27+
| testCoreData2.swift:48:2:48:12 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
28+
| testCoreData2.swift:48:34:48:34 | bankAccountNo | label:bankAccountNo, type:credential |
29+
| testCoreData2.swift:49:2:49:12 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential |
30+
| testCoreData2.swift:50:2:50:12 | .myBankAccountNumber2 | label:myBankAccountNumber2, type:credential |
31+
| testCoreData2.swift:50:35:50:35 | bankAccountNo | label:bankAccountNo, type:credential |
32+
| testCoreData2.swift:51:2:51:12 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential |
33+
| testCoreData2.swift:52:2:52:12 | .notStoredBankAccountNumber | label:notStoredBankAccountNumber, type:credential |
34+
| testCoreData2.swift:52:41:52:41 | bankAccountNo | label:bankAccountNo, type:credential |
35+
| testCoreData2.swift:57:3:57:7 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
36+
| testCoreData2.swift:57:29:57:29 | bankAccountNo | label:bankAccountNo, type:credential |
37+
| testCoreData2.swift:60:4:60:8 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
38+
| testCoreData2.swift:60:30:60:30 | bankAccountNo | label:bankAccountNo, type:credential |
39+
| testCoreData2.swift:62:4:62:8 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
40+
| testCoreData2.swift:62:30:62:30 | bankAccountNo | label:bankAccountNo, type:credential |
41+
| testCoreData2.swift:65:3:65:7 | .myBankAccountNumber | label:myBankAccountNumber, type:credential |
42+
| testCoreData2.swift:65:29:65:29 | bankAccountNo | label:bankAccountNo, type:credential |
43+
| testCoreData2.swift:79:18:79:28 | .bankAccountNo | label:bankAccountNo, type:credential |
44+
| testCoreData2.swift:80:18:80:28 | .bankAccountNo2 | label:bankAccountNo2, type:credential |
45+
| testCoreData2.swift:82:18:82:18 | bankAccountNo | label:bankAccountNo, type:credential |
46+
| testCoreData2.swift:83:18:83:18 | bankAccountNo | label:bankAccountNo, type:credential |
47+
| testCoreData2.swift:84:18:84:18 | bankAccountNo2 | label:bankAccountNo2, type:credential |
48+
| testCoreData2.swift:85:18:85:18 | bankAccountNo2 | label:bankAccountNo2, type:credential |
49+
| testCoreData2.swift:87:22:87:32 | .bankAccountNo | label:bankAccountNo, type:credential |
50+
| testCoreData2.swift:88:22:88:22 | bankAccountNo | label:bankAccountNo, type:credential |
51+
| testCoreData2.swift:89:22:89:22 | bankAccountNo2 | label:bankAccountNo2, type:credential |
52+
| testCoreData2.swift:91:10:91:10 | bankAccountNo | label:bankAccountNo, type:credential |
53+
| testCoreData2.swift:95:10:95:10 | bankAccountNo | label:bankAccountNo, type:credential |
54+
| testCoreData2.swift:101:10:101:10 | bankAccountNo | label:bankAccountNo, type:credential |
5555
| testCoreData.swift:48:15:48:15 | password | label:password, type:credential |
5656
| testCoreData.swift:51:24:51:24 | password | label:password, type:credential |
5757
| testCoreData.swift:58:15:58:15 | password | label:password, type:credential |

0 commit comments

Comments
 (0)