Skip to content

Commit 049c070

Browse files
Tag quality queries that are high precision and dont use pointsto
1 parent b62a6db commit 049c070

File tree

8 files changed

+21
-15
lines changed

8 files changed

+21
-15
lines changed

python/ql/src/Exceptions/CatchingBaseException.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* @name Except block handles 'BaseException'
33
* @description Handling 'BaseException' means that system exits and keyboard interrupts may be mis-handled.
44
* @kind problem
5-
* @tags reliability
6-
* readability
7-
* convention
5+
* @tags quality
6+
* reliability
7+
* error-handling
88
* external/cwe/cwe-396
99
* @problem.severity recommendation
1010
* @sub-severity high

python/ql/src/Exceptions/EmptyExcept.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
* @name Empty except
33
* @description Except doesn't do anything and has no comment
44
* @kind problem
5-
* @tags reliability
6-
* maintainability
5+
* @tags quality
6+
* reliability
7+
* error-handling
78
* external/cwe/cwe-390
89
* @problem.severity recommendation
910
* @sub-severity high

python/ql/src/Expressions/CallToSuperWrongClass.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* @name First argument to super() is not enclosing class
33
* @description Calling super with something other than the enclosing class may cause incorrect object initialization.
44
* @kind problem
5-
* @tags reliability
6-
* maintainability
7-
* convention
5+
* @tags quality
6+
* reliability
7+
* correctness
88
* external/cwe/cwe-687
99
* @problem.severity error
1010
* @sub-severity low

python/ql/src/Expressions/ExplicitCallToDel.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name `__del__` is called explicitly
33
* @description The `__del__` special method is called by the virtual machine when an object is being finalized. It should not be called explicitly.
44
* @kind problem
5-
* @tags reliability
5+
* @tags quality
6+
* reliability
67
* correctness
78
* @problem.severity warning
89
* @sub-severity low

python/ql/src/Expressions/IncorrectComparisonUsingIs.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name Comparison using is when operands support `__eq__`
33
* @description Comparison using 'is' when equivalence is not the same as identity
44
* @kind problem
5-
* @tags reliability
5+
* @tags quality
6+
* reliability
67
* correctness
78
* @problem.severity warning
89
* @sub-severity low

python/ql/src/Functions/ConsistentReturns.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
* @name Explicit returns mixed with implicit (fall through) returns
33
* @description Mixing implicit and explicit returns indicates a likely error as implicit returns always return 'None'.
44
* @kind problem
5-
* @tags reliability
6-
* maintainability
5+
* @tags quality
6+
* reliability
7+
* correctness
78
* @problem.severity recommendation
89
* @sub-severity high
910
* @precision high

python/ql/src/Functions/InitIsGenerator.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name `__init__` method is a generator
33
* @description `__init__` method is a generator.
44
* @kind problem
5-
* @tags reliability
5+
* @tags quality
6+
* reliability
67
* correctness
78
* @problem.severity error
89
* @sub-severity low

python/ql/src/Functions/ModificationOfParameterWithDefault.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
* @description Modifying the default value of a parameter can lead to unexpected
44
* results.
55
* @kind path-problem
6-
* @tags reliability
7-
* maintainability
6+
* @tags quality
7+
* reliability
8+
* correctness
89
* @problem.severity error
910
* @sub-severity low
1011
* @precision high

0 commit comments

Comments
 (0)