Skip to content

Commit 06aefe0

Browse files
alexrfordasgerf
andauthored
Update ruby/ql/lib/codeql/ruby/frameworks/rack/internal/App.qll
Co-authored-by: Asger F <[email protected]>
1 parent 08784d2 commit 06aefe0

File tree

1 file changed

+4
-6
lines changed
  • ruby/ql/lib/codeql/ruby/frameworks/rack/internal

1 file changed

+4
-6
lines changed

ruby/ql/lib/codeql/ruby/frameworks/rack/internal/App.qll

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,10 @@ module App {
9191
/** A read of the query string via `env['QUERY_STRING']`. */
9292
private class EnvQueryStringRead extends Http::Server::RequestInputAccess::Range {
9393
EnvQueryStringRead() {
94-
exists(RequestHandler handler, DataFlow::ParameterNode env, ConstantValue key |
95-
handler.getEnv() = env
96-
|
97-
this = env.getAnElementRead(key) and
98-
key.isStringlikeValue("QUERY_STRING")
99-
)
94+
this =
95+
any(RequestHandler h)
96+
.getEnv()
97+
.getAnElementRead(ConstantValue::fromStringlikeValue("QUERY_STRING"))
10098
}
10199

102100
override string getSourceType() { result = "Rack env" }

0 commit comments

Comments
 (0)